Re: [Intel-gfx] [PATCH 05/11] drm/i915: refactor some crtc code out of intel display.

2020-12-16 Thread Ville Syrjälä
On Wed, Dec 16, 2020 at 12:03:37PM +0200, Jani Nikula wrote: > On Fri, 11 Dec 2020, Dave Airlie wrote: > > From: Dave Airlie > > > > There may be more crtc code that can be pulled out, but this > > is a good start. > > > > RFC: maybe call the new file something different > > I checked this is ju

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix mismatch between misplaced vma check and vma insert (rev2)

2020-12-16 Thread Patchwork
== Series Details == Series: drm/i915: Fix mismatch between misplaced vma check and vma insert (rev2) URL : https://patchwork.freedesktop.org/series/84975/ State : success == Summary == CI Bug Log - changes from CI_DRM_9490 -> Patchwork_19154 ===

[Intel-gfx] [PATCH v6 15/15] drm/i915/display: Let PCON convert from RGB to YUV if it can

2020-12-16 Thread Ankit Nautiyal
If PCON has capability to convert RGB->YUV colorspace and also to 444->420 downsampling then for any YUV420 only mode, we can let the PCON do all the conversion. v2: As suggested by Uma Shankar, considered case for colorspace BT709 and BT2020, and default to BT609. Also appended dir 'display' in c

[Intel-gfx] [PATCH v4 11/11] drm/i915: split fb scalable checks into g4x and skl versions

2020-12-16 Thread Jani Nikula
From: Dave Airlie This just cleans these up a bit. Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_gen9_plane.c | 4 ++-- drivers/gpu/drm/i915/display/intel_sprite.c | 7 +++ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/dr

[Intel-gfx] [PATCH v4 10/11] drm/i915: move pipe update code into crtc.

2020-12-16 Thread Jani Nikula
From: Dave Airlie Daniel suggested this should move here. Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_crtc.c | 230 drivers/gpu/drm/i915/display/intel_sprite.c | 228 --- 2 files changed, 230 insertions(+)

[Intel-gfx] [PATCH v4 08/11] drm/i915: migrate hsw fdi code to new file.

2020-12-16 Thread Jani Nikula
From: Dave Airlie Daniel asked for this, but it's a bit messy and I'm not sure how best to clean it up yet. Signed-off-by: Dave Airlie [Jani: also moved fdi buf trans to intel_fdi.c.] Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_crt.c | 1 + drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH v4 07/11] drm/i915: split fdi code out from intel_display.c

2020-12-16 Thread Jani Nikula
From: Dave Airlie This just refactors out the fdi code to a separate file. Signed-off-by: Dave Airlie [Jani: cleaned up intel_fdi.h a bit.] Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_display.c | 685 +--

[Intel-gfx] [PATCH v4 06/11] drm/i915: refactor pll code out into intel_dpll.c

2020-12-16 Thread Jani Nikula
From: Dave Airlie This pulls a large chunk of the pll calculation code out of intel_display.c to a new file. One function makes sense to be an inline, otherwise this is pretty much a straight copy cover. Also all the remaining hooks for g45 and older end up the same now. Signed-off-by: Dave Air

[Intel-gfx] [PATCH v4 05/11] drm/i915: refactor some crtc code out of intel display.

2020-12-16 Thread Jani Nikula
From: Dave Airlie There may be more crtc code that can be pulled out, but this is a good start. Signed-off-by: Dave Airlie [Jani: cleaned up intel_crtc.h a bit.] Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/display/intel_crtc.c|

[Intel-gfx] [PATCH v4 04/11] drm/i915: refactor cursor code out of i915_display.c

2020-12-16 Thread Jani Nikula
From: Dave Airlie This file is a monster, let's start simple, the cursor plane code seems pretty standalone, and splits out easily enough. Reviewed-by: Ville Syrjälä Signed-off-by: Dave Airlie [Jani: cleaned up intel_cursor.h a bit.] Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefi

[Intel-gfx] [PATCH v4 03/11] drm/i915/display: fix misused comma

2020-12-16 Thread Jani Nikula
From: Dave Airlie There is no need for a comma use here. Reviewed-by: Ville Syrjälä Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_

[Intel-gfx] [PATCH v4 02/11] drm/i915/display: move to_intel_frontbuffer to header

2020-12-16 Thread Jani Nikula
From: Dave Airlie This will be used for some refactoring in other files, so move it first. Signed-off-by: Dave Airlie Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 6 -- drivers/gpu/drm/i915/display/intel_display_types.h |

[Intel-gfx] [PATCH v4 01/11] drm/i915/display: move needs_modeset to an inline in header

2020-12-16 Thread Jani Nikula
From: Dave Airlie This function is going to be used in a later change, so clean it up first before moving it. Reviewed-by: Ville Syrjälä Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 78 +-- .../drm/i915/display/inte

[Intel-gfx] [PATCH v4 00/11] drm/i915: refactor intel display

2020-12-16 Thread Jani Nikula
This is Dave's intel_display.c refactoring series [1] with some minor issues addressed, to get CI results among other things. I've reviewed and fixed any remaining minor issues I spotted in patches 1-8. I'm aware there may be things to improve, but I think this is overall forward progress and clea

Re: [Intel-gfx] [PATCH] drm/i915/display: Prevent double YUV range correction on HDR planes

2020-12-16 Thread Ville Syrjälä
On Wed, Dec 16, 2020 at 01:46:58AM -0500, Andres Calderon Jaramillo wrote: > On Tue, Dec 15, 2020 at 3:13 PM Ville Syrjälä > wrote: > > > > On Tue, Dec 15, 2020 at 03:06:30PM -0500, Andres Calderon Jaramillo wrote: > > > On Tue, Dec 15, 2020 at 1:01 PM Ville Syrjälä > > > wrote: > > > > > > > > O

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix mismatch between misplaced vma check and vma insert (rev2)

2020-12-16 Thread Patchwork
== Series Details == Series: drm/i915: Fix mismatch between misplaced vma check and vma insert (rev2) URL : https://patchwork.freedesktop.org/series/84975/ State : warning == Summary == $ dim checkpatch origin/drm-tip efabc7d5411c drm/i915: Fix mismatch between misplaced vma check and vma inse

Re: [Intel-gfx] [PATCH 08/11] drm/i915: migrate hsw fdi code to new file.

2020-12-16 Thread Jani Nikula
On Fri, 11 Dec 2020, Dave Airlie wrote: > From: Dave Airlie > > Daniel asked for this, but it's a bit messy and I'm not sure > how best to clean it up yet. Cleaned it up some locally by moving both hsw and bdw buf trans tables to intel_fdi.c, and adding a function to get them. Surely this could

Re: [Intel-gfx] [PATCH] drm/i915/display: Prevent double YUV range correction on HDR planes

2020-12-16 Thread Andres Calderon Jaramillo
On Tue, Dec 15, 2020 at 3:13 PM Ville Syrjälä wrote: > > On Tue, Dec 15, 2020 at 03:06:30PM -0500, Andres Calderon Jaramillo wrote: > > On Tue, Dec 15, 2020 at 1:01 PM Ville Syrjälä > > wrote: > > > > > > On Mon, Dec 14, 2020 at 10:57:03PM +, Shankar, Uma wrote: > > > > > > > > > > > > >

Re: [Intel-gfx] [PATCH 07/11] drm/i915: split fdi code out from intel_display.c

2020-12-16 Thread Jani Nikula
On Fri, 11 Dec 2020, Dave Airlie wrote: > From: Dave Airlie > > This just refactors out the fdi code to a separate file. LGTM, save for another header fix that I made locally. ;) See CONFIG_DRM_I915_WERROR=y for what we do in CI to keep stuff clean. BR, Jani. > > Signed-off-by: Dave Airlie >

Re: [Intel-gfx] [PATCH 06/11] drm/i915: refactor pll code out into intel_dpll.c

2020-12-16 Thread Jani Nikula
On Fri, 11 Dec 2020, Dave Airlie wrote: > From: Dave Airlie > > This pulls a large chunk of the pll calculation code out of > intel_display.c to a new file. > > One function makse sense to be an inline, otherwise this > is pretty much a straight copy cover. also all the > remaining hooks for g45

Re: [Intel-gfx] [PATCH v6 2/5] drm/i915/display/psr: Use plane damage clips to calculate damaged area

2020-12-16 Thread Mun, Gwan-gyeong
On Tue, 2020-12-15 at 05:14 -0800, Souza, Jose wrote: > On Tue, 2020-12-15 at 13:02 +, Mun, Gwan-gyeong wrote: > > On Mon, 2020-12-14 at 09:49 -0800, José Roberto de Souza wrote: > > > Now using plane damage clips property to calcualte the damaged > > > area. > > > Selective fetch only supports

Re: [Intel-gfx] [PATCH 1/4] dma-buf: Remove kmap kerneldoc vestiges

2020-12-16 Thread Daniel Vetter
On Tue, Dec 15, 2020 at 03:18:49PM +0100, Christian König wrote: > Am 14.12.20 um 17:01 schrieb Daniel Vetter: > > On Mon, Dec 14, 2020 at 11:33:10AM +0100, Christian König wrote: > > > Am 11.12.20 um 16:58 schrieb Daniel Vetter: > > > > Also try to clarify a bit when dma_buf_begin/end_cpu_access s

Re: [Intel-gfx] [PATCH 04/11] drm/i915: refactor cursor code out of i915_display.c

2020-12-16 Thread Jani Nikula
On Fri, 11 Dec 2020, Dave Airlie wrote: > From: Dave Airlie > > This file is a monster, let's start simple, the cursor plane code > seems pretty standalone, and splits out easily enough. I cleaned up intel_cursor.h a bit locally, but the code movement checks out. BR, Jani. > > Reviewed-by: Vil

Re: [Intel-gfx] [PATCH 05/11] drm/i915: refactor some crtc code out of intel display.

2020-12-16 Thread Jani Nikula
On Fri, 11 Dec 2020, Dave Airlie wrote: > From: Dave Airlie > > There may be more crtc code that can be pulled out, but this > is a good start. > > RFC: maybe call the new file something different I checked this is just code movement. I did clean up intel_crtc.h locally a bit though. (I'll proba

Re: [Intel-gfx] [PATCH 14/65] drm/rcar-du: Annotate dma-fence critical section in commit path

2020-12-16 Thread Daniel Vetter
On Wed, Dec 16, 2020 at 2:29 AM Laurent Pinchart wrote: > > Hi Daniel, > > Thank you for the patch. > > On Fri, Oct 23, 2020 at 02:21:25PM +0200, Daniel Vetter wrote: > > Ends right after drm_atomic_helper_commit_hw_done(), absolutely > > nothing fancy going on here. > > > > Signed-off-by: Daniel

[Intel-gfx] [PATCH v6 2/2] drm/i915/display: Support Multiple Transcoders' PSR status on debugfs

2020-12-16 Thread Gwan-gyeong Mun
In order to support the PSR state of each transcoder, it adds i915_psr_status to sub-directory of each transcoder. v2: Change using of Symbolic permissions 'S_IRUGO' to using of octal permissions '0444' v5: Addressed JJani Nikula's review comments - Remove checking of Gen12 for i915_psr_statu

[Intel-gfx] [PATCH v6 1/2] drm/i915/display: Support PSR Multiple Transcoders

2020-12-16 Thread Gwan-gyeong Mun
It is a preliminary work for supporting multiple EDP PSR and DP PanelReplay. And it refactors singleton PSR to Multi Transcoder supportable PSR. And this moves and renames the i915_psr structure of drm_i915_private's to intel_dp's intel_psr structure. It also causes changes in PSR interrupt handlin

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/2] i915/gem_softpin: Check full placement control under full-ppgtt

2020-12-16 Thread Chris Wilson
Quoting Matthew Auld (2020-12-16 09:31:41) > On Tue, 15 Dec 2020 at 21:07, Chris Wilson wrote: > > > > With full-ppgtt, userspacew has complete control over their GTT. Verify > > that we can place an object at the very beginning and the very end of > > our GTT. > > > > Signed-off-by: Chris Wilson

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/2] i915/gem_softpin: Check full placement control under full-ppgtt

2020-12-16 Thread Matthew Auld
On Tue, 15 Dec 2020 at 21:07, Chris Wilson wrote: > > With full-ppgtt, userspacew has complete control over their GTT. Verify > that we can place an object at the very beginning and the very end of > our GTT. > > Signed-off-by: Chris Wilson > --- > tests/i915/gem_softpin.c | 45 +

[Intel-gfx] [CI] drm/i915: Fix mismatch between misplaced vma check and vma insert

2020-12-16 Thread Chris Wilson
When inserting a VMA, we restrict the placement to the low 4G unless the caller opts into using the full range. This was done to allow usersapce the opportunity to transition slowly from a 32b address space, and to avoid breaking inherent 32b assumptions of some commands. However, for insert we li

[Intel-gfx] ✓ Fi.CI.IGT: success for Add support for DP-HDMI2.1 PCON (rev7)

2020-12-16 Thread Patchwork
== Series Details == Series: Add support for DP-HDMI2.1 PCON (rev7) URL : https://patchwork.freedesktop.org/series/82098/ State : success == Summary == CI Bug Log - changes from CI_DRM_9489_full -> Patchwork_19153_full Summary --- **

Re: [Intel-gfx] [PATCH 1/2] i915/perf: Move gen specific OA formats to single array

2020-12-16 Thread Tvrtko Ursulin
On 15/12/2020 21:49, Umesh Nerlige Ramappa wrote: Variations in OA formats in the different gens has led to creation of several sparse arrays to store the formats. Move oa formats into a single array and add the supported range of platforms for the oa formats. Signed-off-by: Umesh Nerlige Ram

Re: [Intel-gfx] [PATCH] drm/i915: Fix mismatch between misplaced vma check and vma insert

2020-12-16 Thread Matthew Auld
On Wed, 16 Dec 2020 at 08:43, Chris Wilson wrote: > > Quoting Tang, CQ (2020-12-16 00:51:21) > > > > > > > -Original Message- > > > From: Chris Wilson > > > Sent: Tuesday, December 15, 2020 2:02 PM > > > To: Tang, CQ ; intel-gfx@lists.freedesktop.org > > > Cc: stable@ > > > Subject: Re:

Re: [Intel-gfx] [PATCH] drm/i915: Fix mismatch between misplaced vma check and vma insert

2020-12-16 Thread Chris Wilson
Quoting Tang, CQ (2020-12-16 00:51:21) > > > > -Original Message- > > From: Chris Wilson > > Sent: Tuesday, December 15, 2020 2:02 PM > > To: Tang, CQ ; intel-gfx@lists.freedesktop.org > > Cc: stable@ > > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix mismatch between misplaced > > vma

Re: [Intel-gfx] [PATCH 1/2] i915/perf: Move gen specific OA formats to single array

2020-12-16 Thread Lionel Landwerlin
On 15/12/2020 23:49, Umesh Nerlige Ramappa wrote: Variations in OA formats in the different gens has led to creation of several sparse arrays to store the formats. Move oa formats into a single array and add the supported range of platforms for the oa formats. Signed-off-by: Umesh Nerlige Ramap

<    1   2