Re: [Intel-gfx] [PATCH] RFC: dma-buf: Require VM_SPECIAL vma for mmap

2021-02-05 Thread Christian König
Am 04.02.21 um 19:38 schrieb Jason Gunthorpe: On Thu, Feb 04, 2021 at 06:16:27PM +0100, Daniel Vetter wrote: On Thu, Feb 4, 2021 at 5:13 PM Jason Gunthorpe wrote: On Wed, Feb 03, 2021 at 10:19:48PM +0100, Daniel Vetter wrote: tldr; DMA buffers aren't normal memory, expecting that you can use

Re: [Intel-gfx] [PATCH] drm/i915/debugfs: HDCP capability enc NULL check

2021-02-05 Thread Gupta, Anshuman
> -Original Message- > From: Imre Deak > Sent: Thursday, February 4, 2021 11:58 PM > To: Gupta, Anshuman > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/debugfs: HDCP capability enc NULL > check > > On Fri, Jan 29, 2021 at 01:30:43PM +0530, Anshuman G

Re: [Intel-gfx] [PATCH] RFC: dma-buf: Require VM_SPECIAL vma for mmap

2021-02-05 Thread Daniel Vetter
On Thu, Feb 4, 2021 at 9:59 PM Jason Gunthorpe wrote: > > On Thu, Feb 04, 2021 at 09:19:57PM +0100, Daniel Vetter wrote: > > On Thu, Feb 4, 2021 at 9:09 PM Jason Gunthorpe wrote: > > > > > > On Thu, Feb 04, 2021 at 08:59:59PM +0100, Daniel Vetter wrote: > > > > > > > So I think just checking for

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/2] drm/i915/selftests: Restore previous heartbeat interval

2021-02-05 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/selftests: Restore previous heartbeat interval URL : https://patchwork.freedesktop.org/series/86727/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9733_full -> Patchwork_19596_full ===

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdcp: Show connector hdcp capability

2021-02-05 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Show connector hdcp capability URL : https://patchwork.freedesktop.org/series/86740/ State : success == Summary == CI Bug Log - changes from CI_DRM_9736 -> Patchwork_19601 Summary --- **SUC

Re: [Intel-gfx] [PATCH 30/57] drm/i915: Move timeslicing flag to scheduler

2021-02-05 Thread Tvrtko Ursulin
On 04/02/2021 16:11, Chris Wilson wrote: Quoting Tvrtko Ursulin (2021-02-04 15:18:31) On 01/02/2021 08:56, Chris Wilson wrote: Whether a scheduler chooses to implement timeslicing is up to it, and not an underlying property of the HW engine. The scheduler does depend on the HW supporting pre

[Intel-gfx] [PATCH i-g-t] i915/module_load: Tidy up gem_exec_store workalike

2021-02-05 Thread Chris Wilson
We emit a store on each GPU after loading the module to confirm the basic liveness of command submission. Trim away some of the chaff. Signed-off-by: Chris Wilson Cc: Ramalingam C --- tests/i915/i915_module_load.c | 146 ++ 1 file changed, 58 insertions(+), 88 de

[Intel-gfx] [PATCH v2 1/2] drm/i915: cleanup the region class/instance encoding

2021-02-05 Thread Matthew Auld
Get rid of the strange REGION_MAP encoding stuff and just use an explicit class/instance pair for each region. This better matches our future uAPI where all queryable regions are identified with a u16 class and u16 instance. v2: fix whitespace Signed-off-by: Matthew Auld Reviewed-by: Chris Wilso

[Intel-gfx] [PATCH v2 2/2] drm/i915: give stolen system memory its own class

2021-02-05 Thread Matthew Auld
In some future patches we will need to also support a stolen region carved from device local memory, on platforms like DG1. To handle this we can simply describe each in terms of its own memory class. Signed-off-by: Matthew Auld Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_st

[Intel-gfx] [PATCH] drm/i915/gt: Ratelimit heartbeat completion probing

2021-02-05 Thread Chris Wilson
The heartbeat runs through a few phases that we expect to complete within a certain number of heartbeat intervals. First we must submit the heartbeat to the queue, and if the queue is occupied it may take a couple of intervals before the heartbeat preempts the workload and is submitted to HW. Once

Re: [Intel-gfx] linux-next: manual merge of the drivers-x86 tree with the drm-misc tree

2021-02-05 Thread Andy Shevchenko
On Thu, Feb 4, 2021 at 11:04 AM Andy Shevchenko wrote: >> Today's linux-next merge of the drivers-x86 tree got a conflict in: > > Thanks. I already asked Patrik yesterday day if DRM missed to pull an > immutable tag I provided. I think they can pull and resolve conflicts > themselves. Alternativ

Re: [Intel-gfx] linux-next: manual merge of the drivers-x86 tree with the drm-misc tree

2021-02-05 Thread Patrik Jakobsson
On Fri, Feb 5, 2021 at 12:07 PM Andy Shevchenko wrote: > > On Thu, Feb 4, 2021 at 11:04 AM Andy Shevchenko > wrote: > >> Today's linux-next merge of the drivers-x86 tree got a conflict in: > > > > Thanks. I already asked Patrik yesterday day if DRM missed to pull an > > immutable tag I provided.

[Intel-gfx] [PATCH v4] drm/i915/gt: Ratelimit heartbeat completion probing

2021-02-05 Thread Chris Wilson
The heartbeat runs through a few phases that we expect to complete within a certain number of heartbeat intervals. First we must submit the heartbeat to the queue, and if the queue is occupied it may take a couple of intervals before the heartbeat preempts the workload and is submitted to HW. Once

[Intel-gfx] [CI] drm/i915/selftest: Synchronise with the GPU timestamp

2021-02-05 Thread Chris Wilson
Wait for the GPU to wake up from the semaphore before measuring the time, so that we coordinate the sampling on both the CPU and GPU for more accurate comparisons. v2: Switch to local_irq_disable() as once suggested by Mika. Reported-by: Bruce Chang Signed-off-by: Chris Wilson Cc: CQ Tang Revi

Re: [Intel-gfx] [PATCH] drm/i915/debugfs: HDCP capability enc NULL check

2021-02-05 Thread Imre Deak
On Fri, Feb 05, 2021 at 10:16:30AM +0200, Gupta, Anshuman wrote: > > -Original Message- > > From: Imre Deak > > Sent: Thursday, February 4, 2021 11:58 PM > > To: Gupta, Anshuman > > Cc: intel-gfx@lists.freedesktop.org > > Subject: Re: [Intel-gfx] [PATCH] drm/i915/debugfs: HDCP capability

Re: [Intel-gfx] [PATCH] drm/i915/debugfs: HDCP capability enc NULL check

2021-02-05 Thread Gupta, Anshuman
> -Original Message- > From: Imre Deak > Sent: Friday, February 5, 2021 5:35 PM > To: Gupta, Anshuman > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/debugfs: HDCP capability enc NULL > check > > On Fri, Feb 05, 2021 at 10:16:30AM +0200, Gupta, Anshum

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915: cleanup the region class/instance encoding

2021-02-05 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915: cleanup the region class/instance encoding URL : https://patchwork.freedesktop.org/series/86753/ State : success == Summary == CI Bug Log - changes from CI_DRM_9737 -> Patchwork_19602

[Intel-gfx] [PATCH] drm/i915: Autoselect CONFIG_CHECKPOINT_RESTORE for SYS_kcmp

2021-02-05 Thread Chris Wilson
gallium (iris) depends on os_same_file_description() to disambiguate screens and so avoid importing the same screen fd twice as two distinct entities (that share all the kernel resources, so actions on screen affect the other and would cause random faiure). As they depend on it, so must we. os_same

Re: [Intel-gfx] linux-next: manual merge of the drivers-x86 tree with the drm-misc tree

2021-02-05 Thread Daniel Vetter
On Fri, Feb 5, 2021 at 12:14 PM Patrik Jakobsson wrote: > > On Fri, Feb 5, 2021 at 12:07 PM Andy Shevchenko > wrote: > > > > On Thu, Feb 4, 2021 at 11:04 AM Andy Shevchenko > > wrote: > > >> Today's linux-next merge of the drivers-x86 tree got a conflict in: > > > > > > Thanks. I already asked P

Re: [Intel-gfx] [PATCH v4] drm/i915/debugfs : PM_REQ and PM_RES registers

2021-02-05 Thread S, Saichandana
> -Original Message- > From: Chris Wilson > Sent: Friday, January 15, 2021 6:51 PM > To: S, Saichandana ; intel- > g...@lists.freedesktop.org > Cc: Nikula, Jani ; S, Saichandana > > Subject: Re: [Intel-gfx] [PATCH v4] drm/i915/debugfs : PM_REQ and > PM_RES registers > > Quoting Saicha

Re: [Intel-gfx] [PATCH 32/56] drm/i915: Move scheduler queue

2021-02-05 Thread FIKRI ADLY AKBAR18
___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v4] drm/i915/debugfs : PM_REQ and PM_RES registers

2021-02-05 Thread Chris Wilson
Quoting S, Saichandana (2021-02-05 13:05:20) > > > > -Original Message- > > From: Chris Wilson > > Sent: Friday, January 15, 2021 6:51 PM > > To: S, Saichandana ; intel- > > g...@lists.freedesktop.org > > Cc: Nikula, Jani ; S, Saichandana > > > > Subject: Re: [Intel-gfx] [PATCH v4] drm/

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/icl, tgl: whitelist COMMON_SLICE_CHICKEN3 register

2021-02-05 Thread Patchwork
== Series Details == Series: drm/i915/icl, tgl: whitelist COMMON_SLICE_CHICKEN3 register URL : https://patchwork.freedesktop.org/series/86733/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9735_full -> Patchwork_19598_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Ratelimit heartbeat completion probing (rev5)

2021-02-05 Thread Patchwork
== Series Details == Series: drm/i915/gt: Ratelimit heartbeat completion probing (rev5) URL : https://patchwork.freedesktop.org/series/86665/ State : success == Summary == CI Bug Log - changes from CI_DRM_9737 -> Patchwork_19603 Summary ---

Re: [Intel-gfx] [PATCH v15 1/2] drm/i915/display: Support PSR Multiple Instances

2021-02-05 Thread Souza, Jose
On Thu, 2021-02-04 at 15:40 +0200, Gwan-gyeong Mun wrote: > It is a preliminary work for supporting multiple EDP PSR and > DP PanelReplay. And it refactors singleton PSR to Multi Transcoder > supportable PSR. > And this moves and renames the i915_psr structure of drm_i915_private's to > intel_dp's

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: support ddr5 mem types

2021-02-05 Thread Souza, Jose
On Fri, 2021-02-05 at 07:40 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/display: support ddr5 mem types > URL : https://patchwork.freedesktop.org/series/86726/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_9732_full -> Patchwork_19595_full > =

Re: [Intel-gfx] [PATCH] drm/i915/icl, tgl: whitelist COMMON_SLICE_CHICKEN3 register

2021-02-05 Thread Chris Wilson
Quoting Sagar Ghuge (2021-02-05 00:33:10) > Adding this register to whitelist will allow UMD to toggle State Cache > Perf fix disable chicken bit. > >"If this bit is enabled, RCC uses BTP+BTI as address tag in its state >cache instead of BTI only" > > which will lead to dropping unnecessa

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v15,1/2] drm/i915/display: Support PSR Multiple Instances

2021-02-05 Thread Souza, Jose
On Fri, 2021-02-05 at 03:08 +, Patchwork wrote: > == Series Details == > > Series: series starting with [v15,1/2] drm/i915/display: Support PSR Multiple > Instances > URL : https://patchwork.freedesktop.org/series/86701/ > State : success > > == Summary == > > CI Bug Log - changes from CI

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Remove PSR2 on JSL and EHL

2021-02-05 Thread Souza, Jose
On Fri, 2021-02-05 at 04:53 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/display: Remove PSR2 on JSL and EHL > URL : https://patchwork.freedesktop.org/series/86714/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_9732_full -> Patchwork_19592_full

[Intel-gfx] [PATCH] RFC: dma-buf: Require VM_PFNMAP vma for mmap

2021-02-05 Thread Daniel Vetter
tldr; DMA buffers aren't normal memory, expecting that you can use them like that (like calling get_user_pages works, or that they're accounting like any other normal memory) cannot be guaranteed. Since some userspace only runs on integrated devices, where all buffers are actually all resident sys

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Make psr_safest_params and enable_psr2_sel_fetch parameters read only

2021-02-05 Thread Souza, Jose
On Fri, 2021-02-05 at 04:00 +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Make psr_safest_params and enable_psr2_sel_fetch parameters > read only > URL : https://patchwork.freedesktop.org/series/86710/ > State : success > > == Summary == > > CI Bug Log - changes from CI

Re: [Intel-gfx] [PATCH] RFC: dma-buf: Require VM_PFNMAP vma for mmap

2021-02-05 Thread Christian König
Am 05.02.21 um 14:41 schrieb Daniel Vetter: tldr; DMA buffers aren't normal memory, expecting that you can use them like that (like calling get_user_pages works, or that they're accounting like any other normal memory) cannot be guaranteed. Since some userspace only runs on integrated devices, w

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Index min_{cdclk, voltage_level}[] with pipe

2021-02-05 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Thursday, February 4, 2021 4:09 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 1/2] drm/i915: Index min_{cdclk, voltage_level}[] > with pipe > > From: Ville Syrjälä > > min_cdclk[] and

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use intel_hdmi_port_clock() more

2021-02-05 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Thursday, February 4, 2021 4:09 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 2/2] drm/i915: Use intel_hdmi_port_clock() more > > From: Ville Syrjälä > > Replace the hand rolled intel_

Re: [Intel-gfx] [PATCH v11 02/10] drm/i915: migrate hsw fdi code to new file.

2021-02-05 Thread Jani Nikula
On Thu, 04 Feb 2021, Jani Nikula wrote: > From: Dave Airlie > > Daniel asked for this, but it's a bit messy and I'm not sure > how best to clean it up yet. Thanks, pushed. BR, Jani. > > Signed-off-by: Dave Airlie > [Jani: also moved fdi buf trans to intel_fdi.c.] > Reviewed-by: Ville Syrjälä

Re: [Intel-gfx] linux-next: manual merge of the drivers-x86 tree with the drm-misc tree

2021-02-05 Thread Andy Shevchenko
On Fri, Feb 5, 2021 at 3:05 PM Daniel Vetter wrote: > On Fri, Feb 5, 2021 at 12:14 PM Patrik Jakobsson > wrote: > > > > On Fri, Feb 5, 2021 at 12:07 PM Andy Shevchenko > > wrote: > > > > > > On Thu, Feb 4, 2021 at 11:04 AM Andy Shevchenko > > > wrote: > > > >> Today's linux-next merge of the dr

[Intel-gfx] [PATCH] drm/i915/gt: Ratelimit heartbeat completion probing

2021-02-05 Thread Chris Wilson
The heartbeat runs through a few phases that we expect to complete within a certain number of heartbeat intervals. First we must submit the heartbeat to the queue, and if the queue is occupied it may take a couple of intervals before the heartbeat preempts the workload and is submitted to HW. Once

[Intel-gfx] [PATCH] drm/i915/gt: Ratelimit heartbeat completion probing

2021-02-05 Thread Chris Wilson
The heartbeat runs through a few phases that we expect to complete within a certain number of heartbeat intervals. First we must submit the heartbeat to the queue, and if the queue is occupied it may take a couple of intervals before the heartbeat preempts the workload and is submitted to HW. Once

[Intel-gfx] [PATCH v12 2/8] drm/i915: move pipe update code into crtc. (v2)

2021-02-05 Thread Jani Nikula
From: Dave Airlie Daniel suggested this should move here. v2: move vrr code. Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_crtc.c | 241 drivers/gpu/drm/i915/display/intel_sprite.c | 238 ---

[Intel-gfx] [PATCH v12 0/8] drm/i915: refactor intel_display.c + a bit more

2021-02-05 Thread Jani Nikula
Rebase of [1], which wen't stale in less than a day, but managed to push the first two. Progress! This also addresses Ville's review comments, I hope. BR, Jani. [1] https://patchwork.freedesktop.org/series/86723/ Dave Airlie (8): drm/i915: migrate skl planes code new file (v5) drm/i915: move

[Intel-gfx] [PATCH v12 4/8] drm/i915: move is_ccs_modifier to an inline

2021-02-05 Thread Jani Nikula
From: Dave Airlie There is no need for this to be out of line. Reviewed-by: Ville Syrjälä Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 9 - drivers/gpu/drm/i915/display/intel_display.h | 1 - drivers/gpu/drm/i915

[Intel-gfx] [PATCH v12 3/8] drm/i915: split fb scalable checks into g4x and skl versions

2021-02-05 Thread Jani Nikula
From: Dave Airlie This just cleans these up a bit. Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_sprite.c| 7 +++ drivers/gpu/drm/i915/display/skl_universal_plane.c | 4 ++-- 2 files changed, 5 insertions(+

[Intel-gfx] [PATCH v12 5/8] drm/i915: migrate pll enable/disable code to intel_dpll.[ch]

2021-02-05 Thread Jani Nikula
From: Dave Airlie This moves the older i9xx/vlv/chv enable/disable to dpll file. Signed-off-by: Dave Airlie Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 512 --- drivers/gpu/drm/i915/display/intel_display.h | 3 -

[Intel-gfx] [PATCH v12 6/8] drm/i915: migrate i9xx plane get config

2021-02-05 Thread Jani Nikula
From: Dave Airlie Migrate this code out like the skylake code. Signed-off-by: Dave Airlie Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_plane.c| 119 +++ drivers/gpu/drm/i915/display/i9xx_plane.h| 4 + drivers/gpu/drm/i9

[Intel-gfx] [PATCH v12 8/8] drm/i915: move ddi pll state get to dpll mgr

2021-02-05 Thread Jani Nikula
From: Dave Airlie This just migrates the hsw+ code to a better place. Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 219 + drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 223 ++ drivers/gpu/drm/i915/d

[Intel-gfx] [PATCH v12 7/8] drm/i915: refactor skylake scaler code into new file.

2021-02-05 Thread Jani Nikula
From: Dave Airlie This moves the code from various places and consolidates it into one new file. v2: - rename skl_program_plane -> skl_program_plane_scaler (Ville) - also move skl_pfit_enable, and consequently make some skl_scaler_* functions static to skl_scaler.c (Ville) Signed-off-by: Dave

Re: [Intel-gfx] [PATCH v12 7/8] drm/i915: refactor skylake scaler code into new file.

2021-02-05 Thread Ville Syrjälä
On Fri, Feb 05, 2021 at 04:48:42PM +0200, Jani Nikula wrote: > From: Dave Airlie > > This moves the code from various places and consolidates it > into one new file. > > v2: > - rename skl_program_plane -> skl_program_plane_scaler (Ville) > - also move skl_pfit_enable, and consequently make some

Re: [Intel-gfx] [PATCH v12 8/8] drm/i915: move ddi pll state get to dpll mgr

2021-02-05 Thread Ville Syrjälä
On Fri, Feb 05, 2021 at 04:48:43PM +0200, Jani Nikula wrote: > From: Dave Airlie > > This just migrates the hsw+ code to a better place. > > Signed-off-by: Dave Airlie > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_display.c | 219 + > drivers/gpu/drm

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add link rate and lane count to i915_display_info

2021-02-05 Thread Patchwork
== Series Details == Series: drm/i915: Add link rate and lane count to i915_display_info URL : https://patchwork.freedesktop.org/series/86738/ State : success == Summary == CI Bug Log - changes from CI_DRM_9735_full -> Patchwork_19600_full

Re: [Intel-gfx] [PATCH] drm/vblank: Avoid storing a timestamp for the same frame twice

2021-02-05 Thread Daniel Vetter
On Thu, Feb 04, 2021 at 05:55:28PM +0200, Ville Syrjälä wrote: > On Thu, Feb 04, 2021 at 04:32:16PM +0100, Daniel Vetter wrote: > > On Thu, Feb 04, 2021 at 04:04:00AM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > drm_vblank_restore() exists because certain power saving states

[Intel-gfx] [PATCH] drm/i915/display: Allow PSR2 selective fetch to be enabled at run-time

2021-02-05 Thread José Roberto de Souza
Right now CI is blacklisting module reload, so we need to be able to enable PSR2 selective fetch in run time to test this feature before enable it by default. Changes in IGT will also be needed. Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_disp

Re: [Intel-gfx] [PATCH] drm/i915: Autoselect CONFIG_CHECKPOINT_RESTORE for SYS_kcmp

2021-02-05 Thread Daniel Vetter
On Fri, Feb 05, 2021 at 01:03:07PM +, Chris Wilson wrote: > gallium (iris) depends on os_same_file_description() to disambiguate > screens and so avoid importing the same screen fd twice as two distinct > entities (that share all the kernel resources, so actions on screen > affect the other and

Re: [Intel-gfx] [PATCH] drm/i915: Autoselect CONFIG_CHECKPOINT_RESTORE for SYS_kcmp

2021-02-05 Thread Daniel Vetter
On Fri, Feb 05, 2021 at 04:58:32PM +0100, Daniel Vetter wrote: > On Fri, Feb 05, 2021 at 01:03:07PM +, Chris Wilson wrote: > > gallium (iris) depends on os_same_file_description() to disambiguate > > screens and so avoid importing the same screen fd twice as two distinct > > entities (that shar

Re: [Intel-gfx] [PATCH] drm/i915: Autoselect CONFIG_CHECKPOINT_RESTORE for SYS_kcmp

2021-02-05 Thread Lucas Stach
Am Freitag, dem 05.02.2021 um 16:59 +0100 schrieb Daniel Vetter: > On Fri, Feb 05, 2021 at 04:58:32PM +0100, Daniel Vetter wrote: > > On Fri, Feb 05, 2021 at 01:03:07PM +, Chris Wilson wrote: > > > gallium (iris) depends on os_same_file_description() to disambiguate > > > screens and so avoid i

Re: [Intel-gfx] [PATCH] drm/vblank: Avoid storing a timestamp for the same frame twice

2021-02-05 Thread Ville Syrjälä
On Fri, Feb 05, 2021 at 04:46:27PM +0100, Daniel Vetter wrote: > On Thu, Feb 04, 2021 at 05:55:28PM +0200, Ville Syrjälä wrote: > > On Thu, Feb 04, 2021 at 04:32:16PM +0100, Daniel Vetter wrote: > > > On Thu, Feb 04, 2021 at 04:04:00AM +0200, Ville Syrjala wrote: > > > > From: Ville Syrjälä > > >

[Intel-gfx] [PATCH] kernel: Expose SYS_kcmp by default

2021-02-05 Thread Chris Wilson
Userspace has discovered the functionality offered by SYS_kcmp and has started to depend upon it. In particular, Mesa uses SYS_kcmp for os_same_file_description() in order to identify when two fd (e.g. device or dmabuf) point to the same struct file. Since they depend on it for core functionality,

Re: [Intel-gfx] [PATCH] kernel: Expose SYS_kcmp by default

2021-02-05 Thread Lucas Stach
Am Freitag, dem 05.02.2021 um 16:37 + schrieb Chris Wilson: > Userspace has discovered the functionality offered by SYS_kcmp and has > started to depend upon it. In particular, Mesa uses SYS_kcmp for > os_same_file_description() in order to identify when two fd (e.g. device > or dmabuf) point t

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftest: Synchronise with the GPU timestamp (rev2)

2021-02-05 Thread Patchwork
== Series Details == Series: drm/i915/selftest: Synchronise with the GPU timestamp (rev2) URL : https://patchwork.freedesktop.org/series/86731/ State : success == Summary == CI Bug Log - changes from CI_DRM_9739 -> Patchwork_19604 Summary -

Re: [Intel-gfx] [PATCH i-g-t] i915/module_load: Tidy up gem_exec_store workalike

2021-02-05 Thread Ramalingam C
On 2021-02-05 at 10:10:05 +, Chris Wilson wrote: > We emit a store on each GPU after loading the module to confirm the > basic liveness of command submission. Trim away some of the chaff. > > Signed-off-by: Chris Wilson > Cc: Ramalingam C Looks good to me Reviewed-by: Ramalingam C > --- >

[Intel-gfx] [CI 1/2] drm/i915/gt: Always flush the submission queue on checking for idle

2021-02-05 Thread Chris Wilson
We check for idle during debug prints and other debugging actions. Simplify the flow by not touching execlists state. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --gi

[Intel-gfx] [CI 2/2] drm/i915/gt: Pull all execlists scheduler initialisation together

2021-02-05 Thread Chris Wilson
Put all the scheduler initialisation code for execlists into a common routine. This is to reduce code movement later. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- .../drm/i915/gt/intel_execlists_submission.c | 26 --- 1 file changed, 16 insertions(+), 10 deletion

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Autoselect CONFIG_CHECKPOINT_RESTORE for SYS_kcmp

2021-02-05 Thread Patchwork
== Series Details == Series: drm/i915: Autoselect CONFIG_CHECKPOINT_RESTORE for SYS_kcmp URL : https://patchwork.freedesktop.org/series/86759/ State : success == Summary == CI Bug Log - changes from CI_DRM_9739 -> Patchwork_19605 Summary --

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hdcp: Show connector hdcp capability

2021-02-05 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Show connector hdcp capability URL : https://patchwork.freedesktop.org/series/86740/ State : success == Summary == CI Bug Log - changes from CI_DRM_9736_full -> Patchwork_19601_full Summary --

Re: [Intel-gfx] [PATCH] kernel: Expose SYS_kcmp by default

2021-02-05 Thread Kees Cook
On Fri, Feb 05, 2021 at 04:37:52PM +, Chris Wilson wrote: > Userspace has discovered the functionality offered by SYS_kcmp and has > started to depend upon it. In particular, Mesa uses SYS_kcmp for > os_same_file_description() in order to identify when two fd (e.g. device > or dmabuf) point to

Re: [Intel-gfx] [PATCH] drm/i915/icl, tgl: whitelist COMMON_SLICE_CHICKEN3 register

2021-02-05 Thread Sagar Ghuge
On 2/5/21 5:33 AM, Chris Wilson wrote: > Quoting Sagar Ghuge (2021-02-05 00:33:10) >> Adding this register to whitelist will allow UMD to toggle State Cache >> Perf fix disable chicken bit. >> >>"If this bit is enabled, RCC uses BTP+BTI as address tag in its state >>cache instead of BTI o

[Intel-gfx] [PATCH v2] drm/i915: Add link rate and lane count to i915_display_info

2021-02-05 Thread Khaled Almahallawy
Link rate and lane count information are more easier and faster to check in i915_display_info than checking kernel logs for people not familiar with i915 in the following scenarios: * Debugging DP tunnel bandwidth usage in Thunderbolt driver. * In USB4 certification, it is a requirement to know w

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for RFC: dma-buf: Require VM_SPECIAL vma for mmap (rev2)

2021-02-05 Thread Patchwork
== Series Details == Series: RFC: dma-buf: Require VM_SPECIAL vma for mmap (rev2) URL : https://patchwork.freedesktop.org/series/86667/ State : warning == Summary == $ dim checkpatch origin/drm-tip a259cff180fc RFC: dma-buf: Require VM_PFNMAP vma for mmap -:34: WARNING:TYPO_SPELLING: 'entires'

Re: [Intel-gfx] [PATCH] kernel: Expose SYS_kcmp by default

2021-02-05 Thread kernel test robot
/linux.git 2ab38c17aac10bf55ab3efde4c4db3893d8691d2 config: powerpc-randconfig-r023-20210205 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com

Re: [Intel-gfx] [PATCH] kernel: Expose SYS_kcmp by default

2021-02-05 Thread kernel test robot
/linux.git 2ab38c17aac10bf55ab3efde4c4db3893d8691d2 config: i386-randconfig-s002-20210205 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-215-g0fb77bb6-dirty # https://github.com/0day-ci/li

[Intel-gfx] ✗ Fi.CI.BAT: failure for RFC: dma-buf: Require VM_SPECIAL vma for mmap (rev2)

2021-02-05 Thread Patchwork
== Series Details == Series: RFC: dma-buf: Require VM_SPECIAL vma for mmap (rev2) URL : https://patchwork.freedesktop.org/series/86667/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9740 -> Patchwork_19606 Summary ---

Re: [Intel-gfx] [PATCH 1/3] i915/display/intel_dp: Read PCON DSC ENC caps only for DPCD rev >= 1.4

2021-02-05 Thread Ville Syrjälä
On Thu, Feb 04, 2021 at 12:18:40PM +0530, Ankit Nautiyal wrote: > DP-HDMI2.1 PCON has DSC encoder caps defined in registers 0x92-0x9E. > Do not read the registers if DPCD rev < 1.4. > > Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/2868 > Signed-off-by: Ankit Nautiyal > --- > drivers/

Re: [Intel-gfx] [PATCH 2/3] drm/dp_helper: Define options for FRL training for HDMI2.1 PCON

2021-02-05 Thread Ville Syrjälä
On Thu, Feb 04, 2021 at 12:18:41PM +0530, Ankit Nautiyal wrote: > Currently the FRL training mode (Concurrent, Sequential) and > training type (Normal, Extended) are not defined properly and > are passed as bool values in drm_helpers for pcon > configuration for FRL training. > > This patch: > -De

Re: [Intel-gfx] [PATCH 3/3] i915/display: Remove FRL related code from disable DP sequence for older platforms

2021-02-05 Thread Ville Syrjälä
On Thu, Feb 04, 2021 at 12:18:42PM +0530, Ankit Nautiyal wrote: > Remove code for resetting frl related members from intel_disable_dp, as > this is not applicable for older platforms. > > Signed-off-by: Ankit Nautiyal > --- > drivers/gpu/drm/i915/display/intel_dp.c | 2 -- > 1 file changed, 2 de

Re: [Intel-gfx] [PATCH 1/3] i915/display/intel_dp: Read PCON DSC ENC caps only for DPCD rev >= 1.4

2021-02-05 Thread Navare, Manasi
On Fri, Feb 05, 2021 at 09:58:07PM +0200, Ville Syrjälä wrote: > On Thu, Feb 04, 2021 at 12:18:40PM +0530, Ankit Nautiyal wrote: > > DP-HDMI2.1 PCON has DSC encoder caps defined in registers 0x92-0x9E. > > Do not read the registers if DPCD rev < 1.4. > > > > Fixes: https://gitlab.freedesktop.org/d

Re: [Intel-gfx] [PATCH 1/3] i915/display/intel_dp: Read PCON DSC ENC caps only for DPCD rev >= 1.4

2021-02-05 Thread Ville Syrjälä
On Fri, Feb 05, 2021 at 12:07:41PM -0800, Navare, Manasi wrote: > On Fri, Feb 05, 2021 at 09:58:07PM +0200, Ville Syrjälä wrote: > > On Thu, Feb 04, 2021 at 12:18:40PM +0530, Ankit Nautiyal wrote: > > > DP-HDMI2.1 PCON has DSC encoder caps defined in registers 0x92-0x9E. > > > Do not read the regis

Re: [Intel-gfx] [PATCH 1/3] i915/display/intel_dp: Read PCON DSC ENC caps only for DPCD rev >= 1.4

2021-02-05 Thread Navare, Manasi
On Fri, Feb 05, 2021 at 10:06:48PM +0200, Ville Syrjälä wrote: > On Fri, Feb 05, 2021 at 12:07:41PM -0800, Navare, Manasi wrote: > > On Fri, Feb 05, 2021 at 09:58:07PM +0200, Ville Syrjälä wrote: > > > On Thu, Feb 04, 2021 at 12:18:40PM +0530, Ankit Nautiyal wrote: > > > > DP-HDMI2.1 PCON has DSC e

Re: [Intel-gfx] [PATCH v2] drm/i915: Add link rate and lane count to i915_display_info

2021-02-05 Thread Navare, Manasi
On Fri, Feb 05, 2021 at 11:09:36AM -0800, Khaled Almahallawy wrote: > Link rate and lane count information are more easier and faster to check in > i915_display_info > than checking kernel logs for people not familiar with i915 in the following > scenarios: > * Debugging DP tunnel bandwidth usage

[Intel-gfx] [PATCH] drm/i915: Nuke INTEL_OUTPUT_FORMAT_INVALID

2021-02-05 Thread Ville Syrjala
From: Ville Syrjälä We tend to use output_format!=RGB as a shorthand for YCbCr, but this fails if we have a disabled crtc where output_format==INVALID. We're now getting some fail from intel_color_check() when we have: hw.enable==false hw.ctm!=NULL output_format==INVALID Let's avoid that by t

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Ratelimit heartbeat completion probing (rev7)

2021-02-05 Thread Patchwork
== Series Details == Series: drm/i915/gt: Ratelimit heartbeat completion probing (rev7) URL : https://patchwork.freedesktop.org/series/86665/ State : success == Summary == CI Bug Log - changes from CI_DRM_9740 -> Patchwork_19607 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/vbt: update DP max link rate table

2021-02-05 Thread Ville Syrjälä
On Mon, Feb 01, 2021 at 11:02:28PM +0800, Lee Shawn C wrote: > According to Bspec #20124, max link rate table for DP was updated > at BDB version 230. Max link rate can support upto UHBR. > > After migrate to BDB v230, the definition for LBR, HBR2 and HBR3 > were changed. For backward compatibilit

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: refactor intel_display.c + a bit more (rev2)

2021-02-05 Thread Patchwork
== Series Details == Series: drm/i915: refactor intel_display.c + a bit more (rev2) URL : https://patchwork.freedesktop.org/series/86723/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2685c66ddd72 drm/i915: migrate skl planes code new file (v5) -:2738: WARNING:FILE_PATH_CHANGES

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: refactor intel_display.c + a bit more (rev2)

2021-02-05 Thread Patchwork
== Series Details == Series: drm/i915: refactor intel_display.c + a bit more (rev2) URL : https://patchwork.freedesktop.org/series/86723/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +drivers/gp

Re: [Intel-gfx] [PATCH v12 8/8] drm/i915: move ddi pll state get to dpll mgr

2021-02-05 Thread Ville Syrjälä
On Fri, Feb 05, 2021 at 05:09:14PM +0200, Ville Syrjälä wrote: > On Fri, Feb 05, 2021 at 04:48:43PM +0200, Jani Nikula wrote: > > From: Dave Airlie > > > > This just migrates the hsw+ code to a better place. > > > > Signed-off-by: Dave Airlie > > Signed-off-by: Jani Nikula > > --- > > drivers

Re: [Intel-gfx] [PATCH] kernel: Expose SYS_kcmp by default

2021-02-05 Thread Daniel Vetter
On Fri, Feb 5, 2021 at 7:37 PM Kees Cook wrote: > > On Fri, Feb 05, 2021 at 04:37:52PM +, Chris Wilson wrote: > > Userspace has discovered the functionality offered by SYS_kcmp and has > > started to depend upon it. In particular, Mesa uses SYS_kcmp for > > os_same_file_description() in order

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: refactor intel_display.c + a bit more (rev2)

2021-02-05 Thread Patchwork
== Series Details == Series: drm/i915: refactor intel_display.c + a bit more (rev2) URL : https://patchwork.freedesktop.org/series/86723/ State : success == Summary == CI Bug Log - changes from CI_DRM_9740 -> Patchwork_19608 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/2] drm/i915: cleanup the region class/instance encoding

2021-02-05 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915: cleanup the region class/instance encoding URL : https://patchwork.freedesktop.org/series/86753/ State : success == Summary == CI Bug Log - changes from CI_DRM_9737_full -> Patchwork_19602_full ==

[Intel-gfx] [PATCH v2] kernel: Expose SYS_kcmp by default

2021-02-05 Thread Chris Wilson
Userspace has discovered the functionality offered by SYS_kcmp and has started to depend upon it. In particular, Mesa uses SYS_kcmp for os_same_file_description() in order to identify when two fd (e.g. device or dmabuf) point to the same struct file. Since they depend on it for core functionality,

Re: [Intel-gfx] [PATCH v2] kernel: Expose SYS_kcmp by default

2021-02-05 Thread Chris Wilson
The subject should of course be changed, as it is no longer being enabled by default. Something like kcmp: Support selection of SYS_kcmp without CHECKPOINT_RESTORE Quoting Chris Wilson (2021-02-05 21:06:10) > Userspace has discovered the functionality offered by SYS_kcmp and has > started to dep

Re: [Intel-gfx] [PATCH] drm/vblank: Avoid storing a timestamp for the same frame twice

2021-02-05 Thread Ville Syrjälä
On Fri, Feb 05, 2021 at 06:24:08PM +0200, Ville Syrjälä wrote: > On Fri, Feb 05, 2021 at 04:46:27PM +0100, Daniel Vetter wrote: > > On Thu, Feb 04, 2021 at 05:55:28PM +0200, Ville Syrjälä wrote: > > > On Thu, Feb 04, 2021 at 04:32:16PM +0100, Daniel Vetter wrote: > > > > On Thu, Feb 04, 2021 at 04:

Re: [Intel-gfx] [PATCH v2] kernel: Expose SYS_kcmp by default

2021-02-05 Thread Kees Cook
On Fri, Feb 05, 2021 at 09:16:01PM +, Chris Wilson wrote: > The subject should of course be changed, as it is no longer being > enabled by default. "default n" is redundant. I thought Daniel said CONFIG_DRM needed to "select" it too, though? Otherwise, yeah, this looks good. Was the export due

Re: [Intel-gfx] [PATCH v2] kernel: Expose SYS_kcmp by default

2021-02-05 Thread Chris Wilson
Quoting Kees Cook (2021-02-05 21:20:33) > On Fri, Feb 05, 2021 at 09:16:01PM +, Chris Wilson wrote: > > The subject should of course be changed, as it is no longer being > > enabled by default. > > "default n" is redundant. I thought being explicit would be preferred. There are a few other de

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Allow PSR2 selective fetch to be enabled at run-time

2021-02-05 Thread Patchwork
== Series Details == Series: drm/i915/display: Allow PSR2 selective fetch to be enabled at run-time URL : https://patchwork.freedesktop.org/series/86773/ State : success == Summary == CI Bug Log - changes from CI_DRM_9740 -> Patchwork_19609

[Intel-gfx] [PATCH v3 00/15] drm/i915: Clean up the DDI clock routing mess

2021-02-05 Thread Ville Syrjala
From: Ville Syrjälä Sorry for spamming the same series again and again. v2 still had some issues around FDI, and to fix those I had to stick a fresh patch to the start of the series. Hopefully it's now solid. I have a few more patches already cooked up on top to clean up the readout side too. Bu

[Intel-gfx] [PATCH v3 02/15] drm/i915: Introduce .{enable, disable}_clock() encoder vfuncs

2021-02-05 Thread Ville Syrjala
From: Ville Syrjälä The current code dealing with the clock routing for DDI encoders is a maintenance nightmare. Let's start cleaning it up by allowing the encoder to provide vfuncs for enablign/disabling the clock. We leave them initially unimplemented, falling back to the old if-else approach.

[Intel-gfx] [PATCH v3 01/15] drm/i915: Use intel_ddi_clk_select() for FDI

2021-02-05 Thread Ville Syrjala
From: Ville Syrjälä We want to put all DDI clock routing code into one place. Unify the FDI enable sequence to use the standard function instead of hand rolling its own. The disable sequence already uses the normal thing. Cc: Lucas De Marchi Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i9

[Intel-gfx] [PATCH v3 03/15] drm/i915: Extract hsw_ddi_{enable, disable}_clock()

2021-02-05 Thread Ville Syrjala
From: Ville Syrjälä Yank out the HSW/BDW code from intel_ddi_clk_{select,disable}() and put it into the new encoder .{enable,disable}_clock() vfuncs. v2: s/dev_priv/i915/ (Lucas) v3: Deal with FDI Reviewed-by: Lucas De Marchi #v2 Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/

[Intel-gfx] [PATCH v3 04/15] drm/i915: Extract skl_ddi_{enable, disable}_clock()

2021-02-05 Thread Ville Syrjala
From: Ville Syrjälä Extract the DDI clock routing clode for skl/derivatives into the new encoder vfuncs. v2: s/dev_priv/i915/ (Lucas) Reviewed-by: Lucas De Marchi Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 53 +--- 1 file changed, 38 inser

[Intel-gfx] [PATCH v3 06/15] drm/i915: Convert DG1 over to .{enable, disable}_clock()

2021-02-05 Thread Ville Syrjala
From: Ville Syrjälä Replace dg1_{map,unmap}_plls_to_ports() with the appropriate encoder vfuncs. And let's relocate the disable function next to the enable function while at it. Reviewed-by: Lucas De Marchi Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 43 +++

[Intel-gfx] [PATCH v3 05/15] drm/i195: Extract cnl_ddi_{enable, disable}_clock()

2021-02-05 Thread Ville Syrjala
From: Ville Syrjälä Extract the DDI clock routing for CNL into the new vfuncs. v2: s/dev_priv/i915/ (Lucas) Reviewed-by: Lucas De Marchi Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 62 1 file changed, 42 insertions(+), 20 deletions(-)

[Intel-gfx] [PATCH v3 08/15] drm/i915: Use intel_de_rmw() for DDI clock routing

2021-02-05 Thread Ville Syrjala
From: Ville Syrjälä The DDI clock routing programming is riddled with shared registers, forcing us to do a lot of RMW. Switch over to intel_de_rmw() to make that a bit less obnoxious. Reviewed-by: Lucas De Marchi Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 77 +

  1   2   >