Re: [Intel-gfx] [PATCH 7/7] drm/i915/display/xelpd: Exetend Wa_14011508470

2021-07-09 Thread Matt Roper
On Thu, Jul 08, 2021 at 02:18:27PM -0700, José Roberto de Souza wrote: > This workaround is also applicable to xelpd display so extending it. > > Cc: Gwan-gyeong Mun > Signed-off-by: José Roberto de Souza Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/display/intel_display_power.c | 4

Re: [Intel-gfx] [PATCH 6/7] drm/i915/display/adl_p: Correctly program MBUS DBOX A credits

2021-07-09 Thread Matt Roper
On Thu, Jul 08, 2021 at 02:18:26PM -0700, José Roberto de Souza wrote: > Alderlake-P have different values for MBUS DBOX A credits depending > if MBUS join is enabled or not. > > BSpec: 50343 > BSpec: 54369 > Cc: Matt Atwood > Signed-off-by: José Roberto de Souza > --- >

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add TTM offset argument to mmap. (rev2)

2021-07-09 Thread Patchwork
== Series Details == Series: drm/i915: Add TTM offset argument to mmap. (rev2) URL : https://patchwork.freedesktop.org/series/92103/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10324_full -> Patchwork_20562_full Summary

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Limit Wa_22010178259 to affected platforms

2021-07-09 Thread Matt Roper
On Thu, Jul 08, 2021 at 02:18:25PM -0700, José Roberto de Souza wrote: > This workaround is not needed for platforms with display 13. > > Cc: Gwan-gyeong Mun > Signed-off-by: José Roberto de Souza Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/display/intel_display_power.c | 9

Re: [Intel-gfx] [PATCH 08/16] drm/i915/guc/slpc: Add methods to set min/max frequency

2021-07-09 Thread kernel test robot
Hi Vinay, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next drm/drm-next v5.13 next-20210709] [If your patch is applied to the wrong git tree

Re: [Intel-gfx] [PATCH 3/7] drm/i915/adl_s: Extend Wa_1406941453

2021-07-09 Thread Matt Roper
On Thu, Jul 08, 2021 at 02:18:23PM -0700, José Roberto de Souza wrote: > BSpec: 54370 > Cc: Gwan-gyeong Mun > Signed-off-by: José Roberto de Souza Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Implement Wa_1508744258

2021-07-09 Thread Matt Roper
On Thu, Jul 08, 2021 at 02:18:22PM -0700, José Roberto de Souza wrote: > Same bit was required for Wa_14012131227 in DG1 now it is also This is a DG1-specific number; the general lineage number given here and in the comment should be 22011054531 (and this lineage number does apply to TGL, RKL,

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Settle on "adl-x" in WA comments

2021-07-09 Thread Matt Roper
On Thu, Jul 08, 2021 at 02:18:21PM -0700, José Roberto de Souza wrote: > From: Lucas De Marchi > > Most of the places are using this format so lets consolidate it. > > Signed-off-by: José Roberto de Souza > Signed-off-by: Lucas De Marchi Reviewed-by: Matt Roper > --- >

[Intel-gfx] ✓ Fi.CI.BAT: success for Minor revid/stepping and workaround cleanup (rev2)

2021-07-09 Thread Patchwork
== Series Details == Series: Minor revid/stepping and workaround cleanup (rev2) URL : https://patchwork.freedesktop.org/series/92299/ State : success == Summary == CI Bug Log - changes from CI_DRM_10329 -> Patchwork_20568 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Minor revid/stepping and workaround cleanup (rev2)

2021-07-09 Thread Patchwork
== Series Details == Series: Minor revid/stepping and workaround cleanup (rev2) URL : https://patchwork.freedesktop.org/series/92299/ State : warning == Summary == $ dim checkpatch origin/drm-tip 602f2fe49dc0 drm/i915/step: s/_revid_tbl/_revids 023cab2a2100 drm/i915: Make pre-production

Re: [Intel-gfx] [PATCH 22/47] drm/i915/guc: Update intel_gt_wait_for_idle to work with GuC

2021-07-09 Thread Matthew Brost
On Fri, Jul 09, 2021 at 05:16:34PM -0700, John Harrison wrote: > On 6/24/2021 00:04, Matthew Brost wrote: > > When running the GuC the GPU can't be considered idle if the GuC still > > has contexts pinned. As such, a call has been added in > > intel_gt_wait_for_idle to idle the UC and in turn the

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Make pre-production detection use direct revid comparison

2021-07-09 Thread Matt Roper
On Thu, Jul 08, 2021 at 11:08:46AM -0700, Srivatsa, Anusha wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf Of > > Matt Roper > > Sent: Wednesday, July 7, 2021 10:38 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [Intel-gfx] [PATCH 1/7] drm/i915: Make

[Intel-gfx] [PATCH v2 09/12] drm/i915/rkl: Use revid->stepping tables

2021-07-09 Thread Matt Roper
Switch RKL to use a revid->stepping table as we're trying to do on all platforms going forward. Bspec: 44501 Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_psr.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.h | 8 ++-- drivers/gpu/drm/i915/intel_step.c| 9

[Intel-gfx] [PATCH v2 08/12] drm/i915/jsl_ehl: Use revid->stepping tables

2021-07-09 Thread Matt Roper
Switch JSL/EHL to use a revid->stepping table as we're trying to do on all platforms going forward. Bspec: 29153 Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +- drivers/gpu/drm/i915/gt/intel_workarounds.c | 2 +- drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH v2 03/12] drm/i915/skl: Use revid->stepping tables

2021-07-09 Thread Matt Roper
Switch SKL to use a revid->stepping table as we're trying to do on all platforms going forward. Also drop the preproduction revisions and add the newer steppings we hadn't already handled. Note that SKL has a case where a newer revision ID corresponds to an older GT/disp stepping (0x9 ->

[Intel-gfx] [PATCH v2 05/12] drm/i915/bxt: Use revid->stepping tables

2021-07-09 Thread Matt Roper
Switch BXT to use a revid->stepping table as we're trying to do on all platforms going forward. Note that the REVID macros we had before weren't being used anywhere in the code and weren't even correct; the table values come from the bspec (and omits all the placeholder and preproduction

[Intel-gfx] [PATCH v2 01/12] drm/i915/step: s/_revid_tbl/_revids

2021-07-09 Thread Matt Roper
From: Anusha Srivatsa Simplify the stepping info array name. Cc: Jani Nikula Signed-off-by: Anusha Srivatsa Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/intel_step.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

[Intel-gfx] [PATCH v2 06/12] drm/i915/glk: Use revid->stepping tables

2021-07-09 Thread Matt Roper
Switch GLK to use a revid->stepping table as we're trying to do on all platforms going forward. Pre-production and placeholder revisions are omitted. Although nothing in the code is using the data from this table at the moment, we expect some upcoming DMC patches to start utilizing it. Bspec:

[Intel-gfx] [PATCH v2 11/12] drm/i915/cnl: Drop all workarounds

2021-07-09 Thread Matt Roper
All of the Cannon Lake hardware that came out had graphics fused off, and our userspace drivers have already dropped their support for the platform; CNL-specific code in i915 that isn't inherited by subsequent platforms is effectively dead code. Let's remove all of the CNL-specific workarounds as

[Intel-gfx] [PATCH v2 07/12] drm/i915/icl: Use revid->stepping tables

2021-07-09 Thread Matt Roper
Switch ICL to use a revid->stepping table as we're trying to do on all platforms going forward. While we're at it, let's include some additional steppings that have popped up, even if we don't yet have any workarounds tied to those steppings (we probably need to audit our workaround list soon to

[Intel-gfx] [PATCH v2 02/12] drm/i915: Make pre-production detection use direct revid comparison

2021-07-09 Thread Matt Roper
Although we're converting our workarounds to use a revid->stepping lookup table, the function that detects pre-production hardware should continue to compare against PCI revision ID values directly. These are listed in the bspec as integers, so it's easier to confirm their correctness if we just

[Intel-gfx] [PATCH v2 12/12] drm/i915/icl: Drop workarounds that only apply to pre-production steppings

2021-07-09 Thread Matt Roper
We're past the point at which we usually drop workarounds that were never needed on production hardware. The driver will already print an error and apply taint if loaded on pre-production hardware. Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 39

[Intel-gfx] [PATCH v2 10/12] drm/i915/dg1: Use revid->stepping tables

2021-07-09 Thread Matt Roper
Switch DG1 to use a revid->stepping table as we're trying to do on all platforms going forward. This removes the last use of IS_REVID() and REVID_FOREVER, so remove those now-unused macros as well to prevent their accidental use on future platforms. Bspec: 44463 Signed-off-by: Matt Roper ---

[Intel-gfx] [PATCH v2 00/12] Minor revid/stepping and workaround cleanup

2021-07-09 Thread Matt Roper
PCI revision IDs don't always map to GT and display IP steppings in an intuitive/sensible way. On many of our recent platforms we've switched to using revid->stepping lookup tables with the infrastructure in intel_step.c to handle stepping lookups and comparisons. This series converts several of

[Intel-gfx] [PATCH v2 04/12] drm/i915/kbl: Drop pre-production revision from stepping table

2021-07-09 Thread Matt Roper
We're long past the point where we need to care about pre-production hardware, and we already warn the user and taint the kernel if we detect the driver is being loaded on pre-production hardware. Bspec: 18329 Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/intel_step.c | 1 - 1 file

Re: [Intel-gfx] [PATCH 17/47] drm/i915/guc: Extend deregistration fence to schedule disable

2021-07-09 Thread Matthew Brost
On Fri, Jul 09, 2021 at 03:59:11PM -0700, John Harrison wrote: > On 6/24/2021 00:04, Matthew Brost wrote: > > Extend the deregistration context fence to fence whne a GuC context has > > scheduling disable pending. > > > > Cc: John Harrison > > Signed-off-by: Matthew Brost > > --- > >

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add missing docbook chapters for i915 uapi.

2021-07-09 Thread Patchwork
== Series Details == Series: drm/i915: Add missing docbook chapters for i915 uapi. URL : https://patchwork.freedesktop.org/series/92359/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10324_full -> Patchwork_20561_full

Re: [Intel-gfx] [PATCH 08/16] drm/i915/guc/slpc: Add methods to set min/max frequency

2021-07-09 Thread kernel test robot
Hi Vinay, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next drm/drm-next v5.13 next-20210709] [If your patch is applied to the wrong git tree

Re: [Intel-gfx] [PATCH 16/47] drm/i915/guc: Disable engine barriers with GuC during unpin

2021-07-09 Thread Matthew Brost
On Fri, Jul 09, 2021 at 03:53:29PM -0700, John Harrison wrote: > On 6/24/2021 00:04, Matthew Brost wrote: > > Disable engine barriers for unpinning with GuC. This feature isn't > > needed with the GuC as it disables context scheduling before unpinning > > which guarantees the HW will not reference

[Intel-gfx] ✗ Fi.CI.BAT: failure for Enable GuC based power management features

2021-07-09 Thread Patchwork
== Series Details == Series: Enable GuC based power management features URL : https://patchwork.freedesktop.org/series/92391/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10329 -> Patchwork_20567 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable GuC based power management features

2021-07-09 Thread Patchwork
== Series Details == Series: Enable GuC based power management features URL : https://patchwork.freedesktop.org/series/92391/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable GuC based power management features

2021-07-09 Thread Patchwork
== Series Details == Series: Enable GuC based power management features URL : https://patchwork.freedesktop.org/series/92391/ State : warning == Summary == $ dim checkpatch origin/drm-tip d9063ce26607 drm/i915/guc: Squashed patch - DO NOT REVIEW -:21: WARNING:BAD_SIGN_OFF: Duplicate signature

[Intel-gfx] [PATCH 16/16] drm/i915/guc/rc: Setup and enable GUCRC feature

2021-07-09 Thread Vinay Belgaumkar
This feature hands over the control of HW RC6 to the GUC. GUC decides when to put HW into RC6 based on it's internal busyness algorithms. GUCRC needs GUC submission to be enabled, and only supported on Gen12+ for now. When GUCRC is enabled, do not set HW RC6. Use a H2G message to tell guc to

[Intel-gfx] [PATCH 15/16] drm/i915/guc/slpc: slpc selftest

2021-07-09 Thread Vinay Belgaumkar
Tests that exercise the slpc get/set frequency interfaces. Clamp_max will set max frequency to multiple levels and check that slpc requests frequency lower than or equal to it. Clamp_min will set min frequency to different levels and check if slpc requests are higher or equal to those levels.

[Intel-gfx] [PATCH 14/16] drm/i915/guc/slpc: Sysfs hooks for slpc

2021-07-09 Thread Vinay Belgaumkar
Update the get/set min/max freq hooks to work for slpc case as well. Consolidate helpers for requested/min/max frequency get/set to intel_rps where the proper action can be taken depending on whether slpc is enabled. Signed-off-by: Vinay Belgaumkar Signed-off-by: Tvrtko Ursulin Signed-off-by:

[Intel-gfx] [PATCH 13/16] drm/i915/guc/slpc: Update slpc to use platform min/max

2021-07-09 Thread Vinay Belgaumkar
SLPC requests efficient frequency by default instead of min. It provides a flag to turn this off. Set that flag to maintain original semantics so that tests do not fail. SLPC can also request frequency that is much higher than the platform max, update that as well for the same reason.

[Intel-gfx] [PATCH 12/16] drm/i915/guc/slpc: Cache platform frequency limits for slpc

2021-07-09 Thread Vinay Belgaumkar
Cache rp0, rp1 and rpn platform limits into slpc structure for range checking while setting min/max frequencies. Also add "soft" limits which keep track of frequency changes made from userland. These are initially set to platform min and max. Signed-off-by: Vinay Belgaumkar ---

[Intel-gfx] [PATCH 11/16] drm/i915/guc/slpc: Enable ARAT timer interrupt

2021-07-09 Thread Vinay Belgaumkar
This interrupt is enabled during RPS initialization, and now needs to be done by slpc code. It allows ARAT timer expiry interrupts to get forwarded to GuC. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 16

[Intel-gfx] [PATCH 10/16] drm/i915/guc/slpc: Add debugfs for slpc info

2021-07-09 Thread Vinay Belgaumkar
This prints out relevant SLPC info from the SLPC shared structure. We will send a h2g message which forces SLPC to update the shared data structure with latest information before reading it. Signed-off-by: Vinay Belgaumkar Signed-off-by: Sundaresan Sujaritha ---

[Intel-gfx] [PATCH 09/16] drm/i915/guc/slpc: Add get max/min freq hooks

2021-07-09 Thread Vinay Belgaumkar
Add helpers to read the min/max frequency being used by SLPC. This is done by send a h2g command which forces SLPC to update the shared data struct which can then be read. Signed-off-by: Vinay Belgaumkar Signed-off-by: Sundaresan Sujaritha --- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 58

[Intel-gfx] [PATCH 08/16] drm/i915/guc/slpc: Add methods to set min/max frequency

2021-07-09 Thread Vinay Belgaumkar
Add param set h2g helpers to set the min and max frequencies for use by SLPC. Signed-off-by: Sundaresan Sujaritha Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 94 + drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.h | 2 + 2 files changed, 96

[Intel-gfx] [PATCH 07/16] drm/i915/guc/slpc: Enable slpc and add related H2G events

2021-07-09 Thread Vinay Belgaumkar
Add methods for interacting with guc for enabling SLPC. Enable SLPC after guc submission has been established. GuC load will fail if SLPC cannot be successfully initialized. Add various helper methods to set/unset the parameters for SLPC. They can be set using h2g calls or directly setting bits in

[Intel-gfx] [PATCH 06/16] drm/i915/guc/slpc: Allocate, initialize and release slpc

2021-07-09 Thread Vinay Belgaumkar
Allocate data structures for SLPC and functions for initializing on host side. Signed-off-by: Vinay Belgaumkar Signed-off-by: Sundaresan Sujaritha --- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 11 +++ drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 36 -

[Intel-gfx] [PATCH 05/16] drm/i915/guc/slpc: Adding slpc communication interfaces

2021-07-09 Thread Vinay Belgaumkar
Replicate the SLPC header file in GuC for the most part. There are some SLPC mode based parameters which haven't been included since we are not using them. Signed-off-by: Vinay Belgaumkar Signed-off-by: Sundaresan Sujaritha --- drivers/gpu/drm/i915/gt/uc/intel_guc.c| 4 +

[Intel-gfx] [PATCH 04/16] drm/i915/guc/slpc: Lay out slpc init/enable/disable/fini

2021-07-09 Thread Vinay Belgaumkar
Declare header and source files for SLPC, along with init and enable/disable function templates. Signed-off-by: Vinay Belgaumkar Signed-off-by: Sundaresan Sujaritha --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 ++

[Intel-gfx] [PATCH 03/16] drm/i915/guc/slpc: Gate Host RPS when slpc is enabled

2021-07-09 Thread Vinay Belgaumkar
Disable RPS when slpc is enabled. Also ensure uc_init is called before we initialize RPS so that we can check for slpc support. We do not need to enable up/down interrupts when slpc is enabled. However, we still need the ARAT interrupt, which will be enabled separately. Signed-off-by: Vinay

[Intel-gfx] [PATCH 02/16] drm/i915/guc/slpc: Initial definitions for slpc

2021-07-09 Thread Vinay Belgaumkar
Add macros to check for slpc support. This feature is currently supported for gen12+ and enabled whenever guc submission is enabled/selected. Signed-off-by: Vinay Belgaumkar Signed-off-by: Sundaresan Sujaritha Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_guc.c

[Intel-gfx] [PATCH 00/16] Enable GuC based power management features

2021-07-09 Thread Vinay Belgaumkar
This series enables Single Loop Power Control (SLPC) feature in GuC. GuC implements various power management algorithms as part of it's operation. These need to be specifically enabled by KMD. They replace the legacy host based management of these features. With this series, we will enable two PM

Re: [Intel-gfx] [PATCH 22/47] drm/i915/guc: Update intel_gt_wait_for_idle to work with GuC

2021-07-09 Thread John Harrison
On 6/24/2021 00:04, Matthew Brost wrote: When running the GuC the GPU can't be considered idle if the GuC still has contexts pinned. As such, a call has been added in intel_gt_wait_for_idle to idle the UC and in turn the GuC by waiting for the number of unpinned contexts to go to zero. v2:

Re: [Intel-gfx] [PATCH 20/47] drm/i915/guc: Disable semaphores when using GuC scheduling

2021-07-09 Thread John Harrison
On 6/24/2021 00:04, Matthew Brost wrote: Semaphores are an optimization and not required for basic GuC submission to work properly. Disable until we have time to do the implementation to enable semaphores and tune them for performance. Also long direction is just to delete semaphores from the

Re: [Intel-gfx] [PATCH 18/47] drm/i915: Disable preempt busywait when using GuC scheduling

2021-07-09 Thread John Harrison
On 6/24/2021 00:04, Matthew Brost wrote: Disable preempt busywait when using GuC scheduling. This isn't need as needed the GuC control preemption when scheduling. controls With the above fixed: Reviewed-by: John Harrison Cc: John Harrison Signed-off-by: Matthew Brost ---

Re: [Intel-gfx] [PATCH 17/47] drm/i915/guc: Extend deregistration fence to schedule disable

2021-07-09 Thread John Harrison
On 6/24/2021 00:04, Matthew Brost wrote: Extend the deregistration context fence to fence whne a GuC context has scheduling disable pending. Cc: John Harrison Signed-off-by: Matthew Brost --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 37 +++ 1 file changed, 30

Re: [Intel-gfx] [PATCH 16/47] drm/i915/guc: Disable engine barriers with GuC during unpin

2021-07-09 Thread John Harrison
On 6/24/2021 00:04, Matthew Brost wrote: Disable engine barriers for unpinning with GuC. This feature isn't needed with the GuC as it disables context scheduling before unpinning which guarantees the HW will not reference the context. Hence it is not necessary to defer unpinning until a kernel

Re: [Intel-gfx] [PATCH 15/47] drm/i915/guc: Defer context unpin until scheduling is disabled

2021-07-09 Thread John Harrison
On 6/24/2021 00:04, Matthew Brost wrote: With GuC scheduling, it isn't safe to unpin a context while scheduling is enabled for that context as the GuC may touch some of the pinned state (e.g. LRC). To ensure scheduling isn't enabled when an unpin is done, a call back is added to

Re: [Intel-gfx] [PATCH 14/47] drm/i915/guc: Insert fence on context when deregistering

2021-07-09 Thread John Harrison
On 6/24/2021 00:04, Matthew Brost wrote: Sometime during context pinning a context with the same guc_id is Sometime*s* registered with the GuC. In this a case deregister must be before before before before -> done before the context can be registered. A fence is inserted on all requests

Re: [Intel-gfx] [PATCH 09/10] drm/i915/step: Add intel_step_name() helper

2021-07-09 Thread Lucas De Marchi
On Fri, Jul 09, 2021 at 11:36:09AM -0700, Anusha Srivatsa wrote: -Original Message- From: De Marchi, Lucas Sent: Friday, July 9, 2021 10:53 AM To: Roper, Matthew D Cc: Srivatsa, Anusha ; intel- g...@lists.freedesktop.org; Jani Nikula Subject: Re: [Intel-gfx] [PATCH 09/10]

[Intel-gfx] ✓ Fi.CI.BAT: success for iommu/vt-d: Disable igfx iommu superpage on bxt/skl/glk

2021-07-09 Thread Patchwork
== Series Details == Series: iommu/vt-d: Disable igfx iommu superpage on bxt/skl/glk URL : https://patchwork.freedesktop.org/series/92374/ State : success == Summary == CI Bug Log - changes from CI_DRM_10326 -> Patchwork_20566 Summary

Re: [Intel-gfx] [PATCH 09/10] drm/i915/step: Add intel_step_name() helper

2021-07-09 Thread Srivatsa, Anusha
> -Original Message- > From: De Marchi, Lucas > Sent: Friday, July 9, 2021 10:53 AM > To: Roper, Matthew D > Cc: Srivatsa, Anusha ; intel- > g...@lists.freedesktop.org; Jani Nikula > Subject: Re: [Intel-gfx] [PATCH 09/10] drm/i915/step: Add intel_step_name() > helper > > On Thu, Jul

Re: [Intel-gfx] [PATCH v2] drm/i915/dg2: Update modeset sequences

2021-07-09 Thread Lucas De Marchi
On Wed, Jul 07, 2021 at 03:22:07PM -0700, Matt Roper wrote: DG2 has some changes to the expected modesetting sequences when compared to gen12. Adjust our driver logic accordingly. Although the DP sequence is pretty similar to TGL's, there are some steps that change, so let's split the handling

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for iommu/vt-d: Disable igfx iommu superpage on bxt/skl/glk

2021-07-09 Thread Patchwork
== Series Details == Series: iommu/vt-d: Disable igfx iommu superpage on bxt/skl/glk URL : https://patchwork.freedesktop.org/series/92374/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7da685194fc4 iommu/vt-d: Disable superpage for Geminilake igfx -:18:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/vgem: Restore mmap functionality

2021-07-09 Thread Patchwork
== Series Details == Series: drm/vgem: Restore mmap functionality URL : https://patchwork.freedesktop.org/series/92373/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10326 -> Patchwork_20565 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH 09/10] drm/i915/step: Add intel_step_name() helper

2021-07-09 Thread Lucas De Marchi
On Thu, Jul 08, 2021 at 09:16:16PM -0700, Matt Roper wrote: On Thu, Jul 08, 2021 at 04:18:20PM -0700, Anusha Srivatsa wrote: Add a helper to convert the step info to string. This is specifically useful when we want to load a specific firmware for a given stepping/substepping combination. What

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ehl: unconditionally flush the pages on acquire (rev2)

2021-07-09 Thread Patchwork
== Series Details == Series: drm/i915/ehl: unconditionally flush the pages on acquire (rev2) URL : https://patchwork.freedesktop.org/series/92367/ State : success == Summary == CI Bug Log - changes from CI_DRM_10326 -> Patchwork_20564

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add release id version

2021-07-09 Thread Matt Roper
On Wed, Jul 07, 2021 at 04:59:21PM -0700, Lucas De Marchi wrote: > Besides the arch version returned by GRAPHICS_VER(), new platforms > contain a "release id" to make clear the difference from one platform to > another. > > The release id number is not formally defined by hardware until future >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: do not abbreviate version in debugfs

2021-07-09 Thread Matt Roper
On Wed, Jul 07, 2021 at 04:59:20PM -0700, Lucas De Marchi wrote: > Brevity is not needed here, so just spell out "* version" in the string. > > Suggested-by: Chris Wilson > Signed-off-by: Lucas De Marchi Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/intel_device_info.c | 6 +++--- >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/ehl: unconditionally flush the pages on acquire (rev2)

2021-07-09 Thread Patchwork
== Series Details == Series: drm/i915/ehl: unconditionally flush the pages on acquire (rev2) URL : https://patchwork.freedesktop.org/series/92367/ State : warning == Summary == $ dim checkpatch origin/drm-tip 898f9d8b7d24 drm/i915/ehl: unconditionally flush the pages on acquire -:20:

Re: [Intel-gfx] [PATCH] drm/i915/ehl: unconditionally flush the pages on acquire

2021-07-09 Thread Daniel Vetter
On Fri, Jul 9, 2021 at 6:35 PM Matthew Auld wrote: > > On Fri, 9 Jul 2021 at 17:13, Daniel Vetter wrote: > > > > On Fri, Jul 9, 2021 at 5:19 PM Matthew Auld wrote: > > > > > > EHL and JSL add the 'Bypass LLC' MOCS entry, which should make it > > > possible for userspace to bypass the GTT

[Intel-gfx] [PATCH 4/4] drm/i915/fbc: Allow FBC + VT-d on SKL/BXT

2021-07-09 Thread Ville Syrjala
From: Ville Syrjälä With the iommu driver disabling VT-d superpage it should be safe to use FBC on SKL/BXT with VT-d otherwise enabled. Cc: David Woodhouse Cc: Lu Baolu Cc: io...@lists.linux-foundation.org Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_fbc.c | 16

[Intel-gfx] [PATCH 2/4] iommu/vt-d: Disable superpage for Broxton igfx

2021-07-09 Thread Ville Syrjala
From: Ville Syrjälä Broxton has known issues with VT-d superpage. Namely frame buffer compression (FBC) can't be safely used when superpage is enabled. Currently we're disabling FBC entirely when VT-d is active, but I think just disabling superpage would be better since FBC can save some power.

[Intel-gfx] [PATCH 3/4] iommu/vt-d: Disable superpage for Skylake igfx

2021-07-09 Thread Ville Syrjala
From: Ville Syrjälä Skylake has known issues with VT-d superpage. Namely frame buffer compression (FBC) can't be safely used when superpage is enabled. Currently we're disabling FBC entirely when VT-d is active, but I think just disabling superpage would be better since FBC can save some power.

[Intel-gfx] [PATCH 1/4] iommu/vt-d: Disable superpage for Geminilake igfx

2021-07-09 Thread Ville Syrjala
From: Ville Syrjälä While running "gem_exec_big --r single" from igt-gpu-tools on Geminilake as soon as a 2M mapping is made I tend to get a DMAR write fault. Strangely the faulting address is always a 4K page and usually very far away from the 2M page that got mapped. But if no 2M mappings get

[Intel-gfx] [PATCH 0/4] iommu/vt-d: Disable igfx iommu superpage on bxt/skl/glk

2021-07-09 Thread Ville Syrjala
From: Ville Syrjälä I ran into some kind of fail with VT-d superpage on Geminlake igfx, so without any better ideas let's just disable it. Additionally Skylake/Broxton igfx have known issues with VT-d superpage as well, so let's disable it there as well. This should let us re-enable frame

Re: [Intel-gfx] [PATCH] drm/i915/ehl: unconditionally flush the pages on acquire

2021-07-09 Thread Matthew Auld
On Fri, 9 Jul 2021 at 17:13, Daniel Vetter wrote: > > On Fri, Jul 9, 2021 at 5:19 PM Matthew Auld wrote: > > > > EHL and JSL add the 'Bypass LLC' MOCS entry, which should make it > > possible for userspace to bypass the GTT caching bits set by the kernel, > > as per the given object cache_level.

Re: [Intel-gfx] [PATCH] drm/i915/ehl: unconditionally flush the pages on acquire

2021-07-09 Thread Daniel Vetter
On Fri, Jul 9, 2021 at 5:19 PM Matthew Auld wrote: > > EHL and JSL add the 'Bypass LLC' MOCS entry, which should make it > possible for userspace to bypass the GTT caching bits set by the kernel, > as per the given object cache_level. This is troublesome since the heavy > flush we apply when

[Intel-gfx] [PATCH] drm/vgem: Restore mmap functionality

2021-07-09 Thread Thomas Zimmermann
Commit 375cca1cfeb5 ("drm/vgem: Implement mmap as GEM object function") accidentally removed the actual mmap functionality from vgem. Restore the original implementation and VMA flags. Fixes access to unmapped memory: [ 106.591744] BUG: KASAN: vmalloc-out-of-bounds in do_fault+0x38/0x480 [

[Intel-gfx] [PATCH v2] drm/i915/ehl: unconditionally flush the pages on acquire

2021-07-09 Thread Matthew Auld
EHL and JSL add the 'Bypass LLC' MOCS entry, which should make it possible for userspace to bypass the GTT caching bits set by the kernel, as per the given object cache_level. This is troublesome since the heavy flush we apply when first acquiring the pages is skipped if the kernel thinks the

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/sched dependency tracking and dma-resv fixes (rev2)

2021-07-09 Thread Patchwork
== Series Details == Series: drm/sched dependency tracking and dma-resv fixes (rev2) URL : https://patchwork.freedesktop.org/series/92333/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10320_full -> Patchwork_20559_full

Re: [Intel-gfx] [PATCH] drm/i915/debugfs: xelpd lpsp capability

2021-07-09 Thread Daniel Vetter
On Fri, Jul 9, 2021 at 2:12 PM Anshuman Gupta wrote: > > Extend i915_lpsp_capability sysfs to xelpd and future platforms. You're talking about sysfs but the patch is toucing a _debugfs.c file. Something is very, very wrong here, either the commit message, or worse, the code that's there already.

[Intel-gfx] [PATCH] drm/i915/ehl: unconditionally flush the pages on acquire

2021-07-09 Thread Matthew Auld
EHL and JSL add the 'Bypass LLC' MOCS entry, which should make it possible for userspace to bypass the GTT caching bits set by the kernel, as per the given object cache_level. This is troublesome since the heavy flush we apply when first acquiring the pages is skipped if the kernel thinks the

Re: [Intel-gfx] [PATCH v2] drm/i915: Add TTM offset argument to mmap.

2021-07-09 Thread Daniel Vetter
On Fri, Jul 9, 2021 at 1:41 PM Maarten Lankhorst wrote: > > This is only used for ttm, and tells userspace that the mapping type is > ignored. This disables the other type of mmap offsets when discrete > memory is used, so fix the selftests as well. > > Document the struct as well, so it shows up

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/7] drm/i915: Settle on "adl-x" in WA comments

2021-07-09 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Settle on "adl-x" in WA comments URL : https://patchwork.freedesktop.org/series/92342/ State : success == Summary == CI Bug Log - changes from CI_DRM_10320_full -> Patchwork_20558_full

Re: [Intel-gfx] [PATCH] drm/i915: Add TTM offset argument to mmap.

2021-07-09 Thread Jason Ekstrand
On Thu, Jul 1, 2021 at 6:42 AM Maarten Lankhorst wrote: > > This is only used for ttm, and tells userspace that the mapping type is > ignored. This disables the other type of mmap offsets when discrete > memory is used, so fix the selftests as well. > > Signed-off-by: Maarten Lankhorst > --- >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/debugfs: xelpd lpsp capability

2021-07-09 Thread Patchwork
== Series Details == Series: drm/i915/debugfs: xelpd lpsp capability URL : https://patchwork.freedesktop.org/series/92364/ State : success == Summary == CI Bug Log - changes from CI_DRM_10324 -> Patchwork_20563 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dg1: Compute MEM Bandwidth using MCHBAR (rev2)

2021-07-09 Thread Patchwork
== Series Details == Series: drm/i915/dg1: Compute MEM Bandwidth using MCHBAR (rev2) URL : https://patchwork.freedesktop.org/series/92094/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10320_full -> Patchwork_20557_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add TTM offset argument to mmap. (rev2)

2021-07-09 Thread Patchwork
== Series Details == Series: drm/i915: Add TTM offset argument to mmap. (rev2) URL : https://patchwork.freedesktop.org/series/92103/ State : success == Summary == CI Bug Log - changes from CI_DRM_10324 -> Patchwork_20562 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: Add TTM offset argument to mmap.

2021-07-09 Thread Maarten Lankhorst
Op 09-07-2021 om 11:30 schreef Matthew Auld: > On Mon, 5 Jul 2021 at 15:36, Matthew Auld > wrote: >> On Thu, 1 Jul 2021 at 12:50, Maarten Lankhorst >> wrote: >>> Op 01-07-2021 om 13:42 schreef Maarten Lankhorst: This is only used for ttm, and tells userspace that the mapping type is

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add TTM offset argument to mmap. (rev2)

2021-07-09 Thread Patchwork
== Series Details == Series: drm/i915: Add TTM offset argument to mmap. (rev2) URL : https://patchwork.freedesktop.org/series/92103/ State : warning == Summary == $ dim checkpatch origin/drm-tip 53107c2bf2c8 drm/i915: Add TTM offset argument to mmap. -:66: WARNING:PREFER_FALLTHROUGH: Prefer

[Intel-gfx] ✗ Fi.CI.IGT: failure for CT changes required for GuC submission

2021-07-09 Thread Patchwork
== Series Details == Series: CT changes required for GuC submission URL : https://patchwork.freedesktop.org/series/92330/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10320_full -> Patchwork_20556_full Summary ---

[Intel-gfx] [PATCH] drm/i915/debugfs: xelpd lpsp capability

2021-07-09 Thread Anshuman Gupta
Extend i915_lpsp_capability sysfs to xelpd and future platforms. Cc: Animesh Manna Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c

Re: [Intel-gfx] [PATCH v3 01/20] drm/sched: entity->rq selection cannot fail

2021-07-09 Thread Christian König
Am 09.07.21 um 10:00 schrieb Daniel Vetter: On Fri, Jul 9, 2021 at 9:23 AM Christian König wrote: Am 09.07.21 um 09:14 schrieb Daniel Vetter: On Fri, Jul 9, 2021 at 8:53 AM Christian König wrote: Am 08.07.21 um 19:37 schrieb Daniel Vetter: If it does, someone managed to set up a

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add missing docbook chapters for i915 uapi.

2021-07-09 Thread Patchwork
== Series Details == Series: drm/i915: Add missing docbook chapters for i915 uapi. URL : https://patchwork.freedesktop.org/series/92359/ State : success == Summary == CI Bug Log - changes from CI_DRM_10324 -> Patchwork_20561 Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for Set BPP in the kernel (rev2)

2021-07-09 Thread Patchwork
== Series Details == Series: Set BPP in the kernel (rev2) URL : https://patchwork.freedesktop.org/series/92312/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10320_full -> Patchwork_20554_full Summary ---

[Intel-gfx] [PATCH v2] drm/i915: Add TTM offset argument to mmap.

2021-07-09 Thread Maarten Lankhorst
This is only used for ttm, and tells userspace that the mapping type is ignored. This disables the other type of mmap offsets when discrete memory is used, so fix the selftests as well. Document the struct as well, so it shows up in docbook correctly. Changes since v1: - Add docbook entries.

[Intel-gfx] [PATCH] drm/i915: Add missing docbook chapters for i915 uapi.

2021-07-09 Thread Maarten Lankhorst
I noticed when grepping for DOC: that those were defined in the header, but not actually used. Fix it. Signed-off-by: Maarten Lankhorst --- Documentation/gpu/driver-uapi.rst | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/gpu/driver-uapi.rst

Re: [Intel-gfx] [PATCH v3 01/20] drm/sched: entity->rq selection cannot fail

2021-07-09 Thread Christian König
Am 09.07.21 um 09:14 schrieb Daniel Vetter: On Fri, Jul 9, 2021 at 8:53 AM Christian König wrote: Am 08.07.21 um 19:37 schrieb Daniel Vetter: If it does, someone managed to set up a sched_entity without schedulers, which is just a driver bug. NAK, it is perfectly valid for rq selection to

Re: [Intel-gfx] [PATCH] drm/sched: Barriers are needed for entity->last_scheduled

2021-07-09 Thread Christian König
Am 08.07.21 um 23:54 schrieb Daniel Vetter: It might be good enough on x86 with just READ_ONCE, but the write side should then at least be WRITE_ONCE because x86 has total store order. It's definitely not enough on arm. Fix this proplery, which means - explain the need for the barrier in

Re: [Intel-gfx] [PATCH v3 01/20] drm/sched: entity->rq selection cannot fail

2021-07-09 Thread Christian König
Am 08.07.21 um 19:37 schrieb Daniel Vetter: If it does, someone managed to set up a sched_entity without schedulers, which is just a driver bug. NAK, it is perfectly valid for rq selection to fail. See drm_sched_pick_best():     if (!sched->ready) {    

Re: [Intel-gfx] [PATCH] drm/i915: Add TTM offset argument to mmap.

2021-07-09 Thread Matthew Auld
On Mon, 5 Jul 2021 at 15:36, Matthew Auld wrote: > > On Thu, 1 Jul 2021 at 12:50, Maarten Lankhorst > wrote: > > > > Op 01-07-2021 om 13:42 schreef Maarten Lankhorst: > > > This is only used for ttm, and tells userspace that the mapping type is > > > ignored. This disables the other type of mmap

Re: [Intel-gfx] [PATCH v3 16/20] drm/msm: always wait for the exclusive fence

2021-07-09 Thread Daniel Vetter
On Fri, Jul 9, 2021 at 10:48 AM Christian König wrote: > Am 08.07.21 um 19:37 schrieb Daniel Vetter: > > From: Christian König > > > > Drivers also need to to sync to the exclusive fence when > > a shared one is present. > > > > Signed-off-by: Christian König > > [danvet: Not that hard to

Re: [Intel-gfx] [PATCH v3 01/20] drm/sched: entity->rq selection cannot fail

2021-07-09 Thread Daniel Vetter
On Fri, Jul 9, 2021 at 9:23 AM Christian König wrote: > Am 09.07.21 um 09:14 schrieb Daniel Vetter: > > On Fri, Jul 9, 2021 at 8:53 AM Christian König > > wrote: > >> Am 08.07.21 um 19:37 schrieb Daniel Vetter: > >>> If it does, someone managed to set up a sched_entity without > >>> schedulers,

  1   2   >