[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pmu: Avoid with_intel_runtime_pm within spinlock

== Series Details == Series: drm/i915/pmu: Avoid with_intel_runtime_pm within spinlock URL : https://patchwork.freedesktop.org/series/97124/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10908_full -> Patchwork_21645_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for Introduce Raptor Lake S (rev2)

== Series Details == Series: Introduce Raptor Lake S (rev2) URL : https://patchwork.freedesktop.org/series/96869/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10908_full -> Patchwork_21644_full Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: RPS tuning for light media playback (rev3)

== Series Details == Series: drm/i915/gt: RPS tuning for light media playback (rev3) URL : https://patchwork.freedesktop.org/series/97043/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10908_full -> Patchwork_21643_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/ttm: Async migration (rev6)

== Series Details == Series: drm/i915/ttm: Async migration (rev6) URL : https://patchwork.freedesktop.org/series/96798/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10908_full -> Patchwork_21642_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Avoid with_intel_runtime_pm within spinlock

== Series Details == Series: drm/i915/pmu: Avoid with_intel_runtime_pm within spinlock URL : https://patchwork.freedesktop.org/series/97124/ State : success == Summary == CI Bug Log - changes from CI_DRM_10908 -> Patchwork_21645 Summary

[Intel-gfx] [PATCH] drm/i915/pmu: Avoid with_intel_runtime_pm within spinlock

When guc timestamp ping worker runs it takes the spinlock and calls with_intel_runtime_pm. Since with_intel_runtime_pm may sleep, move the spinlock inside __update_guc_busyness_stats. Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 12 +++-

[Intel-gfx] ✓ Fi.CI.BAT: success for Introduce Raptor Lake S (rev2)

== Series Details == Series: Introduce Raptor Lake S (rev2) URL : https://patchwork.freedesktop.org/series/96869/ State : success == Summary == CI Bug Log - changes from CI_DRM_10908 -> Patchwork_21644 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Introduce Raptor Lake S (rev2)

== Series Details == Series: Introduce Raptor Lake S (rev2) URL : https://patchwork.freedesktop.org/series/96869/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/2] drm/i915/trace: clean up boilerplate organization

== Series Details == Series: series starting with [v2,1/2] drm/i915/trace: clean up boilerplate organization URL : https://patchwork.freedesktop.org/series/97106/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10907_full -> Patchwork_21640_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce Raptor Lake S (rev2)

== Series Details == Series: Introduce Raptor Lake S (rev2) URL : https://patchwork.freedesktop.org/series/96869/ State : warning == Summary == $ dim checkpatch origin/drm-tip 56b18da79200 drm/i915/rpl-s: Add PCI IDS for Raptor Lake S -:107: ERROR:COMPLEX_MACRO: Macros with complex values

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: RPS tuning for light media playback (rev3)

== Series Details == Series: drm/i915/gt: RPS tuning for light media playback (rev3) URL : https://patchwork.freedesktop.org/series/97043/ State : success == Summary == CI Bug Log - changes from CI_DRM_10908 -> Patchwork_21643 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gt: RPS tuning for light media playback (rev3)

== Series Details == Series: drm/i915/gt: RPS tuning for light media playback (rev3) URL : https://patchwork.freedesktop.org/series/97043/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] [v2 3/3] drm/i915/rpl-s: Enable guc submission by default

Though, RPL-S is defined as subplatform of ADL-S, unlike ADL-S, it has GuC submission by default. v2: Remove extra parenthesis (Jani) Cc: Jani Nikula Cc: Swathi Dhanavanthri Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +- 1 file changed, 1 insertion(+), 1

[Intel-gfx] [v2 2/3] drm/i915/rpl-s: Add PCH Support for Raptor Lake S

Add the PCH ID for RPL-S. v2: Self contained commit message (Jani) Cc: Jani Nikula Cc: Swathi Dhanavanthri Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/intel_pch.c | 1 + drivers/gpu/drm/i915/intel_pch.h | 1 + 2 files changed, 2 insertions(+) diff --git

[Intel-gfx] [v2 1/3] drm/i915/rpl-s: Add PCI IDS for Raptor Lake S

Raptor Lake S(RPL-S) is a version 12 Display, Media and Render. For all i915 purposes it is the same as Alder Lake S (ADL-S). Introduce RPL-S as a subplatform of ADL-S. This patch adds PCI ids for RPL-S. v2: Update PCI IDs. - Add more description to commit message (Jani) BSpec: 53655 Cc: Matt

[Intel-gfx] [v2 0/3] Introduce Raptor Lake S

Raptor Lake S(RPL-S) is a version 12 Display, Media and Render. For all i915 purposes it is the same as Alder Lake S (ADL-S). The series introduces it as a subplatform of ADL-S. The one difference is the GuC submission which is default on RPL-S but was not the case with ADL-S. Anusha Srivatsa

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Fix synchronization of PMU callback with reset

Hi Tvrtko, Any inputs on this one? Thanks, Umesh On Thu, Nov 11, 2021 at 08:48:10AM -0800, Umesh Nerlige Ramappa wrote: On Thu, Nov 11, 2021 at 02:37:43PM +, Tvrtko Ursulin wrote: On 04/11/2021 22:04, Umesh Nerlige Ramappa wrote: On Thu, Nov 04, 2021 at 05:37:37PM +, Tvrtko Ursulin

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] Revert "drm/i915: Implement Wa_1508744258"

== Series Details == Series: series starting with [1/2] Revert "drm/i915: Implement Wa_1508744258" URL : https://patchwork.freedesktop.org/series/97105/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10907_full -> Patchwork_21639_full

Re: [Intel-gfx] [PATCH v10 08/10] dyndbg: add print-to-tracefs, selftest with it - RFC

On Fri, 19 Nov 2021 15:46:31 -0700 jim.cro...@gmail.com wrote: > > So I could see us supporting subsystem specific trace buffer output > > via dynamic debug here. We could add new dev_debug() variants that > > allow say a trace buffer to be supplied. So in that way subsystems > > could 'opt-out'

Re: [Intel-gfx] [PATCH v10 08/10] dyndbg: add print-to-tracefs, selftest with it - RFC

On Fri, Nov 19, 2021 at 9:21 AM Jason Baron wrote: > > > > On 11/18/21 10:24 AM, Pekka Paalanen wrote: > > On Thu, 18 Nov 2021 09:29:27 -0500 > > Jason Baron wrote: > > > >> On 11/16/21 3:46 AM, Pekka Paalanen wrote: > >>> On Fri, 12 Nov 2021 10:08:41 -0500 > >>> Jason Baron wrote: > >>> >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/rpm: Enable runtime pm autosuspend by default (rev4)

== Series Details == Series: drm/i915/rpm: Enable runtime pm autosuspend by default (rev4) URL : https://patchwork.freedesktop.org/series/96741/ State : success == Summary == CI Bug Log - changes from CI_DRM_10896_full -> Patchwork_21622_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ttm: Async migration (rev6)

== Series Details == Series: drm/i915/ttm: Async migration (rev6) URL : https://patchwork.freedesktop.org/series/96798/ State : success == Summary == CI Bug Log - changes from CI_DRM_10908 -> Patchwork_21642 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/ttm: Async migration (rev6)

== Series Details == Series: drm/i915/ttm: Async migration (rev6) URL : https://patchwork.freedesktop.org/series/96798/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/2] i915/gvt: Introduce the mmio_info_table.c to support VFIO new mdev API

== Series Details == Series: series starting with [1/2] i915/gvt: Introduce the mmio_info_table.c to support VFIO new mdev API URL : https://patchwork.freedesktop.org/series/97110/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/trace: clean up boilerplate organization

== Series Details == Series: series starting with [v2,1/2] drm/i915/trace: clean up boilerplate organization URL : https://patchwork.freedesktop.org/series/97106/ State : success == Summary == CI Bug Log - changes from CI_DRM_10907 -> Patchwork_21640

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/2] drm/i915/trace: clean up boilerplate organization

== Series Details == Series: series starting with [v2,1/2] drm/i915/trace: clean up boilerplate organization URL : https://patchwork.freedesktop.org/series/97106/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/2] drm/i915/trace: clean up boilerplate organization

== Series Details == Series: series starting with [v2,1/2] drm/i915/trace: clean up boilerplate organization URL : https://patchwork.freedesktop.org/series/97106/ State : warning == Summary == $ dim checkpatch origin/drm-tip 783ba647fe60 drm/i915/trace: clean up boilerplate organization

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Rename gt to gt0

On Wed, Nov 17, 2021 at 02:16:13PM +, Chris Wilson wrote: Quoting Andi Shyti (2021-11-17 13:34:56) diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c index a9727447c0379..4bfedc04f5c70 100644 ---

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] Revert "drm/i915: Implement Wa_1508744258"

== Series Details == Series: series starting with [1/2] Revert "drm/i915: Implement Wa_1508744258" URL : https://patchwork.freedesktop.org/series/97105/ State : success == Summary == CI Bug Log - changes from CI_DRM_10907 -> Patchwork_21639

[Intel-gfx] ✓ Fi.CI.IGT: success for Add support for CD clock squashing feature.

== Series Details == Series: Add support for CD clock squashing feature. URL : https://patchwork.freedesktop.org/series/97104/ State : success == Summary == CI Bug Log - changes from CI_DRM_10906_full -> Patchwork_21638_full Summary

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/rpm: Enable runtime pm autosuspend by default (rev4)

Re-reported. -Original Message- From: Gupta, Anshuman Sent: Friday, November 19, 2021 2:40 AM To: Vudum, Lakshminarayana Cc: Tangudu, Tilak ; intel-gfx@lists.freedesktop.org Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/rpm: Enable runtime pm autosuspend by default (rev4)

Re: [Intel-gfx] [PATCH v4 6/6] drm/i915/ttm: Update i915_gem_obj_copy_ttm() to be asynchronous

On 18/11/2021 13:02, Thomas Hellström wrote: Update the copy function i915_gem_obj_copy_ttm() to be asynchronous for future users and update the only current user to sync the objects as needed after this function. Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld

Re: [Intel-gfx] [PATCH v4 5/6] drm/i915/ttm: Implement asynchronous TTM moves

On 18/11/2021 13:02, Thomas Hellström wrote: Don't wait sync while migrating, but rather make the GPU blit await the dependencies and add a moving fence to the object. This also enables asynchronous VRAM management in that on eviction, rather than waiting for the moving fence to expire before

Re: [Intel-gfx] [PATCH v3 5/5] drm/i915/dg2: extend Wa_1409120013 to DG2

On Fri, Nov 19, 2021 at 08:36:56AM -0800, Souza, Jose wrote: > On Tue, 2021-11-16 at 09:48 -0800, Matt Roper wrote: > > From: Matt Atwood > > > > Extend existing workaround 1409120013 to DG2. > > > > Cc: José Roberto de Souza > > Signed-off-by: Matt Atwood > > Signed-off-by: Matt Roper > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/rpm: Enable runtime pm autosuspend by default (rev4)

== Series Details == Series: drm/i915/rpm: Enable runtime pm autosuspend by default (rev4) URL : https://patchwork.freedesktop.org/series/96741/ State : success == Summary == CI Bug Log - changes from CI_DRM_10896 -> Patchwork_21622

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/6] drm/i915: move the pre_pin earlier (rev2)

Filed https://gitlab.freedesktop.org/drm/intel/-/issues/4570 for the latest regression. igt@gem_ctx_shared@q-smoketest@vecs0 - incomplete - No warnings/errors Rev2 regression is related to https://gitlab.freedesktop.org/drm/intel/-/issues/4564

Re: [Intel-gfx] Sparsely populated TTM bos

On Fri, Nov 19, 2021 at 05:35:53PM +0100, Christian König wrote: > Hi Thomas, > > Am 19.11.21 um 15:28 schrieb Thomas Hellström: > > Hi, Christian, > > > > We have an upcoming use-case in i915 where one solution would be > > sparsely populated TTM bos. > > > > We had that at one point where

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/6] drm/i915: move the pre_pin earlier (rev3)

== Series Details == Series: series starting with [v2,1/6] drm/i915: move the pre_pin earlier (rev3) URL : https://patchwork.freedesktop.org/series/97026/ State : success == Summary == CI Bug Log - changes from CI_DRM_10904_full -> Patchwork_21637_full

Re: [Intel-gfx] [PATCH 00/17] Add memberof(), split some headers, and slightly simplify code

On Fri, Nov 19, 2021 at 05:12:19PM +0100, Alejandro Colomar (man-pages) wrote: > On 11/19/21 16:57, Arnd Bergmann wrote: ... > > On the plus side, I did see something on the order of a 30% > > compile speed improvement with clang, which is insane > > given that this only removed dead

Re: [Intel-gfx] [PATCH v3 5/5] drm/i915/dg2: extend Wa_1409120013 to DG2

On Tue, 2021-11-16 at 09:48 -0800, Matt Roper wrote: > From: Matt Atwood > > Extend existing workaround 1409120013 to DG2. > > Cc: José Roberto de Souza > Signed-off-by: Matt Atwood > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/intel_pm.c | 4 ++-- > 1 file changed, 2

Re: [Intel-gfx] [PATCH 00/17] Add memberof(), split some headers, and slightly simplify code

On Fri, Nov 19, 2021 at 05:22:48PM +0100, Alejandro Colomar (man-pages) wrote: > > > On 11/19/21 17:18, Arnd Bergmann wrote: > > On Fri, Nov 19, 2021 at 5:10 PM Andy Shevchenko > > wrote: > >> On Fri, Nov 19, 2021 at 04:57:46PM +0100, Arnd Bergmann wrote: > > > >>> The main problem with this

Re: [Intel-gfx] [PATCH 00/17] Add memberof(), split some headers, and slightly simplify code

On Fri, Nov 19, 2021 at 5:22 PM Alejandro Colomar (man-pages) wrote: > On 11/19/21 17:18, Arnd Bergmann wrote: > > On Fri, Nov 19, 2021 at 5:10 PM Andy Shevchenko > > wrote: > >> On Fri, Nov 19, 2021 at 04:57:46PM +0100, Arnd Bergmann wrote: > > > >>> The main problem with this approach is that

Re: [Intel-gfx] [PATCH 00/17] Add memberof(), split some headers, and slightly simplify code

On Fri, Nov 19, 2021 at 5:12 PM Alejandro Colomar (man-pages) wrote: > > On 11/19/21 16:57, Arnd Bergmann wrote: > > > > From what I can tell, linux/stddef.h is tiny, I don't think it's really > > worth optimizing this part. I have spent some time last year > > trying to untangle some of the more

Re: [Intel-gfx] [PATCH 00/17] Add memberof(), split some headers, and slightly simplify code

On 11/19/21 17:18, Arnd Bergmann wrote: > On Fri, Nov 19, 2021 at 5:10 PM Andy Shevchenko > wrote: >> On Fri, Nov 19, 2021 at 04:57:46PM +0100, Arnd Bergmann wrote: > >>> The main problem with this approach is that as soon as you start >>> actually reducing the unneeded indirect includes, you

Re: [Intel-gfx] [PATCH 00/17] Add memberof(), split some headers, and slightly simplify code

On Fri, Nov 19, 2021 at 5:10 PM Andy Shevchenko wrote: > On Fri, Nov 19, 2021 at 04:57:46PM +0100, Arnd Bergmann wrote: > > The main problem with this approach is that as soon as you start > > actually reducing the unneeded indirect includes, you end up with > > countless .c files that no longer

Re: [Intel-gfx] [PATCH 00/17] Add memberof(), split some headers, and slightly simplify code

Hi Arnd, On 11/19/21 16:57, Arnd Bergmann wrote: > > From what I can tell, linux/stddef.h is tiny, I don't think it's really > worth optimizing this part. I have spent some time last year > trying to untangle some of the more interesting headers, but ended > up not completing this as there are

Re: [Intel-gfx] [PATCH 00/17] Add memberof(), split some headers, and slightly simplify code

On Fri, Nov 19, 2021 at 04:57:46PM +0100, Arnd Bergmann wrote: > On Fri, Nov 19, 2021 at 4:06 PM Alejandro Colomar (man-pages) > wrote: > > On 11/19/21 15:47, Arnd Bergmann wrote: > > > On Fri, Nov 19, 2021 at 12:36 PM Alejandro Colomar > > > > Yes, I would like to untangle the dependencies. > >

Re: [Intel-gfx] [PATCH] drm/i915: Don't disable interrupts and pretend a lock as been acquired in __timeline_mark_lock().

On Thu, Nov 18, 2021 at 05:59:14PM +0100, Sebastian Andrzej Siewior wrote: > This is a revert of commits >d67739268cf0e ("drm/i915/gt: Mark up the nested engine-pm timeline lock as > irqsafe") >6c69a45445af9 ("drm/i915/gt: Mark context->active_count as protected by > timeline->mutex") >

Re: [Intel-gfx] [PATCH 00/17] Add memberof(), split some headers, and slightly simplify code

On Fri, Nov 19, 2021 at 4:06 PM Alejandro Colomar (man-pages) wrote: > On 11/19/21 15:47, Arnd Bergmann wrote: > > On Fri, Nov 19, 2021 at 12:36 PM Alejandro Colomar > > Yes, I would like to untangle the dependencies. > > The main reason I started doing this splitting > is because I wouldn't be

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 3/6] igt/core: Fix build warning

On Fri, Nov 19, 2021 at 05:41:08PM +0200, Petri Latvala wrote: > On Fri, Nov 19, 2021 at 03:34:54PM +, Tvrtko Ursulin wrote: > > On 19/11/2021 13:53, Petri Latvala wrote: > > > On Fri, Nov 19, 2021 at 12:59:42PM +, Tvrtko Ursulin wrote: > > Okay I wasn't sufficiently focused while trying

[Intel-gfx] [PATCH v5 6/6] drm/i915/ttm: Update i915_gem_obj_copy_ttm() to be asynchronous

Update the copy function i915_gem_obj_copy_ttm() to be asynchronous for future users and update the only current user to sync the objects as needed after this function. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 40 ++--

[Intel-gfx] [PATCH v5 4/6] drm/i915/ttm: Correctly handle waiting for gpu when shrinking

With async migration, the shrinker may end up wanting to release the pages of an object while the migration blit is still running, since the GT migration code doesn't set up VMAs and the shrinker is thus oblivious to the fact that the GPU is still using the pages. Add waiting for gpu in the

[Intel-gfx] [PATCH v5 5/6] drm/i915/ttm: Implement asynchronous TTM moves

Don't wait sync while migrating, but rather make the GPU blit await the dependencies and add a moving fence to the object. This also enables asynchronous VRAM management in that on eviction, rather than waiting for the moving fence to expire before freeing VRAM, it is freed immediately and the

[Intel-gfx] [PATCH v5 2/6] drm/i915/ttm: Move the i915_gem_obj_copy_ttm() function

Move the i915_gem_obj_copy_ttm() function to i915_gem_ttm_move.h. This will help keep a number of functions static when introducing async moves. Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 47 ---

[Intel-gfx] [PATCH v5 3/6] drm/i915/ttm: Drop region reference counting

There is an interesting refcounting loop: struct intel_memory_region has a struct ttm_resource_manager, ttm_resource_manager->move may hold a reference to i915_request, i915_request may hold a reference to intel_context, intel_context may hold a reference to drm_i915_gem_object,

[Intel-gfx] [PATCH v5 1/6] drm/i915: Add support for moving fence waiting

From: Maarten Lankhorst For now, we will only allow async migration when TTM is used, so the paths we care about are related to TTM. The mmap path is handled by having the fence in ttm_bo->moving, when pinning, the binding only becomes available after the moving fence is signaled, and pinning a

[Intel-gfx] [PATCH v5 0/6] drm/i915/ttm: Async migration

This patch series deals with async migration and async vram management. It still leaves an important part out, which is async unbinding which will reduce latency further, at least when trying to migrate already active objects. Patches 1/6 deals with accessing and waiting for the TTM moving fence

Re: [Intel-gfx] [PATCH 1/1] drm/i915/dmc: Update DMC to v2.14 on ADL-P

On Fri, 2021-11-19 at 15:06 +, Srivatsa, Anusha wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf > > Of Imre > > Deak > > Sent: Friday, November 19, 2021 4:58 AM > > To: Tolakanahalli Pradeep, Madhumitha > > > > Cc: intel-gfx@lists.freedesktop.org > > Subject: Re:

Re: [Intel-gfx] [PATCH i-g-t 3/6] igt/core: Fix build warning

On Fri, Nov 19, 2021 at 03:34:54PM +, Tvrtko Ursulin wrote: > > On 19/11/2021 13:53, Petri Latvala wrote: > > On Fri, Nov 19, 2021 at 12:59:42PM +, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > .../lib/igt_thread.c: In function ‘__igt_uniqueigt_constructor_l66’: > > >

Re: [Intel-gfx] [PATCH 00/17] Add memberof(), split some headers, and slightly simplify code

Hi Andy, On 11/19/21 16:34, Andy Shevchenko wrote: > On Fri, Nov 19, 2021 at 04:06:27PM +0100, Alejandro Colomar (man-pages) wrote: >> Yes, I would like to untangle the dependencies. >> >> The main reason I started doing this splitting >> is because I wouldn't be able to include >> in some

Re: [Intel-gfx] [PATCH 00/17] Add memberof(), split some headers, and slightly simplify code

On Fri, Nov 19, 2021 at 04:06:27PM +0100, Alejandro Colomar (man-pages) wrote: > Hi Arnd, > > On 11/19/21 15:47, Arnd Bergmann wrote: > > On Fri, Nov 19, 2021 at 12:36 PM Alejandro Colomar > > wrote: > >> > >> Alejandro Colomar (17): > >> linux/container_of.h: Add memberof(T, m) > >> Use

Re: [Intel-gfx] [PATCH i-g-t 3/6] igt/core: Fix build warning

On 19/11/2021 13:53, Petri Latvala wrote: On Fri, Nov 19, 2021 at 12:59:42PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin .../lib/igt_thread.c: In function ‘__igt_uniqueigt_constructor_l66’: .../lib/igt_thread.c:68:9: warning: ‘pthread_setspecific’ expecting 1 byte in a region of

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/6] drm/i915: move the pre_pin earlier (rev3)

On 19/11/2021 13:53, Patchwork wrote: *Patch Details* *Series:* series starting with [v2,1/6] drm/i915: move the pre_pin earlier (rev3) *URL:* https://patchwork.freedesktop.org/series/97026/ *State:*failure *Details:*

Re: [Intel-gfx] [PATCH 00/17] Add memberof(), split some headers, and slightly simplify code

Hi Jani, On 11/19/21 13:47, Jani Nikula wrote: On Fri, 19 Nov 2021, Alejandro Colomar wrote: In the first and second commits I changed a lot of stuff in many parts, and that's why I CCd so many people (also in this cover letter). However, to avoid spamming, and since it would be a nightmare

[Intel-gfx] [PATCH 2/2] i915/gvt: save the MMIO snapshot in the early init of GVT-g

From: Zhi Wang To support the early init of GVT-g, which will be put in i915, after the GVT-g is moved into a dedicated module, we need to save the MMIO snapshot in the early init of GVT-g, when the HW hasn't been touched. Cc: Christoph Hellwig Cc: Jason Gunthorpe Cc: Jani Nikula Cc: Joonas

Re: [Intel-gfx] [PATCH 00/17] Add memberof(), split some headers, and slightly simplify code

Hi Arnd, On 11/19/21 15:47, Arnd Bergmann wrote: > On Fri, Nov 19, 2021 at 12:36 PM Alejandro Colomar > wrote: >> >> Alejandro Colomar (17): >> linux/container_of.h: Add memberof(T, m) >> Use memberof(T, m) instead of explicit NULL dereference >> Replace some uses of memberof() by its

[Intel-gfx] [PATCH 1/2] i915/gvt: Introduce the mmio_info_table.c to support VFIO new mdev API

From: Zhi Wang To support the new mdev interfaces and the re-factor patches from Christoph, which moves the GVT-g code into a dedicated module, the GVT-g initialization path has to be seperated into two phases: a) Early initialization. The early initialization of GVT requires to be done when

Re: [Intel-gfx] [PATCH v10 08/10] dyndbg: add print-to-tracefs, selftest with it - RFC

On 11/16/21 3:46 AM, Pekka Paalanen wrote: > On Fri, 12 Nov 2021 10:08:41 -0500 > Jason Baron wrote: > >> On 11/12/21 6:49 AM, Vincent Whitchurch wrote: >>> On Thu, Nov 11, 2021 at 03:02:04PM -0700, Jim Cromie wrote: Sean Paul proposed, in:

[Intel-gfx] [PATCH 02/17] Use memberof(T, m) instead of explicit NULL dereference

Signed-off-by: Alejandro Colomar Cc: Ajit Khaparde Cc: Andrew Morton Cc: Andy Shevchenko Cc: Arnd Bergmann Cc: Bjorn Andersson Cc: Borislav Petkov Cc: Corey Minyard Cc: Chris Mason Cc: Christian Brauner Cc: David Sterba Cc: Jani Nikula Cc: Jason Wang Cc: Jitendra Bhivare Cc: John

[Intel-gfx] [PATCH 00/17] Add memberof(), split some headers, and slightly simplify code

Hi all, I simplified some xxxof() macros, by adding a new macro memberof(), which implements a common operation in many of them. I also splitted many of those macros into tiny headers, since I noticed that touching those headers implied recompiling almost the whole kernel. Hopefully after

Re: [Intel-gfx] [PATCH 1/1] drm/i915/dmc: Update DMC to v2.14 on ADL-P

> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Friday, November 19, 2021 4:58 AM > To: Tolakanahalli Pradeep, Madhumitha > > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 1/1] drm/i915/dmc: Update DMC to v2.14 on > ADL-P > > On Thu,

Re: [Intel-gfx] [PATCH 1/1] drm/i915/dmc: Update DMC to v2.14 on ADL-P

> -Original Message- > From: Intel-gfx On Behalf Of > Madhumitha Tolakanahalli Pradeep > Sent: Thursday, November 18, 2021 10:31 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 1/1] drm/i915/dmc: Update DMC to v2.14 on ADL- > P > > The release notes mention that

Re: [Intel-gfx] [PATCH 00/17] Add memberof(), split some headers, and slightly simplify code

On Fri, Nov 19, 2021 at 12:36 PM Alejandro Colomar wrote: > > Alejandro Colomar (17): > linux/container_of.h: Add memberof(T, m) > Use memberof(T, m) instead of explicit NULL dereference > Replace some uses of memberof() by its wrappers > linux/memberof.h: Move memberof() to separate

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Don't disable interrupts and pretend a lock as been acquired in __timeline_mark_lock().

On 2021-11-19 08:47:56 [-], Patchwork wrote: > == Series Details == > > Series: drm/i915: Don't disable interrupts and pretend a lock as been > acquired in __timeline_mark_lock(). > URL : https://patchwork.freedesktop.org/series/97082/ > State : failure > > == Summary == > > CI Bug Log -

Re: [Intel-gfx] [PATCH 00/17] Add memberof(), split some headers, and slightly simplify code

On Fri, Nov 19, 2021 at 02:16:03PM +0100, Alejandro Colomar (man-pages) wrote: > On 11/19/21 13:47, Jani Nikula wrote: > > On Fri, 19 Nov 2021, Alejandro Colomar wrote: ... > Patch set 1: > - Add with memberof() > - Split offsetof() to > - Split offsetofend() to > - Split typeof_member() to

[Intel-gfx] Sparsely populated TTM bos

Hi, Christian, We have an upcoming use-case in i915 where one solution would be sparsely populated TTM bos. We had that at one point where ttm_tt pages were allocated on demand, but this time we'd rather be looking at multiple struct ttm_resources per bo and those resources could be from

[Intel-gfx] ✓ Fi.CI.BAT: success for Add support for CD clock squashing feature.

== Series Details == Series: Add support for CD clock squashing feature. URL : https://patchwork.freedesktop.org/series/97104/ State : success == Summary == CI Bug Log - changes from CI_DRM_10906 -> Patchwork_21638 Summary ---

Re: [Intel-gfx] [PATCH 1/2] Revert "drm/i915: Implement Wa_1508744258"

On Fri, 2021-11-19 at 06:09 -0800, José Roberto de Souza wrote: > This workarounds are causing hangs, because I missed the fact that it > needs to be enabled for all cases and disabled when doing a resolve > pass. > > So KMD only needs to whitelist it and UMD will be the one setting it > on per

[Intel-gfx] [PATCH v2 2/2] drm/i915/trace: split out display trace to a separate file

Add display/intel_display_trace.[ch] for defining display tracepoints. The main goal is to reduce cross-includes between gem and display. It would be possible split up tracing even further, but that would lead to more boilerplate. There should be no changes to tracepoints. v2: - Define

[Intel-gfx] [PATCH v2 1/2] drm/i915/trace: clean up boilerplate organization

Follow the style that seems to be prevalent in kernel for undef and define of TRACE_SYSTEM, TRACE_INCLUDE_PATH, and TRACE_INCLUDE_FILE. There should be no changes to tracepoints. v2: Keep TRACE_INCLUDE_PATH relative to define_trace.h (Chris) Cc: Ville Syrjälä Signed-off-by: Jani Nikula

[Intel-gfx] [PATCH 2/2] drm/i915: Add workaround numbers to GEN7_COMMON_SLICE_CHICKEN1 whitelisting

Those two workarounds needs to be implemented in UMD, KMD only needs to whitelist the registers, so here only adding the workaround number to facilitate future workaroud table checks. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 +- 1 file

[Intel-gfx] [PATCH 1/2] Revert "drm/i915: Implement Wa_1508744258"

This workarounds are causing hangs, because I missed the fact that it needs to be enabled for all cases and disabled when doing a resolve pass. So KMD only needs to whitelist it and UMD will be the one setting it on per case. This reverts commit 28ec02c9cbebf3feeaf21a59df9dfbc02bda3362. Fixes:

Re: [Intel-gfx] [PATCH i-g-t 3/6] igt/core: Fix build warning

On Fri, Nov 19, 2021 at 12:59:42PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > .../lib/igt_thread.c: In function ‘__igt_uniqueigt_constructor_l66’: > .../lib/igt_thread.c:68:9: warning: ‘pthread_setspecific’ expecting 1 byte in > a region of size 0 [-Wstringop-overread] >68

Re: [Intel-gfx] [PATCH] drm/i915/pxp: fix includes for headers in include/drm

On Tue, 16 Nov 2021, Rodrigo Vivi wrote: > On Tue, Nov 16, 2021 at 03:58:13PM +0200, Jani Nikula wrote: >> Use <> not "" for including headers from include/drm. >> >> Signed-off-by: Jani Nikula > > Reviewed-by: Rodrigo Vivi Thanks, pushed to drm-intel-next. BR, Jani. > >> --- >>

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/6] drm/i915: move the pre_pin earlier (rev3)

== Series Details == Series: series starting with [v2,1/6] drm/i915: move the pre_pin earlier (rev3) URL : https://patchwork.freedesktop.org/series/97026/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10904_full -> Patchwork_21637_full

Re: [Intel-gfx] [PATCH 5/5] drm/i915: drop intel_display.h include from intel_display_power.h

On Tue, 16 Nov 2021, Daniel Vetter wrote: > On Tue, Nov 16, 2021 at 07:14:34PM +0200, Jani Nikula wrote: >> Use forward declarations instead. >> >> Cc: Imre Deak >> Signed-off-by: Jani Nikula > > On the series: Reviewed-by: Daniel Vetter > > I'm assuming you've copypaste stuff correctly, at a

Re: [Intel-gfx] [PATCH 00/17] Add memberof(), split some headers, and slightly simplify code

On Fri, 19 Nov 2021, "Alejandro Colomar (man-pages)" wrote: > Hi Jani, > > On 11/19/21 13:47, Jani Nikula wrote: >> On Fri, 19 Nov 2021, Alejandro Colomar wrote: >>> In the first and second commits >>> I changed a lot of stuff in many parts, >>> and that's why I CCd so many people (also in this

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add support for CD clock squashing feature.

== Series Details == Series: Add support for CD clock squashing feature. URL : https://patchwork.freedesktop.org/series/97104/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add support for CD clock squashing feature.

== Series Details == Series: Add support for CD clock squashing feature. URL : https://patchwork.freedesktop.org/series/97104/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1372fab833bb drm/i915/display/dg2: Introduce CD clock squashing table -:9: WARNING:COMMIT_LOG_LONG_LINE:

[Intel-gfx] ✗ Fi.CI.IGT: failure for Bump DMC version on ADL-P to v2.14

== Series Details == Series: Bump DMC version on ADL-P to v2.14 URL : https://patchwork.freedesktop.org/series/97093/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10904_full -> Patchwork_21636_full Summary ---

[Intel-gfx] [PATCH v2 5/5] drm/i915: Allow cdclk squasher to be reconfigured live

From: Ville Syrjälä Supposedly we should be able to change the cdclk squasher waveform even when many pipes are active. Make it so. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_cdclk.c | 40 -- 1 file changed, 37 insertions(+), 3 deletions(-) diff

[Intel-gfx] [PATCH v2 4/5] drm/i915/display/dg2: Read CD clock from squasher table

To calculate CD clock with squasher unit, we set CD clock ratio to fixed value of 34. The CD clock value is read from CD clock squasher table. BSpec: 54034 v2: Read ratio from register (Ville) Drop unnecessary local variable (Ville) Get CD clock from the given table v3: Calculate CD

[Intel-gfx] [PATCH v2 3/5] drm/i915/display/dg2: Set CD clock squashing registers

Set CD clock squashing registers based on selected CD clock. v2: use slk_cdclk_decimal() to compute decimal values instead of a specific table (Ville) Set waveform based on CD clock table (Ville) Drop unnecessary local variable (Ville) v3: Correct function naming (Ville) Correct

[Intel-gfx] [PATCH v2 2/5] drm/i915/display/dg2: Sanitize CD clock

In case of CD clock squashing the divider is always 1. We don't need to calculate the divider in use so let's skip that for DG2. v2: Drop unnecessary local variable (Ville) v3: Avoid if-else structure (Ville) [v4: vsyrjala: Fix cd2x divider calculation (Uma), Introduce

[Intel-gfx] [PATCH v2 1/5] drm/i915/display/dg2: Introduce CD clock squashing table

For CD clock squashing method, we need to define corresponding CD clock table for reference clocks, dividers and ratios for all CD clock options. BSpec: 54034 v2: Add CD squashing waveforms as part of CD clock table (Ville) v3: Waveform is 16 bits wide (Ville) [v4: vsyrjala: Nuke the

[Intel-gfx] [PATCH v2 0/5] Add support for CD clock squashing feature.

Add support for CD clock squashing feature. v2: Reorder patches (Jani) Add Ville's "Allow cdclk squasher to be reconfigured live" to the series Signed-off-by: Mika Kahola Signed-off-by: Ville Syrjälä Mika Kahola (4): drm/i915/display/dg2: Introduce CD clock squashing table

[Intel-gfx] [PATCH i-g-t 6/6] intel_gpu_top: Add a sanity check discovered busy metric is per engine

From: Tvrtko Ursulin Adding a cross-check with ABI config name space and not just relying on sysfs names. Signed-off-by: Tvrtko Ursulin Cc: Dmitry Rogozhkin --- tools/intel_gpu_top.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c index

[Intel-gfx] [PATCH i-g-t 5/6] intel_gpu_top: Remove clients support

From: Tvrtko Ursulin When kernel feature was removed the intel_gpu_top part was forgotten. Signed-off-by: Tvrtko Ursulin Cc: Daniel Vetter --- man/intel_gpu_top.rst | 4 - tools/intel_gpu_top.c | 810 +- 2 files changed, 1 insertion(+), 813

[Intel-gfx] [PATCH i-g-t 4/6] igt/drm_read: Fix build warning

From: Tvrtko Ursulin In function ‘read’, inlined from ‘test_invalid_buffer’ at ../../home/tursulin/wc/intel-gpu-tools/tests/drm_read.c:113:2, inlined from ‘__igt_uniquereal_main258’ at ../../home/tursulin/wc/intel-gpu-tools/tests/drm_read.c:297:3:

[Intel-gfx] [PATCH i-g-t 3/6] igt/core: Fix build warning

From: Tvrtko Ursulin .../lib/igt_thread.c: In function ‘__igt_uniqueigt_constructor_l66’: .../lib/igt_thread.c:68:9: warning: ‘pthread_setspecific’ expecting 1 byte in a region of size 0 [-Wstringop-overread] 68 | pthread_setspecific(__igt_is_main_thread, (void*) 0x1); |

  1   2   >