[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c

2022-04-14 Thread Patchwork
== Series Details == Series: series starting with [CI,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c URL : https://patchwork.freedesktop.org/series/102719/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11503_full -> Patchwork_102719v1_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/4] drm/i915/doc: Convert drm_i915_query_topology_info comment to kerneldoc

2022-04-14 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915/doc: Convert drm_i915_query_topology_info comment to kerneldoc URL : https://patchwork.freedesktop.org/series/102713/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11503_full -> Patchwork_102713v1_full

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: Load DMC on DG2 (rev4)

2022-04-14 Thread Lucas De Marchi
On Thu, Apr 14, 2022 at 08:54:49PM +, Anusha Srivatsa wrote: HI, The result here says SUCCESS but closer look shows that it never ran on any DG2. Wanted to know if something went wrong at the system side and if it needs to be revived. The patch is simply loading DMC and shouldn’t cause

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Load DMC on DG2

2022-04-14 Thread Lucas De Marchi
On Tue, Apr 12, 2022 at 05:57:07PM -0700, Anusha Srivatsa wrote: Add Support for DC states on Dg2. Signed-off-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi Failure in CI seems unrelated. Although it's unfortunate the DG2 couldn't get tested with this patch. were you able to test this

Re: [Intel-gfx] [PATCH 09/10] drm/i915/dg2: Enable Wa_14014475959 - RCS / CCS context exit

2022-04-14 Thread Matthew Brost
On Wed, Apr 13, 2022 at 12:27:29PM -0700, Umesh Nerlige Ramappa wrote: > From: Matthew Brost > > There is bug in DG2 where if the CCS contexts switches out while the RCS > is running it can cause memory corruption. To workaround this add an > atomic to a memory address with a value 1 and

[Intel-gfx] ✓ Fi.CI.IGT: success for Drop wbinvd_on_all_cpus usage

2022-04-14 Thread Patchwork
== Series Details == Series: Drop wbinvd_on_all_cpus usage URL : https://patchwork.freedesktop.org/series/102710/ State : success == Summary == CI Bug Log - changes from CI_DRM_11502_full -> Patchwork_102710v1_full Summary ---

Re: [Intel-gfx] [PATCH 9/9] vfio: Remove calls to vfio_group_add_container_user()

2022-04-14 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Thursday, April 14, 2022 10:22 PM > > On Thu, Apr 14, 2022 at 09:51:49AM -0400, Matthew Rosato wrote: > > On 4/12/22 11:53 AM, Jason Gunthorpe wrote: > > > When the open_device() op is called the container_users is incremented > and > > > held incremented until

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Don't show client busyness in fdinfo with GuC submission (rev4)

2022-04-14 Thread Patchwork
== Series Details == Series: drm/i915: Don't show client busyness in fdinfo with GuC submission (rev4) URL : https://patchwork.freedesktop.org/series/102676/ State : success == Summary == CI Bug Log - changes from CI_DRM_11504 -> Patchwork_102676v4

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Don't show client busyness in fdinfo with GuC submission (rev4)

2022-04-14 Thread Patchwork
== Series Details == Series: drm/i915: Don't show client busyness in fdinfo with GuC submission (rev4) URL : https://patchwork.freedesktop.org/series/102676/ State : warning == Summary == Error: dim checkpatch failed f88e1e858cef drm/i915: Don't show engine information in fdinfo with GuC

Re: [Intel-gfx] [PATCH 10/10] drm/i915/dg2: Enable Wa_22012727170/Wa_22012727685

2022-04-14 Thread Umesh Nerlige Ramappa
On Thu, Apr 14, 2022 at 05:22:47PM -0700, John Harrison wrote: On 4/13/2022 12:27, Umesh Nerlige Ramappa wrote: From: John Harrison The above two workaronuds regarding context isolation are implemented workaronuds -> workarounds by GuC. The KMD just needs to enable them. v2: Use dg2

[Intel-gfx] [PATCH v3] drm/i915: Don't show engine information in fdinfo with GuC submission

2022-04-14 Thread Ashutosh Dixit
At present i915 does not fetch busyness information from GuC, resulting in incorrect busyness values in fdinfo. Because engine information is coupled with busyness in fdinfo, skip showing client engine information in fdinfo with GuC submission till fetching busyness is supported in the i915 GuC

Re: [Intel-gfx] [PATCH 10/10] drm/i915/dg2: Enable Wa_22012727170/Wa_22012727685

2022-04-14 Thread John Harrison
On 4/13/2022 12:27, Umesh Nerlige Ramappa wrote: From: John Harrison The above two workaronuds regarding context isolation are implemented workaronuds -> workarounds by GuC. The KMD just needs to enable them. v2: Use dg2 stepping for ctx isolation WA (Umesh) v3: Rebase (Umesh) v4: Fix WA

Re: [Intel-gfx] [PATCH 09/10] drm/i915/dg2: Enable Wa_14014475959 - RCS / CCS context exit

2022-04-14 Thread John Harrison
On 4/13/2022 12:27, Umesh Nerlige Ramappa wrote: From: Matthew Brost There is bug in DG2 where if the CCS contexts switches out while the RCS is running it can cause memory corruption. To workaround this add an atomic to a memory address with a value 1 and semaphore wait to the same address

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Don't show client busyness in fdinfo with GuC submission (rev3)

2022-04-14 Thread Patchwork
== Series Details == Series: drm/i915: Don't show client busyness in fdinfo with GuC submission (rev3) URL : https://patchwork.freedesktop.org/series/102676/ State : success == Summary == CI Bug Log - changes from CI_DRM_11503 -> Patchwork_102676v3

Re: [Intel-gfx] [PATCH 08/10] drm/i915/guc: Apply Wa_16011777198

2022-04-14 Thread John Harrison
On 4/13/2022 12:27, Umesh Nerlige Ramappa wrote: From: Vinay Belgaumkar Enable GuC Wa to reset RCS/CCS before it goes into RC6. v2: Comments from Matt R. Signed-off-by: Vinay Belgaumkar Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 +

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/1] i915/gem: drop wbinvd_on_all_cpus usage

2022-04-14 Thread Patchwork
== Series Details == Series: series starting with [v2,1/1] i915/gem: drop wbinvd_on_all_cpus usage URL : https://patchwork.freedesktop.org/series/102708/ State : success == Summary == CI Bug Log - changes from CI_DRM_11501_full -> Patchwork_102708v1_full

Re: [Intel-gfx] [PATCH 1/1] drm/i915/guc: Update to GuC version 70.1.1

2022-04-14 Thread Matt Roper
On Tue, Apr 12, 2022 at 03:59:55PM -0700, john.c.harri...@intel.com wrote: > From: John Harrison > > The latest GuC firmware drops the context descriptor pool in favour of > passing all creation data in the create H2G. It also greatly simplifies > the work queue and removes the process

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't show engine information in fdinfo with GuC submission

2022-04-14 Thread Ceraolo Spurio, Daniele
On 4/14/2022 2:24 PM, Ashutosh Dixit wrote: At present i915 does not fetch busyness information from GuC, resulting in incorrect busyness values in fdinfo. Because engine information is coupled with busyness in fdinfo, skip showing client engine information in fdinfo with GuC submission till

Re: [Intel-gfx] [PATCH 06/10] drm/i915: Add Wa_22011802037 force cs halt

2022-04-14 Thread John Harrison
On 4/13/2022 12:27, Umesh Nerlige Ramappa wrote: From: Tilak Tangudu Prior to doing a reset, SW must ensure command streamer is stopped, as a workaround, to eliminate a race condition in GPM flow. Setting both the ring stop and prefetch disable bits, will cause the command streamer to halt.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Don't show client busyness in fdinfo with GuC submission (rev3)

2022-04-14 Thread Patchwork
== Series Details == Series: drm/i915: Don't show client busyness in fdinfo with GuC submission (rev3) URL : https://patchwork.freedesktop.org/series/102676/ State : warning == Summary == Error: dim checkpatch failed 0899841de83a drm/i915: Don't show engine information in fdinfo with GuC

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c

2022-04-14 Thread Patchwork
== Series Details == Series: series starting with [CI,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c URL : https://patchwork.freedesktop.org/series/102719/ State : success == Summary == CI Bug Log - changes from CI_DRM_11503 -> Patchwork_102719v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c

2022-04-14 Thread Patchwork
== Series Details == Series: series starting with [CI,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c URL : https://patchwork.freedesktop.org/series/102719/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c

2022-04-14 Thread Patchwork
== Series Details == Series: series starting with [CI,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c URL : https://patchwork.freedesktop.org/series/102719/ State : warning == Summary == Error: dim checkpatch failed c5b4984a0598 drm/i915: Move per-platform

[Intel-gfx] ✗ Fi.CI.BAT: failure for ALSA: hda: handle UAF at probe error

2022-04-14 Thread Patchwork
== Series Details == Series: ALSA: hda: handle UAF at probe error URL : https://patchwork.freedesktop.org/series/102714/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11503 -> Patchwork_102714v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for ALSA: hda: handle UAF at probe error

2022-04-14 Thread Patchwork
== Series Details == Series: ALSA: hda: handle UAF at probe error URL : https://patchwork.freedesktop.org/series/102714/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/4] drm/i915/doc: Convert drm_i915_query_topology_info comment to kerneldoc

2022-04-14 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915/doc: Convert drm_i915_query_topology_info comment to kerneldoc URL : https://patchwork.freedesktop.org/series/102713/ State : success == Summary == CI Bug Log - changes from CI_DRM_11503 -> Patchwork_102713v1

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Don't show client busyness in fdinfo with GuC submission (rev2)

2022-04-14 Thread Patchwork
== Series Details == Series: drm/i915: Don't show client busyness in fdinfo with GuC submission (rev2) URL : https://patchwork.freedesktop.org/series/102676/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11500_full -> Patchwork_102676v2_full

Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-04-14 Thread Dixit, Ashutosh
On Thu, 14 Apr 2022 06:28:57 -0700, Jani Nikula wrote: > > On Wed, 13 Apr 2022, Ashutosh Dixit wrote: > > Each gt contains an independent instance of pcode. Extend pcode functions > > to interface with pcode on different gt's. Previous (GT0) pcode read/write > > interfaces are preserved. > > The

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/4] drm/i915/doc: Convert drm_i915_query_topology_info comment to kerneldoc

2022-04-14 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915/doc: Convert drm_i915_query_topology_info comment to kerneldoc URL : https://patchwork.freedesktop.org/series/102713/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit

Re: [Intel-gfx] [PATCH v5 03/10] drm/hdcp: Update property value on content type and user changes

2022-04-14 Thread Rodrigo Vivi
On Thu, Apr 14, 2022 at 03:58:02PM +, Sean Paul wrote: > On Tue, Apr 12, 2022 at 09:25:59AM -0400, Rodrigo Vivi wrote: > > On Mon, Apr 11, 2022 at 08:47:32PM +, Sean Paul wrote: > > > From: Sean Paul > > > > > > This patch updates the connector's property value in 2 cases which were > >

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dmc: Load DMC on DG2 (rev4)

2022-04-14 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Load DMC on DG2 (rev4) URL : https://patchwork.freedesktop.org/series/102630/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11500_full -> Patchwork_102630v4_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for Drop wbinvd_on_all_cpus usage

2022-04-14 Thread Patchwork
== Series Details == Series: Drop wbinvd_on_all_cpus usage URL : https://patchwork.freedesktop.org/series/102710/ State : success == Summary == CI Bug Log - changes from CI_DRM_11502 -> Patchwork_102710v1 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH] drm/i915: Reserving some Multi-thread forcewake bits.

2022-04-14 Thread Vivi, Rodrigo
On Thu, 2022-04-14 at 14:14 -0700, Matt Roper wrote: > On Wed, Apr 13, 2022 at 05:39:27PM -0400, Rodrigo Vivi wrote: > > Bit 0: Currently bit used by i915. Ideally only i915 touches it > >    in a Linux stack. > > > > Bits 1 and 2: A while ago we were using Bit 1 for i915 and bit 2 > >    

[Intel-gfx] [PATCH v2] drm/i915: Don't show engine information in fdinfo with GuC submission

2022-04-14 Thread Ashutosh Dixit
At present i915 does not fetch busyness information from GuC, resulting in incorrect busyness values in fdinfo. Because engine information is coupled with busyness in fdinfo, skip showing client engine information in fdinfo with GuC submission till fetching busyness is supported in the i915 GuC

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Drop wbinvd_on_all_cpus usage

2022-04-14 Thread Patchwork
== Series Details == Series: Drop wbinvd_on_all_cpus usage URL : https://patchwork.freedesktop.org/series/102710/ State : warning == Summary == Error: dim checkpatch failed e1e1903177c2 i915/gem: drop wbinvd_on_all_cpus usage -:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v3,1/2] drm/dp: Factor out a function to probe a DPCD address (rev3)

2022-04-14 Thread Vudum, Lakshminarayana
Re-reported. -Original Message- From: Deak, Imre Sent: Thursday, April 14, 2022 11:33 AM To: intel-gfx@lists.freedesktop.org; Nikula, Jani ; Almahallawy, Khaled Cc: Vudum, Lakshminarayana Subject: Re: ✗ Fi.CI.IGT: failure for series starting with [v3,1/2] drm/dp: Factor out a

Re: [Intel-gfx] [PATCH] drm/i915: Reserving some Multi-thread forcewake bits.

2022-04-14 Thread Matt Roper
On Wed, Apr 13, 2022 at 05:39:27PM -0400, Rodrigo Vivi wrote: > Bit 0: Currently bit used by i915. Ideally only i915 touches it >in a Linux stack. > > Bits 1 and 2: A while ago we were using Bit 1 for i915 and bit 2 > for the user space, until commit 7130630323c5

[Intel-gfx] [CI 13/18] drm/i915: Sanitize the ADL-S power well definition

2022-04-14 Thread Imre Deak
Instead of the skip_mask special casing of the ADL-S power well descriptors, add a power well descriptor list for ADL-S as well reusing the TGL descriptors, w/o the TC-cold power well. ADL-S doesn't have TypeC PHYs, so a better way would be having ADL-S specific AUX descriptors, but I left

[Intel-gfx] [CI 15/18] drm/i915: Remove the aliasing of power domain enum values

2022-04-14 Thread Imre Deak
Aliasing the intel_display_power_domain enum values was required because of the u64 power domain mask size limit. This makes the dmesg/debugfs printouts of the domain names somewhat unclear, for instance domain names for port D are shown on D12+ platforms where the corresponding port is called

[Intel-gfx] [CI 18/18] drm/i915: Remove the XELPD specific AUX and DDI power domains

2022-04-14 Thread Imre Deak
The spec calls the XELPD_D/E ports just D/E, the platform prefix in the domain names was only needed by the port->domain mapping relying on matching enum values for the whole port/domain range (and the corresponding aliasing between the platform specific domain enums). Since a previous patch we

[Intel-gfx] [CI 11/18] drm/i915: Allow platforms to share power well descriptors

2022-04-14 Thread Imre Deak
Some power wells - like always-on and skl+/icl+ PW_1 - with the same name, domain list, flags, ops are used by multiple platforms, so allow platforms to reuse the descriptors of such power wells. This change also lets the follow up patches to simplify the DG1/RKL power well definitions, and

[Intel-gfx] [CI 17/18] drm/i915: Remove duplicate DDI/AUX power domain mappings

2022-04-14 Thread Imre Deak
The DDI and AUX domain -> power well mappings are identical for a few platforms/power well instances, reuse the mappings of earlier platforms for these removing the duplicate mapping of new platforms. Signed-off-by: Imre Deak Reviewed-by: Jouni Högander ---

[Intel-gfx] [CI 16/18] drm/i915: Remove the ICL specific TBT power domains

2022-04-14 Thread Imre Deak
The spec calls the ICL TBT AUX power well instances TBT1-4 (similarly to all later platforms), align the power domain names with the spec. Signed-off-by: Imre Deak Reviewed-by: Jouni Högander --- .../gpu/drm/i915/display/intel_display_power.c | 10 +-

[Intel-gfx] [CI 12/18] drm/i915: Simplify the DG1 power well descriptors

2022-04-14 Thread Imre Deak
Simplify the definition of DG1 power wells by reusing the identical RKL DDI/AUX descriptors. This reorders the DG1 DDI/AUX vs. PW4/5 power wells, but this shouldn't make a difference (it is the order on RKL and the DDI/AUX power wells don't have a dependency on PW4/5). Signed-off-by: Imre Deak

[Intel-gfx] [CI 14/18] drm/i915: Sanitize the port -> DDI/AUX power domain mapping for each platform

2022-04-14 Thread Imre Deak
Atm the port -> DDI and AUX power domain mapping is specified by relying on the aliasing of the platform specific intel_display_power_domain enum values. For instance D12+ platforms refer to the 'D' port and power domain instances, which doesn't match the bspec terminology, on these platforms the

[Intel-gfx] [CI 10/18] drm/i915: Simplify power well definitions by adding power well instances

2022-04-14 Thread Imre Deak
All the port specific AUX/DDI_IO power wells share the same power well ops struct and flags, so we can save some space and simplify the definition of these by listing for all such power wells only the params specific to them (name, domains, power well register index, id). Move these params to a

[Intel-gfx] [CI 09/18] drm/i915: Convert the u64 power well domains mask to a bitmap

2022-04-14 Thread Imre Deak
To remove the aliasing of the power domain enum values in a follow-up patch in this patchset (requiring a bigger mask) and allow for defining additional power domains in the future (at least some upcoming TypeC changes requires this) convert the u64 i915_power_well_desc::domains mask to a bitmap.

[Intel-gfx] [CI 08/18] drm/i915: Convert the power well descriptor domain mask to an array of domains

2022-04-14 Thread Imre Deak
The next patch converts the i915_power_well_desc::domain mask from a u64 mask to a bitmap. I didn't find a reasonably simple way to initialize bitmaps statically, so prepare for the next patch here by converting the masks to an array of domain enums and initing the masks from these arrays during

[Intel-gfx] [CI 06/18] drm/i915: Rename the power domain names to end with pipes/ports

2022-04-14 Thread Imre Deak
Make all power domain names end with the pipe/port instance for consistency. No functional changes. Signed-off-by: Imre Deak Reviewed-by: Jouni Högander --- drivers/gpu/drm/i915/display/icl_dsi.c| 8 +- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-

[Intel-gfx] [CI 07/18] drm/i915: Sanitize the power well names

2022-04-14 Thread Imre Deak
Use the shortest descriptive name for all power wells for simplicity and to use the same name for the same type of power wells on multiple platforms. Signed-off-by: Imre Deak Reviewed-by: Jouni Högander --- .../i915/display/intel_display_power_map.c| 254 +- 1 file changed,

[Intel-gfx] [CI 04/18] drm/i915: Move the dg2 fixed_enable_delay power well param to a common bitfield

2022-04-14 Thread Imre Deak
The DG2 fixed delay duration is always 600usec, so save some space in the power well descriptors by converting the parameter to a flag. While at it also use a bitfield for both the always_on and fixed_enable_delay flag. This change also lets simplifying the definiton of power wells sharing the

[Intel-gfx] [CI 01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c

2022-04-14 Thread Imre Deak
Move the implementation of platform specific power well hooks to intel_display_power_well.c, to reduce the clutter in intel_display_power.c. The locking of all the power domain/power well state is handled in the power domain functions in intel_display_power.c using i915_power_domains::lock. This

[Intel-gfx] [CI 05/18] drm/i915: Move the HSW power well flags to a common bitfield

2022-04-14 Thread Imre Deak
Save some space by grouping the HSW power well descriptor flags along with other flags in one bitfield. This change also lets simplifying the definition of power well descriptors sharing the same flags in an upcoming patch. Signed-off-by: Imre Deak Reviewed-by: Jouni Högander ---

[Intel-gfx] [CI 03/18] drm/i915: Move the power domain->well mappings to intel_display_power_map.c

2022-04-14 Thread Imre Deak
Move the list of platform specific power domain -> power well definitions to intel_display_power_map.c. While at it group the platforms' power domain macros with the corresponding power well lists and keep all the power domain lists in the same order (matching the enum order). No functional

[Intel-gfx] [CI 02/18] drm/i915: Unexport the for_each_power_well() macros

2022-04-14 Thread Imre Deak
The for_each_power_well() macros are only used in intel_display_power.c and intel_display_power_well.c, so unexport them. Signed-off-by: Imre Deak Reviewed-by: Jouni Högander --- .../drm/i915/display/intel_display_power.c| 8 .../drm/i915/display/intel_display_power.h| 20

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/edid: CEA data block iterators, and more (rev2)

2022-04-14 Thread Patchwork
== Series Details == Series: drm/edid: CEA data block iterators, and more (rev2) URL : https://patchwork.freedesktop.org/series/102703/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11500_full -> Patchwork_102703v2_full

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: Load DMC on DG2 (rev4)

2022-04-14 Thread Srivatsa, Anusha
HI, The result here says SUCCESS but closer look shows that it never ran on any DG2. Wanted to know if something went wrong at the system side and if it needs to be revived. The patch is simply loading DMC and shouldn’t cause the system to not boot up at all. Any info in this regard will be

Re: [Intel-gfx] [PATCH v2] drm/i915: Check EDID for HDR static metadata when choosing blc

2022-04-14 Thread Lyude Paul
Reviewed-by: Lyude Paul On Wed, 2022-04-13 at 11:28 +0300, Jouni Högander wrote: > We have now seen panel (XMG Core 15 e21 laptop) advertizing support > for Intel proprietary eDP backlight control via DPCD registers, but > actually working only with legacy pwm control. > > This patch adds panel

Re: [Intel-gfx] [PATCH] drm/i915/rpl-p: Add PCI IDs

2022-04-14 Thread Matt Roper
On Thu, Apr 14, 2022 at 07:36:26PM +0530, Tejas Upadhyay wrote: > From: Matt Atwood > > Adding initial PCI ids for RPL-P. > RPL-P behaves identically to ADL-P from i915's point of view. > > Bspec: 55376 > Signed-off-by: Matt Atwood > Signed-off-by: Madhumitha Tolakanahalli Pradeep > >

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v3,1/2] drm/dp: Factor out a function to probe a DPCD address (rev3)

2022-04-14 Thread Patchwork
== Series Details == Series: series starting with [v3,1/2] drm/dp: Factor out a function to probe a DPCD address (rev3) URL : https://patchwork.freedesktop.org/series/102428/ State : success == Summary == CI Bug Log - changes from CI_DRM_11482_full -> Patchwork_102428v3_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v3,1/2] drm/i915/display/psr: Unset enable_psr2_sel_fetch if other checks in intel_psr2_config_valid() fails

2022-04-14 Thread Patchwork
== Series Details == Series: series starting with [v3,1/2] drm/i915/display/psr: Unset enable_psr2_sel_fetch if other checks in intel_psr2_config_valid() fails URL : https://patchwork.freedesktop.org/series/102704/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11500_full ->

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/1] i915/gem: drop wbinvd_on_all_cpus usage

2022-04-14 Thread Patchwork
== Series Details == Series: series starting with [v2,1/1] i915/gem: drop wbinvd_on_all_cpus usage URL : https://patchwork.freedesktop.org/series/102708/ State : success == Summary == CI Bug Log - changes from CI_DRM_11501 -> Patchwork_102708v1

[Intel-gfx] [PATCH 2/2] ALSA: hda: handle UAF at probe error

2022-04-14 Thread Nirmoy Das
Call snd_card_free_on_error() on probe error instead of calling snd_card_free() which should handle devres call orders. Issues: https://gitlab.freedesktop.org/drm/intel/-/issues/5701 Fixes: e8ad415b7a55 ("ALSA: core: Add managed card creation") Signed-off-by: Nirmoy Das ---

[Intel-gfx] [PATCH v2] ALSA: hda: handle UAF at probe error

2022-04-14 Thread Nirmoy Das
Call snd_card_free_on_error() on probe error instead of calling snd_card_free() which should handle devres call orders. Issues: https://gitlab.freedesktop.org/drm/intel/-/issues/5701 Fixes: e8ad415b7a55 ("ALSA: core: Add managed card creation") Signed-off-by: Nirmoy Das ---

[Intel-gfx] [PATCH 1/2] ALSA: core: Add snd_card_free_on_error() helper

2022-04-14 Thread Nirmoy Das
From: Takashi Iwai This is a small helper function to handle the error path more easily when an error happens during the probe for the device with the device-managed card. Since devres releases in the reverser order of the creations, usually snd_card_free() gets called at the last in the probe

[Intel-gfx] [CI 0/2] Fix UAF in snd_hda_intel

2022-04-14 Thread Nirmoy Das
Run CI for these two patches for: https://gitlab.freedesktop.org/drm/intel/-/issues/5701 Nirmoy Das (1): ALSA: hda: handle UAF at probe error Takashi Iwai (1): ALSA: core: Add snd_card_free_on_error() helper include/sound/core.h | 1 + sound/core/init.c | 28

[Intel-gfx] [CI 4/4] drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES

2022-04-14 Thread Matt Roper
From: Matt Atwood Newer platforms have DSS that aren't necessarily available for both geometry and compute, two queries will need to exist. This introduces the first, when passing a valid engine class and engine instance in the flags returns a topology describing geometry. Based on past

[Intel-gfx] [CI 3/4] drm/i915/doc: Link query items to their uapi structs

2022-04-14 Thread Matt Roper
Document the possible options for drm_i915_query_item.query_id with links to the corresponding uapi structures. Signed-off-by: Matt Roper Reviewed-by: Francisco Jerez --- include/uapi/drm/i915_drm.h | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-)

[Intel-gfx] [CI 2/4] drm/i915/doc: Convert perf UAPI comments to kerneldoc

2022-04-14 Thread Matt Roper
Convert the comments for drm_i915_query_perf_config and drm_i915_perf_oa_config to kerneldoc so that they will show up in the generated documentation. Also correct a couple places that referred to query_id when they actually meant to refer to query_item.flags. Signed-off-by: Matt Roper

[Intel-gfx] [CI 1/4] drm/i915/doc: Convert drm_i915_query_topology_info comment to kerneldoc

2022-04-14 Thread Matt Roper
This structure has a great comment describing the fields, but it's not currently in kerneldoc form and does not show up in the generated documentation. Let's fix that and also clarify the description of what "subslice" refers to on gen12 platforms and beyond and that "slice" is no longer

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/1] i915/gem: drop wbinvd_on_all_cpus usage

2022-04-14 Thread Patchwork
== Series Details == Series: series starting with [v2,1/1] i915/gem: drop wbinvd_on_all_cpus usage URL : https://patchwork.freedesktop.org/series/102708/ State : warning == Summary == Error: dim checkpatch failed 5557f3ff453a i915/gem: drop wbinvd_on_all_cpus usage -:10:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Don't show client busyness in fdinfo with GuC submission (rev2)

2022-04-14 Thread Patchwork
== Series Details == Series: drm/i915: Don't show client busyness in fdinfo with GuC submission (rev2) URL : https://patchwork.freedesktop.org/series/102676/ State : success == Summary == CI Bug Log - changes from CI_DRM_11500 -> Patchwork_102676v2

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v3,1/2] drm/dp: Factor out a function to probe a DPCD address (rev3)

2022-04-14 Thread Imre Deak
On Mon, Apr 11, 2022 at 08:18:39PM +, Patchwork wrote: > == Series Details == > > Series: series starting with [v3,1/2] drm/dp: Factor out a function to probe > a DPCD address (rev3) > URL : https://patchwork.freedesktop.org/series/102428/ > State : failure I pushed patch 1/2 to

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/rpl-p: Add PCI IDs

2022-04-14 Thread Patchwork
== Series Details == Series: drm/i915/rpl-p: Add PCI IDs URL : https://patchwork.freedesktop.org/series/102701/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11500_full -> Patchwork_102701v1_full Summary ---

[Intel-gfx] [PATCH v2 0/1] Drop wbinvd_on_all_cpus usage

2022-04-14 Thread Michael Cheng
To align with the discussion in [1][2], this patch series drops all usage of wbvind_on_all_cpus within i915 by either replacing the call with certain drm clflush helpers, or reverting to a previous logic.

[Intel-gfx] [PATCH v2 1/1] i915/gem: drop wbinvd_on_all_cpus usage

2022-04-14 Thread Michael Cheng
Previous concern with using drm_clflush_sg was that we don't know what the sg_table is pointing to, thus the usage of wbinvd_on_all_cpus to flush everything at once to avoid paranoia. To make i915 more architecture-neutral and be less paranoid, lets attempt to use drm_clflush_sg to flush the

[Intel-gfx] [PATCH v2 0/1]

2022-04-14 Thread Michael Cheng
To align with the discussion in [1][2], this patch series drops all usage of wbvind_on_all_cpus within i915 by either replacing the call with certain drm clflush helpers, or reverting to a previous logic.

[Intel-gfx] [PATCH v2 1/1] i915/gem: drop wbinvd_on_all_cpus usage

2022-04-14 Thread Michael Cheng
Previous concern with using drm_clflush_sg was that we don't know what the sg_table is pointing to, thus the usage of wbinvd_on_all_cpus to flush everything at once to avoid paranoia. To make i915 more architecture-neutral and be less paranoid, lets attempt to use drm_clflush_sg to flush the

Re: [Intel-gfx] [PATCH] drm/i915: Don't show client busyness in fdinfo with GuC submission

2022-04-14 Thread Ceraolo Spurio, Daniele
On 4/13/2022 3:57 PM, Ashutosh Dixit wrote: Client busyness is not available when GuC submission is used. Don't show it in fdinfo till this is supported by GuC. GuC does support this, but we don't yet have code in place in i915 to fetch the data, so this commit message needs a slightly

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: Load DMC on DG2 (rev4)

2022-04-14 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Load DMC on DG2 (rev4) URL : https://patchwork.freedesktop.org/series/102630/ State : success == Summary == CI Bug Log - changes from CI_DRM_11500 -> Patchwork_102630v4 Summary ---

Re: [Intel-gfx] [PATCH v3] drm/i915: program wm blocks to at least blocks required per line

2022-04-14 Thread Ville Syrjälä
On Wed, Apr 06, 2022 at 08:43:11PM +0300, Vinod Govindapillai wrote: > In configurations with single DRAM channel, for usecases like > 4K 60 Hz, FIFO underruns are observed quite frequently. Looks > like the wm0 watermark values need to bumped up because the wm0 > memory latency calculations are

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/edid: CEA data block iterators, and more (rev2)

2022-04-14 Thread Patchwork
== Series Details == Series: drm/edid: CEA data block iterators, and more (rev2) URL : https://patchwork.freedesktop.org/series/102703/ State : success == Summary == CI Bug Log - changes from CI_DRM_11500 -> Patchwork_102703v2 Summary

Re: [Intel-gfx] [PATCH v3 5/5] drm/i915: stolen memory use ttm backend

2022-04-14 Thread Robert Beckett
On 14/04/2022 15:41, Thomas Hellström wrote: Hi, On 4/12/22 21:38, Robert Beckett wrote: +struct ttm_resource * +i915_gem_stolen_reserve_range(struct drm_i915_private *i915, +  resource_size_t size, +  u64 start, u64 end)   { -    int ret; +    struct

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid: CEA data block iterators, and more (rev2)

2022-04-14 Thread Patchwork
== Series Details == Series: drm/edid: CEA data block iterators, and more (rev2) URL : https://patchwork.freedesktop.org/series/102703/ State : warning == Summary == Error: dim checkpatch failed 3bcd5f30a3e4 drm/edid: reset display info in drm_add_edid_modes() for NULL edid 4bddacab36a6

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v3,1/2] drm/i915/display/psr: Unset enable_psr2_sel_fetch if other checks in intel_psr2_config_valid() fails

2022-04-14 Thread Patchwork
== Series Details == Series: series starting with [v3,1/2] drm/i915/display/psr: Unset enable_psr2_sel_fetch if other checks in intel_psr2_config_valid() fails URL : https://patchwork.freedesktop.org/series/102704/ State : success == Summary == CI Bug Log - changes from CI_DRM_11500 ->

Re: [Intel-gfx] [PATCH] drm/i915/adl-n: Differentiate ADLP and ADLN steppings

2022-04-14 Thread Souza, Jose
On Wed, 2022-04-13 at 16:28 +0530, Tejas Upadhyay wrote: > ADL-N and ADL-P stepping are different, thus we > need to add check for ADL-N in IS_ADLP_DISPLAY_STEP(). > > Signed-off-by: Tejas Upadhyay > --- > drivers/gpu/drm/i915/i915_drv.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

[Intel-gfx] ✗ Fi.CI.IGT: failure for add support for enum module parameters

2022-04-14 Thread Patchwork
== Series Details == Series: add support for enum module parameters URL : https://patchwork.freedesktop.org/series/102695/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11499_full -> Patchwork_102695v1_full Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Use i915_probe_error instead of drm_err

2022-04-14 Thread Gupta, Anshuman
> -Original Message- > From: Belgaumkar, Vinay > Sent: Thursday, April 14, 2022 8:38 PM > To: Gupta, Anshuman > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Use i915_probe_error > instead of drm_err > > >

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Use i915_probe_error instead of drm_err

2022-04-14 Thread Jani Nikula
On Thu, 14 Apr 2022, "Belgaumkar, Vinay" wrote: > On 4/13/2022 11:41 PM, Anshuman Gupta wrote: >> On 2022-04-13 at 04:18:52 +0530, Vinay Belgaumkar wrote: >>> This will ensure we don't have false positives when we run >>> error injection tests. >>> >>> Signed-off-by: Vinay Belgaumkar >>> --- >>>

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915: ttm backend dont provide mmap_offset for kernel buffers

2022-04-14 Thread Robert Beckett
On 14/04/2022 15:05, Thomas Hellström wrote: On Tue, 2022-04-12 at 15:18 +, Robert Beckett wrote: stolen/kernel buffers should not be mmapable by userland. do not provide callbacks to facilitate this for these buffers. Signed-off-by: Robert Beckett ---  

Re: [Intel-gfx] [PATCH v5 00/10] drm/hdcp: Pull HDCP auth/exchange/check into helpers

2022-04-14 Thread Sean Paul
On Tue, Apr 12, 2022 at 09:41:35AM -0400, Rodrigo Vivi wrote: > On Mon, Apr 11, 2022 at 08:47:29PM +, Sean Paul wrote: > > From: Sean Paul > > > > Rebased set from November. Fixed a nit from Stephen in the msm patch and > > moved hdcp registers into the trogdor dtsi file to avoid differences

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/edid: low level EDID block read refactoring etc. (rev9)

2022-04-14 Thread Patchwork
== Series Details == Series: drm/edid: low level EDID block read refactoring etc. (rev9) URL : https://patchwork.freedesktop.org/series/102329/ State : success == Summary == CI Bug Log - changes from CI_DRM_11499_full -> Patchwork_102329v9_full

Re: [Intel-gfx] [PATCH v5 03/10] drm/hdcp: Update property value on content type and user changes

2022-04-14 Thread Sean Paul
On Tue, Apr 12, 2022 at 09:25:59AM -0400, Rodrigo Vivi wrote: > On Mon, Apr 11, 2022 at 08:47:32PM +, Sean Paul wrote: > > From: Sean Paul > > > > This patch updates the connector's property value in 2 cases which were > > previously missed: > > > > 1- Content type changes. The value should

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/edid: CEA data block iterators, and more

2022-04-14 Thread Patchwork
== Series Details == Series: drm/edid: CEA data block iterators, and more URL : https://patchwork.freedesktop.org/series/102703/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11500 -> Patchwork_102703v1 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid: CEA data block iterators, and more

2022-04-14 Thread Patchwork
== Series Details == Series: drm/edid: CEA data block iterators, and more URL : https://patchwork.freedesktop.org/series/102703/ State : warning == Summary == Error: dim checkpatch failed 3c1721b51008 drm/edid: reset display info in drm_add_edid_modes() for NULL edid 819f872f2dc6 drm/edid:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/rpl-p: Add PCI IDs

2022-04-14 Thread Patchwork
== Series Details == Series: drm/i915/rpl-p: Add PCI IDs URL : https://patchwork.freedesktop.org/series/102701/ State : success == Summary == CI Bug Log - changes from CI_DRM_11500 -> Patchwork_102701v1 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Make the rest of the VFIO driver interface use vfio_device (rev2)

2022-04-14 Thread Patchwork
== Series Details == Series: Make the rest of the VFIO driver interface use vfio_device (rev2) URL : https://patchwork.freedesktop.org/series/102606/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/102606/revisions/2/mbox/ not applied Applying:

Re: [Intel-gfx] [PATCH 1/2] drm/i915/fbc: Consult hw.crtc instead of uapi.crtc

2022-04-14 Thread Navare, Manasi
On Wed, Apr 13, 2022 at 06:28:51PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > plane_state->uapi.crtc is not what we want to be looking at. > If bigjoiner is used hw.crtc is what tells us what crtc the plane > is supposedly using. > > Not an actual problem on current hardware as the

Re: [Intel-gfx] [PATCH 2/2] drm/i915/fbc: s/false/0/

2022-04-14 Thread Navare, Manasi
On Wed, Apr 13, 2022 at 06:28:52PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > intel_fbc_check_plane() is supposed to an int, not a boolean. > So replace the bogus 'return false's with the correct 'return 0's. > These were accidental copy-paste mistakes when the code got moved > into

[Intel-gfx] [PATCH v3 2/2] drm/i915/display/psr: Clear more PSR state during disable

2022-04-14 Thread José Roberto de Souza
After commit 805f04d42a6b ("drm/i915/display/psr: Use continuos full frame to handle frontbuffer invalidations") was merged we started to get some drm_WARN_ON(_priv->drm, !(tmp & PSR2_MAN_TRK_CTL_ENABLE)) in tests that are executed in pipe B. This is probably due psr2_sel_fetch_cff_enabled being

  1   2   >