On Fri, 03 Jun 2022, "Murthy, Arun R" wrote:
>> On Thu, 02 Jun 2022, Animesh Manna wrote:
>> > From: Arun R Murthy
>> >
>> > With the enablement of dual eDP, there will have to exist two entries
>> > of backlight sysfs file. In order to avoid sysfs file name
>> > duplication, the file names are
On 02/06/2022 23:35, Jason Ekstrand wrote:
On Thu, Jun 2, 2022 at 3:11 PM Niranjana Vishwanathapura
wrote:
On Wed, Jun 01, 2022 at 01:28:36PM -0700, Matthew Brost wrote:
>On Wed, Jun 01, 2022 at 05:25:49PM +0300, Lionel Landwerlin wrote:
>> On 17/05/2022 21:32, Niranjana Vishwanath
On Thu, Jun 02, 2022 at 05:54:03PM -0700, john.c.harri...@intel.com wrote:
> From: John Harrison
>
> Update to the latest master version of the DRM UAPI header file.
>
> NB: Had to remove '__user' keywords as they do not appear to be
> supported outside of kernel builds.
>
> Signed-off-by: John
On Thu, 02 Jun 2022, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> We're not parsing the 5.4 Gbps value for the old eDP fast link
> training link rate, nor are we parsing the new fast link training
> link rate field. Remedy both.
>
> Also we'll now use the actual link rate instead of the DPCD BW
On Thu, 02 Jun 2022, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> The eDP BDB block has gained yet another max link rate field.
> Let's parse it and consult it during the source rate filtering.
>
> v2: *20 instead of *2 to get the correct units (Jani)
Failed to mention the same issue here as i
On Thu, 02 Jun 2022, Matt Roper wrote:
> On Thu, Jun 02, 2022 at 12:45:42PM +0300, Jani Nikula wrote:
>> Split out audio registers to a header of its own to reduce the size of
>> i915_reg.h.
>>
>> TODO: Remove direct audio register access from intel_ddi.c. However,
>> unification of audio get con
This patch series fixes integer overflow or integer truncation issues in
page lookups, ttm place configuration and scatterlist creation, etc.
We need to check that we avoid integer overflows when looking up a page,
and so fix all the instances where we have mistakenly used a plain integer
instead o
From: Chris Wilson
We need to check that we avoid integer overflows when looking up a page,
and so fix all the instances where we have mistakenly used a plain
integer instead of a more suitable long. Be pedantic and add integer
typechecking to the lookup so that we can be sure that we are safe.
A
From: Chris Wilson
There is an impedance mismatch between the scatterlist API using unsigned
int and our memory/page accounting in unsigned long. That is we may try
to create a scatterlist for a large object that overflows returning a
small table into which we try to fit very many pages. As the o
The __shmem_file_setup() function returns -EINVAL if size is greater than
MAX_LFS_FILESIZE. To handle the same error as other code that returns
-E2BIG when the size is too large, it add a code that returns -E2BIG when
the size is larger than the size that can be handled.
Signed-off-by: Gwan-gyeong
The ttm_bo_init_reserved() functions returns -ENOSPC if the size is too big
to add vma. The direct function that returns -ENOSPC is
drm_mm_insert_node_in_range().
To handle the same error as other code returning -E2BIG when the size is
too large, it converts return value to -E2BIG.
Signed-off-by:
There is an impedance mismatch between the first/last valid page
frame number of ttm place in unsigned and our memory/page accounting in
unsigned long.
As the object size is under the control of userspace, we have to be prudent
and catch the conversion errors.
To catch the implicit truncation as we
From: Chris Wilson
Having addressed the issues surrounding incorrect types for local
variables and potential integer truncation in using the scatterlist API,
we have closed all the loop holes we had previously identified with
dangerously large object creation. As such, we can eliminate the warnin
This patch series fixes integer overflow or integer truncation issues in
page lookups, ttm place configuration and scatterlist creation, etc.
We need to check that we avoid integer overflows when looking up a page,
and so fix all the instances where we have mistakenly used a plain integer
instead o
From: Chris Wilson
We need to check that we avoid integer overflows when looking up a page,
and so fix all the instances where we have mistakenly used a plain
integer instead of a more suitable long. Be pedantic and add integer
typechecking to the lookup so that we can be sure that we are safe.
A
From: Chris Wilson
There is an impedance mismatch between the scatterlist API using unsigned
int and our memory/page accounting in unsigned long. That is we may try
to create a scatterlist for a large object that overflows returning a
small table into which we try to fit very many pages. As the o
There is an impedance mismatch between the first/last valid page
frame number of ttm place in unsigned and our memory/page accounting in
unsigned long.
As the object size is under the control of userspace, we have to be prudent
and catch the conversion errors.
To catch the implicit truncation as we
The __shmem_file_setup() function returns -EINVAL if size is greater than
MAX_LFS_FILESIZE. To handle the same error as other code that returns
-E2BIG when the size is too large, it add a code that returns -E2BIG when
the size is larger than the size that can be handled.
Signed-off-by: Gwan-gyeong
The ttm_bo_init_reserved() functions returns -ENOSPC if the size is too big
to add vma. The direct function that returns -ENOSPC is
drm_mm_insert_node_in_range().
To handle the same error as other code returning -E2BIG when the size is
too large, it converts return value to -E2BIG.
Signed-off-by:
From: Chris Wilson
Having addressed the issues surrounding incorrect types for local
variables and potential integer truncation in using the scatterlist API,
we have closed all the loop holes we had previously identified with
dangerously large object creation. As such, we can eliminate the warnin
> -Original Message-
> From: Nikula, Jani
> Sent: Thursday, June 2, 2022 8:41 PM
> To: Manna, Animesh ; intel-
> g...@lists.freedesktop.org
> Cc: ville.syrj...@linux.intel.com; Shankar, Uma ;
> Manna, Animesh
> Subject: Re: [RFC PATCH 1/5] drm/i915/bios: calculate drrs mode using panel
This patch set disables connector polling when entering runtime
suspend for headless sku to prevent waking it up again when poll
is performed.
Cc: Imre Deak
Cc: Anshuman Gupta
Jouni Högander (2):
drm/i915/opregion: add function to check if headless sku
drm/i915: do not start connector polli
Export headless sku bit (bit 13) from opregion->header->pcon as an
interface to check if our device is headless configuration.
Bspec: 53441
Signed-off-by: Jouni Högander
---
drivers/gpu/drm/i915/display/intel_opregion.c | 12
drivers/gpu/drm/i915/display/intel_opregion.h | 7 ++
Connector polling is waking up the polled device. Polling
is unnecessary if our device is known to not have display.
Fix this and Save some power by disabling starting connector
polling when we are having headless sku. Use information from
opregion.
Signed-off-by: Jouni Högander
---
drivers/gpu
> -Original Message-
> From: Nikula, Jani
> Sent: Thursday, June 2, 2022 9:03 PM
> To: Manna, Animesh ; intel-
> g...@lists.freedesktop.org
> Cc: ville.syrj...@linux.intel.com; Shankar, Uma ;
> Varide, Nischal ; Manna, Animesh
>
> Subject: Re: [RFC PATCH 5/5] drm/i915/display/tgl+: Use
== Series Details ==
Series: Fixes integer overflow or integer truncation issues in page lookups,
ttm place configuration and scatterlist creation (rev2)
URL : https://patchwork.freedesktop.org/series/104704/
State : warning
== Summary ==
Error: dim checkpatch failed
14fec565e6d1 drm/i915/gem
== Series Details ==
Series: Fixes integer overflow or integer truncation issues in page lookups,
ttm place configuration and scatterlist creation (rev2)
URL : https://patchwork.freedesktop.org/series/104704/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast m
== Series Details ==
Series: Disable connector polling for a headless sku
URL : https://patchwork.freedesktop.org/series/104711/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: Fixes integer overflow or integer truncation issues in page lookups,
ttm place configuration and scatterlist creation (rev2)
URL : https://patchwork.freedesktop.org/series/104704/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11726 -> Patchwork_10
On Fri, 03 Jun 2022, Jouni Högander wrote:
> Export headless sku bit (bit 13) from opregion->header->pcon as an
> interface to check if our device is headless configuration.
>
> Bspec: 53441
> Signed-off-by: Jouni Högander
> ---
> drivers/gpu/drm/i915/display/intel_opregion.c | 12
>
== Series Details ==
Series: Disable connector polling for a headless sku
URL : https://patchwork.freedesktop.org/series/104711/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11726 -> Patchwork_104711v1
Summary
---
*
Turn i915_gem.h into a useful header that contains stuff the name
implies, and clean up i915_drv.h a bit.
Jani Nikula (7):
drm/i915/tasklet: separate local hacks around struct tasklet_struct
drm/i915/debug: add new i915_debug.h for debug asserts
drm/i915: un-inline i915_gem_drain_* functions
No longer needed after panel data was moved.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_drv.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index fa8f208c8939..5093fe824789 100644
--- a/drivers/gpu/drm/i915/i915
Only the uapi header is required.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_drm_client.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_drm_client.h
b/drivers/gpu/drm/i915/i915_drm_client.h
index f796c5e8e060..69496af996d9 100644
---
Remove some of the unused helpers from i915_utils.h.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_utils.h | 40 ---
1 file changed, 40 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_utils.h
b/drivers/gpu/drm/i915/i915_utils.h
index ea7648e3aa0e..c10
Add a dedicated file for the local functions around struct
tasklet_struct. Far from ideal, but better placed in a dedicated file
than i915_gem.h.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/TODO.txt | 2 +-
drivers/gpu/drm/i915/i915_gem.h | 33
drivers
Move the various GEM_BUG_ON(), GEM_WARN_ON(), etc. debug macros to a
dedicated i915_debug.h file.
Unfortunately, the i915_debug.h needs to be included from some headers
that get included from i915_drv.h, so we don't really get much build
benefits here, other than getting rid of superfluous i915_ge
Turn i915_gem.h into a useful header for declaring the functions in
i915_gem.c.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dpt.c | 1 +
drivers/gpu/drm/i915/display/intel_dsb.c | 1 +
drivers/gpu/drm/i915/display/intel_overlay.c | 1 +
drivers/gpu/drm/i915/ge
As best I can tell these aren't used in the kind of hotpaths that
mandate using static inline. They do make header cleanup harder, though,
so un-inline.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_drv.h | 39 ++---
drivers/gpu/drm/i915/i915_gem.c | 38 +++
On Fri, 2022-06-03 at 15:43 +0300, Jani Nikula wrote:
> On Fri, 03 Jun 2022, Jouni Högander wrote:
> > Export headless sku bit (bit 13) from opregion->header->pcon as an
> > interface to check if our device is headless configuration.
> >
> > Bspec: 53441
> > Signed-off-by: Jouni Högander
> > ---
On Fri, 03 Jun 2022, Gwan-gyeong Mun wrote:
> This patch series fixes integer overflow or integer truncation issues in
> page lookups, ttm place configuration and scatterlist creation, etc.
> We need to check that we avoid integer overflows when looking up a page,
> and so fix all the instances wh
== Series Details ==
Series: drm/i915: i915_drv.h & i915_gem.h header refactoring
URL : https://patchwork.freedesktop.org/series/104725/
State : warning
== Summary ==
Error: dim checkpatch failed
a53c0ec4baf9 drm/i915/tasklet: separate local hacks around struct tasklet_struct
Traceback (most r
== Series Details ==
Series: drm/i915: i915_drv.h & i915_gem.h header refactoring
URL : https://patchwork.freedesktop.org/series/104725/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
On Thu, 2022-06-02 at 16:30 -0700, Matt Roper wrote:
> We missed this setting in the initial device info patch's definition of
> XE_HPC_FEATURES.
Reviewed-by: José Roberto de Souza
>
> Signed-off-by: Matt Roper
> ---
> drivers/gpu/drm/i915/i915_pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
On Fri, Jun 03, 2022 at 03:54:36AM +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/pvc: GuC depriv applies to PVC
> URL : https://patchwork.freedesktop.org/series/104688/
> State : success
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_11723_full -> Patchwork_104688
== Series Details ==
Series: Fixes integer overflow or integer truncation issues in page lookups,
ttm place configuration and scatterlist creation (rev2)
URL : https://patchwork.freedesktop.org/series/104704/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11726_full -> Patchwo
On Fri, Jun 03, 2022 at 03:50:38AM +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/pvc: Add register steering
> URL : https://patchwork.freedesktop.org/series/104691/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_11724 -> Patchwork_104691v1
>
== Series Details ==
Series: Disable connector polling for a headless sku
URL : https://patchwork.freedesktop.org/series/104711/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11726_full -> Patchwork_104711v1_full
Summary
--
Hi John,
On 2022-06-02 at 17:54:04 -0700, john.c.harri...@intel.com wrote:
> From: Rodrigo Vivi
>
> Newer platforms have an embedded table giving details about that
> platform's hardware configuration. This table can be retrieved from
> the KMD via the existing query API. So add a test for it as
From: John Harrison
Various UMDs require hardware configuration information about the
current platform. A new interface has been added to the KMD to return
this information. So, add a test for the new interface.
Also, update to the latest DRM UAPI header file that contains the new
query enums.
From: Rodrigo Vivi
Newer platforms have an embedded table giving details about that
platform's hardware configuration. This table can be retrieved from
the KMD via the existing query API. So add a test for it as both an
example of how to fetch the table and to validate the contents as much
as is
From: John Harrison
Update to the latest master version of the DRM UAPI header file from
git://anongit.freedesktop.org/git/drm/drm:
c4955d9cd2fc Merge tag 'drm-intel-next-fixes-2022-05-24' of
git://anongit.freedesktop.org/drm/drm-intel into drm-next
Signed-off-by: John Harrison
---
include
From: Rodrigo Vivi
Newer platforms have an embedded table giving details about that
platform's hardware configuration. This table can be retrieved from
the KMD via the existing query API. So add a test for it as both an
example of how to fetch the table and to validate the contents as much
as is
From: John Harrison
Update to the latest master version of the DRM UAPI header file from
git://anongit.freedesktop.org/git/drm/drm:
c4955d9cd2fc Merge tag 'drm-intel-next-fixes-2022-05-24' of
git://anongit.freedesktop.org/drm/drm-intel into drm-next
Signed-off-by: John Harrison
---
include
From: John Harrison
Various UMDs require hardware configuration information about the
current platform. A new interface has been added to the KMD to return
this information. So, add a test for the new interface.
Also, update to the latest DRM UAPI header file that contains the new
query enums.
From: John Harrison
None of the query tests had a description. So make some up.
Signed-off-by: John Harrison
---
tests/i915/i915_query.c | 12
1 file changed, 12 insertions(+)
diff --git a/tests/i915/i915_query.c b/tests/i915/i915_query.c
index 246a979af72a..35a91d245ec1 100644
-
On Fri, 2022-06-03 at 13:14 +, Hogander, Jouni wrote:
> On Fri, 2022-06-03 at 15:43 +0300, Jani Nikula wrote:
> > On Fri, 03 Jun 2022, Jouni Högander wrote:
> > > Export headless sku bit (bit 13) from opregion->header->pcon as an
> > > interface to check if our device is headless configuration
From: Ville Syrjälä
We'll need to know the VBT panel_type before we can determine the
maximum link rate for eDP. To that end move
intel_dp_set_source_rates() & co. to be called after the per-panel
VBT parsing has been done.
intel_dp_mst_encoder_init() depends on the source rates so we'll
have to
On Tue, May 24, 2022 at 01:39:33PM +0300, Jani Nikula wrote:
> HDMI 2.1 section 10.3.6 defines an HDMI Forum EDID Extension Override
> Data Block, which may contain a different extension count than the base
> block claims. Add support for reading more EDID data if available. The
> extra blocks aren
== Series Details ==
Series: drm/i915: i915_drv.h & i915_gem.h header refactoring
URL : https://patchwork.freedesktop.org/series/104725/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11726 -> Patchwork_104725v1
Summary
== Series Details ==
Series: drm/i915/display/fbc: Do not apply WA 22014263786 to DG2 (rev2)
URL : https://patchwork.freedesktop.org/series/104678/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11726 -> Patchwork_104678v2
S
Hi Lakshmi
Can you please help with this failures?
Current code is only doing a small change that would only affect DG2.
On Fri, 2022-06-03 at 20:09 +, Patchwork wrote:
Patch Details
Series: drm/i915/display/fbc: Do not apply WA 22014263786 to DG2 (rev2)
URL:https://patchwork.freedesktop.
== Series Details ==
Series: drm/i915: i915_drv.h & i915_gem.h header refactoring
URL : https://patchwork.freedesktop.org/series/104725/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11726_full -> Patchwork_104725v1_full
Su
On Fri, Jun 03, 2022 at 10:20:25AM +0300, Lionel Landwerlin wrote:
On 02/06/2022 23:35, Jason Ekstrand wrote:
On Thu, Jun 2, 2022 at 3:11 PM Niranjana Vishwanathapura
wrote:
On Wed, Jun 01, 2022 at 01:28:36PM -0700, Matthew Brost wrote:
>On Wed, Jun 01, 2022 at 05:25:49PM
== Series Details ==
Series: drm/i915: Parse more eDP link rate stuff from VBT (rev4)
URL : https://patchwork.freedesktop.org/series/104615/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11727 -> Patchwork_104615v4
Summary
== Series Details ==
Series: drm/i915/display/fbc: Do not apply WA 22014263786 to DG2 (rev2)
URL : https://patchwork.freedesktop.org/series/104678/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11726 -> Patchwork_104678v2
S
== Series Details ==
Series: drm/i915/display/fbc: Do not apply WA 22014263786 to DG2 (rev2)
URL : https://patchwork.freedesktop.org/series/104678/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11726 -> Patchwork_104678v2
S
== Series Details ==
Series: drm/i915/display/fbc: Do not apply WA 22014263786 to DG2 (rev2)
URL : https://patchwork.freedesktop.org/series/104678/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11726_full -> Patchwork_104678v2_full
=
68 matches
Mail list logo
