[Intel-gfx] ✗ Fi.CI.IGT: failure for Break VM to rq reference loop

2022-06-14 Thread Patchwork
== Series Details == Series: Break VM to rq reference loop URL : https://patchwork.freedesktop.org/series/105122/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11757_full -> Patchwork_105122v1_full Summary --- **FAIL

Re: [Intel-gfx] [PATCH 3/3] drm/i915/bios: split ddi port parsing and debug printing

2022-06-14 Thread Jani Nikula
On Fri, 10 Jun 2022, Ville Syrjälä wrote: > On Fri, Jun 10, 2022 at 05:10:27PM +0300, Jani Nikula wrote: >> Split ddi port parsing and debug printing to clarify the functional >> parts of parse_ddi_port(), which are quite small nowadays. >> >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/dr

[Intel-gfx] [PATCH 2/2] drm/i915: Add lmem_bar_size modparam

2022-06-14 Thread priyanka . dandamudi
From: Priyanka Dandamudi lmem_bar_size is used to resize lmem bar. It sets to only one of the supported sizes. Setting this param will be in MB unit. Cc: Matthew Auld Signed-off-by: Priyanka Dandamudi --- drivers/gpu/drm/i915/gt/intel_region_lmem.c | 3 +++ drivers/gpu/drm/i915/i915_driver.c

[Intel-gfx] [PATCH 1/2] drm/i915: Add support for LMEM PCIe resizable bar

2022-06-14 Thread priyanka . dandamudi
From: Akeem G Abodunrin This patch adds support for the local memory PICe resizable bar, so that local memory can be resized to the maximum size supported by the device, and mapped correctly to the PCIe memory bar. It is usual that GPU devices expose only 256MB BARs primarily to be compatible wit

[Intel-gfx] [PATCH 0/2] Add support for LMEM PCIe resizable bar

2022-06-14 Thread priyanka . dandamudi
From: Priyanka Dandamudi Added support to resize the bar to maximum supported, only when bar is not set to maximum by default. Also, added new modparam lmem_bar_size which can resize the bar provided if it is among the supported sizes. Akeem G Abodunrin (1): drm/i915: Add support for LMEM PCIe

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hdcp: split out hdcp registers to a separate file

2022-06-14 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: split out hdcp registers to a separate file URL : https://patchwork.freedesktop.org/series/105119/ State : success == Summary == CI Bug Log - changes from CI_DRM_11757_full -> Patchwork_105119v1_full ==

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915/display: Add smem fallback allocation for dpt (rev3)

2022-06-14 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display: Add smem fallback allocation for dpt (rev3) URL : https://patchwork.freedesktop.org/series/104983/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11757_full -> Patchwork_104983v3_full ===

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Clean up drm_crtc.h (rev5)

2022-06-14 Thread Patchwork
== Series Details == Series: drm: Clean up drm_crtc.h (rev5) URL : https://patchwork.freedesktop.org/series/105073/ State : success == Summary == CI Bug Log - changes from CI_DRM_11757_full -> Patchwork_105073v5_full Summary --- **SU

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/dp/mst: Read the extended DPCD capabilities during system resume

2022-06-14 Thread Patchwork
== Series Details == Series: drm/dp/mst: Read the extended DPCD capabilities during system resume URL : https://patchwork.freedesktop.org/series/105102/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11756_full -> Patchwork_105102v1_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dsi: add payload receiving code

2022-06-14 Thread Patchwork
== Series Details == Series: drm/i915/dsi: add payload receiving code URL : https://patchwork.freedesktop.org/series/105096/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11756_full -> Patchwork_105096v1_full Summary --

[Intel-gfx] ✗ Fi.CI.BAT: failure for i915: Extract, polish, and document multicast handling

2022-06-14 Thread Patchwork
== Series Details == Series: i915: Extract, polish, and document multicast handling URL : https://patchwork.freedesktop.org/series/105134/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11758 -> Patchwork_105134v1 Summary --

[Intel-gfx] ✗ Fi.CI.IGT: failure for remove shmem backend and region and unify them with TTM

2022-06-14 Thread Patchwork
== Series Details == Series: remove shmem backend and region and unify them with TTM URL : https://patchwork.freedesktop.org/series/105087/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11755_full -> Patchwork_105087v1_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915: Extract, polish, and document multicast handling

2022-06-14 Thread Patchwork
== Series Details == Series: i915: Extract, polish, and document multicast handling URL : https://patchwork.freedesktop.org/series/105134/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.IGT: success for i915/pmu: Wire GuC backend to per-client busyness

2022-06-14 Thread Patchwork
== Series Details == Series: i915/pmu: Wire GuC backend to per-client busyness URL : https://patchwork.freedesktop.org/series/105085/ State : success == Summary == CI Bug Log - changes from CI_DRM_11755_full -> Patchwork_105085v1_full Summa

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Implement w/a 22010492432 for adl-s

2022-06-14 Thread Patchwork
== Series Details == Series: drm/i915: Implement w/a 22010492432 for adl-s URL : https://patchwork.freedesktop.org/series/105074/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11755_full -> Patchwork_105074v1_full Summary -

[Intel-gfx] [PATCH v2 0/2] i915: Extract, polish, and document multicast handling

2022-06-14 Thread Matt Roper
Multicast/replicated (MCR) registers on Intel hardware are a purely GT-specific concept. Rather than leaving MCR register handling spread across several places throughout the driver (intel_uncore.c, intel_gt.c, etc.) with confusing combinations of handler functions living in different namespaces,

[Intel-gfx] [PATCH v2 2/2] drm/i915/gt: Cleanup interface for MCR operations

2022-06-14 Thread Matt Roper
Let's replace the assortment of intel_gt_* and intel_uncore_* functions that operate on MCR registers with a cleaner set of interfaces: * intel_gt_mcr_read -- unicast read from specific instance * intel_gt_mcr_read_any[_fw] -- unicast read from any non-terminated instance * intel_gt_mcr_

[Intel-gfx] [PATCH v2 1/2] drm/i915/gt: Move multicast register handling to a dedicated file

2022-06-14 Thread Matt Roper
Handling of multicast/replicated registers is spread across intel_gt.c and intel_uncore.c today. As multicast handling and the related steering logic gets more complicated with the addition of new platforms and new rules it makes sense to centralize it all in one place. For now the existing funct

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/display: Add smem fallback allocation for dpt (rev2)

2022-06-14 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display: Add smem fallback allocation for dpt (rev2) URL : https://patchwork.freedesktop.org/series/104983/ State : success == Summary == CI Bug Log - changes from CI_DRM_11755_full -> Patchwork_104983v2_full ===

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pvc: Add recommended MMIO setting

2022-06-14 Thread Patchwork
== Series Details == Series: drm/i915/pvc: Add recommended MMIO setting URL : https://patchwork.freedesktop.org/series/105063/ State : success == Summary == CI Bug Log - changes from CI_DRM_11755_full -> Patchwork_105063v1_full Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Re-add check for low voltage sku for max dp source rate

2022-06-14 Thread Patchwork
== Series Details == Series: drm/i915/display: Re-add check for low voltage sku for max dp source rate URL : https://patchwork.freedesktop.org/series/105048/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11755_full -> Patchwork_105048v1_full ==

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/bios: minor cleanups (rev2)

2022-06-14 Thread Patchwork
== Series Details == Series: drm/i915/bios: minor cleanups (rev2) URL : https://patchwork.freedesktop.org/series/104988/ State : success == Summary == CI Bug Log - changes from CI_DRM_11755_full -> Patchwork_104988v2_full Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for i915: Extract, polish, and document multicast handling

2022-06-14 Thread Patchwork
== Series Details == Series: i915: Extract, polish, and document multicast handling URL : https://patchwork.freedesktop.org/series/105015/ State : success == Summary == CI Bug Log - changes from CI_DRM_11755_full -> Patchwork_105015v1_full

Re: [Intel-gfx] [PATCH 00/15] HuC loading for DG2

2022-06-14 Thread Ye, Tony
On 6/14/2022 8:30 AM, Ceraolo Spurio, Daniele wrote: On 6/14/2022 12:44 AM, Tvrtko Ursulin wrote: On 13/06/2022 19:13, Ceraolo Spurio, Daniele wrote: On 6/13/2022 10:39 AM, Tvrtko Ursulin wrote: On 13/06/2022 18:06, Ceraolo Spurio, Daniele wrote: On 6/13/2022 9:56 AM, Tvrtko Ursulin wrot

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc/slpc: Add a new SLPC selftest (rev2)

2022-06-14 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: Add a new SLPC selftest (rev2) URL : https://patchwork.freedesktop.org/series/105005/ State : success == Summary == CI Bug Log - changes from CI_DRM_11755_full -> Patchwork_105005v2_full Summa

Re: [Intel-gfx] [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-14 Thread Zeng, Oak
Thanks, Oak > -Original Message- > From: dri-devel On Behalf Of > Zeng, Oak > Sent: June 14, 2022 5:13 PM > To: Vishwanathapura, Niranjana ; > Landwerlin, Lionel G > Cc: Intel GFX ; Wilson, Chris P > ; Hellstrom, Thomas > ; Maling list - DRI developers de...@lists.freedesktop.org>; Ve

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pvc: Adjust EU per SS according to HAS_ONE_EU_PER_FUSE_BIT()

2022-06-14 Thread Matt Roper
Looks like the logs links finally work (there was probably a big backlog to upload them after the gitlab downtime). The module_reload log shows and ext4 filesystem panic (not graphics-related). The syncobj_basic failure is an unexpected incomplete; no graphics errors in the log that I can see, al

Re: [Intel-gfx] [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-14 Thread Zeng, Oak
Thanks, Oak > -Original Message- > From: Vishwanathapura, Niranjana > Sent: June 14, 2022 1:02 PM > To: Landwerlin, Lionel G > Cc: Zeng, Oak ; Intel GFX g...@lists.freedesktop.org>; Maling list - DRI developers de...@lists.freedesktop.org>; Hellstrom, Thomas > ; Wilson, Chris P ; > V

Re: [Intel-gfx] [PATCH] drm/i915/pvc: Adjust EU per SS according to HAS_ONE_EU_PER_FUSE_BIT()

2022-06-14 Thread Srivatsa, Anusha
> -Original Message- > From: Intel-gfx On Behalf Of Matt > Roper > Sent: Friday, June 10, 2022 4:08 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH] drm/i915/pvc: Adjust EU per SS according to > HAS_ONE_EU_PER_FUSE_BIT() > > If we're treating each bit in the EU f

[Intel-gfx] ✓ Fi.CI.BAT: success for Break VM to rq reference loop

2022-06-14 Thread Patchwork
== Series Details == Series: Break VM to rq reference loop URL : https://patchwork.freedesktop.org/series/105122/ State : success == Summary == CI Bug Log - changes from CI_DRM_11757 -> Patchwork_105122v1 Summary --- **SUCCESS** N

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pvc: Adjust EU per SS according to HAS_ONE_EU_PER_FUSE_BIT()

2022-06-14 Thread Vudum, Lakshminarayana
I am unable to load both the failures? Is there any other way to get these failures? -Original Message- From: Roper, Matthew D Sent: Tuesday, June 14, 2022 1:07 PM To: intel-gfx@lists.freedesktop.org Cc: Vudum, Lakshminarayana Subject: Re: ✗ Fi.CI.IGT: failure for drm/i915/pvc: Adjust

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pvc: Adjust EU per SS according to HAS_ONE_EU_PER_FUSE_BIT()

2022-06-14 Thread Matt Roper
On Tue, Jun 14, 2022 at 07:20:48PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/pvc: Adjust EU per SS according to HAS_ONE_EU_PER_FUSE_BIT() > URL : https://patchwork.freedesktop.org/series/105010/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_

Re: [Intel-gfx] [PATCH] drm/i915/guc: Check ctx while waiting for response

2022-06-14 Thread Dixit, Ashutosh
On Tue, 14 Jun 2022 09:28:14 -0700, Dixit, Ashutosh wrote: > On Thu, 02 Jun 2022 10:21:19 -0700, Zhanjun Dong wrote: > > > @@ -481,12 +481,14 @@ static int wait_for_ct_request_update(struct > > ct_request *req, u32 *status) > > #define GUC_CTB_RESPONSE_TIMEOUT_SHORT_MS 10 > > #define GUC_CTB_RES

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Break VM to rq reference loop

2022-06-14 Thread Patchwork
== Series Details == Series: Break VM to rq reference loop URL : https://patchwork.freedesktop.org/series/105122/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] iosys-map: Add per-word read

2022-06-14 Thread Patchwork
== Series Details == Series: series starting with [1/3] iosys-map: Add per-word read URL : https://patchwork.freedesktop.org/series/105011/ State : success == Summary == CI Bug Log - changes from CI_DRM_11753_full -> Patchwork_105011v1_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pvc: Adjust EU per SS according to HAS_ONE_EU_PER_FUSE_BIT()

2022-06-14 Thread Patchwork
== Series Details == Series: drm/i915/pvc: Adjust EU per SS according to HAS_ONE_EU_PER_FUSE_BIT() URL : https://patchwork.freedesktop.org/series/105010/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11753_full -> Patchwork_105010v1_full ===

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: disable HPD workers before display driver unregister (rev9)

2022-06-14 Thread Patchwork
== Series Details == Series: drm/i915/display: disable HPD workers before display driver unregister (rev9) URL : https://patchwork.freedesktop.org/series/103811/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11753_full -> Patchwork_103811v9_full ==

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915/display: Add smem fallback allocation for dpt

2022-06-14 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display: Add smem fallback allocation for dpt URL : https://patchwork.freedesktop.org/series/104983/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11753_full -> Patchwork_104983v1_full ==

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] intel-gpu-top: Optimise the scanning loop a bit

2022-06-14 Thread Umesh Nerlige Ramappa
On Mon, Jun 06, 2022 at 02:27:19PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Opendir(3) and fdopendir(3) are quite expensive system calls when ran in a loop which iterates all processes in a system times all open files in each. Replace some of them (easy ones) with simpler open(2)/read(

[Intel-gfx] [PATCH 3/3] drm/i915: Do not use reserved requests for virtual engines

2022-06-14 Thread Ramalingam C
Do not use reserved requests for virtual engines as this is only needed for kernel contexts. Signed-off-by: Ramalingam C Suggested-by: Matthew Brost --- drivers/gpu/drm/i915/i915_request.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_request.

[Intel-gfx] [PATCH 2/3] Revert "drm/i915: Hold reference to intel_context over life of i915_request"

2022-06-14 Thread Ramalingam C
From: Niranjana Vishwanathapura This reverts commit 1e98d8c52ed5dfbaf273c4423c636525c2ce59e7. The problem with this patch is that it makes i915_request to hold a reference to intel_context, which in turn holds a reference on the VM. This strong back referencing can lead to reference loops which

Re: [Intel-gfx] [PATCH] drm/i915/guc: Check ctx while waiting for response

2022-06-14 Thread Dong, Zhanjun
Thanks for all comments, I will update code and prepare for next version. Regards, Zhanjun -Original Message- From: Dixit, Ashutosh Sent: June 14, 2022 12:28 PM To: Dong, Zhanjun Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Teres Alexis, Alan Previn ; Wajdeczk

[Intel-gfx] [PATCH 1/3] drm/i915: Do not access rq->engine without a reference

2022-06-14 Thread Ramalingam C
From: Niranjana Vishwanathapura In i915_fence_get_driver_name(), user may not hold a reference to rq->engine. Hence do not access it. Instead, store required device private pointer in 'rq->i915' and use it. Signed-off-by: Niranjana Vishwanathapura Suggested-by: Matthew Brost --- drivers/gpu/d

[Intel-gfx] [PATCH 0/3] Break VM to rq reference loop

2022-06-14 Thread Ramalingam C
The i915_request holds a reference to intel_context, which in turn holds a reference on the VM. But the dma-resv update for VM_BIND feature would require VM hold a reference to the i915_request through dma-resv fences of VM_PRIVATE objects (which share a per VM dma-resv object). Thus, we have a ci

[Intel-gfx] ✓ Fi.CI.IGT: success for Disable connector polling for a headless sku (rev3)

2022-06-14 Thread Patchwork
== Series Details == Series: Disable connector polling for a headless sku (rev3) URL : https://patchwork.freedesktop.org/series/104711/ State : success == Summary == CI Bug Log - changes from CI_DRM_11753_full -> Patchwork_104711v3_full Sum

Re: [Intel-gfx] [PATCH 2/3] drm/i915/ttm: don't overwrite cache_dirty after setting coherency

2022-06-14 Thread Matthew Auld
On Tue, 14 Jun 2022 at 02:14, Adrian Larumbe wrote: > > When i915_gem_object_set_cache_level sets the GEM object's cache_dirty to > true, in the case of TTM that will sometimes be overwritten when getting > the object's pages, more specifically for shmem-placed objects for which > its ttm structur

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdcp: split out hdcp registers to a separate file

2022-06-14 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: split out hdcp registers to a separate file URL : https://patchwork.freedesktop.org/series/105119/ State : success == Summary == CI Bug Log - changes from CI_DRM_11757 -> Patchwork_105119v1 Summar

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/hdcp: split out hdcp registers to a separate file

2022-06-14 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: split out hdcp registers to a separate file URL : https://patchwork.freedesktop.org/series/105119/ State : warning == Summary == Error: dim checkpatch failed 60447ec4cacf drm/i915/hdcp: split out hdcp registers to a separate file Traceback (most rece

[Intel-gfx] ✗ Fi.CI.BAT: failure for Bump up CDCLK for DG2

2022-06-14 Thread Patchwork
== Series Details == Series: Bump up CDCLK for DG2 URL : https://patchwork.freedesktop.org/series/105110/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11757 -> Patchwork_105110v1 Summary --- **FAILURE** Serious u

Re: [Intel-gfx] [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-14 Thread Niranjana Vishwanathapura
On Tue, Jun 14, 2022 at 10:04:00AM +0300, Lionel Landwerlin wrote: On 13/06/2022 21:02, Niranjana Vishwanathapura wrote: On Mon, Jun 13, 2022 at 06:33:07AM -0700, Zeng, Oak wrote: Regards, Oak -Original Message- From: Intel-gfx On Behalf Of Niranjana Vishwanathapura Sent: June 10

[Intel-gfx] [PATCH] drm/i915/hdcp: split out hdcp registers to a separate file

2022-06-14 Thread Jani Nikula
Reduce the bloat of i915_reg.h. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 1 + drivers/gpu/drm/i915/display/intel_hdcp.c | 1 + .../gpu/drm/i915/display/intel_hdcp_regs.h| 270 ++ drivers/gpu/drm/i915/display/intel_hdmi.c | 1

[Intel-gfx] ✗ Fi.CI.BAT: failure for Do not enable PSR2 if no active planes

2022-06-14 Thread Patchwork
== Series Details == Series: Do not enable PSR2 if no active planes URL : https://patchwork.freedesktop.org/series/105109/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11757 -> Patchwork_105109v1 Summary --- **FAILU

Re: [Intel-gfx] [PATCH 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-14 Thread Niranjana Vishwanathapura
On Tue, Jun 14, 2022 at 05:07:37PM +0100, Tvrtko Ursulin wrote: On 14/06/2022 17:02, Tvrtko Ursulin wrote: On 14/06/2022 16:43, Niranjana Vishwanathapura wrote: On Tue, Jun 14, 2022 at 08:16:41AM +0100, Tvrtko Ursulin wrote: On 14/06/2022 00:39, Matthew Brost wrote: On Mon, Jun 13, 2022 at

Re: [Intel-gfx] [PATCH] i915/pmu: Wire GuC backend to per-client busyness

2022-06-14 Thread Umesh Nerlige Ramappa
On Tue, Jun 14, 2022 at 02:30:42PM +0100, Tvrtko Ursulin wrote: On 14/06/2022 01:46, Nerlige Ramappa, Umesh wrote: From: John Harrison GuC provides engine_id and last_switch_in ticks for an active context in the pphwsp. The context image provides a 32 bit total ticks which is the accumulated

Re: [Intel-gfx] [PATCH] drm/i915/guc: Check ctx while waiting for response

2022-06-14 Thread Dixit, Ashutosh
On Thu, 02 Jun 2022 10:21:19 -0700, Zhanjun Dong wrote: > Hi Zhanjun, > We are seeing error message of "No response for request". Some cases happened > while waiting for response and reset/suspend action was triggered. In this > case, no response is not an error, active requests will be cancelled

Re: [Intel-gfx] [PATCH] drm/i915/guc: Check ctx while waiting for response

2022-06-14 Thread Jani Nikula
On Thu, 02 Jun 2022, Zhanjun Dong wrote: > We are seeing error message of "No response for request". Some cases happened > while waiting for response and reset/suspend action was triggered. In this > case, no response is not an error, active requests will be cancelled. > > This patch will handle t

Re: [Intel-gfx] [PATCH 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-14 Thread Niranjana Vishwanathapura
On Tue, Jun 14, 2022 at 09:27:05AM +0300, Lionel Landwerlin wrote: On 10/06/2022 11:53, Matthew Brost wrote: On Fri, Jun 10, 2022 at 12:07:11AM -0700, Niranjana Vishwanathapura wrote: VM_BIND and related uapi definitions Signed-off-by: Niranjana Vishwanathapura --- Documentation/gpu/rfc/i915

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/display: Add smem fallback allocation for dpt (rev3)

2022-06-14 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display: Add smem fallback allocation for dpt (rev3) URL : https://patchwork.freedesktop.org/series/104983/ State : success == Summary == CI Bug Log - changes from CI_DRM_11757 -> Patchwork_104983v3 =

Re: [Intel-gfx] [PATCH] drm/i915/guc: Check ctx while waiting for response

2022-06-14 Thread Michal Wajdeczko
On 02.06.2022 19:21, Zhanjun Dong wrote: > We are seeing error message of "No response for request". Some cases happened > while waiting for response and reset/suspend action was triggered. In this > case, no response is not an error, active requests will be cancelled. > > This patch will handl

Re: [Intel-gfx] [PATCH 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-14 Thread Tvrtko Ursulin
On 14/06/2022 17:02, Tvrtko Ursulin wrote: On 14/06/2022 16:43, Niranjana Vishwanathapura wrote: On Tue, Jun 14, 2022 at 08:16:41AM +0100, Tvrtko Ursulin wrote: On 14/06/2022 00:39, Matthew Brost wrote: On Mon, Jun 13, 2022 at 07:09:06PM +0100, Tvrtko Ursulin wrote: On 13/06/2022 18:49,

Re: [Intel-gfx] [PATCH 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-14 Thread Tvrtko Ursulin
On 14/06/2022 16:43, Niranjana Vishwanathapura wrote: On Tue, Jun 14, 2022 at 08:16:41AM +0100, Tvrtko Ursulin wrote: On 14/06/2022 00:39, Matthew Brost wrote: On Mon, Jun 13, 2022 at 07:09:06PM +0100, Tvrtko Ursulin wrote: On 13/06/2022 18:49, Niranjana Vishwanathapura wrote: On Mon, Jun

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/display: Add smem fallback allocation for dpt (rev3)

2022-06-14 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display: Add smem fallback allocation for dpt (rev3) URL : https://patchwork.freedesktop.org/series/104983/ State : warning == Summary == Error: dim checkpatch failed 53835e6eed08 drm/i915/display: Add smem fallback allocation f

Re: [Intel-gfx] [PATCH 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-14 Thread Niranjana Vishwanathapura
On Tue, Jun 14, 2022 at 08:16:41AM +0100, Tvrtko Ursulin wrote: On 14/06/2022 00:39, Matthew Brost wrote: On Mon, Jun 13, 2022 at 07:09:06PM +0100, Tvrtko Ursulin wrote: On 13/06/2022 18:49, Niranjana Vishwanathapura wrote: On Mon, Jun 13, 2022 at 05:22:02PM +0100, Tvrtko Ursulin wrote: On

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Clean up drm_crtc.h (rev5)

2022-06-14 Thread Patchwork
== Series Details == Series: drm: Clean up drm_crtc.h (rev5) URL : https://patchwork.freedesktop.org/series/105073/ State : success == Summary == CI Bug Log - changes from CI_DRM_11757 -> Patchwork_105073v5 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH] drm/i915/guc: Check ctx while waiting for response

2022-06-14 Thread Teres Alexis, Alan Previn
Can't see anything wrong with this. I consider this only a NIT, so feel : not sure if -ECANCELLED is reflective of the "ct service being temporarily down" as opposed to the "requester cancelling". Perhaps a -EPIPE or -EAGAIN (if we got this far, we know we are probably mid- reset) ?? (if not alre

Re: [Intel-gfx] [PATCH 00/15] HuC loading for DG2

2022-06-14 Thread Ceraolo Spurio, Daniele
On 6/14/2022 12:44 AM, Tvrtko Ursulin wrote: On 13/06/2022 19:13, Ceraolo Spurio, Daniele wrote: On 6/13/2022 10:39 AM, Tvrtko Ursulin wrote: On 13/06/2022 18:06, Ceraolo Spurio, Daniele wrote: On 6/13/2022 9:56 AM, Tvrtko Ursulin wrote: On 13/06/2022 17:41, Ceraolo Spurio, Daniele wrote:

Re: [Intel-gfx] [PATCH v7] drm/i915/display: disable HPD workers before display driver unregister

2022-06-14 Thread Andrzej Hajda
On 10.06.2022 20:37, Ville Syrjälä wrote: On Fri, Jun 10, 2022 at 06:00:24PM +0200, Andrzej Hajda wrote: Handling HPD during driver removal is pointless, and can cause different use-after-free/concurrency issues: 1. Setup of deferred fbdev after fbdev unregistration. 2. Access to DP-AUX after DP

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/dp/mst: Read the extended DPCD capabilities during system resume

2022-06-14 Thread Patchwork
== Series Details == Series: drm/dp/mst: Read the extended DPCD capabilities during system resume URL : https://patchwork.freedesktop.org/series/105102/ State : success == Summary == CI Bug Log - changes from CI_DRM_11756 -> Patchwork_105102v1 ==

Re: [Intel-gfx] [PATCH] drm/dp/mst: Read the extended DPCD capabilities during system resume

2022-06-14 Thread Jani Nikula
On Tue, 14 Jun 2022, Imre Deak wrote: > On Tue, Jun 14, 2022 at 03:32:59PM +0300, Jani Nikula wrote: >> On Tue, 14 Jun 2022, Imre Deak wrote: >> > The WD22TB4 Thunderbolt dock at least will revert its DP_MAX_LINK_RATE >> > from HBR3 to HBR2 after system suspend/resume if the DP_DP13_DPCD_REV >> >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: add payload receiving code

2022-06-14 Thread Patchwork
== Series Details == Series: drm/i915/dsi: add payload receiving code URL : https://patchwork.freedesktop.org/series/105096/ State : success == Summary == CI Bug Log - changes from CI_DRM_11756 -> Patchwork_105096v1 Summary --- **SUC

Re: [Intel-gfx] [PATCH] i915/pmu: Wire GuC backend to per-client busyness

2022-06-14 Thread Tvrtko Ursulin
On 14/06/2022 01:46, Nerlige Ramappa, Umesh wrote: From: John Harrison GuC provides engine_id and last_switch_in ticks for an active context in the pphwsp. The context image provides a 32 bit total ticks which is the accumulated by the context (a.k.a. context[CTX_TIMESTAMP]). This information

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: add payload receiving code

2022-06-14 Thread Patchwork
== Series Details == Series: drm/i915/dsi: add payload receiving code URL : https://patchwork.freedesktop.org/series/105096/ State : warning == Summary == Error: dim checkpatch failed c041108e8df4 drm/i915/dsi: add payload receiving code -:27: CHECK:PARENTHESIS_ALIGNMENT: Alignment should matc

Re: [Intel-gfx] [PATCH] drm/dp/mst: Read the extended DPCD capabilities during system resume

2022-06-14 Thread Imre Deak
On Tue, Jun 14, 2022 at 03:32:59PM +0300, Jani Nikula wrote: > On Tue, 14 Jun 2022, Imre Deak wrote: > > The WD22TB4 Thunderbolt dock at least will revert its DP_MAX_LINK_RATE > > from HBR3 to HBR2 after system suspend/resume if the DP_DP13_DPCD_REV > > registers are not read subsequently also as

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Do not enable PSR2/selective fetch if there are no planes

2022-06-14 Thread Hogander, Jouni
On Tue, 2022-06-14 at 15:22 +0300, Stanislav Lisovskiy wrote: > We seem to enable PSR2 and selective fetch even if there are no > active > planes. That seems to causes FIFO underruns at least for ADLP. > Those are gone if we don't do that. Just adding simple check > in intel_psr2_sel_fetch_config_v

Re: [Intel-gfx] [PATCH] drm/dp/mst: Read the extended DPCD capabilities during system resume

2022-06-14 Thread Jani Nikula
On Tue, 14 Jun 2022, Jani Nikula wrote: > On Tue, 14 Jun 2022, Imre Deak wrote: >> The WD22TB4 Thunderbolt dock at least will revert its DP_MAX_LINK_RATE >> from HBR3 to HBR2 after system suspend/resume if the DP_DP13_DPCD_REV >> registers are not read subsequently also as required. > > Does it a

Re: [Intel-gfx] [PATCH] drm/dp/mst: Read the extended DPCD capabilities during system resume

2022-06-14 Thread Jani Nikula
On Tue, 14 Jun 2022, Imre Deak wrote: > The WD22TB4 Thunderbolt dock at least will revert its DP_MAX_LINK_RATE > from HBR3 to HBR2 after system suspend/resume if the DP_DP13_DPCD_REV > registers are not read subsequently also as required. Does it actually change the behaviour depending on whether

[Intel-gfx] [PATCH 1/1] drm/i915/dg2: Bump up CDCLK for DG2

2022-06-14 Thread Stanislav Lisovskiy
We seem to need this W/A same way as for TGL, in order to fix some of the underruns, which we currently have and those not related to PSR. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_cdclk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dri

[Intel-gfx] [PATCH 0/1] Bump up CDCLK for DG2

2022-06-14 Thread Stanislav Lisovskiy
We set it to be equal to pixel rate here, just same as we have already for TGL, as that seems to be currently the only solution to fix underruns, not related to PSR. Stanislav Lisovskiy (1): drm/i915/dg2: Bump up CDCLK for DG2 drivers/gpu/drm/i915/display/intel_cdclk.c | 4 ++-- 1 file changed

[Intel-gfx] [PATCH 1/1] drm/i915: Do not enable PSR2/selective fetch if there are no planes

2022-06-14 Thread Stanislav Lisovskiy
We seem to enable PSR2 and selective fetch even if there are no active planes. That seems to causes FIFO underruns at least for ADLP. Those are gone if we don't do that. Just adding simple check in intel_psr2_sel_fetch_config_valid seems to do the trick. Signed-off-by: Stanislav Lisovskiy --- dr

[Intel-gfx] [PATCH 0/1] Do not enable PSR2 if no active planes

2022-06-14 Thread Stanislav Lisovskiy
We seem to cause FIFO underruns by doing that. Also it doesn't make sense. Stanislav Lisovskiy (1): drm/i915: Do not enable PSR2/selective fetch if there are no planes drivers/gpu/drm/i915/display/intel_psr.c | 6 ++ 1 file changed, 6 insertions(+) -- 2.24.1.485.gad05a3d8e5

[Intel-gfx] [PATCH v3 7/8] drm: Remove linux/media-bus-format.h from drm_crtc.h

2022-06-14 Thread Ville Syrjala
From: Ville Syrjälä drm_crtc.h has no need for linux/media-bus-format.h, so don't include it. Avoids useless rebuilds of the entire universe when touching linux/media-bus-format.h. Quite a few placs do currently depend on linux/media-bus-format.h without actually including it directly. All of th

[Intel-gfx] [PATCH v3 2/8] drm: Drop drm_framebuffer.h from drm_crtc.h

2022-06-14 Thread Ville Syrjala
From: Ville Syrjälä drm_crtc.h has no need for drm_frambuffer.h, so don't include it. Avoids useless rebuilds of the entire universe when touching drm_framebuffer.h. Quite a few placs do currently depend on drm_framebuffer.h without actually including it directly. All of those need to be fixed u

[Intel-gfx] [PATCH] drm/dp/mst: Read the extended DPCD capabilities during system resume

2022-06-14 Thread Imre Deak
The WD22TB4 Thunderbolt dock at least will revert its DP_MAX_LINK_RATE from HBR3 to HBR2 after system suspend/resume if the DP_DP13_DPCD_REV registers are not read subsequently also as required. Fix this by reading DP_DP13_DPCD_REV registers as well, matching what is done during connector detectio

Re: [Intel-gfx] [PATCH v2] drm/i915: Support Async Flip on Linear buffers

2022-06-14 Thread Murthy, Arun R
Any comments? Thanks and Regards, Arun R Murthy > -Original Message- > From: Murthy, Arun R > Sent: Wednesday, June 1, 2022 9:54 AM > To: intel-gfx@lists.freedesktop.org > Cc: ville.syrj...@linux.intel.com; B S, Karthik ; > Murthy, Arun R > Subject: [PATCH v2] drm/i

[Intel-gfx] [PATCH v2 2/8] drm: Drop drm_framebuffer.h from drm_crtc.h

2022-06-14 Thread Ville Syrjala
From: Ville Syrjälä drm_crtc.h has no need for drm_frambuffer.h, so don't include it. Avoids useless rebuilds of the entire universe when touching drm_framebuffer.h. Quite a few placs do currently depend on drm_framebuffer.h without actually including it directly. All of those need to be fixed u

[Intel-gfx] [PATCH v2 1/8] drm: Drop drm_edid.h from drm_crtc.h

2022-06-14 Thread Ville Syrjala
From: Ville Syrjälä drm_crtc.h has no need for drm_edid.h, so don't include it. Avoids useless rebuilds of the entire universe when touching drm_edid.h. Quite a few placs do currently depend on drm_edid.h without actually including it directly. All of those need to be fixed up. v2: Fix up i915

Re: [Intel-gfx] [PATCH 0/6] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-06-14 Thread Gwan-gyeong Mun
On 6/3/22 4:19 PM, Jani Nikula wrote: On Fri, 03 Jun 2022, Gwan-gyeong Mun wrote: This patch series fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation, etc. We need to check that we avoid integer overflows when looking up a p

[Intel-gfx] [PATCH] drm/i915/dsi: add payload receiving code

2022-06-14 Thread William Tseng
To support Host to read data from Peripheral after a DCS read command is sent over DSI. Cc: Jani Nikula Cc: Ville Syrjälä Cc: Vandita Kulkarni Cc: Lee Shawn C Signed-off-by: William Tseng --- drivers/gpu/drm/i915/display/icl_dsi.c | 68 - drivers/gpu/drm/i915/display

Re: [Intel-gfx] [PATCH 0/8] drm: Clean up drm_crtc.h

2022-06-14 Thread Jani Nikula
On Mon, 13 Jun 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Eliminate unnecessary includes from drm_crtc.h to avoid > pointless rebuilds of the entire universe when touching > some random header. > > I didn't really feel like splitting this up per-driver since > that would have ended up b

Re: [Intel-gfx] [PATCH] drm/i915: Improve user experience and driver robustness under SIGINT or similar

2022-06-14 Thread Tvrtko Ursulin
Final call to raise objections. Regards, Tvrtko On 07/06/2022 09:36, Tvrtko Ursulin wrote: On 27/05/2022 13:07, Andrzej Hajda wrote: On 27.05.2022 09:24, Tvrtko Ursulin wrote: From: Tvrtko Ursulin We have long standing customer complaints that pressing Ctrl-C (or to the effect of) cau

Re: [Intel-gfx] [PATCH 00/15] HuC loading for DG2

2022-06-14 Thread Tvrtko Ursulin
On 13/06/2022 19:13, Ceraolo Spurio, Daniele wrote: On 6/13/2022 10:39 AM, Tvrtko Ursulin wrote: On 13/06/2022 18:06, Ceraolo Spurio, Daniele wrote: On 6/13/2022 9:56 AM, Tvrtko Ursulin wrote: On 13/06/2022 17:41, Ceraolo Spurio, Daniele wrote: On 6/13/2022 9:31 AM, Tvrtko Ursulin wrote:

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] intel-gpu-top: Optimise the scanning loop a bit

2022-06-14 Thread Tvrtko Ursulin
+ Umesh If you have time this is an easy improvement extracted from the "vendor agnostic gputop" series. Regards, Tvrtko On 06/06/2022 14:27, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Opendir(3) and fdopendir(3) are quite expensive system calls when ran in a loop which iterates all pro

Re: [Intel-gfx] [PATCH 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-14 Thread Tvrtko Ursulin
On 14/06/2022 00:39, Matthew Brost wrote: On Mon, Jun 13, 2022 at 07:09:06PM +0100, Tvrtko Ursulin wrote: On 13/06/2022 18:49, Niranjana Vishwanathapura wrote: On Mon, Jun 13, 2022 at 05:22:02PM +0100, Tvrtko Ursulin wrote: On 13/06/2022 16:05, Niranjana Vishwanathapura wrote: On Mon, Jun

Re: [Intel-gfx] [Intel-gfx 1/1] drm/i915/guc: Don't update engine busyness stats too frequently

2022-06-14 Thread Tvrtko Ursulin
On 14/06/2022 02:10, Umesh Nerlige Ramappa wrote: On Sat, Jun 11, 2022 at 10:27:11AM -0700, Alan Previn wrote: Using igt's gem-create and with additional patches to track object creation time, it was measured that guc_update_engine_gt_clks was getting called over 188 thousand times in the span

Re: [Intel-gfx] [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-14 Thread Lionel Landwerlin
On 13/06/2022 21:02, Niranjana Vishwanathapura wrote: On Mon, Jun 13, 2022 at 06:33:07AM -0700, Zeng, Oak wrote: Regards, Oak -Original Message- From: Intel-gfx On Behalf Of Niranjana Vishwanathapura Sent: June 10, 2022 1:43 PM To: Landwerlin, Lionel G Cc: Intel GFX ; Maling list