[Intel-gfx] [PULL] drm-misc-next

2022-07-07 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the PR for drm-misc-next. Best regards Thomas drm-misc-next-2022-07-07: drm-misc-next for v5.20: UAPI Changes: Cross-subsystem Changes: Core Changes: * crtc: Remove unnessary include statements from drm_crtc.h, plus fallout in drivers * edid: More use of stru

Re: [Intel-gfx] [RFC 01/10] drm/i915/vm_bind: Introduce VM_BIND ioctl

2022-07-07 Thread Hellstrom, Thomas
On Wed, 2022-07-06 at 22:01 -0700, Niranjana Vishwanathapura wrote: > > > +   /** > > > +    * true: allow only vm_bind method of binding. > > > +    * false: allow only legacy execbuff method of binding. > > > +    */ > > > > Use proper kerneldoc. (Same holds for structure documen

Re: [Intel-gfx] [PATCH] i915/perf: Disable OA sseu config param for non-gen11 platforms

2022-07-07 Thread Lionel Landwerlin
On 07/07/2022 00:52, Nerlige Ramappa, Umesh wrote: The global sseu config is applicable only to gen11 platforms where concurrent media, render and OA use cases may cause some subslices to be turned off and hence lose NOA configuration. Return ENODEV for non-gen11 platforms. Signed-off-by: Umesh

Re: [Intel-gfx] [RFC 02/10] drm/i915/vm_bind: Bind and unbind mappings

2022-07-07 Thread Thomas Hellström
On Wed, 2022-07-06 at 22:43 -0700, Niranjana Vishwanathapura wrote: > On Wed, Jul 06, 2022 at 06:21:03PM +0200, Thomas Hellström wrote: > > On Fri, 2022-07-01 at 15:50 -0700, Niranjana Vishwanathapura wrote: > > > Bind and unbind the mappings upon VM_BIND and VM_UNBIND calls. > > > > > > Signed-of

Re: [Intel-gfx] [RFT][PATCH v2 1/9] vfio: Make vfio_unpin_pages() return void

2022-07-07 Thread Tian, Kevin
> From: Nicolin Chen > Sent: Wednesday, July 6, 2022 2:28 PM > > There's only one caller that checks its return value with a WARN_ON_ONCE, > while all other callers do not check return value at all. So simplify the > API to return void by embedding similar WARN_ON_ONCEs. While this change keeps

Re: [Intel-gfx] [RFT][PATCH v2 4/9] vfio: Pass in starting IOVA to vfio_pin/unpin_pages API

2022-07-07 Thread Tian, Kevin
> From: Nicolin Chen > Sent: Wednesday, July 6, 2022 2:28 PM > /* > - * Pin a set of guest PFNs and return their associated host PFNs for local > + * Pin contiguous guest pages and return their associated host pages for > local can we replace 'guest' with 'user'? > * domain only. > * @device

Re: [Intel-gfx] [RFT][PATCH v2 7/9] vfio: Rename user_iova of vfio_dma_rw()

2022-07-07 Thread Tian, Kevin
> From: Nicolin Chen > Sent: Wednesday, July 6, 2022 2:28 PM > > Following the updated vfio_pin/unpin_pages(), use the simpler "iova". > > Signed-off-by: Nicolin Chen Reviewed-by: Kevin Tian

Re: [Intel-gfx] [RFT][PATCH v2 9/9] vfio: Replace phys_pfn with pages for vfio_pin_pages()

2022-07-07 Thread Tian, Kevin
> From: Nicolin Chen > Sent: Wednesday, July 6, 2022 2:28 PM > > Most of the callers of vfio_pin_pages() want "struct page *" and the > low-level mm code to pin pages returns a list of "struct page *" too. > So there's no gain in converting "struct page *" to PFN in between. > > Replace the outp

[Intel-gfx] Cleanup of TTM NULL resources

2022-07-07 Thread Christian König
Hi guys, sending this out once more since it was requested that the Intel CI systems can take a run of this as well. The last version had a couple of merge/rebase leftovers which are now fixed as well. Please review and/or comment, Christian.

[Intel-gfx] [PATCH 1/6] drm/ttm: rename and cleanup ttm_bo_init_reserved

2022-07-07 Thread Christian König
Rename ttm_bo_init_reserved to ttm_bo_init_validate since that better matches what the function is actually doing. Remove the unused size parameter, move the function's kerneldoc to the implementation and cleanup the whole error handling. Signed-off-by: Christian König --- drivers/gpu/drm/amd/a

[Intel-gfx] [PATCH 3/6] drm/nouveau: audit bo->resource usage

2022-07-07 Thread Christian König
Make sure we can at least move and release BOs without backing store. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index 9

[Intel-gfx] [PATCH 2/6] drm/amdgpu: audit bo->resource usage

2022-07-07 Thread Christian König
Make sure we can at least move and release BOs without backing store. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgp

[Intel-gfx] [PATCH 4/6] drm/ttm: audit bo->resource usage v2

2022-07-07 Thread Christian König
Allow BOs to exist without backing store. v2: handle ttm_bo_move_memcpy as well. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 16 drivers/gpu/drm/ttm/ttm_bo_util.c | 7 +-- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/g

[Intel-gfx] [PATCH 5/6] drm/ttm: stop allocating dummy resources during BO creation

2022-07-07 Thread Christian König
That should not be necessary any more when drivers should at least be able to handle the move without a resource. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c

[Intel-gfx] [PATCH 6/6] drm/ttm: stop allocating a dummy resource for pipelined gutting

2022-07-07 Thread Christian König
That should not be necessary any more when drivers should at least be able to handle a move without a resource. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_uti

Re: [Intel-gfx] [RFC 03/10] drm/i915/vm_bind: Support private and shared BOs

2022-07-07 Thread Hellstrom, Thomas
On Fri, 2022-07-01 at 15:50 -0700, Niranjana Vishwanathapura wrote: > Add uapi allowing user to specify a BO as private to a specified VM > during the BO creation. > VM private BOs can only be mapped on the specified VM and can't be > dma_buf exported. VM private BOs share a single common dma_resv

Re: [Intel-gfx] [RFC 05/10] drm/i915/vm_bind: Handle persistent vmas

2022-07-07 Thread Hellstrom, Thomas
On Fri, 2022-07-01 at 15:50 -0700, Niranjana Vishwanathapura wrote: > Treat VM_BIND vmas as persistent and handle them during the > request submission in the execbuff path. > > Support eviction by maintaining a list of evicted persistent vmas > for rebinding during next submission. > > Signed-off

[Intel-gfx] [PATCH i-g-t] Revert "lib/i915: request CPU_ACCESS for fb objects"

2022-07-07 Thread Matthew Auld
This reverts commit 3cf110f8dcd1f4f02cf84339664b413abdaebf7d. This is too big of a hammer it seems, since we can't really support flat-CCS with lmem + smem objects, and here adding the flag means we also attach the smem placement, which seems to break kms_ccs. Signed-off-by: Matthew Auld Cc: Juh

Re: [Intel-gfx] [PATCH i-g-t] Revert "lib/i915: request CPU_ACCESS for fb objects"

2022-07-07 Thread Juha-Pekka Heikkila
Reviewed-by: Juha-Pekka Heikkila On 7.7.2022 15.23, Matthew Auld wrote: This reverts commit 3cf110f8dcd1f4f02cf84339664b413abdaebf7d. This is too big of a hammer it seems, since we can't really support flat-CCS with lmem + smem objects, and here adding the flag means we also attach the smem pl

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] Revert "lib/i915: request CPU_ACCESS for fb objects"

2022-07-07 Thread Das, Nirmoy
Reviewed-by: Nirmoy Das On 7/7/2022 2:23 PM, Matthew Auld wrote: This reverts commit 3cf110f8dcd1f4f02cf84339664b413abdaebf7d. This is too big of a hammer it seems, since we can't really support flat-CCS with lmem + smem objects, and here adding the flag means we also attach the smem placement

Re: [Intel-gfx] [RFC 08/10] drm/i915/vm_bind: userptr dma-resv changes

2022-07-07 Thread Hellstrom, Thomas
On Fri, 2022-07-01 at 15:50 -0700, Niranjana Vishwanathapura wrote: > For persistent (vm_bind) vmas of userptr BOs, handle the user > page pinning by using the i915_gem_object_userptr_submit_init() > /done() functions > > Signed-off-by: Niranjana Vishwanathapura > > --- >  .../gpu/drm/i915/gem/i9

[Intel-gfx] [PULL] drm-intel-fixes

2022-07-07 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes our fixes targeting 5.19-rc6. There will probably be a couple more important fixes coming next week for the -rc7 drm-intel-fixes-2022-07-07: - Fix a possible refcount leak in DP MST connector (Hangyu) - Fix on loading guc on ADL-N (Daniele) - Fix vm use-after-free

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/hdmi: Prune modes that require HDMI2.1 FRL

2022-07-07 Thread Patchwork
== Series Details == Series: drm/i915/hdmi: Prune modes that require HDMI2.1 FRL URL : https://patchwork.freedesktop.org/series/106011/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11855_full -> Patchwork_106011v1_full Sum

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/6] drm/ttm: rename and cleanup ttm_bo_init_reserved

2022-07-07 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/ttm: rename and cleanup ttm_bo_init_reserved URL : https://patchwork.freedesktop.org/series/106027/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/6] drm/ttm: rename and cleanup ttm_bo_init_reserved

2022-07-07 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/ttm: rename and cleanup ttm_bo_init_reserved URL : https://patchwork.freedesktop.org/series/106027/ State : warning == Summary == Error: dim checkpatch failed b5704a48c4ba drm/ttm: rename and cleanup ttm_bo_init_reserved -:162: CHECK

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/6] drm/ttm: rename and cleanup ttm_bo_init_reserved

2022-07-07 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/ttm: rename and cleanup ttm_bo_init_reserved URL : https://patchwork.freedesktop.org/series/106027/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11857 -> Patchwork_106027v1 ==

Re: [Intel-gfx] [RFC 06/10] drm/i915/vm_bind: Add I915_GEM_EXECBUFFER3 ioctl

2022-07-07 Thread Hellstrom, Thomas
On Fri, 2022-07-01 at 15:50 -0700, Niranjana Vishwanathapura wrote: > Add new execbuf3 ioctl (I915_GEM_EXECBUFFER3) which only > works in vm_bind mode. The vm_bind mode only works with > this new execbuf3 ioctl. > > The new execbuf3 ioctl will not have any execlist I understand this that you mean

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fix TLB invalidate issues with Broadwell (rev4)

2022-07-07 Thread Patchwork
== Series Details == Series: Fix TLB invalidate issues with Broadwell (rev4) URL : https://patchwork.freedesktop.org/series/105167/ State : warning == Summary == Error: dim checkpatch failed 158bc8b5e012 drm/i915/gt: Serialize GRDOM access between multiple engine resets -:109: WARNING:FROM_SIG

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Fix TLB invalidate issues with Broadwell (rev4)

2022-07-07 Thread Patchwork
== Series Details == Series: Fix TLB invalidate issues with Broadwell (rev4) URL : https://patchwork.freedesktop.org/series/105167/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/gt/

Re: [Intel-gfx] [RFC 07/10] drm/i915/vm_bind: Handle persistent vmas in execbuf3

2022-07-07 Thread Hellstrom, Thomas
On Fri, 2022-07-01 at 15:50 -0700, Niranjana Vishwanathapura wrote: > Handle persistent (VM_BIND) mappings during the request submission > in the execbuf3 path. > > Signed-off-by: Niranjana Vishwanathapura > > --- >  .../gpu/drm/i915/gem/i915_gem_execbuffer3.c   | 176 > +- >  1 fi

[Intel-gfx] ✓ Fi.CI.BAT: success for Fix TLB invalidate issues with Broadwell (rev4)

2022-07-07 Thread Patchwork
== Series Details == Series: Fix TLB invalidate issues with Broadwell (rev4) URL : https://patchwork.freedesktop.org/series/105167/ State : success == Summary == CI Bug Log - changes from CI_DRM_11857 -> Patchwork_105167v4 Summary ---

Re: [Intel-gfx] [PATCH v5 02/14] drm/i915/gsc: add slow_fw flag to the mei auxiliary device

2022-07-07 Thread Rodrigo Vivi
On Wed, Jul 06, 2022 at 02:43:33PM +0300, Alexander Usyskin wrote: > Add slow_fw flag to the mei auxiliary device info > to inform the mei driver about slow underlying firmware. > Such firmware will require to use larger operation timeouts. > > Signed-off-by: Alexander Usyskin > Signed-off-by: To

[Intel-gfx] [PATCH v9 00/11] drm/i915: ttm for stolen

2022-07-07 Thread Robert Beckett
This series refactors i915's stolen memory region to use ttm. v2: handle disabled stolen similar to legacy version. relying on ttm to fail allocs works fine, but is dmesg noisy and causes testing dmesg warning regressions. v3: rebase to latest drm-tip. fix v2 code

[Intel-gfx] [PATCH v9 01/11] drm/i915/ttm: dont trample cache_level overrides during ttm move

2022-07-07 Thread Robert Beckett
Various places within the driver override the default chosen cache_level. Before ttm, these overrides were permanent until explicitly changed again or for the lifetime of the buffer. TTM movement code came along and decided that it could make that decision at that time, which is usually well after

[Intel-gfx] [PATCH v9 03/11] drm/i915/ttm: only trust snooping for dgfx when deciding default cache_level

2022-07-07 Thread Robert Beckett
By default i915_ttm_cache_level() decides I915_CACHE_LLC if HAS_SNOOP. This is divergent from existing backends code which only considers HAS_LLC. Testing shows that trusting snooping on gen5- is unreliable and bsw via ggtt mappings, so limit DGFX for now and maintain previous behaviour. Signed-of

[Intel-gfx] [PATCH v9 02/11] drm/i915: limit ttm to dma32 for i965G[M]

2022-07-07 Thread Robert Beckett
i965G[M] cannot relocate objects above 4GiB. Ensure ttm uses dma32 on these systems. Signed-off-by: Robert Beckett Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/intel_region_ttm.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_regio

[Intel-gfx] [PATCH v9 04/11] drm/i915/gem: selftest should not attempt mmap of private regions

2022-07-07 Thread Robert Beckett
During testing make can_mmap consider whether the region is private. Signed-off-by: Robert Beckett Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/dr

[Intel-gfx] [PATCH v9 07/11] drm/i915: ttm move/clear logic fix

2022-07-07 Thread Robert Beckett
ttm managed buffers start off with system resource definitions and ttm_tt tracking structures allocated (though unpopulated). currently this prevents clearing of buffers on first move to desired placements. The desired behaviour is to clear user allocated buffers and any kernel buffers that specif

[Intel-gfx] [PATCH v9 06/11] drm/i915: sanitize mem_flags for stolen buffers

2022-07-07 Thread Robert Beckett
Stolen regions are not page backed or considered iomem. Prevent flags indicating such. This correctly prevents stolen buffers from attempting to directly map them. See i915_gem_object_has_struct_page() and i915_gem_object_has_iomem() usage for where it would break otherwise. Signed-off-by: Robert

[Intel-gfx] [PATCH v9 05/11] drm/i915: instantiate ttm ranger manager for stolen memory

2022-07-07 Thread Robert Beckett
prepare for ttm based stolen region by using ttm range manager as the resource manager for stolen region. Signed-off-by: Robert Beckett Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 6 ++-- drivers/gpu/drm/i915/intel_region_ttm.c | 31 +++

[Intel-gfx] [PATCH v9 08/11] drm/i915/ttm: add buffer pin on alloc flag

2022-07-07 Thread Robert Beckett
For situations where allocations need to fail on alloc instead of delayed get_pages, add a new alloc flag to pin the ttm bo. This makes sure that the resource has been allocated during buffer creation, allowing it to fail with an error if the placement is exhausted. This allows existing fallback op

[Intel-gfx] [PATCH v9 09/11] drm/i915/selftest: don't attempt engine reset of guc submission engines

2022-07-07 Thread Robert Beckett
igt_reset_engines_stolen tries to reset engines without checking if it is possible. Engines using GuC submission are not able to be reset from the host. In this scenario, the reset exits early, then on the next iteration of the each engine loop, the async teardown of the spinner request context's

[Intel-gfx] [PATCH v9 10/11] drm/i915/selftest: wait for requests during engine reset selftest

2022-07-07 Thread Robert Beckett
While looping around each engine and testing for corrupted solen memory during engine reset, the old requests from the previous engine can still be yet to retire. To prevent false positive corruption tests, wait for the outstanding requests at the end of the test Signed-off-by: Robert Beckett ---

[Intel-gfx] [PATCH v9 11/11] drm/i915: stolen memory use ttm backend

2022-07-07 Thread Robert Beckett
refactor stolen memory region to use ttm. this necessitates using ttm resources to track reserved stolen regions instead of drm_mm_nodes. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/display/intel_fbc.c | 78 ++-- .../gpu/drm/i915/gem/i915_gem_object_types.h | 2 - drivers/gpu

[Intel-gfx] [PATCH] drm/i915/ttm: fix sg_table construction

2022-07-07 Thread Matthew Auld
If we encounter some monster sized local-memory page that exceeds the maximum sg length (UINT32_MAX), ensure that don't end up with some misaligned address in the entry that follows, leading to fireworks later. Also ensure we have some coverage of this in the selftests. Fixes: f701b16d4cc5 ("drm/i

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: ttm for stolen (rev7)

2022-07-07 Thread Patchwork
== Series Details == Series: drm/i915: ttm for stolen (rev7) URL : https://patchwork.freedesktop.org/series/101396/ State : success == Summary == CI Bug Log - changes from CI_DRM_11857 -> Patchwork_101396v7 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 1/6] drm/ttm: rename and cleanup ttm_bo_init_reserved

2022-07-07 Thread kernel test robot
Hi "Christian, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Christian-K-nig/drm-ttm-rename-and-cleanup-ttm_bo_init_reserved/20220707-192538 base: git://anongit.freedesktop.org/drm/dr

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ttm: fix sg_table construction

2022-07-07 Thread Patchwork
== Series Details == Series: drm/i915/ttm: fix sg_table construction URL : https://patchwork.freedesktop.org/series/106048/ State : success == Summary == CI Bug Log - changes from CI_DRM_11857 -> Patchwork_106048v1 Summary --- **SUCC

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gem: Look for waitboosting across the whole object prior to individual waits

2022-07-07 Thread Rodrigo Vivi
On Tue, Jul 05, 2022 at 12:57:17PM +0200, Karolina Drobnik wrote: > From: Chris Wilson > > We employ a "waitboost" heuristic to detect when userspace is stalled > waiting for results from earlier execution. Under latency sensitive work > mixed between the gpu/cpu, the GPU is typically under-utili

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Bump GT idling delay to 2 jiffies

2022-07-07 Thread Rodrigo Vivi
On Tue, Jul 05, 2022 at 12:57:18PM +0200, Karolina Drobnik wrote: > From: Chris Wilson > > In monitoring a transcode pipeline that is latency sensitive (it waits > between submitting frames, and each frame requires work on rcs/vcs/vecs > engines), it is found that it took longer than a single jif

[Intel-gfx] [PATCH 2/2] drm/i915/mtl: Add MeteorLake PCI IDs

2022-07-07 Thread Radhakrishna Sripada
Add Meteorlake PCI IDs. Split into M, and P subplatforms. Bspec: 55420 Signed-off-by: Radhakrishna Sripada Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_drv.h | 4 drivers/gpu/drm/i915/i915_pci.c | 1 + drivers/gpu/drm/i915/intel_device_info.c | 14 ++

[Intel-gfx] [PATCH 0/2] i915: Introduce Meteorlake

2022-07-07 Thread Radhakrishna Sripada
Meteorlake is a new client platform following RPL S. Meteorlake introduces version 14 for Display, version 13 Media and version 12.70 for Graphics. This is the basic platform definition series to introduce Meteorlake. Radhakrishna Sripada (2): drm/i915/mtl: Add MeteorLake platform info drm/i9

[Intel-gfx] [PATCH 1/2] drm/i915/mtl: Add MeteorLake platform info

2022-07-07 Thread Radhakrishna Sripada
MTL has Xe_LPD+ display IP (version = 14), MTL graphics IP (version = 12.70), and Xe_LPM+ media IP (version = 13). Bspec: 55413 Bspec: 55416 Bspec: 55417 Bspec: 55418 Bspec: 55726 Bspec: 45544 Bspec: 65380 Cc: Matt Roper Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH] i915/perf: Disable OA sseu config param for non-gen11 platforms

2022-07-07 Thread Nerlige Ramappa, Umesh
The global sseu config is applicable only to gen11 platforms where concurrent media, render and OA use cases may cause some subslices to be turned off and hence lose NOA configuration. Return ENODEV for non-gen11 platforms. v2: gfx12 is already shipped with this, disable for gfx12.5+ (Lionel) Sig

Re: [Intel-gfx] [PATCH] i915/perf: Disable OA sseu config param for non-gen11 platforms

2022-07-07 Thread Umesh Nerlige Ramappa
On Thu, Jul 07, 2022 at 11:27:38AM -0700, Nerlige Ramappa, Umesh wrote: The global sseu config is applicable only to gen11 platforms where concurrent media, render and OA use cases may cause some subslices to be turned off and hence lose NOA configuration. Return ENODEV for non-gen11 platforms.

[Intel-gfx] [PATCH] i915/perf: Disable OA sseu config param for gfx12.5+

2022-07-07 Thread Nerlige Ramappa, Umesh
The global sseu config is applicable only to gen11 platforms where concurrent media, render and OA use cases may cause some subslices to be turned off and hence lose NOA configuration. Ideally we want to return ENODEV for non-gen11 platforms, however, this has shipped with gfx12, so disable only fo

Re: [Intel-gfx] [PATCH] i915/perf: Disable OA sseu config param for non-gen11 platforms

2022-07-07 Thread Matt Roper
On Thu, Jul 07, 2022 at 11:27:38AM -0700, Nerlige Ramappa, Umesh wrote: > The global sseu config is applicable only to gen11 platforms where > concurrent media, render and OA use cases may cause some subslices to be > turned off and hence lose NOA configuration. Return ENODEV for non-gen11 > platfo

Re: [Intel-gfx] [PATCH] i915/perf: Disable OA sseu config param for non-gen11 platforms

2022-07-07 Thread Umesh Nerlige Ramappa
On Thu, Jul 07, 2022 at 11:49:30AM -0700, Matt Roper wrote: On Thu, Jul 07, 2022 at 11:27:38AM -0700, Nerlige Ramappa, Umesh wrote: The global sseu config is applicable only to gen11 platforms where concurrent media, render and OA use cases may cause some subslices to be turned off and hence los

[Intel-gfx] [PATCH 2/2] i915/perf: Disable OA sseu config param for gfx12.50+

2022-07-07 Thread Nerlige Ramappa, Umesh
The global sseu config is applicable only to gen11 platforms where concurrent media, render and OA use cases may cause some subslices to be turned off and hence lose NOA configuration. Ideally we want to return ENODEV for non-gen11 platforms, however, this has shipped with gfx12, so disable only fo

[Intel-gfx] [PATCH 1/2] i915/perf: Replace DRM_DEBUG with driver specific drm_dbg call

2022-07-07 Thread Nerlige Ramappa, Umesh
DRM_DEBUG is not the right debug call to use in i915 OA, replace it with driver specific drm_dbg() call (Matt). Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_perf.c | 151 --- 1 file changed, 100 insertions(+), 51 deletions(-) diff --git a/driver

[Intel-gfx] [PATCH 1/2] i915/perf: Replace DRM_DEBUG with driver specific drm_dbg call

2022-07-07 Thread Nerlige Ramappa, Umesh
DRM_DEBUG is not the right debug call to use in i915 OA, replace it with driver specific drm_dbg() call (Matt). Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_perf.c | 151 --- 1 file changed, 100 insertions(+), 51 deletions(-) diff --git a/driver

[Intel-gfx] [PATCH 2/2] i915/perf: Disable OA sseu config param for gfx12.50+

2022-07-07 Thread Nerlige Ramappa, Umesh
The global sseu config is applicable only to gen11 platforms where concurrent media, render and OA use cases may cause some subslices to be turned off and hence lose NOA configuration. Ideally we want to return ENODEV for non-gen11 platforms, however, this has shipped with gfx12, so disable only fo

Re: [Intel-gfx] [RFC 06/10] drm/i915/vm_bind: Add I915_GEM_EXECBUFFER3 ioctl

2022-07-07 Thread Andi Shyti
Hi, > It seems we are duplicating a lot of code from i915_execbuffer.c. Did > you consider yeah... while reading the code I was thinking the same then I see that you made the same comment. Perhaps we need to group commonalities and make common library for execbuf 2 and 3. Andi

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] i915/perf: Replace DRM_DEBUG with driver specific drm_dbg call

2022-07-07 Thread Patchwork
== Series Details == Series: series starting with [1/2] i915/perf: Replace DRM_DEBUG with driver specific drm_dbg call URL : https://patchwork.freedesktop.org/series/106062/ State : warning == Summary == Error: dim checkpatch failed 937235fcf86e i915/perf: Replace DRM_DEBUG with driver specif

[Intel-gfx] [PATCH v10 00/11] drm/i915: ttm for stolen

2022-07-07 Thread Robert Beckett
This series refactors i915's stolen memory region to use ttm. v2: handle disabled stolen similar to legacy version. relying on ttm to fail allocs works fine, but is dmesg noisy and causes testing dmesg warning regressions. v3: rebase to latest drm-tip. fix v2 code

[Intel-gfx] [PATCH v10 01/11] drm/i915/ttm: dont trample cache_level overrides during ttm move

2022-07-07 Thread Robert Beckett
Various places within the driver override the default chosen cache_level. Before ttm, these overrides were permanent until explicitly changed again or for the lifetime of the buffer. TTM movement code came along and decided that it could make that decision at that time, which is usually well after

[Intel-gfx] [PATCH v10 07/11] drm/i915: ttm move/clear logic fix

2022-07-07 Thread Robert Beckett
ttm managed buffers start off with system resource definitions and ttm_tt tracking structures allocated (though unpopulated). currently this prevents clearing of buffers on first move to desired placements. The desired behaviour is to clear user allocated buffers and any kernel buffers that specif

[Intel-gfx] [PATCH v10 05/11] drm/i915: instantiate ttm ranger manager for stolen memory

2022-07-07 Thread Robert Beckett
prepare for ttm based stolen region by using ttm range manager as the resource manager for stolen region. Signed-off-by: Robert Beckett Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 6 ++-- drivers/gpu/drm/i915/intel_region_ttm.c | 31 +++

[Intel-gfx] [PATCH v10 04/11] drm/i915/gem: selftest should not attempt mmap of private regions

2022-07-07 Thread Robert Beckett
During testing make can_mmap consider whether the region is private. Signed-off-by: Robert Beckett Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/dr

[Intel-gfx] [PATCH v10 09/11] drm/i915/selftest: don't attempt engine reset of guc submission engines

2022-07-07 Thread Robert Beckett
igt_reset_engines_stolen tries to reset engines without checking if it is possible. Engines using GuC submission are not able to be reset from the host. In this scenario, the reset exits early, then on the next iteration of the each engine loop, the async teardown of the spinner request context's

[Intel-gfx] [PATCH v10 06/11] drm/i915: sanitize mem_flags for stolen buffers

2022-07-07 Thread Robert Beckett
Stolen regions are not page backed or considered iomem. Prevent flags indicating such. This correctly prevents stolen buffers from attempting to directly map them. See i915_gem_object_has_struct_page() and i915_gem_object_has_iomem() usage for where it would break otherwise. Signed-off-by: Robert

[Intel-gfx] [PATCH v10 10/11] drm/i915/selftest: wait for requests during engine reset selftest

2022-07-07 Thread Robert Beckett
While looping around each engine and testing for corrupted solen memory during engine reset, the old requests from the previous engine can still be yet to retire. To prevent false positive corruption tests, wait for the outstanding requests at the end of the test Signed-off-by: Robert Beckett ---

[Intel-gfx] [PATCH v10 03/11] drm/i915/ttm: only trust snooping for dgfx when deciding default cache_level

2022-07-07 Thread Robert Beckett
By default i915_ttm_cache_level() decides I915_CACHE_LLC if HAS_SNOOP. This is divergent from existing backends code which only considers HAS_LLC. Testing shows that trusting snooping on gen5- is unreliable and bsw via ggtt mappings, so limit DGFX for now and maintain previous behaviour. Signed-of

[Intel-gfx] [PATCH v10 08/11] drm/i915/ttm: add buffer pin on alloc flag

2022-07-07 Thread Robert Beckett
For situations where allocations need to fail on alloc instead of delayed get_pages, add a new alloc flag to pin the ttm bo. This makes sure that the resource has been allocated during buffer creation, allowing it to fail with an error if the placement is exhausted. This allows existing fallback op

[Intel-gfx] [PATCH v10 02/11] drm/i915: limit ttm to dma32 for i965G[M]

2022-07-07 Thread Robert Beckett
i965G[M] cannot relocate objects above 4GiB. Ensure ttm uses dma32 on these systems. Signed-off-by: Robert Beckett Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/intel_region_ttm.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_regio

[Intel-gfx] [PATCH v10 11/11] drm/i915: stolen memory use ttm backend

2022-07-07 Thread Robert Beckett
refactor stolen memory region to use ttm. this necessitates using ttm resources to track reserved stolen regions instead of drm_mm_nodes. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/display/intel_fbc.c | 78 ++-- .../gpu/drm/i915/gem/i915_gem_object_types.h | 2 - drivers/gpu

Re: [Intel-gfx] [PATCH] drm/i915/ttm: fix sg_table construction

2022-07-07 Thread kernel test robot
Hi Matthew, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip drm/drm-next drm-exynos/exynos-drm-next drm-misc/drm-misc-next linus/master v5.19-rc5 next-20220707] [If your patch is applied to the

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] i915/perf: Replace DRM_DEBUG with driver specific drm_dbg call

2022-07-07 Thread Patchwork
== Series Details == Series: series starting with [1/2] i915/perf: Replace DRM_DEBUG with driver specific drm_dbg call URL : https://patchwork.freedesktop.org/series/106062/ State : success == Summary == CI Bug Log - changes from CI_DRM_11857 -> Patchwork_106062v1

[Intel-gfx] [PATCH v2 0/2] i915: Introduce Meteorlake

2022-07-07 Thread Radhakrishna Sripada
Meteorlake is a new client platform following RPL S. Meteorlake introduces version 14 for Display, version 13 Media and version 12.70 for Graphics. This is the basic platform definition series to introduce Meteorlake. v2: Remove unused PCI'ids and rebase on drm-tip Radhakrishna Sripada (2): dr

[Intel-gfx] [PATCH v2 2/2] drm/i915/mtl: Add MeteorLake PCI IDs

2022-07-07 Thread Radhakrishna Sripada
Add Meteorlake PCI IDs. Split into M, and P subplatforms. v2: Update PCI id's Bspec: 55420 Signed-off-by: Radhakrishna Sripada Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_drv.h | 4 drivers/gpu/drm/i915/i915_pci.c | 1 + drivers/gpu/drm/i915/intel_device_i

[Intel-gfx] [PATCH v2 1/2] drm/i915/mtl: Add MeteorLake platform info

2022-07-07 Thread Radhakrishna Sripada
MTL has Xe_LPD+ display IP (version = 14), MTL graphics IP (version = 12.70), and Xe_LPM+ media IP (version = 13). Bspec: 55413 Bspec: 55416 Bspec: 55417 Bspec: 55418 Bspec: 55726 Bspec: 45544 Bspec: 65380 Cc: Matt Roper Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/i915_drv.h

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/mtl: Add MeteorLake PCI IDs

2022-07-07 Thread Matt Roper
On Thu, Jul 07, 2022 at 01:26:10PM -0700, Radhakrishna Sripada wrote: > Add Meteorlake PCI IDs. Split into M, and P subplatforms. > > v2: Update PCI id's > > Bspec: 55420 > > Signed-off-by: Radhakrishna Sripada > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/i915_drv.h | 4

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/mtl: Add MeteorLake platform info

2022-07-07 Thread Matt Roper
On Thu, Jul 07, 2022 at 01:26:09PM -0700, Radhakrishna Sripada wrote: > MTL has Xe_LPD+ display IP (version = 14), MTL graphics IP > (version = 12.70), and Xe_LPM+ media IP (version = 13). > > Bspec: 55413 > Bspec: 55416 > Bspec: 55417 > Bspec: 55418 > Bspec: 55726 > Bspec: 45544 > Bspec: 65380 >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: ttm for stolen (rev8)

2022-07-07 Thread Patchwork
== Series Details == Series: drm/i915: ttm for stolen (rev8) URL : https://patchwork.freedesktop.org/series/101396/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: ttm for stolen (rev8)

2022-07-07 Thread Patchwork
== Series Details == Series: drm/i915: ttm for stolen (rev8) URL : https://patchwork.freedesktop.org/series/101396/ State : success == Summary == CI Bug Log - changes from CI_DRM_11859 -> Patchwork_101396v8 Summary --- **WARNING**

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-07-07 Thread Andrzej Hajda
On 04.07.2022 10:09, Mauro Carvalho Chehab wrote: From: Chris Wilson Don't allow two engines to be reset in parallel, as they would both try to select a reset bit (and send requests to common registers) and wait on that register, at the same time. Serialize control of the reset requests/acks us

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/gt: Serialize TLB invalidates with GT resets

2022-07-07 Thread Andrzej Hajda
On 04.07.2022 10:09, Mauro Carvalho Chehab wrote: From: Chris Wilson Avoid trying to invalidate the TLB in the middle of performing an engine reset, as this may result in the reset timing out. Currently, the TLB invalidate is only serialised by its own mutex, forgoing the uncore lock, but we ca

Re: [Intel-gfx] [PATCH v3 1/2] vfio: Replace the DMA unmapping notifier with a callback

2022-07-07 Thread Alex Williamson
On Mon, 4 Jul 2022 21:59:03 -0300 Jason Gunthorpe wrote: > diff --git a/drivers/s390/cio/vfio_ccw_ops.c b/drivers/s390/cio/vfio_ccw_ops.c > index b49e2e9db2dc6f..09e0ce7b72324c 100644 > --- a/drivers/s390/cio/vfio_ccw_ops.c > +++ b/drivers/s390/cio/vfio_ccw_ops.c > @@ -44,31 +44,19 @@ static int

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gem: Look for waitboosting across the whole object prior to individual waits

2022-07-07 Thread Andi Shyti
Hi Rodrigo, Chris and Karolina, On Thu, Jul 07, 2022 at 01:57:52PM -0400, Rodrigo Vivi wrote: > On Tue, Jul 05, 2022 at 12:57:17PM +0200, Karolina Drobnik wrote: > > From: Chris Wilson > > > > We employ a "waitboost" heuristic to detect when userspace is stalled > > waiting for results from earl

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Bump GT idling delay to 2 jiffies

2022-07-07 Thread Andi Shyti
Hi, On Tue, Jul 05, 2022 at 12:57:18PM +0200, Karolina Drobnik wrote: > From: Chris Wilson > > In monitoring a transcode pipeline that is latency sensitive (it waits > between submitting frames, and each frame requires work on rcs/vcs/vecs > engines), it is found that it took longer than a singl

[Intel-gfx] [PATCH v3 1/2] drm/i915/mtl: Add MeteorLake platform info

2022-07-07 Thread Radhakrishna Sripada
MTL has Xe_LPD+ display IP (version = 14), MTL graphics IP (version = 12.70), and Xe_LPM+ media IP (version = 13). Bspec: 55413 Bspec: 55416 Bspec: 55417 Bspec: 55418 Bspec: 55726 Bspec: 45544 Bspec: 65380 v2: rearrange the fields in pci_info(MattR) Cc: Matt Roper Signed-off-by: Radhakrishna Sr

[Intel-gfx] [PATCH v3 2/2] drm/i915/mtl: Add MeteorLake PCI IDs

2022-07-07 Thread Radhakrishna Sripada
Add Meteorlake PCI IDs. Split into M, and P subplatforms. v2: Update PCI id's v3: Move id 7d60 under MTL_M(MattR) Bspec: 55420 Signed-off-by: Radhakrishna Sripada Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_drv.h | 4 drivers/gpu/drm/i915/i915_pci.c | 1 +

[Intel-gfx] [PATCH v3 0/2] i915: Introduce Meteorlake

2022-07-07 Thread Radhakrishna Sripada
Meteorlake is a new client platform following RPL S. Meteorlake introduces version 14 for Display, version 13 Media and version 12.70 for Graphics. This is the basic platform definition series to introduce Meteorlake. v2: Remove unused PCI'ids and rebase on drm-tip v3: Sort the pci info entries a

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/mtl: Add MeteorLake platform info

2022-07-07 Thread Matt Roper
On Thu, Jul 07, 2022 at 05:03:34PM -0700, Radhakrishna Sripada wrote: > MTL has Xe_LPD+ display IP (version = 14), MTL graphics IP > (version = 12.70), and Xe_LPM+ media IP (version = 13). > > Bspec: 55413 > Bspec: 55416 > Bspec: 55417 > Bspec: 55418 > Bspec: 55726 > Bspec: 45544 > Bspec: 65380 >

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/mtl: Add MeteorLake PCI IDs

2022-07-07 Thread Matt Roper
On Thu, Jul 07, 2022 at 05:03:35PM -0700, Radhakrishna Sripada wrote: > Add Meteorlake PCI IDs. Split into M, and P subplatforms. > > v2: Update PCI id's > v3: Move id 7d60 under MTL_M(MattR) > > Bspec: 55420 > > Signed-off-by: Radhakrishna Sripada > Signed-off-by: Matt Roper Since our hardwa

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915: Introduce Meteorlake

2022-07-07 Thread Patchwork
== Series Details == Series: i915: Introduce Meteorlake URL : https://patchwork.freedesktop.org/series/106075/ State : warning == Summary == Error: dim checkpatch failed 37acdff7a17b drm/i915/mtl: Add MeteorLake platform info 14c954fe2072 drm/i915/mtl: Add MeteorLake PCI IDs -:100: ERROR:COMPL

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915: Introduce Meteorlake

2022-07-07 Thread Patchwork
== Series Details == Series: i915: Introduce Meteorlake URL : https://patchwork.freedesktop.org/series/106075/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for i915: Introduce Meteorlake

2022-07-07 Thread Patchwork
== Series Details == Series: i915: Introduce Meteorlake URL : https://patchwork.freedesktop.org/series/106075/ State : success == Summary == CI Bug Log - changes from CI_DRM_11859 -> Patchwork_106075v1 Summary --- **SUCCESS** No r

Re: [Intel-gfx] [PATCH] drm/i915/hdmi: Prune modes that require HDMI2.1 FRL

2022-07-07 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Ankit > Nautiyal > Sent: Thursday, July 7, 2022 10:57 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH] drm/i915/hdmi: Prune modes that require > HDMI2.1 FRL > > HDMI2.1 requires some higher resolution video mode

Re: [Intel-gfx] [PATCH] drm/i915/ttm: fix sg_table construction

2022-07-07 Thread kernel test robot
Hi Matthew, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip drm/drm-next drm-exynos/exynos-drm-next drm-misc/drm-misc-next linus/master v5.19-rc5 next-20220707] [If your patch is applied to the

  1   2   >