Re: [Intel-gfx] [RFC PATCH v3 09/17] drm/i915: Do not support vm_bind mode in execbuf2

2022-08-30 Thread Niranjana Vishwanathapura
On Sat, Aug 27, 2022 at 09:43:55PM +0200, Andi Shyti wrote: From: Niranjana Vishwanathapura Do not support the vm in vm_bind_mode in execbuf2 ioctl. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Ramalingam C Signed-off-by: Andi Shyti ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/edid: Range descriptor stuff (rev2)

2022-08-30 Thread Patchwork
== Series Details == Series: drm/edid: Range descriptor stuff (rev2) URL : https://patchwork.freedesktop.org/series/107824/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12041_full -> Patchwork_107824v2_full Summary

Re: [Intel-gfx] [PATCH] drm/i915/slpc: Let's fix the PCODE min freq table setup for SLPC

2022-08-30 Thread Dixit, Ashutosh
On Tue, 30 Aug 2022 12:16:20 -0700, Rodrigo Vivi wrote: > Hi Rodrigo, > @@ -65,13 +63,8 @@ static bool get_ia_constants(struct intel_llc *llc, > /* convert DDR frequency from units of 266.6MHz to bandwidth */ > consts->min_ring_freq = mult_frac(consts->min_ring_freq, 8, 3); > > -

Re: [Intel-gfx] [PATCH 5/8] drm/i915: Rename and expose common GT early init routine

2022-08-30 Thread Sripada, Radhakrishna
> -Original Message- > From: Roper, Matthew D > Sent: Monday, August 29, 2022 10:03 AM > To: intel-gfx@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org; Sripada, Radhakrishna > ; Roper, Matthew D > > Subject: [PATCH 5/8] drm/i915: Rename and expose common GT early init >

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Prepare more multi-GT initialization

2022-08-30 Thread Sripada, Radhakrishna
> -Original Message- > From: Roper, Matthew D > Sent: Monday, August 29, 2022 10:03 AM > To: intel-gfx@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org; Sripada, Radhakrishna > ; Roper, Matthew D > ; Iddamsetty, Aravind > > Subject: [PATCH 4/8] drm/i915: Prepare more

Re: [Intel-gfx] [PATCH 3/8] drm/i915: Use managed allocations for extra uncore objects

2022-08-30 Thread Sripada, Radhakrishna
> -Original Message- > From: Roper, Matthew D > Sent: Monday, August 29, 2022 10:03 AM > To: intel-gfx@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org; Sripada, Radhakrishna > ; Roper, Matthew D > > Subject: [PATCH 3/8] drm/i915: Use managed allocations for extra uncore >

Re: [Intel-gfx] [PATCH 2/8] drm/i915: Only hook up uncore->debug for primary uncore

2022-08-30 Thread Sripada, Radhakrishna
Hi Matt, > -Original Message- > From: Roper, Matthew D > Sent: Monday, August 29, 2022 10:03 AM > To: intel-gfx@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org; Sripada, Radhakrishna > ; Roper, Matthew D > > Subject: [PATCH 2/8] drm/i915: Only hook up uncore->debug for

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Move locking and unclaimed check into mmio_debug_{suspend, resume}

2022-08-30 Thread Sripada, Radhakrishna
> -Original Message- > From: Roper, Matthew D > Sent: Monday, August 29, 2022 10:03 AM > To: intel-gfx@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org; Sripada, Radhakrishna > ; Roper, Matthew D > > Subject: [PATCH 1/8] drm/i915: Move locking and unclaimed check into >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Allow more varied alternate fixed modes for panels

2022-08-30 Thread Patchwork
== Series Details == Series: drm/i915: Allow more varied alternate fixed modes for panels URL : https://patchwork.freedesktop.org/series/107953/ State : success == Summary == CI Bug Log - changes from CI_DRM_12051 -> Patchwork_107953v1

Re: [Intel-gfx] [PATCH 15/15] vfio: Add struct device to vfio_device

2022-08-30 Thread Alex Williamson
On Sun, 28 Aug 2022 01:10:37 +0800 Kevin Tian wrote: > From: Yi Liu > > and replace kref. With it a 'vfio-dev/vfioX' node is created under the > sysfs path of the parent, indicating the device is bound to a vfio > driver, e.g.: > > /sys/devices/pci\:6f/\:6f\:01.0/vfio-dev/vfio0 > >

[Intel-gfx] [PATCH] drm/i915: Allow more varied alternate fixed modes for panels

2022-08-30 Thread Ville Syrjala
From: Ville Syrjälä On some systems the panel reports alternate modes with different blanking periods. If the EDID reports them and VBT doesn't tell us otherwise then I can't really see why they should be rejected. So allow their use for the purposes of static DRRS. For seamless DRRS we still

Re: [Intel-gfx] [PATCH] drm/i915/slpc: Fix inconsistent locked return

2022-08-30 Thread Dixit, Ashutosh
On Tue, 30 Aug 2022 12:35:37 -0700, Rodrigo Vivi wrote: > > Fix for intel_guc_slpc_set_min_freq() warn: > inconsistent returns '>lock'. > > v2: Avoid with_intel_runtime_pm with the > internal goto/return. (Ashutosh) > Also standardize the 'ret' if this came from > the efficient setup.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/slpc: Fix inconsistent locked return (rev2)

2022-08-30 Thread Patchwork
== Series Details == Series: drm/i915/slpc: Fix inconsistent locked return (rev2) URL : https://patchwork.freedesktop.org/series/107938/ State : success == Summary == CI Bug Log - changes from CI_DRM_12051 -> Patchwork_107938v2 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/slpc: Set rps' min and max frequencies even with SLPC. (rev6)

2022-08-30 Thread Patchwork
== Series Details == Series: drm/i915/slpc: Set rps' min and max frequencies even with SLPC. (rev6) URL : https://patchwork.freedesktop.org/series/107766/ State : success == Summary == CI Bug Log - changes from CI_DRM_12050 -> Patchwork_107766v6

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for Revert "drm/i915/dg2: Add preemption changes for Wa_14015141709"

2022-08-30 Thread Matt Roper
On Tue, Aug 30, 2022 at 05:48:14PM +, Patchwork wrote: > == Series Details == > > Series: Revert "drm/i915/dg2: Add preemption changes for Wa_14015141709" > URL : https://patchwork.freedesktop.org/series/107818/ > State : success > > == Summary == > > CI Bug Log - changes from

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/ats-m: Add thread execution tuning setting

2022-08-30 Thread Matt Roper
On Tue, Aug 30, 2022 at 05:55:35PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/ats-m: Add thread execution tuning setting > URL : https://patchwork.freedesktop.org/series/107822/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_12035_full ->

[Intel-gfx] [PATCH] drm/i915/slpc: Fix inconsistent locked return

2022-08-30 Thread Rodrigo Vivi
Fix for intel_guc_slpc_set_min_freq() warn: inconsistent returns '>lock'. v2: Avoid with_intel_runtime_pm with the internal goto/return. (Ashutosh) Also standardize the 'ret' if this came from the efficient setup. And avoid the 'unlikely'. Fixes: 95ccf312a1e4 ("drm/i915/guc/slpc:

[Intel-gfx] [PATCH] drm/i915/slpc: Let's fix the PCODE min freq table setup for SLPC

2022-08-30 Thread Rodrigo Vivi
We need to inform PCODE of a desired ring frequencies so PCODE update the memory frequencies to us. rps->min_freq and rps->max_freq are the frequencies used in that request. However they were unset when SLPC was enabled and PCODE never updated the memory freq. v2 (as Suggested by Ashutosh): if

[Intel-gfx] ✗ Fi.CI.IGT: failure for Tidy up vfio_device life cycle

2022-08-30 Thread Patchwork
== Series Details == Series: Tidy up vfio_device life cycle URL : https://patchwork.freedesktop.org/series/107838/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12035_full -> Patchwork_107838v1_full Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for Drop version numbers from firmware files (rev4)

2022-08-30 Thread Patchwork
== Series Details == Series: Drop version numbers from firmware files (rev4) URL : https://patchwork.freedesktop.org/series/107340/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12035_full -> Patchwork_107340v4_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: Cancel GuC engine busyness worker synchronously (rev3)

2022-08-30 Thread Patchwork
== Series Details == Series: drm/i915/guc: Cancel GuC engine busyness worker synchronously (rev3) URL : https://patchwork.freedesktop.org/series/106738/ State : success == Summary == CI Bug Log - changes from CI_DRM_12035_full -> Patchwork_106738v3_full

Re: [Intel-gfx] [RFC PATCH v3 04/17] drm/i915: Implement bind and unbind of object

2022-08-30 Thread Matthew Auld
On 27/08/2022 20:43, Andi Shyti wrote: From: Niranjana Vishwanathapura Implement the bind and unbind of an object at the specified GPU virtual addresses. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Prathap Kumar Valsan Signed-off-by: Ramalingam C Signed-off-by: Andi Shyti ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/edid: Range descriptor stuff

2022-08-30 Thread Patchwork
== Series Details == Series: drm/edid: Range descriptor stuff URL : https://patchwork.freedesktop.org/series/107824/ State : success == Summary == CI Bug Log - changes from CI_DRM_12035_full -> Patchwork_107824v1_full Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/ats-m: Add thread execution tuning setting

2022-08-30 Thread Patchwork
== Series Details == Series: drm/i915/ats-m: Add thread execution tuning setting URL : https://patchwork.freedesktop.org/series/107822/ State : success == Summary == CI Bug Log - changes from CI_DRM_12035_full -> Patchwork_107822v1_full

[Intel-gfx] ✓ Fi.CI.IGT: success for Revert "drm/i915/dg2: Add preemption changes for Wa_14015141709"

2022-08-30 Thread Patchwork
== Series Details == Series: Revert "drm/i915/dg2: Add preemption changes for Wa_14015141709" URL : https://patchwork.freedesktop.org/series/107818/ State : success == Summary == CI Bug Log - changes from CI_DRM_12035_full -> Patchwork_107818v1_full

Re: [Intel-gfx] [RFC PATCH v3 04/17] drm/i915: Implement bind and unbind of object

2022-08-30 Thread Matthew Auld
On 27/08/2022 20:43, Andi Shyti wrote: From: Niranjana Vishwanathapura Implement the bind and unbind of an object at the specified GPU virtual addresses. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Prathap Kumar Valsan Signed-off-by: Ramalingam C Signed-off-by: Andi Shyti ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Fix warning callstack for imbalance wakeref (rev7)

2022-08-30 Thread Patchwork
== Series Details == Series: drm/i915/display: Fix warning callstack for imbalance wakeref (rev7) URL : https://patchwork.freedesktop.org/series/107211/ State : success == Summary == CI Bug Log - changes from CI_DRM_12050 -> Patchwork_107211v7

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: stop HPD workers before display driver unregister (rev15)

2022-08-30 Thread Patchwork
== Series Details == Series: drm/i915/display: stop HPD workers before display driver unregister (rev15) URL : https://patchwork.freedesktop.org/series/105557/ State : success == Summary == CI Bug Log - changes from CI_DRM_12034_full -> Patchwork_105557v15_full

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/mtl: Added restriction for plane downscaling

2022-08-30 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/mtl: Added restriction for plane downscaling URL : https://patchwork.freedesktop.org/series/107800/ State : success == Summary == CI Bug Log - changes from CI_DRM_12034_full -> Patchwork_107800v1_full

Re: [Intel-gfx] drm/i915/display: Fix warning callstack for imbalance wakeref

2022-08-30 Thread Golani, Mitulkumar Ajitkumar
> > drivers/gpu/drm/i915/i915_driver.c | 16 > > 1 file changed, 12 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_driver.c > > b/drivers/gpu/drm/i915/i915_driver.c > > index 1332c70370a6..281bf6cd5e4c 100644 > > ---

[Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref

2022-08-30 Thread Mitul Golani
While executing i915_selftest, wakeref imbalance warning is seen with i915_selftest failure. Currently when Driver is suspended, while doing unregister it is taking wakeref without resuming the device. This patch is resuming the device, if driver is already suspended and doing unregister process.

Re: [Intel-gfx] [PATCH] drm/i915/slpc: Fix PCODE IA Freq requests when using SLPC

2022-08-30 Thread Dixit, Ashutosh
On Fri, 26 Aug 2022 13:03:05 -0700, Dixit, Ashutosh wrote: > > On Fri, 26 Aug 2022 10:44:34 -0700, Rodrigo Vivi wrote: > > > > Fixes: 7ba79a671568 ("drm/i915/guc/slpc: Gate Host RPS when SLPC is > > enabled") > > Cc: # v5.15+ > > Cc: Ashutosh Dixit > > Tested-by: Sushma Venkatesh Reddy > >

Re: [Intel-gfx] drm/i915/display: Fix warning callstack for imbalance wakeref

2022-08-30 Thread Imre Deak
On Mon, 29 Aug 2022 14:01:24 +0530, Mitul Golani wrote: > While executing i915_selftest, wakeref imbalance warning is seen > with i915_selftest failure. > > Currently when Driver is suspended, while doing unregister > it is taking wakeref without resuming the device. > This patch is resuming the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/slpc: Fix inconsistent locked return

2022-08-30 Thread Patchwork
== Series Details == Series: drm/i915/slpc: Fix inconsistent locked return URL : https://patchwork.freedesktop.org/series/107938/ State : success == Summary == CI Bug Log - changes from CI_DRM_12049 -> Patchwork_107938v1 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/slpc: Fix inconsistent locked return

2022-08-30 Thread Dixit, Ashutosh
On Tue, 30 Aug 2022 08:02:29 -0700, Rodrigo Vivi wrote: > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c > b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c > index 9d49ccef03bb..f8a2bbcdf14f 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c > +++

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/slpc: Fix inconsistent locked return

2022-08-30 Thread Patchwork
== Series Details == Series: drm/i915/slpc: Fix inconsistent locked return URL : https://patchwork.freedesktop.org/series/107938/ State : warning == Summary == Error: dim checkpatch failed 06ec684fe41a drm/i915/slpc: Fix inconsistent locked return -:6: WARNING:COMMIT_LOG_LONG_LINE: Possible

[Intel-gfx] [PATCH] drm/i915/slpc: Fix inconsistent locked return

2022-08-30 Thread Rodrigo Vivi
Fix for intel_guc_slpc_set_min_freq() warn: inconsistent returns '>lock'. Fixes: 95ccf312a1e4 ("drm/i915/guc/slpc: Allow SLPC to use efficient frequency") Reported-by: kernel test robot Reported-by: Dan Carpenter Cc: Ashutosh Dixit Signed-off-by: Rodrigo Vivi ---

Re: [Intel-gfx] [PATCH] drm/i915: Fix random -ENOSPC eviction errors due to locked vma objects

2022-08-30 Thread Tvrtko Ursulin
On 17/08/2022 08:34, Thomas Hellström wrote: On Wed, 2022-08-17 at 09:55 +0300, Sviatoslav Peleshko wrote: The i915_gem_object_trylock we had in the grab_vma() makes it return false when the vma->obj is already locked. In this case we'll skip this vma during eviction, and eventually might be

[Intel-gfx] [drm-intel:for-linux-next-gt 1/1] drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c:497 intel_guc_slpc_set_min_freq() warn: inconsistent returns '>lock'.

2022-08-30 Thread Dan Carpenter
-ci/archive/20220830/202208301957.ulaot2oy-...@intel.com/config) compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot Reported-by: Dan Carpenter New smatch warnings: drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c:497

Re: [Intel-gfx] [PATCH] drm/i915/guc: clear stalled request after a reset

2022-08-30 Thread Tvrtko Ursulin
On 12/08/2022 16:31, Ceraolo Spurio, Daniele wrote: On 8/12/2022 12:29 AM, Tvrtko Ursulin wrote: On 11/08/2022 22:08, Daniele Ceraolo Spurio wrote: If the GuC CTs are full and we need to stall the request submission while waiting for space, we save the stalled request and where the stall

Re: [Intel-gfx] [PATCH 1/1] drm/i915/dgfx: Release mmap on rpm suspend

2022-08-30 Thread Matthew Auld
On Tue, 30 Aug 2022 at 14:39, Matthew Auld wrote: > > On Mon, 29 Aug 2022 at 12:15, Gupta, Anshuman > wrote: > > > > > > > > > -Original Message- > > > From: Auld, Matthew > > Thanks Matt for reviewing this. > > > Sent: Friday, August 26, 2022 11:09 PM > > > To: Gupta, Anshuman ;

Re: [Intel-gfx] [PATCH 1/1] drm/i915/dgfx: Release mmap on rpm suspend

2022-08-30 Thread Matthew Auld
On Mon, 29 Aug 2022 at 12:15, Gupta, Anshuman wrote: > > > > > -Original Message- > > From: Auld, Matthew > Thanks Matt for reviewing this. > > Sent: Friday, August 26, 2022 11:09 PM > > To: Gupta, Anshuman ; intel- > > g...@lists.freedesktop.org > > Cc: joonas.lahti...@linux.intel.com;

Re: [Intel-gfx] [PATCH v2 14/41] drm/modes: Move named modes parsing to a separate function

2022-08-30 Thread Jani Nikula
On Tue, 30 Aug 2022, Maxime Ripard wrote: > Hi, > > On Tue, Aug 30, 2022 at 01:43:07PM +0300, Jani Nikula wrote: >> On Tue, 30 Aug 2022, Geert Uytterhoeven wrote: >> > On Mon, Aug 29, 2022 at 3:13 PM Maxime Ripard wrote: >> >> +#define STR_STRICT_EQ(str, len, cmp) \ >> >> + ((strlen(cmp)

Re: [Intel-gfx] [PATCH 0/6] drm/i915/gmbus: stop using implicit dev_priv

2022-08-30 Thread Jani Nikula
On Tue, 30 Aug 2022, Ville Syrjälä wrote: > On Tue, Aug 30, 2022 at 01:27:56PM +0300, Jani Nikula wrote: >> The register macros are the last holdout for implicit dev_priv local >> variable. Try out what it would mean to stop using it, and require >> passing i915 as parameter to the register

Re: [Intel-gfx] [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes

2022-08-30 Thread Maíra Canal
Hi Maxime, On 8/29/22 10:11, Maxime Ripard wrote: > Multiple drivers (meson, vc4, sun4i) define analog TV 525-lines and > 625-lines modes in their drivers. > > Since those modes are fairly standard, and that we'll need to use them > in more places in the future, it makes sense to move their

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/slpc: Set rps' min and max frequencies even with SLPC. (rev4)

2022-08-30 Thread Patchwork
== Series Details == Series: drm/i915/slpc: Set rps' min and max frequencies even with SLPC. (rev4) URL : https://patchwork.freedesktop.org/series/107766/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12031_full -> Patchwork_107766v4_full

Re: [Intel-gfx] [PATCH] drm/i915/selftests: allow misaligned_pin test work with unmappable memory

2022-08-30 Thread Matthew Auld
On 25/08/2022 16:46, Matthew Auld wrote: On 25/08/2022 16:42, Andrzej Hajda wrote: In case of Small BAR configurations stolen local memory can be unmappable. Since the test does not touch the memory, passing I915_BO_ALLOC_GPU_ONLY flag to i915_gem_object_create_region, will prevent -ENOSPC

Re: [Intel-gfx] [PATCH v2 19/41] drm/modes: Introduce the tv_mode property as a command-line option

2022-08-30 Thread Maíra Canal
On 8/29/22 10:11, Maxime Ripard wrote: > Our new tv mode option allows to specify the TV mode from a property. > However, it can still be useful, for example to avoid any boot time > artifact, to set that property directly from the kernel command line. > > Let's add some code to allow it, and

Re: [Intel-gfx] [PATCH v2 19/41] drm/modes: Introduce the tv_mode property as a command-line option

2022-08-30 Thread Maíra Canal
Hi Maxime, On 8/29/22 10:11, Maxime Ripard wrote: > Our new tv mode option allows to specify the TV mode from a property. > However, it can still be useful, for example to avoid any boot time > artifact, to set that property directly from the kernel command line. > > Let's add some code to allow

Re: [Intel-gfx] [PATCH 0/6] drm/i915/gmbus: stop using implicit dev_priv

2022-08-30 Thread Ville Syrjälä
On Tue, Aug 30, 2022 at 01:27:56PM +0300, Jani Nikula wrote: > The register macros are the last holdout for implicit dev_priv local > variable. Try out what it would mean to stop using it, and require > passing i915 as parameter to the register macros. Use gmbus as a nicely > isolated playing

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Extract drm_dp_atomic_find_vcpi_slots cycle to separate function

2022-08-30 Thread Lisovskiy, Stanislav
On Mon, Aug 29, 2022 at 05:43:19PM +0300, Govindapillai, Vinod wrote: > Hi Stan, > > I wonder if it is better if you reorder the 3 and 4 patches in this - move > this 4/4 before the 3rd > one and modify the 3rd one accordingly. Was thiking about that, but decided to first introduce a new

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Remove log size module parameters (rev2)

2022-08-30 Thread Patchwork
== Series Details == Series: drm/i915/guc: Remove log size module parameters (rev2) URL : https://patchwork.freedesktop.org/series/107780/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12031_full -> Patchwork_107780v2_full

Re: [Intel-gfx] [PATCH v2 14/41] drm/modes: Move named modes parsing to a separate function

2022-08-30 Thread Maxime Ripard
Hi, On Tue, Aug 30, 2022 at 01:43:07PM +0300, Jani Nikula wrote: > On Tue, 30 Aug 2022, Geert Uytterhoeven wrote: > > On Mon, Aug 29, 2022 at 3:13 PM Maxime Ripard wrote: > >> +#define STR_STRICT_EQ(str, len, cmp) \ > >> + ((strlen(cmp) == len) && !strncmp(str, cmp, len)) > > > > This is

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: some BUG_ON() removals

2022-08-30 Thread Patchwork
== Series Details == Series: drm/i915: some BUG_ON() removals URL : https://patchwork.freedesktop.org/series/107785/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12031_full -> Patchwork_107785v1_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gmbus: stop using implicit dev_priv

2022-08-30 Thread Patchwork
== Series Details == Series: drm/i915/gmbus: stop using implicit dev_priv URL : https://patchwork.freedesktop.org/series/107930/ State : success == Summary == CI Bug Log - changes from CI_DRM_12048 -> Patchwork_107930v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gmbus: stop using implicit dev_priv

2022-08-30 Thread Patchwork
== Series Details == Series: drm/i915/gmbus: stop using implicit dev_priv URL : https://patchwork.freedesktop.org/series/107930/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gmbus: stop using implicit dev_priv

2022-08-30 Thread Patchwork
== Series Details == Series: drm/i915/gmbus: stop using implicit dev_priv URL : https://patchwork.freedesktop.org/series/107930/ State : warning == Summary == Error: dim checkpatch failed 3c07702148f6 drm/i915/gmbus: split out gmbus regs in a separate file Traceback (most recent call last):

Re: [Intel-gfx] [PATCH 1/3] drm/i915: audit bo->resource usage

2022-08-30 Thread Matthew Auld
Hi, On 30/08/2022 08:33, Christian König wrote: Hi guys, can we get an rb/acked-by for this i915 change? Basically we are just making sure that the driver doesn't crash when bo->resource is NULL and a bo doesn't have any backing store assigned to it. The Intel CI seems to be happy with

Re: [Intel-gfx] [PATCH v2 14/41] drm/modes: Move named modes parsing to a separate function

2022-08-30 Thread Jani Nikula
On Tue, 30 Aug 2022, Geert Uytterhoeven wrote: > On Mon, Aug 29, 2022 at 3:13 PM Maxime Ripard wrote: >> +#define STR_STRICT_EQ(str, len, cmp) \ >> + ((strlen(cmp) == len) && !strncmp(str, cmp, len)) > > This is not part of the move, but newly added. The same construct is also duplicated

[Intel-gfx] [PATCH 2/6] drm/i915/gmbus: whitespace cleanup in reg definitions

2022-08-30 Thread Jani Nikula
Simple whitespace cleanup and comment movement. Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/intel_gmbus_regs.h | 117 ++ 1 file changed, 63 insertions(+), 54 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_gmbus_regs.h

[Intel-gfx] [PATCH 6/6] drm/i915/gmbus: mass dev_priv -> i915 rename

2022-08-30 Thread Jani Nikula
Now that gmbus no longer uses macros that assume dev_priv is implicitly available, mass rename dev_priv to i915 in gmbus code. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_gmbus.c | 268 ++--- 1 file changed, 134 insertions(+), 134 deletions(-) diff --git

[Intel-gfx] [PATCH 5/6] drm/i915/reg: stop using implicit dev_priv in DSPCLK_GATE_D

2022-08-30 Thread Jani Nikula
Remove the implicit dev_priv usage in DSPCLK_GATE_D register, and pass it as parameter. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_power_well.c | 4 ++-- drivers/gpu/drm/i915/display/intel_gmbus.c | 4 ++-- drivers/gpu/drm/i915/display/intel_overlay.c

[Intel-gfx] [PATCH 3/6] drm/i915/gmbus: add wrapper for gmbus mmio base

2022-08-30 Thread Jani Nikula
Don't repeat the same thing so much. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_gmbus_regs.h | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_gmbus_regs.h

[Intel-gfx] [PATCH 4/6] drm/i915/gmbus: stop using implicit dev_priv in register definitions

2022-08-30 Thread Jani Nikula
Since the beginning of time, we've implicitly assumed dev_priv is present as a local variable in many places. We've gone a long way in removing many of them, but the register macro definitions are the last holdout. Remove them from the gmbus macros. Signed-off-by: Jani Nikula ---

[Intel-gfx] [PATCH 1/6] drm/i915/gmbus: split out gmbus regs in a separate file

2022-08-30 Thread Jani Nikula
Declutter i915_reg.h, and also observe very few places need the gmbus register defitions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_gmbus.c| 1 + .../gpu/drm/i915/display/intel_gmbus_regs.h | 71 +++ drivers/gpu/drm/i915/gvt/edid.c |

[Intel-gfx] [PATCH 0/6] drm/i915/gmbus: stop using implicit dev_priv

2022-08-30 Thread Jani Nikula
The register macros are the last holdout for implicit dev_priv local variable. Try out what it would mean to stop using it, and require passing i915 as parameter to the register macros. Use gmbus as a nicely isolated playing ground. Jani Nikula (6): drm/i915/gmbus: split out gmbus regs in a

Re: [Intel-gfx] [PATCH v2 14/41] drm/modes: Move named modes parsing to a separate function

2022-08-30 Thread Geert Uytterhoeven
Hi Maxime, On Mon, Aug 29, 2022 at 3:13 PM Maxime Ripard wrote: > The current construction of the named mode parsing doesn't allow to extend > it easily. Let's move it to a separate function so we can add more > parameters and modes. > > Signed-off-by: Maxime Ripard Thanks for your patch! >

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/5] drm/i915/crt: remove BUG_ON()

2022-08-30 Thread Patchwork
== Series Details == Series: series starting with [v2,1/5] drm/i915/crt: remove BUG_ON() URL : https://patchwork.freedesktop.org/series/107929/ State : success == Summary == CI Bug Log - changes from CI_DRM_12048 -> Patchwork_107929v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/5] drm/i915/crt: remove BUG_ON()

2022-08-30 Thread Patchwork
== Series Details == Series: series starting with [v2,1/5] drm/i915/crt: remove BUG_ON() URL : https://patchwork.freedesktop.org/series/107929/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH v2 3/5] drm/i915/pch: replace BUG_ON() with drm_WARN_ON()

2022-08-30 Thread Jani Nikula
Avoid BUG_ON(). Replace with drm_WARN_ON(). Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_pch_refclk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_pch_refclk.c

[Intel-gfx] [PATCH v2 4/5] drm/i915/perf: replace BUG_ON() with WARN_ON()

2022-08-30 Thread Jani Nikula
Avoid BUG_ON(). Replace with WARN_ON() and early return. Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_perf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c index

[Intel-gfx] [PATCH v2 5/5] drm/i915/fence: replace BUG_ON() with BUILD_BUG_ON()

2022-08-30 Thread Jani Nikula
Avoid BUG_ON(). Since __i915_sw_fence_init() is always called via a wrapper macro, we can replace it with a compile time BUILD_BUG_ON(). Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_sw_fence.c | 2 -- drivers/gpu/drm/i915/i915_sw_fence.h | 6 +- 2

[Intel-gfx] [PATCH v2 1/5] drm/i915/crt: remove BUG_ON()

2022-08-30 Thread Jani Nikula
Avoid BUG_ON(). We don't have such checks on output type anywhere else either, so just remove. Suggested-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_crt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_crt.c

[Intel-gfx] [PATCH v2 2/5] drm/i915/dpll: replace BUG_ON() with drm_WARN_ON()

2022-08-30 Thread Jani Nikula
Avoid BUG_ON(). Actually check the dpll count and bail out loudly with drm_WARN_ON() from the loop before overflowing i915->dpll.shared_dplls[]. v2: Rebase Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 6 -- 1 file changed, 4

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Fix spelling mistake "heatbeat" -> "heartbeat"

2022-08-30 Thread Patchwork
== Series Details == Series: drm/i915/guc: Fix spelling mistake "heatbeat" -> "heartbeat" URL : https://patchwork.freedesktop.org/series/107784/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12030_full -> Patchwork_107784v1_full

Re: [Intel-gfx] [PATCH] drm/i915/bios: Copy the whole MIPI sequence block

2022-08-30 Thread Ville Syrjälä
On Tue, Aug 30, 2022 at 11:27:27AM +0300, Jani Nikula wrote: > On Mon, 29 Aug 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Turns out the MIPI sequence block version number and > > new block size fields are considered part of the block > > header and are not included in the reported

Re: [Intel-gfx] [PATCH v2 01/41] drm/tests: Order Kunit tests in Makefile

2022-08-30 Thread Maxime Ripard
Hi Konstantin, On Mon, Aug 29, 2022 at 03:02:42PM -0400, Konstantin Ryabitsev wrote: > On Mon, Aug 29, 2022 at 08:46:42PM +0200, Noralf Trønnes wrote: > > Something has gone wrong with this patchset, there are double line endings. > > I noticed this, too, and I think the reason is because these

Re: [Intel-gfx] [PATCH] drm/i915/bios: Copy the whole MIPI sequence block

2022-08-30 Thread Jani Nikula
On Mon, 29 Aug 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Turns out the MIPI sequence block version number and > new block size fields are considered part of the block > header and are not included in the reported new block size > field itself. Bump up the block size appropriately so

Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers

2022-08-30 Thread Ville Syrjälä
On Tue, Aug 30, 2022 at 07:57:15AM +, Murthy, Arun R wrote: > > > > > > > Intel Gen do support Async Flip is supported on linear buffers. > > > > > > > Since we didn't had a use case, it was not enabled. Now that > > > > > > > as part of hybrid graphics for unsupported hardware pixel > > > > >

Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers

2022-08-30 Thread Murthy, Arun R
> > > > > > Intel Gen do support Async Flip is supported on linear buffers. > > > > > > Since we didn't had a use case, it was not enabled. Now that > > > > > > as part of hybrid graphics for unsupported hardware pixel > > > > > > formats, its being converted to linear memory and then flipped, >

Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers

2022-08-30 Thread Ville Syrjälä
On Tue, Aug 30, 2022 at 06:15:44AM +, Murthy, Arun R wrote: > > -Original Message- > > From: Ville Syrjälä > > Sent: Wednesday, August 24, 2022 5:48 PM > > To: Murthy, Arun R > > Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma > > Subject: Re: [PATCHv3] drm/i915: Support Async

[Intel-gfx] ✓ Fi.CI.IGT: success for Drop version numbers from firmware files (rev3)

2022-08-30 Thread Patchwork
== Series Details == Series: Drop version numbers from firmware files (rev3) URL : https://patchwork.freedesktop.org/series/107340/ State : success == Summary == CI Bug Log - changes from CI_DRM_12029_full -> Patchwork_107340v3_full

Re: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers

2022-08-30 Thread Murthy, Arun R
> -Original Message- > From: Ville Syrjälä > Sent: Wednesday, August 24, 2022 5:48 PM > To: Murthy, Arun R > Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma > Subject: Re: [PATCHv3] drm/i915: Support Async Flip on Linear buffers > > On Wed, Aug 24, 2022 at 03:02:33AM +, Murthy,