Re: [Intel-gfx] [PATCH 2/6] drm/i915/display: add cdclk action struct to cdclk_config

On Mon, 19 Sep 2022, "Srivatsa, Anusha" wrote: >> -Original Message- >> From: Navare, Manasi D >> Sent: Monday, September 19, 2022 12:33 PM >> To: Jani Nikula >> Cc: Srivatsa, Anusha ; intel- >> g...@lists.freedesktop.org >> Subject: Re: [Intel-gfx] [PATCH 2/6] drm/i915/display: add cdcl

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Move hotplug inversion logic into separate helper

== Series Details == Series: drm/i915: Move hotplug inversion logic into separate helper URL : https://patchwork.freedesktop.org/series/108742/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12158_full -> Patchwork_108742v1_full =

[Intel-gfx] [PATCH v4] drm/edid: ignore the CEA modes not defined in CEA-861-D

This is a workaround for HDMI 1.4 sink which has a CEA mode with higher vic than what is defined in CEA-861-D. As an example, a HDMI 1.4 sink has the video format 2560x1080p to be displayed and the video format is indicated by both SVD (with vic 90 and picture aspect ratio 64:27) and DTD. When co

Re: [Intel-gfx] [PATCH 1/1] drm/i915/guc: Delay disabling guc_id scheduling for better hysteresis

On Fri, 2022-09-16 at 08:36 -0700, Ceraolo Spurio, Daniele wrote: > > On 9/16/2022 1:58 AM, Tvrtko Ursulin wrote: > > On 16/09/2022 08:53, Teres Alexis, Alan Previn wrote: > > > On Thu, 2022-09-15 at 09:48 +0100, Tvrtko Ursulin wrote: > > > > On 15/09/2022 03:12, Alan Previn wrote: > > > > > From

[Intel-gfx] ✓ Fi.CI.IGT: success for Remove unused declarations for gpu/drm

== Series Details == Series: Remove unused declarations for gpu/drm URL : https://patchwork.freedesktop.org/series/108731/ State : success == Summary == CI Bug Log - changes from CI_DRM_12158_full -> Patchwork_108731v1_full Summary ---

Re: [Intel-gfx] [PATCH v6 0/4] Let userspace know when snd-hda-intel needs i915

Hi Luis, On Mon, 9 May 2022 13:38:28 -0700 Luis Chamberlain wrote: > On Mon, May 09, 2022 at 06:23:35PM +0200, Mauro Carvalho Chehab wrote: > > Currently, kernel/module annotates module dependencies when > > request_symbol is used, but it doesn't cover more complex inter-driver > > dependencies

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 3/4] tests/core_hotunplug: Don't apply i915 workarounds on other platforms

On Tue, 13 Sep 2022 14:04:40 +0200 Janusz Krzysztofik wrote: > Starting from commit 0edabd8a4a08 ("core_hotunplug: fix audio unbind > logic") audio modules are unloaded unconditionally before graphics driver > unbind. This is required for i915 to be unbound cleanly from a graphics > device. How

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 4/4] tests/core_hotunplug: Select health checks for initially detected chipset

On Tue, 13 Sep 2022 14:04:41 +0200 Janusz Krzysztofik wrote: > As soon as we first time open a drm device to be exercised, we identify > its chipset, store that information, and perform some basic device > specific checks. We also store a filter that matches the device bus > address to make sure

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/4] tests/core_hotunplug: Also unload audio before device unplug

On Tue, 13 Sep 2022 14:04:39 +0200 Janusz Krzysztofik wrote: > Starting from commit e9c69e02b2f7 ("tests/core_hotunplug: Unload snd > driver before i915 unbind") that replaced a former conservative workaround > with a more liberal one but also moved it out of initial igt_fixture > section to driv

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/4] tests/core_hotunplug: Free mem allocated by igt_audio_driver_unload

On Tue, 13 Sep 2022 14:04:38 +0200 Janusz Krzysztofik wrote: > Since we pass NULL to igt_audio_driver_unload(), realloc() it calls > allocates new memory for us. Free it each time we no longer need it, > before dropping a pointer to it, to avoid memory leaking. > > Signed-off-by: Janusz Krzyszt

Re: [Intel-gfx] [PATCH 2/2] drm/i915/mtl: Add C6 residency support for MTL SAMedia

On Mon, 19 Sep 2022 05:13:18 -0700, Jani Nikula wrote: > > On Mon, 19 Sep 2022, Badal Nilawar wrote: > > For MTL SAMedia updated relevant functions and places in the code to get > > Media C6 residency. > > > > v2: Fixed review comments (Ashutosh) > > > > Cc: Vinay Belgaumkar > > Cc: Ashutosh Dixi

Re: [Intel-gfx] [PATCH 01/19] drm/i915/perf: Fix OA filtering logic for GuC mode

On Thu, 15 Sep 2022 15:49:27 -0700, Umesh Nerlige Ramappa wrote: > > On Wed, Sep 14, 2022 at 04:13:41PM -0700, Umesh Nerlige Ramappa wrote: > > On Wed, Sep 14, 2022 at 03:26:15PM -0700, Umesh Nerlige Ramappa wrote: > >> On Tue, Sep 06, 2022 at 09:39:33PM +0300, Lionel Landwerlin wrote: > >>> On 06/

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gvt: Fix kernel-doc

== Series Details == Series: drm/i915/gvt: Fix kernel-doc URL : https://patchwork.freedesktop.org/series/108738/ State : success == Summary == CI Bug Log - changes from CI_DRM_12158_full -> Patchwork_108738v1_full Summary --- **SUCCE

[Intel-gfx] ✗ Fi.CI.IGT: failure for drivers/gpu/drm/i915/gt: Check the return value of i915_active_acquire()

== Series Details == Series: drivers/gpu/drm/i915/gt: Check the return value of i915_active_acquire() URL : https://patchwork.freedesktop.org/series/108734/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12158_full -> Patchwork_108734v1_full

Re: [Intel-gfx] [PATCH 16/19] drm/i915/perf: Apply Wa_18013179988

On Mon, 19 Sep 2022 14:21:07 -0700, Umesh Nerlige Ramappa wrote: > > On Fri, Sep 16, 2022 at 02:00:19PM -0700, Dixit, Ashutosh wrote: > > On Fri, 16 Sep 2022 13:25:17 -0700, Umesh Nerlige Ramappa wrote: > >> > >> On Fri, Sep 16, 2022 at 12:57:19PM -0700, Dixit, Ashutosh wrote: > >> > On Fri, 16 Sep

[Intel-gfx] ✓ Fi.CI.BAT: success for Explicit MCR handling and MTL steering

== Series Details == Series: Explicit MCR handling and MTL steering URL : https://patchwork.freedesktop.org/series/108755/ State : success == Summary == CI Bug Log - changes from CI_DRM_12158 -> Patchwork_108755v1 Summary --- **SUCCE

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Fix kernel-doc

== Series Details == Series: drm/i915/gt: Fix kernel-doc URL : https://patchwork.freedesktop.org/series/108733/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12158_full -> Patchwork_108733v1_full Summary --- **FAILUR

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Explicit MCR handling and MTL steering

== Series Details == Series: Explicit MCR handling and MTL steering URL : https://patchwork.freedesktop.org/series/108755/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Explicit MCR handling and MTL steering

== Series Details == Series: Explicit MCR handling and MTL steering URL : https://patchwork.freedesktop.org/series/108755/ State : warning == Summary == Error: dim checkpatch failed b8fad010a955 drm/i915/gen8: Create separate reg definitions for new MCR registers -:266: WARNING:LONG_LINE: lin

Re: [Intel-gfx] [PATCH 03/19] drm/i915/perf: Fix noa wait predication for DG2

On Tue, 23 Aug 2022 13:41:39 -0700, Umesh Nerlige Ramappa wrote: > > Predication for batch buffer commands changed in XEHPSDV. > MI_BATCH_BUFFER_START predicates based on MI_SET_PREDICATE_RESULT > register. The MI_SET_PREDICATE_RESULT register can only be modified > with MI_SET_PREDICATE command. W

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Perf_limit_reasons are only available for Gen11+

== Series Details == Series: drm/i915: Perf_limit_reasons are only available for Gen11+ URL : https://patchwork.freedesktop.org/series/108747/ State : success == Summary == CI Bug Log - changes from CI_DRM_12158 -> Patchwork_108747v1 Summar

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Perf_limit_reasons are only available for Gen11+

== Series Details == Series: drm/i915: Perf_limit_reasons are only available for Gen11+ URL : https://patchwork.freedesktop.org/series/108747/ State : warning == Summary == Error: dim checkpatch failed 19ac562ae81f drm/i915: Perf_limit_reasons are only available for Gen11+ -:11: WARNING:COMMIT

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable Pipewriteback (rev7)

== Series Details == Series: Enable Pipewriteback (rev7) URL : https://patchwork.freedesktop.org/series/107440/ State : success == Summary == CI Bug Log - changes from CI_DRM_12158 -> Patchwork_107440v7 Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH] drm/i915/gt: Bump the reset-failure timeout to 60s

On Fri, Sep 16, 2022 at 01:48:23PM -0700, Ashutosh Dixit wrote: > From: Chris Wilson > > If attempting to perform a GT reset takes long than 5 seconds (including > resetting the display for gen3/4), then we declare all hope lost and > discard all user work and wedge the device to prevent further

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable Pipewriteback (rev7)

== Series Details == Series: Enable Pipewriteback (rev7) URL : https://patchwork.freedesktop.org/series/107440/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev7)

== Series Details == Series: Enable Pipewriteback (rev7) URL : https://patchwork.freedesktop.org/series/107440/ State : warning == Summary == Error: dim checkpatch failed c994ba9a29ce drm/i915: Define WD trancoder for i915 5e7abcf91502 drm/i915 : Changing intel_connector iterators -:76: CHECK:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Do not dereference NULL bo->resource

== Series Details == Series: drm/i915: Do not dereference NULL bo->resource URL : https://patchwork.freedesktop.org/series/108744/ State : success == Summary == CI Bug Log - changes from CI_DRM_12158 -> Patchwork_108744v1 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Move hotplug inversion logic into separate helper

== Series Details == Series: drm/i915: Move hotplug inversion logic into separate helper URL : https://patchwork.freedesktop.org/series/108742/ State : success == Summary == CI Bug Log - changes from CI_DRM_12158 -> Patchwork_108742v1 Summa

Re: [Intel-gfx] [PATCH 3/6] drm/i915/display: Embed the new struct steps for squashing

> -Original Message- > From: Navare, Manasi D > Sent: Monday, September 19, 2022 12:39 PM > To: Jani Nikula > Cc: Srivatsa, Anusha ; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 3/6] drm/i915/display: Embed the new struct > steps for squashing > > On Mon, Sep

Re: [Intel-gfx] [PATCH 1/2] drm/i915/mtl: Modify CAGF functions for MTL

On Mon, Sep 19, 2022 at 03:46:47PM -0700, Matt Roper wrote: > On Mon, Sep 19, 2022 at 05:29:05PM +0530, Badal Nilawar wrote: > > Updated the CAGF functions to get actual resolved frequency of > > 3D and SAMedia > > > > Bspec: 66300 > > > > Cc: Vinay Belgaumkar > > Cc: Ashutosh Dixit > > Signed-

Re: [Intel-gfx] [PATCH 1/2] drm/i915/mtl: Modify CAGF functions for MTL

On Mon, Sep 19, 2022 at 05:29:05PM +0530, Badal Nilawar wrote: > Updated the CAGF functions to get actual resolved frequency of > 3D and SAMedia > > Bspec: 66300 > > Cc: Vinay Belgaumkar > Cc: Ashutosh Dixit > Signed-off-by: Badal Nilawar > --- > drivers/gpu/drm/i915/gt/intel_gt_regs.h | 8 ++

Re: [Intel-gfx] [PATCH 2/6] drm/i915/display: add cdclk action struct to cdclk_config

> -Original Message- > From: Navare, Manasi D > Sent: Monday, September 19, 2022 12:33 PM > To: Jani Nikula > Cc: Srivatsa, Anusha ; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 2/6] drm/i915/display: add cdclk action struct > to cdclk_config > > On Mon, Sep 1

Re: [Intel-gfx] [PATCH 6/6] drm/i915/display: Dump the new cdclk config values

On Mon, Sep 19, 2022 at 05:10:47PM -0400, Rodrigo Vivi wrote: > On Mon, Sep 19, 2022 at 12:46:45PM -0700, Navare, Manasi wrote: > > On Fri, Sep 16, 2022 at 05:44:04PM -0700, Anusha Srivatsa wrote: > > > Add a helper function to get stringify values of the > > > desired cdclk action and dump it with

[Intel-gfx] [PATCH 09/12] drm/i915/gt: Add MCR-specific workaround initializers

Let's be more explicit about which of our workarounds are updating MCR registers. Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 424 +++--- .../gpu/drm/i915/gt/intel_workarounds_types.h | 4 +- 2 files changed, 259 insertions(+), 169 deletions(-) di

[Intel-gfx] [PATCH 02/12] drm/i915/xehp: Create separate reg definitions for new MCR registers

Starting in Xe_HP, several registers our driver works with have been converted from singleton registers into replicated registers with multicast behavior. Although the registers are still located at the same MMIO offsets as on previous platforms, let's duplicate the register definitions in prepara

[Intel-gfx] [PATCH 07/12] drm/i915/gt: Always use MCR functions on multicast registers

Rather than relying on the implicit behavior of intel_uncore_*() functions, let's always use the intel_gt_mcr_*() functions to operate on multicast/replicated registers. Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_ggtt.c | 4 +- drivers/gpu/drm/i915/gt/intel_gtt.c | 4

[Intel-gfx] [PATCH 10/12] drm/i915: Define multicast registers as a new type

Rather than treating multicast registers as 'i915_reg_t' let's define them as a completely new type. This will allow the compiler to help us make sure we're using multicast-aware functions to operate on multicast registers. This plan does break down a bit in places where we're just maintaining he

[Intel-gfx] [PATCH 11/12] drm/i915/mtl: Add multicast steering for render GT

MTL once again changes the multicast register types and steering details. Key changes from past platforms: * The number of instances of some MCR types (NODE, OAAL2, and GAM) vary according to the MTL subplatform and cannot be read from fuse registers. * The MCR steering register (and its b

[Intel-gfx] [PATCH 08/12] drm/i915/guc: Handle save/restore of MCR registers explicitly

MCR registers can be placed on the GuC's save/restore list, but at the moment they are always handled in a multicast manner (i.e., the GuC reads one instance to save the value and then does a multicast write to restore that single value to all instances). In the future the GuC will probably give u

[Intel-gfx] [PATCH 06/12] drm/i915: Define MCR registers explicitly

Rather than using the same _MMIO() macro to define MCR registers as singleton registers, let's use a new MCR_REG() macro to make it clear that these registers are special and should be handled accordingly. For now MCR_REG() will still generate an i915_reg_t with the given offset, but we'll change

[Intel-gfx] [PATCH 12/12] drm/i915/mtl: Add multicast steering for media GT

MTL's media GT only has a single type of steering ("OAADDRM") which selects between media slice 0 and media slice 1. We'll always steer to media slice 0 unless it is fused off (which is the case when VD0, VE0, and SFC0 are all reported as unavailable). Bspec: 67789 Signed-off-by: Matt Roper ---

[Intel-gfx] [PATCH 03/12] drm/i915/gt: Drop a few unused register definitions

Let's drop a few register definitions that are unused anywhere in the driver today. Since the referenced offsets are part of what is now considered a multicast register region, the current definitions would not be correct for use on any future platform. Signed-off-by: Matt Roper --- drivers/gpu

[Intel-gfx] [PATCH 05/12] drm/i915/xehp: Check for faults on primary GAM

On Xe_HP the fault registers are now in a multicast register range. However as part of the GAM these registers follow special rules and we need only read from the "primary" GAM's instance to get the information we need. So a single intel_gt_mcr_read_any() (which will automatically steer to the pri

[Intel-gfx] [PATCH 04/12] drm/i915/gt: Correct prefix on a few registers

We have a few registers that have existed for several hardware generations, but are only used by the driver on Xe_HP and beyond. In cases where the Xe_HP version of the register is now replicated and uses multicast behavior, but earlier generations were singleton, let's change the register prefix

[Intel-gfx] [PATCH 01/12] drm/i915/gen8: Create separate reg definitions for new MCR registers

Gen8 was the first time our hardware had multicast registers (or at least the first time the multicast nature was exposed and MMIO accesses could be steered). There are some registers that transitioned from singleton behavior to multicast during the gen7 -> gen8 transition; let's duplicate the reg

[Intel-gfx] ✓ Fi.CI.BAT: success for Remove unused declarations for gpu/drm

== Series Details == Series: Remove unused declarations for gpu/drm URL : https://patchwork.freedesktop.org/series/108731/ State : success == Summary == CI Bug Log - changes from CI_DRM_12158 -> Patchwork_108731v1 Summary --- **SUCCE

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Remove unused declarations for gpu/drm

== Series Details == Series: Remove unused declarations for gpu/drm URL : https://patchwork.freedesktop.org/series/108731/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2

Re: [Intel-gfx] [PATCH 16/19] drm/i915/perf: Apply Wa_18013179988

On Fri, Sep 16, 2022 at 02:00:19PM -0700, Dixit, Ashutosh wrote: On Fri, 16 Sep 2022 13:25:17 -0700, Umesh Nerlige Ramappa wrote: On Fri, Sep 16, 2022 at 12:57:19PM -0700, Dixit, Ashutosh wrote: > On Fri, 16 Sep 2022 11:56:04 -0700, Umesh Nerlige Ramappa wrote: >> >> On Thu, Sep 15, 2022 at 10:

Re: [Intel-gfx] [PATCH 6/6] drm/i915/display: Dump the new cdclk config values

On Mon, Sep 19, 2022 at 12:46:45PM -0700, Navare, Manasi wrote: > On Fri, Sep 16, 2022 at 05:44:04PM -0700, Anusha Srivatsa wrote: > > Add a helper function to get stringify values of the > > desired cdclk action and dump it with rest of the > > cdclk config values > > > > Signed-off-by: Anusha Sr

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: Fix kernel-doc

== Series Details == Series: drm/i915/gvt: Fix kernel-doc URL : https://patchwork.freedesktop.org/series/108738/ State : success == Summary == CI Bug Log - changes from CI_DRM_12158 -> Patchwork_108738v1 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.BUILD: failure for ✗ Fi.CI.BUILD: failure for drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry. (rev3)

== Series Details == Series: ✗ Fi.CI.BUILD: failure for drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry. (rev3) URL : https://patchwork.freedesktop.org/series/108188/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/108188/revisions/3/mbox/

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display/lspcon: Increase LSPCON mode settle timeout

== Series Details == Series: drm/i915/display/lspcon: Increase LSPCON mode settle timeout URL : https://patchwork.freedesktop.org/series/108735/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12158 -> Patchwork_108735v1 Summ

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry (rev2)

== Series Details == Series: drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry (rev2) URL : https://patchwork.freedesktop.org/series/108732/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/108732/revisions/2/mbox/ not applied Patch is empty.

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.

== Series Details == Series: drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry. URL : https://patchwork.freedesktop.org/series/108736/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/108736/revisions/1/mbox/ not applied Patch is empty. When

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/display/lspcon: Increase LSPCON mode settle timeout

== Series Details == Series: drm/i915/display/lspcon: Increase LSPCON mode settle timeout URL : https://patchwork.freedesktop.org/series/108735/ State : warning == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/108735/revisions/1/mbox/ not found

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/lspcon: Increase LSPCON mode settle timeout

== Series Details == Series: drm/i915/display/lspcon: Increase LSPCON mode settle timeout URL : https://patchwork.freedesktop.org/series/108735/ State : warning == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/108735/revisions/1/mbox/ not found

Re: [Intel-gfx] [PATCH 0/6] Introduce struct cdclk_step

Please find the review commenst for the respective patches. Also as a general rule, please add/ copy all folks nvolved in offline discussions/ triage help in order to accelerate reviews and get feedback from all. Manasi On Fri, Sep 16, 2022 at 05:43:58PM -0700, Anusha Srivatsa wrote: > This is

[Intel-gfx] ✓ Fi.CI.BAT: success for drivers/gpu/drm/i915/gt: Check the return value of i915_active_acquire()

== Series Details == Series: drivers/gpu/drm/i915/gt: Check the return value of i915_active_acquire() URL : https://patchwork.freedesktop.org/series/108734/ State : success == Summary == CI Bug Log - changes from CI_DRM_12158 -> Patchwork_108734v1 ==

Re: [Intel-gfx] [PATCH 6/6] drm/i915/display: Dump the new cdclk config values

On Fri, Sep 16, 2022 at 05:44:04PM -0700, Anusha Srivatsa wrote: > Add a helper function to get stringify values of the > desired cdclk action and dump it with rest of the > cdclk config values > > Signed-off-by: Anusha Srivatsa Please add Suggested-by: field to give proper credits as per our di

Re: [Intel-gfx] [PATCH 3/6] drm/i915/display: Embed the new struct steps for squashing

On Mon, Sep 19, 2022 at 12:27:55PM +0300, Jani Nikula wrote: > On Fri, 16 Sep 2022, Anusha Srivatsa wrote: > > Populate the new struct steps for squash case. > > > > Signed-off-by: Anusha Srivatsa > > --- > > drivers/gpu/drm/i915/display/intel_cdclk.c | 9 - > > 1 file changed, 8 inserti

Re: [Intel-gfx] [PATCH 2/6] drm/i915/display: add cdclk action struct to cdclk_config

On Mon, Sep 19, 2022 at 12:26:19PM +0300, Jani Nikula wrote: > On Fri, 16 Sep 2022, Anusha Srivatsa wrote: > > The struct has the action to be performed - squash, crawl > > or modeset and the corresponding cdclk which is the desired > > cdclk. This is the structure that gets populated during > > a

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drivers/gpu/drm/i915/gt: Check the return value of i915_active_acquire()

== Series Details == Series: drivers/gpu/drm/i915/gt: Check the return value of i915_active_acquire() URL : https://patchwork.freedesktop.org/series/108734/ State : warning == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/108734/revisions/1/mbox/ not found

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drivers/gpu/drm/i915/gt: Check the return value of i915_active_acquire()

== Series Details == Series: drivers/gpu/drm/i915/gt: Check the return value of i915_active_acquire() URL : https://patchwork.freedesktop.org/series/108734/ State : warning == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/108734/revisions/1/mbox/ not found

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Fix kernel-doc

== Series Details == Series: drm/i915/gt: Fix kernel-doc URL : https://patchwork.freedesktop.org/series/108733/ State : success == Summary == CI Bug Log - changes from CI_DRM_12158 -> Patchwork_108733v1 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Fix kernel-doc

== Series Details == Series: drm/i915/gt: Fix kernel-doc URL : https://patchwork.freedesktop.org/series/108733/ State : warning == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/108733/revisions/1/mbox/ not found

Re: [Intel-gfx] [PATCH 1/2] drm/i915/mtl: Modify CAGF functions for MTL

On 19-09-2022 22:19, Andi Shyti wrote: Hi Badal, On Mon, Sep 19, 2022 at 05:29:05PM +0530, Badal Nilawar wrote: Updated the CAGF functions to get actual resolved frequency of 3D and SAMedia can you please use the imperative form? "Update" and not "Updated". Ok. Besides I don't really un

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add HWMON support (rev6)

== Series Details == Series: drm/i915: Add HWMON support (rev6) URL : https://patchwork.freedesktop.org/series/104278/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12146_full -> Patchwork_104278v6_full Summary --- *

Re: [Intel-gfx] [PATCH 1/2] drm/i915/mtl: Modify CAGF functions for MTL

Hi Badal, On Mon, Sep 19, 2022 at 05:29:05PM +0530, Badal Nilawar wrote: > Updated the CAGF functions to get actual resolved frequency of > 3D and SAMedia can you please use the imperative form? "Update" and not "Updated". Besides I don't really understand what you did from the commit, can you p

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Introduce struct cdclk_step

On Sun, 18 Sep 2022 23:35:56 -0700, Vudum, Lakshminarayana wrote: > Hi Lakshmi, > Filed a couple of issues and re-reported. > > This one Likely a regression? > https://gitlab.freedesktop.org/drm/intel/-/issues/6864 > Few tests - dmesg-warn/dmesg-fail/incomplete -BUG: unable to handle page > faul

[Intel-gfx] [PATCH] drm/i915: Perf_limit_reasons are only available for Gen11+

Register GT0_PERF_LIMIT_REASONS (0x1381a8) is available only for Gen11+. Therefore ensure perf_limit_reasons sysfs/debugfs files are created only for Gen11+. Otherwise on Gen < 5 accessing these files results in the following oops: <1> [88.829420] BUG: unable to handle page fault for address:

Re: [Intel-gfx] [PATCH v3 0/2] drm/i915/gem: Really move i915_gem_context.link under ref protection

Pushed, Thanks! Andi On Fri, Sep 16, 2022 at 11:24:01AM +0200, Janusz Krzysztofik wrote: > i915_perf assumes that it can use the i915_gem_context reference to > protect its i915->gem.contexts.list iteration. However, this requires > that we do not remove the context from the list until after we d

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add HWMON support (rev6)

== Series Details == Series: drm/i915: Add HWMON support (rev6) URL : https://patchwork.freedesktop.org/series/104278/ State : success == Summary == CI Bug Log - changes from CI_DRM_12146 -> Patchwork_104278v6 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH] drm/i915: Do not dereference NULL bo->resource

> -Original Message- > From: Das, Nirmoy > Sent: Monday, September 19, 2022 8:33 PM > To: intel-gfx@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org; Auld, Matthew > ; Gupta, Anshuman > Subject: [PATCH] drm/i915: Do not dereference NULL bo->resource > > bo->resource could b

Re: [Intel-gfx] [PATCH] drm/i915: Document and future-proof preemption control policy

On 9/7/22 2:24 PM, Matt Roper wrote: Intel hardware allows some preemption settings to be controlled either by the kernel-mode driver exclusively, or placed under control of the user-mode drivers; on Linux we always select the userspace control option. The various registers involved in this a

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mtl: Add MTL forcewake support

On Sat, Sep 10, 2022 at 07:25:24AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/mtl: Add MTL forcewake support > URL : https://patchwork.freedesktop.org/series/108394/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_12112_full -> Patchwork_108394

[Intel-gfx] [PATCH] drm/i915: Do not dereference NULL bo->resource

bo->resource could be NULL hence add a NULL check for bo->resource before dereferencing it. References: https://gitlab.freedesktop.org/drm/intel/-/issues/6850 Fixes: ad74457a6b5a96 ("drm/i915/dgfx: Release mmap on rpm suspend") Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/i915_gem_ttm.

[Intel-gfx] [PATCH] drm/i915: Move hotplug inversion logic into separate helper

Make the code more readable, which will be more apparent as new platforms with different hotplug inversion needs are added. Signed-off-by: Gustavo Sousa --- drivers/gpu/drm/i915/i915_irq.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/

[Intel-gfx] ✗ Fi.CI.BAT: failure for Enable Pipewriteback (rev6)

== Series Details == Series: Enable Pipewriteback (rev6) URL : https://patchwork.freedesktop.org/series/107440/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12155 -> Patchwork_107440v6 Summary --- **FAILURE** Ser

[Intel-gfx] ✗ Fi.CI.IGT: failure for i915: CAGF and RC6 changes for MTL (rev4)

== Series Details == Series: i915: CAGF and RC6 changes for MTL (rev4) URL : https://patchwork.freedesktop.org/series/108156/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12154_full -> Patchwork_108156v4_full Summary -

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable Pipewriteback (rev6)

== Series Details == Series: Enable Pipewriteback (rev6) URL : https://patchwork.freedesktop.org/series/107440/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev6)

== Series Details == Series: Enable Pipewriteback (rev6) URL : https://patchwork.freedesktop.org/series/107440/ State : warning == Summary == Error: dim checkpatch failed e8e2789aae64 drm/i915: Define WD trancoder for i915 f0b7332cab29 drm/i915 : Changing intel_connector iterators -:76: CHECK:

Re: [Intel-gfx] [topic/core-for-CI] Revert "iommu/dma: Fix race condition during iova_domain initialization"

On 16.09.2022 22:32, Lucas De Marchi wrote: On Fri, Sep 16, 2022 at 02:24:00PM +0200, Karolina Drobnik wrote: On 14.09.2022 17:54, Robin Murphy wrote: On 2022-09-14 16:01, Lucas De Marchi wrote: On Wed, Sep 14, 2022 at 02:40:45PM +0200, Karolina Drobnik wrote: This reverts commit ac9a5d522bb8

Re: [Intel-gfx] [topic/core-for-CI] Revert "iommu/dma: Fix race condition during iova_domain initialization"

On 2022-09-14 16:01, Lucas De Marchi wrote: On Wed, Sep 14, 2022 at 02:40:45PM +0200, Karolina Drobnik wrote: This reverts commit ac9a5d522bb80be50ea84965699e1c8257d745ce. This change introduces a regression on Alder Lake that completely blocks testing. To enable CI and avoid possible circular

[Intel-gfx] [PATCH 5/6] drm/amd/pm: remove unused declarations in hardwaremanager.h

phm_is_hw_access_blocked() and phm_block_hw_access() has been removed since commit 698f88e697cc ("drm/amd/powerplay: delete dead code in powerplay"), so remove them. Signed-off-by: Gaosheng Cui --- drivers/gpu/drm/amd/pm/powerplay/inc/hardwaremanager.h | 2 -- 1 file changed, 2 deletions(-) dif

Re: [Intel-gfx] [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry

Got it. I'll try again later. Best Regards, Zheng Wang Jani Nikula 于2022年9月19日周一 17:30写道： > > On Mon, 19 Sep 2022, Zheng Wang <1002992...@qq.com> wrote: > > From afe79848cb74cc8e45ab426d13fa2394c87e0422 Mon Sep 17 00:00:00 2001 > > From: xmzyshypnc <1002992...@qq.com> > > Date: Fri, 16 Sep 2022

Re: [Intel-gfx] [PATCH] drm/i915: Fix return type of mode_valid function hook

On Tue, Sep 13, 2022 at 01:55:27PM -0700, Nathan Huckleberry wrote: > All of the functions used for intel_dvo_dev_ops.mode_valid have a return > type of enum drm_mode_status, but the mode_valid field in the struct > definition has a return type of int. > > The mismatched return type breaks forward

[Intel-gfx] [PATCH 4/6] drm/gma500: remove unused declarations in psb_intel_drv.h

psb_intel_sdvo_supports_hotplug(), psb_intel_sdvo_set_hotplug() and psb_intel_sdvo_find() have been removed since commit 871c60156dbe ("drm/gma500: Remove dead code"), so remove them. Signed-off-by: Gaosheng Cui --- drivers/gpu/drm/gma500/psb_intel_drv.h | 5 - 1 file changed, 5 deletions(-)

[Intel-gfx] [PATCH] drm/i915/gvt: Fix kernel-doc

drivers/gpu/drm/i915/gvt/cfg_space.c:258: warning: expecting prototype for intel_vgpu_emulate_cfg_read(). Prototype was for intel_vgpu_emulate_cfg_write() instead. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2217 Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/d

Re: [Intel-gfx] [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.

Here I introduced is_error to judge if the ppgtt_invalidate_spt is called from good case or not. Only free spt in good case, leave it to handle for the error path of caller. Zheng Hacker 于2022年9月16日周五 14:39写道： > > From 8d95c1399e3ff345500a575e21254a73b0c89144 Mon Sep 17 00:00:00 2001 > From: xmzy

Re: [Intel-gfx] [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.

I'll try using another mail client like Mutt later. :) Regards, Zheng Wang Greg KH 于2022年9月17日周六 17:07写道： > > On Fri, Sep 16, 2022 at 11:54:42PM +0800, Zheng Hacker wrote: > > >From afe79848cb74cc8e45ab426d13fa2394c87e0422 Mon Sep 17 00:00:00 2001 > > From: xmzyshypnc <1002992...@qq.com> > > Dat

Re: [Intel-gfx] [PATCH v6 17/57] dyndbg: validate class FOO by checking with module

On 9/9/22 16:44, jim.cro...@gmail.com wrote: > On Wed, Sep 7, 2022 at 12:19 PM Jason Baron wrote: >> >> >> >> On 9/4/22 17:40, Jim Cromie wrote: >>> Add module-to-class validation: >>> >>> #> echo class DRM_UT_KMS +p > /proc/dynamic_debug/control >>> >>> If a query has "class FOO", then ddebu

[Intel-gfx] [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry

From afe79848cb74cc8e45ab426d13fa2394c87e0422 Mon Sep 17 00:00:00 2001 From: xmzyshypnc <1002992...@qq.com> Date: Fri, 16 Sep 2022 23:48:23 +0800 Subject: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry There is a double-free security bug in split_2MB_gtt_entry. Here is a callin

Re: [Intel-gfx] [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.

From afe79848cb74cc8e45ab426d13fa2394c87e0422 Mon Sep 17 00:00:00 2001 From: xmzyshypnc <1002992...@qq.com> Date: Fri, 16 Sep 2022 23:48:23 +0800 Subject: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry There is a double-free security bug in split_2MB_gtt_entry. Here is a calling

[Intel-gfx] [PATCH 1/6] drm/vmwgfx: remove unused vmw_bo_is_vmw_bo() declaration

vmw_bo_is_vmw_bo() has been removed since commit 298799a28264 ("drm/vmwgfx: Fix gem refcounting and memory evictions"), so remove it. Signed-off-by: Gaosheng Cui --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h b/driv

Re: [Intel-gfx] [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.

>From 8d95c1399e3ff345500a575e21254a73b0c89144 Mon Sep 17 00:00:00 2001 From: xmzyshypnc <1002992...@qq.com> Date: Fri, 16 Sep 2022 14:37:48 +0800 Subject: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry There is a double-free security bug in split_2MB_gtt_entry. Here is a callin

[Intel-gfx] [PATCH 6/6] drm/i915: remove unused i915_gem_lmem_obj_ops declaration

i915_gem_lmem_obj_ops has been removed since commit 213d50927763 ("drm/i915/ttm: Introduce a TTM i915 gem object backend"), so remove it. Signed-off-by: Gaosheng Cui --- drivers/gpu/drm/i915/gem/i915_gem_lmem.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_ge

[Intel-gfx] [PATCH 2/6] drm/radeon/r600_cs: remove r600_cs_legacy_get_tiling_conf() declaration

r600_cs_legacy_get_tiling_conf() has been removed since commit 8333f607a631 ("drm/radeon: remove UMS support"), so remove it. Signed-off-by: Gaosheng Cui --- drivers/gpu/drm/radeon/r600_cs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600_cs.c b/drivers/gpu/drm/r

Re: [Intel-gfx] [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.

>From afe79848cb74cc8e45ab426d13fa2394c87e0422 Mon Sep 17 00:00:00 2001 From: xmzyshypnc <1002992...@qq.com> Date: Fri, 16 Sep 2022 23:48:23 +0800 Subject: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry There is a double-free security bug in split_2MB_gtt_entry. Here is a callin

[Intel-gfx] [PATCH] drm/i915/display/lspcon: Increase LSPCON mode settle timeout

On some devices the Parade PS175 takes more than 400ms to settle in PCON mode. Signed-off-by: Pablo Ceballos --- drivers/gpu/drm/i915/display/intel_lspcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/dis

[Intel-gfx] [PATCH] drm/i915: Fix return type of mode_valid function hook

All of the functions used for intel_dvo_dev_ops.mode_valid have a return type of enum drm_mode_status, but the mode_valid field in the struct definition has a return type of int. The mismatched return type breaks forward edge kCFI since the underlying function definitions do not match the function

  1   2   >