[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Remove unused function parameter

2022-09-21 Thread Patchwork
== Series Details == Series: drm/i915: Remove unused function parameter URL : https://patchwork.freedesktop.org/series/108863/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12166_full -> Patchwork_108863v1_full Summary

Re: [Intel-gfx] [PATCH 5/7] drm/i915/hwmon: Expose card reactive critical power

2022-09-21 Thread Gupta, Anshuman
On 9/22/2022 8:47 AM, Dixit, Ashutosh wrote: On Wed, 21 Sep 2022 08:07:15 -0700, Gupta, Anshuman wrote: Hi Anshuman, diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 55c35903adca..956e5298ef1e 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove unused function parameter

2022-09-21 Thread Patchwork
== Series Details == Series: drm/i915: Remove unused function parameter URL : https://patchwork.freedesktop.org/series/108863/ State : success == Summary == CI Bug Log - changes from CI_DRM_12166 -> Patchwork_108863v1 Summary --- **S

Re: [Intel-gfx] [PATCH v3 15/15] vfio: Add struct device to vfio_device

2022-09-21 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Thursday, September 22, 2022 12:10 AM > > On Tue, Sep 20, 2022 at 10:55:40PM +, Tian, Kevin wrote: > > > From: Alex Williamson > > > Sent: Wednesday, September 21, 2022 4:27 AM > > > > > > On Fri, 9 Sep 2022 18:22:47 +0800 > > > Kevin Tian wrote: > > > > > >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Remove unused function parameter

2022-09-21 Thread Patchwork
== Series Details == Series: drm/i915: Remove unused function parameter URL : https://patchwork.freedesktop.org/series/108863/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH] drm/i915: Remove unused function parameter

2022-09-21 Thread Niranjana Vishwanathapura
The function parameter 'exclude' in funciton i915_sw_fence_await_reservation() is not used. Remove it. Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 5 ++--- drivers/gpu/drm/i915/gem/i915_gem_clflush.c | 2 +- drivers/gpu/drm/i915/i915_sw_

Re: [Intel-gfx] [PATCH 01/19] drm/i915/perf: Fix OA filtering logic for GuC mode

2022-09-21 Thread Dixit, Ashutosh
On Mon, 19 Sep 2022 20:22:40 -0700, Dixit, Ashutosh wrote: > > On Thu, 15 Sep 2022 15:49:27 -0700, Umesh Nerlige Ramappa wrote: > > > > On Wed, Sep 14, 2022 at 04:13:41PM -0700, Umesh Nerlige Ramappa wrote: > > > On Wed, Sep 14, 2022 at 03:26:15PM -0700, Umesh Nerlige Ramappa wrote: > > >> On Tue,

Re: [Intel-gfx] [PATCH 01/19] drm/i915/perf: Fix OA filtering logic for GuC mode

2022-09-21 Thread Dixit, Ashutosh
On Wed, 21 Sep 2022 20:44:57 -0700, Dixit, Ashutosh wrote: > > On Fri, 09 Sep 2022 16:47:36 -0700, Dixit, Ashutosh wrote: > > > > On Tue, 23 Aug 2022 13:41:37 -0700, Umesh Nerlige Ramappa wrote: > > > > > > +/* > > > + * For execlist mode of submission, pick an unused context id > > > + * 0 - (NUM_

Re: [Intel-gfx] [PATCH 01/19] drm/i915/perf: Fix OA filtering logic for GuC mode

2022-09-21 Thread Dixit, Ashutosh
On Fri, 09 Sep 2022 16:47:36 -0700, Dixit, Ashutosh wrote: > > On Tue, 23 Aug 2022 13:41:37 -0700, Umesh Nerlige Ramappa wrote: > > > > +/* > > + * For execlist mode of submission, pick an unused context id > > + * 0 - (NUM_CONTEXT_TAG -1) are used by other contexts > > + * XXX_MAX_CONTEXT_HW_ID is

Re: [Intel-gfx] [PATCH 5/7] drm/i915/hwmon: Expose card reactive critical power

2022-09-21 Thread Dixit, Ashutosh
On Wed, 21 Sep 2022 08:07:15 -0700, Gupta, Anshuman wrote: > Hi Anshuman, > > diff --git a/drivers/gpu/drm/i915/i915_reg.h > > b/drivers/gpu/drm/i915/i915_reg.h > > index 55c35903adca..956e5298ef1e 100644 > > --- a/drivers/gpu/drm/i915/i915_reg.h > > +++ b/drivers/gpu/drm/i915/i915_reg.h > > @@

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix TC port PLLs after readout

2022-09-21 Thread Patchwork
== Series Details == Series: drm/i915: Fix TC port PLLs after readout URL : https://patchwork.freedesktop.org/series/108847/ State : success == Summary == CI Bug Log - changes from CI_DRM_12166_full -> Patchwork_108847v1_full Summary --

Re: [Intel-gfx] [PATCH 1/1] drm/i915/guc: Delay disabling guc_id scheduling for better hysteresis

2022-09-21 Thread Teres Alexis, Alan Previn
On Fri, 2022-09-16 at 08:36 -0700, Ceraolo Spurio, Daniele wrote: > > On 9/16/2022 1:58 AM, Tvrtko Ursulin wrote: > > On 16/09/2022 08:53, Teres Alexis, Alan Previn wrote: > > > On Thu, 2022-09-15 at 09:48 +0100, Tvrtko Ursulin wrote: > > > > On 15/09/2022 03:12, Alan Previn wrote: > > > > > > >

Re: [Intel-gfx] [PATCH 1/1] drm/i915/guc: Delay disabling guc_id scheduling for better hysteresis

2022-09-21 Thread Teres Alexis, Alan Previn
On Fri, 2022-09-16 at 09:58 +0100, Tvrtko Ursulin wrote: > On 16/09/2022 08:53, Teres Alexis, Alan Previn wrote: > > On Thu, 2022-09-15 at 09:48 +0100, Tvrtko Ursulin wrote: > > > On 15/09/2022 03:12, Alan Previn wrote: > > > > From: Matthew Brost > > > > > > > > +static void guc_flush_all_delay

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix TC port PLLs after readout

2022-09-21 Thread Patchwork
== Series Details == Series: drm/i915: Fix TC port PLLs after readout URL : https://patchwork.freedesktop.org/series/108847/ State : success == Summary == CI Bug Log - changes from CI_DRM_12166 -> Patchwork_108847v1 Summary --- **SUC

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix TC port PLLs after readout

2022-09-21 Thread Patchwork
== Series Details == Series: drm/i915: Fix TC port PLLs after readout URL : https://patchwork.freedesktop.org/series/108847/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:1

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Allow D3 when we are not actively managing a known PCI device.

2022-09-21 Thread Patchwork
== Series Details == Series: drm/i915: Allow D3 when we are not actively managing a known PCI device. URL : https://patchwork.freedesktop.org/series/108841/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12164_full -> Patchwork_108841v1_full

[Intel-gfx] [PATCH 3/4] drm/i915: Pimp DPLL ref/unref debugs

2022-09-21 Thread Ville Syrjala
From: Ville Syrjälä We currently have a debug message in intel_reference_shared_dpll() but no counterpart in intel_unreference_shared_dpll(). Add one. Switch to the [CRTC:...] notation for the pipe name while at it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dpll_mgr.

[Intel-gfx] [PATCH 4/4] drm/i915: WARN if PLL ref/unref got messed up

2022-09-21 Thread Ville Syrjala
From: Ville Syrjälä Spew a WARN if we try to ref/unref the same DPLL multiple times for the same pipe. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dpl

[Intel-gfx] [PATCH 2/4] drm/i915: Don't bail early from intel_dp_initial_fastset_check()

2022-09-21 Thread Ville Syrjala
From: Ville Syrjälä Do all the checks in intel_dp_initial_fastset_check() instead of bailing out on the first condition that triggers. This makes for better debug logs since we see all the reasons why the full modeset computation is forced. Also avoid the risk of someone accidentally adding a c

[Intel-gfx] [PATCH 1/4] drm/i915: Force DPLL calculation for TC ports after readout

2022-09-21 Thread Ville Syrjala
From: Ville Syrjälä We always allocate two DPLLs (TC and TBT) for TC ports. This is because we can't know ahead of time wherher we need to put the PHY into DP-Alt or TBT mode. However during readout we can obviously only read out the state of the DPLL that the port is actually using. Thus the st

[Intel-gfx] [PATCH 0/4] drm/i915: Fix TC port PLLs after readout

2022-09-21 Thread Ville Syrjala
From: Ville Syrjälä I broke the dp-alt->tbt fallback for TC ports a bit. Try to fix it. Also pimp the debugs around those parts a bit. Ville Syrjälä (4): drm/i915: Force DPLL calculation for TC ports after readout drm/i915: Don't bail early from intel_dp_initial_fastset_check() drm/i915: P

[Intel-gfx] [CI] PR for DMC v2.071 for DG2

2022-09-21 Thread Tolakanahalli Pradeep, Madhumitha
The following changes since commit f09bebf31b0590bdc875d7236aa705279510cfd0: amdgpu: update yellow carp DMCUB firmware (2022-09-13 08:02:23 -0400) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware dg2_dmc_v2.071 for you to fetch changes up to 4b05845b82d

[Intel-gfx] [PULL] drm-intel-fixes

2022-09-21 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2022-09-21: 2 gem context related fixes: - to avoid a general protection failure when using perf/OA (Chris) - to avoid kernel warnings on driver release (Janusz) Thanks, Rodrigo. The following changes since commit 521a547ced6477c54b4b0cc206000406c22

[Intel-gfx] ✓ Fi.CI.IGT: success for Delay disabling GuC scheduling of an idle context (rev2)

2022-09-21 Thread Patchwork
== Series Details == Series: Delay disabling GuC scheduling of an idle context (rev2) URL : https://patchwork.freedesktop.org/series/108587/ State : success == Summary == CI Bug Log - changes from CI_DRM_12164_full -> Patchwork_108587v2_full

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Split GAM and MSLICE steering

2022-09-21 Thread Matt Roper
On Fri, Sep 16, 2022 at 08:41:54AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Split GAM and MSLICE steering > URL : https://patchwork.freedesktop.org/series/108627/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_12144_full -> Patchwork_108627

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Allow D3 when we are not actively managing a known PCI device.

2022-09-21 Thread Patchwork
== Series Details == Series: drm/i915: Allow D3 when we are not actively managing a known PCI device. URL : https://patchwork.freedesktop.org/series/108841/ State : success == Summary == CI Bug Log - changes from CI_DRM_12164 -> Patchwork_108841v1 ==

Re: [Intel-gfx] [PATCH] drm/i915: Split GAM and MSLICE steering

2022-09-21 Thread Kumar Valsan, Prathap
On Wed, Sep 21, 2022 at 12:26:17PM -0700, Matt Roper wrote: > On Wed, Sep 21, 2022 at 12:58:08PM -0400, Kumar Valsan, Prathap wrote: > > On Fri, Sep 16, 2022 at 07:53:40AM -0700, Matt Roper wrote: > > > On Fri, Sep 16, 2022 at 10:02:32AM +0100, Tvrtko Ursulin wrote: > > > > > > > > On 16/09/2022 0

Re: [Intel-gfx] [PATCH] drm/i915: Split GAM and MSLICE steering

2022-09-21 Thread Matt Roper
On Wed, Sep 21, 2022 at 12:58:08PM -0400, Kumar Valsan, Prathap wrote: > On Fri, Sep 16, 2022 at 07:53:40AM -0700, Matt Roper wrote: > > On Fri, Sep 16, 2022 at 10:02:32AM +0100, Tvrtko Ursulin wrote: > > > > > > On 16/09/2022 02:43, Matt Roper wrote: > > > > Although the bspec lists several MMIO

[Intel-gfx] ✓ Fi.CI.BAT: success for Delay disabling GuC scheduling of an idle context (rev2)

2022-09-21 Thread Patchwork
== Series Details == Series: Delay disabling GuC scheduling of an idle context (rev2) URL : https://patchwork.freedesktop.org/series/108587/ State : success == Summary == CI Bug Log - changes from CI_DRM_12164 -> Patchwork_108587v2 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Delay disabling GuC scheduling of an idle context (rev2)

2022-09-21 Thread Patchwork
== Series Details == Series: Delay disabling GuC scheduling of an idle context (rev2) URL : https://patchwork.freedesktop.org/series/108587/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Don't use port enum as register offset (rev2)

2022-09-21 Thread Patchwork
== Series Details == Series: drm/i915/display: Don't use port enum as register offset (rev2) URL : https://patchwork.freedesktop.org/series/108833/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12164 -> Patchwork_108833v2 S

Re: [Intel-gfx] [RFC v4 08/14] drm/i915/vm_bind: Abstract out common execbuf functions

2022-09-21 Thread Niranjana Vishwanathapura
On Wed, Sep 21, 2022 at 11:18:53AM +0100, Tvrtko Ursulin wrote: On 21/09/2022 08:09, Niranjana Vishwanathapura wrote: The new execbuf3 ioctl path and the legacy execbuf ioctl paths have many common functionalities. Share code between these two paths by abstracting out the common functionalities

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Don't use port enum as register offset

2022-09-21 Thread Ville Syrjälä
On Wed, Sep 21, 2022 at 10:52:59PM +0530, Balasubramani Vivekanandan wrote: > Display DDI ports are enumerated as PORT_A,PORT_B... . The enums are > also used as an index to access the DDI_BUF_CTL register for the port. > > With the introduction of TypeC ports, new enums PORT_TC1,PORT_TC2.. were >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: Don't use port enum as register offset (rev2)

2022-09-21 Thread Patchwork
== Series Details == Series: drm/i915/display: Don't use port enum as register offset (rev2) URL : https://patchwork.freedesktop.org/series/108833/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [RFC v4 03/14] drm/i915/vm_bind: Expose i915_gem_object_max_page_size()

2022-09-21 Thread Niranjana Vishwanathapura
On Wed, Sep 21, 2022 at 10:13:12AM +0100, Tvrtko Ursulin wrote: On 21/09/2022 08:09, Niranjana Vishwanathapura wrote: Expose i915_gem_object_max_page_size() function non-static which will be used by the vm_bind feature. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti ---

Re: [Intel-gfx] [RFC v4 02/14] drm/i915/vm_bind: Add __i915_sw_fence_await_reservation()

2022-09-21 Thread Niranjana Vishwanathapura
On Wed, Sep 21, 2022 at 10:06:48AM +0100, Tvrtko Ursulin wrote: On 21/09/2022 08:09, Niranjana Vishwanathapura wrote: Add function __i915_sw_fence_await_reservation() for asynchronous wait on a dma-resv object with specified dma_resv_usage. This is required for async vma unbind with vm_bind. S

[Intel-gfx] [PATCH] drm/i915: Allow D3 when we are not actively managing a known PCI device.

2022-09-21 Thread Rodrigo Vivi
The force_probe protection actively avoids the probe of i915 to manage a device that is currently under development. It is a nice protection for future users when getting a new platform but using some older kernel. However, when we avoid the probe we don't take back the registration of the device.

[Intel-gfx] [PATCH v2 1/1] drm/i915/guc: Delay disabling guc_id scheduling for better hysteresis

2022-09-21 Thread Alan Previn
From: Matthew Brost Add a delay, configurable via debugfs (default 34ms), to disable scheduling of a context after the pin count goes to zero. Disable scheduling is a costly operation as it requires synchronizing with the GuC. So the idea is that a delay allows the user to resubmit something befo

[Intel-gfx] [PATCH v2 0/1] Delay disabling GuC scheduling of an idle context

2022-09-21 Thread Alan Previn
This series adds a delay before disabling scheduling of the guc-context when a context has become idle to avoid costly re-registration that may occur immediately after. The 2nd patch should explain it quite well. The origin of this series was posted by Matthew Brost back in Oct 2021 (https://patch

[Intel-gfx] [PATCH v2] drm/i915/display: Don't use port enum as register offset

2022-09-21 Thread Balasubramani Vivekanandan
Display DDI ports are enumerated as PORT_A,PORT_B... . The enums are also used as an index to access the DDI_BUF_CTL register for the port. With the introduction of TypeC ports, new enums PORT_TC1,PORT_TC2.. were added starting from enum value 4 to match the index position of the DDI_BUF_CTL regis

Re: [Intel-gfx] [topic/core-for-CI] Revert "iommu/dma: Fix race condition during iova_domain initialization"

2022-09-21 Thread Janusz Krzysztofik
Hi Robin, On Wednesday, 14 September 2022 17:54:36 CEST Robin Murphy wrote: > On 2022-09-14 16:01, Lucas De Marchi wrote: > > On Wed, Sep 14, 2022 at 02:40:45PM +0200, Karolina Drobnik wrote: > >> This reverts commit ac9a5d522bb80be50ea84965699e1c8257d745ce. > >> > >> This change introduces a regr

Re: [Intel-gfx] [PATCH] drm/i915: Split GAM and MSLICE steering

2022-09-21 Thread Kumar Valsan, Prathap
On Fri, Sep 16, 2022 at 07:53:40AM -0700, Matt Roper wrote: > On Fri, Sep 16, 2022 at 10:02:32AM +0100, Tvrtko Ursulin wrote: > > > > On 16/09/2022 02:43, Matt Roper wrote: > > > Although the bspec lists several MMIO ranges as "MSLICE," it turns out > > > that a subset of these are of a "GAM" subc

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Restrict forced preemption to the active context

2022-09-21 Thread Patchwork
== Series Details == Series: drm/i915/gt: Restrict forced preemption to the active context URL : https://patchwork.freedesktop.org/series/108830/ State : success == Summary == CI Bug Log - changes from CI_DRM_12164_full -> Patchwork_108830v1_full ===

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload

2022-09-21 Thread Das, Nirmoy
On 9/9/2022 10:55 AM, Tvrtko Ursulin wrote: On 08/09/2022 21:07, Nirmoy Das wrote: i915_gem_drain_freed_objects() might not be enough to free all the objects and RCU delayed work might get scheduled after the i915 device struct gets freed. Call i915_gem_drain_workqueue() to catch all RCU del

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Don't use port enum as register offset

2022-09-21 Thread Patchwork
== Series Details == Series: drm/i915/display: Don't use port enum as register offset URL : https://patchwork.freedesktop.org/series/108833/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12164 -> Patchwork_108833v1 Summary

Re: [Intel-gfx] [PATCH 1/7] drm/i915/hwmon: Add HWMON infrastructure

2022-09-21 Thread Andi Shyti
Hi Badal, > > > +struct hwm_reg { > > > +}; > > > + > > > +struct hwm_drvdata { > > > + struct i915_hwmon *hwmon; > > > + struct intel_uncore *uncore; > > > + struct device *hwmon_dev; > > > + char name[12]; > > > +}; > > > + > > > +struct i915_hwmon { > > > + struct hwm_drvdata ddat; > > > + stru

Re: [Intel-gfx] [PATCH] drm/i915/gt: Restrict forced preemption to the active context

2022-09-21 Thread Andi Shyti
Hi Andrzej and Chris, On Wed, Sep 21, 2022 at 03:52:58PM +0200, Andrzej Hajda wrote: > From: Chris Wilson > > When we submit a new pair of contexts to ELSP for execution, we start a > timer by which point we expect the HW to have switched execution to the > pending contexts. If the promotion to

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: Don't use port enum as register offset

2022-09-21 Thread Patchwork
== Series Details == Series: drm/i915/display: Don't use port enum as register offset URL : https://patchwork.freedesktop.org/series/108833/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 1/7] drm/i915/hwmon: Add HWMON infrastructure

2022-09-21 Thread Nilawar, Badal
On 21-09-2022 18:14, Andi Shyti wrote: Hi Badal, +struct hwm_reg { +}; + +struct hwm_drvdata { + struct i915_hwmon *hwmon; + struct intel_uncore *uncore; + struct device *hwmon_dev; + char name[12]; +}; + +struct i915_hwmon { + struct hwm_drvdata ddat; + s

Re: [Intel-gfx] [PATCH v2 5/9] drm/i915: Add missing invalidate to g4x wm readout

2022-09-21 Thread Lisovskiy, Stanislav
On Wed, Jun 22, 2022 at 06:54:48PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Let's not forget to mark the unused watermark levels as invalid > after the readout. The vlv/chv codepath has this but the g4x > didn't for some reason. > > Signed-off-by: Ville Syrjälä Reviewed-by: Stanis

Re: [Intel-gfx] [PATCH v2 4/9] drm/i915: Simplify up vlv watermark sanitation

2022-09-21 Thread Lisovskiy, Stanislav
On Wed, Jun 22, 2022 at 06:54:47PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > We can simplify the vlv watermark sanitation by reusing the > second half of vlv_compute_pipe_wm() to convert the sanitized > raw watermarks into the proper form to be used as the > optimal/intermediate water

Re: [Intel-gfx] [PATCH v2 3/9] drm/i915: Simplify up g4x watermark sanitation

2022-09-21 Thread Lisovskiy, Stanislav
On Wed, Jun 22, 2022 at 06:54:46PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > We can simplify the g4x watermark sanitation by reusing the > second half of g4x_compute_pipe_wm() to convert the sanitized > raw watermarks into the proper form to be used as the > optimal/intermediate water

Re: [Intel-gfx] [PATCH 5/7] drm/i915/hwmon: Expose card reactive critical power

2022-09-21 Thread Gupta, Anshuman
On 9/16/2022 8:30 PM, Badal Nilawar wrote: From: Ashutosh Dixit Expose the card reactive critical (I1) power. I1 is exposed as power1_crit in microwatts (typically for client products) or as curr1_crit in milliamperes (typically for server). v2: Add curr1_crit functionality (Ashutosh) v3:

Re: [Intel-gfx] [PATCH v2 2/9] drm/i915: Split vlv_compute_pipe_wm() into two

2022-09-21 Thread Lisovskiy, Stanislav
On Wed, Jun 22, 2022 at 06:54:45PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Split vlv_compute_pipe_wm() into two halves. The first half computes > the new raw watermarks, and the second half munges those up into real > watermarks for the particular pipe. > > We can reuse the second

Re: [Intel-gfx] [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes

2022-09-21 Thread Maxime Ripard
Hi, On Sun, Sep 11, 2022 at 06:48:50AM +0200, Mateusz Kwiatkowski wrote: > >> Those extra vbp lines will be treated as a black bar at the top of the > >> frame, > >> and extra vfp lines will be at the bottom of the frame. > >> > >> However if someone specifies e.g. 720x604, there's nothing more y

Re: [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting

2022-09-21 Thread Nilawar, Badal
On 21-09-2022 17:15, Gupta, Anshuman wrote: On 9/16/2022 8:30 PM, Badal Nilawar wrote: From: Dale B Stimson Use i915 HWMON to display/modify dGfx power PL1 limit and TDP setting. v2:    - Fix review comments (Ashutosh)    - Do not restore power1_max upon module unload/load sequence

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Restrict forced preemption to the active context

2022-09-21 Thread Patchwork
== Series Details == Series: drm/i915/gt: Restrict forced preemption to the active context URL : https://patchwork.freedesktop.org/series/108830/ State : success == Summary == CI Bug Log - changes from CI_DRM_12164 -> Patchwork_108830v1 Sum

[Intel-gfx] [PATCH] drm/i915/display: Don't use port enum as register offset

2022-09-21 Thread Balasubramani Vivekanandan
Display DDI ports are enumerated as PORT_A,PORT_B... . The enums are also used as an index to access the DDI_BUF_CTL register for the port. With the introduction of TypeC ports, new enums PORT_TC1,PORT_TC2.. were added starting from enum value 4 to match the index position of the DDI_BUF_CTL regis

Re: [Intel-gfx] [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes

2022-09-21 Thread Maxime Ripard
Hi, Thanks again for your help On Sun, Sep 11, 2022 at 06:30:39AM +0200, kFYatek wrote: > W dniu 9.09.2022 o 16:00, Maxime Ripard pisze: > > On Wed, Sep 07, 2022 at 11:31:21PM +0200, Mateusz Kwiatkowski wrote: > >> The "canonical" modelines (at least for vc4's VEC, see the notes below): > >> > >>

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gt: Restrict forced preemption to the active context

2022-09-21 Thread Patchwork
== Series Details == Series: drm/i915/gt: Restrict forced preemption to the active context URL : https://patchwork.freedesktop.org/series/108830/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Restrict forced preemption to the active context

2022-09-21 Thread Patchwork
== Series Details == Series: drm/i915/gt: Restrict forced preemption to the active context URL : https://patchwork.freedesktop.org/series/108830/ State : warning == Summary == Error: dim checkpatch failed 1f75a439c5ab drm/i915/gt: Restrict forced preemption to the active context -:103: WARNING

Re: [Intel-gfx] [PATCH v10 3/9] compiler_types.h: Add assert_type to catch type mis-match while compiling

2022-09-21 Thread Gwan-gyeong Mun
On 9/13/22 3:01 PM, Kees Cook wrote: On Fri, Sep 09, 2022 at 07:59:07PM +0900, Gwan-gyeong Mun wrote: It adds assert_type and assert_typable macros to catch type mis-match while compiling. The existing typecheck() macro outputs build warnings, but the newly added assert_type() macro uses the

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Start cleaning up the DPLL ID mess

2022-09-21 Thread Patchwork
== Series Details == Series: drm/i915: Start cleaning up the DPLL ID mess URL : https://patchwork.freedesktop.org/series/108827/ State : success == Summary == CI Bug Log - changes from CI_DRM_12164_full -> Patchwork_108827v1_full Summary --

Re: [Intel-gfx] [PATCH v2 00/41] drm: Analog TV Improvements

2022-09-21 Thread Maxime Ripard
On Wed, Sep 07, 2022 at 06:44:53PM +0200, Noralf Trønnes wrote: > > > Den 07.09.2022 12.36, skrev Stefan Wahren: > > Hi Maxime, > > > > Am 05.09.22 um 16:57 schrieb Maxime Ripard: > >> On Fri, Sep 02, 2022 at 01:28:16PM +0200, Noralf Trønnes wrote: > >>> > >>> Den 01.09.2022 21.35, skrev Noralf

[Intel-gfx] [PATCH] drm/i915/gt: Restrict forced preemption to the active context

2022-09-21 Thread Andrzej Hajda
From: Chris Wilson When we submit a new pair of contexts to ELSP for execution, we start a timer by which point we expect the HW to have switched execution to the pending contexts. If the promotion to the new pair of contexts has not occurred, we declare the executing context to have hung and for

Re: [Intel-gfx] [PATCH] drm/i915/psr: Fix PSR_IMR/IIR field handling

2022-09-21 Thread Souza, Jose
On Wed, 2022-09-21 at 09:24 +0300, Jouni Högander wrote: > Current PSR code is assuming TRANSCODER_EDP == 0. This is not the case > and all fields in PSR_IMR and PSR_IIR are shifted incorrectly if > DISPLAY_VER >= 12. There is no EDP transcoder in display 12 and newer. > > Fix this by using TRAN

[Intel-gfx] ✗ Fi.CI.IGT: failure for Enable YCbCr420 for VDSC

2022-09-21 Thread Patchwork
== Series Details == Series: Enable YCbCr420 for VDSC URL : https://patchwork.freedesktop.org/series/108824/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12164_full -> Patchwork_108824v1_full Summary --- **FAILURE**

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Start cleaning up the DPLL ID mess

2022-09-21 Thread Patchwork
== Series Details == Series: drm/i915: Start cleaning up the DPLL ID mess URL : https://patchwork.freedesktop.org/series/108827/ State : success == Summary == CI Bug Log - changes from CI_DRM_12164 -> Patchwork_108827v1 Summary --- *

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Start cleaning up the DPLL ID mess

2022-09-21 Thread Patchwork
== Series Details == Series: drm/i915: Start cleaning up the DPLL ID mess URL : https://patchwork.freedesktop.org/series/108827/ State : warning == Summary == Error: dim checkpatch failed e566d547b93b drm/i915: Always initialize dpll.lock 081d1cb10d41 drm/i915: Nuke intel_get_shared_dpll_id()

Re: [Intel-gfx] [PATCH 1/7] drm/i915/hwmon: Add HWMON infrastructure

2022-09-21 Thread Andi Shyti
Hi Badal, > +struct hwm_reg { > +}; > + > +struct hwm_drvdata { > + struct i915_hwmon *hwmon; > + struct intel_uncore *uncore; > + struct device *hwmon_dev; > + char name[12]; > +}; > + > +struct i915_hwmon { > + struct hwm_drvdata ddat; > + struct mutex hwmon_lock;

[Intel-gfx] [PATCH 4/4] drm/i915: Decouple I915_NUM_PLLS from PLL IDs

2022-09-21 Thread Ville Syrjala
From: Ville Syrjälä Stop assuming the size of PLL ID based bitmask is restricted to I915_NUM_PLLS bits. This is the last thing coupling the two things together and thus artificially limiting PLL IDs. We could just pass any arbitrary (large enough) size to for_each_set_bit() and be done with it,

[Intel-gfx] [PATCH 3/4] drm/i915: Stop requiring PLL index == PLL ID

2022-09-21 Thread Ville Syrjala
From: Ville Syrjälä There's no good reason to keep around this PLL index == PLL ID footgun. Get rid of it. Both i915->shared_dplls[] and state->shared_dpll[] are indexed by the same thing now, which is just the index we get at initialization from dpll_mgr->dpll_info[]. The rest is all about PLL

[Intel-gfx] [PATCH 2/4] drm/i915: Nuke intel_get_shared_dpll_id()

2022-09-21 Thread Ville Syrjala
From: Ville Syrjälä Each PLL knows its own ID so intel_get_shared_dpll_id() is pointless. Get rid of it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 4 ++-- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 22 --- drivers/gpu/drm/i915/displa

[Intel-gfx] [PATCH 1/4] drm/i915: Always initialize dpll.lock

2022-09-21 Thread Ville Syrjala
From: Ville Syrjälä Initialize the dll.lock mutex whether or not we manage to initialize the rest of the dpll mgr. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/i

[Intel-gfx] [PATCH 0/4] drm/i915: Start cleaning up the DPLL ID mess

2022-09-21 Thread Ville Syrjala
From: Ville Syrjälä Start to clean up the mess around DPLL IDs a bit by removing the nasty assumption that the index of the DPLL in the arrays matches its ID. Fortunately we did have a WARN i nthere to cathc mistakes, but better to not has such silly assumptions i nthe first place. There's still

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable YCbCr420 for VDSC

2022-09-21 Thread Patchwork
== Series Details == Series: Enable YCbCr420 for VDSC URL : https://patchwork.freedesktop.org/series/108824/ State : success == Summary == CI Bug Log - changes from CI_DRM_12164 -> Patchwork_108824v1 Summary --- **SUCCESS** No reg

Re: [Intel-gfx] [PATCH] drm/i915: Move hotplug inversion logic into separate helper

2022-09-21 Thread Gustavo Sousa
On Wed, Sep 21, 2022 at 11:21:00AM +0300, Jani Nikula wrote: > On Tue, 20 Sep 2022, Gustavo Sousa wrote: > > Hi, Jani. > > > > On Tue, Sep 20, 2022 at 10:19:53AM +0300, Jani Nikula wrote: > >> On Mon, 19 Sep 2022, Gustavo Sousa wrote: > >> > Make the code more readable, which will be more apparen

Re: [Intel-gfx] [PATCH 4/7] drm/i915/hwmon: Show device level energy usage

2022-09-21 Thread Gupta, Anshuman
On 9/16/2022 8:30 PM, Badal Nilawar wrote: From: Dale B Stimson Use i915 HWMON to display device level energy input. v2: - Updated the date and kernel version in feature description v3: - Cleaned up hwm_energy function and removed unused function i915_hwmon_energy_status_get (Ash

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable YCbCr420 for VDSC

2022-09-21 Thread Patchwork
== Series Details == Series: Enable YCbCr420 for VDSC URL : https://patchwork.freedesktop.org/series/108824/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:117:1: warning: u

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable YCbCr420 for VDSC

2022-09-21 Thread Patchwork
== Series Details == Series: Enable YCbCr420 for VDSC URL : https://patchwork.freedesktop.org/series/108824/ State : warning == Summary == Error: dim checkpatch failed 3f358f4298a9 drm/i915/dp: Check if DSC supports the given output_format 40dde02e9f75 drm/i915/vdsc: Enable YCbCr420 for VDSC -

Re: [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting

2022-09-21 Thread Gupta, Anshuman
On 9/16/2022 8:30 PM, Badal Nilawar wrote: From: Dale B Stimson Use i915 HWMON to display/modify dGfx power PL1 limit and TDP setting. v2: - Fix review comments (Ashutosh) - Do not restore power1_max upon module unload/load sequence because on production systems modules are alway

Re: [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting

2022-09-21 Thread Tvrtko Ursulin
On 21/09/2022 01:02, Dixit, Ashutosh wrote: On Fri, 16 Sep 2022 08:00:50 -0700, Badal Nilawar wrote: diff --git a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon index e2974f928e58..bc061238e35c 100644 --- a/Documentation/ABI/

Re: [Intel-gfx] [PATCH 2/7] drm/i915/hwmon: Add HWMON current voltage support

2022-09-21 Thread Gupta, Anshuman
On 9/16/2022 8:30 PM, Badal Nilawar wrote: From: Riana Tauro Use i915 HWMON subsystem to display current input voltage. v2: - Updated date and kernel version in feature description - Fixed review comments (Ashutosh) v3: Use macro HWMON_CHANNEL_INFO to define hwmon channel (Guenter) v4

Re: [Intel-gfx] [PATCH 1/7] drm/i915/hwmon: Add HWMON infrastructure

2022-09-21 Thread Gupta, Anshuman
On 9/16/2022 8:30 PM, Badal Nilawar wrote: From: Dale B Stimson The i915 HWMON module will be used to expose voltage, power and energy values for dGfx. Here we set up i915 hwmon infrastructure including i915 hwmon registration, basic data structures and functions. v2: - Create HWMON infr

[Intel-gfx] [PATCH 3/3] drm/i915/display: Fill in native_420 field

2022-09-21 Thread Kandpal, Suraj
From: Suraj Kandpal Now that we have laid the groundwork for YUV420 Enablement we fill up native_420 field in vdsc_cfg and add appropriate checks wherever required. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/icl_dsi.c| 2 -- drivers/gpu/drm/i915/display/intel_dp.c |

[Intel-gfx] [PATCH 2/3] drm/i915/vdsc: Enable YCbCr420 for VDSC

2022-09-21 Thread Kandpal, Suraj
From: Suraj Kandpal Implementation of VDSC for YCbCr420. Signed-off-by: Suraj Kandpal --- .../gpu/drm/i915/display/intel_qp_tables.c| 187 -- .../gpu/drm/i915/display/intel_qp_tables.h| 4 +- drivers/gpu/drm/i915/display/intel_vdsc.c | 4 +- 3 files changed, 180

[Intel-gfx] [PATCH 1/3] drm/i915/dp: Check if DSC supports the given output_format

2022-09-21 Thread Kandpal, Suraj
From: Ankit Nautiyal Go with DSC only if the given output_format is supported. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i91

[Intel-gfx] [PATCH 0/3] Enable YCbCr420 for VDSC

2022-09-21 Thread Kandpal, Suraj
This patch series aims to enable the YCbCr420 format for DSC. Changes are mostly compute params related for hdmi,dp and dsi along with the addition of new rc_tables for native_420 and corresponding changes to macros used to fetch them. Ankit Nautiyal (1): drm/i915/dp: Check if DSC supports the g

Re: [Intel-gfx] [PATCH v5 15/21] dma-buf: Move dma_buf_vmap() to dynamic locking specification

2022-09-21 Thread Dmitry Osipenko
On 9/20/22 17:13, Sumit Semwal wrote: > Hi Dmitry, > > Thanks very much for the series. > > On Wed, 14 Sept 2022 at 00:59, Dmitry Osipenko > wrote: >> >> Move dma_buf_vmap/vunmap_unlocked() functions to the dynamic locking >> specification by asserting that the reservation lock is held. > Thanks

Re: [Intel-gfx] [PATCH] drm/i915: Move hotplug inversion logic into separate helper

2022-09-21 Thread Jani Nikula
On Tue, 20 Sep 2022, Lucas De Marchi wrote: > On Tue, Sep 20, 2022 at 02:04:33PM -0300, Gustavo Sousa wrote: >>Hi, Jani. >> >>On Tue, Sep 20, 2022 at 10:19:53AM +0300, Jani Nikula wrote: >>> On Mon, 19 Sep 2022, Gustavo Sousa wrote: >>> > Make the code more readable, which will be more apparent a

Re: [Intel-gfx] [RFC v4 08/14] drm/i915/vm_bind: Abstract out common execbuf functions

2022-09-21 Thread Tvrtko Ursulin
On 21/09/2022 08:09, Niranjana Vishwanathapura wrote: The new execbuf3 ioctl path and the legacy execbuf ioctl paths have many common functionalities. Share code between these two paths by abstracting out the common functionalities into a separate file where possible. Looks like a good start

Re: [Intel-gfx] [PATCH] drm/i915: Move hotplug inversion logic into separate helper

2022-09-21 Thread Jani Nikula
On Tue, 20 Sep 2022, Gustavo Sousa wrote: > On Tue, Sep 20, 2022 at 12:01:36AM -0700, Lucas De Marchi wrote: >> On Mon, Sep 19, 2022 at 11:56:59AM -0300, Gustavo Sousa wrote: >> > Make the code more readable, which will be more apparent as new >> > platforms with different hotplug inversion needs

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915/guc: Define CTB based TLB invalidation routines

2022-09-21 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/guc: Define CTB based TLB invalidation routines URL : https://patchwork.freedesktop.org/series/108818/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12163 -> Patchwork_108818v1 ==

Re: [Intel-gfx] [PATCH v5 2/2] drm/i915/dgfx: Release mmap on rpm suspend

2022-09-21 Thread Matthew Auld
On 21/09/2022 06:29, Gupta, Anshuman wrote: -Original Message- From: Matthew Auld Sent: Tuesday, September 20, 2022 7:30 PM To: Gupta, Anshuman Cc: intel-gfx@lists.freedesktop.org; ch...@chris-wilson.co.uk; Auld, Matthew ; Vivi, Rodrigo Subject: Re: [Intel-gfx] [PATCH v5 2/2] drm/i9

Re: [Intel-gfx] [RFC v4 03/14] drm/i915/vm_bind: Expose i915_gem_object_max_page_size()

2022-09-21 Thread Tvrtko Ursulin
On 21/09/2022 08:09, Niranjana Vishwanathapura wrote: Expose i915_gem_object_max_page_size() function non-static which will be used by the vm_bind feature. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_create.c | 20 +++

Re: [Intel-gfx] [RFC v4 02/14] drm/i915/vm_bind: Add __i915_sw_fence_await_reservation()

2022-09-21 Thread Tvrtko Ursulin
On 21/09/2022 08:09, Niranjana Vishwanathapura wrote: Add function __i915_sw_fence_await_reservation() for asynchronous wait on a dma-resv object with specified dma_resv_usage. This is required for async vma unbind with vm_bind. Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915/guc: Define CTB based TLB invalidation routines

2022-09-21 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/guc: Define CTB based TLB invalidation routines URL : https://patchwork.freedesktop.org/series/108818/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked se

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/guc: Define CTB based TLB invalidation routines

2022-09-21 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/guc: Define CTB based TLB invalidation routines URL : https://patchwork.freedesktop.org/series/108818/ State : warning == Summary == Error: dim checkpatch failed 16cae73d9bcf drm/i915/guc: Define CTB based TLB invalidation routi

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/vm_bind: Add VM_BIND functionality (rev3)

2022-09-21 Thread Patchwork
== Series Details == Series: drm/i915/vm_bind: Add VM_BIND functionality (rev3) URL : https://patchwork.freedesktop.org/series/105879/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12163 -> Patchwork_105879v3 Summary --

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/vm_bind: Add VM_BIND functionality (rev3)

2022-09-21 Thread Patchwork
== Series Details == Series: drm/i915/vm_bind: Add VM_BIND functionality (rev3) URL : https://patchwork.freedesktop.org/series/105879/ State : warning == Summary == Error: dim checkpatch failed 1faa6bedf8da drm/i915/vm_bind: Expose vm lookup function 2474615410c3 drm/i915/vm_bind: Add __i915_s

  1   2   >