Re: [Intel-gfx] [RFC][PATCH v3 13/33] timers: drm: Use timer_shutdown_sync() before freeing timer

2022-11-03 Thread Steven Rostedt
[ Once again, quilt fails the MIME coding ] From: "Steven Rostedt (Google)" Before a timer is freed, timer_shutdown_sync() must be called. Link: https://lore.kernel.org/all/20220407161745.7d675...@gandalf.local.home/ Cc: "Noralf Trønnes" Cc: David Airlie Cc: Daniel Vetter Cc: Jani Nikula

[Intel-gfx] [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-03 Thread Steven Rostedt
Back in April, I posted an RFC patch set to help mitigate a common issue where a timer gets armed just before it is freed, and when the timer goes off, it crashes in the timer code without any evidence of who the culprit was. I got side tracked and never finished up on that patch set. Since this

[Intel-gfx] [RFC][PATCH v3 13/33] timers: drm: Use timer_shutdown_sync() before freeing timer

2022-11-03 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Before a timer is freed, timer_shutdown_sync() must be called. Link: https://lore.kernel.org/all/20220407161745.7d675...@gandalf.local.home/ Cc: "Noralf Trønnes" Cc: David Airlie Cc: Daniel Vetter Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc:

Re: [Intel-gfx] [PATCH 11/11] drm/i915: Create resized LUTs for ivb+ split gamma mode

2022-11-03 Thread Nautiyal, Ankit K
Patch looks good to me. Minor suggestions inline: On 10/26/2022 5:09 PM, Ville Syrjala wrote: From: Ville Syrjälä Currently when opeating in split gamma mode we do the nitpick: 'operating' typo. "skip ever other sw LUT entry" trick in the low level LUT programming/readout functions. That

Re: [Intel-gfx] [PATCH] i915/pmu: Use a faster read for 2x32 mmio reads

2022-11-03 Thread Dixit, Ashutosh
On Thu, 03 Nov 2022 11:07:05 -0700, Umesh Nerlige Ramappa wrote: > Hi Umesh, > PMU reads the GT timestamp as a 2x32 mmio read and since upper and lower > 32 bit registers are read in a loop, there is a latency involved in > getting the GT timestamp. To reduce the latency, define another version

Re: [Intel-gfx] [PATCH v3 1/1] drm/i915/guc/slpc: Add selftest for slpc tile-tile interaction

2022-11-03 Thread Belgaumkar, Vinay
On 10/30/2022 10:14 PM, Riana Tauro wrote: Run a workload on tiles simultaneously by requesting for RP0 frequency. Pcode can however limit the frequency being granted due to throttling reasons. This test fails if there is any throttling It actually passes if there was throttling. Only fails if

Re: [Intel-gfx] [PATCH v2 0/7] vfio-ccw parent rework

2022-11-03 Thread Matthew Rosato
On 11/3/22 5:56 PM, Alex Williamson wrote: > On Wed, 2 Nov 2022 16:01:45 +0100 > Eric Farman wrote: > >> Hi all, >> >> Here is an update to the vfio-ccw lifecycle changes that have been discussed >> in various forms over the past year [1][2] or so, and which I dusted off >> recently. >> >>

Re: [Intel-gfx] [PATCH v2 7/7] vfio: Remove vfio_free_device

2022-11-03 Thread Matthew Rosato
On 11/2/22 11:01 AM, Eric Farman wrote: > With the "mess" sorted out, we should be able to inline the > vfio_free_device call introduced by commit cb9ff3f3b84c > ("vfio: Add helpers for unifying vfio_device life cycle") > and remove them from driver release callbacks. > > Signed-off-by: Eric

Re: [Intel-gfx] [PATCH v2 6/7] vfio/ccw: replace vfio_init_device with _alloc_

2022-11-03 Thread Matthew Rosato
On 11/2/22 11:01 AM, Eric Farman wrote: > Now that we have a reasonable separation of structs that follow > the subchannel and mdev lifecycles, there's no reason we can't > call the official vfio_alloc_device routine for our private data, > and behave like everyone else. > > Signed-off-by: Eric

Re: [Intel-gfx] [PATCH v2 5/7] vfio/ccw: remove release completion

2022-11-03 Thread Matthew Rosato
On 11/2/22 11:01 AM, Eric Farman wrote: > There's enough separation between the parent and private structs now, > that it is fine to remove the release completion hack. > > Signed-off-by: Eric Farman > Reviewed-by: Kevin Tian Reviewed-by: Matthew Rosato > --- >

Re: [Intel-gfx] [PATCH v2 4/7] vfio/ccw: move private to mdev lifecycle

2022-11-03 Thread Matthew Rosato
On 11/2/22 11:01 AM, Eric Farman wrote: > Now that the mdev parent data is split out into its own struct, > it is safe to move the remaining private data to follow the > mdev probe/remove lifecycle. The mdev parent data will remain > where it is, and follow the subchannel and the css driver >

[Intel-gfx] linux-next: manual merge of the drm-misc tree with Linus' tree

2022-11-03 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: include/drm/gpu_scheduler.h between commit: 7b476affcccf ("drm/sched: add DRM_SCHED_FENCE_DONT_PIPELINE flag") from Linus' tree and commit: 4d5230b50dd4 ("drm/scheduler: add drm_sched_job_add_resv_dependencies")

Re: [Intel-gfx] [PATCH v2 1/7] vfio/ccw: create a parent struct

2022-11-03 Thread Matthew Rosato
On 11/2/22 11:01 AM, Eric Farman wrote: > Move the stuff associated with the mdev parent (and thus the > subchannel struct) into its own struct, and leave the rest in > the existing private structure. > > The subchannel will point to the parent, and the parent will point > to the private, for the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Add Wa_14017073508 for SAMedia

2022-11-03 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add Wa_14017073508 for SAMedia URL : https://patchwork.freedesktop.org/series/110502/ State : success == Summary == CI Bug Log - changes from CI_DRM_12339 -> Patchwork_110502v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/mtl: Add Wa_14017073508 for SAMedia

2022-11-03 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add Wa_14017073508 for SAMedia URL : https://patchwork.freedesktop.org/series/110502/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/mtl: Add Wa_14017073508 for SAMedia

2022-11-03 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add Wa_14017073508 for SAMedia URL : https://patchwork.freedesktop.org/series/110502/ State : warning == Summary == Error: dim checkpatch failed 0a9efdca81c1 drm/i915/mtl: Add Wa_14017073508 for SAMedia -:114: CHECK:MACRO_ARG_REUSE: Macro argument

Re: [Intel-gfx] [PATCH 3/9] drm/i915: Use kmap_local_page() in gem/i915_gem_shmem.c

2022-11-03 Thread Fabio M. De Francesco
On lunedì 17 ottobre 2022 11:37:19 CET Zhao Liu wrote: > From: Zhao Liu > > The use of kmap_atomic() is being deprecated in favor of > kmap_local_page()[1]. > > The main difference between atomic and local mappings is that local > mappings doesn't disable page faults or preemption. > > In

[Intel-gfx] ✗ Fi.CI.BAT: failure for i915/pmu: Use a faster read for 2x32 mmio reads

2022-11-03 Thread Patchwork
== Series Details == Series: i915/pmu: Use a faster read for 2x32 mmio reads URL : https://patchwork.freedesktop.org/series/110497/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12339 -> Patchwork_110497v1 Summary ---

Re: [Intel-gfx] [PATCH v2 0/7] vfio-ccw parent rework

2022-11-03 Thread Alex Williamson
On Wed, 2 Nov 2022 16:01:45 +0100 Eric Farman wrote: > Hi all, > > Here is an update to the vfio-ccw lifecycle changes that have been discussed > in various forms over the past year [1][2] or so, and which I dusted off > recently. > > Patches 1-5 rework the behavior of the vfio-ccw driver's

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915/pmu: Use a faster read for 2x32 mmio reads

2022-11-03 Thread Patchwork
== Series Details == Series: i915/pmu: Use a faster read for 2x32 mmio reads URL : https://patchwork.freedesktop.org/series/110497/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for mei: add timeout to send

2022-11-03 Thread Patchwork
== Series Details == Series: mei: add timeout to send URL : https://patchwork.freedesktop.org/series/110495/ State : success == Summary == CI Bug Log - changes from CI_DRM_12339 -> Patchwork_110495v1 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for mei: add timeout to send

2022-11-03 Thread Patchwork
== Series Details == Series: mei: add timeout to send URL : https://patchwork.freedesktop.org/series/110495/ State : warning == Summary == Error: dim checkpatch failed 37ffcfbe1ad7 mei: add timeout to send -:157: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #157: FILE:

[Intel-gfx] ✗ Fi.CI.BAT: failure for KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL

2022-11-03 Thread Patchwork
== Series Details == Series: KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL URL : https://patchwork.freedesktop.org/series/110492/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12339 -> Patchwork_110492v1

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL

2022-11-03 Thread Patchwork
== Series Details == Series: KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL URL : https://patchwork.freedesktop.org/series/110492/ State : warning == Summary == Error: dim checkpatch failed 68f3d9527a29 KUnit issues - Was: [igt-dev] [PATCH RFC v2

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/fb-helper: Untangle fbdev emulation and helpers (rev3)

2022-11-03 Thread Patchwork
== Series Details == Series: drm/fb-helper: Untangle fbdev emulation and helpers (rev3) URL : https://patchwork.freedesktop.org/series/109942/ State : success == Summary == CI Bug Log - changes from CI_DRM_12339 -> Patchwork_109942v3

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/fb-helper: Untangle fbdev emulation and helpers (rev3)

2022-11-03 Thread Patchwork
== Series Details == Series: drm/fb-helper: Untangle fbdev emulation and helpers (rev3) URL : https://patchwork.freedesktop.org/series/109942/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/fb-helper: Untangle fbdev emulation and helpers (rev3)

2022-11-03 Thread Patchwork
== Series Details == Series: drm/fb-helper: Untangle fbdev emulation and helpers (rev3) URL : https://patchwork.freedesktop.org/series/109942/ State : warning == Summary == Error: make htmldocs had i915 warnings ./drivers/gpu/drm/i915/i915_perf_types.h:319: warning: Function parameter or

[Intel-gfx] ✓ Fi.CI.BAT: success for Add KUnit support for i915 driver

2022-11-03 Thread Patchwork
== Series Details == Series: Add KUnit support for i915 driver URL : https://patchwork.freedesktop.org/series/110483/ State : success == Summary == CI Bug Log - changes from CI_DRM_12339 -> Patchwork_110483v1 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

2022-11-03 Thread John Harrison
On 11/3/2022 03:45, Jani Nikula wrote: On Wed, 02 Nov 2022, John Harrison wrote: On 11/2/2022 07:20, Tvrtko Ursulin wrote: On 02/11/2022 12:12, Jani Nikula wrote: On Tue, 01 Nov 2022, john.c.harri...@intel.com wrote: From: John Harrison At the end of each test, IGT does a drop caches

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

2022-11-03 Thread John Harrison
On 11/3/2022 02:18, Tvrtko Ursulin wrote: On 03/11/2022 01:33, John Harrison wrote: On 11/2/2022 07:20, Tvrtko Ursulin wrote: On 02/11/2022 12:12, Jani Nikula wrote: On Tue, 01 Nov 2022, john.c.harri...@intel.com wrote: From: John Harrison At the end of each test, IGT does a drop caches

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add KUnit support for i915 driver

2022-11-03 Thread Patchwork
== Series Details == Series: Add KUnit support for i915 driver URL : https://patchwork.freedesktop.org/series/110483/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add KUnit support for i915 driver

2022-11-03 Thread Patchwork
== Series Details == Series: Add KUnit support for i915 driver URL : https://patchwork.freedesktop.org/series/110483/ State : warning == Summary == Error: dim checkpatch failed 1c12427bb8a0 drm/i915: export all selftest functions 100f0a51abe8 drm/i915: place selftest preparation on a separate

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dsc: Add is_dsc_supported()

2022-11-03 Thread Patchwork
== Series Details == Series: drm/i915/dsc: Add is_dsc_supported() URL : https://patchwork.freedesktop.org/series/110469/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12333_full -> Patchwork_110469v1_full Summary ---

Re: [Intel-gfx] [PATCH 1/9] drm/i915: Use kmap_local_page() in gem/i915_gem_object.c

2022-11-03 Thread Fabio M. De Francesco
On giovedì 3 novembre 2022 17:51:23 CET Ira Weiny wrote: > On Sat, Oct 29, 2022 at 01:17:03PM +0200, Fabio M. De Francesco wrote: > > On lunedì 17 ottobre 2022 11:37:17 CEST Zhao Liu wrote: > > > From: Zhao Liu > > > > > > The use of kmap_atomic() is being deprecated in favor of > > >

Re: [Intel-gfx] [PATCH] drm/i915/dsc: Add is_dsc_supported()

2022-11-03 Thread Navare, Manasi
On Thu, Nov 03, 2022 at 11:32:22AM +0530, Swati Sharma wrote: > Lets use RUNTIME_INFO->has_dsc since platforms supporting dsc has this > flag enabled. > > This is done based on the review comments received on > https://patchwork.freedesktop.org/patch/509393/ > > Signed-off-by: Swati Sharma >

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gt: Add sysfs RAPL PL1 interface

2022-11-03 Thread Patchwork
== Series Details == Series: drm/i915/gt: Add sysfs RAPL PL1 interface URL : https://patchwork.freedesktop.org/series/110476/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/110476/revisions/1/mbox/ not applied Applying: drm/i915/gt: Add sysfs

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

2022-11-03 Thread John Harrison
On 11/3/2022 02:38, Tvrtko Ursulin wrote: On 03/11/2022 09:18, Tvrtko Ursulin wrote: On 03/11/2022 01:33, John Harrison wrote: On 11/2/2022 07:20, Tvrtko Ursulin wrote: On 02/11/2022 12:12, Jani Nikula wrote: On Tue, 01 Nov 2022, john.c.harri...@intel.com wrote: From: John Harrison At the

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Use memcpy_from_page() in gt/uc/intel_uc_fw.c

2022-11-03 Thread Ira Weiny
On Mon, Oct 17, 2022 at 05:37:23PM +0800, Zhao Liu wrote: > From: Zhao Liu > > The use of kmap_atomic() is being deprecated in favor of > kmap_local_page()[1]. > > The main difference between atomic and local mappings is that local > mappings doesn't disable page faults or preemption. > > In

Re: [Intel-gfx] [PATCH] drm/i915/guc: Remove excessive line feeds in state dumps

2022-11-03 Thread Umesh Nerlige Ramappa
On Mon, Oct 31, 2022 at 03:00:07PM -0700, john.c.harri...@intel.com wrote: From: John Harrison Some of the GuC state dump messages were adding extra line feeds. When printing via a DRM printer to dmesg, for example, that messes up the log formatting as it loses any prefixing from the printer.

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/guc: Don't deadlock busyness stats vs reset

2022-11-03 Thread Umesh Nerlige Ramappa
On Thu, Nov 03, 2022 at 11:45:57AM -0700, John Harrison wrote: On 11/3/2022 04:31, Tvrtko Ursulin wrote: On 02/11/2022 19:21, john.c.harri...@intel.com wrote: From: John Harrison The engine busyness stats has a worker function to do things like 64bit extend the 32bit hardware counters. The

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/guc: Don't deadlock busyness stats vs reset

2022-11-03 Thread John Harrison
On 11/3/2022 04:31, Tvrtko Ursulin wrote: On 02/11/2022 19:21, john.c.harri...@intel.com wrote: From: John Harrison The engine busyness stats has a worker function to do things like 64bit extend the 32bit hardware counters. The GuC's reset prepare function flushes out this worker function to

[Intel-gfx] [PATCH v2] drm/i915/mtl: Add Wa_14017073508 for SAMedia

2022-11-03 Thread Badal Nilawar
This workaround is added for Media tile of MTL A step. It is to help pcode workaround which handles the hardware issue seen during package C2/C3 transitions due to RC6 entry/exit transitions on Media tile. As a part of workaround pcode expect kmd to send mailbox message "media busy" when

Re: [Intel-gfx] [PATCH] drm/i915/selftest: Bump up sample period for busy stats selftest

2022-11-03 Thread Umesh Nerlige Ramappa
On Thu, Nov 03, 2022 at 10:01:11AM -0700, Dixit, Ashutosh wrote: On Wed, 02 Nov 2022 17:11:49 -0700, Umesh Nerlige Ramappa wrote: Engine busyness samples around a 10ms period is failing with busyness ranging approx. from 87% to 115%. The expected range is +/- 5% of the sample period. When

Re: [Intel-gfx] [PATCH] i915/pmu: Use a faster read for 2x32 mmio reads

2022-11-03 Thread Umesh Nerlige Ramappa
On Thu, Nov 03, 2022 at 11:07:05AM -0700, Umesh Nerlige Ramappa wrote: PMU reads the GT timestamp as a 2x32 mmio read and since upper and lower 32 bit registers are read in a loop, there is a latency involved in getting the GT timestamp. To reduce the latency, define another version of the

Re: [Intel-gfx] [PATCH] drm/i915/selftest: Bump up sample period for busy stats selftest

2022-11-03 Thread Umesh Nerlige Ramappa
On Thu, Nov 03, 2022 at 12:28:46PM +, Tvrtko Ursulin wrote: On 03/11/2022 00:11, Umesh Nerlige Ramappa wrote: Engine busyness samples around a 10ms period is failing with busyness ranging approx. from 87% to 115%. The expected range is +/- 5% of the sample period. When determining

[Intel-gfx] [PATCH] i915/pmu: Use a faster read for 2x32 mmio reads

2022-11-03 Thread Umesh Nerlige Ramappa
PMU reads the GT timestamp as a 2x32 mmio read and since upper and lower 32 bit registers are read in a loop, there is a latency involved in getting the GT timestamp. To reduce the latency, define another version of the helper that requires caller to acquire uncore->spinlock and necessary

Re: [Intel-gfx] [PATCH] drm/i915/selftest: Bump up sample period for busy stats selftest

2022-11-03 Thread Dixit, Ashutosh
On Wed, 02 Nov 2022 17:11:49 -0700, Umesh Nerlige Ramappa wrote: > > Engine busyness samples around a 10ms period is failing with busyness > ranging approx. from 87% to 115%. The expected range is +/- 5% of the > sample period. > > When determining busyness of active engine, the GuC based engine >

Re: [Intel-gfx] [PATCH 1/9] drm/i915: Use kmap_local_page() in gem/i915_gem_object.c

2022-11-03 Thread Ira Weiny
On Sat, Oct 29, 2022 at 01:17:03PM +0200, Fabio M. De Francesco wrote: > On lunedì 17 ottobre 2022 11:37:17 CEST Zhao Liu wrote: > > From: Zhao Liu > > > > The use of kmap_atomic() is being deprecated in favor of > > kmap_local_page()[1]. > > > > The main difference between atomic and local

Re: [Intel-gfx] [PATCH 3/9] drm/i915: Use kmap_local_page() in gem/i915_gem_shmem.c

2022-11-03 Thread Ira Weiny
On Mon, Oct 17, 2022 at 05:37:19PM +0800, Zhao Liu wrote: > From: Zhao Liu > > The use of kmap_atomic() is being deprecated in favor of > kmap_local_page()[1]. > > The main difference between atomic and local mappings is that local > mappings doesn't disable page faults or preemption. > > In

[Intel-gfx] [PATCH] mei: add timeout to send

2022-11-03 Thread Alexander Usyskin
When driver wakes up the firmware from the low power stand, it is sending a memory ready message. The send is done via synchronous/blocking function to ensure that firmware is in ready state. However firmware might be in unstable state and send might be block forever. To address this issue a

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Don't wait forever in drop_caches (rev2)

2022-11-03 Thread Patchwork
== Series Details == Series: drm/i915: Don't wait forever in drop_caches (rev2) URL : https://patchwork.freedesktop.org/series/110395/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12333_full -> Patchwork_110395v2_full

[Intel-gfx] KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL

2022-11-03 Thread Mauro Carvalho Chehab
Hi, I'm facing a couple of issues when testing KUnit with the i915 driver. The DRM subsystem and the i915 driver has, for a long time, his own way to do unit tests, which seems to be added before KUnit. I'm now checking if it is worth start using KUnit at i915. So, I wrote a RFC with some

[Intel-gfx] [PATCH v3 18/23] drm/fb_helper: Minimize damage-helper overhead

2022-11-03 Thread Thomas Zimmermann
Pull the test for fb_dirty into the caller to avoid extra work if no callback has been set. In this case no damage handling is required and no damage area needs to be computed. Print a warning if the damage worker runs without getting an fb_dirty callback. Signed-off-by: Thomas Zimmermann

[Intel-gfx] [PATCH v3 15/23] drm/fb-helper: Disconnect damage worker from update logic

2022-11-03 Thread Thomas Zimmermann
The fbdev helpers implement a damage worker that forwards fbdev updates to the DRM driver. The worker's update logic depends on the generic fbdev emulation. Separate the two via function pointer. The generic fbdev emulation sets struct drm_fb_helper_funcs.fb_dirty, a new callback that hides the

[Intel-gfx] [PATCH v3 16/23] drm/fb-helper: Call fb_sync in I/O functions

2022-11-03 Thread Thomas Zimmermann
Call struct fb_ops.fb_sync in drm_fbdev_{read,write}() to mimic the behavior of fbdev. Fbdev implementations of fb_read and fb_write in struct fb_ops invoke fb_sync to synchronize with outstanding operations before I/O. Doing the same in DRM implementations will allow us to use them throughout DRM

[Intel-gfx] [PATCH v3 17/23] drm/fb-helper: Perform all fbdev I/O with the same implementation

2022-11-03 Thread Thomas Zimmermann
Implement the fbdev's read/write helpers with the same functions. Use the generic fbdev's code as template. Convert all drivers. DRM's fb helpers must implement regular I/O functionality in struct fb_ops and possibly perform a damage update. Handle all this in the same functions and convert

[Intel-gfx] [PATCH v3 22/23] drm/fb-helper: Remove unnecessary include statements

2022-11-03 Thread Thomas Zimmermann
Remove include statements for where it is not required (i.e., most of them). In a few places include other header files that are required by the source code. v3: * fix amdgpu include statements * fix rockchip include statements Signed-off-by: Thomas Zimmermann Reviewed-by:

[Intel-gfx] [PATCH v3 14/23] drm/fb-helper: Rename drm_fb_helper_unregister_fbi() to use _info postfix

2022-11-03 Thread Thomas Zimmermann
Rename drm_fb_helper_unregister_fbi() to drm_fb_helper_unregister_info() as part of unifying the naming within fbdev helpers. Adapt drivers. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/armada/armada_fbdev.c | 2 +-

[Intel-gfx] [PATCH v3 12/23] drm/fb_helper: Rename field fbdev to info in struct drm_fb_helper

2022-11-03 Thread Thomas Zimmermann
Rename struct drm_fb_helper.fbdev to info. The current name is misleading as it overlaps with generic fbdev naming conventions. Adapt to the usual naming in fbdev drivers by calling the field 'info'. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas

[Intel-gfx] [PATCH v3 19/23] drm/fb-helper: Always initialize generic fbdev emulation

2022-11-03 Thread Thomas Zimmermann
Initialize the generic fbdev emulation even if it has been disabled on the kernel command line. The hotplug and mode initialization will fail accordingly. The kernel parameter can still be changed at runtime and the emulation will initialize after hotplugging the connector. Signed-off-by: Thomas

[Intel-gfx] [PATCH v3 23/23] drm/fb-helper: Clarify use of last_close and output_poll_changed

2022-11-03 Thread Thomas Zimmermann
Clarify documentation in the use of struct drm_driver.last_close and struct drm_mode_config_funcs.output_poll_changed. Those callbacks should not be said for fbdev implementations on top of struct drm_client_funcs. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 6 --

[Intel-gfx] [PATCH v3 21/23] drm/fb-helper: Move generic fbdev emulation into separate source file

2022-11-03 Thread Thomas Zimmermann
Move the generic fbdev implementation into its own source and header file. Adapt drivers. No functional changes, but some of the internal helpers have been renamed to fit into the drm_fbdev_ naming scheme. v3: * rename drm_fbdev.{c,h} to drm_fbdev_generic.{c,h} * rebase onto

[Intel-gfx] [PATCH v3 20/23] drm/fb-helper: Set flag in struct drm_fb_helper for leaking physical addresses

2022-11-03 Thread Thomas Zimmermann
Uncouple the parameter drm_leak_fbdev_smem from the implementation by setting a flag in struct drm_fb_helper. This will help to move the generic fbdev emulation into its own source file, while keeping the parameter in drm_fb_helper.c. No functional changes. Signed-off-by: Thomas Zimmermann ---

[Intel-gfx] [PATCH v3 13/23] drm/fb-helper: Rename drm_fb_helper_alloc_fbi() to use _info postfix

2022-11-03 Thread Thomas Zimmermann
Rename drm_fb_helper_alloc_fbi() to drm_fb_helper_alloc_info() as part of unifying the naming within fbdev helpers. Adapt drivers. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/armada/armada_fbdev.c | 2 +-

[Intel-gfx] [PATCH v3 11/23] drm/fb-helper: Cleanup include statements in header file

2022-11-03 Thread Thomas Zimmermann
Only include what we have to. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- include/drm/drm_fb_helper.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index

[Intel-gfx] [PATCH v3 08/23] drm/rockchip: Don't set struct drm_driver.output_poll_changed

2022-11-03 Thread Thomas Zimmermann
Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as rockchip uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in

[Intel-gfx] [PATCH v3 06/23] drm/ingenic: Don't set struct drm_driver.output_poll_changed

2022-11-03 Thread Thomas Zimmermann
Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as ingenic uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in

[Intel-gfx] [PATCH v3 10/23] drm/tve200: Include

2022-11-03 Thread Thomas Zimmermann
Include for of_match_ptr(). Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/tve200/tve200_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tve200/tve200_drv.c b/drivers/gpu/drm/tve200/tve200_drv.c index

[Intel-gfx] [PATCH v3 09/23] drm/panel-ili9341: Include

2022-11-03 Thread Thomas Zimmermann
Include for devm_of_find_backlight(). Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c

[Intel-gfx] [PATCH v3 03/23] drm/vboxvideo: Don't set struct drm_driver.lastclose

2022-11-03 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as vboxvideo uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann

[Intel-gfx] [PATCH v3 07/23] drm/logicvc: Don't set struct drm_driver.output_poll_changed

2022-11-03 Thread Thomas Zimmermann
Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as logicvc uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in

[Intel-gfx] [PATCH v3 04/23] drm/amdgpu: Don't set struct drm_driver.output_poll_changed

2022-11-03 Thread Thomas Zimmermann
Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as amdgpu uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in

[Intel-gfx] [PATCH v3 02/23] drm/mcde: Don't set struct drm_driver.lastclose

2022-11-03 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as mcde uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann Reviewed-by:

[Intel-gfx] [PATCH v3 01/23] drm/komeda: Don't set struct drm_driver.lastclose

2022-11-03 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as komeda uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann Reviewed-by:

[Intel-gfx] [PATCH v3 05/23] drm/imx/dcss: Don't set struct drm_driver.output_poll_changed

2022-11-03 Thread Thomas Zimmermann
Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as DCSS uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in

[Intel-gfx] [PATCH v3 00/23] drm/fb-helper: Untangle fbdev emulation and helpers

2022-11-03 Thread Thomas Zimmermann
Separate generic fbdev emulation from the helper code that is shared among the various fbdev implementations within DRM. Affects many drivers. It has become apparent that our fully generic fbdev emulation will never produce optimal results for all drivers. In its current form, it is also hard to

[Intel-gfx] ✓ Fi.CI.BAT: success for Add DP MST DSC support to i915 (rev16)

2022-11-03 Thread Patchwork
== Series Details == Series: Add DP MST DSC support to i915 (rev16) URL : https://patchwork.freedesktop.org/series/101492/ State : success == Summary == CI Bug Log - changes from CI_DRM_12337 -> Patchwork_101492v16 Summary ---

[Intel-gfx] [PATCH RFC v2 0/8] Add KUnit support for i915 driver

2022-11-03 Thread Mauro Carvalho Chehab
This RFC patch series implement KUnit support for i915 driver, using the already-existing tests inside i915 selftests. On this version, mock selftest can now run in qemu with: $ ./tools/testing/kunit/kunit.py run --arch=x86_64 \

[Intel-gfx] [PATCH RFC v2 2/8] drm/i915: place selftest preparation on a separate function

2022-11-03 Thread Mauro Carvalho Chehab
The selftest preparation logic should also be used by KUnit. So, place it on a separate function and export it. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH RFC v2 0/8] at:

[Intel-gfx] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL

2022-11-03 Thread Mauro Carvalho Chehab
The mmap tests require mm in order to work. Failing to do that will cause a crash: [ 316.820722] BUG: kernel NULL pointer dereference, address: 00e8 [ 316.822517] #PF: supervisor write access in kernel mode [ 316.823430] #PF: error_code(0x0002) - not-present page [ 316.824390] PGD

[Intel-gfx] [PATCH RFC v2 4/8] drm/i915: add support to run KUnit tests on bare metal

2022-11-03 Thread Mauro Carvalho Chehab
Add a logic to seek for PCI devices and to run tests on them, if the tests are willing to run on physical hardware, instead of using Qemu. Later patches will add the KUnit tests. So, for now, mark such functions with __maybe_unused, to avoid build issues with WERROR. Signed-off-by: Mauro

[Intel-gfx] [PATCH RFC v2 1/8] drm/i915: export all selftest functions

2022-11-03 Thread Mauro Carvalho Chehab
In order to prepare for a new KUnit module that will run selftests, export all selftest functions to I915_SELFTEST namespace. No functional changes. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH

[Intel-gfx] [PATCH RFC v2 7/8] drm/i915: now that all functions are used, remove __maybe_unused

2022-11-03 Thread Mauro Carvalho Chehab
The PCI-specific KUnit tests that run in bare metal got added, so we can remove the __maybe_unused from such functions. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH RFC v2 0/8] at:

[Intel-gfx] [PATCH RFC v2 3/8] drm/i915: allow running mock selftests via Kunit

2022-11-03 Thread Mauro Carvalho Chehab
The mock selftests don't require any hardware to run. They can easily run via kunit with qemu or bare metal. Add support for it. With this change, mock selftest can now run in qemu with: $ ./tools/testing/kunit/kunit.py run --arch=x86_64 \

[Intel-gfx] [PATCH RFC v2 5/8] drm/i915: add live selftests to KUnit

2022-11-03 Thread Mauro Carvalho Chehab
Now that i915 KUnit has PCI support, add live tests as well. NOTE: currently, some tests are failing when excecuting via KUnit. I'll do a further investigation to check why, and if this patch can be safely merged or not. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large

[Intel-gfx] [PATCH RFC v2 6/8] drm/i915: add perf selftests to KUnit

2022-11-03 Thread Mauro Carvalho Chehab
Now that i915 KUnit has PCI support, add perf tests as well. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH RFC v2 0/8] at: https://lore.kernel.org/all/cover.1667486144.git.mche...@kernel.org/

[Intel-gfx] ✗ Fi.CI.DOCS: warning for Add DP MST DSC support to i915 (rev16)

2022-11-03 Thread Patchwork
== Series Details == Series: Add DP MST DSC support to i915 (rev16) URL : https://patchwork.freedesktop.org/series/101492/ State : warning == Summary == Error: make htmldocs had i915 warnings ./drivers/gpu/drm/i915/i915_perf_types.h:319: warning: Function parameter or member 'lock' not

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pps: improve eDP power on flow. (rev3)

2022-11-03 Thread Patchwork
== Series Details == Series: drm/i915/pps: improve eDP power on flow. (rev3) URL : https://patchwork.freedesktop.org/series/110038/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12333_full -> Patchwork_110038v3_full

[Intel-gfx] [PATCH v1] drm/i915/gt: Add sysfs RAPL PL1 interface

2022-11-03 Thread Sujaritha Sundaresan
Adding the rapl_pl1_freq_mhz sysfs attribute. Signed-off-by: Sujaritha Sundaresan Cc: Ashutosh Dixit --- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 20 ++ drivers/gpu/drm/i915/gt/intel_rps.c | 44 + drivers/gpu/drm/i915/gt/intel_rps.h | 3 ++

[Intel-gfx] [PATCH 6/6] drm/i915: Bpp/timeslot calculation fixes for DP MST DSC

2022-11-03 Thread Stanislav Lisovskiy
Fix intel_dp_dsc_compute_config, previously timeslots parameter was used in fact not as a timeslots, but more like a ratio timeslots/64, which of course didn't have any effect for SST DSC, but causes now issues for MST DSC. Secondly we need to calculate pipe_bpp using intel_dp_dsc_compute_bpp only

[Intel-gfx] [PATCH 5/6] drm/i915: Extract VESA DSC bpp alignment to separate function

2022-11-03 Thread Stanislav Lisovskiy
We might to use that function separately from intel_dp_dsc_compute_config for DP DSC over MST case, because allocating bandwidth in that case can be a bit more tricky. So in order to avoid code copy-pasta lets extract this to separate function and reuse it for both SST and MST cases. v2: Removed

Re: [Intel-gfx] [PATCH] drm/i915/selftest: Bump up sample period for busy stats selftest

2022-11-03 Thread Tvrtko Ursulin
On 03/11/2022 00:11, Umesh Nerlige Ramappa wrote: Engine busyness samples around a 10ms period is failing with busyness ranging approx. from 87% to 115%. The expected range is +/- 5% of the sample period. When determining busyness of active engine, the GuC based engine busyness implementation

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftest: Bump up sample period for busy stats selftest

2022-11-03 Thread Patchwork
== Series Details == Series: drm/i915/selftest: Bump up sample period for busy stats selftest URL : https://patchwork.freedesktop.org/series/110454/ State : success == Summary == CI Bug Log - changes from CI_DRM_12333_full -> Patchwork_110454v1_full

Re: [Intel-gfx] [PATCH 6/7] drm/i915: Factor out function to get/put AUX_IO power for main link

2022-11-03 Thread Imre Deak
On Wed, Nov 02, 2022 at 09:02:41PM +0200, Jani Nikula wrote: > On Wed, 02 Nov 2022, Imre Deak wrote: > > Factor out functions to get/put the AUX_IO power domain for the main > > link on DDI ports. > > > > While at it clarify the corresponding code comment. > > > > No functional change. > > > >

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Allocate power domain set wakerefs dynamically

2022-11-03 Thread Imre Deak
On Wed, Nov 02, 2022 at 08:57:21PM +0200, Jani Nikula wrote: > On Wed, 02 Nov 2022, Imre Deak wrote: > > Since the intel_display_power_domain_set struct, currently its current > > size close 1kB, can be allocated on the stack, it's better to allocate > > the per-domain wakeref pointer array -

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/guc: Don't deadlock busyness stats vs reset

2022-11-03 Thread Tvrtko Ursulin
On 02/11/2022 19:21, john.c.harri...@intel.com wrote: From: John Harrison The engine busyness stats has a worker function to do things like 64bit extend the 32bit hardware counters. The GuC's reset prepare function flushes out this worker function to ensure no corruption happens during the

Re: [Intel-gfx] [v3] drm/i915/pps: improve eDP power on flow

2022-11-03 Thread Lee, Shawn C
On Thursday, November 3, 2022 7:00 PM, Jani Nikula wrote: >On Thu, 03 Nov 2022, Lee Shawn C wrote: >> After i915 dirver initialized, a panel power off cycle delay always >> append before turn eDP on. If eDP display did not power on before. >> With this change, power off duration might longer

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/i915/module_load: restore gem_sanitycheck for discrete

2022-11-03 Thread Das, Nirmoy
Reviewed-by: Nirmoy Das On 11/3/2022 12:10 PM, Das, Nirmoy wrote: Reviewed-by: nirmoy@intel.com On 11/2/2022 4:05 PM, Matthew Auld wrote: This looks to be recently broken in: 5389b3f3 ("tests/i915/i915_module_load: Use GEM_BUSY instead of SET_CACHE for sanity check"). Which fails on

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/i915/module_load: restore gem_sanitycheck for discrete

2022-11-03 Thread Das, Nirmoy
Reviewed-by: nirmoy@intel.com On 11/2/2022 4:05 PM, Matthew Auld wrote: This looks to be recently broken in: 5389b3f3 ("tests/i915/i915_module_load: Use GEM_BUSY instead of SET_CACHE for sanity check"). Which fails on discrete platforms, since we switched over to the gem_busy ioctl, from

Re: [Intel-gfx] [v3] drm/i915/pps: improve eDP power on flow

2022-11-03 Thread Jani Nikula
On Thu, 03 Nov 2022, Lee Shawn C wrote: > After i915 dirver initialized, a panel power off cycle delay > always append before turn eDP on. If eDP display did not > power on before. With this change, power off duration might > longer than power cycle delay. So driver can save power cycle > delay

  1   2   >