[PATCH 2/5] drm/ttm: return ENOSPC from ttm_bo_mem_space

2024-01-08 Thread Christian König
Only convert it to ENOMEM in ttm_bo_validate. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index edf10618fe2b..8c1eaa74fa21 100644 ---

[PATCH 5/5] drm/amdgpu: use GTT only as fallback for VRAM|GTT

2024-01-08 Thread Christian König
Try to fill up VRAM as well by setting the busy flag on GTT allocations. This fixes the issue that when VRAM was evacuated for suspend it's never filled up again unless the application is restarted. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 6 ++ 1

[PATCH 3/5] drm/ttm: replace busy placement with flags v5

2024-01-08 Thread Christian König
From: Somalapuram Amaranath Instead of a list of separate busy placement add flags which indicate that a placement should only be used when there is room or if we need to evict. v2: add missing TTM_PL_FLAG_IDLE for i915 v3: fix auto build test ERROR on drm-tip/drm-tip v4: fix some typos pointed

[PATCH 4/5] drm/ttm: improve idle/busy handling v2

2024-01-08 Thread Christian König
Previously we would never try to move a BO into the preferred placements when it ever landed in a busy placement since those were considered compatible. Rework the whole handling and finally unify the idle and busy handling. ttm_bo_validate() is now responsible to try idle placement first and

[PATCH 1/5] drm/vmwgfx: remove vmw_vram_gmr_placement

2024-01-08 Thread Christian König
Seems to be unused. Signed-off-by: Christian König --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h| 1 - drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 28 -- 2 files changed, 29 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h

Rework TTMs busy handling

2024-01-08 Thread Christian König
Hi guys, I'm trying to make this functionality a bit more useful for years now since we multiple reports that behavior of drivers can be suboptimal when multiple placements be given. So basically instead of hacking around the TTM behavior in the driver once more I've gone ahead and changed the

RE: [PATCH] drm/i915/display/dp: 128/132b DP-capable with SST

2024-01-08 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Monday, January 8, 2024 7:01 PM > To: Murthy, Arun R ; intel-gfx@lists.freedesktop.org; > Deak, Imre > Cc: Murthy, Arun R > Subject: Re: [PATCH] drm/i915/display/dp: 128/132b DP-capable with SST > > On Wed, 03 Jan 2024, Arun R Murthy

✓ Fi.CI.BAT: success for drm/i915/gt: Use rc6.supported flag from intel_gt for rc6_enable sysfs

2024-01-08 Thread Patchwork
== Series Details == Series: drm/i915/gt: Use rc6.supported flag from intel_gt for rc6_enable sysfs URL : https://patchwork.freedesktop.org/series/128343/ State : success == Summary == CI Bug Log - changes from CI_DRM_14098 -> Patchwork_128343v1

✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Use rc6.supported flag from intel_gt for rc6_enable sysfs

2024-01-08 Thread Patchwork
== Series Details == Series: drm/i915/gt: Use rc6.supported flag from intel_gt for rc6_enable sysfs URL : https://patchwork.freedesktop.org/series/128343/ State : warning == Summary == Error: dim checkpatch failed eb5660834460 drm/i915/gt: Use rc6.supported flag from intel_gt for rc6_enable

✓ Fi.CI.BAT: success for VBT read Cleanup

2024-01-08 Thread Patchwork
== Series Details == Series: VBT read Cleanup URL : https://patchwork.freedesktop.org/series/128341/ State : success == Summary == CI Bug Log - changes from CI_DRM_14098 -> Patchwork_128341v1 Summary --- **SUCCESS** No

✗ Fi.CI.SPARSE: warning for VBT read Cleanup

2024-01-08 Thread Patchwork
== Series Details == Series: VBT read Cleanup URL : https://patchwork.freedesktop.org/series/128341/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[PATCH] drm/i915/gt: Use rc6.supported flag from intel_gt for rc6_enable sysfs

2024-01-08 Thread Juan Escamilla
Currently if rc6 is supported, it gets enabled and the sysfs files for rc6_enable_show and rc6_enable_dev_show uses masks to check information from drm_i915_private. However rc6_support functions take more variables and conditions into consideration and thus these masks are not enough for most of

Re: [PATCH i-g-t] tests/perf_pmu: Restore sysfs freq in exit handler

2024-01-08 Thread Belgaumkar, Vinay
On 1/5/2024 3:33 AM, Kamil Konieczny wrote: Hi Vinay, On 2024-01-04 at 17:10:00 -0800, Vinay Belgaumkar wrote: looks good, there are some nits, first about subject: [PATCH i-g-t] tests/perf_pmu: Restore sysfs freq in exit handler s!tests/perf_pmu:!tests/intel/perf_pmu:! Also you can drop

linux-next: manual merge of the drm-intel tree with Linus' tree

2024-01-08 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/display/intel_dp.c between commit: fc93835bb0d7 ("drm: Add HPD state to drm_connector_oob_hotplug_event()") from Linus' tree and commit: cd572b3bb27e ("drm/i915: Disable hotplug detection

[RFC 06/15] drm/i915: Classify vbt type based on its residence

2024-01-08 Thread Radhakrishna Sripada
Vbt can be read from different sources viz. firmware, opregion, oprom or spi. This will be useful for us to handle the vbt cleanup during bios remove phase. Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/display/intel_bios.c | 15 ---

[RFC 10/15] drm/i915: Move vbt firmware load into intel_bios_init

2024-01-08 Thread Radhakrishna Sripada
Grouping various vbt load options, move vbt load from firmware option from opregion vbt load function to bios init. Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/display/intel_bios.c | 47 ++- drivers/gpu/drm/i915/display/intel_opregion.c | 45

[RFC 03/15] drm/i915: Cache opregion asls pointer

2024-01-08 Thread Radhakrishna Sripada
Asls offset is used to calculate the relative offset of vbt in ASLE mailbox. Cache the address read from PCI config space to use later during vbt extraction. Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/display/intel_opregion.c | 4 +++-

[RFC 07/15] drm/i915: Collate vbt cleanup for different types

2024-01-08 Thread Radhakrishna Sripada
VBT not read from opregion needs to be freed. Vbt read from opregion is simply remapped and hence need to point to NULL. While at it assign the type to NONE VBT type. Free the vbt in other cases. Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/display/intel_bios.c | 20

[RFC 14/15] drm/i915: Kill reduntant vbt_firmware from intel_vbt

2024-01-08 Thread Radhakrishna Sripada
vbt_firmware was used to cache the vbt read from firmware. With introduction of intel_vbt, vbt field is used to cache the firmware read from different sources making vbt_firmware field redundant. Kill this field to simplify intel_vbt structure. Signed-off-by: Radhakrishna Sripada ---

[RFC 04/15] drm/i915: Extract opregion vbt capture to its own function

2024-01-08 Thread Radhakrishna Sripada
As part of opregion setup, vbt is extracted from the opregion. Move the vbt parts of opregion setup into its own function. Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/display/intel_opregion.c | 143 ++ 1 file changed, 76 insertions(+), 67 deletions(-) diff

[RFC 09/15] drm/i915: Move vbt load from opregion to bios init

2024-01-08 Thread Radhakrishna Sripada
Opregion is probed early during the driver bring up and if present, vbt is extracted. Move vbt loading to a more appropriate place during bios init where the vbt is parsed. While at it remove the empty return. Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/display/intel_bios.c

[RFC 13/15] drm/i915: Make intel_load_vbt_firmware operate on intel_vbt

2024-01-08 Thread Radhakrishna Sripada
intel_vbt will be used to cache the vbt read from firmware. Make vbt firmware read variant operate on intel_vbt to cache the fw for future reference. Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/display/intel_bios.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[RFC 15/15] drm/i915: Use vbt type to determine its validity

2024-01-08 Thread Radhakrishna Sripada
We depend on a non null vbt field in intel_vbt to determine if a vbt is read from its source. This may not be foolproof hence rely on vbt->type to determine if vbt is read from a source. Note that this does not determine the validity of read vbt. Signed-off-by: Radhakrishna Sripada ---

[RFC 05/15] drm/i915: Init vbt fields when read from oprom/spi

2024-01-08 Thread Radhakrishna Sripada
For some platforms where vbt does not reside in opregion, vbt needs to be cached for debug purposes. Cache them for future usage. Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/display/intel_bios.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

[RFC 11/15] drm/i915: Make oprom_get_vbt operate on intel_vbt

2024-01-08 Thread Radhakrishna Sripada
Pass newly created intel_vbt to oprom_get_vbt to standardize the signature and naming. vbt_header explicitly called out within the body to avoid confusing with intel_vbt. Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/display/intel_bios.c | 32 +++ 1 file

[RFC 02/15] drm/i915: Move vbt fields from opregion to its own structure

2024-01-08 Thread Radhakrishna Sripada
For discrete cards, vbt need not exist in opregion as in the case with pre opregion platforms. To handle vbt in such cases, move vbt fields in opregion structure to newly introduced vbt structure. This organizes vbt related fields and processed intel_vbt_data under the same structure.

[RFC 12/15] drm/i915: Make spi_oprom_get_vbt operate on intel_vbt

2024-01-08 Thread Radhakrishna Sripada
intel_vbt newly introduced, should be used to cache in the vbt read from spi. Pass intel_vbt to spi read variant to cache intel_vbt for future reference. Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/display/intel_bios.c | 32 +++ 1 file changed, 16

[RFC 01/15] drm/i915: Extract display->vbt_data to a new vbt structure

2024-01-08 Thread Radhakrishna Sripada
Vbt data is scattered to multiple places like vbt_data and opregion vbt fields. Introduce a new structure intel_vbt to collate various vbt fields into one simple structure. This will be used to cache the vbt read from spi flash/oprom as well as the vbt read from opregion and firmware.

[RFC 08/15] drm/i915: Make intel_bios_init operate on intel_vbt

2024-01-08 Thread Radhakrishna Sripada
intel_bios_init previously operated on vbt_header. Make use of the newly introduced intel_vbt to be later streamline different vbt reading methods. Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/display/intel_bios.c | 28 --- 1 file changed, 15 insertions(+),

[RFC 00/15] VBT read Cleanup

2024-01-08 Thread Radhakrishna Sripada
This series does the VBT read cleanup. The series introduces new intel_vbt structure to cache and collate vbt related info. Vbt read from different sources viz. firmware/opregion/spi/oprom needs to be cached for debug purposes and handled accordingly during cleanup. Radhakrishna Sripada (15):

Re: [PATCH] nightly.conf: Add the xe repo to drm-tip

2024-01-08 Thread Lucas De Marchi
On Mon, Jan 08, 2024 at 05:13:51PM -0500, Rodrigo Vivi wrote: On Wed, Jan 03, 2024 at 11:59:16PM -0600, Lucas De Marchi wrote: On Wed, Jan 03, 2024 at 02:50:57PM +0100, Thomas Hellström wrote: > On Tue, 2023-12-26 at 13:30 -0500, Rodrigo Vivi wrote: > > On Fri, Dec 22, 2023 at 12:36:39PM +0100,

Re: [PATCH] drm/xe/display: Disable aux ccs framebuffers

2024-01-08 Thread Rodrigo Vivi
On Tue, Jan 02, 2024 at 09:44:48PM +0200, Jani Nikula wrote: > On Tue, 02 Jan 2024, Juha-Pekka Heikkila wrote: > > Aux ccs framebuffers don't work on Xe driver hence disable them > > from plane capabilities until they are fixed. Flat ccs framebuffers > > work and they are left enabled. Here is

Re: [PATCH] nightly.conf: Add the xe repo to drm-tip

2024-01-08 Thread Rodrigo Vivi
On Wed, Jan 03, 2024 at 02:50:57PM +0100, Thomas Hellström wrote: > On Tue, 2023-12-26 at 13:30 -0500, Rodrigo Vivi wrote: > > On Fri, Dec 22, 2023 at 12:36:39PM +0100, Thomas Hellström wrote: > > > Add the xe repo to drm-tip and the dim tools. > > > For now use the sha1 of the first drm-xe-next

Re: [PATCH] nightly.conf: Add the xe repo to drm-tip

2024-01-08 Thread Rodrigo Vivi
On Wed, Jan 03, 2024 at 11:59:16PM -0600, Lucas De Marchi wrote: > On Wed, Jan 03, 2024 at 02:50:57PM +0100, Thomas Hellström wrote: > > On Tue, 2023-12-26 at 13:30 -0500, Rodrigo Vivi wrote: > > > On Fri, Dec 22, 2023 at 12:36:39PM +0100, Thomas Hellström wrote: > > > > Add the xe repo to drm-tip

Re: ✗ Fi.CI.IGT: failure for Update bxt_sanitize_cdclk() for Xe2_LPD (rev3)

2024-01-08 Thread Matt Roper
On Mon, Jan 08, 2024 at 10:35:56AM -0300, Gustavo Sousa wrote: > Quoting Patchwork (2024-01-05 21:14:37-03:00) > >== Series Details == > > > >Series: Update bxt_sanitize_cdclk() for Xe2_LPD (rev3) > >URL : https://patchwork.freedesktop.org/series/128175/ > >State : failure > > > >== Summary == >

Re: ✗ Fi.CI.IGT: failure for drm/i915: Fix HPD handling during driver init/shutdown (rev2)

2024-01-08 Thread Imre Deak
On Fri, Jan 05, 2024 at 08:38:44AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Fix HPD handling during driver init/shutdown (rev2) > URL : https://patchwork.freedesktop.org/series/128186/ > State : failure Thanks for the review, the patchset is pushed to drm-intel-next

Re: [PATCH 1/3] drm/nouveau: include drm/drm_edid.h only where needed

2024-01-08 Thread Danilo Krummrich
On 1/4/24 21:16, Jani Nikula wrote: Including drm_edid.h from nouveau_connector.h causes the rebuild of 15 files when drm_edid.h is modified, while there are only a few files that actually need to include drm_edid.h. Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc:

Re: ✗ Fi.CI.IGT: failure for Update bxt_sanitize_cdclk() for Xe2_LPD (rev3)

2024-01-08 Thread Gustavo Sousa
Quoting Gustavo Sousa (2024-01-08 14:27:46-03:00) >Quoting Gustavo Sousa (2024-01-08 10:35:56-03:00) >>Quoting Patchwork (2024-01-05 21:14:37-03:00) >>>== Series Details == >>> >>>Series: Update bxt_sanitize_cdclk() for Xe2_LPD (rev3) >>>URL : https://patchwork.freedesktop.org/series/128175/

Re: ✗ Fi.CI.IGT: failure for Update bxt_sanitize_cdclk() for Xe2_LPD (rev3)

2024-01-08 Thread Gustavo Sousa
Quoting Gustavo Sousa (2024-01-08 10:35:56-03:00) >Quoting Patchwork (2024-01-05 21:14:37-03:00) >>== Series Details == >> >>Series: Update bxt_sanitize_cdclk() for Xe2_LPD (rev3) >>URL : https://patchwork.freedesktop.org/series/128175/ >>State : failure >> >>== Summary == >> >>CI Bug Log -

✗ Fi.CI.BAT: failure for drm/xe/display: Disable aux ccs framebuffers (rev3)

2024-01-08 Thread Patchwork
== Series Details == Series: drm/xe/display: Disable aux ccs framebuffers (rev3) URL : https://patchwork.freedesktop.org/series/128122/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14093 -> Patchwork_128122v3 Summary

✗ Fi.CI.IGT: failure for Extend ARL support

2024-01-08 Thread Patchwork
== Series Details == Series: Extend ARL support URL : https://patchwork.freedesktop.org/series/128322/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14092_full -> Patchwork_128322v1_full Summary --- **FAILURE**

✗ Fi.CI.SPARSE: warning for drm/xe/display: Disable aux ccs framebuffers (rev3)

2024-01-08 Thread Patchwork
== Series Details == Series: drm/xe/display: Disable aux ccs framebuffers (rev3) URL : https://patchwork.freedesktop.org/series/128122/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/xe/display: Disable aux ccs framebuffers (rev3)

2024-01-08 Thread Patchwork
== Series Details == Series: drm/xe/display: Disable aux ccs framebuffers (rev3) URL : https://patchwork.freedesktop.org/series/128122/ State : warning == Summary == Error: dim checkpatch failed ce28f70c318a drm/xe/display: Disable aux ccs framebuffers Traceback (most recent call last):

Re: [PATCH v2 1/3] drm/i915/gt: Support fixed CCS mode

2024-01-08 Thread Joonas Lahtinen
Quoting Tvrtko Ursulin (2024-01-05 12:39:31) > > On 04/01/2024 21:23, Andi Shyti wrote: > >>> +void intel_gt_apply_ccs_mode(struct intel_gt *gt) > >>> +{ > >>> + mutex_lock(>ccs.mutex); > >>> + __intel_gt_apply_ccs_mode(gt); > >>> + mutex_unlock(>ccs.mutex); > >>> +} > >>> + > >>> +void

✗ Fi.CI.BAT: failure for drm/i915: clear the QGV mask set by GOP while booting (rev2)

2024-01-08 Thread Patchwork
== Series Details == Series: drm/i915: clear the QGV mask set by GOP while booting (rev2) URL : https://patchwork.freedesktop.org/series/128223/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14093 -> Patchwork_128223v2

Re: [PATCH v1 2/3] drm/i915/xelpg: Extend driver code of Xe_LPG to Xe_LPG+

2024-01-08 Thread Matt Roper
On Mon, Jan 08, 2024 at 05:57:37PM +0530, Haridhar Kalvala wrote: > From: Harish Chegondi > > Xe_LPG+ (IP version 12.74) should take the same general code > paths as Xe_LPG (versions 12.70 and 12.71). > > Xe_LPG+'s workaround list will be handled by the next patch. > > Signed-off-by: Harish

[PATCH] drm/xe/display: Disable aux ccs framebuffers

2024-01-08 Thread Juha-Pekka Heikkila
Aux ccs framebuffers don't work on Xe driver hence disable them from plane capabilities until they are fixed. Flat ccs framebuffers work and they are left enabled. Here is separated plane capabilities check on i915 so it can behave differencly depending on the driver. Closes:

[PATCH] drm/i915: clear the QGV mask set by GOP while booting

2024-01-08 Thread George D Sworo
From: George D Sworo GOP driver in the firmware is masking the QGV points except the one which can provide high Bandwidth required for panel. On boot to the OS the mask is already set, and is not cleared anywhere in the i915 driver even though sagv is enabled. This means Pcode is unable to

✓ Fi.CI.BAT: success for Extend ARL support

2024-01-08 Thread Patchwork
== Series Details == Series: Extend ARL support URL : https://patchwork.freedesktop.org/series/128322/ State : success == Summary == CI Bug Log - changes from CI_DRM_14092 -> Patchwork_128322v1 Summary --- **SUCCESS** No

Re: ✗ Fi.CI.IGT: failure for Update bxt_sanitize_cdclk() for Xe2_LPD (rev3)

2024-01-08 Thread Gustavo Sousa
Quoting Patchwork (2024-01-05 21:14:37-03:00) >== Series Details == > >Series: Update bxt_sanitize_cdclk() for Xe2_LPD (rev3) >URL : https://patchwork.freedesktop.org/series/128175/ >State : failure > >== Summary == > >CI Bug Log - changes from CI_DRM_14080_full -> Patchwork_128175v3_full

✗ Fi.CI.SPARSE: warning for Extend ARL support

2024-01-08 Thread Patchwork
== Series Details == Series: Extend ARL support URL : https://patchwork.freedesktop.org/series/128322/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1: warning:

Re: [PATCH] drm/i915/display/dp: 128/132b DP-capable with SST

2024-01-08 Thread Jani Nikula
On Wed, 03 Jan 2024, Arun R Murthy wrote: > With a value of '0' read from MSTM_CAP register MST to be enabled. > DP2.1 SCR updates the spec for 128/132b DP capable supporting only one > stream and not supporting single stream sideband MSG. > The underlying protocol will be MST to enable use of

✓ Fi.CI.BAT: success for Bigjoiner refactoring (rev2)

2024-01-08 Thread Patchwork
== Series Details == Series: Bigjoiner refactoring (rev2) URL : https://patchwork.freedesktop.org/series/128311/ State : success == Summary == CI Bug Log - changes from CI_DRM_14092 -> Patchwork_128311v2 Summary --- **SUCCESS**

✗ Fi.CI.SPARSE: warning for Bigjoiner refactoring (rev2)

2024-01-08 Thread Patchwork
== Series Details == Series: Bigjoiner refactoring (rev2) URL : https://patchwork.freedesktop.org/series/128311/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1:

✗ Fi.CI.CHECKPATCH: warning for Bigjoiner refactoring (rev2)

2024-01-08 Thread Patchwork
== Series Details == Series: Bigjoiner refactoring (rev2) URL : https://patchwork.freedesktop.org/series/128311/ State : warning == Summary == Error: dim checkpatch failed ed3c2b2b22ef drm/i915: Add bigjoiner force enable option to debugfs 519ee160310d drm/i915/bigjoiner: Refactor bigjoiner

Re: [PATCH 07/12] drm/i915: Prevent modesets during driver init/shutdown

2024-01-08 Thread Hogander, Jouni
On Mon, 2024-01-08 at 11:44 +0200, Hogander, Jouni wrote: > On Mon, 2024-01-08 at 11:20 +0200, Imre Deak wrote: > > On Mon, Jan 08, 2024 at 10:31:07AM +0200, Hogander, Jouni wrote: > > > On Thu, 2024-01-04 at 10:30 +0200, Imre Deak wrote: > > > > > > An unexpected modeset or connector detection

[PATCH v1 2/3] drm/i915/xelpg: Extend driver code of Xe_LPG to Xe_LPG+

2024-01-08 Thread Haridhar Kalvala
From: Harish Chegondi Xe_LPG+ (IP version 12.74) should take the same general code paths as Xe_LPG (versions 12.70 and 12.71). Xe_LPG+'s workaround list will be handled by the next patch. Signed-off-by: Harish Chegondi Signed-off-by: Haridhar Kalvala ---

[PATCH v1 3/3] drm/i915/xelpg: Extend some workarounds/tuning to gfx version 12.74

2024-01-08 Thread Haridhar Kalvala
From: Matt Roper Some of our existing Xe_LPG workarounds and tuning are also applicable to the version 12.74 variant. Extend the condition bounds accordingly. Also fix the comment on Wa_14018575942 while we're at it. v2: Extend some more workarounds (Harish) Signed-off-by: Matt Roper

[PATCH v1 1/3] drm/i915: Add additional ARL PCI IDs

2024-01-08 Thread Haridhar Kalvala
From: Matt Roper Our existing MTL driver handling is also sufficient to handle ARL, so these IDs are simply added to the MTL ID list. Bspec: 55420 Signed-off-by: Matt Roper --- include/drm/i915_pciids.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/drm/i915_pciids.h

[PATCH v1 0/3] Extend ARL support

2024-01-08 Thread Haridhar Kalvala
Some SKUs of Arrow Lake use a slightly newer Xe_LPG+ graphics IP (version 12.74). Add some additional PCI IDs and extend the code to support this newer IP version. The general code flow should continue to match existing MTL and Xe_LPG code paths. Harish Chegondi (1): drm/i915/xelpg: Extend

[PATCH 2/3] drm/i915/bigjoiner: Refactor bigjoiner state readout

2024-01-08 Thread Stanislav Lisovskiy
Don't call enabled_bigjoiner_pipes twice, lets just move intel_get_bigjoiner_config earlier, because it is anyway calling same function. Also cleanup hsw_enabled_transcoders from irrelevant bigjoiner code. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 22

[PATCH 3/3] Start separating pipe vs transcoder set logic for bigjoiner during modeset

2024-01-08 Thread Stanislav Lisovskiy
Handle only bigjoiner masters in skl_commit_modeset_enables/disables, slave crtcs should be handled by master hooks. Same for encoders. That way we can also remove a bunch of checks like intel_crtc_is_bigjoiner_slave. Signed-off-by: Stanislav Lisovskiy ---

[PATCH 1/3] drm/i915: Add bigjoiner force enable option to debugfs

2024-01-08 Thread Stanislav Lisovskiy
For validation purposes, it might be useful to be able to force Bigjoiner mode, even if current dotclock/resolution do not require that. Lets add such to option to debugfs. v2: - Apparently intel_dp_need_bigjoiner can't be used, when debugfs entry is created so lets just check manually

[PATCH 0/3] Bigjoiner refactoring

2024-01-08 Thread Stanislav Lisovskiy
There are few things we need to do for bigjoiner, in order to improve code maintenance and also make testing for Bigjoiner easier. Those series contain addition of bigjoiner force debugfs option, in order to be able to force bigjoiner even if there is no display support, also we refactor pipe vs

RE: [PATCH] drm/i915/display/dp: 128/132b DP-capable with SST

2024-01-08 Thread Murthy, Arun R
> -Original Message- > From: Nautiyal, Ankit K > Sent: Monday, January 8, 2024 5:08 PM > To: Murthy, Arun R ; intel-gfx@lists.freedesktop.org; > Nikula, Jani ; Deak, Imre > Subject: Re: [PATCH] drm/i915/display/dp: 128/132b DP-capable with SST > > > On 1/3/2024 2:37 PM, Arun R Murthy

Re: [PATCH] drm/i915/display/dp: 128/132b DP-capable with SST

2024-01-08 Thread Nautiyal, Ankit K
On 1/3/2024 2:37 PM, Arun R Murthy wrote: With a value of '0' read from MSTM_CAP register MST to be enabled. DP2.1 SCR updates the spec for 128/132b DP capable supporting only one stream and not supporting single stream sideband MSG. I think, we still need to read bit

✗ Fi.CI.BUILD: failure for Bigjoiner refactoring

2024-01-08 Thread Patchwork
== Series Details == Series: Bigjoiner refactoring URL : https://patchwork.freedesktop.org/series/128311/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/128311/revisions/1/mbox/ not applied Applying: drm/i915: Add bigjoiner force enable option to

Re: [PATCH 12/12] drm/i915/dp: Abort AUX on disconnected native DP ports

2024-01-08 Thread Hogander, Jouni
On Thu, 2024-01-04 at 10:30 +0200, Imre Deak wrote: > An AUX transfer on any disconnected DP port results in long > timeout/retry delays the same way as this is described for TypeC port > in > > commit a972cd3f0eb5 ("drm/i915/tc: Abort DP AUX transfer on a > disconnected TC port") > > Prevent

Re: [PATCH 11/12] drm/i915: Filter out glitches on HPD lines during hotplug detection

2024-01-08 Thread Hogander, Jouni
On Thu, 2024-01-04 at 10:30 +0200, Imre Deak wrote: > Glitches deasserting the connector HPD line can lead to incorrectly > detecting a disconnect event (a glitch asserting the line will only > cause a redundant connect->disconnect transition). The source of such > a > glitch can be noise on the

Re: [PATCH 1/3] drm/i915: Add bigjoiner force enable option to debugfs

2024-01-08 Thread Jani Nikula
On Mon, 08 Jan 2024, Stanislav Lisovskiy wrote: > For validation purposes, it might be useful to be able to > force Bigjoiner mode, even if current dotclock/resolution > do not require that. > Lets add such to option to debugfs. > > v2: - Apparently intel_dp_need_bigjoiner can't be used, when >

Re: [PATCH 10/12] drm/i915: Add intel_digital_port lock/unlock hooks

2024-01-08 Thread Hogander, Jouni
On Thu, 2024-01-04 at 10:30 +0200, Imre Deak wrote: > Add hooks to intel_digital_port to lock and unlock the port and add a > helper to check the connector's detect status while the port is > locked > already. This simplifies checking the connector detect status in > intel_dp_aux_xfer() and

Re: [PATCH 09/12] drm/i915: Disable hotplug detection handlers during driver init/shutdown

2024-01-08 Thread Hogander, Jouni
On Thu, 2024-01-04 at 10:30 +0200, Imre Deak wrote: > As described in the previous two patches an unexpected connector > detection can happen during the init/shutdown sequences. Prevent > these > by returning the connector's current status from the detection > handlers. > > Signed-off-by: Imre

Re: [PATCH 07/12] drm/i915: Prevent modesets during driver init/shutdown

2024-01-08 Thread Hogander, Jouni
On Mon, 2024-01-08 at 11:20 +0200, Imre Deak wrote: > On Mon, Jan 08, 2024 at 10:31:07AM +0200, Hogander, Jouni wrote: > > On Thu, 2024-01-04 at 10:30 +0200, Imre Deak wrote: > > > > An unexpected modeset or connector detection by a user (user > > > space > > > or FB console) during the

Re: [PATCH 08/12] drm/i915: Disable hotplug detection works during driver init/shutdown

2024-01-08 Thread Hogander, Jouni
On Thu, 2024-01-04 at 10:30 +0200, Imre Deak wrote: > As described in the previous patch, an unexpected connector > detection/modeset started from the intel_hotplug::hotplug_work can > happen during the driver init/shutdown sequence. Prevent these by > disabling the queuing of and flushing all the

Re: [PATCH 07/12] drm/i915: Prevent modesets during driver init/shutdown

2024-01-08 Thread Imre Deak
On Mon, Jan 08, 2024 at 10:31:07AM +0200, Hogander, Jouni wrote: > On Thu, 2024-01-04 at 10:30 +0200, Imre Deak wrote: > > An unexpected modeset or connector detection by a user (user space > > or FB console) during the initialization/shutdown sequence is > > possible either via a hotplug IRQ

[PATCH 3/3] Start separating pipe vs transcoder set logic for bigjoiner during modeset

2024-01-08 Thread Stanislav Lisovskiy
Handle only bigjoiner masters in skl_commit_modeset_enables/disables, slave crtcs should be handled by master hooks. Same for encoders. That way we can also remove a bunch of checks like intel_crtc_is_bigjoiner_slave. Signed-off-by: Stanislav Lisovskiy ---

[PATCH 2/3] drm/i915/bigjoiner: Refactor bigjoiner state readout

2024-01-08 Thread Stanislav Lisovskiy
Don't call enabled_bigjoiner_pipes twice, lets just move intel_get_bigjoiner_config earlier, because it is anyway calling same function. Also cleanup hsw_enabled_transcoders from irrelevant bigjoiner code. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 22

[PATCH 1/3] drm/i915: Add bigjoiner force enable option to debugfs

2024-01-08 Thread Stanislav Lisovskiy
For validation purposes, it might be useful to be able to force Bigjoiner mode, even if current dotclock/resolution do not require that. Lets add such to option to debugfs. v2: - Apparently intel_dp_need_bigjoiner can't be used, when debugfs entry is created so lets just check manually

[PATCH 0/3] Bigjoiner refactoring

2024-01-08 Thread Stanislav Lisovskiy
There are few things we need to do for bigjoiner, in order to improve code maintenance and also make testing for Bigjoiner easier. Those series contain addition of bigjoiner force debugfs option, in order to be able to force bigjoiner even if there is no display support, also we refactor pipe vs

Re: [PATCH 07/12] drm/i915: Prevent modesets during driver init/shutdown

2024-01-08 Thread Hogander, Jouni
On Thu, 2024-01-04 at 10:30 +0200, Imre Deak wrote: > An unexpected modeset or connector detection by a user (user space or > FB > console) during the initialization/shutdown sequence is possible > either > via a hotplug IRQ handling work or via the connector sysfs > (status/detect) interface.