On 5/17/24 11:00, Guenter Roeck wrote:
On 5/17/24 10:48, Steven Rostedt wrote:
On Fri, 17 May 2024 10:36:37 -0700
Guenter Roeck wrote:
Building csky:allmodconfig (and others) ... failed
--
Error log:
In file included from include/trace/trace_events.h:419,
from
Hi,
On Tue, Mar 05, 2024 at 11:07:35AM +0200, Jani Nikula wrote:
> At least the i915 and amd drivers enable a bunch more compiler warnings
> than the kernel defaults.
>
> Extend most of the W=1 warnings to the entire drm subsystem by
> default. Use the copy-pasted warnings from
On Fri, May 17, 2024 at 11:06:16AM +0200, Andi Shyti wrote:
The whole point of the previous fixes has been to change the CCS
hardware configuration to generate only one stream available to
the compute users. We did this by changing the info.engine_mask
that is set during device probe, reset
Hi Andi,
On 5/17/2024 9:34 PM, Andi Shyti wrote:
Hi Nirmoy,
On Fri, May 17, 2024 at 04:00:02PM +0200, Nirmoy Das wrote:
On 5/17/2024 1:25 PM, Andi Shyti wrote:
If we timeout while waiting for an FLR reset, there is nothing we
can do and i915 doesn't have any control on it. In any case the
Hi Nirmoy,
On Fri, May 17, 2024 at 04:00:02PM +0200, Nirmoy Das wrote:
> On 5/17/2024 1:25 PM, Andi Shyti wrote:
> > If we timeout while waiting for an FLR reset, there is nothing we
> > can do and i915 doesn't have any control on it. In any case the
> > system is still perfectly usable
>
> If a
== Series Details ==
Series: drm/i915: Plane register cleanups (rev2)
URL : https://patchwork.freedesktop.org/series/133701/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14783 -> Patchwork_133701v2
Summary
---
== Series Details ==
Series: drm/i915: Plane register cleanups (rev2)
URL : https://patchwork.freedesktop.org/series/133701/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: Plane register cleanups (rev2)
URL : https://patchwork.freedesktop.org/series/133701/
State : warning
== Summary ==
Error: dim checkpatch failed
6b9d030f5372 drm/i915: Add skl+ plane name aliases to enum plane_id
e764cc62d70e drm/i915: Clean up the
On 5/17/24 10:48, Steven Rostedt wrote:
On Fri, 17 May 2024 10:36:37 -0700
Guenter Roeck wrote:
Building csky:allmodconfig (and others) ... failed
--
Error log:
In file included from include/trace/trace_events.h:419,
from include/trace/define_trace.h:102,
On Fri, 17 May 2024 10:36:37 -0700
Guenter Roeck wrote:
> Building csky:allmodconfig (and others) ... failed
> --
> Error log:
> In file included from include/trace/trace_events.h:419,
> from include/trace/define_trace.h:102,
> from
On Thu, May 16, 2024 at 01:34:54PM -0400, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)"
>
> [
>This is a treewide change. I will likely re-create this patch again in
>the second week of the merge window of v6.10 and submit it then. Hoping
>to keep the conflicts that it will
== Series Details ==
Series: Improve drm printer code (rev2)
URL : https://patchwork.freedesktop.org/series/133749/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14782 -> Patchwork_133749v2
Summary
---
**SUCCESS**
From: Ville Syrjälä
Using PLANE_PRIMARY + PLANE_SPRITE? on skl+ results in a bunch
of unnecessary head scratching. Add aliases using the skl+ plane
names.
And for pre-skl we only need to keep PRIMARY,SPRITE0,SPRITE1
as we only ever have 0-2 sprites per pipe on those platforms.
v2: Don't break
== Series Details ==
Series: Improve drm printer code (rev2)
URL : https://patchwork.freedesktop.org/series/133749/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: Improve drm printer code (rev2)
URL : https://patchwork.freedesktop.org/series/133749/
State : warning
== Summary ==
Error: dim checkpatch failed
3274a9b5ce18 drm/print: Add generic drm dev printk function
-:46: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should
With recent introduction of a generic drm dev printk function, we
can now store and use location where drm_dbg_printer was invoked
and output it's symbolic name like we do for all drm debug prints.
Cc: Jani Nikula
Reviewed-by: Jani Nikula
Signed-off-by: Michal Wajdeczko
---
v2: use full cast
Updated code of drm_dbg_printer() is already printing symbolic
name of the caller like drm_dbg() does.
Reviewed-by: Jani Nikula
Signed-off-by: Michal Wajdeczko
---
drivers/gpu/drm/i915/gt/intel_reset.c | 2 +-
drivers/gpu/drm/i915/gt/selftest_context.c | 2 +-
2 files changed, 2
We already have some drm printk functions that need to duplicate
a code to get a similar format of the final result, for example:
[ ] :00:00.0: [drm:foo] bar
[ ] :00:00.0: [drm] foo bar
[ ] :00:00.0: [drm] *ERROR* foo
Add a generic __drm_dev_vprintk() function that can format
We already have some drm printk functions that need to duplicate
a code to get a similar format of the final result, for example:
[ ] :00:00.0: [drm:foo] bar
[ ] :00:00.0: [drm] foo bar
[ ] :00:00.0: [drm] *ERROR* foo
Add a generic __drm_dev_vprintk() function that can format
On Thu, May 16, 2024 at 01:34:54PM -0400, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)"
>
> [
>This is a treewide change. I will likely re-create this patch again in
>the second week of the merge window of v6.10 and submit it then. Hoping
>to keep the conflicts that it will
== Series Details ==
Series: drm/i915: DSC stuff
URL : https://patchwork.freedesktop.org/series/133758/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14781 -> Patchwork_133758v1
Summary
---
**FAILURE**
Serious
On Fri, May 17, 2024 at 06:33:46PM +0300, Jani Nikula wrote:
> On Thu, 16 May 2024, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > Using PLANE_PRIMARY + PLANE_SPRITE? on skl+ results in a bunch
> > of unnecessary head scratching. Add aliases using the skl+ plane
> > names.
> > And for
On 17.05.2024 15:33, Jani Nikula wrote:
> On Fri, 17 May 2024, Michal Wajdeczko wrote:
>> We already have some drm printk functions that need to duplicate
>> a code to get a similar format of the final result, for example:
>>
>> [ ] :00:00.0: [drm:foo] bar
>> [ ] :00:00.0: [drm]
== Series Details ==
Series: drm/ci: uprev mesa/IGT and generate testlist
URL : https://patchwork.freedesktop.org/series/133735/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14779_full -> Patchwork_133735v1_full
Summary
== Series Details ==
Series: drm/i915: DSC stuff
URL : https://patchwork.freedesktop.org/series/133758/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+./arch/x86/include/asm/bitops.h:116:1: warning:
On Thu, 16 May 2024, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Using PLANE_PRIMARY + PLANE_SPRITE? on skl+ results in a bunch
> of unnecessary head scratching. Add aliases using the skl+ plane
> names.
> And for pre-skl we only need to keep PRIMARY,SPRITE0,SPRITE1
> as we only ever have 0-2
From: Ville Syrjälä
Disable eDP DSC usage when instructed to do so by the VBT.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_bios.c | 4
drivers/gpu/drm/i915/display/intel_display_types.h | 1 +
drivers/gpu/drm/i915/display/intel_dp.c| 4
3
From: Ville Syrjälä
No idea what this MST checks is doing in intel_dp_has_audio().
Looks completely pointless, so get rid of it.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_dp.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
From: Ville Syrjälä
intel_dp_supports_dsc() now works for MST as well, reuse it.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_dp.c | 4 ++--
drivers/gpu/drm/i915/display/intel_dp.h | 3 +++
drivers/gpu/drm/i915/display/intel_dp_mst.c | 20
From: Ville Syrjälä
Reuse intel_dp_has_dsc() during .compute_config() instead of
repeating some of the checks again by hand. We'll be adding
more checks to intel_dp_has_dsc() and this will make sure
we cover both .mode_valid() and .compute_config() with them.
Signed-off-by: Ville Syrjälä
---
From: Ville Syrjälä
Extract a helper to check whether the source+sink combo
supports DSC. That basic check is needed both during mode
validation and compute config. We'll also need to add extra
checks to both places, so having a single place for it is nicer.
Signed-off-by: Ville Syrjälä
---
From: Ville Syrjälä
Utilize intel_dp_has_dsc() for MST as well.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_dp.c | 5 -
drivers/gpu/drm/i915/display/intel_dp.h | 1 +
drivers/gpu/drm/i915/display/intel_dp_mst.c | 3 +--
3 files changed, 6 insertions(+), 3
From: Ville Syrjälä
If we have no dsc_decompression_aux (only possible on MST)
then we won't have the dsc_dpcd caps either. So checking
both is not needed.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_dp.c | 1 -
1 file changed, 1 deletion(-)
diff --git
From: Ville Syrjälä
Respect the VBT's edp_disable_dsc bit, and do a bunch
of refactoring around checking for DSC support.
Also threw in a bonus cleanup to intel_dp_has_audio()
that caught my eye.
Ville Syrjälä (7):
drm/i915: Drop redundant dsc_decompression_aux check
drm/i915: Extract
== Series Details ==
Series: drm/i915/gt: Fix CCS id's calculation for CCS mode setting
URL : https://patchwork.freedesktop.org/series/133732/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14779_full -> Patchwork_133732v1_full
== Series Details ==
Series: Improve drm printer code
URL : https://patchwork.freedesktop.org/series/133749/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14781 -> Patchwork_133749v1
Summary
---
**SUCCESS**
No
== Series Details ==
Series: Improve drm printer code
URL : https://patchwork.freedesktop.org/series/133749/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: Improve drm printer code
URL : https://patchwork.freedesktop.org/series/133749/
State : warning
== Summary ==
Error: dim checkpatch failed
6cab5b4517bb drm/print: Add generic drm dev printk function
-:64: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include
Hi Andi,
On 5/17/2024 1:25 PM, Andi Shyti wrote:
If we timeout while waiting for an FLR reset, there is nothing we
can do and i915 doesn't have any control on it. In any case the
system is still perfectly usable
If a FLR reset fails then we will have a dead GPU, I don't think the GPU
is
Hi,
On 5/17/24 11:14 AM, Thomas Zimmermann wrote:
> Commit 2fd001cd3600 ("arch: Rename fbdev header and source files")
> renames the video source files under arch/ such that they do not
> refer to fbdev any longer. The new files named video.o conflict with
> ACPI's video.ko module. Modprobing the
On Fri, 17 May 2024, Michal Wajdeczko wrote:
> Updated code of drm_dbg_printer() is already printing symbolic
> name of the caller like drm_dbg() does.
>
> Signed-off-by: Michal Wajdeczko
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/gt/intel_reset.c | 2 +-
>
On Fri, 17 May 2024, Michal Wajdeczko wrote:
> With recent introduction of a generic drm dev printk function, we
> can now store and use location where drm_dbg_printer was invoked
> and output it's symbolic name like we do for all drm debug prints.
>
> Signed-off-by: Michal Wajdeczko
> Cc: Jani
== Series Details ==
Series: LunarLake IO and Fast Wake changes
URL : https://patchwork.freedesktop.org/series/133728/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14779_full -> Patchwork_133728v1_full
Summary
---
On Fri, 17 May 2024, Michal Wajdeczko wrote:
> We already have some drm printk functions that need to duplicate
> a code to get a similar format of the final result, for example:
>
> [ ] :00:00.0: [drm:foo] bar
> [ ] :00:00.0: [drm] foo bar
> [ ] :00:00.0: [drm] *ERROR* foo
>
>
Updated code of drm_dbg_printer() is already printing symbolic
name of the caller like drm_dbg() does.
Signed-off-by: Michal Wajdeczko
---
drivers/gpu/drm/i915/gt/intel_reset.c | 2 +-
drivers/gpu/drm/i915/gt/selftest_context.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff
We already have some drm printk functions that need to duplicate
a code to get a similar format of the final result, for example:
[ ] :00:00.0: [drm:foo] bar
[ ] :00:00.0: [drm] foo bar
[ ] :00:00.0: [drm] *ERROR* foo
Add a generic __drm_dev_vprintk() function that can format
With recent introduction of a generic drm dev printk function, we
can now store and use location where drm_dbg_printer was invoked
and output it's symbolic name like we do for all drm debug prints.
Signed-off-by: Michal Wajdeczko
Cc: Jani Nikula
---
drivers/gpu/drm/drm_print.c | 3 +--
We already have some drm printk functions that need to duplicate
a code to get a similar format of the final result, for example:
[ ] :00:00.0: [drm:foo] bar
[ ] :00:00.0: [drm] foo bar
[ ] :00:00.0: [drm] *ERROR* foo
Add a generic __drm_dev_vprintk() function that can format
On Tue, May 07, 2024 at 09:20:37AM +0530, Suraj Kandpal wrote:
> Check mst_port field in intel_connector to check connector type
> rather than rely on encoder as it may not be attached to connector
> at times.
>
> Signed-off-by: Suraj Kandpal
> ---
> drivers/gpu/drm/i915/display/intel_dp_hdcp.c
On 5/17/2024 1:53 PM, Jani Nikula wrote:
On Fri, 17 May 2024, Nirmoy Das wrote:
Hi Jani,
On 5/17/2024 9:39 AM, Jani Nikula wrote:
On Thu, 16 May 2024, Nirmoy Das wrote:
The previous commit 'commit 8d4ba9fc1c6c ("drm/i915/selftests: Pick
"previous commit" is a fairly vague reference once
== Series Details ==
Series: Don't be alarmed at FLR timeouts
URL : https://patchwork.freedesktop.org/series/133744/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14780 -> Patchwork_133744v1
Summary
---
**SUCCESS**
On Fri, 17 May 2024, Nirmoy Das wrote:
> Hi Jani,
>
> On 5/17/2024 9:39 AM, Jani Nikula wrote:
>> On Thu, 16 May 2024, Nirmoy Das wrote:
>>> The previous commit 'commit 8d4ba9fc1c6c ("drm/i915/selftests: Pick
>> "previous commit" is a fairly vague reference once this gets
>> committed. It's not
If we timeout while waiting for an FLR reset, there is nothing we
can do and i915 doesn't have any control on it. In any case the
system is still perfectly usable and the function returns void.
We don't need to be alarmed, therefore, print the timeout
expiration as a debug message instead of an
Following the guidelines it takes 3 seconds to perform an FLR
reset. Let's give it a bit more slack because this time can
change depending on the platform and on the firmware
Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10955
Signed-off-by: Andi Shyti
---
Hi,
often, on new platforms or firmware updates, we receive reports
of FLR timeout expiration and we shift the timeout we wait for
the reset to complete.
Let's not be alarmed if we reach a timeout while waiting for FLR
resets and print debugs rather than errors. The function is
anyway a void
== Series Details ==
Series: drm/ci: uprev mesa/IGT and generate testlist
URL : https://patchwork.freedesktop.org/series/133735/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14779 -> Patchwork_133735v1
Summary
---
> -Original Message-
> From: Intel-gfx On Behalf Of Mitul
> Golani
> Sent: Thursday, May 9, 2024 1:28 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Shankar, Uma ; Nikula, Jani
>
> Subject: [PATCH v8 3/7] drm/i915: Compute CMRR and calculate vtotal
>
> Compute Fixed Average
Hi,
On Fri, May 17, 2024 at 11:06:16AM +0200, Andi Shyti wrote:
> The whole point of the previous fixes has been to change the CCS
> hardware configuration to generate only one stream available to
> the compute users. We did this by changing the info.engine_mask
> that is set during device probe,
Hi Nirmoy,
On Thu, May 16, 2024 at 05:14:03PM +0200, Nirmoy Das wrote:
> The previous commit 'commit 8d4ba9fc1c6c ("drm/i915/selftests: Pick
> correct caching mode.")' was not complete as for non LLC sharing platforms
> cpu read can happen from LLC which probably doesn't have the latest
>
== Series Details ==
Series: drm/probe-helper: Call drm_mode_validate_ycbcr420() before
connector->mode_valid() (rev3)
URL : https://patchwork.freedesktop.org/series/133709/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14777_full -> Patchwork_133709v3_full
== Series Details ==
Series: drm/i915/gt: Fix CCS id's calculation for CCS mode setting
URL : https://patchwork.freedesktop.org/series/133732/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14779 -> Patchwork_133732v1
== Series Details ==
Series: drm/i915: Bump max TMDS bitrate to 6 Gbps on ADL/DG2+
URL : https://patchwork.freedesktop.org/series/133716/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14777_full -> Patchwork_133716v1_full
== Series Details ==
Series: drm/ci: uprev mesa/IGT and generate testlist
URL : https://patchwork.freedesktop.org/series/133735/
State : warning
== Summary ==
Error: dim checkpatch failed
f4f172f649c7 drm/ci: uprev mesa version
34b9ee949713 drm/ci: generate testlist from build
-:100:
On Thu, 16 May 2024 19:34:54 +0200,
Steven Rostedt wrote:
>
> From: "Steven Rostedt (Google)"
>
> [
>This is a treewide change. I will likely re-create this patch again in
>the second week of the merge window of v6.10 and submit it then. Hoping
>to keep the conflicts that it will
On Thu, May 16, 2024 at 7:35 PM Steven Rostedt wrote:
>
> From: "Steven Rostedt (Google)"
>
> [
>This is a treewide change. I will likely re-create this patch again in
>the second week of the merge window of v6.10 and submit it then. Hoping
>to keep the conflicts that it will cause
== Series Details ==
Series: arch: Fix name collision with ACPI's video.o
URL : https://patchwork.freedesktop.org/series/133734/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/133734/revisions/1/mbox/ not
applied
Applying: arch: Fix name
== Series Details ==
Series: drm/i915/gt: Fix CCS id's calculation for CCS mode setting
URL : https://patchwork.freedesktop.org/series/133732/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/gt: Fix CCS id's calculation for CCS mode setting
URL : https://patchwork.freedesktop.org/series/133732/
State : warning
== Summary ==
Error: dim checkpatch failed
149a7fb4a88d drm/i915/gt: Fix CCS id's calculation for CCS mode setting
-:79:
Now the testlist is used from IGT build, so update
xfails with the new testlist.
Set the timeout of all i915 jobs to 1h30m since some jobs
takes more than 1 hour to complete.
Signed-off-by: Vignesh Raman
---
v2:
- Set the timeout of all i915 jobs to 1h30m and updated expectations file.
---
Skip driver specific tests and skip kms tests for
panfrost driver since it is not a kms driver.
Signed-off-by: Vignesh Raman
---
v2:
- Skip xe tests for amdgpu and virtio.
---
.../gpu/drm/ci/xfails/amdgpu-stoney-skips.txt | 15 ++-
drivers/gpu/drm/ci/xfails/i915-amly-skips.txt
test-list.txt and test-list-full.txt are not generated for
cross-builds and they are required by drm-ci for testing
arm32 targets.
This is fixed in igt-gpu-tools. So uprev IGT to include the
commit which fixes this issue. Disable building xe driver
tests for non-intel platforms.
Signed-off-by:
With latest IGT, the tests tries to load the module and it
fails. So build the virtual GPU driver for virtio as module.
Signed-off-by: Vignesh Raman
---
v2:
- No changes.
---
drivers/gpu/drm/ci/build.sh | 1 -
drivers/gpu/drm/ci/igt_runner.sh | 6 +++---
Stop vendoring the testlist into the kernel. Instead, use the
testlist from the IGT build to ensure we do not miss renamed
or newly added tests.
Signed-off-by: Vignesh Raman
---
v2:
- Fix testlist generation for arm and arm64 builds.
---
drivers/gpu/drm/ci/build-igt.sh | 34 +
zlib.net is not allowing tarball download anymore and results
in below error in kernel+rootfs_arm32 container build,
urllib.error.HTTPError: HTTP Error 403: Forbidden
urllib.error.HTTPError: HTTP Error 415: Unsupported Media Type
Uprev mesa to latest version which includes a fix for this issue.
Uprev mesa and IGT to the latest version and stop vendoring the
testlist into the kernel. Instead, use the testlist from the
IGT build to ensure we do not miss renamed or newly added tests.
Update the xfails with the latest testlist run.
Also build virtual GPU driver for virtio as module.
The
== Series Details ==
Series: LunarLake IO and Fast Wake changes
URL : https://patchwork.freedesktop.org/series/133728/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14779 -> Patchwork_133728v1
Summary
---
Commit 2fd001cd3600 ("arch: Rename fbdev header and source files")
renames the video source files under arch/ such that they do not
refer to fbdev any longer. The new files named video.o conflict with
ACPI's video.ko module. Modprobing the ACPI module can then fail with
warnings about missing
The whole point of the previous fixes has been to change the CCS
hardware configuration to generate only one stream available to
the compute users. We did this by changing the info.engine_mask
that is set during device probe, reset during the detection of
the fused engines, and finally reset again
== Series Details ==
Series: drm/i915/selftests: Set always_coherent to false when reading from CPU
URL : https://patchwork.freedesktop.org/series/133704/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14775_full -> Patchwork_133704v1_full
Hi Jani,
On 5/17/2024 9:39 AM, Jani Nikula wrote:
On Thu, 16 May 2024, Nirmoy Das wrote:
The previous commit 'commit 8d4ba9fc1c6c ("drm/i915/selftests: Pick
"previous commit" is a fairly vague reference once this gets
committed. It's not going to be "previous" in any meaningful sense.
== Series Details ==
Series: LunarLake IO and Fast Wake changes
URL : https://patchwork.freedesktop.org/series/133728/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+./arch/x86/include/asm/bitops.h:116:1:
== Series Details ==
Series: LunarLake IO and Fast Wake changes
URL : https://patchwork.freedesktop.org/series/133728/
State : warning
== Summary ==
Error: dim checkpatch failed
433dcbf5f0b3 drm/i915/psr: LunarLake IO and Fast Wake time line count maximums
are 68
bd0ec1a85c93 drm/i915/psr:
> -Original Message-
> From: Hogander, Jouni
> Sent: Friday, May 17, 2024 1:02 PM
> To: Shankar, Uma ; intel-gfx@lists.freedesktop.org
> Subject: Re: [PATCH 1/3] drm/i915/psr: LunarLake IO and Fast Wake time line
> count maximums are 63
>
> On Fri, 2024-05-17 at 06:28 +, Shankar,
> -Original Message-
> From: Hogander, Jouni
> Sent: Friday, May 17, 2024 1:00 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Shankar, Uma ; Hogander, Jouni
>
> Subject: [PATCH v2 1/3] drm/i915/psr: LunarLake IO and Fast Wake time line
> count maximums are 68
>
> On LunarLake maximum
On Thu, 16 May 2024, Nirmoy Das wrote:
> The previous commit 'commit 8d4ba9fc1c6c ("drm/i915/selftests: Pick
"previous commit" is a fairly vague reference once this gets
committed. It's not going to be "previous" in any meaningful sense.
Please just start with:
Commit 8d4ba9fc1c6c
On Fri, 2024-05-17 at 06:28 +, Shankar, Uma wrote:
>
>
> > -Original Message-
> > From: Intel-gfx On Behalf
> > Of Jouni
> > Högander
> > Sent: Friday, May 3, 2024 11:36 AM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: Hogander, Jouni
> > Subject: [PATCH 1/3] drm/i915/psr:
There are some changes in LunarLake IO and Fast Wake configuration:
IO Wake Lines configuration is now 6 bits wide
Fast Wake Lines configuration is now 6 bits wide and in ALPM_CTL register
PSR2_CTL[Block count number] is not valid for LunarLake and onwards
This patch set modifies the driver
PSR2_CTL[Block Count Number] is not used by LunarLake do not configure it.
Bspec: 69885
Signed-off-by: Jouni Högander
Reviewed-by: Uma Shankar
---
drivers/gpu/drm/i915/display/intel_psr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On LunarLake maximum for IO and Fast Wake time line counts are 68: 6 bits +
5 lines added by the HW. Take this into account in calculation and when
writing the IO Wake lines.
v2: maximum line count is 68 (6 bits + 5 lines added by HW)
Signed-off-by: Jouni Högander
---
On LunarLake PSR2_CTL[IO Wake Lines] contains now bit 13:18. Take this
into account when enabling PSR2_CTL.
Bspec: 69885
Signed-off-by: Jouni Högander
Reviewed-by: Uma Shankar
---
drivers/gpu/drm/i915/display/intel_psr.c | 2 ++
drivers/gpu/drm/i915/display/intel_psr_regs.h | 4
2
> -Original Message-
> From: Intel-gfx On Behalf Of Jouni
> Högander
> Sent: Friday, May 3, 2024 11:36 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: Hogander, Jouni
> Subject: [PATCH 3/3] drm/i915/psr: PSR2_CTL[Block Count Number] no needed
> for LunarLake
Nit: s/no/not
Looks Good
> -Original Message-
> From: Intel-gfx On Behalf Of Jouni
> Högander
> Sent: Friday, May 3, 2024 11:36 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: Hogander, Jouni
> Subject: [PATCH 2/3] drm/i915/psr: LunarLake PSR2_CTL[IO Wake Lines] is 6 bits
> wide
>
> On LunarLake PSR2_CTL[IO
> -Original Message-
> From: Intel-gfx On Behalf Of Jouni
> Högander
> Sent: Friday, May 3, 2024 11:36 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: Hogander, Jouni
> Subject: [PATCH 1/3] drm/i915/psr: LunarLake IO and Fast Wake time line count
> maximums are 63
>
> On LunarLake
93 matches
Mail list logo
