[Intel-gfx] [CI 2/2] drm/i915/dmc: Change intel_get_stepping_info()

2021-07-19 Thread Anusha Srivatsa
Lets use RUNTIME_INFO->step since all platforms now have their stepping info in intel_step.c. This makes intel_get_stepping_info() a lot simpler. Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_dmc.c |

[Intel-gfx] [CI 1/2] drm/i915/step: Add macro magic for handling steps

2021-07-19 Thread Anusha Srivatsa
With the addition of stepping info for all platforms, lets use macros for handling them and autogenerating code for all steps at a time. Suggested-by: Matt Roper Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/intel_step.c | 14

[Intel-gfx] [CI 2/2] drm/i915/dmc: Change intel_get_stepping_info()

2021-07-19 Thread Anusha Srivatsa
Lets use RUNTIME_INFO->step since all platforms now have their stepping info in intel_step.c. This makes intel_get_stepping_info() a lot simpler. Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_dmc.c |

[Intel-gfx] [CI 1/2] drm/i915/step: Add macro magic for handling steps

2021-07-19 Thread Anusha Srivatsa
With the addition of stepping info for all platforms, lets use macros for handling them and autogenerating code for all steps at a time. Suggested-by: Matt Roper Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/intel_step.c | 14

Re: [Intel-gfx] [PATCH v2 39/50] drm/i915/dg2: Don't read DRAM info

2021-07-15 Thread Srivatsa, Anusha
> -Original Message- > From: Roper, Matthew D > Sent: Tuesday, July 13, 2021 8:15 PM > To: intel-gfx@lists.freedesktop.org > Cc: Roper, Matthew D ; Srivatsa, Anusha > > Subject: [PATCH v2 39/50] drm/i915/dg2: Don't read DRAM info > > DG2 does not

[Intel-gfx] [PATCH 2/2] drm/i915/dmc: Change intel_get_stepping_info()

2021-07-14 Thread Anusha Srivatsa
Lets use RUNTIME_INFO->step since all platforms now have their stepping info in intel_step.c. This makes intel_get_stepping_info() a lot simpler. Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dmc.c | 50 1 file changed

[Intel-gfx] [PATCH 1/2] drm/i915/step: Add macro magic for handling steps

2021-07-14 Thread Anusha Srivatsa
With the addition of stepping info for all platforms, lets use macros for handling them and autogenerating code for all steps at a time. Suggested-by: Matt Roper Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/intel_step.c | 14 drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v3 10/12] drm/i915/dg1: Use revid->stepping tables

2021-07-13 Thread Srivatsa, Anusha
> -Original Message- > From: Roper, Matthew D > Sent: Tuesday, July 13, 2021 10:29 AM > To: intel-gfx@lists.freedesktop.org > Cc: Srivatsa, Anusha ; Roper, Matthew D > > Subject: [PATCH v3 10/12] drm/i915/dg1: Use revid->stepping tables > > Switch DG1

Re: [Intel-gfx] [PATCH v2 04/12] drm/i915/kbl: Drop pre-production revision from stepping table

2021-07-13 Thread Srivatsa, Anusha
> -Original Message- > From: Roper, Matthew D > Sent: Friday, July 9, 2021 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Srivatsa, Anusha ; Roper, Matthew D > > Subject: [PATCH v2 04/12] drm/i915/kbl: Drop pre-production revision from > stepping ta

Re: [Intel-gfx] [PATCH v2 02/12] drm/i915: Make pre-production detection use direct revid comparison

2021-07-13 Thread Srivatsa, Anusha
> -Original Message- > From: Roper, Matthew D > Sent: Friday, July 9, 2021 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Srivatsa, Anusha ; Roper, Matthew D > > Subject: [PATCH v2 02/12] drm/i915: Make pre-production detection use > direct revid compar

Re: [Intel-gfx] [PATCH v2 12/12] drm/i915/icl: Drop workarounds that only apply to pre-production steppings

2021-07-13 Thread Srivatsa, Anusha
> -Original Message- > From: Roper, Matthew D > Sent: Friday, July 9, 2021 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Srivatsa, Anusha ; Roper, Matthew D > > Subject: [PATCH v2 12/12] drm/i915/icl: Drop workarounds that only apply to > pre-production s

Re: [Intel-gfx] [PATCH v2 10/12] drm/i915/dg1: Use revid->stepping tables

2021-07-13 Thread Srivatsa, Anusha
> -Original Message- > From: Roper, Matthew D > Sent: Friday, July 9, 2021 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Srivatsa, Anusha ; Roper, Matthew D > > Subject: [PATCH v2 10/12] drm/i915/dg1: Use revid->stepping tables > > Switch DG1

Re: [Intel-gfx] [PATCH v2 09/12] drm/i915/rkl: Use revid->stepping tables

2021-07-13 Thread Srivatsa, Anusha
> -Original Message- > From: Roper, Matthew D > Sent: Monday, July 12, 2021 3:56 PM > To: Srivatsa, Anusha > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH v2 09/12] drm/i915/rkl: Use revid->stepping tables > > On Mon, Jul 12, 2021 at 03:51:1

Re: [Intel-gfx] [PATCH v3 08/12] drm/i915/jsl_ehl: Use revid->stepping tables

2021-07-13 Thread Srivatsa, Anusha
> -Original Message- > From: Roper, Matthew D > Sent: Tuesday, July 13, 2021 9:15 AM > To: intel-gfx@lists.freedesktop.org > Cc: Srivatsa, Anusha ; Roper, Matthew D > > Subject: [PATCH v3 08/12] drm/i915/jsl_ehl: Use revid->stepping tables > > Switch JS

Re: [Intel-gfx] [PATCH v2 05/12] drm/i915/bxt: Use revid->stepping tables

2021-07-12 Thread Srivatsa, Anusha
> -Original Message- > From: Roper, Matthew D > Sent: Friday, July 9, 2021 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Srivatsa, Anusha ; Roper, Matthew D > > Subject: [PATCH v2 05/12] drm/i915/bxt: Use revid->stepping tables > > Switch BXT

Re: [Intel-gfx] [PATCH v2 03/12] drm/i915/skl: Use revid->stepping tables

2021-07-12 Thread Srivatsa, Anusha
> -Original Message- > From: Roper, Matthew D > Sent: Friday, July 9, 2021 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Srivatsa, Anusha ; Roper, Matthew D > > Subject: [PATCH v2 03/12] drm/i915/skl: Use revid->stepping tables > > Switch SKL

Re: [Intel-gfx] [PATCH v2 11/12] drm/i915/cnl: Drop all workarounds

2021-07-12 Thread Srivatsa, Anusha
> -Original Message- > From: Roper, Matthew D > Sent: Friday, July 9, 2021 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Srivatsa, Anusha ; Roper, Matthew D > > Subject: [PATCH v2 11/12] drm/i915/cnl: Drop all workarounds > > All of the Cannon Lake

Re: [Intel-gfx] [PATCH v2 09/12] drm/i915/rkl: Use revid->stepping tables

2021-07-12 Thread Srivatsa, Anusha
> -Original Message- > From: Roper, Matthew D > Sent: Friday, July 9, 2021 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Srivatsa, Anusha ; Roper, Matthew D > > Subject: [PATCH v2 09/12] drm/i915/rkl: Use revid->stepping tables > > Switch RKL

Re: [Intel-gfx] [PATCH v2 08/12] drm/i915/jsl_ehl: Use revid->stepping tables

2021-07-12 Thread Srivatsa, Anusha
> -Original Message- > From: Roper, Matthew D > Sent: Friday, July 9, 2021 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Srivatsa, Anusha ; Roper, Matthew D > > Subject: [PATCH v2 08/12] drm/i915/jsl_ehl: Use revid->stepping tables > > Switch JS

Re: [Intel-gfx] [PATCH v2 06/12] drm/i915/glk: Use revid->stepping tables

2021-07-12 Thread Srivatsa, Anusha
> -Original Message- > From: Roper, Matthew D > Sent: Friday, July 9, 2021 8:37 PM > To: intel-gfx@lists.freedesktop.org > Cc: Srivatsa, Anusha ; Roper, Matthew D > > Subject: [PATCH v2 06/12] drm/i915/glk: Use revid->stepping tables > > Switch GLK

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Make pre-production detection use direct revid comparison

2021-07-12 Thread Srivatsa, Anusha
> -Original Message- > From: Roper, Matthew D > Sent: Friday, July 9, 2021 8:43 PM > To: Srivatsa, Anusha > Cc: intel-gfx@lists.freedesktop.org; Jani Nikula > Subject: Re: [Intel-gfx] [PATCH 1/7] drm/i915: Make pre-production > detection use direct revid compar

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Make pre-production detection use direct revid comparison

2021-07-12 Thread Srivatsa, Anusha
> -Original Message- > From: Roper, Matthew D > Sent: Friday, July 9, 2021 8:43 PM > To: Srivatsa, Anusha > Cc: intel-gfx@lists.freedesktop.org; Jani Nikula > Subject: Re: [Intel-gfx] [PATCH 1/7] drm/i915: Make pre-production > detection use direct revid compar

Re: [Intel-gfx] [PATCH 09/10] drm/i915/step: Add intel_step_name() helper

2021-07-09 Thread Srivatsa, Anusha
> -Original Message- > From: De Marchi, Lucas > Sent: Friday, July 9, 2021 10:53 AM > To: Roper, Matthew D > Cc: Srivatsa, Anusha ; intel- > g...@lists.freedesktop.org; Jani Nikula > Subject: Re: [Intel-gfx] [PATCH 09/10] drm/i915/step: Add intel_step_name() >

[Intel-gfx] [PATCH 09/10] drm/i915/step: Add intel_step_name() helper

2021-07-08 Thread Anusha Srivatsa
Add a helper to convert the step info to string. This is specifically useful when we want to load a specific firmware for a given stepping/substepping combination. Suggested-by: Jani Nikula Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/intel_step.c | 58

[Intel-gfx] [PATCH 07/10] drm/i915/cnl: Drop all workarounds

2021-07-08 Thread Anusha Srivatsa
From: Matt Roper All of the Cannon Lake hardware that came out had graphics fused off, and our userspace drivers have already dropped their support for the platform; CNL-specific code in i915 that isn't inherited by subsequent platforms is effectively dead code. Let's remove all of the

[Intel-gfx] [PATCH 05/10] drm/i915/rkl: Use revid->stepping tables

2021-07-08 Thread Anusha Srivatsa
From: Matt Roper Switch RKL to use a revid->stepping table as we're trying to do on all platforms going forward. Bspec: 44501 Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_psr.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.h | 8 ++--

[Intel-gfx] [PATCH 10/10] drm/i915/dmc: Modify intel_get_stepping_info()

2021-07-08 Thread Anusha Srivatsa
With all platforms having the tepping info in intel_step.c, it makes no sense to maintain a separate lookup table in intel_dmc.c Let modify intel_Get_stepping_info() to grab stepping info from the central location towards which everything is moving. Cc: Jani Nikula Signed-off-by: Anusha Srivatsa

[Intel-gfx] [PATCH 00/10] Get stepping info from RUNTIME_INFO->step

2021-07-08 Thread Anusha Srivatsa
stepping changes were missing from Matt's series, I have added a patch for it. Anusha Srivatsa (3): drm/i915/bxt: Use revid->stepping tables drm/i915/step: Add intel_step_name() helper drm/i915/dmc: Modify intel_get_stepping_info() Matt Roper (7): drm/i915: Make pre-production detection

[Intel-gfx] [PATCH 04/10] drm/i915/jsl_ehl: Use revid->stepping tables

2021-07-08 Thread Anusha Srivatsa
From: Matt Roper Switch JSL/EHL to use a revid->stepping table as we're trying to do on all platforms going forward. Bspec: 29153 Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +- drivers/gpu/drm/i915/gt/intel_workarounds.c | 2 +-

[Intel-gfx] [PATCH 08/10] drm/i915/bxt: Use revid->stepping tables

2021-07-08 Thread Anusha Srivatsa
Switch BXT to use a revid->stepping table as we're trying to do on all platforms going forward. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/intel_step.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_step.c b/drivers/gpu/drm/i

[Intel-gfx] [PATCH 06/10] drm/i915/dg1: Use revid->stepping tables

2021-07-08 Thread Anusha Srivatsa
From: Matt Roper Switch DG1 to use a revid->stepping table as we're trying to do on all platforms going forward. This removes the last use of IS_REVID() and REVID_FOREVER, so remove those now-unused macros as well to prevent their accidental use on future platforms. Bspec: 44463 Signed-off-by:

[Intel-gfx] [PATCH 02/10] drm/i915/skl: Use revid->stepping tables

2021-07-08 Thread Anusha Srivatsa
From: Matt Roper Switch SKL to use a revid->stepping table as we're trying to do on all platforms going forward. Also add some additional stepping definitions for completeness, even if we don't have any workarounds tied to them. Note that SKL has a case where a newer revision ID corresponds to

[Intel-gfx] [PATCH 03/10] drm/i915/icl: Use revid->stepping tables

2021-07-08 Thread Anusha Srivatsa
From: Matt Roper Switch ICL to use a revid->stepping table as we're trying to do on all platforms going forward. While we're at it, let's include some additional steppings that have popped up, even if we don't yet have any workarounds tied to those steppings (we probably need to audit our

[Intel-gfx] [PATCH 01/10] drm/i915: Make pre-production detection use direct revid comparison

2021-07-08 Thread Anusha Srivatsa
From: Matt Roper Although we're converting our workarounds to use a revid->stepping lookup table, the function that detects pre-production hardware should continue to compare against PCI revision ID values directly. These are listed in the bspec as integers, so it's easier to confirm their

Re: [Intel-gfx] [PATCH 0/7] Minor revid/stepping and workaround cleanup

2021-07-08 Thread Srivatsa, Anusha
> -Original Message- > From: Roper, Matthew D > Sent: Thursday, July 8, 2021 4:05 PM > To: Srivatsa, Anusha > Cc: Jani Nikula ; intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH 0/7] Minor revid/stepping and workaround cleanup > > On Thu, Jul 08,

Re: [Intel-gfx] [PATCH 0/7] Minor revid/stepping and workaround cleanup

2021-07-08 Thread Srivatsa, Anusha
> -Original Message- > From: Jani Nikula > Sent: Thursday, July 8, 2021 12:33 AM > To: Roper, Matthew D ; intel- > g...@lists.freedesktop.org > Cc: Srivatsa, Anusha > Subject: Re: [PATCH 0/7] Minor revid/stepping and workaround cleanup > > On Wed, 07

Re: [Intel-gfx] [PATCH 2/7] drm/i915/skl: Use revid->stepping tables

2021-07-08 Thread Srivatsa, Anusha
{ .gt_step = STEP_H0, .display_step = STEP_H0 }, > + [0x9] = { .gt_step = STEP_J0, .display_step = STEP_J0 }, > + [0xA] = { .gt_step = STEP_I1, .display_step = STEP_I1 }, }; Feedback I received was to avoid adding .display_step if it is same as .gt_step and have something like: if (step.dis

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Make pre-production detection use direct revid comparison

2021-07-08 Thread Srivatsa, Anusha
-#define BXT_REVID_A1 0x1 > -#define BXT_REVID_B0 0x3 > -#define BXT_REVID_B_LAST 0x8 > -#define BXT_REVID_C0 0x9 > - > -#define IS_BXT_REVID(dev_priv, since, until) \ > - (IS_BROXTON(dev_priv) && IS_REVID(dev_priv, since, until)) Here, we

[Intel-gfx] [PATCH 7/8] drm/i915/rkl: s/IS_RKL_REVID/IS_RKL_GT_STEP

2021-07-06 Thread Anusha Srivatsa
Add stepping info table for RKL. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_psr.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.h | 9 +++-- drivers/gpu/drm/i915/intel_step.c| 9 + 3 files changed, 14 insertions(+), 8 deletions(-) diff --git

[Intel-gfx] [PATCH 8/8] drm/i915/dg1: s/IS_DG1_REVID/IS_DG1_GT_STEP

2021-07-06 Thread Anusha Srivatsa
Add stepping info table for DG1 Cc: Jani Nikula Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- drivers/gpu/drm/i915/gt/intel_region_lmem.c| 2 +- drivers/gpu/drm/i915/gt/intel_workarounds.c| 10 +- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 6/8] drm/i915/glk: s/IS_GLK_REVID/IS_GLK_GT_STEP

2021-07-06 Thread Anusha Srivatsa
Add stepping info table for GLK. Remove stepping info table from intel_dmc.c and instead use the centralized stepping_info from intel_step.c Cc: Jani Nikula Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/i915_drv.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 9 +++-- drivers

[Intel-gfx] [PATCH 5/8] drm/i915/icl: s/IS_ICL_REVID/IS_ICL_GT_STEP

2021-07-06 Thread Anusha Srivatsa
Add stepping info table for ICL. Remove stepping info table from intel_dmc.c and instead use the centralized stepping_info from intel_step.c Cc: Jani Nikula Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dmc.c| 153 +--- drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH 4/8] drm/i915/bxt: s/IS_BXT_REVID/IS_BXT_GT_STEP

2021-07-06 Thread Anusha Srivatsa
Add stepping info table for BXT. Remove stepping info table from intel_dmc.c and instead use the centralized stepping_info from intel_step.c Cc: Jani Nikula Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dmc.c | 18 +- drivers/gpu/drm/i915/i915_drv.c

[Intel-gfx] [PATCH 2/8] drm/i915/dmc: Use RUNTIME_INFO->step for DMC

2021-07-06 Thread Anusha Srivatsa
Instead of adding new table for every new platform, lets ues the stepping info from RUNTIME_INFO(dev_priv)->step This patch uses RUNTIME_INFO->step only for recent platforms. Patches that follow this will address this change for remaining platforms + missing platforms. Signed-off-by:

[Intel-gfx] [PATCH 3/8] drm/i915/skl: s/IS_SKL_REVID/IS_SKL_GT_STEP

2021-07-06 Thread Anusha Srivatsa
Start using the latest STEP_ macro for all purposes. For SKL, GT step is same as display step, lets us avoid initializing both Cc: Jani Nikula Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dmc.c| 24 +++-- drivers/gpu/drm/i915/gt/intel_workarounds.c

[Intel-gfx] [PATCH 0/8] Abstract steppings for all platforms

2021-07-06 Thread Anusha Srivatsa
/substepping combination. While at it, change the names of stepping info table to simpler names: s/_revid_step_tbl/_revids Anusha Srivatsa (8): drm/i915/step: s/_revid_tbl/_revids drm/i915/dmc: Use RUNTIME_INFO->step for DMC drm/i915/skl: s/IS_SKL_REVID/IS_SKL_GT_STEP drm/i915/bxt

[Intel-gfx] [PATCH 1/8] drm/i915/step: s/_revid_tbl/_revids

2021-07-06 Thread Anusha Srivatsa
Simplify the stepping info array name. Cc: Jani Nikula Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/intel_step.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_step.c b/drivers/gpu/drm/i915/intel_step.c

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dmc: Use RUNTIME_INFO->step for DMC

2021-07-06 Thread Srivatsa, Anusha
> -Original Message- > From: Jani Nikula > Sent: Monday, July 5, 2021 3:01 AM > To: Srivatsa, Anusha ; intel- > g...@lists.freedesktop.org > Cc: De Marchi, Lucas > Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/dmc: Use RUNTIME_INFO- > >step for DMC >

[Intel-gfx] [PATCH 1/2] drm/i915/dmc: Use RUNTIME_INFO->step for DMC

2021-07-01 Thread Anusha Srivatsa
De Marchi Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dmc.c | 117 +++ drivers/gpu/drm/i915/intel_step.c| 41 drivers/gpu/drm/i915/intel_step.h| 7 ++ 3 files changed, 126 insertions(+), 39 deletions(-) diff --git a/driv

[Intel-gfx] [PATCH 0/2] Stepping/substepping reorg for DMC

2021-07-01 Thread Anusha Srivatsa
This series addresses the following: 1. Add missing stepping/substepping info for all platforms. 2. Use RUNTIME_INFO->step to grab the actual stepping info for a platform instead of having separate lookup tables for each platform on DMC side. Anusha Srivatsa (2): drm/i915/dmc: Use RUNTIME_I

[Intel-gfx] [PATCH 2/2] drm/i915/dmc: Add steping info table for remaining platforms

2021-07-01 Thread Anusha Srivatsa
intel_step.c has stepping_info for most platforms. With DMC using display_step from here, lets add the info for all older platforms as well Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/intel_step.c | 28 1 file changed, 28 insertions

[Intel-gfx] [PATCH] drm/i915/dmc: Use RUNTIME_INFO->stp for DMC

2021-06-30 Thread Anusha Srivatsa
off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dmc.c | 49 ++-- 1 file changed, 45 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c index f8789d4543bf..c7ff7ff3f412 100644 --- a/drivers/

[Intel-gfx] [RFC 2/2] drm/i915/dmc: Modify stepping/substepping table

2021-06-29 Thread Anusha Srivatsa
Grab the stepping info from RUNTIME_INFO(dev_priv)->step on the dmc side to grab the right blob. Adding the helper intel_get_soc_info() that has SOC stepping lookup table. Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dmc.c |

[Intel-gfx] [RFC 1/2] drm/i915/dmc: Add soc stepping to intel_step

2021-06-29 Thread Anusha Srivatsa
DMC firmware looks for SOC stepping to load specific firmware. While we maintained a separate lookup table, lets consolidate SOC steppings with gt and display steppings. Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/intel_step.c | 46

[Intel-gfx] [PATCH 2/2] drm/i915/firmware: Update to DMC v2.03 on RKL

2021-06-21 Thread Anusha Srivatsa
Add support to load latest DMC version. The Release Notes mentions that this version fixes timeout issues. Cc: Madhumitha Pradeep Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 1/2] drm/i915/firmware: Update to DMC v2.12 on TGL

2021-06-21 Thread Anusha Srivatsa
Add support to the latest DMC firmware. Cc: Madhunitha Pradeep Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH 0/2] DMC Updates for RKL, TGL

2021-06-21 Thread Anusha Srivatsa
-firmware rkl_tgl_dmc_updates for you to fetch changes up to 885ee4dde3c760e7b8b8a43a5ba4056a7e66c788: drm/i915/firmware: Add DMC v2.02 for RKL (2021-06-21 16:06:07 -0700) Anusha Srivatsa (2): drm/i915/firmware: Add V2.12 DC fo

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Pipe DMC bits

2021-06-21 Thread Srivatsa, Anusha
From: Patchwork Sent: Monday, June 21, 2021 2:30 PM To: Srivatsa, Anusha Cc: intel-gfx@lists.freedesktop.org Subject: ✗ Fi.CI.IGT: failure for Pipe DMC bits Patch Details Series: Pipe DMC bits URL: https://patchwork.freedesktop.org/series/91746/ State: failure Details: https://intel

[Intel-gfx] [CI 2/4] drm/i915/xelpd: Pipe A DMC plugging

2021-06-21 Thread Anusha Srivatsa
combination in fw_info_matches_stepping() helper. v4: Add macro for start_mmioaddr for V1 package. Simplify code in dmc_set_fw_offset (Lucas) Cc: Souza, Jose Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi --- .../drm/i915/display/intel_display_debugfs.c | 4

[Intel-gfx] [CI 1/4] drm/i915/dmc: Introduce DMC_FW_MAIN

2021-06-21 Thread Anusha Srivatsa
-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_dmc.c | 38 +--- drivers/gpu/drm/i915/display/intel_dmc.h | 18 +++ 2 files changed, 33 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers

[Intel-gfx] [CI 4/4] drm/i915/adl_p: Load DMC

2021-06-21 Thread Anusha Srivatsa
Load DMC v2.10 on ADLP. The release notes mention that this version enables few power savings features. v2: Add DMC_PATH() for ADLP (Lucas) Cc: Lucas De Marchi Cc: Clint Taylor Signed-off-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_dmc.c | 10

[Intel-gfx] [CI 3/4] drm/i915/adl_p: Pipe B DMC Support

2021-06-21 Thread Anusha Srivatsa
ADLP requires us to load both Pipe A and Pipe B. Plug Pipe B loading support. Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 ++ drivers/gpu/drm/i915/display/intel_dmc.h | 1 + 2 files

[Intel-gfx] [CI 0/4] Pipe DMC bits

2021-06-21 Thread Anusha Srivatsa
changes in Pipe DMC plugging patch as suggested by Lucas v4: Remove the sanity check for MMIO that no longer apply to newer platforms.(Anusha) Anusha Srivatsa (4): drm/i915/dmc: Introduce DMC_FW_MAIN drm/i915/xelpd: Pipe A DMC plugging drm/i915/adl_p: Pipe B DMC Support drm/i915/adl_p

Re: [Intel-gfx] [PATCH 1/5] drm/i915/display: Limit disabling PSR around cdclk changes to ADL-P

2021-06-17 Thread Srivatsa, Anusha
> -Original Message- > From: Souza, Jose > Sent: Thursday, June 17, 2021 2:18 PM > To: Mun, Gwan-gyeong ; Srivatsa, Anusha > ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 1/5] drm/i915/display: Limit disabling PSR > around cdclk changes to AD

[Intel-gfx] [PATCH 1/5] drm/i915/display: Limit disabling PSR around cdclk changes to ADL-P

2021-06-17 Thread Anusha Srivatsa
: 49207 Cc: Ville Syrjälä Cc: Mika Kahola Cc: Stanislav Lisovskiy Cc: Anusha Srivatsa Fixes: 17c1a4b7ac6f ("drm/i915: Disable PSR around cdclk change") Signed-off-by: Gwan-gyeong Mun --- drivers/gpu/drm/i915/display/intel_cdclk.c | 22 -- 1 file changed, 16 insert

[Intel-gfx] [PATCH 5/5] drm/i915/adl_p: Load DMC

2021-06-17 Thread Anusha Srivatsa
Load DMC v2.10 on ADLP. The release notes mention that this version enables few power savings features. v2: Add DMC_PATH() for ADLP (Lucas) Cc: Lucas De Marchi Cc: Clint Taylor Signed-off-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_dmc.c | 10

[Intel-gfx] [PATCH 4/5] drm/i915/adl_p: Pipe B DMC Support

2021-06-17 Thread Anusha Srivatsa
ADLP requires us to load both Pipe A and Pipe B. Plug Pipe B loading support. Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 ++ drivers/gpu/drm/i915/display/intel_dmc.h | 1 + 2 files

[Intel-gfx] [PATCH 2/5] drm/i915/dmc: Introduce DMC_FW_MAIN

2021-06-17 Thread Anusha Srivatsa
-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_dmc.c | 38 +--- drivers/gpu/drm/i915/display/intel_dmc.h | 18 +++ 2 files changed, 33 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers

[Intel-gfx] [PATCH 3/5] drm/i915/xelpd: Pipe A DMC plugging

2021-06-17 Thread Anusha Srivatsa
combination in fw_info_matches_stepping() helper. v4: Add macro for start_mmioaddr for V1 package. Simplify code in dmc_set_fw_offset (Lucas) Cc: Souza, Jose Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi --- .../drm/i915/display/intel_display_debugfs.c | 4

[Intel-gfx] [PATCH 0/5] Pipe DMC bits + PSR fix

2021-06-17 Thread Anusha Srivatsa
Pipe DMC series exposed a corner case in PSR patches that were merged recently. Sending the fix along with the Pipe DMC bits to get ensure that CI has no regressions. Anusha Srivatsa (4): drm/i915/dmc: Introduce DMC_FW_MAIN drm/i915/xelpd: Pipe A DMC plugging drm/i915/adl_p: Pipe B DMC

[Intel-gfx] [CI 3/4] drm/i915/adl_p: Pipe B DMC Support

2021-06-13 Thread Anusha Srivatsa
ADLP requires us to load both Pipe A and Pipe B. Plug Pipe B loading support. Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 ++ drivers/gpu/drm/i915/display/intel_dmc.h | 1 + 2 files

[Intel-gfx] [CI 4/4] drm/i915/adl_p: Load DMC

2021-06-13 Thread Anusha Srivatsa
Load DMC v2.10 on ADLP. The release notes mention that this version enables few power savings features. v2: Add DMC_PATH() for ADLP (Lucas) Cc: Lucas De Marchi Cc: Clint Taylor Signed-off-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_dmc.c | 10

[Intel-gfx] [CI 2/4] drm/i915/xelpd: Pipe A DMC plugging

2021-06-13 Thread Anusha Srivatsa
combination in fw_info_matches_stepping() helper. v4: Add macro for start_mmioaddr for V1 package. Simplify code in dmc_set_fw_offset (Lucas) Cc: Souza, Jose Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi --- .../drm/i915/display/intel_display_debugfs.c | 4

[Intel-gfx] [CI 0/4] Pipe DMC Support

2021-06-13 Thread Anusha Srivatsa
changes in Pipe DMC plugging patch as suggested by Lucas v4: Remove the sanity check for MMIO that no longer apply to newer platforms.(Anusha) Anusha Srivatsa (4): drm/i915/dmc: Introduce DMC_FW_MAIN drm/i915/xelpd: Pipe A DMC plugging drm/i915/adl_p: Pipe B DMC Support drm/i915/adl_p

[Intel-gfx] [CI 1/4] drm/i915/dmc: Introduce DMC_FW_MAIN

2021-06-13 Thread Anusha Srivatsa
-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_dmc.c | 38 +--- drivers/gpu/drm/i915/display/intel_dmc.h | 18 +++ 2 files changed, 33 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers

[Intel-gfx] [CI 2/4] drm/i915/xelpd: Pipe A DMC plugging

2021-06-11 Thread Anusha Srivatsa
combination in fw_info_matches_stepping() helper. v4: Add macro for start_mmioaddr for V1 package. Simplify code in dmc_set_fw_offset (Lucas) Cc: Souza, Jose Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa --- .../drm/i915/display/intel_display_debugfs.c | 4 +- .../drm/i915/display

[Intel-gfx] [CI 1/4] drm/i915/dmc: Introduce DMC_FW_MAIN

2021-06-11 Thread Anusha Srivatsa
-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_dmc.c | 38 +--- drivers/gpu/drm/i915/display/intel_dmc.h | 18 +++ 2 files changed, 33 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers

[Intel-gfx] [CI 3/4] drm/i915/adl_p: Pipe B DMC Support

2021-06-11 Thread Anusha Srivatsa
ADLP requires us to load both Pipe A and Pipe B. Plug Pipe B loading support. Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 ++ drivers/gpu/drm/i915/display/intel_dmc.h | 1 + 2 files

[Intel-gfx] [CI 4/4] drm/i915/adl_p: Load DMC

2021-06-11 Thread Anusha Srivatsa
Load DMC v2.10 on ADLP. The release notes mention that this version enables few power savings features. v2: Add DMC_PATH() for ADLP (Lucas) Cc: Lucas De Marchi Cc: Clint Taylor Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dmc.c | 10 +- 1 file changed, 9

[Intel-gfx] [CI 0/4] Pipe DMC Support

2021-06-11 Thread Anusha Srivatsa
changes in Pipe DMC plugging patch as suggested by Lucas v4: Remove the sanity check for MMIO that no longer apply to newer platforms.(Anusha) Anusha Srivatsa (4): drm/i915/dmc: Introduce DMC_FW_MAIN drm/i915/xelpd: Pipe A DMC plugging drm/i915/adl_p: Pipe B DMC Support drm/i915/adl_p

Re: [Intel-gfx] [CI 2/4] drm/i915/xelpd: Pipe A DMC plugging

2021-06-11 Thread Srivatsa, Anusha
> -Original Message- > From: De Marchi, Lucas > Sent: Wednesday, June 9, 2021 11:22 PM > To: Srivatsa, Anusha > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [CI 2/4] drm/i915/xelpd: Pipe A DMC plugging > > On Fri, Jun 04, 2021 at 12:01:26P

[Intel-gfx] [CI 4/4] drm/i915/adl_p: Load DMC

2021-06-10 Thread Anusha Srivatsa
Load DMC v2.10 on ADLP. The release notes mention that this version enables few power savings features. v2: Add DMC_PATH() for ADLP (Lucas) Cc: Lucas De Marchi Cc: Clint Taylor Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dmc.c | 10 +- 1 file changed, 9

[Intel-gfx] [CI 3/4] drm/i915/adl_p: Pipe B DMC Support

2021-06-10 Thread Anusha Srivatsa
ADLP requires us to load both Pipe A and Pipe B. Plug Pipe B loading support. Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 ++ drivers/gpu/drm/i915/display/intel_dmc.h | 1 + 2 files

[Intel-gfx] [CI 1/4] drm/i915/dmc: Introduce DMC_FW_MAIN

2021-06-10 Thread Anusha Srivatsa
-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_dmc.c | 38 +--- drivers/gpu/drm/i915/display/intel_dmc.h | 18 +++ 2 files changed, 33 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers

[Intel-gfx] [CI 2/4] drm/i915/xelpd: Pipe A DMC plugging

2021-06-10 Thread Anusha Srivatsa
combination in fw_info_matches_stepping() helper. v4: Add macro for start_mmioaddr for V1 package. Simplify code in dmc_set_fw_offset (Lucas) Cc: Souza, Jose Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa --- .../drm/i915/display/intel_display_debugfs.c | 4 +- .../drm/i915/display

[Intel-gfx] [CI 0/4] Pipe DMC Support

2021-06-10 Thread Anusha Srivatsa
that came under this category and DMC refused to load. v2: SKL fix tested on SKL. v3: Minor changes in Pipe DMC plugging patch as suggested by Lucas Anusha Srivatsa (4): drm/i915/dmc: Introduce DMC_FW_MAIN drm/i915/xelpd: Pipe A DMC plugging drm/i915/adl_p: Pipe B DMC Support drm/i915/adl_p

[Intel-gfx] [CI 4/4] drm/i915/adl_p: Load DMC

2021-06-04 Thread Anusha Srivatsa
Load DMC v2.10 on ADLP. The release notes mention that this version enables few power savings features. Cc: Lucas De Marchi Cc: Clint Taylor Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dmc.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] [CI 0/4] Pipe DMC Support

2021-06-04 Thread Anusha Srivatsa
that came under this category and DMC refused to load. This fix is tested on SKL. Anusha Srivatsa (4): drm/i915/dmc: Introduce DMC_FW_MAIN xdrm/i915/xelpd: Pipe A DMC plugging drm/i915/adl_p: Pipe B DMC Support drm/i915/adl_p: Load DMC .../drm/i915/display/intel_display_debugfs.c | 6

[Intel-gfx] [CI 2/4] drm/i915/xelpd: Pipe A DMC plugging

2021-06-04 Thread Anusha Srivatsa
combination in fw_info_matches_stepping() helper. Cc: Souza, Jose Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa --- .../drm/i915/display/intel_display_debugfs.c | 4 +- .../drm/i915/display/intel_display_power.c| 5 +- drivers/gpu/drm/i915/display/intel_dmc.c | 130

[Intel-gfx] [CI 3/4] drm/i915/adl_p: Pipe B DMC Support

2021-06-04 Thread Anusha Srivatsa
ADLP requires us to load both Pipe A and Pipe B. Plug Pipe B loading support. Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 ++ drivers/gpu/drm/i915/display/intel_dmc.h | 1 + 2 files changed, 3 insertions(+) diff

[Intel-gfx] [CI 1/4] drm/i915/dmc: Introduce DMC_FW_MAIN

2021-06-04 Thread Anusha Srivatsa
-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dmc.c | 44 +++- drivers/gpu/drm/i915/display/intel_dmc.h | 18 +++--- 2 files changed, 33 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c

[Intel-gfx] [CI 4/4] drm/i915/adl_p: Load DMC

2021-06-04 Thread Anusha Srivatsa
Load DMC v2.06 on ADLP. The release notes mention that this version enables few power savings features. Cc: Lucas De Marchi Cc: Clint Taylor Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dmc.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] [CI 0/4] Pipe DMC Support

2021-06-04 Thread Anusha Srivatsa
that came under this category and DMC refused to load. This fix is tested on SKL. Anusha Srivatsa (4): drm/i915/dmc: Introduce DMC_FW_MAIN xdrm/i915/xelpd: Pipe A DMC plugging drm/i915/adl_p: Pipe B DMC Support drm/i915/adl_p: Load DMC .../drm/i915/display/intel_display_debugfs.c | 6

[Intel-gfx] [CI 3/4] drm/i915/adl_p: Pipe B DMC Support

2021-06-04 Thread Anusha Srivatsa
ADLP requires us to load both Pipe A and Pipe B. Plug Pipe B loading support. Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 ++ drivers/gpu/drm/i915/display/intel_dmc.h | 1 + 2 files changed, 3 insertions(+) diff

[Intel-gfx] [CI 2/4] drm/i915/xelpd: Pipe A DMC plugging

2021-06-04 Thread Anusha Srivatsa
combination in fw_info_matches_stepping() helper. Cc: Souza, Jose Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa --- .../drm/i915/display/intel_display_debugfs.c | 4 +- .../drm/i915/display/intel_display_power.c| 5 +- drivers/gpu/drm/i915/display/intel_dmc.c | 130

[Intel-gfx] [CI 1/4] drm/i915/dmc: Introduce DMC_FW_MAIN

2021-06-04 Thread Anusha Srivatsa
-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dmc.c | 44 +++- drivers/gpu/drm/i915/display/intel_dmc.h | 18 +++--- 2 files changed, 33 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c

[Intel-gfx] [PATCH 1/7] drm/i915/dmc: s/DRM_ERROR/drm_err

2021-05-26 Thread Anusha Srivatsa
Use new format of debug messages across intel_csr. While at it, change some function definitions which now need dev_priv for drm_err and drm_info etc. v2: use container_of() (Jani) v3: Indentation fixes. (Jani) Cc: Jani Nikula Suggested-by: Lucas De Marchi Signed-off-by: Anusha Srivatsa

[Intel-gfx] [PATCH 4/7] drm/i915/dmc: Introduce DMC_FW_MAIN

2021-05-26 Thread Anusha Srivatsa
-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dmc.c | 44 +++- drivers/gpu/drm/i915/display/intel_dmc.h | 18 +++--- 2 files changed, 33 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c

[Intel-gfx] [PATCH 3/7] drm/i915/dmc: Move struct intel_dmc to intel_dmc.h

2021-05-26 Thread Anusha Srivatsa
Move struct intel_dmc from i915_drv.h to intel_dmc.h. v2: Add includes along with moving the struct. Reviewed-by: José Roberto de Souza Reviewed-by: Lucas De Marchi Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dmc.h | 21 + drivers/gpu/drm/i915

[Intel-gfx] [PATCH 2/7] drm/i915/dmc: Add intel_dmc_has_payload() helper

2021-05-26 Thread Anusha Srivatsa
We check for dmc_payload being there at various points in the driver. Replace it with the helper. v2: rebased. v3: Move intel_dmc to intel_dmc.h in another patch (Lucas) v4: Remove headers not needed from intel_dmc.h Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa Reviewed-by: Lucas De

<    1   2   3   4   5   6   7   8   9   10   >