Re: [Intel-gfx] [PATCH v4 5/5] drm/msm/dp: Implement hpd_notify()

2022-05-03 Thread Bjorn Andersson
On Mon 02 May 15:49 PDT 2022, Kuogee Hsieh wrote: > > On 5/2/2022 3:29 PM, Bjorn Andersson wrote: > > On Mon 02 May 13:59 PDT 2022, Kuogee Hsieh wrote: > > > > > On 5/2/2022 9:53 AM, Bjorn Andersson wrote: > > > > The Qualcomm DisplayPort driver contains t

[Intel-gfx] [PATCH v4 5/5] drm/msm/dp: Implement hpd_notify()

2022-05-03 Thread Bjorn Andersson
de in dp_drm_connector_init(). Signed-off-by: Bjorn Andersson --- Changes since v3: - Implements hpd_notify instead of oob_hotplug_event - Rebased on new cleanup patch from Dmitry - Set hpd_state to ST_MAINLINK_READY when dp_display_usbpd_configure() succeeds drivers/gpu/drm/msm/dp/dp_display.c

[Intel-gfx] [PATCH v4 1/5] drm/bridge_connector: stop filtering events in drm_bridge_connector_hpd_cb()

2022-05-03 Thread Bjorn Andersson
() and let drivers decide whether they would like to receive the event or not. Signed-off-by: Dmitry Baryshkov Signed-off-by: Bjorn Andersson --- Changes since v3: - New patch, needed due to the move to drm_bridge_connector drivers/gpu/drm/drm_bridge_connector.c | 5 - 1 file changed, 5

Re: [Intel-gfx] [PATCH v4 5/5] drm/msm/dp: Implement hpd_notify()

2022-05-03 Thread Bjorn Andersson
On Mon 02 May 15:29 PDT 2022, Bjorn Andersson wrote: > On Mon 02 May 13:59 PDT 2022, Kuogee Hsieh wrote: > > > > > On 5/2/2022 9:53 AM, Bjorn Andersson wrote: > > > The Qualcomm DisplayPort driver contains traces of the necessary > > > plumbing to hook u

[Intel-gfx] [PATCH v4 3/5] drm/bridge_connector: implement oob_hotplug_event

2022-05-03 Thread Bjorn Andersson
From: Dmitry Baryshkov Implement the oob_hotplug_event() callback. Translate it to the HPD notification sent to the HPD bridge in the chain. Signed-off-by: Dmitry Baryshkov Signed-off-by: Bjorn Andersson --- Changes since v3: - New patch drivers/gpu/drm/drm_bridge_connector.c | 12

[Intel-gfx] [PATCH v4 4/5] drm/msm/dp: remove most of usbpd-related remains

2022-05-03 Thread Bjorn Andersson
rewritten into . Signed-off-by: Dmitry Baryshkov [bjorn: Cleaned up dp_display_usbpd_attention() prototype as well] Signed-off-by: Bjorn Andersson --- Changes since v3: - New patch drivers/gpu/drm/msm/Makefile| 1 - drivers/gpu/drm/msm/dp/dp_ctrl.h| 1 - drivers/gpu/drm/msm/dp

Re: [Intel-gfx] [PATCH v4 5/5] drm/msm/dp: Implement hpd_notify()

2022-05-03 Thread Bjorn Andersson
On Mon 02 May 13:59 PDT 2022, Kuogee Hsieh wrote: > > On 5/2/2022 9:53 AM, Bjorn Andersson wrote: > > The Qualcomm DisplayPort driver contains traces of the necessary > > plumbing to hook up USB HPD, in the form of the dp_hpd module and the > > dp_usbpd_cb struc

[Intel-gfx] [PATCH v4 0/5] drm/msm/dp: implement HPD notifications handling

2022-05-03 Thread Bjorn Andersson
liver altmode messages to the MSM DP driver. Note, I left the original 'bool connected' field to be used by the notifiers. However I think that it should be replaced in favour of using the dp->hpd_state properly. Bjorn Andersson (2): drm: Add HPD state to drm_connector_oob_hotplug_ev

[Intel-gfx] [PATCH v4 2/5] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-05-03 Thread Bjorn Andersson
test for unchanged state in the displayport altmode driver into the i915 driver, to allow other drivers to act upon each update. Signed-off-by: Bjorn Andersson --- Changes since v3: - Transition to drm_connector_status instead of custom hpd_state drivers/gpu/drm/drm_connector.c

Re: [Intel-gfx] [PATCH v5 09/10] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller

2022-04-25 Thread Bjorn Andersson
On Mon 11 Apr 13:47 PDT 2022, Sean Paul wrote: > From: Sean Paul > > This patch adds the register ranges required for HDCP key injection and > HDCP TrustZone interaction as described in the dt-bindings for the > sc7180 dp controller. Can you please mention why this is only done for trogdor and

Re: [Intel-gfx] [PATCH v3 2/2] drm/msm/dp: Implement oob_hotplug_event()

2022-04-25 Thread Bjorn Andersson
On Fri 22 Apr 16:07 PDT 2022, Dmitry Baryshkov wrote: > On 23/04/2022 01:32, Bjorn Andersson wrote: [..] > > diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c > > b/drivers/gpu/drm/msm/dp/dp_drm.c > > index 80f59cf99089..76904b1601b1 100644 > > --- a/drivers/gpu/drm/msm/dp

[Intel-gfx] [PATCH v3 1/2] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-04-25 Thread Bjorn Andersson
test for unchanged state in the displayport altmode driver into the i915 driver, to allow other drivers to act upon each update. Signed-off-by: Bjorn Andersson --- Changs since v2: - The i915 cached hpd_state is tracked per encoder. drivers/gpu/drm/drm_connector.c | 6 -- driver

[Intel-gfx] [PATCH v3 2/2] drm/msm/dp: Implement oob_hotplug_event()

2022-04-25 Thread Bjorn Andersson
de in dp_drm_connector_init(). Signed-off-by: Bjorn Andersson --- Changes since v2: - Rebased patch drivers/gpu/drm/msm/dp/dp_display.c | 9 + drivers/gpu/drm/msm/dp/dp_display.h | 3 +++ drivers/gpu/drm/msm/dp/dp_drm.c | 11 +++ drivers/gpu/drm/msm/dp/dp_hpd.c

[Intel-gfx] [PATCH v2 1/2] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-03-04 Thread Bjorn Andersson
test for unchanged state in the displayport altmode driver into the i915 driver, to allow other drivers to act upon each update. Changes in v2: - Replace bool with drm_connector_hpd_state enum to represent "state" better - Track old hpd state per encoder in i915 Signed-off-by:

[Intel-gfx] [PATCH v2 2/2] drm/msm/dp: Implement oob_hotplug_event()

2022-03-04 Thread Bjorn Andersson
de in dp_drm_connector_init(). Changes in v2: - Adopt enum drm_connector_hpd_state Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_display.c | 9 + drivers/gpu/drm/msm/dp/dp_display.h | 3 +++ drivers/gpu/drm/msm/dp/dp_drm.c | 11 +++ drivers/gpu/drm/msm/dp/dp_

Re: [Intel-gfx] [PATCH 1/2] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-02-15 Thread Bjorn Andersson
On Mon 14 Feb 09:59 PST 2022, Imre Deak wrote: > On Mon, Feb 07, 2022 at 08:43:27PM -0800, Bjorn Andersson wrote: > > In some implementations, such as the Qualcomm platforms, the display > > driver has no way to query the current HPD state and as such it's > > impossi

Re: [Intel-gfx] [PATCH 1/2] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-02-14 Thread Bjorn Andersson
On Tue 08 Feb 02:39 PST 2022, Greg Kroah-Hartman wrote: > On Mon, Feb 07, 2022 at 08:43:27PM -0800, Bjorn Andersson wrote: > > In some implementations, such as the Qualcomm platforms, the display > > driver has no way to query the current HPD state and as such it's > >

Re: [Intel-gfx] [PATCH 2/2] drm/msm/dp: Implement oob_hotplug_event()

2022-02-14 Thread Bjorn Andersson
On Mon 07 Feb 23:40 PST 2022, Greg Kroah-Hartman wrote: > On Mon, Feb 07, 2022 at 08:43:28PM -0800, Bjorn Andersson wrote: > > The Qualcomm DisplayPort driver contains traces of the necessary > > plumbing to hook up USB HPD, in the form of the dp_hpd module and the > > dp

Re: [Intel-gfx] [PATCH 1/2] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-02-14 Thread Bjorn Andersson
On Thu 10 Feb 13:12 PST 2022, Dmitry Baryshkov wrote: > On Thu, 10 Feb 2022 at 23:54, Bjorn Andersson > wrote: > > > > On Tue 08 Feb 02:39 PST 2022, Greg Kroah-Hartman wrote: > > > > > On Mon, Feb 07, 2022 at 08:43:27PM -0800, Bjorn Andersson wrote: > > &

[Intel-gfx] [PATCH 1/2] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-02-08 Thread Bjorn Andersson
test for unchanged state in the displayport altmode driver into the i915 driver, to allow other drivers to act upon each update. Signed-off-by: Bjorn Andersson --- Note that the Intel driver has only been compile tested with this patch. drivers/gpu/drm/drm_connector.c | 6 -- dr

[Intel-gfx] [PATCH 2/2] drm/msm/dp: Implement oob_hotplug_event()

2022-02-08 Thread Bjorn Andersson
de in dp_drm_connector_init(). Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_display.c | 8 drivers/gpu/drm/msm/dp/dp_display.h | 2 ++ drivers/gpu/drm/msm/dp/dp_drm.c | 10 ++ drivers/gpu/drm/msm/dp/dp_hpd.c | 19 +++ drivers/gpu/drm/msm/dp/dp_

Re: [Intel-gfx] [PATCH v3 12/14] dt-bindings: msm/dp: Add bindings for HDCP registers

2021-10-04 Thread Bjorn Andersson
On Fri 01 Oct 10:11 CDT 2021, Sean Paul wrote: > From: Sean Paul > > This patch adds the bindings for the MSM DisplayPort HDCP registers > which are required to write the HDCP key into the display controller as > well as the registers to enable HDCP authentication/key > exchange/encryption. > >

Re: [Intel-gfx] [PATCH v3 12/14] dt-bindings: msm/dp: Add bindings for HDCP registers

2021-10-04 Thread Bjorn Andersson
On Fri 01 Oct 10:11 CDT 2021, Sean Paul wrote: > From: Sean Paul > > This patch adds the bindings for the MSM DisplayPort HDCP registers > which are required to write the HDCP key into the display controller as > well as the registers to enable HDCP authentication/key > exchange/encryption. > >