Rb on patches 5 & 6.
Cheers,
Lionel Landwerlin (6):
drm/i915: store all subslice masks
drm/i915/debugfs: reuse max slice/subslices already stored in sseu
drm/i915/debugfs: add rcs topology entry
drm/i915: add rcs topology to error state
drm/i915: add query uAPI
drm/i915: expose rcs
setting eu_mask on CHV (Tvrtko)
Reformat debug prints for subslices (Tvrtko)
v4: Change eu_mask helper into sseu_set_eus() (Tvrtko)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_debugfs.c | 25 ++--
drivers/gpu/drm/i915/i915_drv.c
Checked the documentation. It looks good to me :
Reviewed-by: Lionel Landwerlin
On 13/02/18 16:37, Mika Kuoppala wrote:
From: Kelvin Gardiner
This patch adds support to detect ICL, slice, subslice and EU fuse
settings.
Add addresses for ICL 11 slice, subslice and EU fuses registers.
These
On 12/02/18 11:08, Chris Wilson wrote:
Quoting Lionel Landwerlin (2018-02-12 11:00:10)
On 12/02/18 10:41, Chris Wilson wrote:
Quoting Lionel Landwerlin (2018-02-12 10:37:52)
On 09/02/18 20:53, Chris Wilson wrote:
Quoting Lionel Landwerlin (2018-02-09 17:47:44)
Hey Chris,
From the i915
On 12/02/18 10:41, Chris Wilson wrote:
Quoting Lionel Landwerlin (2018-02-12 10:37:52)
On 09/02/18 20:53, Chris Wilson wrote:
Quoting Lionel Landwerlin (2018-02-09 17:47:44)
Hey Chris,
From the i915/perf point of view, I'm fine with this change.
The pinning of the hw_id when monitor
On 09/02/18 20:53, Chris Wilson wrote:
Quoting Lionel Landwerlin (2018-02-09 17:47:44)
Hey Chris,
From the i915/perf point of view, I'm fine with this change.
The pinning of the hw_id when monitoring a single context (with OA)
doesn't break the existing userspace (I can only thi
On 09/02/18 17:44, Oscar Mateo wrote:
On 02/08/2018 08:35 AM, Lionel Landwerlin wrote:
On 11/01/18 18:25, Oscar Mateo wrote:
From: Kelvin Gardiner
ICL 11 has a greater number of maximum subslices. This patch
reflects this.
v2: GEN11 updates to MCR_SELECTOR (Oscar)
Bspec: 21139
BSpec
y the kernel or by perf).
Signed-off-by: Chris Wilson
Cc: Lionel Landwerlin
Cc: Oscar Mateo
Cc: Mika Kuoppala
Cc: Michel Thierry
---
drivers/gpu/drm/i915/i915_debugfs.c | 5 +-
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/dr
On 11/01/18 18:25, Oscar Mateo wrote:
From: Kelvin Gardiner
ICL 11 has a greater number of maximum subslices. This patch
reflects this.
v2: GEN11 updates to MCR_SELECTOR (Oscar)
Bspec: 21139
BSpec: 21108
Reviewed-by: Daniele Ceraolo Spurio (v1)
Signed-off-by: Kelvin Gardiner
Signed-off-by:
eak
Tested-by: Lionel Landwerlin
On CNL.
---
drivers/gpu/drm/i915/i915_debugfs.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
b/drivers/gpu/drm/i915/i915_debugfs.c
index 2bdce9fea671..eff5548ec093 100644
--- a/drivers/gpu/drm/i915/i915_
On 08/02/18 11:14, Chris Wilson wrote:
drivers/gpu/drm/i915/i915_gem_request.c:941: warning: No description found for
parameter 'write'
Signed-off-by: Chris Wilson
Reviewed-by: Lionel Landwerlin
---
drivers/gpu/drm/i915/i915_gem_request.c | 2 +-
1 file changed, 1 inser
'file_priv'
Signed-off-by: Chris Wilson
Reviewed-by: Lionel Landwerlin
---
drivers/gpu/drm/i915/i915_gem_context.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_context.c
b/drivers/gpu/drm/i915/i915_gem_context.c
index dd9efb9d0e0b..7b3e9b41b31b
r.c:741: warning: No description found for
parameter 'cs'
Signed-off-by: Chris Wilson
Reviewed-by: Lionel Landwerlin
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ringbu
r.c:761: warning: No description found for
parameter 'file'
Signed-off-by: Chris Wilson
Reviewed-by: Lionel Landwerlin
---
drivers/gpu/drm/i915/i915_gem_userptr.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_userptr.c
b/drivers/g
I'm not super familiar with all the documentation stuff, but this looks
good to me.
Reviewed-by: Lionel Landwerlin
On 08/02/18 11:11, Chris Wilson wrote:
drivers/gpu/drm/i915/i915_gpu_error.c:1815: warning: No description found for
parameter 'dev_priv'
drivers/gpu/drm/i915/i
-truncation]
v2: strlcpy
Fixes: 95690a02fb5d ("drm/i915/perf: enable perf support on CNL")
Signed-off-by: Chris Wilson
Cc: Lionel Landwerlin
Cc: Matthew Auld
Reviewed-by: Lionel Landwerlin
---
drivers/gpu/drm/i915/i915_oa_cnl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletion
=stringop-truncation]
v2: strlcpy
Fixes: 4407eaa9b0cc ("drm/i915/perf: add support for Coffeelake GT3")
Signed-off-by: Chris Wilson
Cc: Lionel Landwerlin
Reviewed-by: Lionel Landwerlin
Cc: Matthew Auld
---
drivers/gpu/drm/i915/i915_oa_cflgt3.c | 4 ++--
1 file changed, 2 insert
efore terminating nul copying 36 bytes from a string of the same length
[-Werror=stringop-truncation]
Fixes: 4407eaa9b0cc ("drm/i915/perf: add support for Coffeelake GT3")
Signed-off-by: Chris Wilson
Cc: Lionel Landwerlin
Cc: Matthew Auld
---
drivers/gpu/drm/i915/i915_oa_cflgt3.c
On 31/01/18 02:15, Rodrigo Vivi wrote:
On Tue, Jan 30, 2018 at 08:44:46AM +, Jani Nikula wrote:
On Mon, 29 Jan 2018, Jani Nikula wrote:
On Mon, 29 Jan 2018, Lionel Landwerlin wrote:
On 29/01/18 09:02, Chris Wilson wrote:
Quoting Lionel Landwerlin (2018-01-29 08:33:46)
This reverts
On 30/01/18 15:01, Lahtinen, Joonas wrote:
On Mon, 2018-01-29 at 16:24 +, Lionel Landwerlin wrote:
Thanks all,
I don't really read much opposition to the current patch series. If
anything we could actually want to do more it seems.
It would be good to have the green light and land
Thanks Sagar, fixed locally.
On 30/01/18 09:08, Sagar Arun Kamble wrote:
On 1/29/2018 10:01 PM, Lionel Landwerlin wrote:
With the introduction of asymmetric slices in CNL, we cannot rely on
the previous SUBSLICE_MASK getparam to tell userspace what subslices
are available. Here we introduce
Signed-off-by: Lionel Landwerlin
---
drivers/gpu/drm/i915/i915_query.c | 135 ++
drivers/gpu/drm/i915/i915_query.h | 5 ++
include/uapi/drm/i915_drm.h | 76 +
3 files changed, 216 insertions(+)
diff --git a/drivers/gpu/drm/i915
uapi comments style to match the coding style (Lionel)
v9: Fix error in comment about computation of enabled subslice (Tvrtko)
Signed-off-by: Lionel Landwerlin
---
drivers/gpu/drm/i915/i915_query.c | 110 ++
include/uapi/drm/i915_drm
lice2: 8 EUs (0xff)
subslice3: 0 EUs (0x0)
v2: Reformat debugfs printing (Tvrtko)
Use the new EU mask helper (Tvrtko)
v3: Move printing code to intel_device_info.c to be shared with error
state (Michal)
Suggested-by: Chris Wilson
Signed-off-by: Lionel Landwerlin
Reviewed-by: T
This might be useful information for developers looking at an error
state.
v2: Place topology towards the end of the error state (Chris)
v3: Reuse common printing code (Michal)
v4: Make this a one-liner (Chris)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm
setting eu_mask on CHV (Tvrtko)
Reformat debug prints for subslices (Tvrtko)
v4: Change eu_mask helper into sseu_set_eus() (Tvrtko)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_debugfs.c | 25 ++--
drivers/gpu/drm/i915/i915_drv.c
the coding style (Lionel)
v7: Add i915_query.h (Joonas)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/i915_drv.c | 2 ++
drivers/gpu/drm/i915/i915_query.c | 67 +++
drivers
Now that we have that information in topology fields, let's just reused it.
v2: Style tweaks (Tvrtko)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_debugfs.c | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
Signed-off-by: Lionel Landwerlin
---
drivers/gpu/drm/i915/i915_drv.c | 212 ++--
1 file changed, 119 insertions(+), 93 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index ebb2e4241cf7..cc0342e8a400 100644
--- a
device in one ioctl
(Chris' suggestion).
Would be great to land !RFC if people are okay with it.
Cheers,
Lionel Landwerlin (8):
drm/i915: store all subslice masks
drm/i915/debugfs: reuse max slice/subslices already stored in sseu
drm/i915/debugfs: add rcs topology entry
drm/i915: ad
On 24/01/18 15:14, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2018-01-24 12:03:46)
On 23/01/2018 14:17, Lionel Landwerlin wrote:
Hi all,
I've been trying to expose some information to userspace about the fused
parts of the GPU.
This is the 4th attempt at getting this upstream, here ar
On 29/01/18 09:02, Chris Wilson wrote:
Quoting Lionel Landwerlin (2018-01-29 08:33:46)
This reverts commit 5b54eddd3920e9f6f1a6d972454baf350cbae77e.
Conflicts:
drivers/gpu/drm/i915/i915_pci.c
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104805
Fixes: 5b54eddd3920 (&quo
This reverts commit 5b54eddd3920e9f6f1a6d972454baf350cbae77e.
Conflicts:
drivers/gpu/drm/i915/i915_pci.c
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104805
Signed-off-by: Lionel Landwerlin
---
drivers/gpu/drm/i915/i915_pci.c | 96 -
1
lly wouldn't like to rewrite this one more time and get turned down
because this isn't to the taste of one of the reviewer.
So my question is : Is everybody happy with what Joonas is proposing?
Anybody in favor of having a generic mechanism?
Thanks a lot,
-
Lionel
On 22/01/18 08:21, Lione
uapi comments style to match the coding style (Lionel)
v9: Fix error in comment about computation of enabled subslice (Tvrtko)
Signed-off-by: Lionel Landwerlin
---
drivers/gpu/drm/i915/i915_query.c | 110 ++
include/uapi/drm/i915_drm
Hi all,
Just another update with only one change to the last patch (fixing a
comment).
Cheers,
Lionel Landwerlin (6):
drm/i915: store all subslice masks
drm/i915/debugfs: reuse max slice/subslices already stored in sseu
drm/i915/debugfs: add rcs topology entry
drm/i915: add rcs topology
This might be useful information for developers looking at an error
state.
v2: Place topology towards the end of the error state (Chris)
v3: Reuse common printing code (Michal)
v4: Make this a one-liner (Chris)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm
Now that we have that information in topology fields, let's just reused it.
v2: Style tweaks (Tvrtko)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_debugfs.c | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
lice2: 8 EUs (0xff)
subslice3: 0 EUs (0x0)
v2: Reformat debugfs printing (Tvrtko)
Use the new EU mask helper (Tvrtko)
v3: Move printing code to intel_device_info.c to be shared with error
state (Michal)
Suggested-by: Chris Wilson
Signed-off-by: Lionel Landwerlin
Reviewed-by: T
setting eu_mask on CHV (Tvrtko)
Reformat debug prints for subslices (Tvrtko)
v4: Change eu_mask helper into sseu_set_eus() (Tvrtko)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_debugfs.c | 25 ++--
drivers/gpu/drm/i915/i915_drv.c
the coding style (Lionel)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/i915_drv.c | 1 +
drivers/gpu/drm/i915/i915_drv.h | 3 ++
drivers/gpu/drm/i915/i915_query.c | 67
On 19/01/18 14:24, Tvrtko Ursulin wrote:
On 19/01/2018 13:22, Lionel Landwerlin wrote:
With the introduction of asymmetric slices in CNL, we cannot rely on
the previous SUBSLICE_MASK getparam to tell userspace what subslices
are available. Here we introduce a more detailed way of querying the
Now that we have that information in topology fields, let's just reused it.
v2: Style tweaks (Tvrtko)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_debugfs.c | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
uapi comments style to match the coding style (Lionel)
Signed-off-by: Lionel Landwerlin
Cc: Joonas Lahtinen
---
drivers/gpu/drm/i915/i915_query.c | 110 ++
include/uapi/drm/i915_drm.h | 71
2 files changed, 181 insertions(+)
Hi all,
This is hopefully the last iteration with a last tweak on comments for
coding style.
Cheers,
Lionel Landwerlin (6):
drm/i915: store all subslice masks
drm/i915/debugfs: reuse max slice/subslices already stored in sseu
drm/i915/debugfs: add rcs topology entry
drm/i915: add rcs
the coding style (Lionel)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
Cc: Joonas Lahtinen
---
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/i915_drv.c | 1 +
drivers/gpu/drm/i915/i915_drv.h | 3 ++
drivers/gpu/drm/i915/i915_query.c | 67
This might be useful information for developers looking at an error
state.
v2: Place topology towards the end of the error state (Chris)
v3: Reuse common printing code (Michal)
v4: Make this a one-liner (Chris)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm
setting eu_mask on CHV (Tvrtko)
Reformat debug prints for subslices (Tvrtko)
v4: Change eu_mask helper into sseu_set_eus() (Tvrtko)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_debugfs.c | 25 ++--
drivers/gpu/drm/i915/i915_drv.c
lice2: 8 EUs (0xff)
subslice3: 0 EUs (0x0)
v2: Reformat debugfs printing (Tvrtko)
Use the new EU mask helper (Tvrtko)
v3: Move printing code to intel_device_info.c to be shared with error
state (Michal)
Suggested-by: Chris Wilson
Signed-off-by: Lionel Landwerlin
Reviewed-by: T
On 18/01/18 15:36, Chris Wilson wrote:
Quoting Lionel Landwerlin (2018-01-18 15:22:27)
On 18/01/18 15:18, Chris Wilson wrote:
Quoting Lionel Landwerlin (2018-01-18 14:45:31)
+static int query_slice_info(struct drm_i915_private *dev_priv,
+ struct drm_i915_query_item
On 18/01/18 15:18, Chris Wilson wrote:
Quoting Lionel Landwerlin (2018-01-18 14:45:31)
+static int query_slice_info(struct drm_i915_private *dev_priv,
+ struct drm_i915_query_item *query_item)
+{
+ const struct sseu_dev_info *sseu = &INTEL_INFO(dev_priv)-&
On 18/01/18 12:46, Tvrtko Ursulin wrote:
On 17/01/2018 15:39, Lionel Landwerlin wrote:
With the introduction of asymmetric slices in CNL, we cannot rely on
the previous SUBSLICE_MASK getparam to tell userspace what subslices
are available. Here we introduce a more detailed way of querying the
(Chris)
Return error on flags field != 0 (Chris)
Only copy length back to userspace in drm_i915_query_item (Chris)
v4: Use array of functions instead of switch (Chris)
v5: More comments in uapi (Tvrtko)
Return query item errors in length field (All)
Signed-off-by: Lionel Landwerlin
This might be useful information for developers looking at an error
state.
v2: Place topology towards the end of the error state (Chris)
v3: Reuse common printing code (Michal)
v4: Make this a one-liner (Chris)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm
itting (Tvrtko)
tweak uapi struct/define names (Tvrtko)
v5: Replace ALIGN() macro (Chris)
v6: Updated uapi comments (Tvrtko)
Moved flags != 0 checks into vfuncs (Tvrtko)
v7: Use access_ok() before copying anything, to avoid overflows (Chris)
Switch BUG_ON() to GEM_WARN_ON() (Tvrtko)
Signed-
lice2: 8 EUs (0xff)
subslice3: 0 EUs (0x0)
v2: Reformat debugfs printing (Tvrtko)
Use the new EU mask helper (Tvrtko)
v3: Move printing code to intel_device_info.c to be shared with error
state (Michal)
Suggested-by: Chris Wilson
Signed-off-by: Lionel Landwerlin
Reviewed-by: T
Now that we have that information in topology fields, let's just reused it.
v2: Style tweaks (Tvrtko)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_debugfs.c | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
setting eu_mask on CHV (Tvrtko)
Reformat debug prints for subslices (Tvrtko)
v4: Change eu_mask helper into sseu_set_eus() (Tvrtko)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_debugfs.c | 25 ++--
drivers/gpu/drm/i915/i915_drv.c
Hi all,
This looks like the last iteration :)
Cheers,
Lionel Landwerlin (6):
drm/i915: store all subslice masks
drm/i915/debugfs: reuse max slice/subslices already stored in sseu
drm/i915/debugfs: add rcs topology entry
drm/i915: add rcs topology to error state
drm/i915: add query
On 17/01/18 15:50, Lionel Landwerlin wrote:
On 17/01/18 15:39, Lionel Landwerlin wrote:
With the introduction of asymmetric slices in CNL, we cannot rely on
the previous SUBSLICE_MASK getparam to tell userspace what subslices
are available. Here we introduce a more detailed way of querying the
On 17/01/18 15:39, Lionel Landwerlin wrote:
With the introduction of asymmetric slices in CNL, we cannot rely on
the previous SUBSLICE_MASK getparam to tell userspace what subslices
are available. Here we introduce a more detailed way of querying the
Gen's GPU topology that doesn't
This might be useful information for developers looking at an error
state.
v2: Place topology towards the end of the error state (Chris)
v3: Reuse common printing code (Michal)
v4: Make this a one-liner (Chris)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm
(Chris)
Return error on flags field != 0 (Chris)
Only copy length back to userspace in drm_i915_query_item (Chris)
v4: Use array of functions instead of switch (Chris)
v5: More comments in uapi (Tvrtko)
Return query item errors in length field (All)
Signed-off-by: Lionel Landwerlin
Now that we have that information in topology fields, let's just reused it.
v2: Style tweaks (Tvrtko)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_debugfs.c | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
setting eu_mask on CHV (Tvrtko)
Reformat debug prints for subslices (Tvrtko)
v4: Change eu_mask helper into sseu_set_eus() (Tvrtko)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_debugfs.c | 25 ++--
drivers/gpu/drm/i915/i915_drv.c
lice2: 8 EUs (0xff)
subslice3: 0 EUs (0x0)
v2: Reformat debugfs printing (Tvrtko)
Use the new EU mask helper (Tvrtko)
v3: Move printing code to intel_device_info.c to be shared with error
state (Michal)
Suggested-by: Chris Wilson
Signed-off-by: Lionel Landwerlin
Reviewed-by: T
itting (Tvrtko)
tweak uapi struct/define names (Tvrtko)
v5: Replace ALIGN() macro (Chris)
v6: Updated uapi comments (Tvrtko)
Moved flags != 0 checks into vfuncs (Tvrtko)
Signed-off-by: Lionel Landwerlin
---
drivers/gpu/drm/i915/i915_query.c | 105 ++
in
al
version ;)
Thanks all for the great feedback,
Lionel Landwerlin (6):
drm/i915: store all subslice masks
drm/i915/debugfs: reuse max slice/subslices already stored in sseu
drm/i915/debugfs: add rcs topology entry
drm/i915: add rcs topology to error state
drm/i915: add query uAPI
drm/i9
On 17/01/18 10:10, Tvrtko Ursulin wrote:
On 16/01/2018 19:18, Lionel Landwerlin wrote:
There are a number of information that are readable from hardware
registers and that we would like to make accessible to userspace. One
particular example is the topology of the execution units (how are
On 16/01/18 21:48, Chris Wilson wrote:
Quoting Lionel Landwerlin (2018-01-16 19:18:24)
diff --git a/drivers/gpu/drm/i915/i915_query.c
b/drivers/gpu/drm/i915/i915_query.c
index 51736af7f573..038f292e1f2a 100644
--- a/drivers/gpu/drm/i915/i915_query.c
+++ b/drivers/gpu/drm/i915/i915_query.c
On 16/01/18 21:34, Chris Wilson wrote:
Quoting Lionel Landwerlin (2018-01-16 16:07:28)
Signed-off-by: Lionel Landwerlin
---
tests/Makefile.sources | 1 +
tests/meson.build | 1 +
tests/query.c | 268 +
3 files changed, 270
On 16/01/18 21:38, Chris Wilson wrote:
Quoting Chris Wilson (2018-01-16 21:34:34)
Quoting Lionel Landwerlin (2018-01-16 16:07:28)
Signed-off-by: Lionel Landwerlin
---
tests/Makefile.sources | 1 +
tests/meson.build | 1 +
tests/query.c | 268
On 16/01/18 17:40, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2018-01-16 16:22:52)
On 16/01/2018 16:02, Lionel Landwerlin wrote:
diff --git a/drivers/gpu/drm/i915/i915_query.c
b/drivers/gpu/drm/i915/i915_query.c
index 6468ca613d27..81367c8224ee 100644
--- a/drivers/gpu/drm/i915/i915_query.c
itting (Tvrtko)
tweak uapi struct/define names (Tvrtko)
v5: Replace ALIGN() macro (Chris)
Signed-off-by: Lionel Landwerlin
---
drivers/gpu/drm/i915/i915_query.c | 94 +++
include/uapi/drm/i915_drm.h | 68
2 files changed, 162 inser
(Chris)
Return error on flags field != 0 (Chris)
Only copy length back to userspace in drm_i915_query_item (Chris)
v4: Use array of functions instead of switch (Chris)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm
Now that we have that information in topology fields, let's just reused it.
v2: Style tweaks (Tvrtko)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_debugfs.c | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
This might be useful information for developers looking at an error
state.
v2: Place topology towards the end of the error state (Chris)
v3: Reuse common printing code (Michal)
v4: Make this a one-liner (Chris)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm
lice2: 8 EUs (0xff)
subslice3: 0 EUs (0x0)
v2: Reformat debugfs printing (Tvrtko)
Use the new EU mask helper (Tvrtko)
v3: Move printing code to intel_device_info.c to be shared with error
state (Michal)
Suggested-by: Chris Wilson
Signed-off-by: Lionel Landwerlin
Reviewed-by: T
A few tweaks following comments from Chris.
Cheers,
Lionel Landwerlin (6):
drm/i915: store all subslice masks
drm/i915/debugfs: reuse max slice/subslices already stored in sseu
drm/i915/debugfs: add rcs topology entry
drm/i915: add rcs topology to error state
drm/i915: add query uAPI
setting eu_mask on CHV (Tvrtko)
Reformat debug prints for subslices (Tvrtko)
v4: Change eu_mask helper into sseu_set_eus() (Tvrtko)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_debugfs.c | 25 ++--
drivers/gpu/drm/i915/i915_drv.c
Signed-off-by: Lionel Landwerlin
---
tests/Makefile.sources | 1 +
tests/meson.build | 1 +
tests/query.c | 268 +
3 files changed, 270 insertions(+)
create mode 100644 tests/query.c
diff --git a/tests/Makefile.sources b/tests
Signed-off-by: Lionel Landwerlin
---
include/drm-uapi/i915_drm.h | 126
lib/igt_perf.h | 7 ---
2 files changed, 126 insertions(+), 7 deletions(-)
diff --git a/include/drm-uapi/i915_drm.h b/include/drm-uapi/i915_drm.h
index 7f28eea4
lice2: 8 EUs (0xff)
subslice3: 0 EUs (0x0)
v2: Reformat debugfs printing (Tvrtko)
Use the new EU mask helper (Tvrtko)
v3: Move printing code to intel_device_info.c to be shared with error
state (Michal)
Suggested-by: Chris Wilson
Signed-off-by: Lionel Landwerlin
Reviewed-by: T
This might be useful information for developers looking at an error
state.
v2: Place topology towards the end of the error state (Chris)
v3: Reuse common printing code (Michal)
v4: Make this a one-liner (Chris)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm
Hi again,
A few more changes following Chris' comments.
Cheers,
Lionel Landwerlin (6):
drm/i915: store all subslice masks
drm/i915/debugfs: reuse max slice/subslices already stored in sseu
drm/i915/debugfs: add rcs topology entry
drm/i915: add rcs topology to error state
drm/i915
Now that we have that information in topology fields, let's just reused it.
v2: Style tweaks (Tvrtko)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_debugfs.c | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
itting (Tvrtko)
tweak uapi struct/define names (Tvrtko)
v5: Replace ALIGN() macro (Chris)
Signed-off-by: Lionel Landwerlin
---
drivers/gpu/drm/i915/i915_query.c | 108 +-
include/uapi/drm/i915_drm.h | 54 +++
2 files changed, 161 insertions(
setting eu_mask on CHV (Tvrtko)
Reformat debug prints for subslices (Tvrtko)
v4: Change eu_mask helper into sseu_set_eus() (Tvrtko)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_debugfs.c | 25 ++--
drivers/gpu/drm/i915/i915_drv.c
(Chris)
Return error on flags field != 0 (Chris)
Only copy length back to userspace in drm_i915_query_item (Chris)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/i915_drv.c | 1 +
drivers/gpu/drm/i915
On 16/01/18 14:22, Chris Wilson wrote:
Quoting Lionel Landwerlin (2018-01-16 13:40:10)
With the introduction of asymmetric slices in CNL, we cannot rely on
the previous SUBSLICE_MASK getparam to tell userspace what subslices
are available. Here we introduce a more detailed way of querying the
On 16/01/18 14:08, Chris Wilson wrote:
Quoting Lionel Landwerlin (2018-01-16 13:40:09)
+int i915_query_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
+{
+ struct drm_i915_query *args = data;
+ struct drm_i915_query_item __user *user_item_ptr
On 16/01/18 13:57, Chris Wilson wrote:
Quoting Lionel Landwerlin (2018-01-16 13:40:08)
This might be useful information for developers looking at an error
state.
v2: Place topology towards the end of the error state (Chris)
v3: Reuse common printing code (Michal)
Signed-off-by: Lionel
Now that we have that information in topology fields, let's just reused it.
v2: Style tweaks (Tvrtko)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_debugfs.c | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
Hi all,
Hopefully this is the last iteration. A few more tweaks only on patch
6 for uapi define/struct naming and factored out code in the data
exchange between kernel & userspace.
Thanks,
Lionel Landwerlin (6):
drm/i915: store all subslice masks
drm/i915/debugfs: reuse max slice/subsl
setting eu_mask on CHV (Tvrtko)
Reformat debug prints for subslices (Tvrtko)
v4: Change eu_mask helper into sseu_set_eus() (Tvrtko)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_debugfs.c | 25 ++--
drivers/gpu/drm/i915/i915_drv.c
lice2: 8 EUs (0xff)
subslice3: 0 EUs (0x0)
v2: Reformat debugfs printing (Tvrtko)
Use the new EU mask helper (Tvrtko)
v3: Move printing code to intel_device_info.c to be shared with error
state (Michal)
Suggested-by: Chris Wilson
Signed-off-by: Lionel Landwerlin
Reviewed-by: T
itting (Tvrtko)
tweak uapi struct/define names (Tvrtko)
Signed-off-by: Lionel Landwerlin
---
drivers/gpu/drm/i915/i915_query.c | 107 ++
include/uapi/drm/i915_drm.h | 53 +++
2 files changed, 160 insertions(+)
diff --git a/drivers/gpu/drm/i91
This might be useful information for developers looking at an error
state.
v2: Place topology towards the end of the error state (Chris)
v3: Reuse common printing code (Michal)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_gpu_error.c | 9
copy of the data to the pointed memory locations.
The scope of this uAPI is only to provide information to userspace,
not to allow configuration of the device.
v2: Simplify dispatcher code iteration (Tvrtko)
Tweak uapi drm_i915_query_item structure (Tvrtko)
Signed-off-by: Lionel Landwerlin
On 15/01/18 17:43, Tvrtko Ursulin wrote:
On 15/01/2018 14:41, Lionel Landwerlin wrote:
This might be useful information for developers looking at an error
state.
v2: Place topology towards the end of the error state (Chris)
v3: Reuse common printing code (Michal)
Signed-off-by: Lionel
1201 - 1300 of 2233 matches
Mail list logo
