On Tue, Mar 07, 2023 at 05:23:37PM -0300, Gustavo Sousa wrote:
> On Tue, Mar 07, 2023 at 12:12:46PM -0800, Matt Roper wrote:
> > On Tue, Mar 07, 2023 at 12:22:38AM -0300, Gustavo Sousa wrote:
> > > Wa_1606376872 applies to all Xe_LP IPs.
> >
> > "...e
On Tue, Mar 07, 2023 at 12:22:38AM -0300, Gustavo Sousa wrote:
> Wa_1606376872 applies to all Xe_LP IPs.
"...except DG1"
Aside from that,
Reviewed-by: Matt Roper
>
> Signed-off-by: Gustavo Sousa
> ---
> drivers/gpu/drm/i915/gt/intel_gt_regs.h | 3 +++
&
ible payload.
>
> v2:
> - Tighten payload size limit. (Matt, Rodrigo)
> - Use a better name for the defined payload limit. (Rodrigo)
>
> Signed-off-by: Madhumitha Tolakanahalli Pradeep
>
> Signed-off-by: Gustavo Sousa
> Cc: Rodrigo Vivi
> Cc: Matt Rop
> - gen11_gt_irq_postinstall(gt);
> > > + for_each_gt(gt, dev_priv, i) {
> > > + gen11_gt_irq_postinstall(gt);
> > >
> > > - GEN3_IRQ_INIT(uncore, GEN11_GU_MISC_, ~gu_misc_masked,
> > gu_misc_masked);
> > > + GEN3_IRQ_INIT(gt->uncore, GEN
tatic void dg1_ctx_workarounds_init(struct
> intel_engine_cs *engine,
> /* Wa_22010493298 */
> wa_masked_en(wal, HIZ_CHICKEN,
>DG1_HZ_READ_SUPPRESSION_OPTIMIZATION_DISABLE);
> +
> + /* Wa_1806527549 */
> + wa_masked_en(wal, HIZ_CHICKEN, HZ_DEPTH_TEST_LE_GE_OPT_DISABLE);
> }
>
>
On Mon, Mar 06, 2023 at 12:49:53PM -0800, Lucas De Marchi wrote:
> Use gt_tuning_settings() for the recommended tunings rather than the one
> for workarounds.
>
> Signed-off-by: Lucas De Marchi
Reviewed-by: Matt Roper
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 1
On Mon, Mar 06, 2023 at 12:49:52PM -0800, Lucas De Marchi wrote:
> dg1_gt_workarounds_init() is only ever called for DG1, so there is no
> point checking it again.
>
> Signed-off-by: Lucas De Marchi
Reviewed-by: Matt Roper
> ---
> drivers/gpu/drm/i915/gt/intel_
; - intel_uncore_posting_read(uncore, DG1_MSTR_TILE_INTR);
> + dg1_master_intr_enable(to_gt(dev_priv)->uncore->regs);
> + intel_uncore_posting_read(to_gt(dev_priv)->uncore, DG1_MSTR_TILE_INTR);
> }
>
> static void cherryview_irq_postinstall(struct drm_i915_private *dev_priv)
> --
> 2.34.1
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
MTL_PIPEDMC_GATING_DIS_A REG_BIT(15)
> +#define MTL_PIPEDMC_GATING_DIS_B REG_BIT(14)
> +#define PWM2_GATING_DISREG_BIT(14)
> +#define MTL_PIPEDMC_GATING_DIS_C REG_BIT(13)
> +#define PWM1_GATING_DISREG_BIT(13)
> +#define MTL_PIPEDMC_GATING_DI
dmc->fw_path = MTL_DMC_PATH;
> + dmc->max_fw_size = MTL_DMC_MAX_FW_SIZE;
> + } else if (IS_DG2(dev_priv)) {
> dmc->fw_path = DG2_DMC_PATH;
> dmc->max_fw_size = DISPLAY_VER13_DMC_MAX_FW_SIZE;
> } else if (IS_ALDERLAKE_P(dev_priv)) {
> --
> 2.39.2
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
://gitlab.freedesktop.org/drm/intel/issues/6248
> [i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259
> [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
> [i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
> [i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
> [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
> [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
> [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
> [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
> [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
> [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
> [i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
> [i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
> [i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
> [i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
> [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
> [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
> [i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
> [i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
> [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
> [i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
> [i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
> [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
> [i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
> [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
> [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
> [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
> [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
> [i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
> [i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957
> [i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152
> [i915#8154]: https://gitlab.freedesktop.org/drm/intel/issues/8154
> [i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
>
>
> Build changes
> -
>
> * Linux: CI_DRM_12794 -> Patchwork_114199v4
>
> CI-20190529: 20190529
> CI_DRM_12794: 09f45ee84b4e66b882286806fb4b2b03907db5dc @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7176: ffe88a907c0fafe6a736f5f17cee8ba8eddd6fa7 @
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_114199v4: 09f45ee84b4e66b882286806fb4b2b03907db5dc @
> git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114199v4/index.html
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
for SAMedia")
> Signed-off-by: Badal Nilawar
Reviewed-by: Matt Roper
> ---
> drivers/gpu/drm/i915/gt/intel_gt_pm.c | 4 ++--
> drivers/gpu/drm/i915/gt/uc/intel_guc_rc.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/dr
ps://gitlab.freedesktop.org/drm/intel/issues/6252
> [i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
> [i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
> [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
> [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
> [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
> [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
> [i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
> [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
> [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
> [i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
> [i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
> [i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
> [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
> [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
> [i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
> [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
> [i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
> [i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
> [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
> [i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
> [i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
> [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
> [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
> [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
> [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
> [i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
> [i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957
> [i915#7984]: https://gitlab.freedesktop.org/drm/intel/issues/7984
> [i915#8151]: https://gitlab.freedesktop.org/drm/intel/issues/8151
> [i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152
>
>
> Build changes
> -
>
> * Linux: CI_DRM_12774 -> Patchwork_114317v1
>
> CI-20190529: 20190529
> CI_DRM_12774: 51ea055cc2f62af7e9556def2dadb244a6d396c6 @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7171: 35a09092eabf7e55aeb625720634550a0368dde6 @
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_114317v1: 51ea055cc2f62af7e9556def2dadb244a6d396c6 @
> git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114317v1/index.html
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
evice_info.h | 1 +
> include/drm/i915_pciids.h | 12 ++
> 5 files changed, 44 insertions(+), 4 deletions(-)
>
> --
> 2.25.1
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
ELECT_MASK, val)
> +#define XELPDP_DDI_CLOCK_SELECT_NONE 0x0
> +#define XELPDP_DDI_CLOCK_SELECT_MAXPCLK 0x8
> +#define XELPDP_DDI_CLOCK_SELECT_DIV18CLK 0x9
> +#define XELPDP_DDI_CLOCK_SELECT_TBT_162 0xc
> +#define XELPDP_DDI_CLOCK_SELECT_TBT
rg/drm/intel/issues/6333
> [i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
> [i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
> [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
> [i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
> [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
> [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
> [i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
> [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
> [i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
> [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
> [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
> [i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
> [i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
> [i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
> [i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
> [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
> [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
> [i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
> [i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
> [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
> [i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
> [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
> [i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
> [i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
> [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
> [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
> [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
> [i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
> [i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957
> [i915#8150]: https://gitlab.freedesktop.org/drm/intel/issues/8150
> [i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152
>
>
> Build changes
> -
>
> * Linux: CI_DRM_12768 -> Patchwork_114233v2
>
> CI-20190529: 20190529
> CI_DRM_12768: d9a0aa492e367314a1681974bf178363a4b5587a @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7168: 165df656261863684067cd53f95c3a301e67fa24 @
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_114233v2: d9a0aa492e367314a1681974bf178363a4b5587a @
> git://anongit.freedesktop.org/gfx-ci/linux
>
> == Logs ==
>
> For more details see:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114233v2/index.html
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
t; INTEL_RPLP_IDS(_p_info),
> + INTEL_RPLU_IDS(_p_info),
> INTEL_DG2_IDS(_info),
> INTEL_ATS_M_IDS(_m_info),
> INTEL_MTL_IDS(_info),
> --
> 2.39.1
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
lab.freedesktop.org/drm/intel/issues/6497
> [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
> [i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
> [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
> [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
> [i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
> [i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
> [i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
> [i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
> [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
> [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
> [i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
> [i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
> [i915#7479]: https://gitlab.freedesktop.org/drm/intel/issues/7479
> [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
> [i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
> [i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
> [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
> [i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
> [i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
> [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
> [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
> [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
> [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
> [i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
> [i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957
> [i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
> [i915#8151]: https://gitlab.freedesktop.org/drm/intel/issues/8151
> [i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152
> [i915#8154]: https://gitlab.freedesktop.org/drm/intel/issues/8154
>
>
> Build changes
> -
>
> * Linux: CI_DRM_12774 -> Patchwork_114159v2
>
> CI-20190529: 20190529
> CI_DRM_12774: 51ea055cc2f62af7e9556def2dadb244a6d396c6 @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7171: 35a09092eabf7e55aeb625720634550a0368dde6 @
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_114159v2: 51ea055cc2f62af7e9556def2dadb244a6d396c6 @
> git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114159v2/index.html
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
d-off-by: Lucas De Marchi
Reviewed-by: Matt Roper
> ---
> drivers/gpu/drm/i915/gt/intel_gt_regs.h | 2 --
> drivers/gpu/drm/i915/i915_reg_defs.h| 2 ++
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> b/dri
-by: Rodrigo Vivi
Reviewed-by: Matt Roper
> ---
> drivers/gpu/drm/i915/display/intel_backlight.c | 11 ---
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_backlight.c
> b/drivers/gpu/drm/i915/display/intel_backlig
es/6344
> [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
> [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
> [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
> [i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6
47982
Reviewed-by: Matt Roper
> ---
> .../i915/gem/selftests/i915_gem_client_blt.c | 19 +--
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_client_blt.c
> b/drivers/gpu/drm/i915/gem/selfte
+ b/drivers/gpu/drm/i915/gt/uc/intel_guc_rc.c
> > @@ -19,7 +19,7 @@ static bool __guc_rc_supported(struct intel_guc *guc)
> > * Do not enable gucrc to avoid additional interrupts which
> > * may disrupt pcode wa.
> > */
> > - if (IS_MTL_GRAPHICS_STEP(gt->i915, P, STEP_A0, STEP_B0) &&
> > + if (IS_METEORLAKE(gt->i915) && INTEL_REVID(gt->i915) == 0 &&
> > gt->type == GT_MEDIA)
> > return false;
> >
> > --
> > 2.25.1
> >
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
On Thu, Feb 23, 2023 at 10:08:51AM +0100, Andrzej Hajda wrote:
> On 17.02.2023 19:54, Matt Roper wrote:
> > MTL's primary GT can continue to use the same engine TLB invalidation
> > programming as past Xe_HP-based platforms. However the media GT needs
> >
Ursulin
Cc: Daniele Ceraolo Spurio
Cc: Andrzej Hajda
Signed-off-by: Matt Roper
Reviewed-by: Andrzej Hajda
---
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 52 ---
drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 +
2 files changed, 38 insertions(+), 15 deletions(-)
diff --git
A recommended tuning setting for both gen12 and Xe_HP platforms requires
that we grant userspace r/w access to the COMMON_SLICE_CHICKEN3
register.
Bspec: 73993, 73994, 31870, 68331
Cc: Dongwon Kim
Signed-off-by: Matt Roper
---
The bspec update to add COMMON_SLICE_CHICKEN3 to the tuning guide
Xe_HP architecture already makes the CS_CTX_TIMESTAMP readable by
userspace on all engines; there's no longer a need to add it to the
software-managed whitelist for the non-RCS engines.
Bspec: 45545
Signed-off-by: Matt Roper
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 11 +--
1
an area of 4x1 tiles in the main surface. The main surface
> + * pitch is required to be a multiple of 4 tile widths.
> + */
> +#define I915_FORMAT_MOD_4_TILED_MTL_RC_CCS_CC fourcc_mod_code(INTEL, 15)
> +
> /*
> * Tiled, NV12MT, grouped in 64 (pixels) x 32 (lines) -sized macroblocks
> *
> --
> 2.34.1
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
t(struct drm_i915_private
> *i915, struct intel_fb_vi
> memset(view, 0, sizeof(*view));
> view->gtt.type = view_type;
>
> - if (view_type == I915_GTT_VIEW_REMAPPED && IS_ALDERLAKE_P(i915))
> + if (view_type == I915_GTT_VIEW_REMAPPED &&
>
in the commit message too.
Matt
>
> Cc: Matt Roper
> Signed-off-by: Pallavi Mishra
> Signed-off-by: Radhakrishna Sripada
> ---
> drivers/gpu/drm/i915/gt/intel_migrate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i91
EN but doing this way allow us to sanitize the phy
> latch during driver load.
>
> BSpec: 49197
> Cc: Matt Roper
> Signed-off-by: José Roberto de Souza
> Signed-off-by: Radhakrishna Sripada
Reviewed-by: Matt Roper
> ---
> drivers/gpu/drm/i915/display/intel_display
iled to remap framebuffer into
> virtual memory (%pe)\n", vaddr);
> + ret = PTR_ERR(vaddr);
> + continue;
> + }
> }
> +
> + if (ret)
> + goto out_unpin;
> +
> info->screen_base = vaddr;
> info->screen_size = vma->size;
>
> --
> 2.34.1
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
?
Matt
> +
> guc_log_relay_chan = relay_open("guc_log",
> - dev_priv->drm.primary->debugfs_root,
> + guc->dbgfs_node,
> subbuf_size, n_subbufs,
> _callbacks, dev_priv);
> if (!guc_log_relay_chan) {
> --
> 2.34.1
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
13)
> +#define DARBF_GATING_DIS REG_BIT(27)
> +#define MTL_PIPEDMC_GATING_DIS_A REG_BIT(15)
> +#define MTL_PIPEDMC_GATING_DIS_B REG_BIT(14)
> +#define PWM2_GATING_DISREG_BIT(14)
> +#define MTL_PIPEDMC_GATING_DIS_C REG_BIT(13)
> +#define PWM1_GATING_DISREG_BIT(13)
> +#define MTL_PIPEDMC_GATING_DIS_D REG_BIT(12)
>
> #define GEN9_CLKGATE_DIS_3 _MMIO(0x46538)
> #define TGL_VRH_GATING_DIS REG_BIT(31)
> --
> 2.34.1
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
lanes.
Bspec: 49291
Signed-off-by: Matt Roper
---
drivers/gpu/drm/i915/display/intel_combo_phy.c | 5 ++---
drivers/gpu/drm/i915/display/intel_combo_phy_regs.h | 4 ++--
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c
b/drivers/gpu
On Tue, Feb 21, 2023 at 11:30:38AM -0800, Matt Roper wrote:
> The bspec was updated with a minor change to the 'DCC mode select'
> setting to be programmed during combo PHY initialization.
>
> Bspec: 49291
> Signed-off-by: Matt Roper
> ---
> drivers/gpu/drm/i915/disp
The bspec was updated with a minor change to the 'DCC mode select'
setting to be programmed during combo PHY initialization.
Bspec: 49291
Signed-off-by: Matt Roper
---
drivers/gpu/drm/i915/display/intel_combo_phy.c | 9 +++--
drivers/gpu/drm/i915/display/intel_combo_phy_regs.h | 4
max_subslices in the eu_mask
> > struct.
> >
> > Reported-by: Emil Renner Berthing
> > Signed-off-by: Andrea Righi
>
> Looks like bug was probably introduced in:
>
> Fixes: bc3c5e0809ae ("drm/i915/sseu: Don't try to store EU mask internally in
engine instance, it inexplicably
uses bit 1 to request invalidations rather than bit 0.
Cc: Tvrtko Ursulin
Cc: Daniele Ceraolo Spurio
Signed-off-by: Matt Roper
---
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 52 ---
drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 +
2 files
(Andrzej)
>
> v5:
> * Tidy checkpatch warnings.
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Andrzej Hajda
> Cc: Matt Roper
> Reviewed-by: Andrzej Hajda # v1
> Reviewed-by: Matt Roper # v3
Reviewed-by: Matt Roper
for this version as well.
Matt
> Signed-of
> useful). Drop a few more hints into the log to aid in debugging.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Matt Roper
> ---
> drivers/gpu/drm/i915/display/intel_fb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel
ay.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Matt Roper
> ---
> drivers/gpu/drm/i915/display/intel_fb.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fb.c
> b/drivers/gpu/drm/i915/display/intel_
On Wed, Feb 15, 2023 at 11:48:13AM -0800, Sripada, Radhakrishna wrote:
>
>
> > -Original Message-
> > From: dri-devel On Behalf Of Matt
> > Roper
> > Sent: Monday, February 13, 2023 4:19 PM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: d
ttps://gitlab.freedesktop.org/drm/intel/issues/7582
> [i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
> [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
> [i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
> [i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
> [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
> [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
> [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
> [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
> [i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
> [i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957
> [i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
> [i915#8018]: https://gitlab.freedesktop.org/drm/intel/issues/8018
>
>
> Build changes
> -
>
> * Linux: CI_DRM_12734 -> Patchwork_113978v1
>
> CI-20190529: 20190529
> CI_DRM_12734: ffa7027c353c6821636559f42584dd11f527b0e0 @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7160: 45da871dd2684227e93a2fc002b87dfc58bd5fd9 @
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_113978v1: ffa7027c353c6821636559f42584dd11f527b0e0 @
> git://anongit.freedesktop.org/gfx-ci/linux
>
> == Logs ==
>
> For more details see:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113978v1/index.html
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
: a7ec65fc7e83 ("drm/i915/xelpmp: Add multicast steering for media GT")
Signed-off-by: Matt Roper
---
drivers/gpu/drm/i915/gt/intel_gt_mcr.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c
b/drivers/gpu/drm/i915/gt/intel_gt_m
f, and by doing so minimise the amount
> of invariant platform and engine checks during each and every TLB
> invalidation.
>
> v2:
> * Fail engine probe if TLB invlidations registers are unknown.
>
> v3:
> * Rebase.
>
> Signed-off-by: Tvrtko Ursulin
>
//gitlab.freedesktop.org/drm/intel/issues/7118
> [i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
> [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
> [i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
> [i915#7651]: https://gitlab.freedesktop.or
(Gustavo)
Cc: Gustavo Sousa
Signed-off-by: Matt Roper
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 70 -
1 file changed, 42 insertions(+), 28 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c
b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 88
The bspec was recently updated to remove PCI ID 0x5698; this ID is
actually reserved for future use and should not be treated as DG2-G11.
Bspec: 44477
Fixes: 8618b8489ba6 ("drm/i915: DG2 and ATS-M device ID updates")
Signed-off-by: Matt Roper
---
include/drm/i915_pciids.h | 1 -
1 fi
On Tue, Feb 07, 2023 at 01:06:19PM +0200, Jani Nikula wrote:
> The ucode part in the init, fini, suspend and resume function names is
> just unnecessary. Drop it.
>
> Cc: Imre Deak
> Signed-off-by: Jani Nikula
Reviewed-by: Matt Roper
> ---
> drivers/gpu/drm/i915/display
ncorrect type in
> argument 3 (different address spaces)
> drivers/gpu/drm/i915/intel_uncore.c:2494:16:expected void *data
> drivers/gpu/drm/i915/intel_uncore.c:2494:16:got void [noderef] __iomem
> *regs
>
> Cc: Matt Roper
> Signed-off-by: Jani Nikula
Revi
rs/gpu/drm/i915/gt/intel_gt_mcr.c:412:6: warning: context imbalance in
> 'intel_gt_mcr_unlock' - unexpected unlock
>
> Cc: Matt Roper
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/gt/intel_gt_mcr.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
On Mon, Feb 06, 2023 at 08:54:10AM -0800, Lucas De Marchi wrote:
> INF_UNIT_LEVEL_CLKGATE is not replicated, but since it's not actually
> used it can just be removed.
>
> Signed-off-by: Lucas De Marchi
Reviewed-by: Matt Roper
Looks like the only reference to the register
gt; [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
> [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
> [i915#7330]: https://gitlab.freedesktop.org/drm/intel/issues/7330
> [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
> [i915#
On Fri, Feb 03, 2023 at 10:03:49AM -0800, Lucas De Marchi wrote:
> On Thu, Feb 02, 2023 at 05:12:10PM -0800, Matt Roper wrote:
> > On Thu, Feb 02, 2023 at 04:57:08PM -0800, Lucas De Marchi wrote:
> > > Register 0x9424 is not replicated on any platform, so it shouldn't
d either add a new "GEN9" definition, or just go back to
using the GEN7 definition.
Matt
>
> Also use intel_uncore_rmw() rather than a read + write where possible.
>
> Fixes: a9e69428b1b4 ("drm/i915: Define MCR registers explicitly")
> Cc: Matt Roper
>
. As far as we know, there's never a case where a
register that lives outside the RENDER powerwell will be reset by an
RCS/CCS engine reset.
Signed-off-by: Matt Roper
---
.../gpu/drm/i915/gt/selftest_workarounds.c| 52 +++
1 file changed, 52 insertions(+)
diff --git a/drivers/gpu
. As such, we should implement this on the GT
workaround list rather than an engine list.
Bspec: 19219
Fixes: 3551ff928744 ("drm/i915/gen11: Moving WAs to rcs_engine_wa_init()")
Signed-off-by: Matt Roper
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 14 +++---
1 file
915: Define MCR registers explicitly")
Signed-off-by: Matt Roper
---
drivers/gpu/drm/i915/gt/intel_gt_regs.h | 4 ++--
drivers/gpu/drm/i915/gt/intel_workarounds.c | 12 +---
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
b/dri
the reset of a register that
lives outside the RENDER domain.
Re-applying these registers on engine resets wouldn't actually hurt
anything, but is unnecessary and just makes it more confusing to anyone
trying to decipher how these registers really work.
Signed-off-by: Matt Roper
---
drivers/gpu/d
edesktop.org/drm/intel/issues/7178
> [i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
> [i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
> [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
> [i915#7582]: https://gitlab.freedesktop.org/drm/
On Mon, Jan 30, 2023 at 12:19:48PM -0500, Rodrigo Vivi wrote:
> On Fri, Jan 27, 2023 at 02:43:12PM -0800, Matt Roper wrote:
> > Several post-DG1 platforms have been brought up now, so we're well past
> > the point where we usually drop the workarounds that are only applicable
>
On Mon, Jan 30, 2023 at 11:42:41AM -0500, Rodrigo Vivi wrote:
> On Mon, Jan 30, 2023 at 07:51:51AM -0800, Matt Roper wrote:
> > On Mon, Jan 30, 2023 at 10:46:16AM -0500, Rodrigo Vivi wrote:
> > > On Fri, Jan 27, 2023 at 02:43:11PM -0800, Matt Roper wrote:
> > > > S
On Mon, Jan 30, 2023 at 10:46:16AM -0500, Rodrigo Vivi wrote:
> On Fri, Jan 27, 2023 at 02:43:11PM -0800, Matt Roper wrote:
> > Several post-TGL platforms have been brought up now, so we're well past
> > the point where we usually drop the workarounds that are only applicable
>
the original TGL and the U/Y
subplatform).
Bspec 44455
Signed-off-by: Matt Roper
---
.../drm/i915/display/intel_display_power.c| 5 +--
drivers/gpu/drm/i915/display/intel_psr.c | 26 ---
.../drm/i915/display/skl_universal_plane.c| 2 +-
drivers/gpu/drm/i915/gt
in the driver forever. We can probably remove
some pre-production workarounds for RKL and ADL at this point as well,
but the bspec doesn't have details about which steppings were only used
in pre-production, so we'll need to track down that information later.
Matt Roper (3):
drm/i915/tgl: Drop support
All production DG1 hardware has graphics stepping B0; there is no such
thing as C0. As such, we can simplify
IS_DG1_GRAPHICS_STEP(uncore->i915, STEP_A0, STEP_C0)
to just match DG1 in general.
Bspec: 44463
Signed-off-by: Matt Roper
---
drivers/gpu/drm/i915/gt/intel_region_lmem.c
Several post-DG1 platforms have been brought up now, so we're well past
the point where we usually drop the workarounds that are only applicable
to internal/pre-production hardware.
Production DG1 hardware always has a B0 stepping for both display and
GT.
Bspec: 44463
Signed-off-by: Matt Roper
#define INTEL_RPLP_IDS(info) \
> > + INTEL_RPLU_IDS(info), \
> > - INTEL_VGA_DEVICE(0xA721, info), \
> > INTEL_VGA_DEVICE(0xA7A0, info), \
> > - INTEL_VGA_DEVICE(0xA7A1, info), \
> > - INTEL_VGA_DEVICE(0xA7A8, info), \
> > - INTEL_VGA_DEVICE(0xA7A9, info)
> > + INTEL_VGA_DEVICE(0xA7A8, info)
> >
> > With option 2, you also don't need to add INTEL_RPLU_IDS separately to
> > subplatform_rpl_ids[] or pciidlist[].
> >
> > I might lean towards option 2, but no strong opinions.
> >
>
> Thank you Jani for your suggestion. I am also inclined to the solution of
> adding RPLU IDs to RPLP platform.
>
> To summarize, we would add the INTEL_RPLU_IDS(info) into
> INTEL_RPLP_IDS(info). As Jani pointed out, with this, there is no need to
> add INTEL_RPLU_IDS separately to
> subplatform_rpl_ids[] or pciidlist[]. This also aligns with Bspec(55376) as
> RPL-U ids are listed under "RPL-P SKUs and Device IDs Info"
>
> @Matt: I remember, we had discussed a similar option in our communications.
> Do you have any strong opinion against it?
That sounds fine to me.
Thanks.
Matt
>
> If not I would go ahead with this implementation.
>
> Regards
>
> Chaitanya
>
> >
> > BR,
> > Jani.
> >
> >
> > >
> > > /* DG2 */
> > > #define INTEL_DG2_G10_IDS(info) \
> >
> > --
> > Jani Nikula, Intel Open Source Graphics Center
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
On Thu, Jan 26, 2023 at 10:46:01AM +, Tvrtko Ursulin wrote:
>
> On 25/01/2023 19:04, Matt Roper wrote:
> > On Wed, Jan 25, 2023 at 10:51:53AM +, Tvrtko Ursulin wrote:
> > >
> > > On 24/01/2023 20:54, john.c.harri...@intel.com wrote:
> > > > Fr
> [i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
> [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
> [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
> [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
> [i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
>
>
> Build changes
> -
>
> * Linux: CI_DRM_12640 -> Patchwork_113370v1
> * Piglit: piglit_4509 -> None
>
> CI-20190529: 20190529
> CI_DRM_12640: cc7783f223ac644092bb8788f0750fc5c68aa00e @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7136: 31b6af91747ad8c705399c9006cdb81cb1864146 @
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_113370v1: cc7783f223ac644092bb8788f0750fc5c68aa00e @
> git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113370v1/index.html
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
On Wed, Jan 25, 2023 at 03:41:58PM -0800, Matt Roper wrote:
> Workaround Wa_18018781329 has applied to several recent Xe_HP-based
> platforms. However there are some extra gotchas to implementing this
> properly for MTL that we need to take into account:
>
> * Due to the sepa
annotation, workarounds will always be properly applied in a
multicast manner on these platforms.
Cc: Gustavo Sousa
Fixes: 58bc2453ab8a ("drm/i915: Define multicast registers as a new type")
Signed-off-by: Matt Roper
Reviewed-by: Gustavo Sousa
---
drivers/gpu/drm/i915/gt/intel_gt_regs.
ot;drm/i915/dg2: Move misplaced 'ctx' & 'gt' wa's to engine
wa list")
Fixes: b2006061ae28 ("drm/i915/xehpsdv: Move render/compute engine reset
domains related workarounds")
Fixes: 41bb543f5598 ("drm/i915/mtl: Add initial gt workarounds")
Signed-off-by: Matt Roper
---
exist.
Cc: Gustavo Sousa
Signed-off-by: Matt Roper
---
drivers/gpu/drm/i915/gt/intel_gt_regs.h | 7 +--
drivers/gpu/drm/i915/gt/intel_workarounds.c | 22 ++---
drivers/gpu/drm/i915/i915_drv.h | 4
3 files changed, 24 insertions(+), 9 deletions(-)
diff
On Wed, Jan 25, 2023 at 04:43:29PM -0300, Gustavo Sousa wrote:
> On Tue, Jan 24, 2023 at 05:14:06PM -0800, Matt Roper wrote:
> > Register reset characteristics (i.e., whether the register maintains or
> > loses its value on engine reset) is an important factor that determines
>
int ret;
> > - drm_dbg(>drm, "Triggering Driver-FLR\n");
> > + gt_dbg(uncore->gt, "Triggering Driver-FLR\n");
> > /*
> > * Make sure any pending FLR requests have cleared by waiting for the
> > @@ -2738,9 +2733,7 @@ static void driver_initiated_flr(struct intel_uncore
> > *uncore)
> > */
> > ret = intel_wait_for_register_fw(uncore, GU_CNTL, DRIVERFLR, 0,
> > flr_timeout_ms);
> > if (ret) {
> > - drm_err(>drm,
> > - "Failed to wait for Driver-FLR bit to clear! %d\n",
> > - ret);
> > + gt_err(uncore->gt, "Failed to wait for Driver-FLR bit to clear!
> > %d\n", ret);
> > return;
> > }
> > intel_uncore_write_fw(uncore, GU_DEBUG, DRIVERFLR_STATUS);
> > @@ -2752,7 +2745,7 @@ static void driver_initiated_flr(struct intel_uncore
> > *uncore)
> > DRIVERFLR_STATUS, DRIVERFLR_STATUS,
> > flr_timeout_ms);
> > if (ret) {
> > - drm_err(>drm, "wait for Driver-FLR completion failed!
> > %d\n", ret);
> > + gt_err(uncore->gt, "wait for Driver-FLR completion failed!
> > %d\n", ret);
> > return;
> > }
> > @@ -2911,7 +2904,7 @@ intel_uncore_arm_unclaimed_mmio_detection(struct
> > intel_uncore *uncore)
> > {
> > bool ret = false;
> > - if (drm_WARN_ON(>i915->drm, !uncore->debug))
> > + if (gt_WARN_ON(uncore->gt, !uncore->debug))
> > return false;
> > spin_lock_irq(>debug->lock);
> > @@ -2921,10 +2914,10 @@ intel_uncore_arm_unclaimed_mmio_detection(struct
> > intel_uncore *uncore)
> > if (unlikely(check_for_unclaimed_mmio(uncore))) {
> > if (!uncore->i915->params.mmio_debug) {
> > - drm_dbg(>i915->drm,
> > - "Unclaimed register detected, "
> > - "enabling oneshot unclaimed register reporting.
> > "
> > - "Please use i915.mmio_debug=N for more
> > information.\n");
> > + gt_dbg(uncore->gt,
> > + "Unclaimed register detected, "
> > + "enabling oneshot unclaimed register reporting. "
> > + "Please use i915.mmio_debug=N for more
> > information.\n");
> > uncore->i915->params.mmio_debug++;
> > }
> > uncore->debug->unclaimed_mmio_check--;
> > @@ -2957,7 +2950,7 @@ intel_uncore_forcewake_for_reg(struct intel_uncore
> > *uncore,
> > {
> > enum forcewake_domains fw_domains = 0;
> > - drm_WARN_ON(>i915->drm, !op);
> > + gt_WARN_ON(uncore->gt, !op);
> > if (!intel_uncore_has_forcewake(uncore))
> > return 0;
> > @@ -2968,7 +2961,7 @@ intel_uncore_forcewake_for_reg(struct intel_uncore
> > *uncore,
> > if (op & FW_REG_WRITE)
> > fw_domains |= uncore->funcs.write_fw_domains(uncore, reg);
> > - drm_WARN_ON(>i915->drm, fw_domains & ~uncore->fw_domains);
> > + gt_WARN_ON(uncore->gt, fw_domains & ~uncore->fw_domains);
> > return fw_domains;
> > }
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
annotation, workarounds will always be properly applied in a
multicast manner on these platforms.
Cc: Gustavo Sousa
Fixes: 58bc2453ab8a ("drm/i915: Define multicast registers as a new type")
Signed-off-by: Matt Roper
---
drivers/gpu/drm/i915/gt/intel_gt_regs.h | 4 ++--
drivers/gp
engine reset
domains related workarounds")
Fixes: 41bb543f5598 ("drm/i915/mtl: Add initial gt workarounds")
Signed-off-by: Matt Roper
---
drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 +
drivers/gpu/drm/i915/gt/intel_workarounds.c | 88 +
drivers/gpu/drm/i915/i915_d
- intel_gt_set_wedged(gt);
> - ret = -EIO;
> + GEM_TRACE("%pS timed out.\n",
> + __builtin_return_address(0));
> + GEM_TRACE_DUMP();
> +
> + intel_gt_set_wedged(gt);
> + ret = -EIO;
> + }
> }
>
> return ret;
> --
> 2.39.0
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
reedesktop.org/drm/intel/issues/7294
> [i915#7443]: https://gitlab.freedesktop.org/drm/intel/issues/7443
> [i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
> [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
> [i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
> [i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
> [i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
> [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
> [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
> [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
>
>
> Build changes
> -
>
> * Linux: CI_DRM_12618 -> Patchwork_113159v2
> * Piglit: piglit_4509 -> None
>
> CI-20190529: 20190529
> CI_DRM_12618: 7ba8ff20ba23bc940e928ffe3a9054225fff418e @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7129: 7816773163a1b0d248dd9dd34d14e632ad8903be @
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_113159v2: 7ba8ff20ba23bc940e928ffe3a9054225fff418e @
> git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113159v2/index.html
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
mostly just for consistency and
future-proofing the code.
Aside from that,
Reviewed-by: Matt Roper
>
> Signed-off-by: Gustavo Sousa
> Cc: Matt Roper
> Cc: Matthew Atwood
> Fixes: 468a4e630c7d ("drm/i915/dg2: Introduce Wa_18018764978")
> ---
> drivers/gpu/drm/i915/g
ret = skl_pcode_request(_priv->uncore,
> ICL_PCODE_SAGV_DE_MEM_SS_CONFIG,
> points_mask,
> --
> 2.34.1
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
i915 = inode->i_private;
> - intel_gt_pm_debugfs_forcewake_user_release(to_gt(i915));
> + struct intel_gt *gt;
> + unsigned int i;
> +
> + for_each_gt(gt, i915, i)
> + intel_gt_pm_debugfs_forcewake_user_release(gt);
>
> return 0;
> }
> --
> 2.34.1
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
dg1_irq_postinstall(struct drm_i915_private
> *dev_priv)
> GEN11_DISPLAY_IRQ_ENABLE);
> }
>
> - dg1_master_intr_enable(uncore->regs);
> - intel_uncore_posting_read(uncore, DG1_MSTR_TILE_INTR);
> + dg1_master_intr_enable(to_gt
of
platforms without display and its related clock gating, etc.).
I guess setting noop here is good for now, and if our next platform also
winds up being a noop we can make a change at that time.
Reviewed-by: Matt Roper
> ---
> drivers/gpu/drm/i915/intel_pm.c | 4 +++-
> 1 file change
Reviewed-by: Rodrigo Vivi
> >
> > Thanks for the review, Rodrigo!
> >
> > Last time I talked with the team, Lucas suspected there could be a
> > reason why
> > the workarounds were in their current places. I'll include him and
> > Matt Roper
> > here, sin
On Wed, Jan 18, 2023 at 12:01:20PM -0500, Rodrigo Vivi wrote:
> On Wed, Jan 18, 2023 at 09:54:56AM +, Tvrtko Ursulin wrote:
> >
> > On 28/11/2022 18:26, Matt Roper wrote:
> > > On Wed, Nov 23, 2022 at 04:45:25PM -0300, Gustavo Sousa wrote:
> > > > On W
ab.freedesktop.org/drm/intel/issues/7697
> [i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
> [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
> [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
> [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
> [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
>
>
> Build changes
> -
>
> * Linux: CI_DRM_12594 -> Patchwork_112966v1
> * Piglit: piglit_4509 -> None
>
> CI-20190529: 20190529
> CI_DRM_12594: 5cec9cff5436577179bab7b52de0465ba169691a @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7121: aa16e81259f59734230d441905b9d0f605e4a4b5 @
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_112966v1: 5cec9cff5436577179bab7b52de0465ba169691a @
> git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112966v1/index.html
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
as CPU-initiated accesses; they
use a different steering control register (0x20CC) which is initialized
to a non-terminated DSS target by pre-OS firmware and never changed
thereafter (i915 does not touch it and userspace does not have
permission to change that register).
Signed-off-by: Matt Roper
On Thu, Jan 12, 2023 at 09:40:42AM -0800, Matt Roper wrote:
> On Thu, Jan 12, 2023 at 03:11:31PM +0530, Chaitanya Kumar Borah wrote:
> > Fix typo for reference clock from 24400 to 24000
> >
> > Signed-off-by: Chaitanya Kumar Borah
>
> Fixes: 626426ff9ce4 ("d
On Thu, Jan 12, 2023 at 03:11:31PM +0530, Chaitanya Kumar Borah wrote:
> Fix typo for reference clock from 24400 to 24000
>
> Signed-off-by: Chaitanya Kumar Borah
Fixes: 626426ff9ce4 ("drm/i915/adl_p: Add cdclk support for ADL-P")
Reviewed-by: Matt Roper
> ---
> dri
ciids.h
> > @@ -684,14 +684,17 @@
> > INTEL_VGA_DEVICE(0xA78A, info), \
> > INTEL_VGA_DEVICE(0xA78B, info)
> >
> > +/* RPL-U */
> > +#define INTEL_RPLU_IDS(info) \
> > + INTEL_VGA_DEVICE(0xA721, info), \
> > + INTEL_VGA_DEVICE(0xA7A1, info), \
> > + INTEL_VGA_DEVICE(0xA7A9, info)
> > +
> > /* RPL-P */
> > #define INTEL_RPLP_IDS(info) \
> > INTEL_VGA_DEVICE(0xA720, info), \
> > - INTEL_VGA_DEVICE(0xA721, info), \
> > INTEL_VGA_DEVICE(0xA7A0, info), \
> > - INTEL_VGA_DEVICE(0xA7A1, info), \
> > - INTEL_VGA_DEVICE(0xA7A8, info), \
> > - INTEL_VGA_DEVICE(0xA7A9, info)
> > + INTEL_VGA_DEVICE(0xA7A8, info)
> >
> > /* DG2 */
> > #define INTEL_DG2_G10_IDS(info) \
>
> --
> Jani Nikula, Intel Open Source Graphics Center
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
gt;
> Bspec: 45585
>
> Fixes: 0d0e7d1eea9e ("drm/i915/mtl: Define engine context layouts")
> Signed-off-by: Lucas De Marchi
> Signed-off-by: Radhakrishna Sripada
Reviewed-by: Matt Roper
I'll poke the bspec people about getting the platform information fixed
for thi
534
> Fixes: a9e69428b1b4 ("drm/i915: Define MCR registers explicitly").
> Signed-off-by: Gustavo Sousa
> Cc: Matt Roper
Applied to drm-intel-gt-next. Thanks for the patch.
Matt
> ---
> drivers/gpu/drm/i915/gt/intel_gt_regs.h | 4 ++--
> drivers/gpu/drm/i915/
2 to avoid catching all future platforms.
>(Matt)
>
> v4:
> * Be totally explicit on the Gen12 branch. (Andrzej)
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Matt Roper
> Cc: Balasubramani Vivekanandan
> Cc: Andrzej Hajda
> Reviewed-by: Andrzej Hajda # v1
>
clk_table;
>
> Are RPL-U A0-B0 going to enter this branch? Is this the right thing to
> do?
There's no such thing as a RPL A0/B0. RPL continues the stepping
progression from ADL, and all RPL parts have E0 or newer display
steppings (bspec 55376).
Matt
>
> BR,
> Jani.
>
>
> > + e
dev_priv->display.cdclk.table = rplu_cdclk_table;
> else
> dev_priv->display.cdclk.table = adlp_cdclk_table;
> } else if (IS_ROCKETLAKE(dev_priv)) {
> --
> 2.25.1
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
> INTEL_VGA_DEVICE(0xA7A1, info), \
> - INTEL_VGA_DEVICE(0xA7A8, info), \
> + INTEL_VGA_DEVICE(0xA721, info), \
> INTEL_VGA_DEVICE(0xA7A9, info)
I know the bspec orders them like this, but it's probably better to just
sort these two lists numerically. These bspec pages get reshuffled so
often these days that trying to match the bspec's strange ordering isn't
really worth it.
Matt
>
> /* DG2 */
> --
> 2.25.1
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
2 to avoid catching all future platforms.
>(Matt)
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Matt Roper
> Cc: Balasubramani Vivekanandan
> Cc: Andrzej Hajda
> Reviewed-by: Andrzej Hajda # v1
Reviewed-by: Matt Roper
> ---
> drivers/gpu/drm/i915/gt/intel_gt.c | 17
501 - 600 of 4320 matches
Mail list logo
