[Intel-gfx] [RFC v2 5/5] drm/hdmi21: Add frl_dfm_helper to Makefile

2022-02-14 Thread Vandita Kulkarni
Add the new frl_dfm_helper file to drm Makefile Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 8675c2af7ae1..81fe3df8bfda 100644 --- a/drivers/gpu/drm

[Intel-gfx] [RFC v2 4/5] drm/hdmi21: Add support for DFM calculation with DSC

2022-02-14 Thread Vandita Kulkarni
From: Ankit Nautiyal Add helper functions for calculating FRL capacity and DFM requirements with given compressed bpp. Signed-off-by: Ankit Nautiyal Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/drm_frl_dfm_helper.c | 297 +++ include/drm/drm_frl_dfm_helper.h

[Intel-gfx] [RFC v2 3/5] drm/hdmi21: Add helpers to verify non-dsc DFM requirements

2022-02-14 Thread Vandita Kulkarni
Add helpers to compute DFM variables and to verify if the DFM requirements are met or not in non dsc cases. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/drm_frl_dfm_helper.c | 161 +++ include/drm/drm_frl_dfm_helper.h | 2 + 2 files changed, 163 insertions

[Intel-gfx] [RFC v2 2/5] drm/hdmi21: Add non dsc frl capacity computation helpers

2022-02-14 Thread Vandita Kulkarni
Add helper functions for computing non dsc frl link characteristics Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/drm_frl_dfm_helper.c | 396 +++ 1 file changed, 396 insertions(+) create mode 100644 drivers/gpu/drm/drm_frl_dfm_helper.c diff --git a/drivers/gpu

[Intel-gfx] [RFC v2 1/5] drm/hdmi21: Define frl_dfm structure

2022-02-14 Thread Vandita Kulkarni
Define frl_dfm structure to hold frl characteristics needed for frl capacity computation in order to meet the data flow metering requirement. Signed-off-by: Vandita Kulkarni --- include/drm/drm_frl_dfm_helper.h | 124 +++ 1 file changed, 124 insertions(+) create

[Intel-gfx] [RFC v2 0/5] Add data flow metering support for HDMI2.1

2022-02-14 Thread Vandita Kulkarni
unsigned int, corrected patch 4 to address build issue, addressed checkpatch issues, moved the drm_frl_dfm_helper under kms_helpers section for compilation in the Makefile. Ankit Nautiyal (1): drm/hdmi21: Add support for DFM calculation with DSC Vandita Kulkarni (4): drm/hdmi21: Define frl_dfm

[Intel-gfx] [RFC 5/5] drm/hdmi21: Add frl_dfm_helper to Makefile

2022-02-03 Thread Vandita Kulkarni
Add the new frl_dfm_helper file to drm Makefile Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 8675c2af7ae1..4fa9b48995c8 100644 --- a/drivers/gpu/drm

[Intel-gfx] [RFC 3/5] drm/hdmi21: Add helpers to verify non-dsc DFM requirements

2022-02-03 Thread Vandita Kulkarni
Add helpers to compute DFM variables and to verify if the DFM requirements are met or not in non dsc cases. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/drm_frl_dfm_helper.c | 161 +++ include/drm/drm_frl_dfm_helper.h | 2 + 2 files changed, 163 insertions

[Intel-gfx] [RFC 4/5] drm/hdmi21: Add support for DFM calculation with DSC

2022-02-03 Thread Vandita Kulkarni
From: Ankit Nautiyal Add helper functions for calculating FRL capacity and DFM requirements with given compressed bpp. Signed-off-by: Ankit Nautiyal Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/drm_frl_dfm_helper.c | 298 +++ include/drm/drm_frl_dfm_helper.h

[Intel-gfx] [RFC 1/5] drm/hdmi21: Define frl_dfm structure

2022-02-03 Thread Vandita Kulkarni
Define frl_dfm structure to hold frl characteristics needed for frl capacity computation in order to meet the data flow metering requirement. Signed-off-by: Vandita Kulkarni --- include/drm/drm_frl_dfm_helper.h | 126 +++ 1 file changed, 126 insertions(+) create

[Intel-gfx] [RFC 2/5] drm/hdmi21: Add non dsc frl capacity computation helpers

2022-02-03 Thread Vandita Kulkarni
Add helper functions for computing non dsc frl link characteristics Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/drm_frl_dfm_helper.c | 396 +++ 1 file changed, 396 insertions(+) create mode 100644 drivers/gpu/drm/drm_frl_dfm_helper.c diff --git a/drivers/gpu

[Intel-gfx] [RFC 0/5] Add data flow metering support for HDMI2.1

2022-02-03 Thread Vandita Kulkarni
/hdmi21: Add support for DFM calculation with DSC Vandita Kulkarni (4): drm/hdmi21: Define frl_dfm structure drm/hdmi21: Add non dsc frl capacity computation helpers drm/hdmi21: Add helpers to verify non-dsc DFM requirements drm/hdmi21: Add frl_dfm_helper to Makefile drivers/gpu/drm

[Intel-gfx] [PATCH] Revert "drm/i915/tgl/dsi: Gate the ddi clocks after pll mapping"

2021-11-09 Thread Vandita Kulkarni
This reverts commit 991d9557b0c457fb92bc49ddde24a7d9ce6144a8. The Bspec was updated recently with the pll ungate sequence similar to that of icl dsi enable sequence. Hence reverting. Bspec:49187 Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_dsi.c | 10 ++ 1 file

[Intel-gfx] [PATCH] drm/i915/dsc: Fix the usage of uncompressed bpp

2021-10-27 Thread Vandita Kulkarni
DP 1.4 spec limits max compression bpp to uncompressed bpp -1, which is supported from XELPD onwards. Instead of uncompressed bpp, max dsc input bpp was being used to limit the max compression bpp. Fixes: 831d5aa96c97 ("drm/i915/xelpd: Support DP1.4 compression BPPs") Signed-off-b

[Intel-gfx] [V2 4/4] drm/i915/dsi: Ungate clock before enabling the phy

2021-10-19 Thread Vandita Kulkarni
after pll mapping") which gates the clocks much before, as per the older spec. This commit nullifies its effect and makes sure that the clocks are not gated while we enable the DDI buffer. v2: Bspec ref, add a comment wrt earlier clock gating sequence (Jani) Signed-off-b

[Intel-gfx] [V2 2/4] drm/i915/dsi/xelpd: Add DSI transcoder support

2021-10-19 Thread Vandita Kulkarni
Update ADL_P device info to support DSI0, DSI1 v2: Re-define cpu_transcoder_mask only (Jani) Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/i915_pci.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm

[Intel-gfx] [V2 3/4] drm/i915/dsi/xelpd: Disable DC states in Video mode

2021-10-19 Thread Vandita Kulkarni
: Align to the power domain ordering (Jani) Add bspec references (Imre) Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_display_power.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display

[Intel-gfx] [V2 1/4] drm/i915/dsi/xelpd: Fix the bit mask for wakeup GB

2021-10-19 Thread Vandita Kulkarni
v2: Fix the typo, move out the hardcoding from macro(Jani, Ville) Fixes: f87c46c43175 ("drm/i915/dsi/xelpd: Add WA to program LP to HS wakeup guardband") Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_dsi.c | 3 ++- drivers/gpu/drm/i915/i915_reg.h|

[Intel-gfx] [V2 0/4] Enable MIPI DSI video mode on ADLP

2021-10-19 Thread Vandita Kulkarni
v2: Addressed the review comments on v1. Vandita Kulkarni (4): drm/i915/dsi/xelpd: Fix the bit mask for wakeup GB drm/i915/dsi/xelpd: Add DSI transcoder support drm/i915/dsi/xelpd: Disable DC states in Video mode drm/i915/dsi: Ungate clock before enabling the phy drivers/gpu/drm/i915

[Intel-gfx] [PATCH 4/4] drm/i915/dsi: Ungate clock before enabling the phy

2021-10-17 Thread Vandita Kulkarni
For the PHY enable/disable signalling to propagate between Dispaly and PHY, DDI clocks need to be running when enabling the PHY. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_dsi.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 3/4] drm/i915/dsi/xelpd: Disable DC states in Video mode

2021-10-17 Thread Vandita Kulkarni
MIPI DSI transcoder cannot be in video mode to support any of the display C states. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_display_power.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b

[Intel-gfx] [PATCH 2/4] drm/i915/dsi/xelpd: Add DSI transcoder support

2021-10-17 Thread Vandita Kulkarni
Update ADL_P device info to support DSI0, DSI1 Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/i915_pci.c | 31 --- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c index

[Intel-gfx] [PATCH 1/4] drm/i915/dsi/xelpd: Fix the bit mask for wakeup GB

2021-10-17 Thread Vandita Kulkarni
Fixes: f87c46c43175 ("drm/i915/dsi/xelpd: Add WA to program LP to HS wakeup guardband") Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_dsi.c | 2 +- drivers/gpu/drm/i915/i915_reg.h| 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/d

[Intel-gfx] [PATCH 0/4] Enable MIPI DSI video mode on ADLP

2021-10-17 Thread Vandita Kulkarni
Vandita Kulkarni (4): drm/i915/dsi/xelpd: Fix the bit mask for wakeup GB drm/i915/dsi/xelpd: Add DSI transcoder support drm/i915/dsi/xelpd: Disable DC states in Video mode drm/i915/dsi: Ungate clock before enabling the phy drivers/gpu/drm/i915/display/icl_dsi.c| 10

[Intel-gfx] [PATCH] drm/i915/display: Fix the dsc check while selecting min_cdclk

2021-09-14 Thread Vandita Kulkarni
ned-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_cdclk.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c index 9aec17b33819..3a1cdb3937aa 100644 --- a/drivers/gp

[Intel-gfx] [PATCH] drm/i915/display: Enable second VDSC engine for higher moderates

2021-09-13 Thread Vandita Kulkarni
Each VDSC operates with 1ppc throughput, hence enable the second VDSC engine when moderate is higher that the current cdclk. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_dp.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu

[Intel-gfx] [v2 1/2] drm/i915/dsi/xelpd: Add WA to program LP to HS wakeup guardband

2021-08-25 Thread Vandita Kulkarni
Wa_16012360555 SW will have to program the "LP to HS Wakeup Guardband" field to account for the repeaters on the HS Request/Ready PPI signaling between the Display engine and the DPHY. v2: Fix build issue. v3: Align to new naming (Jani) Signed-off-by: Vandita Kulkarni Reviewed-by: J

[Intel-gfx] [v2 2/2] drm/i915/dsi/xelpd: Enable mipi dsi support.

2021-08-25 Thread Vandita Kulkarni
Enable MIPI DSI support on ADL-P platform. The esc clock changes, WA changes are taken care in the previous patches. As per the Bspec the seq remains to be same as TGL. Signed-off-by: Vandita Kulkarni Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 1 + 1 file

[Intel-gfx] [v2 0/2] Enable mipi dsi on XELPD

2021-08-25 Thread Vandita Kulkarni
Vandita Kulkarni (2): drm/i915/dsi/xelpd: Add WA to program LP to HS wakeup guardband drm/i915/dsi/xelpd: Enable mipi dsi support. drivers/gpu/drm/i915/display/icl_dsi.c | 23 drivers/gpu/drm/i915/display/intel_display.c | 1 + drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [v2] drm/i915/dsi/xelpd: Add WA to program LP to HS wakeup guardband

2021-08-22 Thread Vandita Kulkarni
Wa_16012360555 SW will have to program the "LP to HS Wakeup Guardband" field to account for the repeaters on the HS Request/Ready PPI signaling between the Display engine and the DPHY. v2: Fix build issue. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_

[Intel-gfx] [PATCH 2/2] drm/i915/dsi/xelpd: Enable mipi dsi support.

2021-08-22 Thread Vandita Kulkarni
Enable MIPI DSI support on ADL-P platform. The esc clock changes, WA changes are taken care in the previous patches. As per the Bspec the seq remains to be same as TGL. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_display.c | 1 + 1 file changed, 1 insertion(+) diff

[Intel-gfx] [PATCH 1/2] drm/i915/dsi/xelpd: Add WA to program LP to HS wakeup guardband

2021-08-22 Thread Vandita Kulkarni
Wa_16012360555 SW will have to program the "LP to HS Wakeup Guardband" field to account for the repeaters on the HS Request/Ready PPI signaling between the Display engine and the DPHY. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_

[Intel-gfx] [PATCH 0/2] Enable mipi dsi on XELPD

2021-08-22 Thread Vandita Kulkarni
The delta from TGL is wrt the ESC clock, and an additional WA needed. With that support in place, extend the support for mipi dsi. Vandita Kulkarni (2): drm/i915/dsi/xelpd: Add WA to program LP to HS wakeup guardband drm/i915/dsi/xelpd: Enable mipi dsi support. drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH] drm/i915: Update small joiner ram size

2021-08-05 Thread Vandita Kulkarni
Xelpd supports larger small joiner ram. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_dp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 75d4ebc66941

[Intel-gfx] [v7 1/3] drm/i915/display: Add write permissions for fec support

2021-07-19 Thread Vandita Kulkarni
Though there is a write option available on fec_suport debugfs file, so far it has been registering with read permissions only. Suggested-by: Jani Nikula Signed-off-by: Vandita Kulkarni Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 +- 1 file changed

[Intel-gfx] [v7 0/3] Enable setting custom DSC BPP

2021-07-19 Thread Vandita Kulkarni
debugfs node for DSC BPP enable Vandita Kulkarni (2): drm/i915/display: Add write permissions for fec support drm/i915/display/dsc: Force dsc BPP .../drm/i915/display/intel_display_debugfs.c | 78 ++- .../drm/i915/display/intel_display_types.h| 1 + drivers/gpu/drm/i915

[Intel-gfx] [v7 3/3] drm/i915/display/dsc: Force dsc BPP

2021-07-19 Thread Vandita Kulkarni
Set DSC BPP to the value forced through debugfs. It can go from bpc to bpp-1. v2: Use default dsc bpp when we are just doing force_dsc_en, use default dsc bpp for invalid force_dsc_bpp values. (Jani) Signed-off-by: Vandita Kulkarni Reviewed-by: Swati Sharma --- drivers/gpu/drm/i915

[Intel-gfx] [v7 2/3] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable

2021-07-19 Thread Vandita Kulkarni
sions (Jani) Cc: Vandita Kulkarni Cc: Navare Manasi D Cc: Jani Nikula Signed-off-by: Anusha Srivatsa Signed-off-by: Patnana Venkata Sai Signed-off-by: Vandita Kulkarni Reviewed-by: Jani Nikula --- .../drm/i915/display/intel_display_debugfs.c | 76 ++- .../drm/i915/di

[Intel-gfx] [v7 1/3] drm/i915/display: Add write permissions for fec support

2021-07-19 Thread Vandita Kulkarni
Though there is a write option available on fec_suport debugfs file, so far it has been registering with read permissions only. Suggested-by: Jani Nikula Signed-off-by: Vandita Kulkarni Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 +- 1 file changed

[Intel-gfx] [v7 2/3] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable

2021-07-19 Thread Vandita Kulkarni
om v6, permissions (Jani) Cc: Vandita Kulkarni Cc: Navare Manasi D Cc: Jani Nikula Signed-off-by: Anusha Srivatsa Signed-off-by: Patnana Venkata Sai Signed-off-by: Vandita Kulkarni Reviewed-by: Jani Nikula --- .../drm/i915/display/intel_display_debugfs.c | 76 ++- .../drm

[Intel-gfx] [v7 3/3] drm/i915/display/dsc: Force dsc BPP

2021-07-19 Thread Vandita Kulkarni
Set DSC BPP to the value forced through debugfs. It can go from bpc to bpp-1. v2: Use default dsc bpp when we are just doing force_dsc_en, use default dsc bpp for invalid force_dsc_bpp values. (Jani) Signed-off-by: Vandita Kulkarni Reviewed-by: Swati Sharma --- drivers/gpu/drm/i915

[Intel-gfx] [v7 0/3] Set BPP in the kernel

2021-07-19 Thread Vandita Kulkarni
Patnana Venkata Sai (1): drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable Vandita Kulkarni (2): drm/i915/display: Add write permissions for fec support drm/i915/display/dsc: Force dsc BPP .../drm/i915/display/intel_display_debugfs.c | 78

[Intel-gfx] [v2] drm/i915/display/dsc: Force dsc BPP

2021-07-08 Thread Vandita Kulkarni
Set DSC BPP to the value forced through debugfs. It can go from bpc to bpp-1. v2: Use default dsc bpp when we are just doing force_dsc_en, use default dsc bpp for invalid force_dsc_bpp values. (Jani) Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_dp.c | 17

[Intel-gfx] [v7 2/3] drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable

2021-07-08 Thread Vandita Kulkarni
om v6, permissions (Jani) Cc: Vandita Kulkarni Cc: Navare Manasi D Cc: Jani Nikula Signed-off-by: Anusha Srivatsa Signed-off-by: Patnana Venkata Sai Signed-off-by: Vandita Kulkarni --- .../drm/i915/display/intel_display_debugfs.c | 76 ++- .../drm/i915/di

[Intel-gfx] [v7 3/3] drm/i915/display/dsc: Force dsc BPP

2021-07-08 Thread Vandita Kulkarni
Set DSC BPP to the value forced through debugfs. It can go from bpc to bpp-1. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_dp.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915

[Intel-gfx] [v7 1/3] drm/i915/display: Add write permissions for fec support

2021-07-08 Thread Vandita Kulkarni
Though there is a write option available on fec_suport debugfs file, so far it has been registering with read permissions only. Suggested-by: Jani Nikula Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[Intel-gfx] [v7 0/3] Set BPP in the kernel

2021-07-08 Thread Vandita Kulkarni
float them in a different series. Patnana Venkata Sai (1): drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable Vandita Kulkarni (2): drm/i915/display: Add write permissions for fec support drm/i915/display/dsc: Force dsc BPP .../drm/i915/display

[Intel-gfx] [v3] drm/i915/dsc: Fix bigjoiner check in dsc_disable

2021-06-09 Thread Vandita Kulkarni
) Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3537 Signed-off-by: Vandita Kulkarni Reviewed-by: Manasi Navare --- drivers/gpu/drm/i915/display/intel_vdsc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b

[Intel-gfx] [v3] drm/i915/dsc: Fix bigjoiner check in dsc_disable

2021-06-07 Thread Vandita Kulkarni
) Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3537 Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_vdsc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display

[Intel-gfx] [v2] drm/i915/dsc: Fix bigjoiner check in dsc_disable

2021-06-07 Thread Vandita Kulkarni
://gitlab.freedesktop.org/drm/intel/-/issues/3537 Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_vdsc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c index

[Intel-gfx] [PATCH] drm/i915/dsc: Fix bigjoiner check in dsc_disable

2021-06-04 Thread Vandita Kulkarni
/intel/-/issues/3537 Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_vdsc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c index 19cd9531c115..514e6267

[Intel-gfx] [PATCH] drm/i915/dsc: Remove redundant checks in DSC disable

2021-06-03 Thread Vandita Kulkarni
There can be a chance that pre os has enabled DSC and driver's compute config would not need dsc to be enabled, in such case if we check on compute config's compression state to disable, we might end up in state mismatch. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i9

[Intel-gfx] [15 4/5] drm/i915/dsi: Initiate frame request in cmd mode

2020-09-28 Thread Vandita Kulkarni
crtc_state mode_flags (Ville) v6: Add platform and dsi checks (Ville) Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_dsi.c | 26 + drivers/gpu/drm/i915/display/intel_dsi.h| 1 + drivers/gpu/drm/i915/display/intel_sprite.c | 9 +++ 3 files

[Intel-gfx] [v15] drm/i915/dsi: Initiate frame request in cmd mode

2020-09-28 Thread Vandita Kulkarni
crtc_state mode_flags (Ville) v6: Add platform and dsi checks (Ville) Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_dsi.c | 26 + drivers/gpu/drm/i915/display/intel_dsi.h| 1 + drivers/gpu/drm/i915/display/intel_sprite.c | 9 +++ 3 files

[Intel-gfx] [V14 2/5] i915/dsi: Configure TE interrupt for cmd mode

2020-09-24 Thread Vandita Kulkarni
icl_dsi header is not needed Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/i915_irq.c | 50 +++-- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 759f523c6a6b..913548addfba

[Intel-gfx] [V14 4/5] drm/i915/dsi: Initiate frame request in cmd mode

2020-09-24 Thread Vandita Kulkarni
crtc_state mode_flags (Ville) Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_dsi.c | 26 + drivers/gpu/drm/i915/display/intel_dsi.h| 1 + drivers/gpu/drm/i915/display/intel_sprite.c | 7 ++ 3 files changed, 34 insertions(+) diff --git a

[Intel-gfx] [V14 1/5] drm/i915/dsi: Add details about TE in get_config

2020-09-24 Thread Vandita Kulkarni
We need details about enabling TE on which port before we enable TE through vblank enable path. This is based on the configuration that we receive from the VBT wrt ports, dual_link. Signed-off-by: Vandita Kulkarni Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display/icl_dsi.c | 30

[Intel-gfx] [V14 0/5] Add support for mipi dsi cmd mode

2020-09-24 Thread Vandita Kulkarni
This series contain interrupt handling part of cmd mode. Configuration patches were merged already. Vandita Kulkarni (5): drm/i915/dsi: Add details about TE in get_config i915/dsi: Configure TE interrupt for cmd mode drm/i915/dsi: Add TE handler for dsi cmd mode. drm/i915/dsi: Initiate

[Intel-gfx] [V14 3/5] drm/i915/dsi: Add TE handler for dsi cmd mode.

2020-09-24 Thread Vandita Kulkarni
handler func (Jani) Signed-off-by: Vandita Kulkarni Reported-by: kernel test robot Acked-by: Jani Nikula --- drivers/gpu/drm/i915/i915_irq.c | 65 + 1 file changed, 65 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index

[Intel-gfx] [V14 5/5] drm/i915/dsi: Enable software vblank counter

2020-09-24 Thread Vandita Kulkarni
update would have completed in the first TE duration itself. Hence switch to using software timestamp based vblank counter. v2: Use mode_flags from crtc_state (Ville) Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_display.c | 11 +++ drivers/gpu/drm/i915/i915_irq.c

[Intel-gfx] [V13 4/5] drm/i915/dsi: Initiate fame request in cmd mode

2020-09-22 Thread Vandita Kulkarni
frame data is sent to the panel, we see the frame counter updating. v2: Use intel_de_read/write v3: remove the usage of private_flags v4: Use icl_dsi in func names if non static, fix code formatting issues. (Jani) Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_dsi.c

[Intel-gfx] [V13 2/5] i915/dsi: Configure TE interrupt for cmd mode

2020-09-22 Thread Vandita Kulkarni
icl_dsi header is not needed Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/i915_irq.c | 50 +++-- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 759f523c6a6b..913548addfba

[Intel-gfx] [V13 5/5] drm/i915/dsi: Enable software vblank counter

2020-09-22 Thread Vandita Kulkarni
update would have completed in the first TE duration itself. Hence switch to using software timestamp based vblank counter. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_display.c | 11 +++ drivers/gpu/drm/i915/i915_irq.c | 4 2 files changed, 15

[Intel-gfx] [V13 0/5] Add support for mipi dsi cmd mode

2020-09-22 Thread Vandita Kulkarni
This series contain interrupt handling part of cmd mode. Configuration patches were merged already. v10: Address the review comments on patch 3 and 4 v11: fix compilation issue introduced in v10 v12: fix check patch errors on patch 3 v13: Use sw vblank counter (Ville) Vandita Kulkarni (5): drm

[Intel-gfx] [V13 3/5] drm/i915/dsi: Add TE handler for dsi cmd mode.

2020-09-22 Thread Vandita Kulkarni
handler func (Jani) Signed-off-by: Vandita Kulkarni Reported-by: kernel test robot Acked-by: Jani Nikula --- drivers/gpu/drm/i915/i915_irq.c | 65 + 1 file changed, 65 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index

[Intel-gfx] [V13 1/5] drm/i915/dsi: Add details about TE in get_config

2020-09-22 Thread Vandita Kulkarni
We need details about enabling TE on which port before we enable TE through vblank enable path. This is based on the configuration that we receive from the VBT wrt ports, dual_link. Signed-off-by: Vandita Kulkarni Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display/icl_dsi.c | 30

[Intel-gfx] [V12 1/4] drm/i915/dsi: Add details about TE in get_config

2020-09-16 Thread Vandita Kulkarni
We need details about enabling TE on which port before we enable TE through vblank enable path. This is based on the configuration that we receive from the VBT wrt ports, dual_link. Signed-off-by: Vandita Kulkarni Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display/icl_dsi.c | 30

[Intel-gfx] [V12 2/4] i915/dsi: Configure TE interrupt for cmd mode

2020-09-16 Thread Vandita Kulkarni
icl_dsi header is not needed Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/i915_irq.c | 50 +++-- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 759f523c6a6b..913548addfba

[Intel-gfx] [V12 0/4] Add support for mipi dsi cmd mode

2020-09-16 Thread Vandita Kulkarni
This series contain interrupt handling part of cmd mode. Configuration patches were merged already. v10: Address the review comments on patch 3 and 4 v11: fix compilation issue introduced in v10 v12: fix check patch errors on patch 3 Vandita Kulkarni (4): drm/i915/dsi: Add details about TE in

[Intel-gfx] [V12 4/4] drm/i915/dsi: Initiate fame request in cmd mode

2020-09-16 Thread Vandita Kulkarni
frame data is sent to the panel, we see the frame counter updating. v2: Use intel_de_read/write v3: remove the usage of private_flags v4: Use icl_dsi in func names if non static, fix code formatting issues. (Jani) Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_dsi.c

[Intel-gfx] [V12 3/4] drm/i915/dsi: Add TE handler for dsi cmd mode.

2020-09-16 Thread Vandita Kulkarni
handler func (Jani) Signed-off-by: Vandita Kulkarni Reported-by: kernel test robot Acked-by: Jani Nikula --- drivers/gpu/drm/i915/i915_irq.c | 65 + 1 file changed, 65 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index

[Intel-gfx] [V11 1/4] drm/i915/dsi: Add details about TE in get_config

2020-09-15 Thread Vandita Kulkarni
We need details about enabling TE on which port before we enable TE through vblank enable path. This is based on the configuration that we receive from the VBT wrt ports, dual_link. Signed-off-by: Vandita Kulkarni Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display/icl_dsi.c | 30

[Intel-gfx] [V11 4/4] drm/i915/dsi: Initiate fame request in cmd mode

2020-09-15 Thread Vandita Kulkarni
frame data is sent to the panel, we see the frame counter updating. v2: Use intel_de_read/write v3: remove the usage of private_flags v4: Use icl_dsi in func names if non static, fix code formatting issues. (Jani) Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_dsi.c

[Intel-gfx] [V11 0/4] Add support for mipi dsi cmd mode

2020-09-15 Thread Vandita Kulkarni
This series contain interrupt handling part of cmd mode. Configuration patches were merged already. v10: Address the review comments on patch 3 and 4 v11: fix compilation issue introduced in v10 Vandita Kulkarni (4): drm/i915/dsi: Add details about TE in get_config i915/dsi: Configure TE

[Intel-gfx] [V11 3/4] drm/i915/dsi: Add TE handler for dsi cmd mode.

2020-09-15 Thread Vandita Kulkarni
handler func (Jani) Signed-off-by: Vandita Kulkarni Reported-by: kernel test robot Acked-by: Jani Nikula --- drivers/gpu/drm/i915/i915_irq.c | 66 + 1 file changed, 66 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index

[Intel-gfx] [V11 2/4] i915/dsi: Configure TE interrupt for cmd mode

2020-09-15 Thread Vandita Kulkarni
icl_dsi header is not needed Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/i915_irq.c | 50 +++-- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 759f523c6a6b..913548addfba

[Intel-gfx] [V10 4/4] drm/i915/dsi: Initiate fame request in cmd mode

2020-09-15 Thread Vandita Kulkarni
frame data is sent to the panel, we see the frame counter updating. v2: Use intel_de_read/write v3: remove the usage of private_flags v4: Use icl_dsi in func names if non static, fix code formatting issues. (Jani) Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_dsi.c

[Intel-gfx] [V10 0/4] Add support for mipi dsi cmd mode

2020-09-15 Thread Vandita Kulkarni
This series contain interrupt handling part of cmd mode. Configuration patches were merged already. v10: Address the review comments on patch 3 and 4 Vandita Kulkarni (4): drm/i915/dsi: Add details about TE in get_config i915/dsi: Configure TE interrupt for cmd mode drm/i915/dsi: Add TE

[Intel-gfx] [V10 3/4] drm/i915/dsi: Add TE handler for dsi cmd mode.

2020-09-15 Thread Vandita Kulkarni
should be static (Jani), Signed-off-by: Vandita Kulkarni Reported-by: kernel test robot Acked-by: Jani Nikula --- drivers/gpu/drm/i915/i915_irq.c | 66 + 1 file changed, 66 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915

[Intel-gfx] [V10 2/4] i915/dsi: Configure TE interrupt for cmd mode

2020-09-15 Thread Vandita Kulkarni
icl_dsi header is not needed Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/i915_irq.c | 50 +++-- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 759f523c6a6b..913548addfba

[Intel-gfx] [V10 1/4] drm/i915/dsi: Add details about TE in get_config

2020-09-15 Thread Vandita Kulkarni
We need details about enabling TE on which port before we enable TE through vblank enable path. This is based on the configuration that we receive from the VBT wrt ports, dual_link. Signed-off-by: Vandita Kulkarni Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display/icl_dsi.c | 30

[Intel-gfx] [V9 3/4] drm/i915/dsi: Add TE handler for dsi cmd mode.

2020-09-09 Thread Vandita Kulkarni
immediately send the frame data to the panel. We are not dealing with the periodic command mode here. v2: Pass only relevant masked bits to the handler (Jani) v3: Fix the check for cmd mode in TE handler function. v4: Use intel_handle_vblank instead of drm_handle_vblank (Jani) Signed-off-by: Vandita

[Intel-gfx] [V9 2/4] i915/dsi: Configure TE interrupt for cmd mode

2020-09-09 Thread Vandita Kulkarni
: Vandita Kulkarni --- drivers/gpu/drm/i915/i915_irq.c | 51 +++-- 1 file changed, 49 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index f113fe44572b..de540194ce67 100644 --- a/drivers/gpu/drm/i915

[Intel-gfx] [V9 1/4] drm/i915/dsi: Add details about TE in get_config

2020-09-09 Thread Vandita Kulkarni
We need details about enabling TE on which port before we enable TE through vblank enable path. This is based on the configuration that we receive from the VBT wrt ports, dual_link. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_dsi.c | 30 +++--- 1

[Intel-gfx] [V9 4/4] drm/i915/dsi: Initiate fame request in cmd mode

2020-09-09 Thread Vandita Kulkarni
frame data is sent to the panel, we see the frame counter updating. v2: Use intel_de_read/write v3: remove the usage of private_flags Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_dsi.c | 26 drivers/gpu/drm/i915/display/intel_display.c | 13

[Intel-gfx] [V9 0/4] Add support for mipi dsi cmd mode

2020-09-09 Thread Vandita Kulkarni
This series contain interrupt handling part of cmd mode. Configuration patches were merged already. Vandita Kulkarni (4): drm/i915/dsi: Add details about TE in get_config i915/dsi: Configure TE interrupt for cmd mode drm/i915/dsi: Add TE handler for dsi cmd mode. drm/i915/dsi: Initiate

[Intel-gfx] [PATCH] drm/i915/display: Fix the encoder type check

2020-06-12 Thread Vandita Kulkarni
For all ddi, encoder->type holds output type as ddi, assigning it to individual o/p types is no more valid. Fixes: 362bfb995b78 ("drm/i915/tgl: Add DKL PHY vswing table for HDMI") v2: Rebase, no functional change. Signed-off-by: Vandita Kulkarni Reviewed-by: Uma Shankar --- dr

[Intel-gfx] [PATCH] drm/i915/display: Fix the encoder type check

2020-05-04 Thread Vandita Kulkarni
For all ddi, encoder->type holds output type as ddi, assigning it to individual o/p types is no more valid. Fixes: 362bfb995b78 ("drm/i915/tgl: Add DKL PHY vswing table for HDMI") Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/intel_ddi.c | 6 +++--- 1 fi

[Intel-gfx] [V8 1/9] drm/i915/dsi: Configure transcoder operation for command mode.

2020-03-11 Thread Vandita Kulkarni
Configure the transcoder to operate in TE GATE command mode and take TE events from GPIO. Also disable the periodic command mode, that GOP would have programmed. v2: Disable util pin (Jani) v3: Use intel_de_write (Jani) Signed-off-by: Vandita Kulkarni Reviewed-by: Jani Nikula --- drivers/gpu

[Intel-gfx] [V8 8/9] drm/i915/dsi: Initiate fame request in cmd mode

2020-03-11 Thread Vandita Kulkarni
In TE Gate mode, on every flip we need to set the frame update request bit. After this bit is set transcoder hardware will automatically send the frame data to the panel when it receives the TE event. v2: Use intel_de_read/write Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display

[Intel-gfx] [V8 3/9] drm/i915/dsi: Add cmd mode flags in display mode private flags

2020-03-11 Thread Vandita Kulkarni
Adding TE flags and periodic command mode flags as part of private flags to indicate what TE interrupts we would be getting instead of vblanks in case of mipi dsi command mode. v2: Add TE flag description (Jani) Reviewed-by: Jani Nikula Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915

[Intel-gfx] [V8 5/9] drm/i915/dsi: Use private flags to indicate TE in cmd mode

2020-03-11 Thread Vandita Kulkarni
On dsi cmd mode we do not receive vblanks instead we would get TE and these flags indicate TE is expected on which port. Signed-off-by: Vandita Kulkarni Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display/icl_dsi.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a

[Intel-gfx] [V8 2/9] drm/i915/dsi: Add vblank calculation for command mode

2020-03-11 Thread Vandita Kulkarni
calculation, use afe_clk for byte clock calculation, use intel_de_write/read (Jani) Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/display/icl_dsi.c | 48 +++--- 1 file changed, 36 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c

[Intel-gfx] [V8 7/9] drm/i915/dsi: Add TE handler for dsi cmd mode.

2020-03-11 Thread Vandita Kulkarni
In case of dual link, we get the TE on slave. So clear the TE on slave DSI IIR. v2: Pass only relevant masked bits to the handler (Jani) v3: Fix the check for cmd mode in TE handler function. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/i915_irq.c | 64

[Intel-gfx] [V8 0/9] Add support for mipi dsi cmd mode

2020-03-11 Thread Vandita Kulkarni
This series contain basic mipi dsi cmd mode enabling patches. With comments fixed on V7. Vandita Kulkarni (9): drm/i915/dsi: Configure transcoder operation for command mode. drm/i915/dsi: Add vblank calculation for command mode drm/i915/dsi: Add cmd mode flags in display mode private flags

[Intel-gfx] [V8 9/9] drm/i915/dsi: Clear the DSI IIR

2020-03-11 Thread Vandita Kulkarni
Clear the DSI IIR as part of interrupt configuration. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/i915/i915_irq.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 2e1418515c9f..89c8cabe24e0 100644 --- a

[Intel-gfx] [V8 6/9] drm/i915/dsi: Configure TE interrupt for cmd mode

2020-03-11 Thread Vandita Kulkarni
We need to configure TE interrupt in two places. Port interrupt and DSI interrupt mask registers. v2: Hide the private flags check inside configure_te (Jani) v3: Fix the position of masking de_port_masked for DSI_TE. v4: Simplify the caller of configure_te (Jani) Signed-off-by: Vandita

[Intel-gfx] [V8 4/9] drm/i915/dsi: Add check for periodic command mode

2020-03-11 Thread Vandita Kulkarni
If the GOP has programmed periodic command mode, we need to disable that which would need a deconfigure and configure sequence. v2: Fix sparse error, pass only intel_dsi (Jani) v3: Use intel_de_read Signed-off-by: Vandita Kulkarni Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display

[Intel-gfx] [V7 0/9] Add support for mipi dsi cmd mode

2020-02-03 Thread Vandita Kulkarni
This series contain basic cmd mode enablement pacthes. Fix comments on V6. Vandita Kulkarni (9): drm/i915/dsi: Configure transcoder operation for command mode. drm/i915/dsi: Add vblank calculation for command mode drm/i915/dsi: Add cmd mode flags in display mode private flags drm/i915/dsi

[Intel-gfx] [V7 6/9] drm/i915/dsi: Configure TE interrupt for cmd mode

2020-02-03 Thread Vandita Kulkarni
We need to configure TE interrupt in two places. Port interrupt and DSI interrupt mask registers. v2: Hide the private flags check inside configure_te (Jani) v3: Fix the position of masking de_port_masked for DSI_TE. v4: Simplify the caller of configure_te (Jani) Signed-off-by: Vandita

  1   2   3   >