Re: [Intel-gfx] [PATCH] drm/i915: Add i915_param charp macro magic

2017-02-22 Thread Chris Wilson
On Wed, Feb 22, 2017 at 12:30:38PM +0200, Jani Nikula wrote: > On Wed, 22 Feb 2017, Chris Wilson wrote: > > On Wed, Feb 22, 2017 at 12:06:35PM +0200, Jani Nikula wrote: > >> On Tue, 21 Feb 2017, Chris Wilson wrote: > >> > Handling the dynamic charp module parameter requires us to copy it for > >>

Re: [Intel-gfx] [PATCH] drm/i915: Add i915_param charp macro magic

2017-02-22 Thread Chris Wilson
On Wed, Feb 22, 2017 at 12:29:11PM +0200, Joonas Lahtinen wrote: > On ke, 2017-02-22 at 10:11 +, Chris Wilson wrote: > > On Wed, Feb 22, 2017 at 12:06:35PM +0200, Jani Nikula wrote: > > > > > > > > On Tue, 21 Feb 2017, Chris Wilson wrote: > > > > > > > > Handling the dynamic charp module par

Re: [Intel-gfx] [PATCH] drm/i915: Add i915_param charp macro magic

2017-02-22 Thread Jani Nikula
On Wed, 22 Feb 2017, Chris Wilson wrote: > On Wed, Feb 22, 2017 at 12:06:35PM +0200, Jani Nikula wrote: >> On Tue, 21 Feb 2017, Chris Wilson wrote: >> > Handling the dynamic charp module parameter requires us to copy it for >> > the error state, or remember to lock it when reading (in case it use

Re: [Intel-gfx] [PATCH] drm/i915: Add i915_param charp macro magic

2017-02-22 Thread Joonas Lahtinen
On ke, 2017-02-22 at 10:11 +, Chris Wilson wrote: > On Wed, Feb 22, 2017 at 12:06:35PM +0200, Jani Nikula wrote: > > > > > > On Tue, 21 Feb 2017, Chris Wilson wrote: > > > > > > Handling the dynamic charp module parameter requires us to copy it for > > > the error state, or remember to lock

Re: [Intel-gfx] [PATCH] drm/i915: Add i915_param charp macro magic

2017-02-22 Thread Chris Wilson
On Wed, Feb 22, 2017 at 12:06:35PM +0200, Jani Nikula wrote: > On Tue, 21 Feb 2017, Chris Wilson wrote: > > Handling the dynamic charp module parameter requires us to copy it for > > the error state, or remember to lock it when reading (in case it used > > with 0600). > > > > v2: Use __always_inli

Re: [Intel-gfx] [PATCH] drm/i915: Add i915_param charp macro magic

2017-02-22 Thread Jani Nikula
On Tue, 21 Feb 2017, Chris Wilson wrote: > Handling the dynamic charp module parameter requires us to copy it for > the error state, or remember to lock it when reading (in case it used > with 0600). > > v2: Use __always_inline and __builtin_strcmp > > Signed-off-by: Chris Wilson > Reviewed-by: J

[Intel-gfx] [PATCH] drm/i915: Add i915_param charp macro magic

2017-02-21 Thread Chris Wilson
Handling the dynamic charp module parameter requires us to copy it for the error state, or remember to lock it when reading (in case it used with 0600). v2: Use __always_inline and __builtin_strcmp Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_debugfs.c