Re: [Intel-gfx] [PATCH] drm/i915: Clear intel_crtc->atomic before updating it.

2015-11-17 Thread Jani Nikula
On Mon, 16 Nov 2015, Ville Syrjälä wrote: > On Mon, Nov 16, 2015 at 01:41:54PM +0100, Maarten Lankhorst wrote: >> Op 16-11-15 om 13:35 schreef Jani Nikula: >> > On Mon, 16 Nov 2015, Maarten Lankhorst wrote: >> >> If an atomic update fails intel_crtc->atomic may have have some values >> >> left >

Re: [Intel-gfx] [PATCH] drm/i915: Clear intel_crtc->atomic before updating it.

2015-11-16 Thread Ville Syrjälä
On Mon, Nov 16, 2015 at 01:41:54PM +0100, Maarten Lankhorst wrote: > Op 16-11-15 om 13:35 schreef Jani Nikula: > > On Mon, 16 Nov 2015, Maarten Lankhorst wrote: > >> If an atomic update fails intel_crtc->atomic may have have some values left > >> from the last atomic check. One example is atomic->

Re: [Intel-gfx] [PATCH] drm/i915: Clear intel_crtc->atomic before updating it.

2015-11-16 Thread Ville Syrjälä
On Mon, Nov 16, 2015 at 12:50:13PM +0100, Maarten Lankhorst wrote: > If an atomic update fails intel_crtc->atomic may have have some values left > from the last atomic check. One example is atomic->wait_for_vblank, > which results in spurious errors in kms_flip. > > Testcase: kms_flip > Reported-b

Re: [Intel-gfx] [PATCH] drm/i915: Clear intel_crtc->atomic before updating it.

2015-11-16 Thread Maarten Lankhorst
Op 16-11-15 om 13:35 schreef Jani Nikula: > On Mon, 16 Nov 2015, Maarten Lankhorst wrote: >> If an atomic update fails intel_crtc->atomic may have have some values left >> from the last atomic check. One example is atomic->wait_for_vblank, >> which results in spurious errors in kms_flip. > Please

Re: [Intel-gfx] [PATCH] drm/i915: Clear intel_crtc->atomic before updating it.

2015-11-16 Thread Jani Nikula
On Mon, 16 Nov 2015, Maarten Lankhorst wrote: > If an atomic update fails intel_crtc->atomic may have have some values left > from the last atomic check. One example is atomic->wait_for_vblank, > which results in spurious errors in kms_flip. Please add the "spurious errors" you see in the commit

Re: [Intel-gfx] [PATCH] drm/i915: Clear intel_crtc->atomic before updating it.

2015-11-16 Thread Daniel Stone
Hi, On 16 November 2015 at 11:49, Maarten Lankhorst wrote: > If an atomic update fails intel_crtc->atomic may have have some values left > from the last atomic check. One example is atomic->wait_for_vblank, > which results in spurious errors in kms_flip. > > Testcase: kms_flip > Reported-by: Vill

[Intel-gfx] [PATCH] drm/i915: Clear intel_crtc->atomic before updating it.

2015-11-16 Thread Maarten Lankhorst
If an atomic update fails intel_crtc->atomic may have have some values left from the last atomic check. One example is atomic->wait_for_vblank, which results in spurious errors in kms_flip. Testcase: kms_flip Reported-by: Ville Syrjälä Cc: sta...@vger.kernel.org #v4.3 Signed-off-by: Maarten Lankh