Re: [Intel-gfx] [PATCH] drm/i915: Fix pages pin counting around swizzle quirk

2016-11-04 Thread Chris Wilson
On Fri, Nov 04, 2016 at 09:36:31AM +, Chris Wilson wrote: > On Fri, Nov 04, 2016 at 10:50:44AM +0200, Joonas Lahtinen wrote: > > On ke, 2016-11-02 at 09:43 +, Chris Wilson wrote: > > > @@ -2458,17 +2459,16 @@ int __i915_gem_object_get_pages(struct > > > drm_i915_gem_object *obj) > > >   if

Re: [Intel-gfx] [PATCH] drm/i915: Fix pages pin counting around swizzle quirk

2016-11-04 Thread Chris Wilson
On Fri, Nov 04, 2016 at 10:50:44AM +0200, Joonas Lahtinen wrote: > On ke, 2016-11-02 at 09:43 +, Chris Wilson wrote: > > @@ -2458,17 +2459,16 @@ int __i915_gem_object_get_pages(struct > > drm_i915_gem_object *obj) > >   if (err) > >   return err; > >   > > - if (likely(obj->mm.pa

Re: [Intel-gfx] [PATCH] drm/i915: Fix pages pin counting around swizzle quirk

2016-11-04 Thread Joonas Lahtinen
On ke, 2016-11-02 at 09:43 +, Chris Wilson wrote: > @@ -2458,17 +2459,16 @@ int __i915_gem_object_get_pages(struct > drm_i915_gem_object *obj) >   if (err) >   return err; >   > - if (likely(obj->mm.pages)) { > - __i915_gem_object_pin_pages(obj); > -

Re: [Intel-gfx] [PATCH] drm/i915: Fix pages pin counting around swizzle quirk

2016-11-03 Thread Chris Wilson
On Wed, Nov 02, 2016 at 09:43:54AM +, Chris Wilson wrote: > commit bc0629a76726 ("drm/i915: Track pages pinned due to swizzling > quirk") fixed one problem, but revealed a whole lot more. The root cause > of the pin count mismatch for the swizzle quirk (for L-shaped memory on > gen3/4) was that

[Intel-gfx] [PATCH] drm/i915: Fix pages pin counting around swizzle quirk

2016-11-02 Thread Chris Wilson
commit bc0629a76726 ("drm/i915: Track pages pinned due to swizzling quirk") fixed one problem, but revealed a whole lot more. The root cause of the pin count mismatch for the swizzle quirk (for L-shaped memory on gen3/4) was that we were incrementing the pages_pin_count upon getting the backing pag