Re: [Intel-gfx] [PATCH] drm/i915: fix Haswell pfit power well check v2

2013-05-03 Thread Daniel Vetter
On Fri, May 03, 2013 at 12:01:49PM -0300, Paulo Zanoni wrote: > 2013/5/3 Mika Kuoppala : > > Jesse Barnes writes: > > > >> We can't read the pfit regs if the power well is off, so use the cached > >> value. > >> > >> v2: re-add lost comment (Jesse) > >> make sure the crtc using the fitter is a

Re: [Intel-gfx] [PATCH] drm/i915: fix Haswell pfit power well check v2

2013-05-03 Thread Paulo Zanoni
2013/5/3 Mika Kuoppala : > Jesse Barnes writes: > >> We can't read the pfit regs if the power well is off, so use the cached >> value. >> >> v2: re-add lost comment (Jesse) >> make sure the crtc using the fitter is actually enabled (Jesse) >> >> Signed-off-by: Jesse Barnes >> --- >> drivers/

Re: [Intel-gfx] [PATCH] drm/i915: fix Haswell pfit power well check v2

2013-05-03 Thread Mika Kuoppala
Jesse Barnes writes: > We can't read the pfit regs if the power well is off, so use the cached > value. > > v2: re-add lost comment (Jesse) > make sure the crtc using the fitter is actually enabled (Jesse) > > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/intel_display.c |2 +

Re: [Intel-gfx] [PATCH] drm/i915: fix Haswell pfit power well check v2

2013-05-03 Thread Daniel Vetter
On Fri, May 3, 2013 at 12:30 AM, Jesse Barnes wrote: > We can't read the pfit regs if the power well is off, so use the cached > value. > > v2: re-add lost comment (Jesse) > make sure the crtc using the fitter is actually enabled (Jesse) > > Signed-off-by: Jesse Barnes Just a quick maintaine

[Intel-gfx] [PATCH] drm/i915: fix Haswell pfit power well check v2

2013-05-02 Thread Jesse Barnes
We can't read the pfit regs if the power well is off, so use the cached value. v2: re-add lost comment (Jesse) make sure the crtc using the fitter is actually enabled (Jesse) Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_display.c |2 +- 1 file changed, 1 insertion(+), 1 de

[Intel-gfx] [PATCH] drm/i915: fix Haswell pfit power well check

2013-05-02 Thread Jesse Barnes
We can't read the pfit regs if the power well is off, so use the cached value. However, I think this check is incorrect (it was taken from an earlier check against dev_priv). We should probably just drop it altogether, since the panel fitter isn't useful without a pipe to fetch from and an encode