Re: [Intel-gfx] [PATCH] drm/rcar-du: Fix error check when retrieving crtc state

2019-06-18 Thread Sean Paul
On Tue, Jun 18, 2019 at 10:26:52AM +0300, Laurent Pinchart wrote: > Hi Sean, > > Thank you for the patch. > > On Mon, Jun 17, 2019 at 02:15:42PM -0400, Sean Paul wrote: > > From: Sean Paul > > > > drm_atomic_get_crtc_state() returns an error pointer when it fails, so > > the null check is doing

Re: [Intel-gfx] [PATCH] drm/rcar-du: Fix error check when retrieving crtc state

2019-06-18 Thread Laurent Pinchart
Hi Sean, Thank you for the patch. On Mon, Jun 17, 2019 at 02:15:42PM -0400, Sean Paul wrote: > From: Sean Paul > > drm_atomic_get_crtc_state() returns an error pointer when it fails, so > the null check is doing nothing here. > > Credit to 0-day/Dan Carpenter for reporting this. > > Fixes: 6f

[Intel-gfx] [PATCH] drm/rcar-du: Fix error check when retrieving crtc state

2019-06-17 Thread Sean Paul
From: Sean Paul drm_atomic_get_crtc_state() returns an error pointer when it fails, so the null check is doing nothing here. Credit to 0-day/Dan Carpenter for reporting this. Fixes: 6f3b62781bbd ("drm: Convert connector_helper_funcs->atomic_check to accept drm_atomic_state") Cc: Daniel Vetter