Re: [Intel-gfx] [PATCH 1/2] drm/i915/icl: Default to Thread Group preemption for compute workloads

2020-03-03 Thread Jason Ekstrand
FYI: For compute shaders, we have a bit in INTERFACE_DESCRIPTOR_DATA for this which we can set from userspace without whitelisting a register. If drivers can't handle mid-thread, they should just set that bit. Unless we can mid-thread preempt media or 3D which don't have such a bit in which case

Re: [Intel-gfx] [PATCH 1/2] drm/i915/icl: Default to Thread Group preemption for compute workloads

2019-03-06 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-03-05 21:10:42) > Quoting Rafael Antognolli (2019-03-05 17:30:00) > > On Tue, Mar 05, 2019 at 01:48:26PM +0100, Michał Winiarski wrote: > > > We assumed that the default preemption granularity is fine for ICL. > > > Unfortunately, it turns out that some drivers don't

Re: [Intel-gfx] [PATCH 1/2] drm/i915/icl: Default to Thread Group preemption for compute workloads

2019-03-05 Thread Chris Wilson
Quoting Rafael Antognolli (2019-03-05 17:30:00) > On Tue, Mar 05, 2019 at 01:48:26PM +0100, Michał Winiarski wrote: > > We assumed that the default preemption granularity is fine for ICL. > > Unfortunately, it turns out that some drivers don't support mid-thread > > preemption for compute

Re: [Intel-gfx] [PATCH 1/2] drm/i915/icl: Default to Thread Group preemption for compute workloads

2019-03-05 Thread Anuj Phogat
Fixes multiple gpu hangs in piglit and vulkancts. Both patches are: Tested-by: Anuj Phogat On Tue, Mar 5, 2019 at 4:48 AM Michał Winiarski wrote: > > We assumed that the default preemption granularity is fine for ICL. > Unfortunately, it turns out that some drivers don't support mid-thread >

Re: [Intel-gfx] [PATCH 1/2] drm/i915/icl: Default to Thread Group preemption for compute workloads

2019-03-05 Thread Rafael Antognolli
On Tue, Mar 05, 2019 at 01:48:26PM +0100, Michał Winiarski wrote: > We assumed that the default preemption granularity is fine for ICL. > Unfortunately, it turns out that some drivers don't support mid-thread > preemption for compute workloads. > If a workload that doesn't support mid-thread

[Intel-gfx] [PATCH 1/2] drm/i915/icl: Default to Thread Group preemption for compute workloads

2019-03-05 Thread Michał Winiarski
We assumed that the default preemption granularity is fine for ICL. Unfortunately, it turns out that some drivers don't support mid-thread preemption for compute workloads. If a workload that doesn't support mid-thread preemption gets mid-thread preempted, we're going to observe a GPU hang. While

Re: [Intel-gfx] [PATCH 1/2] drm/i915/icl: Default to Thread Group preemption for compute workloads

2019-02-28 Thread Chris Wilson
Quoting Rodrigo Vivi (2019-02-28 22:32:35) > On Thu, Feb 28, 2019 at 11:02:54AM -0800, Rodrigo Vivi wrote: > (What I' wondering now is that how this behaviour can change with GuC... > I heard some media folks were using i915 directly and facing some > strange gpu hangs but no gpu hang when using

Re: [Intel-gfx] [PATCH 1/2] drm/i915/icl: Default to Thread Group preemption for compute workloads

2019-02-28 Thread Rodrigo Vivi
On Thu, Feb 28, 2019 at 11:02:54AM -0800, Rodrigo Vivi wrote: > On Wed, Feb 27, 2019 at 04:51:08PM +0100, Michał Winiarski wrote: > > We assumed that the default preemption granularity is fine for ICL. > > Unfortunately, it turns out that some drivers don't support mid-thread > > preemption for

Re: [Intel-gfx] [PATCH 1/2] drm/i915/icl: Default to Thread Group preemption for compute workloads

2019-02-28 Thread Rodrigo Vivi
On Wed, Feb 27, 2019 at 04:51:08PM +0100, Michał Winiarski wrote: > We assumed that the default preemption granularity is fine for ICL. > Unfortunately, it turns out that some drivers don't support mid-thread > preemption for compute workloads. > If a workload that doesn't support mid-thread

Re: [Intel-gfx] [PATCH 1/2] drm/i915/icl: Default to Thread Group preemption for compute workloads

2019-02-27 Thread Anuj Phogat
Tested both the patches with drm-tip kernel. Fixes multiple gpu hangs in vulkan cts and piglit. I will do more thorough testing with updated version of these patches based on review. On Wed, Feb 27, 2019 at 7:52 AM Michał Winiarski wrote: > > We assumed that the default preemption granularity

[Intel-gfx] [PATCH 1/2] drm/i915/icl: Default to Thread Group preemption for compute workloads

2019-02-27 Thread Michał Winiarski
We assumed that the default preemption granularity is fine for ICL. Unfortunately, it turns out that some drivers don't support mid-thread preemption for compute workloads. If a workload that doesn't support mid-thread preemption gets mid-thread preempted, we're going to observe a GPU hang. While