Re: [Intel-gfx] [PATCH 1/2] drm/i915: Add pretty printer for device info flags

2017-12-18 Thread Chris Wilson
Quoting Jani Nikula (2017-12-18 17:37:13) > On Mon, 18 Dec 2017, Chris Wilson wrote: > > Looks good, I'm thinking we might push the drm_printer to the caller of > > intel_device_info_dump(), but this is already a substantial improvement > > Param ordering seems a bit surprising in both patches. T

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Add pretty printer for device info flags

2017-12-18 Thread Jani Nikula
On Mon, 18 Dec 2017, Chris Wilson wrote: > Quoting Michal Wajdeczko (2017-12-18 15:51:31) >> We dump device flags in few places (init_early, debugfs, gpu_error) >> using different functions. Lets add reusable function to avoid >> code duplication. >> >> add/remove: 1/0 grow/shrink: 0/3 up/down: 1

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Add pretty printer for device info flags

2017-12-18 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-12-18 15:51:31) > We dump device flags in few places (init_early, debugfs, gpu_error) > using different functions. Lets add reusable function to avoid > code duplication. > > add/remove: 1/0 grow/shrink: 0/3 up/down: 1296/-3572 (-2276) > Function

[Intel-gfx] [PATCH 1/2] drm/i915: Add pretty printer for device info flags

2017-12-18 Thread Michal Wajdeczko
We dump device flags in few places (init_early, debugfs, gpu_error) using different functions. Lets add reusable function to avoid code duplication. add/remove: 1/0 grow/shrink: 0/3 up/down: 1296/-3572 (-2276) Function old new delta intel_device_info_dump_