Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix up semaphore_waits_for

2014-03-25 Thread Daniel Vetter
On Tue, Mar 25, 2014 at 3:54 PM, Ben Widawsky wrote: > I don't think it's quite that easy, but I took it as a, "yes." Which one > is patch 3? "drm/i915: make semaphore signaller detection more robust" - it was a follow-up patch in this thread, hence no 3/3. If the relevant bits on bdw have moved

Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix up semaphore_waits_for

2014-03-25 Thread Ben Widawsky
On Tue, Mar 25, 2014 at 10:42:09AM +0100, Daniel Vetter wrote: > On Mon, Mar 24, 2014 at 03:37:12PM -0700, Ben Widawsky wrote: > > On Sat, Mar 22, 2014 at 06:52:25PM +0100, Daniel Vetter wrote: > > > On Fri, Mar 21, 2014 at 07:33:59PM +0200, Mika Kuoppala wrote: > > > > Hi, > > > > > > > > Daniel

Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix up semaphore_waits_for

2014-03-25 Thread Daniel Vetter
On Mon, Mar 24, 2014 at 03:37:12PM -0700, Ben Widawsky wrote: > On Sat, Mar 22, 2014 at 06:52:25PM +0100, Daniel Vetter wrote: > > On Fri, Mar 21, 2014 at 07:33:59PM +0200, Mika Kuoppala wrote: > > > Hi, > > > > > > Daniel Vetter writes: > > > > > > > There's an entire pile of issues in here: >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix up semaphore_waits_for

2014-03-24 Thread Ben Widawsky
On Sat, Mar 22, 2014 at 06:52:25PM +0100, Daniel Vetter wrote: > On Fri, Mar 21, 2014 at 07:33:59PM +0200, Mika Kuoppala wrote: > > Hi, > > > > Daniel Vetter writes: > > > > > There's an entire pile of issues in here: > > > > > > - Use the main RING_HEAD register, not ACTHD. ACTHD points at the

Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix up semaphore_waits_for

2014-03-22 Thread Daniel Vetter
On Fri, Mar 21, 2014 at 07:33:59PM +0200, Mika Kuoppala wrote: > Hi, > > Daniel Vetter writes: > > > There's an entire pile of issues in here: > > > > - Use the main RING_HEAD register, not ACTHD. ACTHD points at the gtt > > offset of the batch buffer when a batch is executed. Semaphores are >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix up semaphore_waits_for

2014-03-21 Thread Mika Kuoppala
Hi, Daniel Vetter writes: > There's an entire pile of issues in here: > > - Use the main RING_HEAD register, not ACTHD. ACTHD points at the gtt > offset of the batch buffer when a batch is executed. Semaphores are > always emitted to the main ring, so we always want to look at that. The ipe

Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix up semaphore_waits_for

2014-03-15 Thread Chris Wilson
On Sat, Mar 15, 2014 at 05:31:04PM +0100, Daniel Vetter wrote: > On Sat, Mar 15, 2014 at 4:46 PM, Chris Wilson > wrote: > > On Sat, Mar 15, 2014 at 12:08:55AM +0100, Daniel Vetter wrote: > >> There's an entire pile of issues in here: > >> > >> - Use the main RING_HEAD register, not ACTHD. ACTHD p

Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix up semaphore_waits_for

2014-03-15 Thread Daniel Vetter
On Sat, Mar 15, 2014 at 4:46 PM, Chris Wilson wrote: > On Sat, Mar 15, 2014 at 12:08:55AM +0100, Daniel Vetter wrote: >> There's an entire pile of issues in here: >> >> - Use the main RING_HEAD register, not ACTHD. ACTHD points at the gtt >> offset of the batch buffer when a batch is executed. S

Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix up semaphore_waits_for

2014-03-15 Thread Chris Wilson
On Sat, Mar 15, 2014 at 12:08:55AM +0100, Daniel Vetter wrote: > There's an entire pile of issues in here: > > - Use the main RING_HEAD register, not ACTHD. ACTHD points at the gtt > offset of the batch buffer when a batch is executed. Semaphores are > always emitted to the main ring, so we al

[Intel-gfx] [PATCH 1/2] drm/i915: fix up semaphore_waits_for

2014-03-15 Thread Daniel Vetter
There's an entire pile of issues in here: - Use the main RING_HEAD register, not ACTHD. ACTHD points at the gtt offset of the batch buffer when a batch is executed. Semaphores are always emitted to the main ring, so we always want to look at that. - Mask the obtained HEAD pointer with the act