Re: [Intel-gfx] [PATCH 4/7] drm/i915/cnl: Fix wrpll math for higher freqs.

2017-11-16 Thread Mika Kahola
On Wed, 2017-11-15 at 10:04 -0800, Rodrigo Vivi wrote: > On Wed, Nov 15, 2017 at 08:06:16AM +, Mika Kahola wrote: > > > > On Tue, 2017-11-14 at 11:47 -0800, Rodrigo Vivi wrote: > > > > > > Spec describe all values in MHz. We handle our > > > clocks in KHz. This includes the best_dco_centralit

Re: [Intel-gfx] [PATCH 4/7] drm/i915/cnl: Fix wrpll math for higher freqs.

2017-11-15 Thread Rodrigo Vivi
On Wed, Nov 15, 2017 at 08:06:16AM +, Mika Kahola wrote: > On Tue, 2017-11-14 at 11:47 -0800, Rodrigo Vivi wrote: > > Spec describe all values in MHz. We handle our > > clocks in KHz. This includes the best_dco_centrality that was > > forgot in the same unity as spec. Consequently we couldn't >

Re: [Intel-gfx] [PATCH 4/7] drm/i915/cnl: Fix wrpll math for higher freqs.

2017-11-15 Thread Mika Kahola
On Tue, 2017-11-14 at 11:47 -0800, Rodrigo Vivi wrote: > Spec describe all values in MHz. We handle our > clocks in KHz. This includes the best_dco_centrality that was > forgot in the same unity as spec. Consequently we couldn't > get a good divider for high frequenies. Hence HDMI 2.0 wasn't > work

Re: [Intel-gfx] [PATCH 4/7] drm/i915/cnl: Fix wrpll math for higher freqs.

2017-11-14 Thread Ville Syrjälä
On Tue, Nov 14, 2017 at 12:09:39PM -0800, Rodrigo Vivi wrote: > On Tue, Nov 14, 2017 at 08:00:31PM +, Ville Syrjälä wrote: > > On Tue, Nov 14, 2017 at 11:47:56AM -0800, Rodrigo Vivi wrote: > > > Spec describe all values in MHz. We handle our > > > clocks in KHz. This includes the best_dco_centr

Re: [Intel-gfx] [PATCH 4/7] drm/i915/cnl: Fix wrpll math for higher freqs.

2017-11-14 Thread Rodrigo Vivi
On Tue, Nov 14, 2017 at 08:00:31PM +, Ville Syrjälä wrote: > On Tue, Nov 14, 2017 at 11:47:56AM -0800, Rodrigo Vivi wrote: > > Spec describe all values in MHz. We handle our > > clocks in KHz. This includes the best_dco_centrality that was > > forgot in the same unity as spec. Consequently we c

Re: [Intel-gfx] [PATCH 4/7] drm/i915/cnl: Fix wrpll math for higher freqs.

2017-11-14 Thread Ville Syrjälä
On Tue, Nov 14, 2017 at 11:47:56AM -0800, Rodrigo Vivi wrote: > Spec describe all values in MHz. We handle our > clocks in KHz. This includes the best_dco_centrality that was > forgot in the same unity as spec. Consequently we couldn't > get a good divider for high frequenies. Hence HDMI 2.0 wasn't

[Intel-gfx] [PATCH 4/7] drm/i915/cnl: Fix wrpll math for higher freqs.

2017-11-14 Thread Rodrigo Vivi
Spec describe all values in MHz. We handle our clocks in KHz. This includes the best_dco_centrality that was forgot in the same unity as spec. Consequently we couldn't get a good divider for high frequenies. Hence HDMI 2.0 wasn't working. This patch also replaces the use of "* KHz(1)" with the val