Re: [Intel-gfx] [PATCH i-g-t] Add dmesg capture and dumping to tests and a test for it.

2015-11-23 Thread Joonas Lahtinen
On pe, 2015-11-20 at 11:34 +, Chris Wilson wrote: > On Fri, Nov 20, 2015 at 01:22:51PM +0200, Joonas Lahtinen wrote: > > On to, 2015-11-19 at 10:41 +0100, Daniel Vetter wrote: > > > On Thu, Nov 19, 2015 at 10:38 AM, Daniel Vetter > > > wrote: > > > > On Wed, Nov 18, 2015 at 05:32:59PM +, C

Re: [Intel-gfx] [PATCH i-g-t] Add dmesg capture and dumping to tests and a test for it.

2015-11-20 Thread Chris Wilson
On Fri, Nov 20, 2015 at 01:22:51PM +0200, Joonas Lahtinen wrote: > On to, 2015-11-19 at 10:41 +0100, Daniel Vetter wrote: > > On Thu, Nov 19, 2015 at 10:38 AM, Daniel Vetter > > wrote: > > > On Wed, Nov 18, 2015 at 05:32:59PM +, Chris Wilson wrote: > > > > On Wed, Nov 18, 2015 at 04:44:20PM +0

Re: [Intel-gfx] [PATCH i-g-t] Add dmesg capture and dumping to tests and a test for it.

2015-11-20 Thread Joonas Lahtinen
On to, 2015-11-19 at 10:41 +0100, Daniel Vetter wrote: > On Thu, Nov 19, 2015 at 10:38 AM, Daniel Vetter > wrote: > > On Wed, Nov 18, 2015 at 05:32:59PM +, Chris Wilson wrote: > > > On Wed, Nov 18, 2015 at 04:44:20PM +0100, Daniel Vetter wrote: > > > > On Mon, Nov 16, 2015 at 03:22:23PM +0200,

Re: [Intel-gfx] [PATCH i-g-t] Add dmesg capture and dumping to tests and a test for it.

2015-11-19 Thread Daniel Vetter
On Thu, Nov 19, 2015 at 10:38 AM, Daniel Vetter wrote: > On Wed, Nov 18, 2015 at 05:32:59PM +, Chris Wilson wrote: >> On Wed, Nov 18, 2015 at 04:44:20PM +0100, Daniel Vetter wrote: >> > On Mon, Nov 16, 2015 at 03:22:23PM +0200, Joonas Lahtinen wrote: >> > > Cc: Thomas Wood >> > > Cc: Chris Wi

Re: [Intel-gfx] [PATCH i-g-t] Add dmesg capture and dumping to tests and a test for it.

2015-11-19 Thread Daniel Vetter
On Wed, Nov 18, 2015 at 05:32:59PM +, Chris Wilson wrote: > On Wed, Nov 18, 2015 at 04:44:20PM +0100, Daniel Vetter wrote: > > On Mon, Nov 16, 2015 at 03:22:23PM +0200, Joonas Lahtinen wrote: > > > Cc: Thomas Wood > > > Cc: Chris Wilson > > > Cc: Damien Lespiau > > > Signed-off-by: Joonas La

Re: [Intel-gfx] [PATCH i-g-t] Add dmesg capture and dumping to tests and a test for it.

2015-11-18 Thread Joonas Lahtinen
On ke, 2015-11-18 at 17:41 +, Thomas Wood wrote: > On 18 November 2015 at 15:44, Daniel Vetter wrote: > > On Mon, Nov 16, 2015 at 03:22:23PM +0200, Joonas Lahtinen wrote: > > > Cc: Thomas Wood > > > Cc: Chris Wilson > > > Cc: Damien Lespiau > > > Signed-off-by: Joonas Lahtinen > > > > Giv

Re: [Intel-gfx] [PATCH i-g-t] Add dmesg capture and dumping to tests and a test for it.

2015-11-18 Thread Thomas Wood
On 18 November 2015 at 15:44, Daniel Vetter wrote: > On Mon, Nov 16, 2015 at 03:22:23PM +0200, Joonas Lahtinen wrote: >> Cc: Thomas Wood >> Cc: Chris Wilson >> Cc: Damien Lespiau >> Signed-off-by: Joonas Lahtinen > > Given that we have all that in piglit already the commit message is a bit > t

Re: [Intel-gfx] [PATCH i-g-t] Add dmesg capture and dumping to tests and a test for it.

2015-11-18 Thread Chris Wilson
On Wed, Nov 18, 2015 at 04:44:20PM +0100, Daniel Vetter wrote: > On Mon, Nov 16, 2015 at 03:22:23PM +0200, Joonas Lahtinen wrote: > > Cc: Thomas Wood > > Cc: Chris Wilson > > Cc: Damien Lespiau > > Signed-off-by: Joonas Lahtinen > > Given that we have all that in piglit already the commit mess

Re: [Intel-gfx] [PATCH i-g-t] Add dmesg capture and dumping to tests and a test for it.

2015-11-18 Thread Daniel Vetter
On Mon, Nov 16, 2015 at 03:22:23PM +0200, Joonas Lahtinen wrote: > Cc: Thomas Wood > Cc: Chris Wilson > Cc: Damien Lespiau > Signed-off-by: Joonas Lahtinen Given that we have all that in piglit already the commit message is a bit thin on justification. Why do we need this in igt too? How does

Re: [Intel-gfx] [PATCH i-g-t] Add dmesg capture and dumping to tests and a test for it.

2015-11-17 Thread Joonas Lahtinen
On ti, 2015-11-17 at 13:05 +, Thomas Wood wrote: > On 16 November 2015 at 13:22, Joonas Lahtinen > wrote: > > +static void _igt_kmsg_capture_dump(void) > > +{ > > > > + //fputs(strchr(igt_kmsg_capture_dump_buf, ';') + 1, > > stderr); > > This line can be removed if it is no lo

Re: [Intel-gfx] [PATCH i-g-t] Add dmesg capture and dumping to tests and a test for it.

2015-11-17 Thread Thomas Wood
On 16 November 2015 at 13:22, Joonas Lahtinen wrote: > Cc: Thomas Wood > Cc: Chris Wilson > Cc: Damien Lespiau > Signed-off-by: Joonas Lahtinen > --- > lib/igt_core.c | 113 > ++--- > tests/Makefile.sources | 1 + > tests/igt_capture.c

Re: [Intel-gfx] [PATCH i-g-t] Add dmesg capture and dumping to tests and a test for it.

2015-11-17 Thread Joonas Lahtinen
On ma, 2015-11-16 at 14:06 +, Chris Wilson wrote: > On Mon, Nov 16, 2015 at 03:22:23PM +0200, Joonas Lahtinen wrote: > > Cc: Thomas Wood > > Cc: Chris Wilson > > Cc: Damien Lespiau > > Signed-off-by: Joonas Lahtinen > > --- > > lib/igt_core.c | 113 > > +

Re: [Intel-gfx] [PATCH i-g-t] Add dmesg capture and dumping to tests and a test for it.

2015-11-16 Thread Chris Wilson
On Mon, Nov 16, 2015 at 03:22:23PM +0200, Joonas Lahtinen wrote: > Cc: Thomas Wood > Cc: Chris Wilson > Cc: Damien Lespiau > Signed-off-by: Joonas Lahtinen > --- > lib/igt_core.c | 113 > ++--- > tests/Makefile.sources | 1 + > tests/igt_c

[Intel-gfx] [PATCH i-g-t] Add dmesg capture and dumping to tests and a test for it.

2015-11-16 Thread Joonas Lahtinen
Cc: Thomas Wood Cc: Chris Wilson Cc: Damien Lespiau Signed-off-by: Joonas Lahtinen --- lib/igt_core.c | 113 ++--- tests/Makefile.sources | 1 + tests/igt_capture.c| 93 3 files changed, 200 ins