Re: [Intel-gfx] [PATCH v2 15/16] drm/i915/gen9: Reject display updates that exceed wm limitations

2016-04-22 Thread Matt Roper
On Fri, Apr 22, 2016 at 10:21:20AM -0400, Lyude Paul wrote: > Unfortunately dropping that patch just results with the screen staying blank > starting from the moment the driver loads.  > > As for the external monitors question: the only time this issue seems to > happen > with this patchset is

Re: [Intel-gfx] [PATCH v2 15/16] drm/i915/gen9: Reject display updates that exceed wm limitations

2016-04-22 Thread Lyude Paul
Unfortunately dropping that patch just results with the screen staying blank starting from the moment the driver loads.  As for the external monitors question: the only time this issue seems to happen with this patchset is when there's no external monitors connected. If I boot with just the

Re: [Intel-gfx] [PATCH v2 15/16] drm/i915/gen9: Reject display updates that exceed wm limitations

2016-04-21 Thread Matt Roper
On Thu, Apr 21, 2016 at 05:49:52PM -0400, Lyude Paul wrote: > On a T560, this ends up rejecting valid watermark configurations so the > internal > display doesn't switch from fbcon to X properly: Hmm. We can leave this patch out of the series and still have a fix for the WARN_ON(!wm_changed),

Re: [Intel-gfx] [PATCH v2 15/16] drm/i915/gen9: Reject display updates that exceed wm limitations

2016-04-21 Thread Lyude Paul
On a T560, this ends up rejecting valid watermark configurations so the internal display doesn't switch from fbcon to X properly: [5.767383] [drm:intelfb_create] re-using BIOS fb [5.767444] [drm] Initialized i915 1.6.0 20160411 for :00:02.0 on minor 0 [5.767449]

[Intel-gfx] [PATCH v2 15/16] drm/i915/gen9: Reject display updates that exceed wm limitations

2016-04-19 Thread Matt Roper
If we can't find any valid level 0 watermark values for the requested atomic transaction, reject the configuration before we try to start programming the hardware. Signed-off-by: Matt Roper Reviewed-by: Maarten Lankhorst ---