Re: [Intel-gfx] [PATCH v4 18/26] drm/i915/slpc: Add i915_slpc_info to debugfs

2016-09-15 Thread Kamble, Sagar A
On 9/9/2016 10:44 PM, Chris Wilson wrote: On Fri, Sep 09, 2016 at 06:21:37PM +0530, Sagar Arun Kamble wrote: + if (!intel_slpc_active(dev_priv)) + return -ENODEV; Can we really say slpc is active without an slpc.vma? No. Will remove this check. -Chris

Re: [Intel-gfx] [PATCH v4 18/26] drm/i915/slpc: Add i915_slpc_info to debugfs

2016-09-09 Thread Chris Wilson
On Fri, Sep 09, 2016 at 06:21:37PM +0530, Sagar Arun Kamble wrote: > + if (!intel_slpc_active(dev_priv)) > + return -ENODEV; Can we really say slpc is active without an slpc.vma? -Chris -- Chris Wilson, Intel Open Source Technology Centre _

[Intel-gfx] [PATCH v4 18/26] drm/i915/slpc: Add i915_slpc_info to debugfs

2016-09-09 Thread Sagar Arun Kamble
From: Tom O'Rourke i915_slpc_info shows the contents of SLPC shared data parsed into text format. v1: Reformat slpc info (Radek) squashed query task state info in slpc info, kunmap before seq_print (Paulo) return void instead of ignored return value (Paulo) Avoid magic numbers an