Re: [Intel-wired-lan] [PATCH net v2 2/2] page_pool: fix IOMMU crash when driver has already unbound

2024-10-01 Thread Ilias Apalodimas
On Wed, 2 Oct 2024 at 09:46, Ilias Apalodimas wrote: > > Hi Paolo, > > Thanks for taking the time. > > On Tue, 1 Oct 2024 at 16:32, Paolo Abeni wrote: > > > > On 9/25/24 09:57, Yunsheng Lin wrote: > > > Networking driver with page_pool support may hand over page > > > still with dma mapping to ne

Re: [Intel-wired-lan] [PATCH net v2 2/2] page_pool: fix IOMMU crash when driver has already unbound

2024-10-01 Thread Ilias Apalodimas
Hi Paolo, Thanks for taking the time. On Tue, 1 Oct 2024 at 16:32, Paolo Abeni wrote: > > On 9/25/24 09:57, Yunsheng Lin wrote: > > Networking driver with page_pool support may hand over page > > still with dma mapping to network stack and try to reuse that > > page after network stack is done w

[Intel-wired-lan] [RFC net-next v4 3/9] net: napi: Make gro_flush_timeout per-NAPI

2024-10-01 Thread Joe Damato
Allow per-NAPI gro_flush_timeout setting. The existing sysfs parameter is respected; writes to sysfs will write to all NAPI structs for the device and the net_device gro_flush_timeout field. Reads from sysfs will read from the net_device field. The ability to set gro_flush_timeout on specific NAP

[Intel-wired-lan] [RFC net-next v4 0/9] Add support for per-NAPI config via netlink

2024-10-01 Thread Joe Damato
Greetings: Welcome to RFC v4. Very important and significant changes have been made since RFC v3 [1], please see the changelog below for details. A couple important call outs for this revision for reviewers: 1. idpf embeds a napi_struct in an internal data structure and includes an asser

Re: [Intel-wired-lan] [net-next v3 1/2] e1000e: Link NAPI instances to queues and IRQs

2024-10-01 Thread Lifshits, Vitaly
On 10/1/2024 1:50 PM, Simon Horman wrote: On Mon, Sep 30, 2024 at 05:12:31PM +, Joe Damato wrote: Add support for netdev-genl, allowing users to query IRQ, NAPI, and queue information. After this patch is applied, note the IRQs assigned to my NIC: $ cat /proc/interrupts | grep ens | cut

[Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: Remove Meteor Lake SMBUS workarounds

2024-10-01 Thread Vitaly Lifshits
This is a partial revert to commit 76a0a3f9cc2f ("e1000e: fix force smbus during suspend flow"). That commit fixed a sporadic PHY access issue but introduced a regression in runtime suspend flows. The original issue on Meteor Lake systems was rare in terms of the reproduction rate and the number of

[Intel-wired-lan] [PATCH iwl-next v1 1/1] igc: remove autoneg parameter from igc_mac_info

2024-10-01 Thread Vitaly Lifshits
Since the igc driver doesn't support forced speed configuration and its current related hardware doesn't support it either, there is no use of the mac.autoneg parameter. Moreover, in one case this usage might result in a NULL pointer dereference due to an uninitialized function pointer, phy.ops.for

Re: [Intel-wired-lan] [RFC net-next 1/1] idpf: Don't hard code napi_struct size

2024-10-01 Thread Alexander Lobakin
From: Joe Damato Date: Mon, 30 Sep 2024 15:17:46 -0700 > On Mon, Sep 30, 2024 at 03:10:41PM +0200, Przemek Kitszel wrote: >> On 9/30/24 14:38, Alexander Lobakin wrote: >>> From: Alexander Lobakin >>> Date: Mon, 30 Sep 2024 14:33:45 +0200 >>> From: Joe Damato Date: Wed, 25 Sep 2024 18:

Re: [Intel-wired-lan] [RFC bpf-next 0/4] Add XDP rx hw hints support performing XDP_REDIRECT

2024-10-01 Thread Toke Høiland-Jørgensen
"Arthur Fabre" writes: > On Mon Sep 30, 2024 at 12:52 PM CEST, Toke Høiland-Jørgensen wrote: >> > Thinking about it more, my only relectance for a registration API is how >> > to communicate the ID back to other consumers (our discussion below). >> > >> >> >> >> > Dynamically registering fields m

[Intel-wired-lan] [PATCH iwl-next 0/2] Extend the dump serdes equalizer values feature

2024-10-01 Thread Mateusz Polchlopek
Extend the work done in commit 70838938e89c ("ice: Implement driver functionality to dump serdes equalizer values") by refactor the ice_get_tx_rx_equa() function, shorten struct fields names and add new Rx registers that can be read using command: $ ethtool -d interface_name. Mateusz Polchlopek (

[Intel-wired-lan] [PATCH iwl-next 2/2] ice: extend dump serdes equalizer values feature

2024-10-01 Thread Mateusz Polchlopek
Extend the work done in commit 70838938e89c ("ice: Implement driver functionality to dump serdes equalizer values") by adding the new set of Rx registers that can be read using command: $ ethtool -d interface_name Rx equalization parameters are E810 PHY registers used by end user to gather infor

[Intel-wired-lan] [PATCH iwl-next 1/2] ice: rework of dump serdes equalizer values feature

2024-10-01 Thread Mateusz Polchlopek
Refactor function ice_get_tx_rx_equa() to iterate over new table of params instead of multiple calls to ice_aq_get_phy_equalization(). Subsequent commit will extend that function by add more serdes equalizer values to dump. Shorten the fields of struct ice_serdes_equalization_to_ethtool for reada

Re: [Intel-wired-lan] [PATCH iwl-next v10 07/14] iavf: add support for indirect access to PHC time

2024-10-01 Thread Mateusz Polchlopek
On 8/21/2024 4:31 PM, Alexander Lobakin wrote: From: Wojciech Drewek Date: Wed, 21 Aug 2024 14:15:32 +0200 From: Jacob Keller Implement support for reading the PHC time indirectly via the VIRTCHNL_OP_1588_PTP_GET_TIME operation. [...] +/** + * iavf_queue_ptp_cmd - Queue PTP command fo

Re: [Intel-wired-lan] [RFC bpf-next 0/4] Add XDP rx hw hints support performing XDP_REDIRECT

2024-10-01 Thread Toke Høiland-Jørgensen
Lorenzo Bianconi writes: >> On Mon Sep 30, 2024 at 1:49 PM CEST, Lorenzo Bianconi wrote: >> > > Lorenzo Bianconi writes: >> > > >> > > >> > We could combine such a registration API with your header format, so >> > > >> > that the registration just becomes a way of allocating one of the >> > >

[Intel-wired-lan] [tnguy-net-queue:100GbE] BUILD SUCCESS 09d0fb5cb30ebcaed4a33028ae383f5a1463e2b2

2024-10-01 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git 100GbE branch HEAD: 09d0fb5cb30ebcaed4a33028ae383f5a1463e2b2 idpf: deinit virtchnl transaction manager after vport and vectors elapsed time: 829m configs tested: 94 configs skipped: 3 The following configs have b

Re: [Intel-wired-lan] [RFC bpf-next 0/4] Add XDP rx hw hints support performing XDP_REDIRECT

2024-10-01 Thread Lorenzo Bianconi
> On Mon Sep 30, 2024 at 1:49 PM CEST, Lorenzo Bianconi wrote: > > > Lorenzo Bianconi writes: > > > > > > >> > We could combine such a registration API with your header format, so > > > >> > that the registration just becomes a way of allocating one of the > > > >> > keys > > > >> > from 0-63 (a

Re: [Intel-wired-lan] [RFC bpf-next 0/4] Add XDP rx hw hints support performing XDP_REDIRECT

2024-10-01 Thread Arthur Fabre
On Mon Sep 30, 2024 at 12:52 PM CEST, Toke Høiland-Jørgensen wrote: > > Thinking about it more, my only relectance for a registration API is how > > to communicate the ID back to other consumers (our discussion below). > > > >> > >> > Dynamically registering fields means you have to share the retur

Re: [Intel-wired-lan] [PATCH net v2 2/2] page_pool: fix IOMMU crash when driver has already unbound

2024-10-01 Thread Paolo Abeni
On 9/25/24 09:57, Yunsheng Lin wrote: Networking driver with page_pool support may hand over page still with dma mapping to network stack and try to reuse that page after network stack is done with it and passes it back to page_pool to avoid the penalty of dma mapping/unmapping. With all the cach

Re: [Intel-wired-lan] [RFC net-next 1/1] idpf: Don't hard code napi_struct size

2024-10-01 Thread Joe Damato
On Tue, Oct 01, 2024 at 03:14:07PM +0200, Alexander Lobakin wrote: > From: Joe Damato > Date: Mon, 30 Sep 2024 15:17:46 -0700 > > > On Mon, Sep 30, 2024 at 03:10:41PM +0200, Przemek Kitszel wrote: > >> On 9/30/24 14:38, Alexander Lobakin wrote: > >>> From: Alexander Lobakin > >>> Date: Mon, 30 S

Re: [Intel-wired-lan] [net-next v3 1/2] e1000e: Link NAPI instances to queues and IRQs

2024-10-01 Thread Simon Horman
On Mon, Sep 30, 2024 at 05:12:31PM +, Joe Damato wrote: > Add support for netdev-genl, allowing users to query IRQ, NAPI, and queue > information. > > After this patch is applied, note the IRQs assigned to my NIC: > > $ cat /proc/interrupts | grep ens | cut -f1 --delimiter=':' > 50 > 51 >

Re: [Intel-wired-lan] [net-next v3 2/2] e1000: Link NAPI instances to queues and IRQs

2024-10-01 Thread Simon Horman
On Mon, Sep 30, 2024 at 05:12:32PM +, Joe Damato wrote: > Add support for netdev-genl, allowing users to query IRQ, NAPI, and queue > information. > > After this patch is applied, note the IRQ assigned to my NIC: > > $ cat /proc/interrupts | grep enp0s8 | cut -f1 --delimiter=':' > 18 > > No

Re: [Intel-wired-lan] [PATCH iwl-next v10 07/14] iavf: add support for indirect access to PHC time

2024-10-01 Thread Alexander Lobakin
From: Mateusz Polchlopek Date: Tue, 1 Oct 2024 09:20:14 +0200 > > > On 8/21/2024 4:31 PM, Alexander Lobakin wrote: >> From: Wojciech Drewek >> Date: Wed, 21 Aug 2024 14:15:32 +0200 >> >>> From: Jacob Keller >>> >>> Implement support for reading the PHC time indirectly via the >>> VIRTCHNL_OP_

Re: [Intel-wired-lan] [RFC bpf-next 0/4] Add XDP rx hw hints support performing XDP_REDIRECT

2024-10-01 Thread Arthur Fabre
On Mon Sep 30, 2024 at 1:49 PM CEST, Lorenzo Bianconi wrote: > > Lorenzo Bianconi writes: > > > > >> > We could combine such a registration API with your header format, so > > >> > that the registration just becomes a way of allocating one of the keys > > >> > from 0-63 (and the registry just bec