Re: [PHP-DEV] [PATCH] fix symbol namespace pollution from bundled libgd

2004-08-17 Thread Joe Orton
On Mon, Aug 09, 2004 at 09:46:21AM +0200, Edin Kadribasic wrote: > I'm -1 on this patch. The problem is has existed for mysql lib for ages and > for all other libraries used by PHP. A note in the documentation stating that > if you want to use GD from PHP and another Apache module you need to com

Re: [PHP-DEV] Locale-aware date parsing

2004-08-17 Thread Hartmut Holzgraefe
Alexander Netkachev wrote: Hi! I'm learning the date formatting and parsing functions in PHP and see that there are no locale-aware date parsing function (strptime) that is a pair for strftime. Are there reasons to not implement it? Is a patch welcome? Short question: is it available on all our m

Re: [PHP-DEV] On Namespaces...

2004-08-17 Thread Zeev Suraski
At 21:06 16/08/2004, Marcus Boerger wrote: Hello Justin, Monday, August 16, 2004, 4:08:46 PM, you wrote: > Zeev, > I too have been searching the archives for subjects on 'namespace' and found > allot of back and forth opinions on it but not a real summary about its > conclusion. Basically, I have

Re: [PHP-DEV] On Namespaces...

2004-08-17 Thread Justin Hannus
> I don't see how it could change in the future, but that's > just my 2c :) Thanks, thats all I was really looking for. The status of the terms, cause if they're not being reserved then I would like to continue using them -- at my own risk. As Marcus points out, its might not be the best idea to i

Re: [PHP-DEV] [PATCH] fix symbol namespace pollution from bundled libgd

2004-08-17 Thread Andi Gutmans
Hi agree with Joe on this one. I think it would be beneficial to include this patch *even* if it means that we might have to update it from time to time. I'm sure Joe will lend a helping hand to do so. At 09:35 AM 8/17/2004 +0100, Joe Orton wrote: On Mon, Aug 09, 2004 at 09:46:21AM +0200, Edin K

[PHP-DEV] [PATCH] Re: [PHP-CVS] cvs: php-src(PHP_4_3) / php.ini-dist php.ini-recommended

2004-08-17 Thread Dave Barr
Andi Gutmans wrote: secondes should also be seconds. Here's a patch with a few more typo fixes. Dave At 10:58 AM 8/17/2004 +, Antony Dovgal wrote: tony2001Tue Aug 17 06:58:34 2004 EDT Modified files: (Branch: PHP_4_3) /php-srcphp.ini-dist php.ini-recommend

[PHP-DEV] [patch] Fix setting of packetsize in ext/sybase_ct

2004-08-17 Thread Alex Kiesel
Hi internals, the attached patch fixes the setting of packetsize in sybase_ct extension. Currently the packetsize is set via ct_config() which is not the right function for this - it should be done via ct_con_props() as this is a connection property according to Sybase docs. A small memory leak f

[PHP-DEV] Re: [PATCH] Re: [PHP-CVS] cvs: php-src(PHP_4_3) / php.ini-dist php.ini-recommended

2004-08-17 Thread Andi Gutmans
Can you please send it as a gziped attachment? Thanks, Andi At 08:01 AM 8/18/2004 +1000, Dave Barr wrote: Andi Gutmans wrote: secondes should also be seconds. Here's a patch with a few more typo fixes. Dave At 10:58 AM 8/17/2004 +, Antony Dovgal wrote: tony2001Tue Aug 17 06:58:3

[PHP-DEV] Re: [PATCH] Re: [PHP-CVS] cvs: php-src(PHP_4_3) / php.ini-dist php.ini-recommended

2004-08-17 Thread Dave Barr
Andi Gutmans wrote: Can you please send it as a gziped attachment? Thanks, Sure. Andi Dave At 08:01 AM 8/18/2004 +1000, Dave Barr wrote: Andi Gutmans wrote: secondes should also be seconds. Here's a patch with a few more typo fixes. Dave [snip] -- PHP Internals - PHP Runtime Development Mailing L

[PHP-DEV] Re: [PATCH] Re: [PHP-CVS] cvs: php-src(PHP_4_3) / php.ini-dist php.ini-recommended

2004-08-17 Thread Andi Gutmans
Commited. Thanks. Andi At 08:57 AM 8/18/2004 +1000, Dave Barr wrote: Andi Gutmans wrote: Can you please send it as a gziped attachment? Thanks, Sure. Andi Dave At 08:01 AM 8/18/2004 +1000, Dave Barr wrote: Andi Gutmans wrote: secondes should also be seconds. Here's a patch with a few more typo fix

[PHP-DEV] setcookie() and Max-Age

2004-08-17 Thread Andi Gutmans
Hey, There's a very interesting user contributed note for the setcookie() function (Follows in the end). I think it makes sense to support Max-Age because it fixes clock skew problems between the client and server. Not sure if an how this could be added to setcookie() because of the already rich

[PHP-DEV] php.net announcement

2004-08-17 Thread Sterling Hughes
http://www.php.net/: Hereby we would like to kindly ask everyone who published an article or howto about installing PHP on Windows to revise those instructions according to our latest guide. These new instructions got distributed with PHP 5.0.1 in both the source code and binary versions, and

[PHP-DEV] Re: setcookie() and Max-Age

2004-08-17 Thread Christian Schneider
Andi Gutmans wrote: Not sure if an how this could be added to setcookie() because of the already rich amount of parameters it accepts. Would it make sense to have something like setcookie_max_age() or something similar? I think we should overload the expire parameter. Somewhat ugly but transform

[PHP-DEV] Re: setcookie() and Max-Age

2004-08-17 Thread Andi Gutmans
If I understand correctly, what you're saying is that we should always use Max-Age and just do the conversion ourselves? Andi At 01:46 AM 8/18/2004 +0200, Christian Schneider wrote: Andi Gutmans wrote: Not sure if an how this could be added to setcookie() because of the already rich amount of pa

Re: [PHP-DEV] Re: setcookie() and Max-Age

2004-08-17 Thread Rasmus Lerdorf
No, I think he is saying use Max-Age if the expire is before Sep. 2001. ie. if the expire timestamp looks like a small value and not a timestamp, treat it like a max-age, otherwise if it looks big enough to be a real unix timestamp, make it a normal absolute expiry. While that is an idea that will

Re: [PHP-DEV] Re: setcookie() and Max-Age

2004-08-17 Thread Andi Gutmans
I think overloading the type is a good idea. Might even be best to use something which doesn't resemble a number for instance "Max-Age: 3600". We could just send that out in the header if it's a string (although it might leave room for typos). Any other ideas or sexier ways to do the overloading

Re: [PHP-DEV] Re: setcookie() and Max-Age

2004-08-17 Thread Rasmus Lerdorf
Perhaps it makes more sense to just give it an array there. I agree that "+3600" is not great either as I am sure someone will try to just pass +3600 without the quotes. How about this: setcookie('name',$value,array('Max-Age'=>3600, 'Comment'=>$comment, 'Path'=>'/'); So, in this overloaded fo

Re: [PHP-DEV] Re: setcookie() and Max-Age

2004-08-17 Thread Andi Gutmans
Yeah I think that would work and it'd mean we probably wouldn't have to make any further API changes in the future if new fields arise (famous last words). At 06:05 PM 8/17/2004 -0700, Rasmus Lerdorf wrote: Perhaps it makes more sense to just give it an array there. I agree that "+3600" is not

Re: [PHP-DEV] Re: setcookie() and Max-Age

2004-08-17 Thread Sterling Hughes
+1 -Sterling On Tue, 17 Aug 2004 18:05:12 -0700 (PDT), Rasmus Lerdorf <[EMAIL PROTECTED]> wrote: > Perhaps it makes more sense to just give it an array there. I agree that > "+3600" is not great either as I am sure someone will try to just pass > +3600 without the quotes. > > How about this: >