Re: [PHP-DEV] Restructuring NEWS?

2010-11-19 Thread Johannes Schlüter
On Fri, 2010-11-19 at 02:23 +0200, Jani Taskinen wrote: 19.11.2010 0:39, Johannes Schlüter kirjoitti: Hi, after the 5.3.3 release I was approached with the request to restructure the NEWS file -- for instance by grouping entries by extension -- so users can identify whether there are

Re: [PHP-DEV] Restructuring NEWS?

2010-11-19 Thread Derick Rethans
On Fri, 19 Nov 2010, Jani Taskinen wrote: It would also help if we can forget that 80 chars per line limit as well. It's 2k already and people do have bigger terminals nowadays. No please, don't change that. Even though some screens are larger, the defacto screen size when you login

Re: [PHP-DEV] Restructuring NEWS?

2010-11-19 Thread Johannes Schlüter
On Fri, 2010-11-19 at 10:30 +0100, Johannes Schlüter wrote: And get rid of those ancient Changelog* files as well. :) I proposed this in the past. See http://www.mail-archive.com/internals@lists.php.net/msg46669.html If nobody creates a process for updating these files I will drop the

Re: [PHP-DEV] Restructuring NEWS?

2010-11-19 Thread Jani Taskinen
On Nov 19, 2010, at 11:38 AM, Johannes Schlüter wrote: On Fri, 2010-11-19 at 10:30 +0100, Johannes Schlüter wrote: And get rid of those ancient Changelog* files as well. :) I proposed this in the past. See http://www.mail-archive.com/internals@lists.php.net/msg46669.html If nobody

Re: [PHP-DEV] Magic quotes in trunk

2010-11-19 Thread Ilia Alshanetsky
+1 for removing it. On Wed, Nov 17, 2010 at 11:08 AM, Kalle Sommer Nielsen ka...@php.net wrote: Greetings I wanted to raise this topic before we go Alpha with trunk, regarding our beloved magic_quotes feature. There seems to be mixed opinions regarding it so I thought I would take it up for

Re: [PHP-DEV] PHP 5.4 - Meta attribute (aka. Annotations) support discussion

2010-11-19 Thread guilhermebla...@gmail.com
Hi Richard, The first proposed patch has some performance impact, due to the parsing time. And that's just it. Instantiation of annotation classes is irrelevant because it only happens when you explicitly request for it at runtime. The only drawback is that it cannot be cached in APC. Cheers,

[PHP-DEV] Re: break/continue $var

2010-11-19 Thread Dmitry Stogov
without $var it would be possible to compile break/continue into ZEND_FREE/ZEND_SWITCH_FREE and ZEND_JMP. I also thought it would allow to remove op_array-brk_cont_array completely, but it's also used for exception handling. :( Thanks. Dmitry. Derick Rethans wrote: On Thu, 18 Nov 2010,

Re: [PHP-DEV] --enable-zend-multibyte

2010-11-19 Thread Dmitry Stogov
CG(multibyte) is defined only inside #ifdef ZEND_MULTIBYTE. Thanks. Dmitry. Patrick ALLAERT wrote: 2010/11/18 Dmitry Stogov dmi...@zend.com: Index: ext/mbstring/mbstring.c === --- ext/mbstring/mbstring.c (revision 305494) +++

Re: [PHP-DEV] --enable-zend-multibyte

2010-11-19 Thread Dmitry Stogov
Derick Rethans wrote: On Thu, 18 Nov 2010, Christopher Jones wrote: On 11/18/2010 06:26 AM, Dmitry Stogov wrote: The proposed patch allows compiling PHP with --enable-zend-multibyte and then enable or disable multibyte support at run-time using zend.multibyte=0/1 in php.ini. As result the

Re: [PHP-DEV] Adding path_len to all stream functions in trunk

2010-11-19 Thread Gustavo Lopes
On Thu, 18 Nov 2010 00:20:11 -, Pierre Joye pierre@gmail.com wrote: If there is no objection I like to apply this patch to 5.3 tomorrow morning (Europe) so we have it in for 5.3.4RC1. Please raise your concerns until then. At the very least we can always revert it after RC1. Note

Re: [PHP-DEV] Re: break/continue $var

2010-11-19 Thread Tjerk Meesters
Reading those notes I'm wondering what's meant by dynamic break is not working? I understand how it could lead to better compilation, but a mere 'not working' at the very least intrigues me :) I have actually used this construct, though its purpose is mainly in parser routines, so I guess I could

Re: [PHP-DEV] Re: break/continue $var

2010-11-19 Thread Tjerk Meesters
Reading those notes I'm wondering what's meant by dynamic break is not working? I understand how it could lead to better compilation, but a mere 'not working' at the very least intrigues me :) I have actually used this construct, though its purpose is mainly in parser routines, so I guess I could

Re: [PHP-DEV] Magic quotes in trunk

2010-11-19 Thread Daniel Convissor
Hi Johannes: On Thu, Nov 18, 2010 at 05:25:49PM +0100, Johannes Schlter wrote: 2) Error out if using CGI or web SAPI and one of the following is true: a) php.ini does not contain magic_quotes_gpc = Off b) php.ini contains magic_quotes_runtime = On c) php.ini contains

Re: [PHP-DEV] Magic quotes in trunk

2010-11-19 Thread Ferenc Kovacs
On Fri, Nov 19, 2010 at 4:17 PM, Daniel Convissor dani...@analysisandsolutions.com wrote: Hi Johannes: On Thu, Nov 18, 2010 at 05:25:49PM +0100, Johannes Schlter wrote: 2) Error out if using CGI or web SAPI and one of the following is true: a) php.ini does not contain

Re: [PHP-DEV] Magic quotes in trunk

2010-11-19 Thread Daniel Convissor
On Fri, Nov 19, 2010 at 04:41:48PM +0100, Ferenc Kovacs wrote: you can get pwn3d with magic_quotes_gpc = On That goes without saying. None the less, it will be problematic for PHP to disable/remove a security feature that some people rely on. --Dan -- T H E A N A L Y S I S A N D S O

[PHP-DEV] [PATCH] fix extract w.r.t GLOBALS again

2010-11-19 Thread Joe Orton
The check to prevent extract() overwriting $GLOBALS got broken at some point - here's a fix: Index: ext/standard/array.c === --- ext/standard/array.c(revision 305556) +++ ext/standard/array.c(working copy) @@

Re: [PHP-DEV] --enable-zend-multibyte

2010-11-19 Thread Stas Malyshev
Hi! CG(multibyte) is defined only inside #ifdef ZEND_MULTIBYTE. If we're already getting into this, how hard it would be to make multibyte build be binary-compatible with non-multibyte build? Is it possible at all? I.e., for example, taking all extra vars into a separate structure and

Re: [PHP-DEV] [PATCH] fix extract w.r.t GLOBALS again

2010-11-19 Thread Chris Stockton
On Fri, Nov 19, 2010 at 8:43 AM, Joe Orton jor...@redhat.com wrote: The check to prevent extract() overwriting $GLOBALS got broken at some point - here's a fix: I remember http://bugs.php.net/47409 for this some time ago and seeing it marked applied. After taking a peak it looks like the patch

Re: [PHP-DEV] Restructuring NEWS?

2010-11-19 Thread Felipe Pena
Hi, 2010/11/19 Johannes Schlüter johan...@schlueters.de On Fri, 2010-11-19 at 02:23 +0200, Jani Taskinen wrote: 19.11.2010 0:39, Johannes Schlüter kirjoitti: Hi, after the 5.3.3 release I was approached with the request to restructure the NEWS file -- for instance by grouping

Re: [PHP-DEV] [PATCH] fix extract w.r.t GLOBALS again

2010-11-19 Thread Felipe Pena
Hi, 2010/11/19 Joe Orton jor...@redhat.com The check to prevent extract() overwriting $GLOBALS got broken at some point - here's a fix: Index: ext/standard/array.c === --- ext/standard/array.c(revision 305556) +++

Re: [PHP-DEV] [PATCH] fix extract w.r.t GLOBALS again

2010-11-19 Thread Felipe Pena
Hi Chris, 2010/11/19 Chris Stockton chrisstockto...@gmail.com On Fri, Nov 19, 2010 at 8:43 AM, Joe Orton jor...@redhat.com wrote: The check to prevent extract() overwriting $GLOBALS got broken at some point - here's a fix: I remember http://bugs.php.net/47409 for this some time ago and

Re: [PHP-DEV] Re: break/continue $var

2010-11-19 Thread Ilia Alshanetsky
+1 to removing it. I think now that we have goto, this functionality does not make much sense. On Fri, Nov 19, 2010 at 9:06 AM, Dmitry Stogov dmi...@zend.com wrote: without $var it would be possible to compile break/continue into ZEND_FREE/ZEND_SWITCH_FREE and ZEND_JMP. I also thought it

Re: [PHP-DEV] Magic quotes in trunk

2010-11-19 Thread Stanley Sufficool
On Fri, Nov 19, 2010 at 8:14 AM, Daniel Convissor dani...@analysisandsolutions.com wrote: On Fri, Nov 19, 2010 at 04:41:48PM +0100, Ferenc Kovacs wrote: you can get pwn3d with magic_quotes_gpc = On That goes without saying.  None the less, it will be problematic for PHP to disable/remove a

Re: [PHP-DEV] Magic quotes in trunk

2010-11-19 Thread Philip Olson
On Nov 19, 2010, at 6:45 PM, Stanley Sufficool wrote: On Fri, Nov 19, 2010 at 8:14 AM, Daniel Convissor dani...@analysisandsolutions.com wrote: On Fri, Nov 19, 2010 at 04:41:48PM +0100, Ferenc Kovacs wrote: you can get pwn3d with magic_quotes_gpc = On That goes without saying. None the