[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Andrey Hristov
On 09/06/2011 10:45 AM, Stas Malyshev wrote: Hi! On 9/6/11 1:24 AM, Andrey Hristov wrote: no, it's about consistency, which you want. mysqlnd should behave like libmysql, and it is a test that can test it. What libmysql returns in filtered in mysqli, mysqli_num_rows() is a direct wrapper around

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Stas Malyshev
Hi! Have you actually checked what libmysql returns??!? If _you_ just have tried to do it, you might actually find that libmysql does what mysqlnd did long ago, but mysqli was hiding it. Here is output from what libmysql does, after removing the following check from mysqli_api.c: I checked wh

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Andrey Hristov
On 09/06/2011 11:16 AM, Stas Malyshev wrote: Hi! Have you actually checked what libmysql returns??!? If _you_ just have tried to do it, you might actually find that libmysql does what mysqlnd did long ago, but mysqli was hiding it. Here is output from what libmysql does, after removing the foll

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-06 Thread Ulf Wendel
Am 05.09.2011 11:08, schrieb Stas Malyshev: Hi! On 9/5/11 1:24 AM, Andrey Hristov wrote: the problem is that libmysql breaks, maybe more often than mysqlnd does. We rarely find bugs in mysqli, there are two codepaths in mysqli. If there is a bug in libmysql, what do you want: If we're dealing

Re: [PHP-DEV] 答复: [PHP-DEV] full LFS support

2011-09-06 Thread Ferenc Kovacs
On Tue, Aug 17, 2010 at 4:22 PM, Ferenc Kovacs wrote: >> >> > Hi. >> > >> > I would like to know what is the current status of the LFS support for >> > php. >> > >> > http://bugs.php.net/bug.php?id=27792 >> > http://bugs.php.net/bug.php?id=48886 >> > >> > As far as I can see, there are some patche

Re: [PHP-DEV] 答复: [PHP-DEV] full LFS support

2011-09-06 Thread Felipe Pena
AFAIK Pierre has some point about Windows part. 2011/9/6 Ferenc Kovacs : > On Tue, Aug 17, 2010 at 4:22 PM, Ferenc Kovacs wrote: >>> >>> > Hi. >>> > >>> > I would like to know what is the current status of the LFS support for >>> > php. >>> > >>> > http://bugs.php.net/bug.php?id=27792 >>> > http:

[PHP-DEV] Borked SKIPIFs (PHP_5_4)

2011-09-06 Thread Ulf Wendel
Hi, annoyed by run-tests.php ignoring borked SKIPIF sections, I hacked it to bail out at me if something seemed suspicious. Maintainers may want to have a look at: Fatal/Parse error @ SKIPIF = SKIPIF non functional BORK 883/9126 [Zend/tests/bug31683.phpt] BORK 4037/9248 [ext/phar/tests/f

[PHP-DEV] zlib issues in 5.4 and trunk

2011-09-06 Thread Pierre Joye
hi, It seems that 5.4 and trunk has something broken in zlib and maybe bas64 encoding/decoding. We have a serie of tests failing on linux or windows: ext\zlib\tests\bug_52944.phpt ext\zlib\tests\gzcompress_basic1.phpt ext\zlib\tests\gzcompress_variation1.phpt ext\zlib\tests\gzdeflate_basic1.phpt

Re: [PHP-DEV] Borked SKIPIFs (PHP_5_4)

2011-09-06 Thread Pierre Joye
hi Ulf, I fixed two. Feel free to fix the other as well if you have time. On Tue, Sep 6, 2011 at 4:40 PM, Ulf Wendel wrote: > Hi, > > annoyed by run-tests.php ignoring borked SKIPIF sections, I hacked it to > bail out at me if something seemed suspicious. Maintainers may want to have > a look at

Re: [PHP-DEV] Borked SKIPIFs (PHP_5_4)

2011-09-06 Thread Ulf Wendel
Hi Pierre, hi all, those three should be left: BORK 8514/9248 [ext/standard/tests/strings/sha1_file.phpt] BORK 8443/9248 [ext/standard/tests/strings/md5_file.phpt] BORK 7328/9248 [ext/standard/tests/file/php_fd_wrapper_04.phpt] They might take more than 1 second (verbally) to fix. Leaving

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Stas Malyshev
Hi! On 9/6/11 2:46 AM, Andrey Hristov wrote: I've looked into mysqli_result_is_unbuffered_and_not_everything_is_fetched() and it looks like for libmysql it checks this: (((r)->handle&& (r)->handle->status == MYSQL_STATUS_USE_RESULT) || ((r)->data == NULL)) When I step through your code, r->data

Re: [PHP-DEV] zlib issues in 5.4 and trunk

2011-09-06 Thread Stas Malyshev
Hi! On 9/6/11 8:59 AM, Pierre Joye wrote: hi, It seems that 5.4 and trunk has something broken in zlib and maybe bas64 encoding/decoding. We have a serie of tests failing on linux or windows: Interestingly enough, none of these fail for me on Darwin. Could you publish the diffs? -- Stanisl

Re: [PHP-DEV] Borked SKIPIFs (PHP_5_4)

2011-09-06 Thread Pierre Joye
On Tue, Sep 6, 2011 at 6:53 PM, Ulf Wendel wrote: > Hi Pierre, hi all, > > those three should be left: > >  BORK 8514/9248 [ext/standard/tests/strings/sha1_file.phpt] >  BORK 8443/9248 [ext/standard/tests/strings/md5_file.phpt] those are fixed already :) >  BORK 7328/9248 [ext/standard/tests/fil

Re: [PHP-DEV] zlib issues in 5.4 and trunk

2011-09-06 Thread Stas Malyshev
Hi! On 9/6/11 10:05 AM, Pierre Joye wrote: here you go (from win) It fails variously on linux or windows. Laruence reproduces the fails on linux too, some segfault from time to time. Hmm... Kind of hard to go on "from time to time" - are you sure there's no build/old library issue? Do we hav

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Andrey Hristov
Stas, On 09/06/2011 06:55 PM, Stas Malyshev wrote: Hi! On 9/6/11 2:46 AM, Andrey Hristov wrote: I've looked into mysqli_result_is_unbuffered_and_not_everything_is_fetched() and it looks like for libmysql it checks this: (((r)->handle&& (r)->handle->status == MYSQL_STATUS_USE_RESULT) || ((r)->da

Re: [PHP-DEV] zlib issues in 5.4 and trunk

2011-09-06 Thread Pierre Joye
On Tue, Sep 6, 2011 at 8:03 PM, Stas Malyshev wrote: > Hmm... Kind of hard to go on "from time to time" - are you sure there's no > build/old library issue? Do we have a reproduction for the segfaults? The > diffs look like your gzip is producing different data - I wonder if some > version might

Re: [PHP-DEV] zlib issues in 5.4 and trunk

2011-09-06 Thread Stas Malyshev
Hi! On 9/6/11 11:35 AM, Pierre Joye wrote: Yes, we use the same libs for 5.3 and 5.4 and same tests pass in 5.3. Bu it is also reproducible on many unrelated hosts. Well, maybe somebody that could reproduce it could look into it? Because I'm unable to reproduce any of it... -- Stanislav Maly

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Stas Malyshev
Hi! On 9/6/11 11:05 AM, Andrey Hristov wrote: I've looked into mysqli_result_is_unbuffered_and_not_everything_is_fetched() and it looks like for libmysql it checks this: (((r)->handle&& (r)->handle->status == MYSQL_STATUS_USE_RESULT) || ((r)->data == NULL)) When I step through your code, r->dat

Re: [PHP-DEV] zlib issues in 5.4 and trunk

2011-09-06 Thread Pierre Joye
On Tue, Sep 6, 2011 at 9:03 PM, Stas Malyshev wrote: > Hi! > > On 9/6/11 11:35 AM, Pierre Joye wrote: >> >> Yes, we use the same libs for 5.3 and 5.4 and same tests pass in 5.3. >> Bu it is also reproducible on many unrelated hosts. > > Well, maybe somebody that could reproduce it could look into

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-06 Thread Stas Malyshev
Hi! Any new PHP major release is about setting new directions. I, Andrey and Johannes, the guys maintaining ext/*mysql* recommend going mysqlnd after an "incubation" of some four years (5.3x series + dev time). My concern was also that making mysqlnd the default would make libmysql support co

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Andrey Hristov
On 09/06/2011 09:08 PM, Stas Malyshev wrote: Hi! On 9/6/11 11:05 AM, Andrey Hristov wrote: I've looked into mysqli_result_is_unbuffered_and_not_everything_is_fetched() and it looks like for libmysql it checks this: (((r)->handle&& (r)->handle->status == MYSQL_STATUS_USE_RESULT) || ((r)->data ==

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Andrey Hristov
On 09/06/2011 09:54 PM, Andrey Hristov wrote: On 09/06/2011 09:08 PM, Stas Malyshev wrote: Hi! On 9/6/11 11:05 AM, Andrey Hristov wrote: I've looked into mysqli_result_is_unbuffered_and_not_everything_is_fetched() and it looks like for libmysql it checks this: (((r)->handle&& (r)->handle->stat

Re: [SPAM?]: Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-06 Thread Ulf Wendel
Am 06.09.2011 21:33, schrieb Stas Malyshev: Hi! Any new PHP major release is about setting new directions. I, Andrey and Johannes, the guys maintaining ext/*mysql* recommend going mysqlnd after an "incubation" of some four years (5.3x series + dev time). My concern was also that making mysqln

Re: [PHP-DEV] zlib issues in 5.4 and trunk

2011-09-06 Thread Hannes Magnusson
On Tue, Sep 6, 2011 at 21:09, Pierre Joye wrote: > On Tue, Sep 6, 2011 at 9:03 PM, Stas Malyshev wrote: >> Hi! >> >> On 9/6/11 11:35 AM, Pierre Joye wrote: >>> >>> Yes, we use the same libs for 5.3 and 5.4 and same tests pass in 5.3. >>> Bu it is also reproducible on many unrelated hosts. >> >> W

Re: [PHP-DEV] zlib issues in 5.4 and trunk

2011-09-06 Thread Ferenc Kovacs
On Wed, Sep 7, 2011 at 1:26 AM, Hannes Magnusson wrote: > On Tue, Sep 6, 2011 at 21:09, Pierre Joye wrote: >> On Tue, Sep 6, 2011 at 9:03 PM, Stas Malyshev wrote: >>> Hi! >>> >>> On 9/6/11 11:35 AM, Pierre Joye wrote: Yes, we use the same libs for 5.3 and 5.4 and same tests pass in 5.3

Re: [PHP-DEV] [VOTE] Weak References

2011-09-06 Thread Etienne Kneuss
Hi, On Sat, Sep 3, 2011 at 19:21, Nicolas Grekas wrote: > > > > $pseudoWeakMap = array(); > > $pseudoWeakMap[spl_object_**hash($obj)] = new WeakReference($obj); > > > > or did I misunderstand the concept? I hope I'll have a chance to use > > WeakReferences soon in my project;) > > > > I also beli

Re: [PHP-DEV] zlib issues in 5.4 and trunk

2011-09-06 Thread Laruence
Hi: ext/zlib/tests/gzencode_variation1.phpt failed in Linux(redhat 64-bit) test log http://pastebin.com/TzpW8GTK thanks 2011/9/6 Pierre Joye : > hi, > > It seems that 5.4 and trunk has something broken in zlib and maybe > bas64 encoding/decoding. > > We have a serie of tests failing on linu

[PHP-DEV] Compiling warnings should be fixed

2011-09-06 Thread Laruence
Hi: there is a lot of compiling warnings in truk(branch also), I have fixed most of them unless those in Zend/* here is the warning log: http://pastebin.com/ah3qtP6A (compile with I think it is better to fix them all, since we should release a perfect project(although most of them are

[PHP-DEV] CI for 5.4

2011-09-06 Thread Stas Malyshev
Hi! Since we started to pay real attention to our unit tests now, I wonder if we could set up some kind of frequently-running CI system that could be used to screen commits and identify breakage early? That'd help with 5.4 process I think. We have http://gcov.php.net/ but it doesn't run with t

Re: [PHP-DEV] CI for 5.4

2011-09-06 Thread Laruence
+1 thanks 2011/9/7 Stas Malyshev : > Hi! > > Since we started to pay real attention to our unit tests now, I wonder if we > could set up some kind of frequently-running CI system that could be used to > screen commits and identify breakage early? That'd help with 5.4 process I > think. > We have

Re: [PHP-DEV] CI for 5.4

2011-09-06 Thread Ferenc Kovacs
On Wed, Sep 7, 2011 at 3:29 AM, Stas Malyshev wrote: > Hi! > > Since we started to pay real attention to our unit tests now, I wonder if we > could set up some kind of frequently-running CI system that could be used to > screen commits and identify breakage early? That'd help with 5.4 process I >

Re: [SPAM?]: Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-06 Thread Tomas Kuliavas
2011.09.06 23:20 Ulf Wendel rašė: > Am 06.09.2011 21:33, schrieb Stas Malyshev: >> Hi! >> >>> Any new PHP major release is about setting new directions. I, Andrey >>> and >>> Johannes, the guys maintaining ext/*mysql* recommend going mysqlnd >>> after >>> an "incubation" of some four years (5.3x se

Re: [PHP-DEV] CI for 5.4

2011-09-06 Thread Pierre Joye
hi Stas, A new box is being setup with numerous VMs (Dan is on it). Each of of them will cover one supported platform (debian, rh, bsd, win) and will run the builds and tests using rmtools in controlled environment, like what I began to do with windows a while back already. Build and tests log wil

[PHP-DEV] Re: Compiling warnings should be fixed

2011-09-06 Thread Pierre Joye
Hi Laruence, I fully agree, the amount of warnings is way too big and only seeing the delta between two builds is useful right now. Btw, if you have patches for Zend, please send them over so we can review and test them :) Cheers, On Wed, Sep 7, 2011 at 3:15 AM, Laruence wrote: > Hi: >    ther

Re: [SPAM?]: Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-06 Thread Andrey Hristov
Hi, On 09/07/2011 07:17 AM, Tomas Kuliavas wrote: 2011.09.06 23:20 Ulf Wendel rašė: Am 06.09.2011 21:33, schrieb Stas Malyshev: Hi! Any new PHP major release is about setting new directions. I, Andrey and Johannes, the guys maintaining ext/*mysql* recommend going mysqlnd after an "incubati

Re: [PHP-DEV] 5.4 beta

2011-09-06 Thread Stas Malyshev
Hi! On 8/28/11 10:55 PM, Gustavo Lopes wrote: I should ask someone with Zend karma to commit the closure rebinding patch. Context: https://wiki.php.net/rfc/closures/object-extension#privateprotected_members_scope Vote: https://wiki.php.net/todo/php54/vote Done. -- Stanislav Malyshev, Softwa