Re: [PHP-DEV] ZE2 broken by newer gcc

2011-09-12 Thread Dmitry Stogov
Hi Flavius, Unfortunately, the proposed fix is wrong. It changes the operators precedence and it's definitely wrong. I suppose the crash caused by side effect of some other bug. Try to run the same script with valgrind. Thanks. Dmitry. On 09/11/2011 02:27 PM, Flavius Aspra wrote: Hi I

Re: [PHP-DEV] [PATCH]#55651

2011-09-12 Thread Pierre Joye
hi! On Mon, Sep 12, 2011 at 2:29 AM, Avi Brender abren...@elitehosts.com wrote: Hi, Please see if the attached patch better addresses your concerns. Regarding the variable name, the PHP_FTP_OPT_USEPASVADDRESS is only internal and is modeled after the other variables PHP_FTP_TIMEOUT_SEC and

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-12 Thread Alexey Shein
Hello, these tests fail for me too, ubuntu 11.04 x86, both trunk and 5.4 branches. 2011/9/12 Ferenc Kovacs tyr...@gmail.com: On Sun, Sep 11, 2011 at 11:04 PM, Stas Malyshev smalys...@sugarcrm.com wrote: Hi! On 9/11/11 8:44 AM, Ferenc Kovacs wrote: AFAIK you shoud get it(as I did on my

Re: [PHP-DEV] [RFC] Factory for Stream Wrappers

2011-09-12 Thread Sebastian Bergmann
Am 12.09.2011 00:26, schrieb Gustavo Lopes: A patch against trunk (or 5.4) would have been nicer. Other than that: * This patch has a huge BC: Johannes already said that he is updating his patch. It is not our intention to break BC, we only want to add additional/optional behaviour. Could

Re: [PHP-DEV] APC in 5.4

2011-09-12 Thread Ilia Alshanetsky
The agreement to include apc in 5.4 is an old one, unfortunately the action of doing was just missed. Also, inclusion of the extension won't break any code since it is self contained... On Thu, Sep 8, 2011 at 9:07 PM, Stas Malyshev smalys...@sugarcrm.com wrote: Hi! On 9/8/11 6:04 PM, Kalle

Re: [PHP-DEV] ZE2 broken by newer gcc

2011-09-12 Thread Flavius Aspra
On 09/12/2011 08:45 AM, Dmitry Stogov wrote: Hi Flavius, Unfortunately, the proposed fix is wrong. It changes the operators precedence and it's definitely wrong. I suppose the crash caused by side effect of some other bug. Try to run the same script with valgrind. Thanks. Dmitry. Please

Re: [PHP-DEV] [RFC] Factory for Stream Wrappers

2011-09-12 Thread Gustavo Lopes
Em Mon, 12 Sep 2011 12:53:13 +0100, Sebastian Bergmann sebast...@php.net escreveu: Regarding state it is important to notice that PHP does *not* execute the constructor on all low level calls when instantiating the wrapper class - for whatever reason that is the case. Changing that

Re: [PHP-DEV] [RFC] Factory for Stream Wrappers

2011-09-12 Thread Christian Kaps
On Mon, 12 Sep 2011 14:43:33 +0100, Gustavo Lopes wrote: Em Mon, 12 Sep 2011 12:53:13 +0100, Sebastian Bergmann sebast...@php.net escreveu: Regarding state it is important to notice that PHP does *not* execute the constructor on all low level calls when instantiating the wrapper class -

Re: [PHP-DEV] [RFC] Factory for Stream Wrappers

2011-09-12 Thread Gustavo Lopes
Em Mon, 12 Sep 2011 15:40:20 +0100, Christian Kaps christian.k...@mohiva.com escreveu: On Mon, 12 Sep 2011 14:43:33 +0100, Gustavo Lopes wrote: Em Mon, 12 Sep 2011 12:53:13 +0100, Sebastian Bergmann sebast...@php.net escreveu: Regarding state it is important to notice that PHP does *not*

Re: [PHP-DEV] [RFC] Factory for Stream Wrappers

2011-09-12 Thread Hannes Magnusson
On Mon, Sep 12, 2011 at 16:56, Gustavo Lopes glo...@nebm.ist.utl.pt wrote: Em Mon, 12 Sep 2011 15:40:20 +0100, Christian Kaps christian.k...@mohiva.com escreveu: On Mon, 12 Sep 2011 14:43:33 +0100, Gustavo Lopes wrote: Em Mon, 12 Sep 2011 12:53:13 +0100, Sebastian Bergmann sebast...@php.net

Re: [PHP-DEV] APC in 5.4

2011-09-12 Thread Stas Malyshev
Hi! On 9/12/11 5:09 AM, Ilia Alshanetsky wrote: The agreement to include apc in 5.4 is an old one, unfortunately the action of doing was just missed. Also, inclusion of the extension won't break any code since it is self contained... If it's an old one, how comes nobody ever mentioned it

Re: [PHP-DEV] APC in 5.4

2011-09-12 Thread Pierre Joye
On Mon, Sep 12, 2011 at 7:42 PM, Stas Malyshev smalys...@sugarcrm.com wrote: Hi! On 9/12/11 5:09 AM, Ilia Alshanetsky wrote: The agreement to include apc in 5.4 is an old one, unfortunately the action of doing was just missed. Also, inclusion of the extension won't break any code since it

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-12 Thread Ferenc Kovacs
I forget to reply-all to the list :/ On Mon, Sep 12, 2011 at 7:46 PM, Stas Malyshev smalys...@sugarcrm.com wrote: Hi! On 9/12/11 3:14 AM, Ferenc Kovacs wrote: you should pass both -n and -c as the make test pass those to the run-tests.php AFAIK, see: That's not what I see happening. as

Re: [PHP-DEV] [RFC] Factory for Stream Wrappers

2011-09-12 Thread Gustavo Lopes
On Mon, 12 Sep 2011 18:00:13 +0100, Hannes Magnusson hannes.magnus...@gmail.com wrote: On Mon, Sep 12, 2011 at 16:56, Gustavo Lopes glo...@nebm.ist.utl.pt wrote: Ah, right. stat() and unlink() should have been static in the first place. Given the circumstances, it might be a good idea, to

Re: [PHP-DEV] [RFC] Factory for Stream Wrappers

2011-09-12 Thread Stas Malyshev
Hi! On 9/12/11 3:45 PM, Gustavo Lopes wrote: It's a change in behavior so it makes sense. Those operations are wrapper operations and by their nature they are static operations, meaning a stream instance is not required. See the difference between php_stream_ops and php_stream_wrapper_ops. It

Re: [PHP-DEV] [RFC] Factory for Stream Wrappers

2011-09-12 Thread Pierre Joye
hi! I like the idea to improve this area. However I'm with Stas here. I do not feel comfortable enough with this RFC to agree to get into 5.4 at this stage. It is a sensible area and we are already late (because of the tests) with the 5.4 release plan. Next will begin in spring next year, not