Re: [PHP-DEV] Preventing users from voting multiple times on a single bug

2014-12-31 Thread Jacob Bednarz
This should probably go to php-webmaster@ Thanks! Next time I will be sure to fire it that way instead of here. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Merge HashTable and zend_array into a single data structure.

2014-12-31 Thread Pierre Joye
On Jan 1, 2015 2:00 AM, "Andrea Faulds" wrote: > > Hey François, > > > On 31 Dec 2014, at 17:50, François Laupretre wrote: > > > > "Showing 46 changed files with 193 additions and 204 deletions". I am sorry but I can't analyze the impacts of your change, just from the patch. Did you write an RFC

[PHP-DEV] Re: [Pre-Vote] Return Types

2014-12-31 Thread Levi Morrison
On Wed, Dec 31, 2014 at 4:26 PM, Levi Morrison wrote: > Dear Internals, > > I have changed the variance of return types to be invariant. I have > given a further example of what invariance does and does not mean in > the RFC, as there has been some confusion about it in previous > discussions. > >

[PHP-DEV] [Pre-Vote] Return Types

2014-12-31 Thread Levi Morrison
Dear Internals, I have changed the variance of return types to be invariant. I have given a further example of what invariance does and does not mean in the RFC, as there has been some confusion about it in previous discussions. Are there any other questions or major concerns before I put this to

[PHP-DEV] resource consistency

2014-12-31 Thread Anatol Belski
Hi, related to bug #43525, I see that zend_fetch_resource() still expects a default id as int as parameter. After some investigation i think that the "int default_id" argument can be surely dropped from the signature. The only extension in the core passing it is ext/interbase, all the others pass

Re: [PHP-DEV] [RFC] Scalar Type Hints

2014-12-31 Thread Andrea Faulds
Hey Stas, > On 31 Dec 2014, at 21:12, Stanislav Malyshev wrote: > > I like it, it's consistent and to the point. If we must have scalar > typed parameters (I'm not sure but if we do), IMO that's the way to do it. Glad you like it. > The issue is the class names though. E.g. see: > https://gith

Re: [PHP-DEV] [RFC] Scalar Type Hints

2014-12-31 Thread Stanislav Malyshev
Hi! I like it, it's consistent and to the point. If we must have scalar typed parameters (I'm not sure but if we do), IMO that's the way to do it. The issue is the class names though. E.g. see: https://github.com/ralphschindler/zf2-db/blob/master/research/ColumnType/Integer.php and: https://git

Re: [PHP-DEV] [RFC] Scalar Type Hints

2014-12-31 Thread Andrea Faulds
Hey Adam, > On 31 Dec 2014, at 20:51, Adam Harvey wrote: > > At a first read through, this looks great, and much more in line with > what I'd like scalar type hints to look like. Nice job! Glad to hear that! > In terms of the open issues, here's what I think: > > 1. Aliases: I think we should

Re: [PHP-DEV] [RFC] Scalar Type Hints

2014-12-31 Thread Adam Harvey
On 31 December 2014 at 12:27, Andrea Faulds wrote: > Parameter type hints for PHP’s scalar types are a long-requested feature for > PHP. Today I am proposing an RFC which is a new attempt to add them to the > language. It is my hope that we can finally get this done for PHP 7. > > I’d like to th

[PHP-DEV] [RFC] Scalar Type Hints

2014-12-31 Thread Andrea Faulds
Good evening, Parameter type hints for PHP’s scalar types are a long-requested feature for PHP. Today I am proposing an RFC which is a new attempt to add them to the language. It is my hope that we can finally get this done for PHP 7. I’d like to thank Dmitry, who emailed me and gave me some fe

Re: [PHP-DEV] Merge HashTable and zend_array into a single data structure.

2014-12-31 Thread Anatol Belski
Hi Dmitry, On Wed, December 31, 2014 11:19, Dmitry Stogov wrote: > Hi, > > > Please take a look into the patch > > > https://github.com/php/php-src/pull/970/files > > > This real changes are in zend_types.h, the rest is renaming that in most > cases makes code cleaner. > > zend_array didn't change

Re: [PHP-DEV] Merge HashTable and zend_array into a single data structure.

2014-12-31 Thread Andrea Faulds
Hey François, > On 31 Dec 2014, at 17:50, François Laupretre wrote: > > "Showing 46 changed files with 193 additions and 204 deletions". I am sorry > but I can't analyze the impacts of your change, just from the patch. Did you > write an RFC that would explain the impact, especially for extens

RE: [PHP-DEV] Merge HashTable and zend_array into a single data structure.

2014-12-31 Thread François Laupretre
> De : Dmitry Stogov [mailto:dmi...@zend.com] > Please take a look into the patch > > https://github.com/php/php-src/pull/970/files > > This real changes are in zend_types.h, the rest is renaming that in most > cases makes code cleaner. > > zend_array didn't change its binary representation, bu

Re: [PHP-DEV] Preventing users from voting multiple times on a single bug

2014-12-31 Thread Chris Wright
On 31 December 2014 at 11:12, Jacob Bednarz wrote: 1. Is this the correct list for changes related to bugs.php.net itself? If >not, what is the correct mailing list for this change? > This should probably go to php-webmaster@

[PHP-DEV] Preventing users from voting multiple times on a single bug

2014-12-31 Thread Jacob Bednarz
Hi, This is my attempt at a patch for a bug related to users being able to vote multiple times on the same bug (full report is at https://bugs.php.net/bug.php?id=51535). While this isn't a huge change I wanted to get confirmation on a few things before I went ahead so that I didn't break anyth

[PHP-DEV] Merge HashTable and zend_array into a single data structure.

2014-12-31 Thread Dmitry Stogov
Hi, Please take a look into the patch https://github.com/php/php-src/pull/970/files This real changes are in zend_types.h, the rest is renaming that in most cases makes code cleaner. zend_array didn't change its binary representation, but now it's not possible to get a pointer to embedded HashT