Re: [PHP-DEV] Fix division by zero to throw exception (round 2)

I, personally, don't have strong opinion. Both behaviors work for me. Bob, if you are going to change this, please show the patch first. Thanks. Dmitry. On Mon, Jun 29, 2015 at 8:14 PM, Andrea Faulds wrote: > Hi again, > > > On 29 Jun 2015, at 18:02, Bob Weinand wrote: > > > > Yes, it generall

Re: [PHP-DEV] VCS Account Request: trowski

+1, yes, please give him access, recently merged some of his commits directly from a him github fork; for most of his small fixes there wasn't anything to complain. Bob > Am 30.06.2015 um 08:08 schrieb Joe Watkins : > > +1, chap already wrote some stuff we're using ... > > On Tue, Jun 30, 201

Re: [PHP-DEV] VCS Account Request: trowski

+1, chap already wrote some stuff we're using ... On Tue, Jun 30, 2015 at 7:01 AM, Sherif Ramadan wrote: > +1 from google...@php.net > > On Tue, Jun 30, 2015 at 1:42 AM, Aaron Piotrowski wrote: > > > Quickly applying bug fixes. > > > > > > -- > > PHP Internals - PHP Runtime Development Mailing

Re: [PHP-DEV] VCS Account Request: trowski

+1 from google...@php.net On Tue, Jun 30, 2015 at 1:42 AM, Aaron Piotrowski wrote: > Quickly applying bug fixes. > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >

[PHP-DEV] VCS Account Request: trowski

Quickly applying bug fixes. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Headsup: PHP7 feature freeze

On Mon, Jun 29, 2015 at 11:31 PM, Levi Morrison wrote: > On Mon, Jun 29, 2015 at 3:47 PM, Jakub Kubíček wrote: >> 2015-06-28 22:19 GMT+02:00 Anatol Belski : >>> What is the benefit changing it? XHTML is a standard which is alive. >> >> That's on every person's opinion. XHTML is currently not a st

Re: [PHP-DEV] Headsup: PHP7 feature freeze

On Mon, Jun 29, 2015 at 3:47 PM, Jakub Kubíček wrote: > 2015-06-28 22:19 GMT+02:00 Anatol Belski : >> What is the benefit changing it? XHTML is a standard which is alive. > > That's on every person's opinion. XHTML is currently not a standard, > XHTML is dead. > >> But, there's for sure some code

Re: [PHP-DEV] Improved zend_string API

> Am 30.06.2015 um 05:44 schrieb François Laupretre : > >> De : Bob Weinand [mailto:bobw...@hotmail.com] >> >> I see you changed the ZSTR_* macros to be pure aliases of the equivalent >> structure members. >> >> May I now honestly ask where the benefit of those macros is? >> >> ZSTR_VAL(str) in

Re: [PHP-DEV] Improved zend_string API

> Am 30.06.2015 um 04:37 schrieb François Laupretre : > > Hi, > >> -Message d'origine- >> De : Bob Weinand [mailto:bobw...@hotmail.com] >> >> Hey, looks like I'm a bit late to the party, but I'd like to object against >> the >> accessor macros on zend_string. >> >> What does it help t

RE: [PHP-DEV] Improved zend_string API

> De : Bob Weinand [mailto:bobw...@hotmail.com] > > I see you changed the ZSTR_* macros to be pure aliases of the equivalent > structure members. > > May I now honestly ask where the benefit of those macros is? > > ZSTR_VAL(str) instead of str->val > ZSTR_H(str) instead of str->h > ZSTR_LEN(str)

RE: [PHP-DEV] Improved zend_string API

> De : Aaron Piotrowski [mailto:aa...@icicle.io] > Envoyé : mardi 30 juin 2015 04:16 > À : Bob Weinand; Anatol Belski > Cc : internals@lists.php.net > Objet : Re: [PHP-DEV] Improved zend_string API > > > > On Jun 29, 2015, at 7:37 PM, Bob Weinand wrote: > > > > Hey Anatol, > > > >> Am 29.06.2015

RE: [PHP-DEV] Improved zend_string API

On Jun 30, 2015 9:38 AM, "François Laupretre" wrote: > > Hi, > > > -Message d'origine- > > De : Bob Weinand [mailto:bobw...@hotmail.com] > > > > Hey, looks like I'm a bit late to the party, but I'd like to object against the > > accessor macros on zend_string. > > > > What does it help to

RE: [PHP-DEV] RE: Improved zend_string API

Hi, > De : François Laupretre [mailto:franc...@php.net] > Envoyé : mardi 30 juin 2015 03:08 > À : 'Dmitry Stogov' > Cc : 'Anatol Belski'; 'PHP Internals' > Objet : [PHP-DEV] RE: Improved zend_string API > > Hi Dmitry, > > I just commited some additional changes, following your suggestions : > >

Re: [PHP-DEV] Improved zend_string API

Hey Dmitry, > Am 29.06.2015 um 15:46 schrieb Dmitry Stogov : > > Committed except of ZVAL_STR_INC/DEC_LEN() and some other unused macros. > > Thanks. Dmitry. I see you changed the ZSTR_* macros to be pure aliases of the equivalent structure members. May I now honestly ask where the benefit of

RE: [PHP-DEV] Improved zend_string API

Hi, > -Message d'origine- > De : Bob Weinand [mailto:bobw...@hotmail.com] > > Hey, looks like I'm a bit late to the party, but I'd like to object against > the > accessor macros on zend_string. > > What does it help to replace very nice ->val, ->len etc. with macros? If you find it 'ver

Re: [PHP-DEV] Improved zend_string API

> On Jun 29, 2015, at 7:37 PM, Bob Weinand wrote: > > Hey Anatol, > >> Am 29.06.2015 um 22:41 schrieb Anatol Belski : >> >> Hi Bob, >> >>> -Original Message- >>> From: Bob Weinand [mailto:bobw...@hotmail.com] >>> Sent: Monday, June 29, 2015 6:44 PM >>> To: Dmitry Stogov >>> Cc: franco

[PHP-DEV] RE: Improved zend_string API

Hi Dmitry, I just commited some additional changes, following your suggestions : - Renamed every ‘zend_string_xxx()’ functions to ‘ZSTR_’-prefixed uppercase names, - Defined compatibility macros for old names - Changed the rest of the code to use new ZSTR_ names - A special case for zend_string_

Re: [PHP-DEV] Improved zend_string API

Hey Anatol, > Am 29.06.2015 um 22:41 schrieb Anatol Belski : > > Hi Bob, > >> -Original Message- >> From: Bob Weinand [mailto:bobw...@hotmail.com] >> Sent: Monday, June 29, 2015 6:44 PM >> To: Dmitry Stogov >> Cc: francois; Anatol Belski; Anatol Belski; PHP Internals >> Subject: Re: [PHP

Re: [PHP-DEV] Headsup: PHP7 feature freeze

2015-06-28 22:19 GMT+02:00 Anatol Belski : > What is the benefit changing it? XHTML is a standard which is alive. That's on every person's opinion. XHTML is currently not a standard, XHTML is dead. > But, there's for sure some code based on parsing the phpinfo() output, since > not everything is

Re: [PHP-DEV] Headsup: PHP7 feature freeze

Hi Anatol, On Mon, Jun 29, 2015 at 10:19 PM, Anatol Belski wrote: > > -Original Message- > > From: yohg...@gmail.com [mailto:yohg...@gmail.com] On Behalf Of Yasuo > > Ohgaki > > Sent: Friday, June 26, 2015 1:58 PM > > To: Hannes Magnusson > > Cc: Kalle Sommer Nielsen; Internals; Anatoliy

RE: [PHP-DEV] Improved zend_string API

Hi Bob, > -Original Message- > From: Bob Weinand [mailto:bobw...@hotmail.com] > Sent: Monday, June 29, 2015 6:44 PM > To: Dmitry Stogov > Cc: francois; Anatol Belski; Anatol Belski; PHP Internals > Subject: Re: [PHP-DEV] Improved zend_string API > > Hey, looks like I'm a bit late to the p

Re: [PHP-DEV] Fix division by zero to throw exception (round 2)

Hi again, > On 29 Jun 2015, at 18:02, Bob Weinand wrote: > > Yes, it generally makes sense... > Then I have other questions: > > - Why do we then still have a Warning? Either we have well-defined behavior, > or we throw an exception. Well-defined behavior *plus* a warning is IMO > non-sense.

Re: [PHP-DEV] Fix division by zero to throw exception (round 2)

Hey Andrea, > Am 29.06.2015 um 18:49 schrieb Andrea Faulds : > > Hi Bob, > >> On 29 Jun 2015, at 16:54, Bob Weinand wrote: >> >> I would like to bring this topic back up, as there were users confused with >> it and it's absolutely not consistent what we have now. >> See also https://bugs.php.

Re: [PHP-DEV] Fix division by zero to throw exception (round 2)

Hi Bob, > On 29 Jun 2015, at 16:54, Bob Weinand wrote: > > I would like to bring this topic back up, as there were users confused with > it and it's absolutely not consistent what we have now. > See also https://bugs.php.net/bug.php?id=69957 (As I thought it was > non-intentional, I went ahead

Re: [PHP-DEV] Improved zend_string API

> Am 29.06.2015 um 15:46 schrieb Dmitry Stogov : > > Committed except of ZVAL_STR_INC/DEC_LEN() and some other unused macros. > > Thanks. Dmitry. > > On Mon, Jun 29, 2015 at 4:23 PM, François Laupretre > wrote: > >> Hi, >> >> >> >> OK, I didn’t understand Dmitry’s comment on ‘aggressively’

Re: [PHP-DEV] Fix division by zero to throw exception (round 2)

On Mon, Jun 29, 2015 at 5:54 PM, Bob Weinand wrote: > I would like to bring this topic back up, as there were users confused > with it and it's absolutely not consistent what we have now. > See also https://bugs.php.net/bug.php?id=69957 (As I thought it was > non-intentional, I went ahead and "fi

Re: [PHP-DEV] Fix division by zero to throw exception (round 2)

I would like to bring this topic back up, as there were users confused with it and it's absolutely not consistent what we have now. See also https://bugs.php.net/bug.php?id=69957 (As I thought it was non-intentional, I went ahead and "fixed" it, was revert

[PHP-DEV] Re: Improved zend_string API

Committed except of ZVAL_STR_INC/DEC_LEN() and some other unused macros. Thanks. Dmitry. On Mon, Jun 29, 2015 at 4:23 PM, François Laupretre wrote: > Hi, > > > > OK, I didn’t understand Dmitry’s comment on ‘aggressively’ using inline > functions but, thanks to your comment, I understand now. It

[PHP-DEV] RE: Improved zend_string API

Hi, OK, I didn’t understand Dmitry’s comment on ‘aggressively’ using inline functions but, thanks to your comment, I understand now. It has nothing to do with performance. Using a function for ->val is useless, I agree, as it is read-only be nature. But using 2 functions for len provides re

RE: [PHP-DEV] Headsup: PHP7 feature freeze

Hi Yasuo, > -Original Message- > From: yohg...@gmail.com [mailto:yohg...@gmail.com] On Behalf Of Yasuo > Ohgaki > Sent: Friday, June 26, 2015 1:58 PM > To: Hannes Magnusson > Cc: Kalle Sommer Nielsen; Internals; Anatoliy Belsky; Dmitry Stogov; Nikita > Popov; Ferenc Kovacs; Xinchen Hui > S

Re: [PHP-DEV] Bundled GD library

Pierre Joye wrote: > Hi, > > On Jun 29, 2015 3:34 AM, "Christoph Becker" wrote: >> >> Hi! >> >> I've just learned from ext/gd/libgd/README that the bundled GD library >> is actually a fork of libgd, which was quite a surprise to me as I >> thought gd is handled similar to pcre and sqlite3. > >

[PHP-DEV] RE: [PHP-CVS] com php-src: Fix bug #69957 (Different ways of handling div/mod by zero): NEWS Zend/tests/bug69957.phpt Zend/zend_compile.c Zend/zend_operators.c Zend/zend_vm_def.h Zend/zend_v

Hi Bob, This commit and 79b1832dd5086cd9b4a2e778a62f1743b548726c was reverted, please check also the comments in the ticket. Bob, please do more discussion of such cases with Dmitry and Hui before. Especially the patches that affect very basic functionality should not be urged to be pushed rig

RE: [PHP-DEV] Allow exceptions in __toString()

Hi Nikita, > -Original Message- > From: Nikita Popov [mailto:nikita@gmail.com] > Sent: Thursday, June 25, 2015 2:53 PM > To: PHP internals; Dmitry Stogov > Subject: [PHP-DEV] Allow exceptions in __toString() > > Hi internals! > > Currently it's not possible to throw an exception from