Re: [PHP-DEV] Re: [RFC] Extended String Types For PDO

2017-03-09 Thread Marco Pivetta
Hey Adam, On Thu, Mar 9, 2017 at 11:07 AM, Adam Baratz wrote: > However, I see no reference about the expected input/output encoding >> (Unicode data is a bit vague). Is it expected to be UFT-8? Or maybe >> match the internal encoding of the driver (e.g. UTF-16?)? What happens >> if I try to quo

[PHP-DEV] UGLY Benchmark Results for PHP Master 2017-03-09

2017-03-09 Thread lp_benchmark_robot
Results for project PHP master, build date 2017-03-09 00:04:30-08:00 commit: f68968f previous commit:2ba2b76 revision date: 2017-03-09 00:10:31+01:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] [Discussion] is_string(), string type and objects implementing __toString()

2017-03-09 Thread Rowan Collins
On 08/03/2017 23:32, Andrey Andreev wrote: For example, a Cookie object may have the cookie attributes (domain, path, etc.) as value objects, but they can easily be created from raw strings, while other types would be ambiguous. A similar effect could be desirable for HTTP headers. OK, now we h

Re: [PHP-DEV] [Discussion] is_string(), string type and objects implementing __toString()

2017-03-09 Thread Fleshgrinder
On 3/9/2017 8:51 PM, Rowan Collins wrote: > On 09/03/2017 17:37, Fleshgrinder wrote: >> On 3/9/2017 3:18 AM, Stanislav Malyshev wrote: >> >>> I don't think it's right approach. is_* functions check the current type >>> of the value, not whether it can be converted to another type. If we >>> need on

Re: [PHP-DEV] [Discussion] is_string(), string type and objects implementing __toString()

2017-03-09 Thread Rowan Collins
On 09/03/2017 17:37, Fleshgrinder wrote: On 3/9/2017 3:18 AM, Stanislav Malyshev wrote: I don't think it's right approach. is_* functions check the current type of the value, not whether it can be converted to another type. If we need ones that express the latter, we should have different funct

Re: [PHP-DEV] Proposing a new 'cache_key' streams operation

2017-03-09 Thread Adam Baratz
> > This PR creates a mechanism to be used by opcode caches to determine > whether a stream-wrapped URI is cacheable, and the key to use when > caching it. > Thanks for sharing this. Very interesting idea. Have you posted an RFC yet? That'll help lay out the bigger questions and guide the conversa

Re: [PHP-DEV] [Discussion] is_string(), string type and objects implementing __toString()

2017-03-09 Thread Fleshgrinder
On 3/9/2017 12:47 PM, Andrey Andreev wrote: > Hi, Hey :) On 3/9/2017 12:47 PM, Andrey Andreev wrote: > On Thu, Mar 9, 2017 at 1:49 AM, Fleshgrinder wrote: >> Stringable seems very explicit and strict to me, since it is opt-in. >> Currently there is no way to have the ergonomics of coercion if st

Re: [PHP-DEV] [Discussion] is_string(), string type and objects implementing __toString()

2017-03-09 Thread Fleshgrinder
On 3/9/2017 3:18 AM, Stanislav Malyshev wrote: > Hi! > >> I submitted a GitHub PR* to allow objects implementing __toString() to >> *optionally* pass is_string() validation. More verbose wording of my >> motivation can be seen in the PR description, but here are the main >> points: > > I don't th

[PHP-DEV] Proposing a new 'cache_key' streams operation

2017-03-09 Thread François Laupretre
Hi, PR is : https://github.com/php/php-src/pull/1711 This PR creates a mechanism to be used by opcode caches to determine whether a stream-wrapped URI is cacheable, and the key to use when caching it. The first usage for this operation is to opcode-cache the PHP code managed by PCS, which i

Re: [PHP-DEV] Re: [RFC] Extended String Types For PDO

2017-03-09 Thread Adam Baratz
> > However, I see no reference about the expected input/output encoding > (Unicode data is a bit vague). Is it expected to be UFT-8? Or maybe > match the internal encoding of the driver (e.g. UTF-16?)? What happens > if I try to quote a latin1 string? I think this is mostly covered by my BC note

Re: [PHP-DEV] Re: [RFC] Extended String Types For PDO

2017-03-09 Thread Marco Pivetta
On Thu, Mar 9, 2017 at 5:03 AM, Matteo Beccati wrote: > Hi Adam, > > On 03/03/2017 16:47, Adam Baratz wrote: > >> > >> Based on some pain points with my team and things I've heard from > others, > >> I created an RFC to handle "national" character sets for emulated > prepared > >> statements: > >

Re: [PHP-DEV] [Discussion] is_string(), string type and objects implementing __toString()

2017-03-09 Thread Andrey Andreev
Hi, On Thu, Mar 9, 2017 at 1:49 AM, Fleshgrinder wrote: > On 3/9/2017 12:32 AM, Andrey Andreev wrote: >> On Thu, Mar 9, 2017 at 12:42 AM, Rowan Collins >> wrote: >>> >>> I still don't understand what you're using this check for that means you >>> want to exclude integers. If you're passing on t

Re: [PHP-DEV] Re: [RFC] Extended String Types For PDO

2017-03-09 Thread Matteo Beccati
Hi Adam, On 03/03/2017 16:47, Adam Baratz wrote: >> >> Based on some pain points with my team and things I've heard from others, >> I created an RFC to handle "national" character sets for emulated prepared >> statements: >> https://wiki.php.net/rfc/extended-string-types-for-pdo >> > > Thanks all

Re: [PHP-DEV] [Discussion] is_string(), string type and objects implementing __toString()

2017-03-09 Thread Lester Caine
On 08/03/17 15:13, Larry Garfield wrote: > (I suppose there's a debate to be had if an int is stringable in strict > mode; I'm not sure there myself.) I think the main difference between strict and what I will call normal mode is that in the strict world of a compiler you have to call code to prov