Re: [PHP-DEV] BC break in master (7.2) - Distinguish between unmatched subpatterns and empty matches in preg_*()

Hello Nicolas 2017-05-15 8:57 GMT+02:00 Nicolas Grekas : > Hi, > > in master, feature request https://bugs.php.net/61780 has been implemented > and merged into master thanks to https://github.com/php/php-src/pull/1303 > > But as noted in the PR and even in the UPGRADING file, this is a BC break: >

[PHP-DEV] Re: [VOTE] PDO Float Type

> > I took another pass at this RFC: >> *https://wiki.php.net/rfc/pdo_float_type >> * >> > > Unless discussion prompts major changes, I'll open this for a vote next > Monday. > I had a request on the PR[1] to rename the const, from PDO::PARAM_FLT to PDO::PA

[PHP-DEV] [RFC] Improved TLS constants

Morning Internals, I hereby open the discussion for https://wiki.php.net/rfc/improved-tls-constants Discussion has already started on the GitHub PR: https://github.com/php/php-src/pull/2518 Further discussion can be found in https://externals.io/thread/864 Regards, Niklas

Re: [PHP-DEV] Re: [VOTE] PDO Float Type

Hi Adam, On 15/05/2017 09:47, Adam Baratz wrote: > I had a request on the PR[1] to rename the const, from PDO::PARAM_FLT to > PDO::PARAM_FLOAT. Agree that readability is better here. Since there's been > a change, I'll plan on opening the vote tomorrow. Are you kidding me? You can't possibly thi

Re: [PHP-DEV] BC break in master (7.2) - Distinguish between unmatched subpatterns and empty matches in preg_*()

hi Nicolas, On Mon, May 15, 2017 at 1:57 PM, Nicolas Grekas wrote: > Hi, > > in master, feature request https://bugs.php.net/61780 has been implemented > and merged into master thanks to https://github.com/php/php-src/pull/1303 > > But as noted in the PR and even in the UPGRADING file, this is a

Re: [PHP-DEV] BC break in master (7.2) - Distinguish between unmatched subpatterns and empty matches in preg_*()

Thanks Pierre, 2017-05-15 12:12 GMT+02:00 Pierre Joye : > hi Nicolas, > > On Mon, May 15, 2017 at 1:57 PM, Nicolas Grekas > wrote: > > Hi, > > > > in master, feature request https://bugs.php.net/61780 has been > implemented > > and merged into master thanks to https://github.com/php/php- > src/p

[PHP-DEV] [RFC] deprecate PDO::PARAM_NULL

Hi, I've heard a few people here mention that this type isn't useful. It looks like it wouldn't be harmful to remove. The RFC mainly outlines the impact and proposes a schedule for doing so. https://wiki.php.net/rfc/deprecate_pdo_null Please let me know your thoughts. Thanks, Adam

Re: [PHP-DEV] Re: [VOTE] PDO Float Type

> > > I had a request on the PR[1] to rename the const, from PDO::PARAM_FLT to > > PDO::PARAM_FLOAT. Agree that readability is better here. Since there's > been > > a change, I'll plan on opening the vote tomorrow. > > Are you kidding me? > You can't possibly think that changing the constant name

Re: [PHP-DEV] Re: [Discussion] Dots and spaces in GPC variable names

On 2017-05-03 13:55, Andrey Andreev wrote: Hi Andrea, On Tue, May 2, 2017 at 11:08 PM, Andrea Faulds wrote: Hey Andrey, Andrey Andreev wrote: I'm not surprised by the suggestion for targeting 8.0, but perhaps we could think of a way to conditionally disable the mangling in 7.x and then remo

[PHP-DEV] HYBRID VM

Hi, Recently, I committed HYBRID VM into master, but didn't enable it by default yet. It provides significant performance improvement on small benchmarks (1.5 times faster on bench.php) and slight improvement on real-life apps (1-2% on wordpress). Currently it improves PHP only on x86, x86_64

Re: [PHP-DEV] HYBRID VM

Am 15.05.2017 um 16:43 schrieb Dmitry Stogov: php zend_vm_gen.php --with-vm-kind=HYBRID make shouldn't that be a ./configure option? calls like "php zend_vm_gen.php" are not self contained in a rpmbuild -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://

Re: [PHP-DEV] BC break in master (7.2) - Distinguish betweenunmatched subpatterns and empty matches in preg_*()

On 15.05.2017 at 12:12, Pierre Joye wrote: > On Mon, May 15, 2017 at 1:57 PM, Nicolas Grekas > wrote: > >> in master, feature request https://bugs.php.net/61780 has been implemented >> and merged into master thanks to https://github.com/php/php-src/pull/1303 >> >> But as noted in the PR and even

Re: [PHP-DEV] BC break in master (7.2) - Distinguish between unmatched subpatterns and empty matches in preg_*()

On Mon, May 15, 2017 at 6:36 AM, Nicolas Grekas wrote: >> I agree that a minimum 5 years old possible bug, quite small, causing >> BC breaks is not good. As far as the fix is critical or justified, I >> think it is sometimes ok to break BC for edge cases. However I do not >> see this is not the ca

RE: [PHP-DEV] Patch for bug #65312: Segmentation fault with filesize=4096

Hi, > -Original Message- > From: Richard H Lee [mailto:ricardohenry...@gmail.com] > Sent: Thursday, May 11, 2017 3:18 PM > To: internals@lists.php.net > Subject: [PHP-DEV] Patch for bug #65312: Segmentation fault with filesize=4096 > > I submitted a patch for bug #65312 "Segmentation faul

Re: [PHP-DEV] HYBRID VM

On Mon, May 15, 2017 at 9:51 AM, li...@rhsoft.net wrote: > Am 15.05.2017 um 16:43 schrieb Dmitry Stogov: >> >> php zend_vm_gen.php --with-vm-kind=HYBRID >> > shouldn't that be a ./configure option? > calls like "php zend_vm_gen.php" are not self contained in a rpmbuild > atm, no. The VM gen is (a

Re: [PHP-DEV] HYBRID VM

Hi! On Mon, 15 May 2017, Dmitry Stogov wrote: > Recently, I committed HYBRID VM into master, but didn't enable it by > default yet. > > It provides significant performance improvement on small benchmarks > (1.5 times faster on bench.php) and slight improvement on real-life > apps (1-2% on wor

Re: [PHP-DEV] HYBRID VM

Am 15.05.2017 um 17:30 schrieb Sara Golemon: On Mon, May 15, 2017 at 9:51 AM, li...@rhsoft.net wrote: Am 15.05.2017 um 16:43 schrieb Dmitry Stogov: php zend_vm_gen.php --with-vm-kind=HYBRID shouldn't that be a ./configure option? calls like "php zend_vm_gen.php" are not self contained in

Re: [PHP-DEV] BC break in master (7.2) - Distinguish between unmatched subpatterns and empty matches in preg_*()

Le 15/05/2017 à 08:57, Nicolas Grekas a écrit : > Hi, > > in master, feature request https://bugs.php.net/61780 has been implemented > and merged into master thanks to https://github.com/php/php-src/pull/1303 I think everyone agree that BC should be avoid, when possible. Even if this one is quit

[PHP-DEV] PDO Parameter types // PDO::PARAM_AUTO

Hello Everyone! Currently PDOStatement::bindValue is declared as public bool PDOStatement::bindValue ( mixed $parameter , mixed $value [, int $data_type = PDO::PARAM_STR ] ) where third parameter is data type, string type as default. It may be useful in terms of providing meta info and ha

Re: [PHP-DEV] HYBRID VM

Am 15.05.2017 um 16:43 schrieb Dmitry Stogov: Hi, Recently, I committed HYBRID VM into master, but didn't enable it by default yet. It provides significant performance improvement on small benchmarks (1.5 times faster on bench.php) and slight improvement on real-life apps (1-2% on wordpre

Re: [PHP-DEV] HYBRID VM

Hi Derick, Sorry, it seems I tested it improperly. Anyway, I found and fixed the problem. It was a bug in USER_OPCODE handling in HYBRID VM. Thanks. Dmitry. From: Derick Rethans Sent: Monday, May 15, 2017 6:32:19 PM To: Dmitry Stogov Cc: PHP internals list;

[PHP-DEV] NEUTRAL Benchmark Results for PHP Master 2017-05-14

Results for project PHP master, build date 2017-05-14 19:25:38-07:00 commit: 8b361f1 previous commit:2fd94e6 revision date: 2017-05-14 02:03:02+02:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB