[PHP-DEV] UGLY Benchmark Results for PHP Master 2017-05-17

2017-05-18 Thread lp_benchmark_robot
Results for project PHP master, build date 2017-05-17 19:23:45-07:00 commit: b627e33 previous commit:774e7ea revision date: 2017-05-17 17:25:23-07:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

[PHP-DEV] RE: PDO Parameter types // PDO::PARAM_AUTO

2017-05-18 Thread Dorin Marcoci
Hi Adam, > From: Adam Baratz [mailto:adambar...@php.net] > Sent: Thursday, May 18, 2017 3:23 PM >> That's why I think, it will be great to have a special type like >> PDO::PARAM_AUTO and a config flag to set it as default instead of PARAM_STR. > The risk with this is queries could lose portabil

Re: [PHP-DEV] Re: [VOTE] PDO Float Type

2017-05-18 Thread Matteo Beccati
Hi Adam, On 18/05/2017 14:59, Adam Baratz wrote: >> >> If you search the archives, you might find that I wasn't happy to have >> PARAM_FLOAT without some kind of PARAM_NUMERIC. You're basically saying >> that my point was irrelevant and out of scope. Aww, thanks ;) > > I'm sorry my update sounded

Re: [PHP-DEV] Re: [VOTE] PDO Float Type

2017-05-18 Thread Adam Baratz
> > If you search the archives, you might find that I wasn't happy to have > PARAM_FLOAT without some kind of PARAM_NUMERIC. You're basically saying > that my point was irrelevant and out of scope. Aww, thanks ;) > I'm sorry my update sounded like I was ignoring your feedback. Another change was m

[PHP-DEV] Re: PDO Parameter types // PDO::PARAM_AUTO

2017-05-18 Thread Adam Baratz
> > Who is the architector/staff board of PDO? PDO is maintained with the rest of PHP core, so it follows the same process outlined in CONTRIBUTING.md. That is to say, there's no central governance. Some people, as listed in EXTENSIONS, have appropriate karma and handle maintenance that falls out

Re: [PHP-DEV] Implement formal process for run-tests.php refactor

2017-05-18 Thread li...@rhsoft.net
Am 18.05.2017 um 12:08 schrieb Marco Pivetta: On Thu, May 18, 2017 at 2:35 AM, Johannes Schlüter wrote: On Mi, 2017-05-17 at 23:30 +0200, Marco Pivetta wrote: Is Sebastian copied in here? Why can't we just use the super-battle- tested PHPUnit? It supports phpt and a ton of plugins, plus eve

Re: [PHP-DEV] messages not delivering?

2017-05-18 Thread li...@rhsoft.net
Am 18.05.2017 um 10:45 schrieb Andrey Andreev: http://news.php.net/php.internals/99093 http://news.php.net/php.internals/99094 Again, failing DMARC authentication which is unavoidable when the list mangles subject with a prefix and body with a list footer which breaks DKIM unconditionally

Re: [PHP-DEV] Implement formal process for run-tests.php refactor

2017-05-18 Thread Sebastian Bergmann
On 05/17/2017 11:30 PM, Marco Pivetta wrote: Is Sebastian copied in here? Why can't we just use the super-battle-tested PHPUnit? It supports phpt and a ton of plugins, plus everyone uses it and is familiar with it. IMO, PHPUnit is not the right tool to test PHP itself. Yes, it supports a subse

RE: [PHP-DEV] Implement formal process for run-tests.php refactor

2017-05-18 Thread Anatol Belski
Hi Sammy, > -Original Message- > From: sam...@sammykmedia.com [mailto:sam...@sammykmedia.com] On > Behalf Of Sammy Kaye Powers > Sent: Wednesday, May 17, 2017 4:29 PM > To: PHP Internals > Subject: [PHP-DEV] Implement formal process for run-tests.php refactor > > Hello internals folks! >

Re: [PHP-DEV] Re: [RFC] deprecate PDO::PARAM_NULL

2017-05-18 Thread Lester Caine
On 18/05/17 10:43, Marco Pivetta wrote: > On Thu, May 18, 2017 at 11:38 AM, Lester Caine wrote: > >> On 18/05/17 09:15, Dorin Marcoci wrote: >>> Yes, null is a state, not a type. ->bindValue('Foo', PDO::PARAM_NULL) is >>> awesome. >>> So it should be deprecated and removed. >> ? One of the reason

Re: [PHP-DEV] PDO Parameter types // PDO::PARAM_AUTO

2017-05-18 Thread dorin.marc...@marcodor.com
Sent from Meizu MX6 Original message Sender: Matteo Beccati Time: Thu 5/18 13:18 To: Dorin Marcoci ,internals Subject: Re: [PHP-DEV] PDO Parameter types // PDO::PARAM_AUTO >> I meant the case when a bool is passed as string, like >> bindValue('boolparam', false); >> Here

Re: [PHP-DEV] [RFC] deprecate PDO::PARAM_NULL

2017-05-18 Thread Matteo Beccati
On 18/05/2017 12:16, Adam Baratz wrote: > In all honesty, I'm ambivalent about this issue. It's certainly not > causing any problems. But if enough people feel it should be removed, > I'm happy to do the work to remove it. Sure, cleaning it up would be cool. I am just slightly worried about its us

Re: [PHP-DEV] Implement formal process for run-tests.php refactor

2017-05-18 Thread Johannes Schlüter
On Do, 2017-05-18 at 12:08 +0200, Marco Pivetta wrote: > On Thu, May 18, 2017 at 2:35 AM, Johannes Schlüter rs.de> wrote: > > On Mi, 2017-05-17 at 23:30 +0200, Marco Pivetta wrote: > > > Is Sebastian copied in here? Why can't we just use the super- > > battle- > > > tested > > > PHPUnit? It suppor

Re: [PHP-DEV] PDO Parameter types // PDO::PARAM_AUTO

2017-05-18 Thread Matteo Beccati
Hi Dorin, On 18/05/2017 11:41, Dorin Marcoci wrote: >>> ! When a bool ZVAL variable is converted to a string ZVAL. >>> Your example is irrelevant. > >> Ok, I think I got it. But the example shows that the pgsql driver is >> working, so maybe you could have a look at how it works. >> e.g. >> http

Re: [PHP-DEV] [RFC] deprecate PDO::PARAM_NULL

2017-05-18 Thread Adam Baratz
> > "A handful of people on the internals mail list have asked for it to be > removed" - where and when? > I didn't mean this as a justification or as any kind of vote, just as a prompt for a formal discussion. "Supporting it adds some weight to PDO" what kind of weight? How many > lines / micros

Re: [PHP-DEV] Implement formal process for run-tests.php refactor

2017-05-18 Thread Marco Pivetta
On Thu, May 18, 2017 at 2:35 AM, Johannes Schlüter wrote: > On Mi, 2017-05-17 at 23:30 +0200, Marco Pivetta wrote: > > Is Sebastian copied in here? Why can't we just use the super-battle- > > tested > > PHPUnit? It supports phpt and a ton of plugins, plus everyone uses it > > and > > is familiar

Re: [PHP-DEV] Re: [RFC] deprecate PDO::PARAM_NULL

2017-05-18 Thread Marco Pivetta
On Thu, May 18, 2017 at 11:38 AM, Lester Caine wrote: > On 18/05/17 09:15, Dorin Marcoci wrote: > > Yes, null is a state, not a type. ->bindValue('Foo', PDO::PARAM_NULL) is > > awesome. > > So it should be deprecated and removed. > > ? One of the reasons for using 'prepare' is to set up a query w

RE: [PHP-DEV] PDO Parameter types // PDO::PARAM_AUTO

2017-05-18 Thread Dorin Marcoci
>>! When a bool ZVAL variable is converted to a string ZVAL. >> Your example is irrelevant. >Ok, I think I got it. But the example shows that the pgsql driver is working, >so maybe you could have a look at how it works. >e.g. >https://github.com/php/php-src/blob/master/ext/pdo_pgsql/pgsql_stateme

Re: [PHP-DEV] Re: [RFC] deprecate PDO::PARAM_NULL

2017-05-18 Thread Lester Caine
On 18/05/17 09:15, Dorin Marcoci wrote: > Yes, null is a state, not a type. ->bindValue('Foo', PDO::PARAM_NULL) is > awesome. > So it should be deprecated and removed. ? One of the reasons for using 'prepare' is to set up a query which can be run several times and some of those passes may require

Re: [PHP-DEV] PDO Parameter types // PDO::PARAM_AUTO

2017-05-18 Thread Matteo Beccati
On 18/05/2017 10:06, Dorin Marcoci wrote: >> What are you referring to? > > I wrote "internally", meaning in C driver code, not in PHP. > When a bool ZVAL variable is converted to a string ZVAL. > Your example is irrelevant. Ok, I think I got it. But the example shows that the pgsql driver is wor

Re: [PHP-DEV] messages not delivering?

2017-05-18 Thread Andrey Andreev
On Wed, May 17, 2017 at 5:28 PM, Ryan Pallas wrote: > > > On Wed, May 17, 2017 at 8:25 AM, Adam Baratz wrote: >> >> > > I'm think this problem might've cropped up again. I didn't receive >> > > this >> > > message: >> > > http://news.php.net/php.internals/99052 >> > > >> > > I only heard about it

[PHP-DEV] Re: [RFC] deprecate PDO::PARAM_NULL

2017-05-18 Thread Dorin Marcoci
> I would agree that NULL is not a type and the constant shouldn't have > been there in the first place, but I think it could be a bit too late now. Raising an warning for first 1-2 years with later removal sounds OK. Also docs should be updated to mark this constant deprecated. Yes, null is a st

RE: [PHP-DEV] PDO Parameter types // PDO::PARAM_AUTO

2017-05-18 Thread Dorin Marcoci
Hello Matteo, -Original Message- From: Matteo Beccati [mailto:p...@beccati.com] Sent: Thursday, May 18, 2017 8:13 AM >> But when implementing FB Boolean data type parameters and doing >> ->bindValue ('bool_param', false) I get an empty string internally. >> >> Yes, true ZVAL is convert