To summarize current situation
libsodium v2.0.9 pecl extension use E_WARNING
sodium extension in php-7.2.0 (tag) use E_WARNING
(as in previous RCs)
sodium extension in PHP-7.2 (branch) use E_WARNING
(all changes have been reverted)
Seems consistent.
For 7.2.0, I don't think we have to change t
On Tue, Nov 28, 2017 at 7:30 PM, Stanislav Malyshev wrote:
>> If there's a mistake that needs to be fixed and that's detected within
>> these two days, a re-tag needs to happen. If the old tag is deleted and a
>> new modified tag is published, all cloned Git repositories that already
>> received t
Hi!
> If there's a mistake that needs to be fixed and that's detected within
> these two days, a re-tag needs to happen. If the old tag is deleted and a
> new modified tag is published, all cloned Git repositories that already
> received the old tag will keep the old tag and never receive the new
On 29.11.2017 at 00:03, Nikita Popov wrote:
> Previously: First
> commit: Second
commit: Third commit:
> In summary, the first two
commits combined were not a BC break -- they only> removed a warning and
made an error message nicer. After the third commit> we now *do* have a
BC break, because
2017-11-29 0:03 GMT+01:00 Nikita Popov :
> In summary, the first two commits combined were not a BC break -- they only
> removed a warning and made an error message nicer. After the third commit
> we now *do* have a BC break, because what was previously a SodiumException
> is now an E_ERROR.
>
> I
So
https://github.com/php/php-src/commit/31d221f9c72f0d0322c84907c5d89a4464667244
landed just now to revert this change, per the request here. This leaves us
with the worst variant... so, let's step back a bit:
The main commit that landed (for 7.2.1) is
https://github.com/php/php-src/commit/c21999
Hi,
> -Original Message-
> From: p...@golemon.com [mailto:p...@golemon.com] On Behalf Of Sara
> Golemon
> Sent: Tuesday, November 28, 2017 6:17 PM
> To: Niklas Keller
> Cc: PHP Internals ; Joe Watkins
> ; Remi Collet ; Anatol Belski
>
> Subject: Re: Public Tags of Releases
>
> On Tue, N
>
> On Tue, Nov 28, 2017 at 10:55 AM, Niklas Keller wrote:
> > it's the current practice to tag releases publicly two days before
> release
> > and then do the final QA phase. Could we please stop that?
> >
> > If there's a mistake that needs to be fixed and that's detected within
> these
> > two
On Tue, Nov 28, 2017 at 10:55 AM, Niklas Keller wrote:
> it's the current practice to tag releases publicly two days before release
> and then do the final QA phase. Could we please stop that?
>
> If there's a mistake that needs to be fixed and that's detected within these
> two days, a re-tag nee
Context: This commit switches some E_ERRORs introduced in a previous commit
to throw exceptions, consistently with the rest of the extension.
The original change was removing warning for parameters below an
"interactive" limit and replacing them with an error below a hard minimum.
This addresses
On Tue, Nov 28, 2017 at 1:17 PM, Sebastian Bergmann
wrote:
> Am 28.11.2017 um 13:56 schrieb Frank Denis:
> > Commit:c05cbd1e775fa69ed9939796a908390f2bfb4459
> > Author:Frank Denis Tue, 28 Nov 2017
> 13:56:11 +0100
> > Parents: c219991c77e4c68f7d62963e18a1da778de0bbe0
> > Branch
Am 28.11.2017 um 16:44 schrieb Niklas Keller :
> 2017-11-28 15:27 GMT+01:00 Christian Schneider :
>> Would you still consider an exception a good idea if the minimum value for
>> one of the function parameters is increased in a later version of libsodium?
>> Personally I'd prefer E_ERROR/E_WARNI
Le 28/11/2017 à 15:27, Christian Schneider a écrit :
>>
>> I am very much in favor of this change. However, making such a change in
>> PHP 7.2.1 is a BC break. Any chance to get that into PHP 7.2.0?
>
> I'm wary of turning errors into exceptions because code which was returning a
> result with li
>
> Afternoon,
>
> Tags are created in release branches, these branches should not be part of
> any workflow other than our internal one.
>
I'm not talking about branches, but tags. Updating these release branches
doesn't matter and is totally fine, as these are normal branches and thus
not deemed
Oh and private repositories suck, we already have a headache with security
fixes because of strange flow and secrecy, we simply don't need or want
more of that.
Cheers
Joe
On 28 Nov 2017 5:02 pm, "Joe Watkins" wrote:
Afternoon,
Tags are created in release branches, these branches should not be
Afternoon,
Tags are created in release branches, these branches should not be part of
any workflow other than our internal one.
It's problematic to tag other than publicly, anywhere we create these tags
is public and presumably would cause the same problem for those people who
choose to use relea
Morning,
it's the current practice to tag releases publicly two days before release
and then do the final QA phase. Could we please stop that?
If there's a mistake that needs to be fixed and that's detected within
these two days, a re-tag needs to happen. If the old tag is deleted and a
new modif
2017-11-28 15:27 GMT+01:00 Christian Schneider :
> Am 28.11.2017 um 14:17 schrieb Sebastian Bergmann :
> > Am 28.11.2017 um 13:56 schrieb Frank Denis:
> >> Commit:c05cbd1e775fa69ed9939796a908390f2bfb4459
> >> Author:Frank Denis Tue, 28 Nov 2017
> 13:56:11 +0100
> >> Parents: c21
Am 28.11.2017 um 14:17 schrieb Sebastian Bergmann :
> Am 28.11.2017 um 13:56 schrieb Frank Denis:
>> Commit:c05cbd1e775fa69ed9939796a908390f2bfb4459
>> Author:Frank Denis Tue, 28 Nov 2017
>> 13:56:11 +0100
>> Parents: c219991c77e4c68f7d62963e18a1da778de0bbe0
>> Branches: PHP-7.
Am 28.11.2017 um 13:56 schrieb Frank Denis:
> Commit:c05cbd1e775fa69ed9939796a908390f2bfb4459
> Author:Frank Denis Tue, 28 Nov 2017
> 13:56:11 +0100
> Parents: c219991c77e4c68f7d62963e18a1da778de0bbe0
> Branches: PHP-7.2
>
> Link:
> http://git.php.net/?p=php-src.git;a=c
On Mon, 27 Nov 2017, Michael Morris wrote:
> I'm sure the internal coders will correct me if I'm wrong on this, but
> as I understand it PHP has no notion of packages, yet many calls to
> modify how namespace importing works seem to be under the illusion
> that packages exist. This is understan
21 matches
Mail list logo