Re: [PHP-DEV] Make bcmath functions more strict

2019-04-25 Thread Vladyslav Startsev
On Thu, Apr 25, 2019 at 12:35 PM Benjamin Morel wrote: > > Hi Vladyslav, > > I just checked your code snippet, here are my 2 cents: > > - bcmath should definitely trigger an error when encountering a malformed > string like '17 .123', silently converting it to zero is indeed the worth > thing to

Re: [PHP-DEV] Revive Number Format Separator RFC

2019-04-25 Thread Bishop Bettini
On Thu, Apr 25, 2019 at 9:28 PM Bishop Bettini wrote: > On Thu, Apr 25, 2019 at 6:07 PM Theodore Brown > wrote: > >> Is there any chance the Number Format Separator RFC [1] could be revived >> for PHP 7.4? I looked at the discussion from a few years ago and it's not >> clear why many people orig

Re: [PHP-DEV] Revive Number Format Separator RFC

2019-04-25 Thread Bishop Bettini
On Thu, Apr 25, 2019 at 6:07 PM Theodore Brown wrote: > Is there any chance the Number Format Separator RFC [1] could be revived > for PHP 7.4? I looked at the discussion from a few years ago and it's not > clear why many people originally voted against it. > > JavaScript and Python have both got

[PHP-DEV] Revive Number Format Separator RFC

2019-04-25 Thread Theodore Brown
Is there any chance the Number Format Separator RFC [1] could be revived for PHP 7.4? I looked at the discussion from a few years ago and it's not clear why many people originally voted against it. JavaScript and Python have both gotten this feature recently and it's something I really miss in

Re: [PHP-DEV] Required Make version

2019-04-25 Thread Peter Kokot
Hello, On Wed, 17 Apr 2019 at 01:08, Johannes Schlüter wrote: > > On Di, 2019-04-16 at 09:46 -0600, Levi Morrison wrote: > > > > I'd be happy to work help with the CMake port, as I know it a decent > > bit, but I don't have enough time to champion the whole thing. > > > > That has been done ages

Re: [PHP-DEV] Alternative approach to short tags deprecation

2019-04-25 Thread Chase Peeler
A lot of this will echo what other people have said. As someone that has been very vocal on the other thread (both before and after the vote) I felt I should comment as well. I definitely appreciate Nikita for taking the time to propose a compromise/alternate solution. On Thu, Apr 25, 2019 at 3:15

Re: [PHP-DEV] Alternative approach to short tags deprecation

2019-04-25 Thread Peter Kokot
Hello, On Thu, 25 Apr 2019 at 09:15, Nikita Popov wrote: > > Hi internals, > > As already discussed in the corresponding voting thread, the deprecation of > short tags as proposed has a high risk of causing inadvertent source code > leakage. The RFC proposes to change the default of short_open_ta

Re: [PHP-DEV] Alternative approach to short tags deprecation

2019-04-25 Thread G. P. B.
On Thu, 25 Apr 2019 at 09:15, Nikita Popov wrote: > Hi internals, > > As already discussed in the corresponding voting thread, the deprecation of > short tags as proposed has a high risk of causing inadvertent source code > leakage. The RFC proposes to change the default of short_open_tag from On

[PHP-DEV] Re: Alternative approach to short tags deprecation

2019-04-25 Thread Mark Randall
On 25/04/2019 08:15, Nikita Popov wrote: The advantage of such an approach would be that no source code leakage could occur when switching to PHP 7.4 or PHP 8.0. The disadvantage is that we'll only be able to fully remove short tags support at a later point in time. It is certainly my opinion t

Re: [PHP-DEV] [RFC] Change the precedence of the concatenation operator

2019-04-25 Thread Bishop Bettini
On Thu, Apr 25, 2019 at 5:52 AM Nikita Popov wrote: > On Thu, Mar 28, 2019 at 2:33 PM Bob Weinand wrote: > > > I feel like concatenation having the same precedence than addition and > > subtraction is promoting programmers to make mistakes. Albeit typically > > easy to catch ones, it is a qualit

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-25 Thread Benjamin Eberlei
On Wed, Apr 24, 2019 at 1:29 PM G. P. B. wrote: > Hello Internal, > > The two weeks of voting have now ended. > The results are 38 for and 18 against (total 56) for the primary vote to > deprecate PHP's short open tag in PHP 7.4. > This passes in favor with 68%. > > The results are 42 for and 15

Re: [PHP-DEV] [RFC] Change the precedence of the concatenation operator

2019-04-25 Thread Nikita Popov
On Thu, Mar 28, 2019 at 2:33 PM Bob Weinand wrote: > Hey, > > I feel like concatenation having the same precedence than addition and > subtraction is promoting programmers to make mistakes. Albeit typically > easy to catch ones, it is a quality of life change at least. > > Hence I'm proposing a R

Re: [PHP-DEV] Make bcmath functions more strict

2019-04-25 Thread Benjamin Morel
Hi Vladyslav, I just checked your code snippet, here are my 2 cents: - bcmath should definitely trigger an error when encountering a malformed string like '17 .123', silently converting it to zero is indeed the worth thing to do; - I don't think that there's much value in having it handle exponen

Re: [PHP-DEV] Alternative approach to short tags deprecation

2019-04-25 Thread Bishop Bettini
On Thu, Apr 25, 2019 at 3:16 AM Nikita Popov wrote: > Hi internals, > > As already discussed in the corresponding voting thread, the deprecation of > short tags as proposed has a high risk of causing inadvertent source code > leakage. The RFC proposes to change the default of short_open_tag from

Re: [PHP-DEV] Make bcmath functions more strict

2019-04-25 Thread Vladyslav Startsev
Any other ideas on that one? I'll wait for one more week and make RFC then -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-25 Thread Thomas Hruska
On 4/24/2019 4:28 AM, G. P. B. wrote: Hello Internal, The two weeks of voting have now ended. The results are 38 for and 18 against (total 56) for the primary vote to deprecate PHP's short open tag in PHP 7.4. This passes in favor with 68%. The results are 42 for and 15 against (total 57) for t

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-25 Thread Thomas Hruska
On 4/25/2019 12:57 AM, Côme Chilliet wrote: Le jeudi 25 avril 2019, 00:11:42 CEST Thomas Hruska a écrit : So I built a tool that meets the above minimum criteria and have already run it against a fairly extensive codebase (and have shared the tool with a few concerned folks - you've already seen

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-25 Thread Thomas Hruska
On 4/25/2019 12:26 AM, Stephen Reay wrote: On 25 Apr 2019, at 14:11, Thomas Hruska wrote: sed-based solutions do NOT work. Neither of the two recommended options to date on this list are valid recommendations for serious software deployment managers. I have no issue with suggesting tools t

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-25 Thread Côme Chilliet
Le jeudi 25 avril 2019, 00:11:42 CEST Thomas Hruska a écrit : > So I built a tool that meets the above minimum criteria and have already > run it against a fairly extensive codebase (and have shared the tool > with a few concerned folks - you've already seen its output here on-list): > > https:/

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-25 Thread Lester Caine
On 25/04/2019 08:34, Reindl Harald wrote: little fucker when i write you a private mail keep it private And as we are on a public forum I will continue to reply to the forum THAT is how my email client is set up and you can just piss off! It pisses me off that I get multiple replies normally an

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-25 Thread Stephen Reay
> On 25 Apr 2019, at 14:11, Thomas Hruska wrote: > sed-based solutions do NOT work. > Neither of the two recommended options to date on this list are valid > recommendations for serious software deployment managers. I have no issue with suggesting tools to fix short opening tags, but lay of

[PHP-DEV] Alternative approach to short tags deprecation

2019-04-25 Thread Nikita Popov
Hi internals, As already discussed in the corresponding voting thread, the deprecation of short tags as proposed has a high risk of causing inadvertent source code leakage. The RFC proposes to change the default of short_open_tag from On to Off in PHP 7.4. Any website using short_open_tags without

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-25 Thread Thomas Hruska
On 4/24/2019 4:28 AM, G. P. B. wrote: Hello Internal, The two weeks of voting have now ended. The results are 38 for and 18 against (total 56) for the primary vote to deprecate PHP's short open tag in PHP 7.4. This passes in favor with 68%. The results are 42 for and 15 against (total 57) for t