Re: [PHP-DEV] List of attributes

On Sat, Oct 31, 2020, at 5:06 AM, Rowan Tommins wrote: > > This would be an artificial limitation on attributes to patch > > over the inherent inconsistency of the grouped syntax for nested > > attributes. > > There is no artificial limitation; there is a binary choice: does > #[Foo] represent an

Re: [PHP-DEV] PHP releases, OPcache + Jit bugs, and communication

Hey Dan, On Tue, Nov 24, 2020 at 9:48 PM Dan Ackroyd wrote: > Hi internals, > > Currently the PHP project doesn't have a particularly great way of > letting users know when serious defects have been found in versions of > PHP. > > My understanding is that this has

Re: [PHP-DEV] PHP releases, OPcache + Jit bugs, and communication

On Tue, Nov 24, 2020, at 2:47 PM, Dan Ackroyd wrote: > Hi internals, > > Currently the PHP project doesn't have a particularly great way of > letting users know when serious defects have been found in versions of > PHP. > > My understanding is that this has been an issue before, when defects >

[PHP-DEV] PHP releases, OPcache + Jit bugs, and communication

Hi internals, Currently the PHP project doesn't have a particularly great way of letting users know when serious defects have been found in versions of PHP. My understanding is that this has been an issue before, when defects were found in OPcache. Due to OPcache incorrectly optimizing code,

Re: [PHP-DEV] [RFC] Draft - Closure self reference

Sara Golemon wrote: > looks a bit... ugly? weird? surprising? I had the same initial reaction, and was going to tell David what I thought of the suggestion. But after a couple of days, I was unable to actually articulate what I didn't like it, so think I was just having a gut reaction to

Re: [PHP-DEV] Preparing for PHP 8.0.0 GA

On Tue, Nov 24, 2020 at 6:14 PM Sara Golemon wrote: > On Tue, Nov 24, 2020 at 8:55 AM Sara Golemon wrote: > >> Given that the JIT is enabled by default, I'm tempted to add another RC >> and delay the release. >> >> > As Niki just helpfully pointed out; My understanding of the JIT's setting > on

Re: [PHP-DEV] Preparing for PHP 8.0.0 GA

On Tue, Nov 24, 2020 at 10:27 AM Dmitry Stogov wrote: > I think, new RC is not necessary. > These commits only affect JIT. They fix the recently found problems and don't show any degradation. > Good enough for me. I'll pull 'em up and cut in the next couple hours. -Sara

Re: [PHP-DEV] Preparing for PHP 8.0.0 GA

Hi Sara, On Tue, Nov 24, 2020 at 5:56 PM Sara Golemon wrote: > On Tue, Nov 24, 2020 at 12:35 AM Dmitry Stogov > wrote: > >> I finally fixed all the known JIT related issues and made the PHP-8.0 >> build "green". >> >> >>

Re: [PHP-DEV] Renaming on of the XML opaque objects for consistency

> I know this is *literally* hours before the GA tag, but I just realized > that when introducing opaque objects during the resource to object > conversion the XMLWriter and XMLParser extensions don't use the same casing > as the classes are named XmlParser and XMLWriter > > Should we rename one

Re: [PHP-DEV] Preparing for PHP 8.0.0 GA

On Tue, Nov 24, 2020 at 8:55 AM Sara Golemon wrote: > Given that the JIT is enabled by default, I'm tempted to add another RC > and delay the release. > > As Niki just helpfully pointed out; My understanding of the JIT's setting on 8.0 is wrong. It's "on", but with a 0-sized buffer, so it's

Re: [PHP-DEV] Preparing for PHP 8.0.0 GA

On Tue, Nov 24, 2020 at 12:35 AM Dmitry Stogov wrote: > I finally fixed all the known JIT related issues and made the PHP-8.0 > build "green". > > > https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=13088=results > > Please, cherry-pick the following 5 commits into PHP-8.0.0. > >

Re: [PHP-DEV] Preparing for PHP 8.0.0 GA

On 24.11.2020 at 03:40, Christopher Jones wrote: > On 20/11/20 1:50 am, Sara Golemon wrote: > >> I've just cut the release branch for PHP-8.0.0 final which will be >> released >> in one week on 26 Nov.  Minor bug fixes can continue to be merged via the >> PHP-8.0 branch for inclusion in 8.0.1,

Re: [PHP-DEV] Renaming on of the XML opaque objects for consistency

Since class names are case-insensitive, and since `XmlParser` is new as of PHP 8.0, I guess that there is not much problems in correcting the canonical casing of `XmlParser` into `XMLParser`? Count it as a last-minute bugfix. —Claude -- PHP Internals - PHP Runtime Development Mailing List To