Re: [PHP-DEV] [Vote] More Appropriate Date/Time Exceptions

2022-12-16 Thread Derick Rethans
On 16 December 2022 21:34:16 GMT, Theodore Brown wrote: >On Thu, Dec 15, 2022 at 8:27 AM Derick Rethans wrote: > >> Hi, >> >> I've just opened the vote for "More Appropriate Date/Time Exceptions". >> It runs until December 31st, 24:00 UTC. >> >> You can vote at: >> https://wiki.php.net/rfc/date

Re: [PHP-DEV] [Vote] More Appropriate Date/Time Exceptions

2022-12-16 Thread Theodore Brown
On Thu, Dec 15, 2022 at 8:27 AM Derick Rethans wrote: > Hi, > > I've just opened the vote for "More Appropriate Date/Time Exceptions". > It runs until December 31st, 24:00 UTC. > > You can vote at: > https://wiki.php.net/rfc/datetime-exceptions#voting Hi Derick, Thank you for your work on thi

Re: [PHP-DEV] [RFC] Unicode Text Processing

2022-12-16 Thread Rowan Tommins
On 16 December 2022 13:55:02 GMT, Derick Rethans wrote: >I do not want a polyfill. These already exist for intl and friends. I think you misunderstood what I meant by "polyfill"; I meant in the sense that once the real implementation gets included in, say PHP 8.3, users needing to support, say,

Re: [PHP-DEV] [RFC] Unicode Text Processing

2022-12-16 Thread Tim Düsterhus
Hi On 12/16/22 16:27, Andreas Heigl wrote: I rather not see this either, because if a 'Text' object may contain binary data, the type safety is lost and users cannot rely on "'Text' implies valid UTF-8" (see sibling thread). Does Text contain valid UTF-8? Or valid Unicode? As IIRC the idea was

Re: [PHP-DEV] [RFC] Unicode Text Processing

2022-12-16 Thread Tim Düsterhus
Hi On 12/16/22 14:55, Derick Rethans wrote: -- getPositionOfFirstOccurrence(): I agree this is too long. How about: - findOffset() - findOffsetLast() And for returnFromFirstOccurence(): - startingWith() - startingWithLast() I have included these as suggested names. I suspect we'll

Re: [PHP-DEV] [RFC] Unicode Text Processing

2022-12-16 Thread Andreas Heigl
Hey On 16.12.22 16:21, Tim Düsterhus wrote: Hi On 12/16/22 14:28, Derick Rethans wrote: Question 2 is that class.  I know folks have been clammoring for a `String` class for some time and this actually fills that niche quite well.  A part of me wonders if we can overload it a little to provide

Re: [PHP-DEV] [RFC] Unicode Text Processing

2022-12-16 Thread Tim Düsterhus
Hi On 12/16/22 14:28, Derick Rethans wrote: Question 2 is that class. I know folks have been clammoring for a `String` class for some time and this actually fills that niche quite well. A part of me wonders if we can overload it a little to provide a psuedo locale of "binary" so that users can

Re: [PHP-DEV] [RFC] Unicode Text Processing

2022-12-16 Thread Derick Rethans
On Thu, 15 Dec 2022, Tim Düsterhus wrote: > On 12/15/22 16:34, Derick Rethans wrote: > > You can find it at: > > https://wiki.php.net/rfc/unicode_text_processing > > > > I'm looking forwards to hearing your opinions, additions, and > > suggestions — the RFC specifically asks for these in places.

Re: [PHP-DEV] [RFC] Unicode Text Processing

2022-12-16 Thread Derick Rethans
On Thu, 15 Dec 2022, Rowan Tommins wrote: > On 15/12/2022 15:34, Derick Rethans wrote: > > I have just published an initial draft of the "Unicode Text Processing" > > RFC, a proposal to have performant unicode text processing always > > available to PHP users, by introducing a new "Text" class. >

Re: [PHP-DEV] [RFC] Unicode Text Processing

2022-12-16 Thread Derick Rethans
On Fri, 16 Dec 2022, Tim Starling wrote: > On 16/12/22 02:34, Derick Rethans wrote: > > > > I have just published an initial draft of the "Unicode Text > > Processing" RFC, a proposal to have performant unicode text > > processing always available to PHP users, by introducing a new > > "Text"

Re: [PHP-DEV] Re: [RFC] Unicode Text Processing

2022-12-16 Thread Derick Rethans
On Thu, 15 Dec 2022, Daniel Wolfe wrote: > On 2022-12-15 8:34 AM, Derick Rethans wrote: > > Hi, > > > > I have just published an initial draft of the "Unicode Text Processing" > > RFC, a proposal to have performant unicode text processing always > > available to PHP users, by introducing a new "T

Re: [PHP-DEV] [RFC] Unicode Text Processing

2022-12-16 Thread Derick Rethans
On Thu, 15 Dec 2022, Tim Düsterhus wrote: > [1] The 'Text' class should likely be made final, because folks might > otherwise rely on a specific userland extension, preventing actual > interoperability. Yes, I intended to do this, but forgot to include it. I've updated the RFC. cheers, Derick

Re: [PHP-DEV] [RFC] Unicode Text Processing

2022-12-16 Thread Derick Rethans
On Thu, 15 Dec 2022, Sara Golemon wrote: > On Thu, Dec 15, 2022 at 9:34 AM Derick Rethans wrote: > > > I have just published an initial draft of the "Unicode Text > > Processing" RFC, a proposal to have performant unicode text > > processing always available to PHP users, by introducing a new

Re: [PHP-DEV] Re: [RFC] Unicode Text Processing

2022-12-16 Thread Derick Rethans
On Thu, 15 Dec 2022, Paul Crovella wrote: > On 12/15/2022 7:34 AM, Derick Rethans wrote: > > https://wiki.php.net/rfc/unicode_text_processing > > A few quick thoughts: > > > The constructor will also convert the given text to Unicode Canonical Form. > > By this do you mean Normalization Form C

Re: [PHP-DEV] Re: [RFC] Unicode Text Processing

2022-12-16 Thread Derick Rethans
On Thu, 15 Dec 2022, Jakub Zelenka wrote: > On Thu, Dec 15, 2022 at 4:56 PM Christoph M. Becker > wrote: > > > On 15.12.2022 at 16:34, Derick Rethans wrote: > > > > > I have just published an initial draft of the "Unicode Text > > > Processing" RFC, a proposal to have performant unicode text >

Re: [PHP-DEV] [Vote] More Appropriate Date/Time Exceptions

2022-12-16 Thread Derick Rethans
On Thu, 15 Dec 2022, Marco Pivetta wrote: > On Thu, 15 Dec 2022 at 15:27, Derick Rethans wrote: > > > I've just opened the vote for "More Appropriate Date/Time > > Exceptions". It runs until December 31st, 24:00 UTC. > > > > You can vote at: > > https://wiki.php.net/rfc/datetime-exceptions#voti

Re: [PHP-DEV] [RFC] Unicode Text Processing

2022-12-16 Thread Rowan Tommins
On Fri, 16 Dec 2022 at 03:21, Tim Starling wrote: > > I'm concerned about the time order of using grapheme offsets. For > example, is subString() O(N) in $offset? If the idea is to be easy to > use and performant, you don't want to have subtle algorithmic > complexity traps. > This is a good po