[PHP-DEV] Quick missing NEWS entry questions

2011-12-28 Thread Andrew Curioso
Hi everyone, I'll try to make this quick with easy questions since everyone is so busy. I contributed some minor but non-trivial code to 5.4 but I was (am) a bit new to the project and I didn't know to put an entry in NEWS. But there is a reference in UPGRADING because my change did effect

Re: [PHP-DEV] Porting PECL to userspace

2011-05-20 Thread Andrew Curioso
AMF-PHP does something similar to this. It is a PHP implementation of AMF (Action Message Format) so it allows you to accept and respond to AMF messages from Flash apps. Its native PHP encoder is extremely slow but it works. However, if you install amfext from PECL it will use that for encoding

Re: [PHP-DEV] Inconsistencies with constructors in SPL

2011-05-17 Thread Andrew Curioso
...@php.net wrote: Hi, On May 16 16:52:08, Andrew Curioso wrote: Well, that wasn't where I was expecting that thread to go, but to wrap it up what do you think... Is it too late to put this on the 5.4 roadmap for consideration? I'm assuming just the implicit ctor and dtor. Not all magic

[PHP-DEV] Inconsistencies with constructors in SPL

2011-05-16 Thread Andrew Curioso
So, I ran across bug #54631 A fatal error is thrown if you try to call parent::__construct() from a subclass of SplObjectStorage. I was going to close it as expected behavior since that is pretty normal if the parent class doesn't implement __construct(). Also, the docs don't list it as having a

Re: [PHP-DEV] Inconsistencies with constructors in SPL

2011-05-16 Thread Andrew Curioso
constructor is called but doesn't exist the engine should ignore this. The same goes for destructors. This solution would also work for userland classes. johannes On Mon, 2011-05-16 at 14:14 -0400, Andrew Curioso wrote: So, I ran across bug #54631 A fatal error is thrown if you try

Re: [PHP-DEV] Inconsistencies with constructors in SPL

2011-05-16 Thread Andrew Curioso
). That way we can use an error exception to catch the fatal and recover from it if necessary. But silently ignoring a called function, something just doesn't sit right about that... On Mon, May 16, 2011 at 2:44 PM, Andrew Curioso andrewcuri...@gmail.com wrote: I like that idea and I like

Re: [PHP-DEV] Inconsistencies with constructors in SPL

2011-05-16 Thread Andrew Curioso
, Anthony Ferrara ircmax...@gmail.comwrote: Well, if we follow that logic (which does make sense), then shouldn't all magic methods be implicit? So parent::__sleep/__call/__get/etc would silently do the default if not defined? On Mon, May 16, 2011 at 3:18 PM, Andrew Curioso andrewcuri...@gmail.com

Re: [PHP-DEV] Inconsistencies with constructors in SPL

2011-05-16 Thread Andrew Curioso
Well, that wasn't where I was expecting that thread to go, but to wrap it up what do you think... Is it too late to put this on the 5.4 roadmap for consideration? I'm assuming just the implicit ctor and dtor. Not all magic methods (not now, at least). With your OK, Stas, I'd like to write up an

Re: [PHP-DEV] Inconsistencies with constructors in SPL

2011-05-16 Thread Andrew Curioso
I had given up on someone actually going with one of my original ideas for fixing the bug! That is where I was leaning but I would take it a step further and add constructors to all SPL classes even if the docs don't currently list one. In regards to the implicit ctor and dtor. I don't thing it

[PHP-DEV] SVN Account Request: acurioso

2011-05-13 Thread Andrew Curioso
Rasmus encouraged me to... in his php.internals message on May 11 Re: 5.4 again. Fixed the issue documented in test ext/simplexml/tests/034.phpt (an almost 2 year old expected fail) The fix was non-trivial. It uses the iterator where appropriate to enumerate the property hash instead of

[PHP-DEV] SimpleXML bug with the properties hash

2011-05-13 Thread Andrew Curioso
I'm looking for feedback since this is my first commit to PHP and it changes some behavior of SimpleXMLElement. If no-one has an objections I'll go ahead and commit the code. First, here is the original bug: ---BEGIN-- $string = '?xml version=1.0? foobar pBlah 1/p pBlah 2/p

Re: [PHP-DEV] SimpleXML bug with the properties hash

2011-05-13 Thread Andrew Curioso
Thank you. That makes sense. I attached the .txt version this time. Hopefully that works. 2011/5/13 Johannes Schlüter johan...@schlueters.de On Fri, 2011-05-13 at 19:43 -0400, Andrew Curioso wrote: I attached a diff of my changes. This didn|T come through. Make sure it is send