Yasuo Ohgaki wrote:
2011/12/2 Daniel K. :
Yasuo Ohgaki wrote:
2011/12/2 Yasuo Ohgaki :
Search for a + followed by only tabs or spaces. Empty lines should be
just that, empty.
Does CODING_STANDARDS mention this?
I hope not, this should be obvious.
Since Daniel mentioned that he cannot
Yasuo Ohgaki wrote:
Hi all,
According to comments, I updated the patch.
Our emails crossed, however my comments still stand.
Test files are added.
Thanks for that.
Entry added to php.ini-*
Typo:
+session.usr_strict_mode = 1
Daniel K.
--
PHP Internals - PHP Runtime Development
/0 as does the exsting ps_files_valid_key.
I am in serious doubt as to whether the additonal restrictions on valid
characters in session ids are appropriate, and I fear that some poor sod
may be in for a nasty surpris because of this.
Remember, this is not just about the return value of ha
ot at the same time? It seems appropriate to prove that you have
tested the new features when you commit them?
It removes session read failure retry code from
php_session_initialize() . The retry code may cause infinite loop
depending on save handler implementation. Some session save handlers
may be using this to prevent adoption(?)
I do not believe this could have been used as you speculate. The retry
logic kicks in when PS_READ_FUNC() fails _and_ additionally sets
PS(invalid_session_id)
This could never work with:
session_id("foo");
session_start();
could it?
Have you checked that this still works as advertised with the patch
applied?
I may have additional comments if I can find time to test it.
Daniel K.
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
ike people have been tripping over this left and
right, and given the change in behaviour, it may not be worth the risk.
That said, I'd be _very_ surprised, and a bit sad if anyone is relying
on the current buggy behaviour.
Daniel K.
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
w test-case uploaded, and attached.
Daniel K.
--- /dev/null 2011-07-31 22:39:26.003634828 +0200
+++ php-5.3.8/tests/lang/bug55754.phpt 2011-09-23 12:39:35.0 +0200
@@ -0,0 +1,14 @@
+--TEST--
+Bug #55754 (Only variables should be passed by reference for ZEND_SEND_PREFER_REF params)
+--FILE
On 10/06/2011 06:03 PM, Etienne Kneuss wrote:
> On Thu, Oct 6, 2011 at 17:31, Daniel K. wrote:
>> The patch still applies to trunk, and I think it should be applied to
>> the 5.3 and 5.4 branches as well.
>
> The new patch seems to be indeed better. My only concern is wh
On 10/06/2011 05:55 PM, Stas Malyshev wrote:
> On 10/6/11 5:31 PM, Daniel K. wrote:
>> A patch was appended, discussed, and improved, and I have uploaded a
>> test-case, as well as a minimal patch that fixes the problem (attached)
>> to the original bug-report.
>>
&
the completely wrong
approach to solve the problem and dropping a few hints would be most
appreciated, but any feedback is welcome.
Daniel K.
diff --git a/Zend/zend_compile.c b/Zend/zend_compile.c
index c325a7e..d361c64 100644
--- a/Zend/zend_compile.c
+++ b/Zend/zend_compile.c
@@ -2096,7 +2096,7 @@ vo
On 09/23/2011 03:41 PM, Daniel K. wrote:
> On 09/23/2011 02:28 PM, Etienne Kneuss wrote:
>> On Fri, Sep 23, 2011 at 14:06, Daniel K. wrote:
>>> When a built-in function is defined with ZEND_SEND_PREFER_REF, PHP will
>>> issue a strict warning if you use an assignment
On 09/23/2011 02:28 PM, Etienne Kneuss wrote:
> On Fri, Sep 23, 2011 at 14:06, Daniel K. wrote:
>> When a built-in function is defined with ZEND_SEND_PREFER_REF, PHP will
>> issue a strict warning if you use an assignment expression as the parameter.
>
> The patch looks str
the right approach to solve the
problem, in which case, I hope to at least have put one of you on the
right track to the _real_ solution, and to have made you interested in
fixing it properly.
The patch is for php-5.3.8
Daniel K.
diff --git a/Zend/zend_compile.c b/Zend/zend_compile.c
index
The following is a test-case for bug #55754
The patch is on top of php-5.3.8.
Daniel K.
diff --git a/tests/lang/bug55754.phpt b/tests/lang/bug55754.phpt
new file mode 100644
index 000..179d475
--- /dev/null
+++ b/tests/lang/bug55754.phpt
@@ -0,0 +1,11 @@
+--TEST--
+Bug #55754 (Only
I need the account to maintain XML_XPath in PEAR.
Helgi sent me.
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
14 matches
Mail list logo
