Hi again,
Hmm, not a single reply about this patch...? Did anyone try it out? :-)
Think it can be used after 5.2.2?
Matt
- Original Message -
From: "Matt Wilmas"
Sent: Thursday, April 12, 2007
Subject: [PHP-DEV] [PATCH] Major optimization for heredocs/interpolated
strings
Hi Marcus,
Yeah, I did a lot of benchmarking different things ;-) and mentioned some
statistics in my original message -- such as 10-15% *overall* improvement
using ApacheBench on a few scripts. The difference for specific strings
depends on what the string looks like (length, etc.), but is alway
Hi Ilia, all,
I've attached patches for what I think is a better fix here, and it
simplifies the code. Looking at the CVS log, the is_numeric_string() usage
was added in version 1.120 to fix the first numeric key bug. The simple,
better thing would've been to just change zend_hash... to zend_sym
address,
http://realplain.com/php/scanner_optimizations_5_2.diff, and the original
was moved to http://realplain.com/php/scanner_optimizations_5_2-v1.diff
Thanks,
Matt
- Original Message -
From: "Matt Wilmas"
Sent: Thursday, April 12, 2007
> Hi all,
>
> I think I firs
Hi Richard,
- Original Message -
From: "Richard Quadling"
Sent: Wednesday, May 16, 2007
[...]
> If you use variables, then this works fine ...
>
> php -r "$a = 1; $b = -2; $c = 5; var_dump($a/$b*$c);"
> float(-2.5)
Certainly. :-) The problem seems to be the parser is acting weird as fa
Hi Stas,
Can we see any difference with optimal ZEND_ADD_(STRING|CHAR|VAR)? :-)
Well, multiple ADD_STRINGs are one thing that optimizers/accelerators would
stitch back together, because it's a "major optimization." ;-) I didn't
specifically mention it in my previous messages, but since these part
Hi Antony,
Would this change also apply to string_compare_function and
string_locale_compare_function? They currently use
zend_make_printable_zval()...
Matt
- Original Message -
From: "Antony Dovgal"
Sent: Thursday, May 17, 2007
> tony2001 Thu May 17 17:28:12 2007 UTC
>
> Modified
Hi Ilia,
Did you see the last message...? Any reason not to apply the patch I sent
to prevent future bug reports/simplify code?
http://news.php.net/php.internals/29315
Matt
- Original Message -
From: "Matt Wilmas"
Sent: Tuesday, May 08, 2007
> Hi Ilia, all,
>
> I&
Hi all,
I haven't thought about this too much, just came to mind after following
this thread, so ignore any stupidity. :-)
Wanting to preserve BC where possible, and figuring that code to take
advantage of PHP 6's Unicode support will be either new or rewritten... Is
it possible to always have U
Hi Gwynne, all,
I think this "parsing variables within strings..." note should be removed,
as it's incorrect/misleading as far as I can tell.
First, I was never able to repeat the behavior with the code in the bug
report months ago, nor am I now (no matter what I try). Second, and more
important
Hi Richard,
- Original Message -
From: "Richard Lynch"
Sent: Thursday, July 05, 2007 10:43 PM
> On Fri, June 29, 2007 1:21 am, Tomas Kuliavas wrote:
> >> If unicode semantics are "on" what exactly is borked in PHP 5?
> >
> > In Unicode mode \[0-7]{1,3} and \x[0-9A-Fa-f]{1,2} refer to uni
Hi!
- Original Message -
From: "Stanislav Malyshev"
Sent: Monday, May 11, 2015
Hi!
argument. I'd like to propose making the order of evaluation defined
by splitting this into separate statements:
What is the purpose of this? I.e. why is it important that these notices
would be prod
Hi all,
- Original Message -
From: "Yasuo Ohgaki"
Sent: Tuesday, June 09, 2015
Hi all,
On Tue, Jun 9, 2015 at 6:21 AM, Stanislav Malyshev
wrote:
> Would throwing a notice or a warning on array deferencing scalars
> be acceptable for PHP 7.0, or does this need an RFC?
I think this d
Hi all,
- Original Message -
From: "Christoph Becker"
Sent: Tuesday, June 09, 2015
Yasuo Ohgaki wrote:
I fully agree that current behavior could be used meaningful ways.
However,
NULL
$v = NULL;
$v[0][1][2][3][4][5][6][7][8][9]; // NULL
this code is semantically wrong and I wou
Hi all,
- Original Message -
From: "Sara Golemon"
Sent: Monday, May 11, 2015
On Mon, May 11, 2015 at 5:12 PM, Matt Wilmas
wrote:
- Original Message -
From: "Stanislav Malyshev"
Sent: Monday, May 11, 2015
argument. I'd like to propose making the or
Hi Sara,
- Original Message -
From: "Sara Golemon"
Sent: Wednesday, June 10, 2015
On Tue, Jun 9, 2015 at 6:05 AM, Matt Wilmas
wrote:
Hah, looks like this just changed last week after barely 3 weeks. :-P I
didn't verify, just noticed the code change:
http://git.php.net
Hi Dmitry,
- Original Message -
From: "Dmitry Stogov"
Sent: Wednesday, June 10, 2015
Hi Sara,
https://gist.github.com/dstogov/6a90601872b538d2ddd6
I see no problems committing this (running tests now).
Cool. :-) Just FYI, I noticed you didn't update ZEND_BOOL_XOR, at least...
Tha
Hi Dmitry,
- Original Message -
From: "Dmitry Stogov"
Sent: Tuesday, June 16, 2015
Commit:48ed660cdf6fe94ac2cd8eac217ea97340766e75
Author:Dmitry Stogov Tue, 16 Jun 2015 14:11:16
+0300
Parents: 3180b8e100285e5bd9088e9981608dfd14f6ff27
Branches: master
Link:
http://
Hi Dmitry, all,
- Original Message -
From: "Dmitry Stogov"
Sent: Wednesday, June 24, 2015
We should NOT use it everywhere. It'll lead to code bloat.
Thanks. Dmitry.
On Wed, Jun 24, 2015 at 12:21 PM, Ferenc Kovacs wrote:
On Wed, Jun 24, 2015 at 3:42 AM, Yasuo Ohgaki wrote:
> Hi all
Hi Dmitry, all,
- Original Message -
From: "Dmitry Stogov"
Sent: Thursday, June 25, 2015
On Wed, Jun 24, 2015 at 1:35 PM, Matt Wilmas
wrote:
Hi Dmitry, all,
- Original Message -
From: "Dmitry Stogov"
Sent: Wednesday, June 24, 2015
We should NOT use
Hi Levi,
- Original Message -
From: "Levi Morrison"
Sent: Wednesday, June 24, 2015
On Wed, Jun 24, 2015 at 3:21 AM, Ferenc Kovacs wrote:
On Wed, Jun 24, 2015 at 3:42 AM, Yasuo Ohgaki wrote:
Hi all,
I'm wondering the state of Fast ZPP.
https://wiki.php.net/rfc/fast_zpp
Last year's
Hello RMs, all!
- Original Message -
From: "Kalle Sommer Nielsen"
Sent: Thursday, June 25, 2015
Howdy
This is a quick heads up that we plan to have the next release of
7.0.0 be Beta 1, this marks a feature freeze and from there on, we
will switch focus on to stabilization, regressions
Hi again Dmitry, all,
- Original Message -
From: "Dmitry Stogov"
Sent: Monday, June 29, 2015
On Sat, Jun 27, 2015 at 12:36 AM, Matt Wilmas
wrote:
Hi Dmitry, all,
[...]
Yeah, I knew how the traditional ZPP worked, just wondered about any
certain "problem area.&quo
Hi Anatol,
- Original Message -
From: "Anatol Belski"
Sent: Monday, July 07, 2015
Hi Matt,
-Original Message-----
From: Matt Wilmas [mailto:php_li...@realplain.com]
Sent: Tuesday, July 7, 2015 4:10 AM
To: Internals; Kalle Sommer Nielsen
Cc: Anatoliy Belsky; Dmitry Stog
Hi all,
- Original Message -
From: "Levi Morrison"
Sent: Sunday, May 10, 2015
Again, this is a C11 feature. It is supported by clang, gcc and MSVC.
To clarify this a bit: they permit anonymous unions in C89 and C99
code (meaning you do not need to pass flags like -std=c11 to enable
it
Hi Kalle,
- Original Message -
From: "Kalle Sommer Nielsen"
Sent: Wednesday, July 08, 2015
Hi Matt
2015-07-08 17:00 GMT+02:00 Matt Wilmas :
Hi all,
- Original Message -
From: "Levi Morrison"
Sent: Sunday, May 10, 2015
Again, this is a C11 feature. It i
Hi again Dmitry, all,
Hopefully the final update on this, before all is revealed... :-)
- Original Message -
From: "Matt Wilmas"
Sent: Tuesday, July 07, 2015
Hi again Dmitry, all,
[...]
Just an update... I didn't abandon this; quite the opposite! I thought
I
Hi Dmitry, Bogdan,
- Original Message -
From: "Dmitry Stogov"
Sent: Thursday, July 30, 2015
Hi Bogdan,
On Wed, Jul 29, 2015 at 5:22 PM, Andone, Bogdan
wrote:
Hi Guys,
My name is Bogdan Andone and I work for Intel in the area of SW
performance analysis and optimizations.
We would li
Hi Anatol,
- Original Message -
From: "Anatol Belski"
Sent: Friday, July 31, 2015
Commit:3a66a23679487f4feda699ada109ab2b675e9474
Author:Anatol Belski Fri, 31 Jul 2015 14:02:03
+0200
Parents: 7be9e69eafdb1828d09daecde5cd39112db3f581
Branches: master
Link:
http://g
Hi all,
- Original Message -
From: "Matt Wilmas"
Sent: Wednesday, July 08, 2015
Hi Kalle,
- Original Message -
From: "Kalle Sommer Nielsen"
Sent: Wednesday, July 08, 2015
Hi Matt
2015-07-08 17:00 GMT+02:00 Matt Wilmas :
Hi all,
- Original Messa
Hi Dmitry,
- Original Message -
From: "Dmitry Stogov"
Sent: Monday, August 03, 2015
Hi Matt,
On Wed, Jul 22, 2015 at 11:16 PM, Matt Wilmas
wrote:
Hi again Dmitry, all,
Hopefully the final update on this, before all is revealed... :-)
[...]
I tried to rush and finish
Hi Levi,
- Original Message -
From: "Levi Morrison"
Sent: Thursday, August 06, 2015
Don't know about Windows now... Visual Studio 2008 and 2012 (not much
difference) are NOT optimizing away the code (other times it was GCC with
issues). :-/ Not sure why. Of course they don't support
Hi Pierre,
- Original Message -
From: "Pierre Joye"
Sent: Thursday, August 06, 2015
On Aug 6, 2015 1:49 PM, "Matt Wilmas" wrote:
Hi Levi,
- Original Message -
From: "Levi Morrison"
Sent: Thursday, August 06, 2015
Don't know about Win
Hi Dmitry, all,
Help me understand this. :-) It's been more puzzling to me recently since
just coming to the part of optimizing traditional ZPP (sharing part with
FAST_ZPP...).
With the FAST_ZPP inline macros, why is there a Z_PARAM_ZVAL and
Z_PARAM_ZVAL_DEREF? It seems the zpp 'z' specifi
Hi again,
- Original Message -
From: "Matt Wilmas"
Sent: Tuesday, August 11, 2015
Hi Dmitry, all,
Help me understand this. :-) It's been more puzzling to me recently since
just coming to the part of optimizing traditional ZPP (sharing part with
FAST_ZPP...).
Wi
Hi Dmitry,
- Original Message -
From: "Dmitry Stogov"
Sent: Tuesday, August 11, 2015
Hi Matt,
On Tue, Aug 11, 2015 at 9:00 PM, Matt Wilmas
wrote:
Hi again,
- Original Message -----
From: "Matt Wilmas"
Sent: Tuesday, August 11, 2015
Hi Dmitry, all,
Hel
Hi Nikita,
- Original Message -
From: "Nikita Popov"
Sent: Tuesday, August 11, 2015
On Tue, Aug 11, 2015 at 10:10 PM, Matt Wilmas
wrote:
[...]
Look at e.g. is_numeric() or strpos() (needle). Plain zval param
parsing,
so NO ZVAL_DEREF() occurs (FAST_ZPP or traditional)
H Dmitry,
- Original Message -
From: "Dmitry Stogov"
Sent: Tuesday, August 11, 2015
On Tue, Aug 11, 2015 at 11:10 PM, Matt Wilmas
wrote:
[...]
Look at e.g. is_numeric() or strpos() (needle). Plain zval param
parsing,
so NO ZVAL_DEREF() occurs (FAST_ZPP or traditional)
Hi Dmitry, all,
Has it been considered to use __attribute__((cold)) on, for example,
error-type functions? I happened to notice this part about it in the GCC
docs [1] a couple days ago: "The paths leading to calls of cold functions
within code are marked as unlikely by the branch prediction m
Hi Anatol, Jakub,
- Original Message -
From: "Jakub Zelenka"
Sent: Tuesday, August 18, 2015
On Tue, Aug 18, 2015 at 8:23 PM, Anatol Belski
wrote:
Hi Jakub,
> -Original Message-
> From: Jakub Zelenka [mailto:bu...@php.net]
> Sent: Tuesday, August 18, 2015 8:47 PM
> To: php-..
Hi Jakub,
- Original Message -
From: "Jakub Zelenka"
Sent: Tuesday, August 18, 2015
On Tue, Aug 18, 2015 at 9:48 PM, Matt Wilmas
wrote:
Hi Anatol, Jakub,
[...]
The checks with zend_long vars like key_length and iterations are
impossible when ZEND_LONG_MAX == INT_MAX (m
Hi Anatol,
- Original Message -
From: "Anatol Belski"
Sent: Tuesday, August 18, 2015
Hi Matt,
> [...]
>
> The checks with zend_long vars like key_length and iterations are
> impossible
> when ZEND_LONG_MAX == INT_MAX (most if not all 32-bit, I guess). So
> those
> checks should alr
Hi Anatol,
- Original Message -
From: "Anatol Belski"
Sent: Tuesday, August 18, 2015
Ok, got the idea now. But sizeof(size_t) is always >
sizeof(zend_long). And for signed, still it is simpler and safer to
just use an #ifdef around.
No, == like I said. :-) OK, just saw your correcti
D_NORETRUN_ALIAS"
instead of NORETURN.
[1] https://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html
Thanks. Dmitry.
Thanks,
Matt
On Mon, Aug 17, 2015 at 1:26 PM, Matt Wilmas
wrote:
Hi Dmitry, all,
Has it been considered to use __attribute__((cold)) on, for example,
error-type functions?
ith the fastest/smallest
parameter parsing we could imagine, across all of PHP! I guess that means
start looking for it next week...? :-) I may just send a patch sooner
without even writing up an explanation about parts first like I planned.
More below...
- Original Message -----
Fro
Hi Anatol, Dmitry, all,
- Original Message -
From: "Anatol Belski"
Sent: Friday, August 21, 2015
Hi,
Resending this as missed internals at the start.
I was lately rethinking some part of the 64-bit RFC, and also seeing now
Jakub's work on catching overflows in ext/openssl and Matt Wil
ssage-----
From: Matt Wilmas [mailto:php_li...@realplain.com]
Sent: Tuesday, August 25, 2015 12:06 PM
To: Anatol Belski ; 'Dmitry Stogov'
;
'Xinchen Hui' ; 'Nikita Popov'
;
'Pierre Joye' ; 'Bob Weinand'
; 'Jakub Zelenka'
Cc: inter
Hi Anatol :-),
Just wanted to point out that those conditions (non-0 macros, of course)
should use UNEXPECTED(), so their code block can be moved "out of the way."
(May already be happening with a "return" involved.)
Although now, IF php_error_docref is involved, that *should* implicitly
hap
Hi Yasuo,
- Original Message -
From: "Yasuo Ohgaki"
Sent: Friday, September 18, 2015
Hi all,
On Fri, Sep 4, 2015 at 9:41 AM, Yasuo Ohgaki wrote:
IEEE 754 double cannot express exact float values. That said,
float values expressed by json/serialize/var_export/echo/print
are not precis
Hi Dmitry,
Just curious about this. :-) For dispatching next opcode, isn't a tail call
an indirect jmp instruction, just like a computed goto? So how is it
different than GOTO executor...? Debugging/compatibility? (Unless it can
work with MSVC -- oh nevermind, looks like it's only with glo
Hi,
- Original Message -
From: "Andrea Faulds"
Sent: Friday, November 13, 2015
Hi,
lp_benchmark_ro...@intel.com wrote:
---
benchmark relative change since change
si
Hi Dmitry, Anatol, Pierre (etc.), and all,
I'm back now, I think, after a much longer (unintentional) break than I
expected. Be coming very soon with what I was doing in the summer (param
parsing stuff) -- *now* it works with MSVC too, barring any fragility, as I
accidentally discovered last
Hi Anatol,
- Original Message -
From: "Anatol Belski"
Sent: Monday, November 16, 2015
Hello Matt,
-Original Message-----
From: Matt Wilmas [mailto:php_li...@realplain.com]
Sent: Sunday, November 15, 2015 11:31 PM
To: internals@lists.php.net; internals-...@lists.php.net
Hi Anatol, Dmitry, all,
Will reply about the original subject issues soon, but this is about new
stuff I noticed the other day... Adding Matt Tait and Nikita because of PR
#1418 and comments.
Anyway, the new Control Flow Guard (/guard:cf) is causing a big slowdown on
bench.php. :-( 14% on
Hi Dmitry,
- Original Message -
From: "Dmitry Stogov"
Sent: Monday, November 16, 2015
Hi Matt,
On Mon, Nov 16, 2015 at 1:30 AM, Matt Wilmas
wrote:
Hi Dmitry, Anatol, Pierre (etc.), and all,
I'm back now, I think, after a much longer (unintentional) break than
Hi Anatol, all,
- Original Message -
From: "Anatol Belski"
Sent: Monday, November 16, 2015
Hi Matt,
-Original Message-----
From: Matt Wilmas [mailto:php_li...@realplain.com]
Sent: Monday, November 16, 2015 2:59 PM
To: Anatol Belski ; internals@lists.php.net;
int
Hi Anatol,
- Original Message -
From: "Anatol Belski"
Sent: Wednesday, November 25, 2015
Hi Matt,
-Original Message-----
From: Matt Wilmas [mailto:php_li...@realplain.com]
Sent: Monday, November 23, 2015 8:15 AM
To: Anatol Belski ; internals@lists.php.net;
int
e across stuff while doing other things, otherwise maybe I would
have discovered this sooner!
-Original Message-----
From: Matt Wilmas [mailto:php_li...@realplain.com]
Sent: Monday, November 23, 2015 2:28 AM
To: internals@lists.php.net; internals-...@lists.php.net
Cc: Dmitry Stogov ; Anat
Hi Bob, all,
After this commit:
http://git.php.net/?p=php-src.git;a=commitdiff;h=509712c7d9056b4ceb50134bfeea1a1115720744
In streamsfuncs.c, line 996 has an extra comma; and line 1511 has #ifdef
instead of #ifndef ...
BTW, maybe with the changes I'll propose, all this extra FAST_ZPP stuff
Hi,
- Original Message
From: "Andrea Faulds"
Sent: Monday, December 07, 2015
Hi Matt,
Matt Wilmas wrote:
Hi Bob, all,
After this commit:
http://git.php.net/?p=php-src.git;a=commitdiff;h=509712c7d9056b4ceb50134bfeea1a1115720744
In streamsfuncs.c, line 996 has an extra
Hi all,
Lior, which compiler are you using? You can still reproduce the problem?
Can you run it through Valgrind?
I'm getting random crashes I can't figure out on 64-bit Linux after just
making a very trivial change. :-/ The backtrace is the same up to
compile_file() (although maybe that d
Hi Dmitry!
- Original Message -
From: "Dmitry Stogov"
Sent: Tuesday, December 22, 2015
Hi Matt,
On Tue, Dec 22, 2015 at 8:36 PM, Matt Wilmas
wrote:
Hi all,
Lior, which compiler are you using? You can still reproduce the problem?
Can you run it through Valgrind?
I
Hi Dmitry,
- Original Message -
From: "Dmitry Stogov"
Sent: Tuesday, March 22, 2016
Commit:d8b75b0807a5d94bd7b6b175d56aba8bc5be8d7a
Author:Dmitry Stogov Tue, 22 Mar 2016
23:57:26 +0300
Parents: 76d612129bb6b67171308f43c19d7e4791d7919e
Branches: master
Link:
http:
Hi Yasuo,
- Original Message -
From: "Yasuo Ohgaki"
Sent: Tuesday, March 22, 2016
Hi all,
On Fri, Mar 18, 2016 at 9:30 PM, wrote:
---
benchmark relative change since
Hi Dmitry,
- Original Message -
From: "Dmitry Stogov"
Sent: Wednesday, April 20, 2016
Hi,
It's a well known PHP problem, that exceeding of execution time-out
(max_execution_time) may lead to unexpected crashes.
They occur because PHP may be interrupted in inconsistent state, and
att
Hi Bob, all,
- Original Message
From: "Bob Weinand"
Sent: Wednesday, April 20, 2016
> Am 20.04.2016 um 18:22 schrieb Dmitry Stogov :
>
>
>
> On 04/20/2016 06:24 PM, Matt Wilmas wrote:
>> Hi Dmitry,
>>
>> - Original Message -
>>
Hi Bogdan, all,
- Original Message -
From: "Andone, Bogdan"
Sent: Monday, April 25, 2016
-Original Message-
From: Andone, Bogdan [mailto:bogdan.and...@intel.com]
Sent: Friday, March 18, 2016 11:58 AM
To: 'Nikita Popov'
Cc: internals@lists.php.net
Subject: RE: [PHP-DEV] Lazy key
Hi all,
Last June, it was briefly mentioned about changing PHP's string hash
function [1] (DJB33 *seems* pretty horrible, after all, as far as
collisions...). So 8 months ago I tried almost, if not, a half-dozen of
them (including Murmur3) that were simple enough to quickly toss in.
The result?
Now, after seeing Bogdan's hash optimization idea last month [2], and
reading Nikita's blog post [3] again, I had some ideas I'd like to try --
assuming nobody else is planning major changes. :-) Besides Nikita, I'm
addressing Dmitry and Xinchen because your names are on some minor hash
items on
Hi all,
- Original Message -
From:
Sent: Friday, August 05, 2016
Results for project PHP master, build date 2016-08-05 06:26:56+03:00
commit: 65b6f20
previous commit: 69a72df
revision date: 2016-08-04 22:27:42+02:00
environment: Haswell-EP
cpu: Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz
Hi Stas, all!
- Original Message -
From: "Stas Malyshev"
Sent: Thursday, August 28, 2014
Hi!
5.6.0 has been released, and first thing I'd like to congratulate all
who participated in it with this great milestone.
Second thing, that means 5.4.33 would be the last release including
non-
Hi all!
I'm back after several years, and will have a few more changes for Windows,
at least. (It was CVS back then, so I still have to figure some things
out... Just had to edit files on Github site. :-/)
Anyway, this patch is for microtime, etc. on Windows XP-7. In March 2013,
the fix f
Hi Stas!
- Original Message -
From: "Matt Wilmas"
Sent: Friday, August 29
Hi Stas, all!
- Original Message -
From: "Stas Malyshev"
Sent: Thursday, August 28, 2014
Hi!
5.6.0 has been released, and first thing I'd like to congratulate all
who par
Hi Stas,
- Original Message -
From: "Stas Malyshev"
Sent: Monday, September 01, 2014
Hi!
It's much more optimized than what's there now, and slightly over the old
implementation. Not sure if I should give the saved patch link, or the
"live compare" (?) on Github, so I'll do both for
Hi Stas,
- Original Message -
From: "Stas Malyshev"
Sent: Monday, September 01, 2014
Hi!
I'm also not sure how important it is how have it for 5.4. Does the
problem that this patch fixes exist only in older versions of Windows or
on all versions? What are the actual effects of this pr
Hi Dmitry, all,
I was looking through a few parts of the new MM last week (cool, thanks! I
will try soon on my Windows XP), and wasn't sure about the function in the
subject...
This:
/* higher set bit number (0->0, 1->1, 2->2, 4->3, 8->4, 127->7, 128->8 etc)
*/
static zend_always_inline in
Hi Anatol!
- Original Message -
From: "Anatol Belski"
Sent: Tuesday, September 02, 2014
Hi Matt,
On Mon, September 1, 2014 20:36, Matt Wilmas wrote:
Hi all!
I'm back after several years, and will have a few more changes for
Windows,
at least. (It was CVS back then,
Hi Anatol, Stas,
- Original Message -
From: "Anatol Belski"
Sent: Tuesday, September 02, 2014
On Mon, September 1, 2014 22:49, Stas Malyshev wrote:
Hi!
It's much more optimized than what's there now, and slightly over the
old implementation. Not sure if I should give the saved patc
Hi Anatol,
- Original Message -
From: "Anatol Belski"
Sent: Tuesday, September 02, 2014
Unfortunately that's not a PR so I cannot comment there directly, so I'd
leave a couple of the comments to the code here:
It looks like there can be "commit comments?" *shrug* In the future, shoul
Hi Anatol, all,
Sorry for top post... Stas must be getting confused with all these details!
:-) Is Pierre going to weigh in? Are there any other Windows people?
While I don't think I'd disagree with much of what you've said, I don't see
that using my patch is *causing* or *creating* new is
Hi Nuno,
Late reply, but I'm glad the idea was able to be used. :-)
To the other hash people: While checking how Ilia made implode() faster in
5.2, I think I found another optimization that can be done. In
zend_hash_copy/merge, it seems the zend_hash_quick_* functions can be used
instead for as
Hi (Dmitry?),
See Bug #33282 -- I saw it in the Bug Summary; don't know if there are other
related ones... Same applies to foreach ($arr ... &$v) which is where I
noticed it last week with var_dump($arr). All elements that WERE referenced
but aren't anymore still have is_ref=1 (when refcount=1).
- Original Message -
From: "Michael Wallner"
Sent: Tuesday, November 07, 2006
> Matt Wilmas wrote:
> > Hi (Dmitry?),
> >
> > See Bug #33282 -- I saw it in the Bug Summary; don't know if there are
other
> > related ones... Same applies
Hi Arnold,
zend_hash_find() is always returning FAILURE because its "key_length"
parameter *includes* the terminating '\0'. :-) So you need strlen(key) + 1.
BTW, are any of your keys going to have numeric values ([123] sections
etc.)? Then you'll also have a problem with hash_find() as it doesn
Hi,
Here's an additional ZEND_SIGNED_MULTIPLY_LONG() for platforms with 32-bit
longs that don't use the assembly version (so all Windows systems at
least?). On my Windows system, mul_function() is 40% faster with this
version (no overflow), which makes PHP's * operator 20% faster; with
overflow m
Hi Nuno,
- Original Message -
From: "Nuno Lopes"
Sent: Thursday, November 09, 2006
> Great patch! From my quick tests I got about 35% performance increase.
> Ah, it needs a little tweak to work on windows, as 'long long' is defined
as
> __int64 (probably we could do a typedef once for al
- Original Message -
From: "Stanislav Malyshev"
Sent: Thursday, November 09, 2006
> > Did it not work for you as-is on Windows...? It did for me, since it
seems
> > there's already a typedef for __int64 -> long long. I'd wondered the
same,
>
> I think some VC versions on windows don't kn
Hi Andi,
- Original Message -
From: "Andi Gutmans"
Sent: Wednesday, November 08, 2006
> Nice patch! Looks good to me... Any other thoughts?
Since I don't have a *nix system to test on, I was wondering how my version
compares to the assembly one. But I guess the latter is still fastest w
Hi Andrei, et al.,
I was just looking at README.UNICODE, regarding interpretation of numbers:
"we restrict numbers to consist only of ASCII digits," and "Numeric strings
are supposed to adhere to the same rules." Is it correct to take that to
mean only UChar's with values from '0'-'9'/0x30-0x39 (
Hi Antony,
- Original Message -
From: "Antony Dovgal"
Sent: Friday, November 10, 2006
> Hello all.
>
> I would like to propose a replacement for current zend_u_strtod()
implementation.
> The patch: http://tony2001.phpclub.net/dev/tmp/u_strtod.diff
>
> According to my tests, new implementa
Hi Andrei,
All right, glad I checked. I had a few things in mind to optimize
is_numeric_string/unicode, and it's fairly straightforward in _string, but
would just make things slower if u_* functions were needed to do the same in
_unicode, so I was going to rethink it. Now whatever I come up with
Hi Antony,
- Original Message -
From: "Antony Dovgal"
Sent: Friday, November 10, 2006
> On 11/10/2006 02:14 PM, Matt Wilmas wrote:
> > Hi Antony,
> >
> > - Original Message -
> > From: "Antony Dovgal"
> > Sent: Friday, Novembe
Hi all,
This is regarding Derick's addition of the (binary) cast in 5.2, and its
discussion. I agree with the others who think it's a good addition so
future code for PHP 6 won't fail with a parse error on a small thing that
could be handled transparently.
But the point of this message is to ask
Hi Antony!
Wow, lots of testing ya did there. :-) Nice. But, just wanted to mention
that "Matt's patch" is the one I did back in Aug. Did you see my last
message [1] the other day with a new version that only checks for ASCII
chars, doesn't do conversion from Unicode, etc.?
http://realplain.com
vgal"
Sent: Friday, November 17, 2006
> On 11/17/2006 06:26 PM, Matt Wilmas wrote:
> > Hi Antony!
> >
> > Wow, lots of testing ya did there. :-) Nice. But, just wanted to
mention
> > that "Matt's patch" is the one I did back in Aug. Did you see my last
&
-
From: "Antony Dovgal"
Sent: Friday, November 17, 2006
> On 11/17/2006 06:52 PM, Matt Wilmas wrote:
> > [...]
> > http://realplain.com/php/zend_u_strtod-v2.diff
>
>
Hi Andrei,
One more related question: What about for any leading whitespace with
numeric strings, like in zend_u_strtol()? Is u_isspace() needed, or are
only the ASCII-equivalents (0x20, 9-13 [\t, \n, \v, \f, \r]) allowed?
Thanks again,
Matt
- Original Message -
From: "Andrei Zmievski
Hi Alexey,
Not sure what the exact problem is, or if this is related, but in your
loc_set() function's zend_hash_add() calls, you have sizeof(HashTable) and
sizeof(zval). Shouldn't both of those be sizeof(HashTable *) ? :-)
Matt
- Original Message -
From: "Alexey Zakhlestin"
Sent: Sa
Hi Alexey,
- Original Message -
From: "Alexey Zakhlestin"
Sent: Sunday, December 03, 2006
> On 12/3/06, Matt Wilmas <[EMAIL PROTECTED]> wrote:
> > Hi Alexey,
> >
> > Not sure what the exact problem is, or if this is related, but in your
> > loc_
Hi Alexey,
Whoops! Ugh, I was looking at the first param of zend_hash_add(). :-O
You're correct then, sorry! :-/
Matt
- Original Message -
From: "Alexey Zakhlestin"
Sent: Sunday, December 03, 2006
> first zend_hash_add adds ns_ht, so it is (HashTable *)
> second zend_hash_add adds p_v
1 - 100 of 229 matches
Mail list logo
