Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-26 Thread Alex Wells
On Fri, Apr 26, 2024 at 11:01 AM Benjamin Außenhofer wrote: > After discussing with Mate shortly one reason for adding $since from a PHP > project POV is that we do show the $since information in the generated > documentation output. > > Integrating with the work in progress to auto generate part

Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-26 Thread Stephen Reay
Sent from my iPhone > On 26 Apr 2024, at 22:06, Rowan Tommins [IMSoP] wrote: > >  > >> On 26 April 2024 09:40:57 BST, Mike Schinkel wrote: >> >> Given a lack of agreed definition for 'since' it appears you are using >> narrow assumptions about the meaning of 'since' that led you to view '

Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-26 Thread Rowan Tommins [IMSoP]
On 26 April 2024 09:40:57 BST, Mike Schinkel wrote: >Given a lack of agreed definition for 'since' it appears you are using narrow >assumptions about the meaning of 'since' that led you to view 'since' as >useless. I can't see any ambiguity in the definition: "This function has been depreca

Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-26 Thread Mike Schinkel
> On Apr 25, 2024, at 5:47 PM, Rowan Tommins [IMSoP] > wrote: > I think you missed the context of that sentence - or I'm missing something in > yours. I meant specifically that the "deprecated since" information is > useless if there's no published policy on how long something will stay > depr

Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-26 Thread Benjamin Außenhofer
On Tue, Apr 23, 2024 at 7:27 PM Levi Morrison wrote: > On Tue, Apr 23, 2024 at 7:30 AM Benjamin Außenhofer > wrote: > > > > Hi internals, > > > > My PR for #[\Deprecated] attribute was in hibernation for a long while > now and after some off-list discussion a few weeks ago I have decided to > re

Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-25 Thread Rowan Tommins [IMSoP]
On 25 April 2024 22:01:35 BST, Mike Schinkel wrote: >> On Apr 25, 2024, at 11:28 AM, Rowan Tommins [IMSoP] >> wrote: >> If the project has no clear deprecation policy, the information is useless >> anyway. > >Not true. > >Having standardized notation for deprecation would allow tooling to an

Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-25 Thread Mike Schinkel
> On Apr 25, 2024, at 11:28 AM, Rowan Tommins [IMSoP] > wrote: > If the project has no clear deprecation policy, the information is useless > anyway. Not true. Having standardized notation for deprecation would allow tooling to analyze a codebase and determine if it contains deprecated code t

Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-25 Thread Rowan Tommins [IMSoP]
On 25/04/2024 08:40, Stephen Reay wrote: If you're on X.y and it says it was deprecated in X.w you know you don't need to worry about it being removed until at least Y.a. Yeah, that's the reasoning given in the Rust discussion, but I don't find it convincing. If the project's deprecation po

Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-25 Thread Stephen Reay
Sent from my iPhone > On 25 Apr 2024, at 16:26, Rowan Tommins [IMSoP] wrote: > > On 24 April 2024 18:18:28 BST, Jorg Sowa wrote: >> What about setting this parameter vaguely as the boolean we can pass? >> ... >> #[Deprecated(since: $packageVersion > 5.5)] >> #[Deprecated(since: PHP_VERSION_ID

Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-24 Thread Rowan Tommins [IMSoP]
On 24 April 2024 18:18:28 BST, Jorg Sowa wrote: > What about setting this parameter vaguely as the boolean we can pass? > ... > #[Deprecated(since: $packageVersion > 5.5)] > #[Deprecated(since: PHP_VERSION_ID > 80100)] > #[Deprecated(since: date("Y-m-d") > "2024-01-21")] Even if these expression

Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-24 Thread Benjamin Außenhofer
On Wed, Apr 24, 2024 at 7:18 PM Jorg Sowa wrote: > I like the proposition and I like the idea of $since parameter, however, > this option is too ambiguous about what should store. Should it store the > PHP version, package version, or the date? > > What about setting this parameter vaguely as the

Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-24 Thread Jorg Sowa
I like the proposition and I like the idea of $since parameter, however, this option is too ambiguous about what should store. Should it store the PHP version, package version, or the date? What about setting this parameter vaguely as the boolean we can pass? #[Attribute(Attribute::TARGET_METHOD

Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-24 Thread Benjamin Außenhofer
On Wed, Apr 24, 2024 at 2:55 PM Lynn wrote: > > > On Tue, Apr 23, 2024 at 3:30 PM Benjamin Außenhofer > wrote: > >> Hi internals, >> >> My PR for #[\Deprecated] attribute was in hibernation for a long while >> now and after some off-list discussion a few weeks ago I have decided to >> revisit it

Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-24 Thread Benjamin Außenhofer
On Wed, Apr 24, 2024 at 3:57 PM Nicolas Grekas wrote: > Hi Benjamin, > > My PR for #[\Deprecated] attribute was in hibernation for a long while now >> and after some off-list discussion a few weeks ago I have decided to >> revisit it and asked Tim to help me out with the work. >> >> Tim has clean

Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-24 Thread Nicolas Grekas
Hi Benjamin, My PR for #[\Deprecated] attribute was in hibernation for a long while now > and after some off-list discussion a few weeks ago I have decided to > revisit it and asked Tim to help me out with the work. > > Tim has cleaned up the PR quite a bit and also worked in additional > features

Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-24 Thread Lynn
On Tue, Apr 23, 2024 at 3:30 PM Benjamin Außenhofer wrote: > Hi internals, > > My PR for #[\Deprecated] attribute was in hibernation for a long while now > and after some off-list discussion a few weeks ago I have decided to > revisit it and asked Tim to help me out with the work. > > Tim has cle

Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-24 Thread Larry Garfield
On Wed, Apr 24, 2024, at 4:01 AM, Benjamin Außenhofer wrote: > On Tue, Apr 23, 2024 at 7:27 PM Levi Morrison > wrote: >> On Tue, Apr 23, 2024 at 7:30 AM Benjamin Außenhofer >> wrote: >> > >> > Hi internals, >> > >> > My PR for #[\Deprecated] attribute was in hibernation for a long while now >>

Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-24 Thread Benjamin Außenhofer
On Tue, Apr 23, 2024 at 7:27 PM Levi Morrison wrote: > On Tue, Apr 23, 2024 at 7:30 AM Benjamin Außenhofer > wrote: > > > > Hi internals, > > > > My PR for #[\Deprecated] attribute was in hibernation for a long while > now and after some off-list discussion a few weeks ago I have decided to > re

Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-23 Thread Levi Morrison
On Tue, Apr 23, 2024 at 7:30 AM Benjamin Außenhofer wrote: > > Hi internals, > > My PR for #[\Deprecated] attribute was in hibernation for a long while now > and after some off-list discussion a few weeks ago I have decided to revisit > it and asked Tim to help me out with the work. > > Tim has

[PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-23 Thread Benjamin Außenhofer
Hi internals, My PR for #[\Deprecated] attribute was in hibernation for a long while now and after some off-list discussion a few weeks ago I have decided to revisit it and asked Tim to help me out with the work. Tim has cleaned up the PR quite a bit and also worked in additional features such as