Re: [PHP-DEV] [RFC] [Discussion] Implement SQLite "openBlob" feature in PDO

2017-10-01 Thread BohwaZ
On Wed, 27 Sep 2017 11:47:21 +0200 / Matteo Beccati said : > On 27/09/2017 11:34, Lester Caine wrote: > > openBlob is a specific feature of SQLite so the decision to use it > > already rules out any other database. IN PDO access to it via the > > generic blob functions is the

Re: [PHP-DEV] [RFC] [Discussion] Implement SQLite "openBlob" feature in PDO

2017-09-30 Thread BohwaZ
On Wed, 27 Sep 2017 09:47:51 +0100 / Dan Ackroyd said : > On 26 September 2017 at 03:03, BohwaZ/PHP wrote: > > Kia ora, > > > > https://wiki.php.net/rfc/implement_sqlite_openblob_in_pdo > > > Couple of questions: > > > $stream =

Re: [PHP-DEV] [RFC] [Discussion] Implement SQLite "openBlob" feature in PDO

2017-09-27 Thread Matteo Beccati
On 27/09/2017 11:34, Lester Caine wrote: > openBlob is a specific feature of SQLite so the decision to use it > already rules out any other database. IN PDO access to it via the > generic blob functions is the proper way forward so that a call for a > blob gives a blob what ever the underlying

Re: [PHP-DEV] [RFC] [Discussion] Implement SQLite "openBlob" feature in PDO

2017-09-27 Thread Lester Caine
On 27/09/17 10:17, Matteo Beccati wrote: > On 27/09/2017 11:00, Lester Caine wrote: >> The bigger question is - Should database specific extensions to PDO be >> allowed at all? The WHOLE base of PDO was that it would allow easy data >> management between DIFFERENT databases. This should be

Re: [PHP-DEV] [RFC] [Discussion] Implement SQLite "openBlob" feature in PDO

2017-09-27 Thread Matteo Beccati
Hey Marco, On 27/09/2017 11:04, Marco Pivetta wrote: > First time I agree with Lester here, so please take note :-P Anything you say can and will be used against you ;-) > Unless the type of the connection is PDOSQLiteConnection, this specific > patch adds methods that are not interfaced, and

Re: [PHP-DEV] [RFC] [Discussion] Implement SQLite "openBlob" feature in PDO

2017-09-27 Thread Matteo Beccati
Hi Lester, On 27/09/2017 11:00, Lester Caine wrote: > The bigger question is - Should database specific extensions to PDO be > allowed at all? The WHOLE base of PDO was that it would allow easy data > management between DIFFERENT databases. This should be implemented in a > way that mirrors blobs

Re: [PHP-DEV] [RFC] [Discussion] Implement SQLite "openBlob" feature in PDO

2017-09-27 Thread Marco Pivetta
On Wed, Sep 27, 2017 at 11:00 AM, Lester Caine wrote: > On 27/09/17 09:47, Dan Ackroyd wrote: > >> https://wiki.php.net/rfc/implement_sqlite_openblob_in_pdo > > > > Couple of questions: > > > >> $stream = $pdo->sqliteOpenBlob('test', 'data', 1); > > I tried reading the code

Re: [PHP-DEV] [RFC] [Discussion] Implement SQLite "openBlob" feature in PDO

2017-09-27 Thread Lester Caine
On 27/09/17 09:47, Dan Ackroyd wrote: >> https://wiki.php.net/rfc/implement_sqlite_openblob_in_pdo > > Couple of questions: > >> $stream = $pdo->sqliteOpenBlob('test', 'data', 1); > I tried reading the code but failed; what happens when this is called > on a PDO connection that isn't to an

Re: [PHP-DEV] [RFC] [Discussion] Implement SQLite "openBlob" feature in PDO

2017-09-27 Thread Dan Ackroyd
On 26 September 2017 at 03:03, BohwaZ/PHP wrote: > Kia ora, > > https://wiki.php.net/rfc/implement_sqlite_openblob_in_pdo Couple of questions: > $stream = $pdo->sqliteOpenBlob('test', 'data', 1); I tried reading the code but failed; what happens when this is called on a PDO

Re: [PHP-DEV] [RFC] [Discussion] Implement SQLite "openBlob" feature in PDO

2017-09-27 Thread Adam Baratz
> > following my patch and discussions on this list, here is the RFC requested > by some people here to implement "openBlob" in the pdo_sqlite driver, to > match the "openBlob" method from the SQLite3 extension. Thanks for taking the time to do the writeup. No objections from me. Adam

[PHP-DEV] [RFC] [Discussion] Implement SQLite "openBlob" feature in PDO

2017-09-25 Thread BohwaZ/PHP
Kia ora, following my patch and discussions on this list, here is the RFC requested by some people here to implement "openBlob" in the pdo_sqlite driver, to match the "openBlob" method from the SQLite3 extension. https://wiki.php.net/rfc/implement_sqlite_openblob_in_pdo Discussion should